Commit Graph

7 Commits

Author SHA1 Message Date
Quan Tian
16a7b53602 Fix typos in comments
Signed-off-by: Quan Tian <qtian@vmware.com>
2023-08-30 23:56:47 +08:00
Quan Tian
2b69daa960 Allow specifying ExternalTrafficPolicy for ClusterIP Services with ExternalIPs
When defining a ClusterIP Service, we can specify externalIP, and the
traffic policy of externalIP is subject to externalTrafficPolicy.
However, the policy can't be set when type is not NodePort or
LoadBalancer, and will default to Cluster when kube-proxy processes the
Service.

This commit updates the defaulting and validation of Service to allow
specifying ExternalTrafficPolicy for ClusterIP Services with
ExternalIPs.

Signed-off-by: Quan Tian <qtian@vmware.com>
2023-08-30 23:56:47 +08:00
Wojciech Tyczyński
3b98f59e16 Clean shutdown of service integration tests 2022-05-26 16:20:56 +02:00
Wojciech Tyczyński
deef9e40de Simplify Create/Delete-TestingNamespace functions 2022-05-15 23:06:26 +02:00
Andrew Sy Kim
aead636249 add integration test validating that converting a Service to ExternalName results in the field being dropped on read
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2022-01-05 12:41:53 -05:00
Andrew Sy Kim
9c3c3d8a3a add integration test to validate that ExternalName Services can set internalTrafficPolicy, but the field is dropped on read
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2022-01-05 12:41:53 -05:00
Andrew Sy Kim
7aa20122bc add integration test to check that Service internalTrafficPolicy is no longer defaulting when Type is ExternalName
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2022-01-05 12:41:53 -05:00