Commit Graph

6422 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
31a482a149 Merge pull request #120344 from rohitssingh/disable_force_detach
Add a flag to disable force detach behavior in kube-controller-manager
2024-02-22 13:02:38 -08:00
Rohit Singh
13dddca6a2 Add "disable-force-detach-on-timeout" flag to kube-controller-manager 2024-02-22 18:31:52 +00:00
Kubernetes Prow Robot
47f92ce231 Merge pull request #123242 from mimowo/fast-backoff-for-replacment-policy-tests
Improve accuracy of the PodsCreationTotal metric and use fast pod failure backoff for ReplacementPolicy integration tests
2024-02-15 09:54:53 -08:00
Michal Wozniak
f84d643c20 Use the Defer for pod replacement policy 2024-02-15 17:37:31 +01:00
Michal Wozniak
115dc90633 Increase accuracy of the pods_creation_total metric and improve test exec time 2024-02-15 10:59:01 +01:00
Kubernetes Prow Robot
68bbbd0359 Merge pull request #123300 from antoninbas/nodeipam-controller-remove-unused-field
Remove unused lookupIP field in NodeIPAM Controller struct
2024-02-14 17:00:13 -08:00
Kubernetes Prow Robot
684a9975fe Merge pull request #122919 from alexzielenski/apiserver/policy/mutating-initial
Refactor AdmissionPolicy for code sharing with mutating
2024-02-14 14:52:26 -08:00
Antonin Bas
75a3069294 Remove unused lookupIP field in NodeIPAM Controller struct
I am not sure why this was originally required, but it doesn't seem to
have been used for years.

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
2024-02-14 13:28:35 -08:00
Kubernetes Prow Robot
bd0e1e2d9e Merge pull request #121554 from kaisoz/fix-job-controller-panics
Check if time is nil before logging
2024-02-13 09:33:04 -08:00
Alexander Zielenski
8b14116509 refactor: move vap into parent policy folder
also renames to remove stutter

comment
2024-02-12 10:58:24 -08:00
Kubernetes Prow Robot
1fc510a969 Merge pull request #120688 from skitt/copy-instead-of-for-loop
Use copy() instead of a for loop
2024-02-05 08:44:40 -08:00
xigang
f589b911f8 node_controller: improve taint eviction queue add worker time args
Signed-off-by: xigang <wangxigang2014@gmail.com>
2024-01-30 10:18:59 +08:00
Kubernetes Prow Robot
0209c546fd Merge pull request #121824 from carlory/clean-112
adc remove stale comments
2024-01-29 14:13:17 -08:00
Kubernetes Prow Robot
9e34bac02a Merge pull request #119395 from carlory/patch-expand-001
getPersistentVolume remove reduant deep copy
2024-01-29 05:40:40 -08:00
Kubernetes Prow Robot
eb1ae05cf0 Merge pull request #122030 from carlory/121799
fix issue with using feature HonorPVReclaimPolicy in csi-provisioner
2024-01-19 04:35:48 +01:00
carlory
5ff42b2368 fix issue with using feature HonorPVReclaimPolicy in csi-provisioner 2024-01-17 10:57:30 +08:00
carlory
8af9a177b2 If a pvc has an empty storageclass name, don't try to assign a default StorageClass to it. 2024-01-13 21:25:43 +08:00
Tomas Tormo
9a3f1a3164 Avoid panics when logging a nil pod.deletionTimestamp 2024-01-12 15:34:44 +00:00
Kubernetes Prow Robot
c9158e9a19 Merge pull request #122595 from dims/support-building-with-and-without-cloud-providers
KUBE_PROVIDERLESS - Support building with and without cloud providers
2024-01-11 05:42:23 +01:00
Antonio Ojea
e46778a246 remove dead code
Change-Id: I8e1fd101ecb32436d82363c76fa84c476b171d52
2024-01-08 13:15:28 +00:00
Davanum Srinivas
b7012da2ad Remove providerless tag in controller_test.go
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2024-01-08 07:03:49 -05:00
Davanum Srinivas
7a236bd7e0 Add providerless tags appropriately in test/
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2024-01-07 08:16:05 -05:00
Kubernetes Prow Robot
f12529c2f2 Merge pull request #118756 from sxllwx/bugfix/cascade-ctx
namespace-controller: Correctly cascade ctx when making API calls
2024-01-04 17:58:45 +01:00
Kubernetes Prow Robot
5cf72fbfae Merge pull request #121713 from carlory/adc
adc remove redundant check
2023-12-28 21:47:19 +01:00
Kubernetes Prow Robot
755b4e2bc4 Merge pull request #121576 from huww98/opti-aswp
ad controller: optimize populateActualStateOfWorld
2023-12-19 17:43:45 +01:00
Kubernetes Prow Robot
2b5c0c281d Merge pull request #122310 from weilaaa/use_buildin_max_min_instead
use build-in max and min func to instead of k8s.io/utils/integer funcs
2023-12-18 19:25:34 +01:00
weilaaa
eb8f3f194f use build-in max and min func to instead of k8s.io/utils/integer funcs 2023-12-15 15:09:11 +08:00
Kubernetes Prow Robot
d687dc4772 Merge pull request #122261 from mimowo/unit-tests-for-job-controller-fix
Add unit test for Job Controller for panic when PodFailurePolicy is used on 1.28
2023-12-14 07:27:48 +01:00
Kubernetes Prow Robot
734fdc775c Merge pull request #122143 from ii2day/typo_registerCidrsetMetrics
Fix typos: update registerCidrsetMetrics to registerCIDRSetMetrics
2023-12-14 06:18:43 +01:00
Kubernetes Prow Robot
17823e00d1 Merge pull request #121935 from tenzen-y/job-use-builtin-integer
Job: Use built-in min function instead of integer package
2023-12-14 02:42:39 +01:00
Dejan Zele Pejchev
31710a799d fix: Refactor TestFinalizerCleanup unit test by asserting job and pod informer state (#121856)
* fix: change informer resync period in TestFinalizerCleanup unit test

* refactor TestFinalizerCleanup to avoid flakiness by asserting job and pod informer state

* minor cleanups in TestFinalizerCleanup test in job_controller_test.go

another minor cleanup in TestFinalizerCleanup test in job_controller_test.go

* reduce poll time to 10ms in TestFinalizerCleanup in job_controller_test.go when waiting for podStore cache to get updated

* remove a whitespace from TestFinalizerCleanup to keep diff smaller
2023-12-13 23:55:28 +01:00
Kubernetes Prow Robot
c24e8ee403 Merge pull request #121697 from carlory/clean-111
add comments for switch case of syncUnboundClaim
2023-12-13 22:35:00 +01:00
Kubernetes Prow Robot
89c314ed8b Merge pull request #121669 from xigang/daemonsetcontroller_eventhandler
node labels and taints do not change, node events shoule be ignored in daemonset controller.
2023-12-13 22:34:42 +01:00
Kubernetes Prow Robot
2f0aca1fc2 Merge pull request #121663 from carlory/clean-010
remove EventRecorder from ControllerParameters of pv base controller
2023-12-13 22:34:33 +01:00
Michal Wozniak
34bc590418 Add unit test for Job Controller for panic when PodFailurePolicy is used on 1.28 2023-12-11 11:08:46 +01:00
ii2day
4b1408c2e7 Fix typos: update registerCidrsetMetrics to registerCIDRSetMetrics
Signed-off-by: ii2day <ji.li@daocloud.io>
2023-12-04 10:09:52 +08:00
huweiwen
a3e27aa1ad ad controller: optimize populateActualStateOfWorld
Reduce overall complexity from O(n^2) to O(n)
Run time of the new benchmark is reduced from hours to 13s
2023-11-17 16:48:30 +08:00
huweiwen
854347ac81 ad controller populator: check for inUse sync in test 2023-11-17 16:48:30 +08:00
Yuki Iwai
a85f587984 Job: Use built-in min function instead of integer package
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2023-11-17 14:10:00 +09:00
carlory
4a4940694f remove stale comments 2023-11-09 11:58:50 +08:00
carlory
ae24846c48 add comments for switch of syncUnboundClaim 2023-11-08 17:15:27 +08:00
Kevin Hannon
2645b22003 Self nominate Kevin Hannon for reviewer for job controller
I have been lead the PodReplacementPolicy KEP for alpha and I helped review/fix some issues in beta.  

https://github.com/kubernetes/kubernetes/pulls?q=+is%3Apr+reviewed-by%3Akannon92+label%3Asig%2Fapps+

I have also been an active reviewer and helped GA job tracking last release.  I hope to continue reviewing Job related code.
2023-11-07 13:21:02 -05:00
carlory
957e9a7f1a adc remove redundant check 2023-11-03 16:17:39 +08:00
xigang
6b3476b79f node labels and taints do not change, node events are ignored in daemonset controller
Signed-off-by: xigang <wangxigang2014@gmail.com>
2023-11-02 17:53:44 +08:00
carlory
58236aa3eb remove EventRecorder from ControllerParameters of pv base controller 2023-11-01 17:54:00 +08:00
Antonio Ojea
3b69bd6a9b servicecidrs controller clarify condition false reevaluation
Change-Id: I0eb8d39abe9b7b0ce6472ff426e9a62e7155aae1
2023-10-31 21:05:58 +00:00
Antonio Ojea
3edcce52e3 service cidr controller manager: use new ServiceCIDR API 2023-10-31 21:05:50 +00:00
Antonio Ojea
599597ca65 fix race on ServiceCIDR deletion
When a ServiceCIDR is deleted, the service CIDR controller on the
controller manager verifies that is safe to be deleted before removing
the finalizer, howerver, since the information of deletion takes time to
propragate, there can be a race where the apiserver allocators didn't
receive the information of deletion and assign an IP address that will
be orphan.

To avoid this race, the service cidr controller waits a grace period
before removing the finalizer to ensure the allocators do not assign any
new IP Address from that range before is completely deleted.

Change-Id: Ib34d32c0bdde91c6e84f1d056db9374589b25c0b
2023-10-31 21:05:06 +00:00
Antonio Ojea
4ff80864e1 service cidr controller manager
Controls the lifecycle of the ServiceCIDRs adding finalizers and
setting the Ready condition in status when they are created, and
removing the finalizers once it is safe to remove (no orphan IPAddresses)

An IPAddress is orphan if there are no ServiceCIDR containing it.

Change-Id: Icbe31e1ed8525fa04df3b741c8a817e5f2a49e80
2023-10-31 21:05:05 +00:00
James Munnelly
76463e21d4 KEP-4193: bound service account token improvements 2023-10-30 21:15:10 +00:00