Commit Graph

116 Commits

Author SHA1 Message Date
Konstantinos Tsakalozos
e2399de900 Clean-up not needed method. 2018-02-15 17:01:52 +02:00
Kubernetes Submit Queue
f114f0e45c
Merge pull request #59837 from Cynerva/gkk/fix-auth-bootstrap-on-upgrade
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

juju: Fix broken ingress after upgrade-charm

**What this PR does / why we need it**:

This fixes a bug that prevents the ingress controller from being deployed after doing an `upgrade-charm`.

Essentially, `worker.auth.bootstrapped` gets cleared during `upgrade-charm`, and it never gets set again. This prevents the `start_worker` and `render_and_launch_ingress` handlers from running, among other things.

This PR fixes that.

**Release note**:

```release-note
NONE
```
2018-02-14 02:07:55 -08:00
Kubernetes Submit Queue
92e4d3da00
Merge pull request #59803 from wwwtyro/rye/robust-label-change
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Avoid hook errors when effecting label changes on kubernetes-worker charm.

**What this PR does / why we need it**: Avoid hook errors when effecting label changes on kubernetes-worker charm.

**Release note**:
```release-note
Avoid hook errors when effecting label changes on kubernetes-worker charm.
```
2018-02-13 13:13:20 -08:00
George Kraft
d1ab6a110a juju: Fix broken ingress after upgrade-charm 2018-02-13 14:04:18 -06:00
Rye Terrell
e52ecc56d7 Avoid hook errors when effecting label changes. 2018-02-13 13:37:18 -06:00
Mike Wilson
15530c0914 Requesting new credentials when node names change 2018-02-11 14:25:45 -05:00
Kubernetes Submit Queue
317853c90c
Merge pull request #59464 from dixudx/fix_all_typos
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

fix all the typos across the project

**What this PR does / why we need it**:
There are lots of typos across the project. We should avoid small PRs on fixing those annoying typos, which is time-consuming and low efficient.

This PR does fix all the typos across the project currently. And with #59463, typos could be avoided when a new PR gets merged.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #

**Special notes for your reviewer**:
/sig testing
/area test-infra
/sig release
/cc @ixdy 
/assign @fejta 

**Release note**:

```release-note
None
```
2018-02-10 22:12:45 -08:00
Di Xu
48388fec7e fix all the typos across the project 2018-02-11 11:04:14 +08:00
George Kraft
fba0119eb0 juju: Fix kube-proxy failing to identify local endpoints 2018-02-09 16:56:22 -06:00
Kubernetes Submit Queue
fb340a4695
Merge pull request #57824 from thockin/gcr-vanity
Automatic merge from submit-queue (batch tested with PRs 57824, 58806, 59410, 59280). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

2nd try at using a vanity GCR name

The 2nd commit here is the changes relative to the reverted PR.  Please focus review attention on that.

This is the 2nd attempt.  The previous try (#57573) was reverted while we
figured out the regional mirrors (oops).
    
New plan: k8s.gcr.io is a read-only facade that auto-detects your source
region (us, eu, or asia for now) and pulls from the closest.  To publish
an image, push k8s-staging.gcr.io and it will be synced to the regionals
automatically (similar to today).  For now the staging is an alias to
gcr.io/google_containers (the legacy URL).
    
When we move off of google-owned projects (working on it), then we just
do a one-time sync, and change the google-internal config, and nobody
outside should notice.
    
We can, in parallel, change the auto-sync into a manual sync - send a PR
to "promote" something from staging, and a bot activates it.  Nice and
visible, easy to keep track of.

xref https://github.com/kubernetes/release/issues/281

TL;DR:
  *  The new `staging-k8s.gcr.io` is where we push images.  It is literally an alias to `gcr.io/google_containers` (the existing repo) and is hosted in the US.
  * The contents of `staging-k8s.gcr.io` are automatically synced to `{asia,eu,us)-k8s.gcr.io`.
  * The new `k8s.gcr.io` will be a read-only alias to whichever regional repo is closest to you.
  * In the future, images will be promoted from `staging` to regional "prod" more explicitly and auditably.

 ```release-note
Use "k8s.gcr.io" for pulling container images rather than "gcr.io/google_containers".  Images are already synced, so this should not impact anyone materially.
    
Documentation and tools should all convert to the new name. Users should take note of this in case they see this new name in the system.
```
2018-02-08 03:29:32 -08:00
Tim Hockin
3586986416 Switch to k8s.gcr.io vanity domain
This is the 2nd attempt.  The previous was reverted while we figured out
the regional mirrors (oops).

New plan: k8s.gcr.io is a read-only facade that auto-detects your source
region (us, eu, or asia for now) and pulls from the closest.  To publish
an image, push k8s-staging.gcr.io and it will be synced to the regionals
automatically (similar to today).  For now the staging is an alias to
gcr.io/google_containers (the legacy URL).

When we move off of google-owned projects (working on it), then we just
do a one-time sync, and change the google-internal config, and nobody
outside should notice.

We can, in parallel, change the auto-sync into a manual sync - send a PR
to "promote" something from staging, and a bot activates it.  Nice and
visible, easy to keep track of.
2018-02-07 21:14:19 -08:00
Kubernetes Submit Queue
f2362ed6e5
Merge pull request #59396 from kwmonroe/bug/opts-before-login
Automatic merge from submit-queue (batch tested with PRs 59441, 58264, 59287, 59396, 59439). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Ensure docker daemon opts are in effect before docker login

**What this PR does / why we need it**:
Make sure the kubernetes-worker charm is using the configured `docker-opts` daemon options prior to running the `docker-logins` handler.
**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #
https://github.com/juju-solutions/layer-docker/issues/112
**Special notes for your reviewer**:

**Release note**:

```release-note
Fixed charm issue where docker login would run prior to daemon options being set. 
```
2018-02-06 20:27:42 -08:00
Kevin W Monroe
fa440c8dd2 split docker-logins logic into 2 handlers
Previous commit relied on non-obvious reactive behavior, with the
'docker.restart' flag being exploited to re-execute docker_logins_changed
in a single hook execution.

Split this into 2 handlers:
- when docker-logins config changes, set one flag to handle the login
and another to request a daemon restart (if needed).
- run docker login after any potential daemon restarts have occurred.
2018-02-06 11:29:42 -06:00
Kevin W Monroe
4af548bb5a Ensure daemon opts are in effect before docker login 2018-02-06 05:16:20 +00:00
halfcrazy
9b64650311 fix typo in cluster 2018-02-03 11:08:06 +08:00
Kubernetes Submit Queue
ea501413ce
Merge pull request #59219 from hyperbolic2346/mwilson/get-node-name-timeout-bump
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

bumping timeouts for apiserver communication.

**What this PR does / why we need it**:
Our CI is failing due to timeouts. The times we set node names intersects with apiserver restarts, which can sometimes get caught up for longer than one minute. This is a temporary fix until we can decide on the best long-term solution.
**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
Upped the timeout for apiserver communication in the juju kubernetes-worker charm.
```
2018-02-02 10:25:36 -08:00
Kubernetes Submit Queue
4b8309e315
Merge pull request #59064 from hyperbolic2346/mwilson/upgrade-creds-fix
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Fixing upgrade charm failing if upgrading from an old enough charm

**What this PR does / why we need it**:
Charms before ~Nov 2017 can not upgrade to charms made after that time due to a race with a missing credential dictionary. This change forces the dictionary to be created before we attempt to use it.
**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #
https://github.com/juju-solutions/bundle-canonical-kubernetes/issues/474
**Special notes for your reviewer**:

**Release note**:

```release-note
Fixed issue with charm upgrades resulting in an error state.
```
2018-02-02 04:34:28 -08:00
Mike Wilson
af71c9670f bumping timeouts for apiserver communication. 2018-02-01 15:55:44 -05:00
Kubernetes Submit Queue
57bd4f8344
Merge pull request #59116 from hyperbolic2346/mwilson/priv-typo-fix
Automatic merge from submit-queue (batch tested with PRs 57683, 59116, 58728, 59140, 58976). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Fixing issue with capitalization in allow-privileged

**What this PR does / why we need it**:
Config option in kubernetes-master allow-privileged would do odd things if you used True instead of true.
**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #
https://github.com/juju-solutions/bundle-canonical-kubernetes/issues/374
**Special notes for your reviewer**:

**Release note**:

```release-note
Fixed issue with kubernetes-worker option allow-privileged not properly handling the value True with a capital T.
```
2018-02-01 07:04:37 -08:00
Mike Wilson
ec0bedbf43 Fixing issue with capitalization causing odd behaviors for allow-privileged configuration option. 2018-01-31 10:26:23 -05:00
Mike Wilson
17f8f18f6f Fixing upgrade charm failing if upgrading from an old enough charm(pre Nov 2017). 2018-01-30 14:52:57 -05:00
Mike Wilson
e87b537654 Forcing get_node_name to continue searching for a node name if the returned list of nodes doesn't include this one.
There was a race condition where the kubelet was restarting and we were querying the api server for this node.
2018-01-29 20:27:35 -05:00
Rye Terrell
154caf6a8c Ensure config has been created before attempting to launch ingress. 2018-01-24 11:06:37 -06:00
Kubernetes Submit Queue
ecb3d7bb6d
Merge pull request #58523 from hyperbolic2346/mwilson/network-spaces
Automatic merge from submit-queue (batch tested with PRs 58438, 58523, 58513, 57948). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

network spaces support for kubernetes-worker charm

**What this PR does / why we need it**:
Adds support for network spaces in the kubernetes-worker charm.
**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #
https://github.com/juju-solutions/bundle-canonical-kubernetes/issues/406
**Special notes for your reviewer**:

**Release note**:

```release-note
Added support for network spaces in the kubernetes-worker charm
```
2018-01-23 03:53:28 -08:00
Mike Wilson
a22358e525 Fixing some flake8 issues 2018-01-22 14:54:58 -05:00
Mike Wilson
b04a88cc9e Adding support for changing default backend and nginx container images 2018-01-19 16:40:57 -05:00
Mike Wilson
531c9a81c1 Changing where the charm gets network addresses in order to support network spaces. 2018-01-19 10:00:46 -05:00
Kubernetes Submit Queue
7fb2d5432d
Merge pull request #57530 from hyperbolic2346/mwilson/nginx-daemonset
Automatic merge from submit-queue (batch tested with PRs 57492, 57530). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Changing ingress from manually scaling rc to a daemon set.

**What this PR does / why we need it**:
Quality of life fix. We used to set an RC to run the nginx ingress and then scale it in the charm as workers were added. Now we just use a daemon set to make sure it is running everywhere. Using application-specific names and roles so multiple applications can have different ingress settings.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #
https://github.com/juju-solutions/bundle-canonical-kubernetes/issues/367

**Special notes for your reviewer**:

**Release note**:

```release-note
CDK nginx ingress is now handled via a daemon set.
```
2018-01-05 08:14:40 -08:00
Mike Wilson
4aef85aab4 Removing duplicate import 2018-01-05 09:41:23 -05:00
Mike Wilson
806759cfc9 Changed return of empty string to raise an exception as it should have been from the beginning. 2018-01-04 17:45:40 -05:00
Tim Hockin
e9dd8a68f6 Revert k8s.gcr.io vanity domain
This reverts commit eba5b6092a.

Fixes https://github.com/kubernetes/kubernetes/issues/57526
2017-12-22 14:36:16 -08:00
Mike Wilson
1b814c43ad Changing ingress from manually scaling rc to a daemon set. 2017-12-21 18:31:08 -05:00
Konstantinos Tsakalozos
f2da078168 Pointing juju charms to 1.9 2017-12-19 14:48:05 +02:00
Tim Hockin
eba5b6092a Use k8s.gcr.io vanity domain for container images 2017-12-18 09:18:34 -08:00
Kubernetes Submit Queue
cab439b20f
Merge pull request #57195 from marcoceppi/s390x-fixes
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Use an s390x default-http-backend

This needs to be refactored to eventually say all non x86 architectures place a -arch() in the image name to support ppc64el, arm, etc.

Most all gcr.io/google_containers have -arch() image names.


**What this PR does / why we need it**:

Adds s390x images for when deploying to z system mainframes for default-http-backend image

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes https://github.com/juju-solutions/bundle-canonical-kubernetes/issues/455

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
2017-12-17 00:54:22 -08:00
Kubernetes Submit Queue
3492467178
Merge pull request #57113 from wwwtyro/rye/optional-kube-dns
Automatic merge from submit-queue (batch tested with PRs 56676, 57050, 54881, 56822, 57113). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

make kube-dns addon optional

**What this PR does / why we need it**: Makes the kube-dns addon optional so that users can deploy their own DNS solution.

**Release note**:
```release-note
Makes the kube-dns addon optional so that users can deploy their own DNS solution.
```
2017-12-16 19:19:49 -08:00
Kubernetes Submit Queue
05acd736c1
Merge pull request #56217 from Cynerva/gkk/docker-logins
Automatic merge from submit-queue (batch tested with PRs 56217, 56268, 56263, 56328, 56200). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add docker-logins config to kubernetes-worker charm

**What this PR does / why we need it**:

This adds a `docker-logins` config option to the kubernetes-worker charm, which allows cluster operators to authenticate against docker registries so kubelet can pull containers from them.

**Release note**:

```release-note
Added docker-logins config to kubernetes-worker charm
```
2017-12-14 23:37:39 -08:00
Marco Ceppi
6592e44d18 Use an s390x default-http-backend
This needs to be refactored to eventually say all non x86 architectures place a -arch() in the image name to support ppc64el, arm, etc.

Most all gcr.io/google_containers have -arch() image names.
2017-12-14 13:28:41 +00:00
Rye Terrell
6559e4dede make kube-dns addon optional 2017-12-12 14:33:38 -06:00
Konstantinos Tsakalozos
a6ee55c4a7 Lowecasing the hostname on the known nodes entry 2017-11-22 16:55:39 +02:00
Konstantinos Tsakalozos
99a25fed19 Lowercase hostnames when used as node names in k8s 2017-11-22 09:45:23 +02:00
George Kraft
ca9076cf0f Add docker-logins config to kubernetes-worker 2017-11-20 12:52:34 -06:00
George Kraft
9036d07cb8 Add extra-args configs to kubernetes-worker charm 2017-11-08 12:49:37 -06:00
Konstantinos Tsakalozos
b134ce7621 New master takes over 2017-11-03 20:47:43 +02:00
George Kraft
47f44f58a5 Fix hook failure in kubernetes-worker charm due to iptables conflict 2017-10-31 17:05:53 -05:00
George Kraft
421379889d Fix iptables FORWARD policy for Docker 1.13 in kubernetes-worker charm 2017-10-27 11:04:56 -05:00
Konstantinos Tsakalozos
42702518a1 Address lint errors 2017-10-25 10:34:20 +03:00
Konstantinos Tsakalozos
9a28e9b125 Addressing review comments 2017-10-17 22:31:22 +03:00
Konstantinos Tsakalozos
95fec2dc3f Work on upgrade path 2017-10-11 17:13:19 +03:00
Konstantinos Tsakalozos
b8a4fa6d81 Move ingress to kube-system. Rename enable-rbac to authorization-mode. 2017-10-09 11:05:42 +03:00