Commit Graph

7121 Commits

Author SHA1 Message Date
danielqsj
46d7f7ca17 fix shellcheck codegen in code-generator 2019-01-30 10:30:19 +08:00
Bin Lu
5cdb762fb9 Bug fix: ./hack/install-etcd.sh is not work on Arm64 platform
Signed-off-by: Bin Lu <bin.lu@arm.com>
2019-01-30 09:52:06 +08:00
Bin Lu
44a36ea36e Bug fix: ./hack/local-up-cluster.sh is not work on Arm64 platform
Signed-off-by: Bin Lu <bin.lu@arm.com>
2019-01-30 09:49:46 +08:00
Andrew Kim
84191eb99b replace pkg/util/file with k8s.io/utils/path 2019-01-29 15:20:13 -05:00
Jordan Liggitt
6cec098771 Allow control over media-type 2019-01-29 10:39:24 -05:00
Kubernetes Prow Robot
34425974c8 Merge pull request #73117 from war-turtle/fixShellCheck
Fixes shellcheck warning in build/common.sh
2019-01-29 06:57:28 -08:00
Ismo Puustinen
83030b67fa verify-generated-files-remake.sh: use 'read -r'.
'read' will not handle backslashes properly. 'read -r' is safer to use.
The find_genfiles() will not insert backslashes, so if there are any,
they will be from directory names.
2019-01-29 13:11:25 +02:00
Ismo Puustinen
a911034e01 verify-generated-files-remake.sh: do not mix strings and arrays.
The pattern used in the file is this:

  echo "  ${X[@]:-(none)}"

What happens is that the array is expanded to separate strings, and it
is checked if that's set (for the default value assignment). However,
the correct way is to check if the concatenated array string is set to
avoid a type mismatch:

  echo "  ${X[*]:-(none)}"

Tests show that at least bash 4.4.23 behaves the same:

  X=(foo bar)
  echo "  ${X[@]:-(none)}"
  echo "  ${X[*]:-(none)}"

  X=()
  echo "  ${X[@]:-(none)}"
  echo "  ${X[*]:-(none)}"

produces:

  foo bar
  foo bar
  (none)
  (none)
2019-01-29 13:11:25 +02:00
Kubernetes Prow Robot
d9fbb9af5e Merge pull request #73251 from danielqsj/api
fix shellcheck in k8s.io/apiserver
2019-01-29 01:21:13 -08:00
Kubernetes Prow Robot
b2d2432291 Merge pull request #73234 from baltendo/master
Fix golint failures
2019-01-29 01:21:03 -08:00
Kubernetes Prow Robot
6ebe874d11 Merge pull request #73212 from danielqsj/samplecontroller
fix shellcheck in sample-controller
2019-01-29 01:20:52 -08:00
Kubernetes Prow Robot
bbfc3be51b Merge pull request #73096 from yuwenma/golint1
fix golint failure for pkg/controller/deployment/util
2019-01-28 21:52:15 -08:00
Kubernetes Prow Robot
3c34d28fe0 Merge pull request #72818 from humblec/md-2
Remove explicit nil initialization and correct error string.
2019-01-28 21:52:03 -08:00
Yuwen Ma
14a1e27ddd fix golint failure for pkg/controller/deployment/util 2019-01-28 11:00:40 -08:00
bruceauyeung
c53d76d535 log useful information instead of silent exit without error when etcd has already been installed 2019-01-28 15:34:59 +08:00
Dr. Stefan Schimanski
9377448667 Move hack/import-restrictions.yaml to staging/publishing 2019-01-26 19:53:51 +01:00
war-turtle
b1b7d0dbae fixing shellcheck warning in build/common.sh 2019-01-26 19:21:17 +05:30
Kubernetes Prow Robot
c6d0cdf309 Merge pull request #72694 from liggitt/integration-api-versions
Use apps/v1 APIs in integration, explicitly enable all resources for print/etcd/scale tests
2019-01-26 00:35:43 -08:00
Kubernetes Prow Robot
fb9e07c664 Merge pull request #70052 from neolit123/placeholder-docs
docs: stop tracking placeholder documentation
2019-01-26 00:35:33 -08:00
Kubernetes Prow Robot
e1605310a5 Merge pull request #72902 from andrewsykim/72649
E2E test for node deleted in cloud provider
2019-01-25 22:31:16 -08:00
Kenichi Omichi
c32d1acbb9 Add check-file-in-alphabetical-order for cleanup
Both verify-golint.sh and verify-shellcheck.sh have the same logic
which checks failure_file in alphabetical order.
In addition, we'd like to add another script which requires the
same logic. So this add a common function for cleanup.
2019-01-26 02:09:06 +00:00
Lubomir I. Ivanov
54e8d73920 docs: stop tracking placeholder documentation
The placeholder documentation introduces a couple of problems:
- it complicates the contributor-experience (forces the CI to run
N times before the contributor finds out that they need to call an .sh
script and include certain files from docs/)
- it forces CLI related pull requests for tools like kubeadm and kubectl
to require top level approval from docs/OWNERS as such PRs still need
to touch the .generated_docs file

Stop tracking the placeholder documentation by applying the
following actions:
- remove the utility set-placeholder-gen-docs()
- make verify-generated-docs.sh only generate in a temporary folder
and not match .generated_docs
- mark generate-docs.sh as an alias for update-generated-docs.sh
- remove all current placeholder files in docs folders admin, man,
user-guide, yaml
- ignore the above folders and .generated_docs in a .gitignore file
2019-01-26 01:07:10 +02:00
andrewsykim
596c6fbf03 e2e test for node deleted in cloud provider 2019-01-25 17:45:18 -05:00
Jordan Liggitt
89b0b0b84b Clean up initializer-related comments, test data 2019-01-25 12:37:45 -05:00
Kubernetes Prow Robot
b466308bbd Merge pull request #73151 from tanshanshan/fixshell
fix shellcheck failure
2019-01-24 20:07:46 -08:00
Jordan Liggitt
b64075dbd0 explicitly enable apps/v1beta1, apps/v1beta2, extensions/v1beta1 for print,etcd,storage tests 2019-01-24 21:43:15 -05:00
Kubernetes Prow Robot
0210c0d869 Merge pull request #73253 from phenixblue/improve-syntax-for-shell-script
Updates to eliminate shellcheck failures - kubernetes/cluster/centos
2019-01-24 17:46:43 -08:00
Kubernetes Prow Robot
2cbb16bc8d Merge pull request #73243 from andrewsykim/update-utils-vendor
Update vendor k8s.io/utils and remove internal utils
2019-01-24 16:30:14 -08:00
Kubernetes Prow Robot
d1031b18fc Merge pull request #73279 from dims/fix-problem-fetching-sudo
Run apt-get update before installing sudo
2019-01-24 14:55:33 -08:00
Kubernetes Prow Robot
e28c757e87 Merge pull request #72972 from liggitt/remove-alpha-initializers
Remove use of alpha initializers
2019-01-24 14:54:52 -08:00
Joe Searcy
e72a683f82 Updates to eliminate shellcheck failures in #72956
Extend quotes to full filepath strings

Fixes for reviewers comments
2019-01-24 15:57:26 -05:00
Andrew Kim
aab0ea4e41 allow k8s.io/utils in client-go import restrictions 2019-01-24 15:34:21 -05:00
Andrew Kim
93b086f6ea replace k8s.io/apiserver/pkg/util/trace with k8s.io/utils/trace 2019-01-24 15:34:21 -05:00
Andrew Kim
0bc5508aca replace client-go/util/integer with k8s.io/utils/integer 2019-01-24 15:34:21 -05:00
Davanum Srinivas
279e1ed117 Run apt-get update before installing sudo
recent changes to kubekins broke local-e2e with the following error
```
E: Unable to locate package sudo
```

Change-Id: I9ad324a2a070bc068ed1f0f88a912eafb191ad90
2019-01-24 11:45:42 -05:00
Kubernetes Prow Robot
31311a6343 Merge pull request #73148 from liggitt/remove-deprecated-swagger-paths
remove deprecated openapi paths in favor of /openapi/v2
2019-01-23 22:06:21 -08:00
danielqsj
481c2d8e03 fix shellcheck in k8s.io/apiserver 2019-01-24 13:55:09 +08:00
Bernhard Altendorfer
736f35ec29 Fix golint failures 2019-01-24 00:14:25 +01:00
Kubernetes Prow Robot
a5d55f49b0 Merge pull request #73217 from kubernetes/revert-73071-reflector_trace
Revert "Adding trace to reflector initialization"
2019-01-23 12:20:27 -08:00
Kubernetes Prow Robot
4e340f450f Merge pull request #73150 from rlenferink/patch-2
Improved some more bash script variable definitions
2019-01-23 12:20:17 -08:00
Jordan Liggitt
dc1fa870bf Remove alpha InitializerConfiguration types, Initializers admission plugin 2019-01-23 11:37:39 -05:00
Wojciech Tyczynski
c8d89b34cc Revert "Adding trace to reflector initialization" 2019-01-23 14:50:37 +01:00
danielqsj
078115a604 fix shellcheck in sample-controller 2019-01-23 20:56:25 +08:00
Humble Devassy Chirammal
2651c72166 This patch consists of various corrections. (#73060)
* This patch consists of various corrections.

*) Remove unwanted `else` code block
*) Adjust variable intialization.
*) Correct error strings.
*) Use recommended variable increment method.

Signed-off-by: hchiramm <hchiramm@redhat.com>

* Remove cluster/images/cluster-version-monitor from hack/.golint_failures.

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2019-01-22 12:28:59 -08:00
Krzysztof Siedlecki
e2a017327c adding dependency 2019-01-22 11:00:51 +01:00
tanshanshan
529cfd1437 fix shellcheck failure 2019-01-22 08:39:55 +08:00
Roy Lenferink
b18bc2ea79 Improved some more bash script variable definitions 2019-01-21 23:11:58 +01:00
Jordan Liggitt
52519ecb1c remove deprecated openapi paths in favor of /openapi/v2 2019-01-21 16:33:41 -05:00
Kubernetes Prow Robot
dc3edee5f5 Merge pull request #73107 from rlenferink/patch-2
Bash script syntax improvements
2019-01-20 17:49:44 -08:00
Kubernetes Prow Robot
6ce59dd1a2 Merge pull request #72584 from xing-yang/local_cluster
Install CRD's in local cluster
2019-01-19 08:07:58 -08:00