Commit Graph

8218 Commits

Author SHA1 Message Date
Jin Hase
17fa573e05 Add simple explanation to verify-golint.sh 2019-12-25 17:05:32 +09:00
Mark Janssen
a54e5cec54 Fix staticcheck failures for pkg/proxy/...
Errors from staticcheck:
pkg/proxy/healthcheck/proxier_health.go:55:2: field port is unused (U1000)
pkg/proxy/healthcheck/proxier_health.go:162:20: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
pkg/proxy/healthcheck/service_health.go:166:20: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
pkg/proxy/iptables/proxier.go:737:2: this value of args is never used (SA4006)
pkg/proxy/iptables/proxier.go:737:15: this result of append is never used, except maybe in other appends (SA4010)
pkg/proxy/iptables/proxier.go:1287:28: this result of append is never used, except maybe in other appends (SA4010)
pkg/proxy/userspace/proxysocket.go:293:3: this value of n is never used (SA4006)
pkg/proxy/winkernel/metrics.go:74:6: func sinceInMicroseconds is unused (U1000)
pkg/proxy/winkernel/metrics.go:79:6: func sinceInSeconds is unused (U1000)
pkg/proxy/winuserspace/proxier.go:94:2: field portMapMutex is unused (U1000)
pkg/proxy/winuserspace/proxier.go:118:2: field owner is unused (U1000)
pkg/proxy/winuserspace/proxier.go:119:2: field socket is unused (U1000)
pkg/proxy/winuserspace/proxysocket.go:620:4: this value of n is never used (SA4006)
2019-12-22 21:32:06 +01:00
Kubernetes Prow Robot
109810dfbb
Merge pull request #86473 from kireledan/kireledan/hack-aws-provider
hack/local-up-cluster: modify cloud provider launch to work with aws
2019-12-20 18:28:17 -08:00
kireledan
a8a00f690e hack/local-up-cluster: modify cloud provider launch to work with aws
This commit updates the local-up-cluster script to set the proper provider id when the aws cloud provider is used.
2019-12-19 22:54:10 -08:00
Kubernetes Prow Robot
127c47caf4
Merge pull request #85512 from serathius/remove-cluster-monitoring
Remove cluster-monitoring
2019-12-17 21:05:57 -08:00
Kubernetes Prow Robot
7a6090550a
Merge pull request #82971 from AnishShah/proxy.go
Refactor `kubectl proxy` command to have similar design pattern as other kubectl commands.
2019-12-17 11:59:58 -08:00
Kubernetes Prow Robot
623b697886
Merge pull request #86040 from haosdent/fix-staticcheck-annotate
fix static check in kubectl/pkg/cmd/annotate.
2019-12-17 06:18:27 -08:00
Kubernetes Prow Robot
fb0956c234
Merge pull request #85016 from hvaara/fix-golint-pkg-util-sysctl-testing
Fix golint issues in pkg/util/sysctl/testing
2019-12-17 06:18:13 -08:00
Anish Shah
0bd41a300f Refactor kubectl proxy command to have similar design pattern as other kubectl commands.
Few days ago I watched this kubectl code base tour on Youtube
(https://www.youtube.com/watch?v=uz8TS3V9qqY). It talks about a design
pattern that almost every command follows. But I found out that
`kubectl proxy` command does not follow this pattern. So, I'm
refactoring this command to use similar design pattern as other kubectl
commands.
2019-12-17 08:28:01 +05:30
carlory
2fe82075b4 fix staticcheck faulures in 'cmd' pkg 2019-12-16 18:32:54 +08:00
Kubernetes Prow Robot
32883e46d6
Merge pull request #86238 from SataQiu/fix-staticcheck-20191213
Fix staticcheck failures of test/e2e/manifest
2019-12-15 11:07:37 -08:00
Kubernetes Prow Robot
6a919f2b54
Merge pull request #85903 from liggitt/disable-deprecated-apis
Remove ability to re-enable serving deprecated APIs
2019-12-13 16:19:36 -08:00
Jordan Liggitt
f2f22b84cd Delete ReplicationControllerDummy 2019-12-13 12:21:33 -05:00
Jordan Liggitt
18ba6f9482 Remove references to unserved types 2019-12-13 12:21:33 -05:00
Jordan Liggitt
424d5e20df Remove testapi 2019-12-13 11:56:29 -05:00
SataQiu
95bf226533 fix staticcheck failures of test/e2e/manifest 2019-12-13 14:03:44 +08:00
hwdef
64e49e187a add hwdef as a reviewer of hack 2019-12-12 16:10:06 +08:00
SataQiu
e70120f083 fix staticcheck failures of e2e/storage/utils e2e/storage/vsphere 2019-12-11 10:33:21 +08:00
SataQiu
3ed535a89a fix staticcheck failures of e2e/storage/drivers e2e/storage/testsuites 2019-12-10 16:09:29 +08:00
Marek Siarkowicz
31fb04fa98 Remove cluster-monitoring
Heapster is deprecated and no longer supported
2019-12-09 11:25:20 +01:00
Haosdent Huang
303c1a40bc fix static check in kubectl/pkg/cmd/annotate. 2019-12-08 23:25:50 +08:00
SataQiu
27d645dc5b fix staticcheck failures of test/e2e/storage 2019-12-07 21:32:11 +08:00
Kubernetes Prow Robot
8ef9caaded
Merge pull request #85676 from tanjunchen/fix-staticcheck-test-integration-apiserver
fix staticcheck in test/integration/apiserver
2019-12-06 19:49:08 -08:00
Kubernetes Prow Robot
e0f11a2fc3
Merge pull request #85893 from tanjunchen/fix-test-e2e-network
fix staticcheck in test/e2e/network/
2019-12-06 17:06:06 -08:00
tanjunchen
06c5901769 fix staticcheck in test/integration/apiserver 2019-12-06 23:05:20 +08:00
Kubernetes Prow Robot
c2b312bd22
Merge pull request #85790 from tanjunchen/fix-staticcheck-pkg-printers
fix staticcheck in pkg/printers
2019-12-05 13:50:54 -08:00
Kubernetes Prow Robot
fe80f32904
Merge pull request #85780 from hwdef/fix-staticcheck16
test/e2e/auth: Fix static check failures
2019-12-05 13:50:44 -08:00
Kubernetes Prow Robot
e68d7be680
Merge pull request #85457 from BenTheElder/typecheck-fun
Typecheck support for verifying providerless build
2019-12-05 13:50:17 -08:00
hwdef
d81dd48e2c test/e2e/auth: Fix static check failures 2019-12-05 22:42:04 +08:00
Kubernetes Prow Robot
8290c85b95
Merge pull request #82315 from beautytiger/fix_staticcheck_azure
fix staticcheck errors in legacy-cloud-providers/azure
2019-12-05 06:36:32 -08:00
Kubernetes Prow Robot
2f58d2e3fe
Merge pull request #85890 from tanjunchen/fix-golint-test-e2e_node-ruuner
fix golint check in test/e2e_node/runner/remote
2019-12-05 00:36:32 -08:00
Benjamin Elder
b24dbac09a add hack/verify-typecheck-providerless.sh 2019-12-04 22:30:23 -08:00
tanjunchen
d51b72d9e9 fix staticcheck in test/e2e/network/ 2019-12-05 13:58:28 +08:00
tanjunchen
40911e74c1 fix staticcheck in pkg/printers 2019-12-05 10:24:42 +08:00
Jan Chaloupka
f967c544ad scheduler benchmark: allow to override bench prefix
Right now, hack/jenkins/dockerized.sh is solely utilized by scheduler perf jenkins job.
There's an effort to extend the scheduler performance suite. In order to run
individual subsuites separately, we need a way to select a subset of benchmark tests
to be run. Golang exposes -bench option which allows to specify a prefix
of benchmark tests to be run.
2019-12-04 18:45:48 +01:00
Kubernetes Prow Robot
97a4e6683e
Merge pull request #85634 from hwdef/fix-staticcheck14
pkg/master: Fix static check failures
2019-12-04 07:18:57 -08:00
Guangming Wang
b304538942 fix staticcheck errors in legacy-cloud-providers/azure
clean remaining static check errors in legacy-cloud-providers/azure

logging unhandled error in azure_backoff.go

delete unused var and func in azure_vmss_cache.go

run gofmt
2019-12-04 21:58:26 +08:00
tanjunchen
29eb15c3a8 fix golint check in test/e2e_node/runner/remote 2019-12-04 18:14:52 +08:00
Kubernetes Prow Robot
6d5eee88e0
Merge pull request #84624 from hwdef/fix-staticcheck
cmd/kube-controller-manager: fix staticcheck warning
2019-12-04 01:54:57 -08:00
Kubernetes Prow Robot
0f332bae5d
Merge pull request #85853 from SataQiu/fix-staticcheck-20191203
Fix staticcheck failures of test/e2e/upgrade
2019-12-03 21:51:18 -08:00
Kubernetes Prow Robot
9acdf52877
Merge pull request #85744 from tanjunchen/fix-golint-problems
Fix golint issues in test/e2e/lifecycle/
2019-12-03 19:44:57 -08:00
Kubernetes Prow Robot
fe97fbb2e6
Merge pull request #85071 from hvaara/fix-golint-pkg-apis-batch-validation
Fix golint issues in pkg/apis/batch/validation
2019-12-03 17:00:57 -08:00
Kubernetes Prow Robot
bb9981e19f
Merge pull request #85046 from hvaara/fix-golint-pkg-registry--storage
Fix golint issues in pkg/registry/.../storage
2019-12-03 15:47:11 -08:00
Jacek Kaniuk
7eb6182a63 Revert "Fix shellcheck failure in log-dump/log-dump.sh"
This reverts commit e99a325d4e.
2019-12-03 18:17:54 +01:00
SataQiu
6fcd030877 fix staticcheck failures of test/e2e/upgrade 2019-12-03 23:36:09 +08:00
Kubernetes Prow Robot
716b4549b2
Merge pull request #85749 from SataQiu/golint-e2e-20191129
Fix golint failures of test/e2e_node/remote
2019-12-03 06:06:58 -08:00
tanjunchen
d2d68026fc Fix golint issues in test/e2e/lifecycle/ 2019-12-03 17:14:38 +08:00
hwdef
dddd631706 cmd/kube-controller-manager: fix staticcheck warning 2019-12-03 11:16:24 +08:00
Kubernetes Prow Robot
0810bc3386
Merge pull request #85363 from immutableT/encryption-config-defaulter
Add defaulting and validation logic for EncryptionConfiguration type.
2019-12-02 17:06:57 -08:00
immutablet
a151aa35dc Add defaulting logic for EncryptionConfiguration. 2019-12-02 13:21:05 -08:00