github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
81,217 Commits 1 Branch 31 Tags
1b6ec47a045ba938c475f6f497beb50b58ba9da1
Commit Graph

14089 Commits

Author SHA1 Message Date
W. Trevor King
96b04bfeac test/e2e/upgrades/apps/job: List Pods in failure message 
Currently, this test can fail with the not-very-helpful [1,2]:

  fail [k8s.io/kubernetes/test/e2e/upgrades/apps/job.go:58]: Expected
      <bool>: false
  to be true

Since this test is the only CheckForAllJobPodsRunning consumer, and
has been since CheckForAllJobPodsRunning landed in 116eda0909
(Implements an upgrade test for Job, 2017-02-22, #41271), this commit
refactors the function to EnsureJobPodsRunning, dropping the opaque
boolean, and constructing a useful error summarizing the divergence
from the expected parallelism and the status of listed Pods.

Thanks to Maciej Szulik for the fixups [3] :).

[1]: https://storage.googleapis.com/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade/1434/build-log.txt
[2]: https://bugzilla.redhat.com/show_bug.cgi?id=1708454#c0
[3]: https://github.com/wking/kubernetes/pull/1
 2019-05-10 06:09:36 -07:00
loic le dru
61731dd1d1 e2e-test logf instead framework.logf 2019-05-10 14:18:55 +02:00
Kubernetes Prow Robot
b9ccdd2824 Merge pull request #77598 from danielqsj/unreserve 
Add Un-reserve extension point for the scheduling framework
 2019-05-09 23:37:57 -07:00
danielqsj
629ec7e113 replace test error checking with more readable way 2019-05-10 13:58:09 +08:00
danielqsj
1058877fbf remove dot imports in e2e/storage 2019-05-10 13:56:26 +08:00
danielqsj
8a6fede9e6 remove dot imports in e2e/storage/vsphere 2019-05-10 13:56:16 +08:00
danielqsj
997648a923 Add Un-reserve extension point for the scheduling framework 2019-05-10 13:19:22 +08:00
danielqsj
f3ea5e5c94 replace test error checking with more readable way 2019-05-10 10:15:45 +08:00
draveness
c045046e5b feat: use framework.ExpectNoError instead in e2e test 2019-05-10 09:53:10 +08:00
Akihito INOH
be4af8f83f Use framework.ExpectNoError() for e2e/lifecycle 
The e2e test framework has ExpectNoError() for readable test code.
This replaces Expect(err).NotTo(HaveOccurred()) with it for e2e/lifecycle.
 2019-05-10 10:45:32 +09:00
Joe Betz
b0aab03209 Fix admission webhook integration tests to filter out controller requests 2019-05-09 17:34:33 -07:00
Aaron Crickenberger
69eab5f04b Prune test/OWNERS 
Move approvers who haven't reviewed any PRs touching test/ in
over six months to emeritus_approvers (and remove from reviewers
as well to avoid assigning to inactive people)
 2019-05-09 16:30:58 -07:00
Kubernetes Prow Robot
69b52633cc Merge pull request #77605 from pohly/multivolume-storage-class-fix 
Multivolume storage class fix
 2019-05-09 15:48:22 -07:00
Kubernetes Prow Robot
b27fe7f4b9 Merge pull request #74314 from oomichi/add-ExpectError 
Add ExpectError() to e2e test framework
 2019-05-09 15:47:57 -07:00
Aaron Crickenberger
f0ec8c8644 Promote oomichi to approver in test/ 2019-05-09 14:22:06 -07:00
Kenichi Omichi
2a7202b71f Use framework.ExpectNoError() for e2e/ 
The e2e test framework has ExpectNoError() for readable test code.
This replaces Expect(err).NotTo(HaveOccurred()) with it.
 2019-05-09 19:26:16 +00:00
Kubernetes Prow Robot
851afa0bea Merge pull request #77528 from cblecker/go-1.12.5 
Update to go 1.12.5
 2019-05-09 09:32:51 -07:00
Kubernetes Prow Robot
524169fe1c Merge pull request #77005 from k-toyoda-pi/e2e_add_check_pod_in_job 
[e2e] add pod status check after job completes in job test
 2019-05-09 06:20:48 -07:00
xiaojingchen
2b19a4db9e fix cmd/kube-controller-manager's golint failures 2019-05-09 17:56:08 +08:00
toyoda
34a120fc42 fix shellcheck failures in /hack/make-rules/test.sh 2019-05-09 17:47:12 +09:00
Patrick Ohly
093027c891 e2e/storage: ensure that also external storage classes are unique 
One previously undocumented expectation is that
GetDynamicProvisionStorageClass can be called more than once per test
and then each time returns a new, unique storage class. The in-memory
implementation in driveroperations.go:GetStorageClass ensured that,
but loading from a .yaml file didn't. This caused the multivolume tests
to fail when applied to an already installed GCE driver with the
-storage.testdriver parameter.
 2019-05-09 08:53:25 +02:00
Kubernetes Prow Robot
ee0038adaa Merge pull request #77425 from figo/e2e 
Modify apimachinery,apps,instrumentation tests to import framework/log
 2019-05-08 21:48:47 -07:00
Kubernetes Prow Robot
548bf0afe5 Merge pull request #77580 from liggitt/fix-list-interface 
Fix unstructured list interface compatibility, fix kubectl paging
 2019-05-08 20:13:26 -07:00
Kubernetes Prow Robot
7f86cb140f Merge pull request #72167 from brahmaroutu/conformance_context 
Comment association to ConformanceIt block should be validated properly.
 2019-05-08 20:12:48 -07:00
Kubernetes Prow Robot
b6887e3915 Merge pull request #77530 from seans3/unexport-print-table 
Unexport PrintTable function
 2019-05-08 17:15:26 -07:00
hui luo
4d4e4f4056 Modify apimachinery,apps,instrumentation tests to import framework/log 
This is part of the transition to using framework/log instead
of the Logf inside the framework package. This will help with
import size/cycles when importing the framework or subpackages
 2019-05-08 16:46:39 -07:00
John Belamaric
4f3653f026 Add johnbelamaric as conformance test reviewer 2019-05-08 16:37:25 -07:00
Christoph Blecker
31ffa88a14 Update to go 1.12.5 2019-05-08 15:43:01 -07:00
Kubernetes Prow Robot
71bbabc36b Merge pull request #77486 from jiatongw/logf/kubectl 
Modify e2e/kubectl tests to import e2elog.Logf
 2019-05-08 14:32:45 -07:00
Kubernetes Prow Robot
b3875556b0 Merge pull request #77336 from johnSchnake/refactorFrameworkSSH 
Move ssh code to new package
 2019-05-08 13:06:47 -07:00
Kubernetes Prow Robot
09c4e10333 Merge pull request #74021 from andrewsykim/move-features-component-base 
Move feature gate package from k8s.io/apiserver to k8s.io/component-base
 2019-05-08 13:06:34 -07:00
Kenichi Omichi
436544488b Add ExpectError() to e2e test framework 
There is a lot of gomega.Expect(err).To(gomega.HaveOccurred()) callers
which expect an error happens in e2e tests.
However these test code seems confusing because the code readers
need to take care of To() or NotTo() on each test scenario.
This adds ExpectError() for more readable test code.
In addition, this applies ExpectError() to e2e provisioning.go as a
sample.
 2019-05-08 17:40:12 +00:00
Daniel (Shijun) Qian
5268f69405 fix duplicated imports of k8s code (#77484) 
* fix duplicated imports of api/core/v1

* fix duplicated imports of client-go/kubernetes

* fix duplicated imports of rest code

* change import name to more reasonable
 2019-05-08 10:12:47 -07:00
Kubernetes Prow Robot
f7d92fb963 Merge pull request #77427 from draveness/feature/use-logf-in-log-pkg 
refactor: use e2elog.Logf instead of framework.Logf
 2019-05-08 10:12:34 -07:00
John Schnake
338bc3ce42 Move framework ssh code to new package 
The framework/ssh.go code was heavily used throughout the framework
and could be useful elsewhere but reusing those methods requires
importing all of the framework.

Extracting these methods to their own package for reuse.

Only a few methods had to be copied into this package from the
rest of the framework to avoid an import cycle.
 2019-05-08 11:00:36 -05:00
Patrick Ohly
62c5c6345e Revert "Make external driver storage class name generation contain a more random suffix in case of double generation in the same framework context (twice in the same test)" 
This reverts commit c50e7fd301 because
it included API changes that shouldn't have been in that PR and
fixing the storage class conflict inside the framework is probably the
wrong place.
 2019-05-08 17:28:13 +02:00
Andrew Kim
c919139245 update import of generic featuregate code from k8s.io/apiserver/pkg/util/feature -> k8s.io/component-base/featuregate 2019-05-08 10:01:50 -04:00
Kubernetes Prow Robot
086a86b9e2 Merge pull request #77525 from davidz627/fix/externalMulti 
Make external driver name generation contain a more random suffix in case of double generation in the same framework context (twice in the same test)
 2019-05-08 04:54:48 -07:00
Kubernetes Prow Robot
bace505467 Merge pull request #77577 from logicalhan/revert-unreserve 
Revert "Add Un-reserve extension point for the scheduling framework"
 2019-05-08 03:04:32 -07:00
Jordan Liggitt
e5778f05b9 Fix unstructured list interface compatibility, fix kubectl paging 2019-05-08 02:00:18 -04:00
Kubernetes Prow Robot
7faeee22b1 Merge pull request #77556 from spiffxp/add-spiffxp-to-conformance-code-approvers 
Promote spiffxp to approver, add oomichi as reviewer
 2019-05-07 22:15:10 -07:00
Kubernetes Prow Robot
873e7a3259 Merge pull request #77533 from jiatongw/logf/lifecycle 
Modify e2e/lifecycle tests to import e2elog.Logf
 2019-05-07 22:14:58 -07:00
Kubernetes Prow Robot
11a46d2515 Merge pull request #77479 from danielqsj/id 
fix increment-decrement lint error
 2019-05-07 22:14:45 -07:00
Han Kang
51992d61a0 Revert "Add Un-reserve extension point for the scheduling framework" 
This reverts commit 8b5182581a.
 2019-05-07 21:17:29 -07:00
Kubernetes Prow Robot
1ce103a41f Merge pull request #77457 from danielqsj/un-reserve 
Add Un-reserve extension point for the scheduling framework
 2019-05-07 17:52:45 -07:00
Kubernetes Prow Robot
7aa57df279 Merge pull request #77374 from cheftako/gce-staging 
Staging the GCE Cloud Provider
 2019-05-07 17:52:32 -07:00
Kubernetes Prow Robot
b4262e9a22 Merge pull request #77408 from johnSchnake/frameworkLogRefactoringCommonScaleUpgrades 
Move scalability, upgrade, and common packages to framework/log
 2019-05-07 15:54:46 -07:00
Srini Brahmaroutu
e9bab1c896 Allow version field in the title to be changeable 2019-05-07 15:05:04 -07:00
David Zhu
c50e7fd301 Make external driver storage class name generation contain a more random suffix in case of double generation in the same framework context (twice in the same test) 2019-05-07 14:37:06 -07:00
Kubernetes Prow Robot
eacae8540a Merge pull request #76508 from bclau/tests/agnhost-custom-dns-test 
tests: Adds configurable pod DNS nameservers and search list test
 2019-05-07 14:30:49 -07:00