NonBlockingRun should also return a channel that gets closed when the
underlying http Server has stopped listening (during the graceful
shutdown period)
github.com/hashicorp/golang-lru is MPL 2 licensed, which means that
anyone who distributes code or binaries that incorporates it needs to
include its source code, even if they haven't made any modifications.
Since lrucacheexpire is picked up as a dependency of using the shared
informers in client-go, that's potentially a lot of distributors.
Most other deps of client-go are Apache 2.0, MIT, or BSD-like
licensed, which only requires including the license.
Rather than reverting to groupcache/lru, I just reimplemented the
functionality we need, which isn't much.
When API Priority and Fairness is enabled, the inflight limits must
add up to something positive.
This rejects the configuration that prompted
https://github.com/kubernetes/kubernetes/issues/102885
Update help for max inflight flags
This adds the gate `SeccompDefault` as new alpha feature. Seccomp path
and field fallbacks are now passed to the helper functions, whereas unit
tests covering those code paths have been added as well.
Beside enabling the feature gate, the feature has to be enabled by the
`SeccompDefault` kubelet configuration or its corresponding
`--seccomp-default` CLI flag.
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Apply suggestions from code review
Co-authored-by: Paulo Gomes <pjbgf@linux.com>
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
The test was flaking because the test was creating more connections
than expected.
Disabling connection pooling removes the flakes, and no more connections
are created that the necessary.
- Add `EncodeCaller` field in `encoderConfig`
- Use `ShortCallerEncoder` as `EncodeCaller
- Add CallerKey to encoderConfig
- Get frame of calling function based on what logging function is called (Info, Error, dPanic)
- Using obtained frame (if obtainable), set the Caller in the zapcore.Entry to indicate source code info
- Update tests to reflect the new format
Fix call frame depth implementation
- Implement zapLogger.WithCallDepth to implement the logr.CallDepthLogger interface
- Add a custom time encoder that use timeNow() stub instead of calling it manually in a zap Entry
- Update json logger unit tests and klog integration tests
Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
