Commit Graph

9352 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
9cf41a6766
Merge pull request #110899 from HecarimV/update-doc-220701
Remove invalid comments in hack/lib/version.sh
2022-07-08 18:03:46 -07:00
Dave Chen
50d1b6c8ba Add Ginkgo v1 to the list of unwanted dependencies
Ginkgo has been migrated to V2, add this to unwanted dependencies
so that it won't be shown up as a dep again in the future.

Signed-off-by: Dave Chen <dave.chen@arm.com>
2022-07-08 10:46:11 +08:00
Patrick Ohly
f7427d07e0 build: add ginkgo aliases for WHAT
The alias for vendor/github.com/onsi/ginkgo/ginkgo ensures that code like
30e99cb2a9/experiment/kind-conformance-image-e2e.sh (L110)
continues to work. The one without "vendor/" is there just in case that it
was used because it also worked.

Long term, "ginkgo" is a nicer, version independent alias. It gets used
internally to avoid future churn and gets documented also publicly in the
Makefile help.

The caveat is that there's no guarantee that a future v3 CLI will be compatible
with current invocations. But the most common usage is through
hack/ginkgo-e2e.sh, which can deal with such differences.
2022-07-08 10:46:11 +08:00
Dave Chen
2f3028c00d Define the timeout to 24h for Ginkgo V2
Default timeout setting has been reduced from `24h` down to `1h` in
Ginkgo V2, but for some long running test this is too short.

How long to abort the test was controlled by the the linux command `timeout`
in V1. e.g. `'timeout -k 30s 150m ...`, and is configured in the file
like `sig-network-misc.yaml`.

Set the timeout manually for Ginkgo V2 to avoid the early aborting.

Signed-off-by: Dave Chen <dave.chen@arm.com>
2022-07-08 10:46:11 +08:00
Dave Chen
2084f3cef2 Drop all stacktrace related validtion
The change is needed for `verify-e2e-test-ownership.sh`.
The `jq` is re-defined since the structure of test spec
is different with v1 and the stacktrace related validation
is not available, e.g. `package` and `func`.

Signed-off-by: Dave Chen <dave.chen@arm.com>
2022-07-08 10:46:11 +08:00
Dave Chen
b57bade50c Switch to use dry-run option to generate test spec
`dryRun` option is deprecated and will not be able to
generate test spec.

Signed-off-by: Dave Chen <dave.chen@arm.com>
2022-07-08 10:46:11 +08:00
Dave Chen
375b2a5fb2 Build Ginkgo binary
Signed-off-by: Dave Chen <dave.chen@arm.com>
2022-07-08 10:46:11 +08:00
Kubernetes Prow Robot
b3be343bc8
Merge pull request #110811 from Abirdcfly/clock
Update golangci-lint to 1.46.2 and fix errors
2022-07-06 16:03:32 -07:00
HaoJie Liu
4990214c6f
Remove invalid comments in hack/lib/version.sh
Signed-off-by: HaoJie Liu <liuhaojie@beyondcent.com>
2022-07-06 19:19:29 +08:00
Abirdcfly
2bca77a3d9 Update golangci-lint to 1.46.2 and fix errors
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
2022-06-29 17:42:46 +08:00
Kubernetes Prow Robot
f4abde9e57
Merge pull request #110632 from Kartik494/fix_cherry_pick
Update cherry_pick_pull.sh
2022-06-26 05:18:58 -07:00
Kartik Sharma
23f7594946 Update cherry_pick_pull.sh 2022-06-26 09:21:05 +05:30
Anish Ramasekar
907545445a
Add KMS v2alpha1 API
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
2022-06-24 17:58:34 +00:00
hwdef
2ea856026a clean up spelling_failures 2022-06-21 17:33:46 +08:00
Patrick Ohly
0284c6c06e hack/tools: use logcheck v0.1.0 from sigs.k8s.io/logtools/logcheck
The code was moved out of k8s.io/klog into its own repo with proper
tagging. Functionally there is no difference.
2022-06-14 17:27:16 +02:00
Kubernetes Prow Robot
0348821c9f
Merge pull request #110525 from gnufied/disable-trimpath-debug-mode
Disable trimpath in debug mode
2022-06-13 16:14:11 -07:00
Hemant Kumar
86cd654371 We need to all all=-N -l because some objects are being optimzied away
Without all=-N -l, some objects are being optimized away and
impossible to debug
2022-06-13 14:31:37 -04:00
SataQiu
d2632ed950 remove BUILD from .spelling_failures 2022-06-12 23:17:15 +08:00
Hemant Kumar
bfe34ab224 Disable trimpath in debug mode
This allows remote debugging with debuggers like vscode and Goland
2022-06-12 07:53:18 -04:00
Kubernetes Prow Robot
6e0e9f382e
Merge pull request #109194 from pohly/log-tests
log tests
2022-06-10 03:07:46 -07:00
Kubernetes Prow Robot
2d7dcf928c
Merge pull request #109594 from linux-on-ibm-z/fastbuild_s390x
Add fast build support for s390x
2022-06-05 23:42:23 -07:00
Kubernetes Prow Robot
0c0b528ec4
Merge pull request #109516 from kaydxh/master
refactor(hack): use ${BASH_SOURCE[0]} to get script name
2022-06-03 09:30:44 -07:00
Manish Kumar
e9e8be304c etcd: Updated to v3.5.4 2022-06-01 07:52:46 +05:30
Davanum Srinivas
50bea1dad8
Move from k8s.gcr.io to registry.k8s.io
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2022-05-31 10:16:53 -04:00
Patrick Ohly
991d848e34 logcheck: enable helper check
This is in preparation of converting code to contextual logging.
2022-05-31 08:07:37 +02:00
Kubernetes Prow Robot
6e04ca634d
Merge pull request #109729 from MikeSpreitzer/wrap-weighted-histograms
Wrap weighted histograms
2022-05-12 12:32:32 -07:00
Patrick Ohly
1aa58532c8 test: enable unit tests under test/e2e
The test/e2e directory contains several unit tests that should run as part of
"make test":

./test/e2e/chaosmonkey/chaosmonkey_test.go
./test/e2e/storage/external/external_test.go
./test/e2e/storage/utils/utils_test.go
./test/e2e/framework/log_test.go
./test/e2e/framework/testfiles/testfiles_test.go
./test/e2e/framework/timer/timer_test.go
./test/e2e/framework/node/wait_test.go
./test/e2e/framework/pod/resource_test.go
./test/e2e/framework/config/config_test.go
./test/e2e/framework/ingress/ingress_utils_test.go
./test/e2e/framework/providers/gce/firewall_test.go

Because they were excluded by "./test/e2e/*", some of them became outdated.

./test/e2e/e2e_test.go is the only test that needs to be excluded because it is
the E2E test suite that depends on a functional cluster.
2022-05-11 11:48:58 +02:00
Mario Jason Braganza
066fd90f26
add verify-licenses.sh to the EXCLUDED_PATTERNS in make-rules/verify.sh 2022-05-06 19:03:03 +05:30
Kubernetes Prow Robot
73a07082d9
Merge pull request #109299 from Priyankasaggu11929/add-verify-licenses-hack-script
add verify-licenses.sh hack script (#108942)
2022-05-06 06:21:04 -07:00
Priyanka Saggu
31a5e8a027
add workaround fix for incorrect license URL 2022-05-06 13:19:24 +05:30
Kubernetes Prow Robot
5e9a6a256e
Merge pull request #109464 from liggitt/gomodule-install
Use module mode when building/installing
2022-05-05 16:28:52 -07:00
Mike Spreitzer
68d9249490 Add wrapper for TimingHistogram
Do not bother wrapping WeightedHistogram because it is not used
in k/k.
2022-05-05 14:21:21 -04:00
Kubernetes Prow Robot
99de67958d
Merge pull request #109798 from liggitt/psp
Remove PodSecurityPolicy admission plugin
2022-05-05 06:40:32 -07:00
Jordan Liggitt
6cdaecfe0a Build in hermetic module mode 2022-05-05 08:47:33 -04:00
Jordan Liggitt
2a10ca650d drop vendor from test targets 2022-05-05 08:47:33 -04:00
Jordan Liggitt
39f5c13510 drop vendor from go install paths 2022-05-05 08:47:33 -04:00
Jordan Liggitt
a44192b955 Remove PodSecurityPolicy cluster config 2022-05-04 16:00:56 -04:00
Jordan Liggitt
9e1064a26b Regenerate vendor 2022-05-04 10:27:41 -04:00
Jordan Liggitt
1176b7ca28 Update go.mod files to go1.18, update license vendor script 2022-05-04 10:22:27 -04:00
Kubernetes Prow Robot
366dcaa81c
Merge pull request #109606 from endocrimes/dani/cleanup-make-test-e2e-node
hack: make test-e2e-node: remove old project refs
2022-05-04 02:34:45 -07:00
Kubernetes Prow Robot
cbb164efe6
Merge pull request #109277 from MikeSpreitzer/add-weighted-histogram
Start drafting weighted and timing histograms
2022-05-03 19:30:31 -07:00
Mike Spreitzer
b4a40cd43e Draft weighted and timing histograms
The following investigation occurred during development.

Add TimingHistogram impl that shares lock with WeightedHistogram

Benchmarking and profiling shows that two layers of locking is
noticeably more expensive than one.

After adding this new alternative, I now get the following benchmark
results.

```
(base) mspreitz@mjs12 kubernetes % go test -benchmem -run=^$ -bench ^BenchmarkTimingHistogram$ k8s.io/component-base/metrics/prometheusextension
goos: darwin
goarch: amd64
pkg: k8s.io/component-base/metrics/prometheusextension
cpu: Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
BenchmarkTimingHistogram-16    	22232037	        52.79 ns/op	       0 B/op	       0 allocs/op
PASS
ok  	k8s.io/component-base/metrics/prometheusextension	1.404s

(base) mspreitz@mjs12 kubernetes % go test -benchmem -run=^$ -bench ^BenchmarkTimingHistogram$ k8s.io/component-base/metrics/prometheusextension
goos: darwin
goarch: amd64
pkg: k8s.io/component-base/metrics/prometheusextension
cpu: Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
BenchmarkTimingHistogram-16    	22190997	        54.50 ns/op	       0 B/op	       0 allocs/op
PASS
ok  	k8s.io/component-base/metrics/prometheusextension	1.435s
```

and

```
(base) mspreitz@mjs12 kubernetes % go test -benchmem -run=^$ -bench ^BenchmarkTimingHistogramDirect$ k8s.io/component-base/metrics/prometheusextension
goos: darwin
goarch: amd64
pkg: k8s.io/component-base/metrics/prometheusextension
cpu: Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
BenchmarkTimingHistogramDirect-16    	28863244	        40.99 ns/op	       0 B/op	       0 allocs/op
PASS
ok  	k8s.io/component-base/metrics/prometheusextension	1.890s
(base) mspreitz@mjs12 kubernetes %
(base) mspreitz@mjs12 kubernetes %
(base) mspreitz@mjs12 kubernetes % go test -benchmem -run=^$ -bench ^BenchmarkTimingHistogramDirect$ k8s.io/component-base/metrics/prometheusextension
goos: darwin
goarch: amd64
pkg: k8s.io/component-base/metrics/prometheusextension
cpu: Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
BenchmarkTimingHistogramDirect-16    	27994173	        40.37 ns/op	       0 B/op	       0 allocs/op
PASS
ok  	k8s.io/component-base/metrics/prometheusextension	1.384s
```

So the new implementation is roughly 20% faster than the original.

Add overlooked exception, rename timingHistogram to timingHistogramLayered

Use the direct (one mutex) style of TimingHistogram impl

This is about a 20% gain in CPU speed on my development machine, in
benchmarks without lock contention.  Following are two consecutive
trials.

(base) mspreitz@mjs12 prometheusextension % go test  -benchmem -run=^$ -bench Histogram .
goos: darwin
goarch: amd64
pkg: k8s.io/component-base/metrics/prometheusextension
cpu: Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
BenchmarkTimingHistogramLayered-16    	21650905	        51.91 ns/op	       0 B/op	       0 allocs/op
BenchmarkTimingHistogramDirect-16     	29876860	        39.33 ns/op	       0 B/op	       0 allocs/op
BenchmarkWeightedHistogram-16         	49227044	        24.13 ns/op	       0 B/op	       0 allocs/op
BenchmarkHistogram-16                 	41063907	        28.82 ns/op	       0 B/op	       0 allocs/op
PASS
ok  	k8s.io/component-base/metrics/prometheusextension	5.432s

(base) mspreitz@mjs12 prometheusextension % go test  -benchmem -run=^$ -bench Histogram .
goos: darwin
goarch: amd64
pkg: k8s.io/component-base/metrics/prometheusextension
cpu: Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
BenchmarkTimingHistogramLayered-16    	22483816	        51.72 ns/op	       0 B/op	       0 allocs/op
BenchmarkTimingHistogramDirect-16     	29697291	        39.39 ns/op	       0 B/op	       0 allocs/op
BenchmarkWeightedHistogram-16         	48919845	        24.03 ns/op	       0 B/op	       0 allocs/op
BenchmarkHistogram-16                 	41153044	        29.26 ns/op	       0 B/op	       0 allocs/op
PASS
ok  	k8s.io/component-base/metrics/prometheusextension	5.044s

Remove layered implementation of TimingHistogram
2022-04-28 17:36:06 -04:00
Danielle Lancashire
f1f45df2c1 hack: make test-e2e-node: remove old project refs
This commit cleans up references to the old kubernetes-node-e2e-images
project. In the process it removes the `LIST_IMAGES` mode as listing
large numbers of public cloud projects is not particularly useful, and
has been somewhat broken for a long period of time - as we defaulted
launching a VM to a different project than listing.
2022-04-22 00:59:25 +02:00
vitt-bagal
969ddfbd72 Add fast build support for s390x 2022-04-21 01:47:26 -07:00
kayxhding
33ce0cbe9c refactor(hack): use ${BASH_SOURCE[0]} to get script name 2022-04-16 23:58:13 +08:00
Kubernetes Prow Robot
10dcc6c5f4
Merge pull request #109484 from liggitt/go-min-version
Update min golang version to 1.18.1
2022-04-14 09:20:47 -07:00
Kubernetes Prow Robot
a8c582a765
Merge pull request #109312 from MadhavJivrajani/remove-sha1-godebug
hack/jenkins: Remove GODEBUG workaround for sha1 changes
2022-04-14 07:06:46 -07:00
Jordan Liggitt
f97bc825d5 Update min golang version to 1.18.1 2022-04-14 09:53:20 -04:00
Stephen Augustus
3f85937b11
etcd: Update to v3.5.3
Signed-off-by: Stephen Augustus <foo@auggie.dev>
2022-04-13 19:04:00 -04:00
Priyanka Saggu
0e92873ee5
update verify-licenses.sh to make it execute in a different git worktree 2022-04-13 21:00:56 +05:30