Commit Graph

35756 Commits

Author SHA1 Message Date
Patrick Ohly
1db1263476 storage: add test for ValidateCSIDriverUpdate
Adding this test was forgotten when adding CSIDriver.
2019-08-13 23:12:52 +02:00
Patrick Ohly
7bbc06fcd4 storage: check CSIDriver.Spec.VolumeLifecycleModes
Using a "normal" CSI driver for an inline ephemeral volume may have
unexpected and potentially harmful effects when the driver gets a
NodePublishVolume call that it isn't expecting. To prevent that mistake,
driver deployments for a driver that supports such volumes must:
- deploy a CSIDriver object for the driver
- set CSIDriver.Spec.VolumeLifecycleModes such that it contains "ephemeral"

The default for that field is "persistent", so existing deployments
continue to work and are automatically protected against incorrect
usage.

For the E2E tests we need a way to specify the driver mode. The
existing cluster-driver-registrar doesn't support that and also was
deprecated, so we stop using it altogether and instead deploy and
patch a CSIDriver object.
2019-08-13 23:12:52 +02:00
Patrick Ohly
b60f08e24b storage: validate CSIDriver.Spec.VolumeLifecycleModes
This ensures that users get a good error message early on when trying
to do something that isn't okay:

  $ kubectl create -f csi-hostpath-driverinfo.yaml
  The CSIDriver "hostpath.csi.k8s.io" is invalid: spec.volumeLifecycleModes: Unsupported value: "foobar": supported values: "persistent", "ephemeral"
2019-08-13 23:12:48 +02:00
Patrick Ohly
f7742fd31a storage: generated files for CSIDriver.Spec.VolumeLifecycleModes 2019-08-13 23:11:42 +02:00
Patrick Ohly
029fd47757 storage: introduce CSIDriver.Spec.VolumeLifecycleModes
Using a "normal" CSI driver for an inline ephemeral volume may have
unexpected and potentially harmful effects when the driver gets a
NodePublishVolume call that it isn't expecting. To prevent that mistake,
driver deployments for a driver that supports such volumes must:
- deploy a CSIDriver object for the driver
- list "ephemeral" as one of the supported modes

The default is "persistent", so existing deployments continue to work
and are automatically protected against incorrect usage.

This commit contains the API change. Generated code and manual code
which uses the new API follow.
2019-08-13 23:11:36 +02:00
Kubernetes Prow Robot
f3c94c9c42 Merge pull request #81151 from mrkm4ntr/remove-node-lister
Remove algorithm.NodeLister from scheduler interface
2019-08-13 12:29:55 -07:00
Kubernetes Prow Robot
c505bb9533 Merge pull request #80985 from ethan-daocloud/patch-6
fixup: correct file name in log message
2019-08-13 12:29:42 -07:00
Kubernetes Prow Robot
6d921c0eb5 Merge pull request #80779 from andrewsykim/ipvs-test-tables
proxy/ipvs: refactor IPVS unit tests TestClusterIP and TestNodePort to use test tables
2019-08-13 07:55:42 -07:00
Wei Huang
a4d97cc47d kubectl: eliminate unnecessary blank ending line (#81229)
* kubectl: eliminate unnecessary blank ending line

* address comments and add more tests
2019-08-13 04:50:20 -07:00
Kubernetes Prow Robot
2e72cdd7b1 Merge pull request #81081 from p0lyn0mial/gc_transition_delete
changes the way `gc` detect that an object needs to be deleted
2019-08-13 02:28:33 -07:00
Kubernetes Prow Robot
0eb2e21352 Merge pull request #81013 from Madhu-1/fix-err
Fix logging message during unmounting
2019-08-13 02:28:07 -07:00
Kubernetes Prow Robot
12a085f917 Merge pull request #80942 from gongguan/fix_ipvs_svc_del
fix ipvs_svc deletion
2019-08-13 02:27:54 -07:00
Kubernetes Prow Robot
ac2295a24d Merge pull request #78587 from kad/socketmask-string
Use go standard library for common bit operations
2019-08-13 00:03:39 -07:00
Kubernetes Prow Robot
76e19a1619 Merge pull request #81204 from codenrhoden/rename-hu-pathexists
Rename HostUtils.ExistsPath to PathExists
2019-08-12 20:12:12 -07:00
Kubernetes Prow Robot
56b5f8b47c Merge pull request #80519 from ethan-daocloud/patch-1
fix typos in kubelet.go
2019-08-12 20:11:51 -07:00
Shintaro Murakami
11f043c784 Remove algorithm.NodeLister from scheduler interface
Will fixup
2019-08-13 10:30:30 +09:00
Kubernetes Prow Robot
890b50f98b Merge pull request #80952 from tedyu/storage-ret-err
Propagate error from NewREST
2019-08-12 18:21:52 -07:00
Kubernetes Prow Robot
2f91fcc3fd Merge pull request #80825 from tallclair/runtimeclass-scheduling-api
Runtimeclass scheduling api
2019-08-12 18:21:39 -07:00
Ted Yu
87b2a3129b Propagate error from NewREST 2019-08-12 13:55:35 -07:00
ethan
94efd3fcdf cleanup: proxier.go error message fix 2019-08-12 22:36:16 +08:00
Lukasz Szaszkiewicz
2d81cee900 changes the way gc detect that an object needs to be deleted
before this change, an object would be added to `attemptToDelete` queue only if `gc` detected the transition, simply by check if `deletionTimestamp` was set. After the change, it will check if `foregroundDeletion` finalizer has been set before adding the item to the queue.
2019-08-12 10:52:43 +02:00
Madhu Rajanna
ec5ff52b88 Fix logging message during unmounting
use errors.New() if formatting is not  required

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2019-08-12 09:18:35 +05:30
Kubernetes Prow Robot
46e58df837 Merge pull request #79578 from cezarsa/stable-node-images
kubelet: ensure stable order for images in node status
2019-08-10 08:59:12 -07:00
Kubernetes Prow Robot
c0997e8dc1 Merge pull request #81174 from answer1991/reduce-node-lease-get
reduce kubelet getting node lease
2019-08-10 02:59:26 -07:00
Kubernetes Prow Robot
37647eb88a Merge pull request #79978 from cwdsuzhou/July/hostpath_cleanup
Fix host path test clean up
2019-08-10 02:59:13 -07:00
Kubernetes Prow Robot
1d812991b6 Merge pull request #81230 from codenrhoden/rename-GetFSGroup
Rename HostUtils.GetFSGroup to HostUtils.GetOwner
2019-08-09 23:57:26 -07:00
Kubernetes Prow Robot
d816998bd8 Merge pull request #81187 from codenrhoden/rename-newosexec
Rename mount.NewOsExec to mount.NewOSExec
2019-08-09 22:17:13 -07:00
Kubernetes Prow Robot
c8c9d2e21c Merge pull request #77167 from paulsubrata55/spaul-kube-proxy-fix
Fix for kube-proxy to wait for some duration for the node to be defined.
2019-08-09 19:47:14 -07:00
Kubernetes Prow Robot
406904269d Merge pull request #81210 from figo/metrics
Add iptables restore failure metric
2019-08-09 16:33:14 -07:00
louisssgong
97c4edaa4f Fix a bug in the IPVS proxier where virtual servers are not cleaned up even though the corresponding Service object was deleted. 2019-08-10 06:32:38 +08:00
Kubernetes Prow Robot
31bade3822 Merge pull request #81046 from liggitt/admission-side-effects
Limit v1 webhooks to None and NoneOnDryRun side effects classes
2019-08-09 13:55:27 -07:00
Travis Rhoden
0e73131ca6 Rename HostUtils.GetFSGroup to HostUtils.GetOwner
This patch renames GetFSGroup (a process property) to GetOwner (a file
property), returning both the uid and gid of the given pathname. This
method is only used in one place in the k/k codebase, but having
"GetOwner" instead of "GetGroup" seems to have more utility.
2019-08-09 13:20:35 -06:00
Travis Rhoden
14e25b7c04 Rename HostUtils.ExistsPath to PathExists 2019-08-09 12:40:19 -06:00
Travis Rhoden
4574473753 Rename mount.NewOsExec to mount.NewOSExec 2019-08-09 12:30:56 -06:00
Tim Allclair
d54879862b Update generated files 2019-08-09 11:13:07 -07:00
Yassine TIJANI
009658d643 Introduce topology into the runtimeClass API
Co-authored-by: Tim Allclair <tallclair@google.com>
2019-08-09 11:13:07 -07:00
Kubernetes Prow Robot
acaac181dc Merge pull request #81180 from codenrhoden/mount-pkg-lint
Fix most linting issues in pkg/util/mount
2019-08-09 10:53:14 -07:00
hui luo
a2ef00c1b1 Add iptables restore failure metrics
As mentioned in issue #80061, in iptables lock contention case,
we can see increasing rate of iptables restore failures because it
need to grab iptables file lock.

The failure metric can provide administrators more insight

Metrics will be collected in kube-proxy iptables and ipvs modes

Signed-off-by: Hui Luo <luoh@vmware.com>
2019-08-09 10:18:19 -07:00
chenjun.cj
acdac6e999 reduce kubelet getting node lease 2019-08-09 19:00:50 +08:00
Kubernetes Prow Robot
3f6f3fc3f9 Merge pull request #80416 from mrkm4ntr/metrics-framework-returns-unschedulable
Record metrics when framework returns unschedulable error
2019-08-09 03:01:25 -07:00
caiweidong
41bb76bb88 make hostpath configurable for test 2019-08-09 10:59:29 +08:00
Kubernetes Prow Robot
d47f9ff132 Merge pull request #81086 from dims/fix-incorrect-readlink-check-for-checking-kernel-pids
[TOB-K8S-027] Fix Incorrect isKernelPid check
2019-08-08 17:58:04 -07:00
Kubernetes Prow Robot
2bea7a371b Merge pull request #80811 from liu-cong/loglevel
Lower verbosity level for some useful scheduler logs; Also add node resource info when pod is scheduled on node.
2019-08-08 17:57:38 -07:00
Kubernetes Prow Robot
aecc1e829c Merge pull request #81083 from dims/fix-docker-daemon-process-name
[TOB-K8S-025] Incorrect docker daemon process name in container manager
2019-08-08 16:12:18 -07:00
Kubernetes Prow Robot
806ced34a4 Merge pull request #80491 from hpandeycodeit/static_pod_priority
Changed IsCriticalPod to return true in case of static pods
2019-08-08 16:11:39 -07:00
Kubernetes Prow Robot
f4e39afea0 Merge pull request #81152 from tedyu/const-pass-cmp
Constant time password comparison
2019-08-08 12:35:59 -07:00
Kubernetes Prow Robot
744386857f Merge pull request #81104 from tallclair/cleanup
remove dead code: pkg/api/resources
2019-08-08 12:35:33 -07:00
Travis Rhoden
b47184e954 Fix most linting issues in pkg/util/mount
This patch adds comments to exported items that were missing them in
order to make the linter happy. Only code changes that were limited to
the scope of this package were made. There are other linting issues that
will effect callers, and that will be done a seperate patch.
2019-08-08 12:42:21 -06:00
Kubernetes Prow Robot
46e6fd12bf Merge pull request #80526 from rosti/remove-normalizer
Remove unused package //pkg/util/normalizer
2019-08-08 10:03:58 -07:00
Kubernetes Prow Robot
5257266e9b Merge pull request #79631 from Huang-Wei/sched-q-flake
Fixed a racing issue in scheduler UT
2019-08-08 10:03:19 -07:00