Kubernetes Prow Robot
2590f6cc77
Merge pull request #89435 from humblec/correct
...
Clean some code paths and correct static errors
2020-03-31 05:14:40 -07:00
Kubernetes Prow Robot
e178cacb97
Merge pull request #89589 from jsafrane/fix-node-startup
...
Wait for APIServer 'ok' forever during CSINode initialization during Kubelet init
2020-03-30 07:02:08 -07:00
Humble Chirammal
31b837b420
Clean some code paths and correct static errors
...
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2020-03-30 17:34:06 +05:30
Kubernetes Prow Robot
a329e67922
Merge pull request #89511 from andyzhangx/sharedisk
...
feat: add azure shared disk support
2020-03-29 17:29:53 -07:00
andyzhangx
51e0bd2480
feat: add azure shared disk support
...
fix comment
2020-03-29 09:35:15 +00:00
Jan Safranek
8bdbd4d683
Fix CSINodeInfo startup
...
To speed up unit tests and add more observability when things go wrong.
2020-03-27 18:29:34 +01:00
David Zhu
8205f815fb
Wait for APIServer 'ok' forever during CSINode initialization during Kubelet init
2020-03-27 18:27:57 +01:00
Kubernetes Prow Robot
99d0559ab4
Merge pull request #89172 from jsafrane/fix-mount-opts
...
Fix mountOptions in iSCSI and FC volume plugins
2020-03-26 15:58:23 -07:00
Jan Safranek
58129fd12c
Fix mount options in FibreChannel volumes
...
Do not mount volumes in WaitForAttach(), mount them in MountDevice()
instead. They will get proper mount options this way.
2020-03-26 18:01:19 +01:00
Shihang Zhang
b56da85a77
sync api/v1/pod/util with api/pod/util and remove DefaultContainers
2020-03-24 16:42:32 -07:00
andyzhangx
f889213d38
feat: support Azure shared disk
2020-03-21 13:16:22 +00:00
Kubernetes Prow Robot
173b5ee6f7
Merge pull request #89250 from andyzhangx/disk-version
...
feat: change azure disk api-version
2020-03-21 02:56:57 -07:00
Kubernetes Prow Robot
2c8ef3b19d
Merge pull request #89196 from YuikoTakada/fix_non_aschii_pkg_volume_iscsi
...
Fix non-ascii characters in pkg/volume/iscsi/iscsi_util_test.go
2020-03-19 10:28:08 -07:00
andyzhangx
12c6c81b1a
feat: change azure disk api-version
2020-03-19 10:51:53 +00:00
Yuiko Mori
558e8bb199
Fix non-ascii characters in pkg/volume/iscsi/iscsi_util_test.go
2020-03-18 02:14:07 +00:00
Jan Safranek
f60a0c8660
Fix mount options in iSCSI volumes
...
Do not mount volumes in WaitForAttach(), mount them in MountDevice()
instead. They will get proper mount options this way.
2020-03-17 11:37:18 +01:00
andyzhangx
da20cc202f
chore: upgrade to azure-sdk v40.2.0
...
chore: use autorest v0.9.6
fix go module issue
fix go module error
2020-03-13 11:51:25 +00:00
Kubernetes Prow Robot
ef672c1c2d
Merge pull request #88678 from verult/slow-rxm-attach
...
Parallelize attach operations across different nodes for volumes that allow multi-attach
2020-03-06 13:17:21 -08:00
Christian Huffman
d0890533a9
Updated files after rebase
2020-03-06 08:56:59 -05:00
Christian Huffman
c6fd25d100
Updated CSIDriver references
2020-03-06 08:21:26 -05:00
Kubernetes Prow Robot
5708511499
Merge pull request #88708 from mikedanese/deleteopts
...
Migrate clientset metav1.DeleteOpts to pass-by-value
2020-03-05 23:09:23 -08:00
Cheng Xing
ef3d66b98b
Parallelize attach operations across different nodes for volumes that allow multi-attach
2020-03-05 22:22:05 -08:00
Mike Danese
c58e69ec79
automated refactor
2020-03-05 14:59:46 -08:00
Hemant Kumar
b132959687
Start adding tests for verifying correct modes
...
Add an example for permission bits checking
2020-03-05 08:00:27 -05:00
Hemant Kumar
c52d4bf32f
Implement changes into volume plugins for skipping chown
...
Add a separate function for walking directories
2020-03-04 21:23:31 -05:00
Hemant Kumar
053baaf143
Update generated files
...
update generated code
2020-03-04 21:23:31 -05:00
Kubernetes Prow Robot
cd23e78c3d
Merge pull request #88684 from saad-ali/updateMountLib
...
Update AzureFile and CephFS to use MountSensitive
2020-03-03 21:05:48 -08:00
Kubernetes Prow Robot
9d0cbb7503
Merge pull request #88673 from jsafrane/block-feature-ga
...
Promote block volumes to GA
2020-03-03 12:17:12 -08:00
saad-ali
3784438b56
Prevent CephFS from logging senstive options
2020-03-03 11:20:08 -08:00
saad-ali
548b297a00
Prevent AzureFile from logging senstive options
2020-03-03 11:20:08 -08:00
saad-ali
727582311f
Fix MountError Test
2020-03-03 11:20:08 -08:00
Kubernetes Prow Robot
ac55a51034
Merge pull request #85056 from pohsienshih/volume/golint
...
Fix golint issues for pkg/volume/rbd
2020-03-03 01:37:37 -08:00
Jan Safranek
3af671011a
Generated API
2020-03-02 22:21:42 +01:00
Jan Safranek
afcbb68386
Fix unit test to fail with proper final gRPC code
...
Plain "errors.New" is interpreted as transient error.
2020-03-02 12:54:03 +01:00
Jan Safranek
8536787133
Add unit tests
2020-03-02 12:54:02 +01:00
Jan Safranek
c11427fef5
Call NodeUnstage after NodeStage timeout
...
When NodeStage times out and does not prepare destination device and user
deletes corresponding pod, the driver may continue staging the volume in
background. Kubernetes must call NodeUnstage to "cancel" this operation.
Therefore TearDownDevice should be called even when the target directory
does not exist (yet).
2020-03-02 12:54:02 +01:00
Jan Safranek
f6fc73573c
Call NodeUnpublish after NodePublish timeout
...
When NodePublish times out and user deletes corresponding pod, the driver
may continue publishing the volume. In order to "cancel" this operation,
Kubernetes must issue NodeUnpublish and wait until it finishes.
Therefore, NodeUnpublish should be called even if the target directory
(created by the driver) does not exist yet.
2020-03-02 12:54:02 +01:00
Jan Safranek
86a5bd98b6
Add uncertain map state to block volumes
...
Volume mount should be marked as uncertain after NodeStage / NodePublish
timeout or similar error, when the driver can continue with the operation in
background.
2020-03-02 12:54:02 +01:00
Kubernetes Prow Robot
39ed64ec4c
Merge pull request #88569 from andyzhangx/csi-corrupt-mnt-fix
...
fix: corrupted mount point in csi driver node stage/publish
2020-03-02 03:30:43 -08:00
pohsienshih
9bfe818229
Fixed golint issues in RBD code
2020-02-29 23:36:58 +08:00
Jan Safranek
2c1b743766
Promote block volume features to GA
2020-02-28 20:48:38 +01:00
Kubernetes Prow Robot
c73532c4f7
Merge pull request #88610 from andyzhangx/azurefile-mount-fix
...
fix: azure file mount timeout issue
2020-02-27 22:10:50 -08:00
Kubernetes Prow Robot
a555825ab4
Merge pull request #88602 from yuga711/pd-limit
...
Fix to expose max gce-pd disks per instance
2020-02-27 16:12:53 -08:00
andyzhangx
fb7209486e
fix: azure file mount timeout issue
2020-02-27 09:29:27 +00:00
Jayasekhar Konduru
505dff6d20
Fixed in the GCE/PD in-tree volume logic to expose the max number of
...
persistent-disks for each instance type correctly.
Tested: Verified the kubernetes node object shows correct limits for
various instance types (n1-, c2-, e2-).
2020-02-26 18:20:37 -08:00
andyzhangx
5a6435ad76
fix: corrupted mount point in csi driver
...
add test
fix build failure and bazel
fix golint
2020-02-26 09:43:51 +00:00
Kubernetes Prow Robot
851efa8a34
Merge pull request #84051 from bart0sh/PR0079-multiple-sizes-hugepages
...
Implement support for multiple sizes huge pages
2020-02-25 14:40:27 -08:00
Kubernetes Prow Robot
c69c91987b
Merge pull request #87811 from mborsz/pv
...
Remove unnecessary calls to GCE API after PD is created
2020-02-21 18:31:01 -08:00
Ed Bartosh
03ecc20b19
empty_dir: Check if hugetlbfs volume is mounted with a correct pagesize
...
Extended GetMountMedium function to check if hugetlbfs volume
is mounted with the page size equal to the medium size.
Page size is obtained from the 'pagesize' mount option of the
mounted hugetlbfs volume.
2020-02-20 13:57:36 +02:00
Ed Bartosh
882d6e93af
Implement tests for multiple sizes huge pages
...
Co-Authored-By: Odin Ugedal <odin@ugedal.com>
2020-02-19 18:15:40 +02:00
Ed Bartosh
0eb65bd7da
Implement support for multiple sizes huge pages
...
This implementation allows Pod to request multiple hugepage resources
of different size and mount hugepage volumes using storage medium
HugePage-<size>, e.g.
spec:
containers:
resources:
requests:
hugepages-2Mi: 2Mi
hugepages-1Gi: 2Gi
volumeMounts:
- mountPath: /hugepages-2Mi
name: hugepage-2mi
- mountPath: /hugepages-1Gi
name: hugepage-1gi
...
volumes:
- name: hugepage-2mi
emptyDir:
medium: HugePages-2Mi
- name: hugepage-1gi
emptyDir:
medium: HugePages-1Gi
NOTE: This is an alpha feature.
Feature gate HugePageStorageMediumSize must be enabled for it to work.
2020-02-19 18:15:40 +02:00
Kubernetes Prow Robot
da9db64f9c
Merge pull request #87978 from jsafrane/block-csi-test
...
Add CSI block volume directory cleanup
2020-02-19 00:34:24 -08:00
Jan Safranek
073d0b2340
Add getPublishDir and getVolumePluginDir
...
So we don't need to compute these backwards from getPublishPath and
getVolumeDevicePluginDir.
2020-02-17 10:51:39 +01:00
Kubernetes Prow Robot
8b2f08f39d
Merge pull request #88201 from andyzhangx/update-max-disk-count
...
fix: update azure disk max count
2020-02-16 01:47:28 -08:00
andyzhangx
6a773fb9c2
fix: update max azure disk max count
2020-02-16 02:46:27 +00:00
Kubernetes Prow Robot
3e3a3599ca
Merge pull request #87711 from alena1108/jan30volume
...
Ineffassign fixes for pkg/volume
2020-02-14 21:53:28 -08:00
andyzhangx
6068ce96b1
fix: get azure disk lun timeout issue
2020-02-14 12:51:42 +00:00
Hemant Kumar
c058073046
Add a event to PV when mount fails because of fs mismatch
...
Filesystem mismatch is a special event. This could indicate
either user has asked for incorrect filesystem or there is a error
from which mount operation can not recover on retry.
Co-Authored-By: Jordan Liggitt <jordan@liggitt.net>
2020-02-13 12:29:42 -05:00
Jan Safranek
0bd2e629c7
Fix unit tests
2020-02-13 12:20:03 +01:00
Jan Safranek
e2d8e575f0
Add CSI block volume directory cleanup
...
CSI volume plugin creates number of files/directories when processing block
volumes. These files must be cleaned when the plugin is done with the
volume, i.e. at the end on TearDownDevice().
2020-02-13 12:19:31 +01:00
Maciej Borsz
c78c0e949d
Remove unnecessary calls to GCE API after PD is created.
2020-02-13 09:57:25 +01:00
Kubernetes Prow Robot
177506d87c
Merge pull request #87945 from andyzhangx/azure-writeaccelerator
...
add azure disk WriteAccelerator support
2020-02-12 21:37:24 -08:00
Kubernetes Prow Robot
92be16ce82
Merge pull request #88014 from andyzhangx/azure-csi-migration
...
fix: add azure disk migration support on CSINode
2020-02-11 23:16:09 -08:00
Kubernetes Prow Robot
fd0b34d69d
Merge pull request #87911 from tedyu/rm-exp-backoff
...
Remove the exponential backoff in NodeGetInfo
2020-02-11 23:15:10 -08:00
andyzhangx
9cb7f54c0b
fix: add azure disk migration support for CSINode
2020-02-11 11:39:55 +00:00
Mike Danese
25651408ae
generated: run refactor
2020-02-08 12:30:21 -05:00
Kubernetes Prow Robot
334d788f08
Merge pull request #87299 from mikedanese/ctx
...
context in client-go
2020-02-08 06:43:52 -08:00
andyzhangx
657dedc3be
add azure disk WriteAccelerator support
2020-02-08 07:43:21 +00:00
Kubernetes Prow Robot
6d4e2d722e
Merge pull request #87381 from yuxiaobo96/k8s-staticcheck3
...
staticcheck: pkg/volume/fc, pkg/volume/portworx and pkg/volume/vspher…
2020-02-07 18:32:58 -08:00
Mike Danese
3aa59f7f30
generated: run refactor
2020-02-07 18:16:47 -08:00
Kubernetes Prow Robot
cbffb19c76
Merge pull request #87609 from mvisonneau/rbd_mount_ro_fix
...
Fixed a failing test on a RBD mount scenario
2020-02-07 12:32:03 -08:00
Ted Yu
f48e5de963
Remove the exponential backoff in NodeGetInfo
2020-02-07 06:39:12 -08:00
Kubernetes Prow Robot
c24fa741ae
Merge pull request #87499 from ejweber/fc-mount-options
...
FC mount options
2020-02-07 05:55:56 -08:00
Kubernetes Prow Robot
69e01784c1
Merge pull request #87838 from Ikuyadeu/path2filepath
...
Move 'path' package usage to 'path/filepath' (repeat the #87713 )
2020-02-06 17:48:11 -08:00
Ted Yu
871739e4df
Check getNodeInfoError against nil
2020-02-06 10:57:43 -08:00
Yuki Ueda
d1bc1875aa
Move 'path' package usage to 'path/filepath'
2020-02-05 14:29:27 +09:00
Kubernetes Prow Robot
76c89645c5
Merge pull request #87713 from kkmsft/filepath-fixes-windows
...
Move 'path' package usage to 'path/filepath'.
2020-02-03 17:07:25 -08:00
Eric Weber
adcdb2fd72
Enable FC mount options
2020-02-03 16:13:58 -06:00
Kubernetes Prow Robot
845b232321
Merge pull request #87451 from jnaulty/jnaulty/fix-aws-ebs-createvolume-signature
...
Fix CreateVolume signature in comment
2020-02-03 10:51:21 -08:00
Alena Prokharchyk
331cd94ccc
Ineffassign fixes for pkg/volume
...
Along resolves errors whitelisted in hack/.staticcheck_failures
2020-01-31 10:14:45 -08:00
Kubernetes Prow Robot
0b18af6d43
Merge pull request #87384 from yuxiaobo96/k8s-cleanup
...
cleanup: delete unused func
2020-01-30 16:58:47 -08:00
Krishnakumar R(KK)
72fe307b35
Move 'path' package usage to 'path/filepath'.
...
In case of windows, the path package functions such as 'Dir' returns faulty directory path.
For eg: 'path.Dir' on 'c:\var\lib\kubelet\pods' returns '.', where as the result should
have been 'c:\var\lib\kubelet'. The filepath package returns the right values.
2020-01-30 15:53:18 -08:00
Jordan Liggitt
cd1059e3c4
Revert "Merge pull request #87258 from verult/slow-rxm-attach"
...
This reverts commit 15c3f1b119
, reversing
changes made to 52d7614a8c
.
2020-01-29 14:58:32 -05:00
Kubernetes Prow Robot
17936ff63b
Merge pull request #87544 from SenXuDC/staticcheck
...
fix static check in pkg/volume/flocker
2020-01-29 07:32:42 -08:00
Maxime VISONNEAU
bea4b61158
Fixed a failing test on a RBD mount scenario
2020-01-28 12:44:34 +00:00
Cheng Xing
c6a03fa5be
Parallelize attach operations across different nodes for volumes that allow multi-attach
2020-01-27 15:02:25 -08:00
Cheng Xing
37957e2a0d
Refactor operation keys for NestedPendingOperations
2020-01-27 10:42:16 -08:00
SenXuDC
7c72b5791b
fix static check in pkg/volume/flocker
2020-01-25 10:51:55 +08:00
Kubernetes Prow Robot
6c693549a3
Merge pull request #87183 from Aresforchina/fix-staticcheck-test15
...
fix-staticcheck:pkg/volume/scaleio/
2020-01-23 22:20:31 -08:00
John Naulty
80c3f500b6
Fix CreateVolume signature in comment
...
The CreateVolume function for aws-ebs provsiioner returns fstype, which
was missing from the commented section above the function declaration.
2020-01-22 01:06:26 -08:00
Kubernetes Prow Robot
f680c261e6
Merge pull request #87074 from yuxiaobo96/k8s-staticcheck
...
fix staticcheck: pkg/volume/awsebs
2020-01-20 03:09:37 -08:00
yuxiaobo
221396ac35
cleanup: delete unused func
...
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
2020-01-20 18:20:57 +08:00
yuxiaobo
72f34b817e
staticcheck: pkg/volume/fc, pkg/volume/portworx and pkg/volume/vsphere_volume
...
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
2020-01-20 16:47:54 +08:00
Kubernetes Prow Robot
3d8317ae91
Merge pull request #87139 from yuxiaobo96/k8s-staticcheck2
...
fix staticcheck:pkg/volume/cinder
2020-01-19 21:47:36 -08:00
Kubernetes Prow Robot
f88f58cb79
Merge pull request #87245 from 928234269/fix_staticcheck
...
fix staticcheck errors in pkg/volume/hostpath.
2020-01-17 12:15:18 -08:00
Sakura
fe8b32317f
delete unused field
...
Signed-off-by: Sakura <longfei.shang@daocloud.io>
2020-01-17 19:34:48 +08:00
Paul Morie
afaea605f4
Remove Brad Childs from OWNERS files
2020-01-16 15:21:34 -05:00
Kubernetes Prow Robot
0c1d714627
Merge pull request #87128 from Aresforchina/fix-staticcheck-test12
...
fix-staticcheck:pkg/volume/emptydir
2020-01-16 07:48:50 -08:00
Kubernetes Prow Robot
15aa065e86
Merge pull request #86569 from zouyee/btos
...
using string instead of byte
2020-01-15 08:25:49 -08:00
Sakura
4143bc7a96
fix staticcheck errors in pkg/volume/hostpath.
...
Signed-off-by: Sakura <longfei.shang@daocloud.io>
2020-01-15 22:54:48 +08:00
Aresforchina
514bdbedac
fix-static:pkg/volume/scaleio/
2020-01-15 09:53:27 +08:00
yuxiaobo
da15570daa
fix staticcheck:pkg/volume/cinder
...
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
2020-01-13 18:20:23 +08:00
Aresforchina
e62f9625cf
fix-static:pkg/volume/emptydir
2020-01-13 15:23:45 +08:00
sunxiaofei03
330159c0a4
fix orphaned pod flexvolume can not be cleaned up
2020-01-11 14:54:48 +08:00
yuxiaobo
c5764735e2
fix staticcheck:pkg/volume/awsebs
...
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
2020-01-10 18:36:39 +08:00
Rita Zhang
b062fcb117
Update Azure owners
2020-01-09 18:35:18 -08:00
Kubernetes Prow Robot
d6412b856f
Merge pull request #84345 from danielqsj/withdialer
...
replace grpc.WithDialer which is deprecated
2020-01-06 15:56:17 -08:00
Kubernetes Prow Robot
4158e7c1de
Merge pull request #85123 from danielqsj/apierrs
...
Unify aliases for "k8s.io/apimachinery/pkg/api/errors"
2019-12-26 17:59:38 -08:00
danielqsj
19fe9f8d94
replace grpc.WithDialer which is deprecated
2019-12-26 17:46:59 +08:00
danielqsj
5bc0e26c19
unify alias of api errors under pkg and staging
2019-12-26 16:42:28 +08:00
andyzhangx
36393390f4
fix: azure disk could not mounted on Standard_DC4s/DC2s instances
2019-12-25 13:55:58 +00:00
zouyee
bae72ee8d2
using string instead of byte
...
Signed-off-by: Zou Nengren <zouyee1989@gmail.com>
2019-12-24 09:23:02 +08:00
SataQiu
2497a1209b
bump k8s.io/utils version
2019-12-21 14:54:44 +08:00
Kubernetes Prow Robot
40df9f82d0
Merge pull request #82492 from gnufied/fix-uncertain-mounts
...
Fix uncertain mounts
2019-12-17 14:49:57 -08:00
Ted Yu
62d7772882
Check FileInfo against nil during walk of container dir path
2019-12-16 17:59:17 -08:00
Hemant Kumar
ca532c6fb2
Ensure that error is returned on NodePublish
2019-12-11 22:10:09 -05:00
Hemant Kumar
4b8e552a88
Use typed errors for special casing volume progress
...
Use typed errors rather than operation status for
indicating operation progress
2019-12-04 14:48:30 -05:00
Kubernetes Prow Robot
97e34ee223
Merge pull request #85475 from andyzhangx/upgrade-azure-storage-lib
...
upgrade api-version to fix azure file AuthorizationFailure
2019-12-02 17:07:10 -08:00
Hemant Kumar
0741f6fa29
Ensure that metadata directory is not created if secret is not found
...
To ensure that metadata directory is not created if secret is not
found, we will move fetching secrets bit more earlier in the code.
2019-12-02 12:09:38 -05:00
Hemant Kumar
309c6f863a
Handle the case of remounts correctly
2019-12-02 12:09:38 -05:00
Hemant Kumar
5feea93163
Rename MarkVolumeMountedOpts to MarkVolumeOpts
...
Also remove VolumeNotMounted state
2019-12-02 12:09:38 -05:00
Hemant Kumar
cdbd3ba5c2
Change interface of SetUp function
2019-12-02 12:09:38 -05:00
Hemant Kumar
db9ac38592
Change signature of MountDevice function and remove MountDeviceWithStatusTracking
2019-12-02 12:09:38 -05:00
Hemant Kumar
0c52b6606e
Refactor NodeStage function
...
Timeout operations should result in
Fix unit tests for uncertainDeviceGlobalMounts
2019-12-02 12:09:38 -05:00
Hemant Kumar
57019e0628
Add tests for verifying in-progress state
2019-12-02 12:09:38 -05:00
Hemant Kumar
27a70a9260
Update generated files
2019-12-02 12:09:38 -05:00
Hemant Kumar
321e99367a
Add code to handle Setup With Status tracking
2019-12-02 12:09:38 -05:00
Hemant Kumar
dc9e64c31e
Implement return status codes
2019-12-02 12:02:27 -05:00
Hemant Kumar
50dbcb3e00
Make sure PodExistsInVolume does not uses uncertain volumes
2019-12-02 12:01:40 -05:00
Hemant Kumar
34a6007dfe
Add code to mark volume as uncertain
...
Update bazel files
Add tests for volume mounts in uncertain state
2019-12-02 12:01:40 -05:00
Hemant Kumar
a795f3de88
Add code for introducing uncertain state of mounts
...
Add a comment about volumestate
2019-12-02 11:57:40 -05:00
Ryan Roemmich
d44583d28a
Fix iscsi refcounter in the case of no Block iscsi volumes
2019-11-27 15:50:40 -08:00
Kubernetes Prow Robot
3aeb38afd3
Merge pull request #85493 from cofyc/local-owner
...
Add cofyc as owner of pkg/volume/local
2019-11-22 17:31:41 -08:00
Kubernetes Prow Robot
300ca89e60
Merge pull request #85426 from davidz627/fix/testCtx
...
Plumb test state through to fake volume host creation for error handling
2019-11-22 17:31:22 -08:00
Yecheng Fu
96eb647898
add cofyc as local volume owner
2019-11-21 09:38:49 +08:00
andyzhangx
6b73c9f8c2
upgrade api-version to fix azure file AuthorizationFailure
...
fix build failure
2019-11-20 05:41:25 +00:00
Benjamin Elder
753774d9ea
add providerless tag to vsphere volume code
2019-11-19 09:47:45 -08:00
Benjamin Elder
b100bf9654
add providerless tags to new awsebs code
2019-11-19 09:47:45 -08:00
David Zhu
21f7060c8f
Plumb test state through to fake volume host creation for error handling
2019-11-18 14:45:01 -08:00
David Zhu
86f20db7d0
Panic on error when creating fake volume host, add a TODO to clean up later
2019-11-15 11:23:32 -08:00
David Zhu
1a47bf54e2
De-race some CSI unit tests that were initializing the plugin manager…ger (and plugins) twice. Set some const variables earlier to support node info manager initialization and wait for initialization to complete before finishing plugin setup.
2019-11-15 11:23:32 -08:00
Travis Rhoden
0c5c3d8bb9
Remove pkg/util/mount (moved out of tree)
...
This patch removes pkg/util/mount completely, and replaces it with the
mount package now located at k8s.io/utils/mount. The code found at
k8s.io/utils/mount was moved there from pkg/util/mount, so the code is
identical, just no longer in-tree to k/k.
2019-11-15 08:29:12 -07:00
Kubernetes Prow Robot
372ebd24f5
Merge pull request #83098 from ddebroy/disable-intree
...
CSI Migration phase 2: disable probing of in-tree plugins
2019-11-14 20:51:42 -08:00
Masaki Kimura
4578c6c8ce
Separate staging/publish and unstaging/unpublish logics for block
2019-11-15 01:55:20 +00:00
Masaki Kimura
7caf731773
Change publish path for CSI block volume per pod
...
This change is to allow CSI driver to publish the same volume for multipe pods on the same node.
2019-11-15 01:55:15 +00:00
Deep Debroy
129f15328b
Disable in-tree plugins migrated to CSI
...
Signed-off-by: Deep Debroy <ddebroy@docker.com>
2019-11-14 17:28:21 -08:00
Masaki Kimura
a275026ad4
Split CustomBlockVolumeMapper and CustomBlockVolumeUnmapper
...
- Move SetUpDevice to BlockVolumeStager
- Move MapPodDevice to BlockVolumePublisher
- Move TearDownDevice to BlockVolumeUnstager
- Move UnmapPodDevice to BlockVolumeUnpublisher
- Implement BlockVolumePublisher only in local and csi plugin
- Implement BlockVolumeUnstager only in fc, iscsi, rbd, and csi plugin
- Implement BlockVolumeStager and BlockVolumeUnpublisher only in csi plugin
2019-11-14 22:01:19 +00:00
Masaki Kimura
f363a03f0b
Refactor BlockVolumeMapper and BlockVolumeUnmapper interface
...
- Rename MapDevice to MapPodDevice in BlockVolumeMapper
- Add UnmapPodDevice in BlockVolumeUnmapper (This will be used by csi driver later)
- Add CustomBlockVolumeMapper and CustomBlockVolumeUnmapper interface
- Move SetUpDevice and MapPodDevice to CustomBlockVolumeMapper
- Move TearDownDevice and UnmapPodDevice to CustomBlockVolumeUnmapper
- Implement CustomBlockVolumeMapper only in local and csi plugin
- Implement CustomBlockVolumeUnmapper only in fc, iscsi, rbd, and csi plugin
- Change MapPodDevice to return path and SetUpDevice not to return path
2019-11-14 22:01:11 +00:00
Masaki Kimura
560d9c56eb
Change mount.NewOSExec to utilexec.New
2019-11-14 15:58:27 +00:00
Masaki Kimura
8a09460c2f
Change getDeviceMajorMinor to use unix.Stat
2019-11-14 15:58:27 +00:00
Masaki Kimura
aee875a855
Fix error messages in operation_generator.go
2019-11-14 15:58:27 +00:00
Masaki Kimura
a2cbc028f4
Remove remaining empty file in unmapBindMountDevice
2019-11-14 15:58:27 +00:00
Masaki Kimura
dd945424e1
Rename IsBindMountExist to IsDeviceBindMountExist
2019-11-14 15:58:26 +00:00
Masaki Kimura
bee6514d79
Remove klog for output error instead return err with context
2019-11-14 15:58:26 +00:00
Masaki Kimura
7abb704e7b
Improve comments for volume path hanlder and volume.go
2019-11-14 15:58:26 +00:00
Masaki Kimura
5a351e3014
Check and return error first in IsSymlinkExist and IsBindMountExist
2019-11-14 15:58:26 +00:00
Masaki Kimura
8a159d7253
Move MapBlockVolume call to operation_generator and add UnmapBlockVolume
2019-11-14 15:58:26 +00:00
Masaki Kimura
68be3947b8
Make descriptor lock per pod and release it per pod
...
This change is needed to avoid unmapVolumeFunc for one pod blocked,
when the lock for the same volume is taken for another pod.
2019-11-14 15:58:26 +00:00
Masaki Kimura
2ecdc5e8d1
Change globalMapPath to bind mount from symlink
...
This change is needed to make descriptor lock per pod, in the next commit.
If losetup is called for symlink, path in the output for losetup is resolved,
as a result, we can't distinguish which path the lock is taken.
2019-11-14 15:58:26 +00:00
Travis Rhoden
367f879131
Retire mount.Exec for k8s.io/utils/exec
...
This patch removes mount.Exec entirely and instead uses the common
utility from k8s.io/utils/exec.
The fake exec implementation found in k8s.io/utils/exec differs a bit
than mount.Exec, with the ability to pre-script expected calls to
Command.CombinedOutput(), so tests that previously relied on a callback
mechanism to produce specific output have been updated to use that
mechanism.
2019-11-13 14:09:57 -07:00
Kubernetes Prow Robot
c580a12c8e
Merge pull request #83568 from bertinatto/volume_limits_ga
...
Promote volume limits to GA
2019-11-12 11:50:22 -08:00
Kubernetes Prow Robot
897ce3073c
Merge pull request #84533 from davidz627/fix/deprecatedPath
...
Remove plugin watching of deprecated directory and CSI v0 support in accordance with deprecation policy
2019-11-12 04:48:20 -08:00
Fabio Bertinatto
affcd0128b
Promote volume limits to GA
2019-11-12 09:43:53 +01:00
David Zhu
802fe12803
Remove plugin watching of deprecated directory {kubelet_root_dir}/plugins and support for CSI V0 in accordance with deprecation announcement in https://v1-13.docs.kubernetes.io/docs/setup/release/notes/
2019-11-11 11:42:58 -08:00
Travis Rhoden
1fd8921546
Move mount/fake.go to mount/fake_mount.go
...
This patch moves fake.go to mount_fake.go, and follows to principle of
always returning a discrete type rather than an Interface. All callers
of "FakeMounter" are changed to instead use "NewFakeMounter()". The
FakeMounter "Log" struct member is changed to not be exported, and
instead only access through a new "GetLog()" method.
2019-11-08 08:07:41 -07:00
Kubernetes Prow Robot
59aa8fd99e
Merge pull request #82698 from janario/fix/umount-subpath-warns
...
Unmount subpath should only scan the first level of files/directories
2019-11-08 02:16:14 -08:00
Kubernetes Prow Robot
bae8f56bb1
Merge pull request #84865 from deads2k/feature-gate-fail
...
panic in featuregate if a requested feature is unknown
2019-11-07 16:20:34 -08:00
David Eads
7d897d5f77
make azure fail if feature gates are not registered
2019-11-07 12:42:09 -05:00
Janario Oliveira
c9e97151b3
Changed unmount function for subpath with dirs
2019-11-07 10:05:26 +01:00
Janario Oliveira
cb0ab22b2e
Added test case for subpath mount with file
2019-11-07 10:05:26 +01:00
Janario Oliveira
2ca213579d
Renamed function
2019-11-07 10:05:26 +01:00
Janario Oliveira
439ce51441
Changed test case to use filepath.Walk
2019-11-07 10:05:26 +01:00
Janario Oliveira
67ec00d6b8
Unmount subpath should only scan the first level dir
2019-11-07 10:05:26 +01:00
Jordan Liggitt
297570e06a
hack/update-vendor.sh
2019-11-06 17:42:34 -05:00
Kubernetes Prow Robot
b01ac96bd4
Merge pull request #84770 from mikedanese/uuid
...
remove github.com/pborman/uuid
2019-11-05 08:47:05 -08:00
Kubernetes Prow Robot
1488460cd2
Merge pull request #84605 from andyzhangx/byok
...
add azure disk encryption(SSE+CMK) support
2019-11-04 23:16:52 -08:00
Mike Danese
a4ca9e6c93
migrate callers to g/g/uuid
2019-11-04 23:15:29 -08:00
Kubernetes Prow Robot
1d1385af91
Merge pull request #83474 from msau42/topology-ga
...
CSI Topology ga
2019-11-04 15:28:27 -08:00
Kubernetes Prow Robot
08410cbf06
Merge pull request #84365 from codenrhoden/rm-mount-container
...
Remove Alpha feature MountContainers
2019-11-03 21:29:41 -08:00
Kubernetes Prow Robot
ed5b038313
Merge pull request #84218 from cofyc/fix74552
...
Support local filesystem volume with block source reconstruction and add related e2e tests
2019-10-31 21:53:36 -07:00
andyzhangx
f10d44bad2
feat: add azure disk encryption(SSE+CMK) support
2019-10-31 13:24:43 +00:00
Yecheng Fu
0fd4cbcac4
log the reconstructed device and add break
2019-10-31 21:09:13 +08:00
David Zhu
3575720154
Add davidz627 as owner of pkg/volume/csi
2019-10-30 13:35:44 -07:00
Kubernetes Prow Robot
a45917008f
Merge pull request #84301 from yutedz/pvc-expand-fail
...
Add event for pvc in case node expansion fails
2019-10-28 14:09:29 -07:00
Michelle Au
fb6dfeb718
Convert attach-detach controller to use v1.CSINode
2019-10-28 13:41:13 -07:00
Michelle Au
d27fa9d890
Kubelet creates v1.CSINode
2019-10-28 13:41:13 -07:00
Michelle Au
8f6ab81cd4
Move feature gate to GA
2019-10-28 13:41:13 -07:00
Yecheng Fu
36a54399a6
support local volume with block source reconstruction
2019-10-28 10:34:57 +08:00
Kubernetes Prow Robot
24ae4d6718
Merge pull request #84173 from cofyc/fix83693
...
Support local volume block mode reconstruction
2019-10-25 19:23:23 -07:00
Kubernetes Prow Robot
cb0f80efe7
Merge pull request #84321 from cduchesne/csi-detach-timeout
...
CSI: modify detach timeout to match attach timeout
2019-10-25 09:54:13 -07:00
Kubernetes Prow Robot
cbf1e2d360
Merge pull request #82794 from ingvagabund/fake-clientset-enforce-exact-much-for-get
...
Require exact match when calling Get method within fake clientset
2019-10-25 09:53:39 -07:00
Travis Rhoden
2e054a4f4c
Remove Alpha feature Mount Containers
...
The alpha feature for mount containers is unused, and is
superseded by CSI. By removing it, we can remove a lot of unnecessary
code, and also clean up the mount library even more before moving it out
of tree.
2019-10-25 09:25:13 -06:00
Kubernetes Prow Robot
8c1ffb59e3
Merge pull request #84083 from ZP-AlwaysWin/dev02
...
cleanup util code
2019-10-24 09:49:23 -07:00
Ted Yu
e8bd5c7785
Add event for pvc in case node expansion fails
2019-10-24 09:11:01 -07:00
Chris Duchesne
b4e0f1b8f8
modify detach timeout to be csiTimeout
2019-10-24 07:53:16 -07:00
Kubernetes Prow Robot
900c0cf0b6
Merge pull request #84137 from cwdsuzhou/Octo/add_success_events
...
Add an event to pvc when node expand successfully
2019-10-24 07:33:15 -07:00
Jan Chaloupka
d32c76fc03
Require exact match when calling Get method within fake clientset
...
`Get` method within the fake clientset returns an object that would not be normally returned when using the real clientset. Reproducer:
```go
package main
import (
v1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/client-go/kubernetes/fake"
)
func main () {
cm := &v1.ConfigMap{
ObjectMeta: metav1.ObjectMeta{Namespace: metav1.NamespaceSystem, Name: "cm"},
}
client := fake.NewSimpleClientset(cm)
obj, err := client.CoreV1().ConfigMaps("").Get("", metav1.GetOptions{})
if err != nil {
panic(err)
}
fmt.Printf("obj: %#v\n", obj)
}
```
stored under `test.go` of `github.com/kubernetes/kubernetes` (master HEAD) root directory and ran:
```sh
$ go run test.go
obj: &v1.ConfigMap{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"cm", GenerateName:"", Namespace:"kube-system", SelfLink:"", UID:"", ResourceVersion:"", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Finalizers:[]string(nil), ClusterName:"", ManagedFields:[]v1.ManagedFieldsEntry(nil)}, Data:map[string]string(nil), BinaryData:map[string][]uint8(nil)}
```
As you can see fake clientset with a "test" configmap is created. When getting the object through the clientset back, I intentionally set the object name to an empty string. I would expect to get an error saying config map "" was not found. However, I get "test" configmap instead.
Reason for that is inside implementation of `filterByNamespaceAndName` private function:
```go
func filterByNamespaceAndName(objs []runtime.Object, ns, name string) ([]runtime.Object, error) {
var res []runtime.Object
for _, obj := range objs {
acc, err := meta.Accessor(obj)
if err != nil {
return nil, err
}
if ns != "" && acc.GetNamespace() != ns {
continue
}
if name != "" && acc.GetName() != name {
continue
}
res = append(res, obj)
}
return res, nil
}
```
When `name` is empty, `name != "" && acc.GetName() != name` condition is false and thus `obj` is consider as a fit.
[1] https://github.com/kubernetes/client-go/blob/master/testing/fixture.go#L481-L493
2019-10-24 14:41:48 +02:00
ZP-AlwaysWin
9ca7888acc
remove the extra space added
2019-10-24 17:17:31 +08:00
Yecheng Fu
46b1e264dc
support local volume block mode reconstruction
2019-10-23 19:32:15 +08:00
Kubernetes Prow Robot
18cef954a1
Merge pull request #83591 from jingxu97/Oct/cache
...
Flush data cache during unmount device for GCE-PD in Windows
2019-10-21 21:11:36 -07:00