github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
75,565 Commits 1 Branch 31 Tags
24b5c6772352d52d6475d2a63e91d0dae7fd332a
Commit Graph

7223 Commits

Author SHA1 Message Date
Ismo Puustinen
24b5c67723 hack/lib/util.sh: various shellcheck-reported cleanups. 
Use "command -v" instead of "which".  Also remove the redirections,
since "command -v" does not return an error message if the command isn't
found. Also use "read -r" instead of "read" and quote variables
properly. Do some error handling if "pushd" or "popd" fail. Read values
properly into arrays.

However, one shellcheck error is ignored in trap mechanism.  The logic
in trap_add function requires the trap command to be expanded when run.
Just storing the variable into trap doesn't work. Add a shellcheck
disable directive to ignore the error.

An alternative to ignoring could be tricking shellcheck with:

  trap ''"${new_cmd}" "${trap_add_name}"
 2019-03-04 23:18:54 +02:00
Kubernetes Prow Robot
222dd0af4c Merge pull request #71022 from emwalker/68026-golint-fixes-5 
Remove test/integration/* from hack/.golint_failures
 2019-03-01 14:08:33 -08:00
Kubernetes Prow Robot
8acb522c03 Merge pull request #74488 from xichengliudui/fixshellcheck19022502 
fix shellcheck in test/e2e_node/jenkins/...
 2019-03-01 12:49:08 -08:00
Eric Walker
75df4dc04c Remove test/integration/* from hack/.golint_failures 2019-02-28 19:52:39 -07:00
Kubernetes Prow Robot
343bb4bd6b Merge pull request #74561 from moshe010/start_kube_scheduler 
Move start kubescheduler to it own function
 2019-02-28 05:07:37 -08:00
Kubernetes Prow Robot
02b8056efb Merge pull request #73288 from wangzhen127/npd-config 
Decouple node-problem-detector release from kubernetes
 2019-02-28 00:27:25 -08:00
Kubernetes Prow Robot
6af2e9afea Merge pull request #74591 from xichengliudui/fixgolint190226 
fix shellcheck in test/image/...
 2019-02-27 20:39:25 -08:00
Kubernetes Prow Robot
d58ff3bfc0 Merge pull request #74176 from dims/containerized-kubelet-is-being-deprecated 
Remove support for containerized-kubelet in local-up-cluster.sh
 2019-02-27 14:40:06 -08:00
Zhen Wang
6df207bdaa allows configuring NPD image version in node e2e test and fix the test 2019-02-26 21:29:50 -08:00
Kubernetes Prow Robot
81e6407393 Merge pull request #74140 from Liujingfang1/kflag 
add -k flag in cli-runtime and kubectl to process kustomization directories
 2019-02-26 19:40:16 -08:00
Kubernetes Prow Robot
5ebdf3e3f2 Merge pull request #74574 from SataQiu/fix-golint-20190226 
fix some golint failures in pkg/registry/...
 2019-02-26 18:12:19 -08:00
Kubernetes Prow Robot
493b261057 Merge pull request #74586 from danielqsj/patch3 
fix golint failures for test/e2e/cloud|kubectl|servicecatalog
 2019-02-26 14:08:16 -08:00
Kubernetes Prow Robot
26f90e850d Merge pull request #74540 from oomichi/golint-e2e-framework-ingress 
Fix golint under test/e2e/framework/ingress
 2019-02-26 14:08:06 -08:00
Kubernetes Prow Robot
0ecba229aa Merge pull request #74512 from danielqsj/ui 
fix golint failures for test/e2e/ui
 2019-02-26 14:07:54 -08:00
SataQiu
9e4c8950be fix some golint failures in pkg/registry/... 2019-02-26 22:36:52 +08:00
danielqsj
8911a2ddbb fix golint failures for test/e2e/kubectl 2019-02-26 18:27:01 +08:00
danielqsj
9ea1b3d86d fix golint failures for test/e2e/servicecatalog 2019-02-26 18:25:23 +08:00
danielqsj
84aeafee7b fix golint failures for test/e2e/cloud 2019-02-26 18:25:23 +08:00
Kubernetes Prow Robot
736baa5e33 Merge pull request #73593 from danielqsj/etcd 
fix shellcheck failure in etcd shell
 2019-02-25 23:11:50 -08:00
danielqsj
1ce7b0b2fa fix golint failures for test/e2e/ui 2019-02-26 14:03:34 +08:00
xichengliudui
4b38978329 fix shellcheck in test/e2e_node/jenkins/... 
update pull request
 2019-02-26 01:01:48 -05:00
Kubernetes Prow Robot
33a0afafe7 Merge pull request #74508 from danielqsj/uapps 
Fix golint failures for e2e/upgrades/...
 2019-02-25 21:48:42 -08:00
Kubernetes Prow Robot
5a2d587ac4 Merge pull request #74505 from SataQiu/fix-golint-20190225 
fix golint failures for pkg/apis/...
 2019-02-25 20:28:30 -08:00
Kubernetes Prow Robot
272d78f1d9 Merge pull request #73966 from alculquicondor/fix/lint-kubelet-server 
Fix lint on pkg/kubelet/server/...
 2019-02-25 20:27:48 -08:00
Moshe Levi
b9fb656546 Move start kubescheduler to it own function 
Currently the kubescheduler starts in the start_kubeproxy
This change move it to ir own function start_kubescheduler

Change-Id: Iff93114d4becabe4b6b937c5077821e092abffd3
Signed-off-by: Moshe Levi <moshele@mellanox.com>
 2019-02-26 04:30:11 +02:00
Kubernetes Prow Robot
1595089ec5 Merge pull request #74453 from xichengliudui/fixgolintfailures1902 
fixgo lint failures test/integration/...
 2019-02-25 17:25:34 -08:00
Kubernetes Prow Robot
483d19ccc4 Merge pull request #74420 from mattjmcnaughton/mattjmcnaughton/fix-shellcheck-for-more-scripts-in-hack 
Fix shellcheck for more scripts in hack
 2019-02-25 17:25:23 -08:00
Kubernetes Prow Robot
0ff7e463ee Merge pull request #73746 from mrbobbytables/kubemark-shellcheck 
Fix shellcheck lint errors in Kubemark scripts
 2019-02-25 17:25:13 -08:00
Jingfang Liu
beacc87ebf add cmdline tests for -k 2019-02-25 16:31:03 -08:00
Kubernetes Prow Robot
3814176d42 Merge pull request #74455 from SataQiu/fix-shell-2019022302 
Fix shellcheck lint errors in cluster and hack scripts
 2019-02-25 15:15:19 -08:00
Kubernetes Prow Robot
a778f409ba Merge pull request #74385 from SataQiu/fix-shell-20190222 
Fix some shellcheck failures in hack
 2019-02-25 13:54:32 -08:00
Kubernetes Prow Robot
0813567660 Merge pull request #74349 from mattjmcnaughton/mattjmcnaughton/fix-shellcheck-in-hack 
Fix shellcheck for hack/verify-generated-*
 2019-02-25 13:54:10 -08:00
Kenichi Omichi
215dee7dd2 Fix golint under test/e2e/framework/ingress 2019-02-25 20:55:03 +00:00
Bob Killen
e137f4702a Fix shellcheck lint errors in test/kubemark/stop-kubemark.sh 2019-02-25 15:21:32 -05:00
Bob Killen
b8aae458a1 Fix shellcheck lint errors in test/kubemark/start-kubemark.sh 2019-02-25 15:21:31 -05:00
Bob Killen
46333a01b4 Fix shellcheck lint errors in test/kubemark/run-e2e-tests.sh 2019-02-25 15:21:31 -05:00
Bob Killen
adf4bf1741 Fix shellcheck lint errors in test/kubemark/resources/start-kubemark-master.sh 2019-02-25 15:21:31 -05:00
Bob Killen
f72ac1f5b7 Fix shellcheck lint errors in test/kubemark/master-log-dump.sh 2019-02-25 15:21:31 -05:00
Bob Killen
cb59cb33ff Fix shellcheck lint errors in test/kubemark/iks/util.sh 2019-02-25 15:21:30 -05:00
Bob Killen
e3e2a96521 Fix shellcheck lint errors in test/kubemark/iks/startup.sh 2019-02-25 15:21:30 -05:00
Bob Killen
6310305d3b Fix shellcheck lint errors in test/kubemark/iks/shutdown.sh 2019-02-25 15:21:30 -05:00
Bob Killen
186b83fe5b Fix shellcheck lint errors in test/kubemark/gce/util.sh 2019-02-25 15:21:30 -05:00
Bob Killen
5f4b919887 Fix shellcheck lint errors in test/kubemark/common/util.sh 2019-02-25 15:21:29 -05:00
Bob Killen
9a4f4878f5 Fix shellcheck lint errors in cluster/kubemark/util.sh 2019-02-25 15:21:29 -05:00
Bob Killen
9a58913e8f Fix shellcheck lint errors in cluster/kubemark/iks/config-default.sh 2019-02-25 15:21:25 -05:00
Bob Killen
ce4c85e3fd Fix shellcheck lint errors in cluster/kubemark/gce/config-default.sh 2019-02-25 14:55:01 -05:00
Kubernetes Prow Robot
35a258d640 Merge pull request #73272 from danielqsj/juju 
fix shellcheck in cluster/juju
 2019-02-25 11:33:21 -08:00
Kubernetes Prow Robot
f288678cfa Merge pull request #73261 from danielqsj/local 
fix shellcheck in cluster/local
 2019-02-25 11:33:11 -08:00
Davanum Srinivas
5d13f6f776 Remove support for containerized-kubelet in local-up-cluster.sh 
Change-Id: I3435b02fbe052a88f6b88d5517de2d68ff636a66
 2019-02-25 08:53:14 -05:00
SataQiu
09ba08f8f4 fix some golint failures for pkg/apis/... 2019-02-25 18:06:08 +08:00