github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
107,235 Commits 1 Branch 31 Tags
28755c32b51dd4052cc79be8a2df4b2eef5e73f6
Commit Graph

5646 Commits

Author SHA1 Message Date
Andrew Sy Kim
845d4a4304 add myself as approver to pkg/controller 
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
 2022-01-12 19:33:02 -05:00
Patrick Ohly
9eaa2dc554 avoid klog Info calls without verbosity 
In the following code pattern, the log message will get logged with v=0 in JSON
output although conceptually it has a higher verbosity:

   if klog.V(5).Enabled() {
       klog.Info("hello world")
   }

Having the actual verbosity in the JSON output is relevant, for example for
filtering out only the important info messages. The solution is to use
klog.V(5).Info or something similar.

Whether the outer if is necessary at all depends on how complex the parameters
are. The return value of klog.V can be captured in a variable and be used
multiple times to avoid the overhead for that function call and to avoid
repeating the verbosity level.
 2022-01-12 07:48:36 +01:00
Kubernetes Prow Robot
1f382b171e Merge pull request #107080 from sivchari/fix-misspell 
fix curent to current
 2022-01-11 13:56:53 -08:00
Kubernetes Prow Robot
ccccd90bbc Merge pull request #107389 from jlsong01/refine_comments_quota_monitor 
refine comments of quota monitor
 2022-01-10 13:34:25 -08:00
Davanum Srinivas
ba1f853b5a Add mwielgus back 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2022-01-10 09:02:53 -05:00
Davanum Srinivas
9682b7248f OWNERS cleanup - Jan 2021 Week 1 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2022-01-10 08:14:29 -05:00
astraw99
a5a54754d5 refactor garbagecollection controllers to make forget impossible to forget 2022-01-09 15:19:10 +08:00
Kubernetes Prow Robot
3bebe8f6b5 Merge pull request #105264 from devincd/fix_typo 
fix the log description
 2022-01-06 17:40:29 -08:00
jlsong01
d6bf04d85f refine comments of quota monitor 2022-01-06 23:08:53 +08:00
JUN YANG
13fa2b1949 replace all occurrences of "node", nodeName to "node", klog.KRef("", nodeName) 2022-01-06 21:19:29 +08:00
Kubernetes Prow Robot
65378e7747 Merge pull request #102636 from charlesxsh/svcacct-ctrl-test 
fix a potential deadlock
 2022-01-05 21:12:27 -08:00
Mengjiao Liu
beda4cafb6 kubelet: Remove the deprecated flag --experimental-check-node-capabilities-before-mount 2022-01-06 11:47:11 +08:00
Kubernetes Prow Robot
abfe397ceb Merge pull request #107166 from jsafrane/fix-pv-controller-tests 
Fix PV controller unit test 5-7
 2022-01-04 23:03:27 -08:00
Jan Safranek
0f9832d095 Fix PV name in unit test 
Test 5-5 should use PV with "5-5"i in the name. It makes log analysys
much easier.
 2022-01-03 15:20:12 +01:00
Kubernetes Prow Robot
f0dbc32ed9 Merge pull request #106853 from gnufied/disable-exp-backoff-volume-not-inuse 
When volume is not marked in-use, do not backoff
 2021-12-22 19:46:37 -08:00
Jan Safranek
045ca75c03 Deflake PV metrics unit test 
Test 5-7 tries to delete a PVC at the very same time when it detects that
the PV controller started processing the PVC. The controller then sometimes
can't update the PVC and generate an event for it that the test expects.

From PV controller logs (not shown in CI):
> I1221 14:36:34.548160  104481 pv_controller.go:815] updating PersistentVolumeClaim[default/claim5-7] status: set phase Lost failed: cannot update claim claim5-7: claim not found

Typical error in CI:
> FAIL: TestControllerSync (83.22s)
> framework_test.go:202: Event "Warning ClaimLost" not emitted

Therefore wait for the PVC to be fully processed before deleting the PVC to
avoid races.
 2021-12-21 15:36:44 +01:00
Jan Safranek
e323306ce0 Add new watchers to PV controller tests 
Add fake Pod and Node watchers to the tests. It only reduces test noise:

Failed to watch *v1.Pod: unhandled watch: testing.WatchActionImpl{ActionImpl:testing.ActionImpl{Namespace:"", Verb:"watch", Resource:schema.GroupVersionResource{Group:"", Version:"v1", Resource:"pods"}, Subresource:""}, WatchRestrictions:testing.WatchRestrictions{Labels:labels.internalSelector(nil), Fields:fields.andTerm{}, ResourceVersion:""}}
 2021-12-21 15:36:34 +01:00
Kubernetes Prow Robot
13e97453f9 Merge pull request #107091 from robscott/endpointslice-metrics-perf 
Improving performance of EndpointSlice controller metrics cache
 2021-12-21 01:08:45 -08:00
Rob Scott
242c33615e Improving performance of EndpointSlice controller metrics cache 2021-12-20 10:26:47 -08:00
Hemant Kumar
7989f27044 use node informer to check volumes attachment status before backoff 
fix unit tests
 2021-12-20 11:57:05 -05:00
Kubernetes Prow Robot
8ade75465a Merge pull request #104799 from RyanAoh/cronjob_dev 
fix the error when cleaning up finished jobs for cronjob
 2021-12-17 13:23:53 -08:00
sivchari
a5c5acf56e fix curent to current 2021-12-17 03:33:22 +09:00
Kubernetes Prow Robot
1426587e08 Merge pull request #106436 from dims/cleanup-owners-files-no-activity-in-a-year 
Cleanup OWNERS files (No Activity in the last year)
 2021-12-15 12:07:51 -08:00
Davanum Srinivas
497e9c1971 Cleanup OWNERS files (No Activity in the last year) 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2021-12-15 10:34:02 -05:00
Kubernetes Prow Robot
8324868f89 Merge pull request #106950 from sunzhaochang/fix-unexpected-end-test 
Fix unexpected end of TestDependentsRace
 2021-12-14 15:16:49 -08:00
Kubernetes Prow Robot
ba200841fd Merge pull request #106366 from cyclinder/evictions_number_stable 
adding evictions_total metric and marking evictions_number deprecated
 2021-12-12 23:19:59 -08:00
cyclinder
b88b51c6e5 adding evictions_total metric and marking evictions_number deprecated 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2021-12-13 10:36:02 +08:00
sunzhaochang
f0e74bfb7f Fix unexpected end of TestDependentsRace 2021-12-10 20:07:37 +08:00
Davanum Srinivas
9405e9b55e Check in OWNERS modified by update-yamlfmt.sh 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2021-12-09 21:31:26 -05:00
Kubernetes Prow Robot
d16a5e5feb Merge pull request #106673 from qmloong/qmloong/master 
refactor: use utilerrors instead of join error msg
 2021-12-07 18:27:22 -08:00
Kubernetes Prow Robot
12901b95c9 Merge pull request #106344 from ikeeip/fix_import_formatting 
Fix golang imports in k8s.io/pkg/controller/volume/persistentvolume package
 2021-12-07 17:26:40 -08:00
menglong.qi
ea31d7b813 refactor: use utilerrors instead of join error msg 2021-11-28 17:16:17 +08:00
Matthew Cary
0e2b901762 Clean up deep copy needed for UpdateStatefulSet 
Change-Id: Id732358183d682d1a945cfee56f83bcaac0d7c31
 2021-11-23 06:48:54 -08:00
Aohan Yang
ad4fe13528 fix the error when cleaning up jobs for cronjob 2021-11-22 17:06:22 +08:00
Kubernetes Prow Robot
084b28f6d5 Merge pull request #106510 from robscott/topology-ready-fix-controller 
Updating TopologyCache to disregard unready endpoints in calculations
 2021-11-19 17:07:11 -08:00
Rob Scott
9813ec7e8a Updating TopologyCache to disregard unready endpoints in calculations 2021-11-18 13:54:09 -08:00
Matthew Cary
53b3a6c1d9 controller change for statefulset auto-delete (tests) 
Change-Id: I16b50e6853bba65fc89c793d2b9b335581c02407
 2021-11-17 16:48:50 -08:00
Matthew Cary
bce87a3e4f controller change for statefulset auto-delete (implementation) 2021-11-17 16:48:50 -08:00
Kubernetes Prow Robot
39c76ba2ed Merge pull request #106455 from soltysh/cronjob_warning 
Add warning about using unsupported CRON_TZ
 2021-11-16 17:44:31 -08:00
Kubernetes Prow Robot
165b581759 Merge pull request #105623 from ash2k/ash2k/resettable-rest-mapper 
ResettableRESTMapper to make it possible to reset wrapped mappers
 2021-11-16 16:36:08 -08:00
Kubernetes Prow Robot
6805e6ee41 Merge pull request #104722 from leiyiz/migration 
turning on the CSIMigrationGCE feature flag
 2021-11-16 15:28:32 -08:00
Kubernetes Prow Robot
f151a40d8d Merge pull request #106154 from gnufied/recover-expansion-failure-123 
Recover expansion failure
 2021-11-16 13:21:34 -08:00
Léiyì Zhang
275fdf0884 fixing unit test failures induced by turning on CSIMigrationGCE 
disable CSIMigrationGCE in some unit tests
 2021-11-16 19:26:30 +00:00
Maciej Szulik
d0518848b5 Add warning about using unsupported CRON_TZ 
CRON_TZ variable slipped in during upgrading github.com/robfig/cron
library.  It allows setting a time zone which is a long requested
feature but one that is not officially supported. This adds warning
event since users should not rely on unsupported features.
 2021-11-16 17:41:37 +01:00
Hemant Kumar
1ddd598d31 Implement controller and kubelet changes for recovery from resize 
failures
 2021-11-16 11:06:46 -05:00
Kubernetes Prow Robot
6d1d8c73ee Merge pull request #106316 from josephburnett/controller-v2 
Watch HPA v2 instead of v1.
 2021-11-16 06:41:38 -08:00
Joseph Burnett
711f96e05e Watch HPA v2 instead of v1. 2021-11-16 11:13:21 +01:00
Kubernetes Prow Robot
ce98eda406 Merge pull request #106376 from jsafrane/stabilize-unit-test 
Fix deletion protection unit test
 2021-11-15 13:04:48 -08:00
shawnhanx
acc55500bc should omit comparison to bool constant in pkg/controller/controller_utils.go 2021-11-13 17:15:25 +08:00
Neha Lohia
fa1b6765d5 move pkg/util/node to component-helpers/node/util (#105347) 
Signed-off-by: Neha Lohia <nehapithadiya444@gmail.com>
 2021-11-12 07:52:27 -08:00