Commit Graph

4186 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
c78204dc06 Merge pull request #118202 from pohly/scheduler-perf-unit-test
scheduler-perf: run as integration tests
2023-06-28 06:24:31 -07:00
Kubernetes Prow Robot
ddbf3575a7 Merge pull request #116729 from AxeZhan/handlers_sync
[Scheduler] Make sure handlers have synced before scheduling
2023-06-28 01:26:31 -07:00
Patrick Ohly
0d41d509d2 scheduler_perf: replace gomega.Eventually with wait.PollUntilContextTimeout
This is done for the sake of consistency. The failure message becomes less
useful.
2023-06-28 09:22:26 +02:00
Patrick Ohly
cecebe8ea2 scheduler_perf: add TestScheduling integration test
This runs workloads that are labeled as "integration-test". The apiserver and
scheduler are only started once per unique configuration, followed by each
workload using that configuration. This makes execution faster. In contrast to
benchmarking, we care less about starting with a clean slate for each test.
2023-06-28 09:22:25 +02:00
Patrick Ohly
dfd646e0a8 scheduler_perf: fix namespace deletion
Merely deleting the namespace is not enough:
- Workloads might rely on the garbage collector to get rid of obsolete objects,
  so we should run it to be on the safe side.
- Pods must be force-deleted because kubelet is not running.
- Finally, the namespace controller is needed to get rid of
  deleted namespaces.
2023-06-28 09:22:25 +02:00
Patrick Ohly
d9c16a1ced scheduler_perf: fix goroutine leak in runWorkload
This becomes relevant when doing more fine-grained leak checking.
2023-06-28 08:14:34 +02:00
Patrick Ohly
2e7f37353c test/integration: avoid errors in fake PC controller during shutdown
Once the context is canceled, the controller can stop processing
events. Without this change it prints errors when the apiserver is already
down.
2023-06-28 08:14:34 +02:00
Kubernetes Prow Robot
960830bc66 Merge pull request #118102 from RomanBednar/retro-sc-assignment-ga
graduate RetroactiveDefaultStorageClass feature to GA in 1.28
2023-06-27 20:46:32 -07:00
Aldo Culquicondor
a4519665fe Skip terminal Pods with a deletion timestamp from the Daemonset sync (#118716)
* Skip terminal Pods with a deletion timestamp from the Daemonset sync

Change-Id: I64a347a87c02ee2bd48be10e6fff380c8c81f742

* Review comments and fix integration test

Change-Id: I3eb5ec62bce8b4b150726a1e9b2b517c4e993713

* Include deleted terminal pods in history

Change-Id: I8b921157e6be1c809dd59f8035ec259ea4d96301
2023-06-27 08:56:33 -07:00
kidddddddddddddddddddddd
9c7166ff63 wait for eventhandlers to sync before run scheduler 2023-06-27 23:19:34 +08:00
Kubernetes Prow Robot
6dbb1c6cf0 Merge pull request #118902 from pohly/staticcheck-cleanup
Cleanup staticcheck workarounds, improve gomega calls, update to golangci-lint 1.53.3
2023-06-27 07:54:32 -07:00
Kevin Hannon
ecd727e4c7 Fix PodGC test when PodDisruptionConditions disabled (#118805)
* test comment should match the code in podgc

* Update test/integration/podgc/podgc_test.go

Co-authored-by: Michał Woźniak <mimowo@users.noreply.github.com>

* test comment should match the code in podgc

---------

Co-authored-by: Michał Woźniak <mimowo@users.noreply.github.com>
2023-06-27 05:50:29 -07:00
Madhav Jivrajani
bdbf07525f test: remove exception comments in discovery tests
The exception comments were added due to a false positive in
staticcheck. This has since been rectified.

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
2023-06-27 14:20:41 +02:00
Dr. Stefan Schimanski
764da8a01d FIXUP: cmd/kube-apiserver/app/options: split apart controlplane part 2023-06-26 21:50:38 +02:00
Kubernetes Prow Robot
9f5a3f5e90 Merge pull request #118868 from sttts/sttts-kube-apiserver-options-completion-move
cmd/kube-apiserver: move options completion into options package
2023-06-26 08:14:29 -07:00
Kubernetes Prow Robot
d9714078f8 Merge pull request #118551 from sanposhiho/event-to-register
feature(scheduler): implement ClusterEventWithHint to filter out useless events
2023-06-26 06:41:45 -07:00
Dr. Stefan Schimanski
6e079545c4 cmd/kube-apiserver: move options completion into options package 2023-06-26 15:20:40 +02:00
Kensei Nakada
6f8d38406a feature(scheduler): implement ClusterEventWithHint to filter out useless events 2023-06-22 13:36:19 +00:00
Patrick Ohly
c91c578795 scheduler_perf: skip expensive cleanup during benchmarks
Each benchmark test case runs with a fresh etcd instance. Therefore it is not
necessary to delete objects after a run.

A future unit test might reuse etcd, therefore cleanup is optional.
2023-06-22 08:56:14 +02:00
Kubernetes Prow Robot
28296ba59e Merge pull request #113994 from mengjiao-liu/contextual-logging-controller-certificates
certificate controller: use contextual logging
2023-06-21 09:03:42 -07:00
Aldo Culquicondor
c84b5b0a99 Cleanup unnecessary renames of variable t
Change-Id: Idf4d0ed7e09cf14323567381de158041236680b0
2023-06-19 13:27:17 -04:00
Kubernetes Prow Robot
162034db85 Merge pull request #118744 from mimowo/job-it-tests-small-default-backoff
Set small DefaultJobPodFailureBackOff in Job integration tests
2023-06-19 08:50:22 -07:00
Michal Wozniak
3dd1bac4dc Set small DefaultJobPodFailureBackOff in Job integration tests 2023-06-19 16:52:38 +02:00
Kubernetes Prow Robot
d2332eb5fd Merge pull request #118743 from mimowo/use-generics-in-job-tests
Replace deprecated sets.Int with sets.Set[int] in Job integration tests
2023-06-19 07:04:22 -07:00
Michal Wozniak
2596245f5a Replace deprecated sets.Int with sets.Set[int] in Job integration tests 2023-06-19 13:55:54 +02:00
ialidzhikov
958c8fb695 Make use of k8s.io/utils/pointer.Duration
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
2023-06-18 21:46:26 +03:00
Michal Wozniak
74c5ff97f1 Lower the constants for the rate limiter in Job controller 2023-06-16 17:00:04 +02:00
Kubernetes Prow Robot
47e79b8156 Merge pull request #116910 from fatsheep9146/job-controller-contextual-logging
Migrated pkg/controller/job to contextual logging
2023-06-14 08:00:18 -07:00
Kubernetes Prow Robot
173a473803 Merge pull request #118128 from carlory/fix-issue-118120
remove helper function for unused storage feature in pkg/proxy/util
2023-06-14 04:28:18 -07:00
Ziqi Zhao
7bc449d7e0 add contextual logging to job-controller
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
2023-06-14 13:40:02 +08:00
Kubernetes Prow Robot
9740bc0e0a Merge pull request #118606 from sanposhiho/refactor-score
refactor: simplify RunScorePlugins for readability + performance
2023-06-13 21:41:57 -07:00
Kubernetes Prow Robot
83d30f4463 Merge pull request #118342 from yt2985/cleanSA
Fix the flaky legacy_service_account_token_clean_up_test.
2023-06-12 22:33:57 -07:00
carlory
5e048041e4 remove helper function for unused storage feature in pkg/proxy/util 2023-06-13 09:22:59 +08:00
tinatingyu
9cb52a6872 Fix the flaky legacy_service_account_token_clean_up_test. 2023-06-13 00:11:13 +00:00
Kensei Nakada
be14b026e3 fix the integration test 2023-06-11 04:47:18 +00:00
Kubernetes Prow Robot
2057a48ee5 Merge pull request #114771 from sanposhiho/scheduling_perf_scheduler_scheduling_attempt_duration_seconds
feature(scheduler_perf): distinguish result in scheduler_scheduling_attempt_duration_seconds metric result
2023-06-07 06:18:13 -07:00
Roman Bednar
6afb363ca1 test: remove RetroactiveDefaultStorageClass feature gate
Since the feature is GA and locked to true, tests can no longer set it
to false. Cleaning up by removing all references to this feature gate
from tests.

Feature gate will be removed in v1.29.
2023-06-07 14:31:16 +02:00
Kubernetes Prow Robot
c3750e4450 Merge pull request #118379 from sttts/sttts-generic-controlplane-1
kube-apiserver/cmd: stratify construction to follow options/config/server pattern
2023-06-07 04:12:13 -07:00
Dr. Stefan Schimanski
7ac36bd072 test/integration: use t.Log in TestAPIServiceWaitOnStart 2023-06-07 10:11:04 +03:00
Dr. Stefan Schimanski
9be6e7bb33 STRUCTURE: cmd/kube-apiserver/app: stratify construction with options/config/server 2023-06-07 10:05:43 +03:00
Dr. Stefan Schimanski
e6ed4c7934 CLEANUP: cmd/kube-apiserver/app: remove trivial funcs 2023-06-07 10:05:43 +03:00
Kubernetes Prow Robot
da1f52034e Merge pull request #118489 from testwill/logs
chore: os.SEEK_END os.SEEK_SET and use b.Logf(...) instead of b.Log(f…
2023-06-06 19:40:24 -07:00
Kubernetes Prow Robot
aaaf70c8ad Merge pull request #118411 from SataQiu/fix-NoNewBetaAPIsByDefault-20230602
Remove enabled by default beta resources that have been removed
2023-06-06 10:20:24 -07:00
guoguangwu
bdfb96c57d chore: os.SEEK_END os.SEEK_SET and use b.Logf(...) instead of b.Log(fmt.Sprintf(...)) 2023-06-06 15:23:19 +08:00
Chris Bandy
2e76ac31fd Replace os.Setenv with testing.T.Setenv in tests
T.Setenv ensures that the environment is returned to its prior state
when the test ends. It also panics when called from a parallel test to
prevent racy test interdependencies.
2023-06-05 21:08:56 -05:00
SataQiu
a51be9786b remove enabled by default beta resources that have been removed 2023-06-03 00:06:50 +08:00
Kensei Nakada
a4ea058cc7 feature(scheduler_perf): distinguish result in scheduler_scheduling_attempt_duration_seconds metric result 2023-06-02 14:45:55 +00:00
Jefftree
2111e79f56 Update gnostic references 2023-06-02 14:34:26 +00:00
Kubernetes Prow Robot
2815a28dfa Merge pull request #118339 from jpbetz/bump-cel-go
Bump cel go to latest version
2023-06-01 09:09:46 -07:00
Joe Betz
68901de898 Enable optionals and add tests 2023-05-31 18:36:50 -04:00