Commit Graph

49555 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
2f2c1fb811 Merge pull request #124210 from thockin/remove_gate_SkipReadOnlyValidationGCE
Remove the gate "SkipReadOnlyValidationGCE"
2024-04-18 06:31:39 -07:00
Kubernetes Prow Robot
951e624ada Merge pull request #124320 from liangyuanpeng/drop-ptr-wrappers-pkg-registry
pkg/registry: drop pointer wrapper functions.
2024-04-18 04:24:32 -07:00
Kubernetes Prow Robot
32a3cbc51d Merge pull request #124245 from wojtek-t/informer_options
Allow for configuring MinWatchTimeout in reflector
2024-04-18 03:24:57 -07:00
Kubernetes Prow Robot
9c9a9b7c48 Merge pull request #124242 from carlory/cleanup-after-NewVolumeManagerReconstruction-ga
remove unneeded func SyncReconstructedVolume from ActualStateOfWorld
2024-04-18 03:24:50 -07:00
Kubernetes Prow Robot
745f56ea2b Merge pull request #124215 from tk3fftk/patch-2
fix: add delay to log message when enqueueing a job
2024-04-18 03:24:36 -07:00
Kubernetes Prow Robot
eb2a59e8d8 Merge pull request #124214 from Monokaix/dev
fix wrong comments of dra
2024-04-18 03:24:28 -07:00
Kubernetes Prow Robot
3188cbd1b3 Merge pull request #124113 from krzysdabro/nodeipam-pooling
nodeipam: poll nodes immediately
2024-04-18 03:23:33 -07:00
Kubernetes Prow Robot
dbaf5d667f Merge pull request #124062 from alculquicondor/nodename-api-comment
Update API comment for nodeName to match system behavior
2024-04-18 02:11:56 -07:00
Kubernetes Prow Robot
846e282d05 Merge pull request #124055 from yangjunmyfm192085/optklogprint
Optimize klog output(Use klog.KObj(pod) instead of pod)
2024-04-18 02:11:47 -07:00
Kubernetes Prow Robot
1646f2cfdb Merge pull request #124015 from carlory/cleanup-ephemeral
Visit ephemeral containers when calculating fs user
2024-04-18 02:11:20 -07:00
Kubernetes Prow Robot
ca1a134a41 Merge pull request #123977 from wojtek-t/avoid_node_gets
Get node from local cache instead of kube-apiserver cache for kubelet status updates
2024-04-18 02:10:44 -07:00
Kubernetes Prow Robot
7f67cb5960 Merge pull request #123969 from liangyuanpeng/cleanup_rand
cleanup: delete rand.Seed(time.Now().UnixNano()) and using global number generator.
2024-04-18 02:10:26 -07:00
Kubernetes Prow Robot
d2ce87eb94 Merge pull request #123938 from pohly/dra-structured-parameters-tests
DRA: test for structured parameters
2024-04-18 02:10:08 -07:00
Filip Křepinský
85d55b6737 fix stateful set pod recreation and event spam (#123809)
* fix pods tracking and internal error checking in statefulset tests

* fix stateful set pod recreation and event spam

- do not emit events when pod reaches terminal phase
- do not try to recreate pod until the old pod has been removed from
  etcd storage

* fix conflict race in statefulset rest update

statefulset controller does less requests per sync now and thus can
reconcile status faster, thus resulting in a higher chance for conflicts
2024-04-18 01:03:46 -07:00
Kubernetes Prow Robot
c43b733dd6 Merge pull request #123736 from thockin/cleanup_manual_conversions
Cleanup manual conversions
2024-04-18 01:03:27 -07:00
Kubernetes Prow Robot
da6be3b718 Merge pull request #123548 from Songjoy/fix-code
Delete a stale code comment
2024-04-18 00:01:10 -07:00
Kubernetes Prow Robot
e800d15494 Merge pull request #123389 from npinaeva/nftables-ut
Ensure nftables unit test parity with iptables
2024-04-18 00:00:56 -07:00
Kubernetes Prow Robot
6faeecc87d Merge pull request #122631 from jmcgrath207/disable-service-links
DisableServiceLinks admission controller
2024-04-18 00:00:28 -07:00
Kubernetes Prow Robot
2c6d5fae7a Merge pull request #122471 from nayihz/feat_podaffinity_qhint
interpodaffinity: scheduler queueing hints
2024-04-18 00:00:21 -07:00
Kubernetes Prow Robot
854af6aba6 Merge pull request #122411 from huww98/lift-mountedByNode
ad controller: lift nodeAttachedTo.mountedByNode
2024-04-18 00:00:14 -07:00
Kubernetes Prow Robot
ef2c682635 Merge pull request #122082 from carlory/remove-keep-terminated-pod-volumes
keep-terminated-pod-volumes flag on kubelet is removed
2024-04-17 23:59:54 -07:00
Kubernetes Prow Robot
a2abca11ff Merge pull request #121898 from carlory/ing-registry-test
ingress registry: add unit test for UpdateStatus
2024-04-17 23:59:40 -07:00
Kubernetes Prow Robot
3fda574e5e Merge pull request #121770 from frzifus/tracing_kubelet_read-only
pass tracerprovider to kublet-readonly server
2024-04-17 23:59:33 -07:00
Kubernetes Prow Robot
528cff12f6 Merge pull request #120969 from skitt/uber-go-mock
Switch from golang/mock to uber-go/mock
2024-04-17 23:59:24 -07:00
Kubernetes Prow Robot
56b39eab7c Merge pull request #119436 from claudiubelu/unittests-9
unittests: Fixes unit tests for Windows (part 9)
2024-04-17 22:51:32 -07:00
Lan Liang
9236425df6 pkg/registry: drop pointer wrapper functions.
The new k8s.io/utils/ptr package provides generic wrapper functions,
which can be used instead of type-specific pointer wrapper functions.
This replaces the latter with the former, and migrates other uses of
the deprecated pointer package to ptr in affacted files.

See kubernetes/utils#283 for details.

Signed-off-by: Lan Liang <gcslyp@gmail.com>
2024-04-15 14:34:53 +00:00
Lan Liang
78762c70db u 2024-04-15 09:24:44 +00:00
nayihz
1b3d10aafa fix: node added with matched pod anti-affinity topologyKey
Co-authored-by: Kensei Nakada <handbomusic@gmail.com>
2024-04-12 11:08:44 +08:00
huweiwen
3a71fe57f7 ad controller: lift nodeAttachedTo.mountedByNode
optimize adc.nodeUpdate(). Time complexity reduced from O(n) to O(1), where n is the number of nodes.

Data stored in nodeAttachedTo.mountedByNode is now at actualStateOfWorld.inUseVolumes.

This refactor also ensures that we can record the state update even if the volume is not present in ASW yet.

The added BenchmarkNodeUpdate result is reduced from 28076923 to 16030 ns/op.
The previous BenchmarkPopulateActualStateOfWorld result is also reduced from 13s to 8s.
2024-04-11 15:35:17 +08:00
Wojciech Tyczyński
36141fa6fb Bump min watch timeout for secret & configmap manager in Kubelet 2024-04-10 19:36:29 +02:00
Maksym Pavlenko
be4b7176dc Fix Abs path validation on Windows (#124084)
* Windows: Consider slash-prefixed paths as absolute

filepath.IsAbs does not consider "/" or "\" as absolute paths, even
though files can be addressed as such. [1][2]

Currently, there are some unit tests that are failing on Windows due to
this reason.

[1] https://learn.microsoft.com/en-us/dotnet/standard/io/file-path-formats#traditional-dos-paths
[2] https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file#fully-qualified-vs-relative-paths

* Add test to verify IsAbs for windows

Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>

* Fix abs path validation on windows

Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>

* Skipp path clean check for podLogDir on windows

Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>

* Implement IsPathClean to validate path

Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>

* Add warn comment for IsAbs

Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>

---------

Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Co-authored-by: Claudiu Belu <cbelu@cloudbasesolutions.com>
2024-04-10 10:13:59 -07:00
carlory
a6b2619274 remove unneeded func SyncReconstructedVolume from ActualStateOfWorld 2024-04-09 15:34:33 +08:00
Xuzheng Chang
3e08030d53 fix wrong comments of dra
Signed-off-by: Xuzheng Chang <changxuzheng@huawei.com>
2024-04-09 09:41:25 +08:00
Hiroki Takatsuka
84ffc2fc3d fix(job_controller): add delay duration to log message when enqueueing job 2024-04-07 16:42:48 +09:00
Tim Hockin
ae01c2126f Remove the gate "SkipReadOnlyValidationGCE"
One less GCE-specifc wart in the codebase.
2024-04-06 15:11:20 -07:00
Nadia Pinaeva
56d1011aa5 kube-proxy: ensure nftables unit test parity with iptables.
Add packet tracing unit tests for ipv4 and ipv6.
Remove unreachable code from runChain, since some of the parsed rules
are never generated by the proxy implementation.

Signed-off-by: Nadia Pinaeva <n.m.pinaeva@gmail.com>
2024-04-02 11:57:47 +02:00
Nadia Pinaeva
1c7b366182 kube-proxy: rename iptables unit test to match tested function name.
Signed-off-by: Nadia Pinaeva <n.m.pinaeva@gmail.com>
2024-04-02 11:57:47 +02:00
Krzysztof Dąbrowski
170d143b1a Revert changes in tests 2024-03-30 20:47:29 +01:00
Krzysztof Dąbrowski
5e94ffe90b nodeipam: poll nodes immediately 2024-03-29 20:56:08 +01:00
cpanato
fc428df491 update setcap/debian-base to bookworm-v1.0.2
Signed-off-by: cpanato <ctadeu@gmail.com>
2024-03-28 14:57:22 +01:00
Patrick Ohly
6f5696b537 dra scheduler: simplify unit tests
The guideline in
https://github.com/kubernetes/community/blob/master/sig-scheduling/CONTRIBUTING.md#technical-and-style-guidelines
is to not compare error strings. This makes the tests less precise. In return,
unit tests don't need to be updated when error strings change.
2024-03-27 10:27:01 +01:00
Aldo Culquicondor
1a2dba426f Update API comment for nodeName to match system behavior
Change-Id: I039b441f4525d280b1ea693d782fe0f43794d9f7
2024-03-26 19:04:48 +00:00
Claudiu Belu
c2dfcf1e34 unittests: Fixes unit tests for Windows (part 9)
Currently, there are some unit tests that are failing on
Windows due to various reasons:

- time.Now() is not as precise on Windows, which means that
  2 consecutive calls may return the same timestamp.
- Different "File not found" error messages on Windows.
- The default Container Runtime URL scheme on Windows is npipe, not unix.
2024-03-26 13:42:50 +00:00
杨军10092085
ba76a624f9 Optimize klog output 2024-03-26 18:53:29 +08:00
Fabio Bertinatto
c893c48432 Use the right feature gate when updating uncertain volumes 2024-03-25 16:47:08 -03:00
Kubernetes Prow Robot
227c2e7c2b Merge pull request #123720 from HirazawaUi/fix-slow-dra-test
kubelet: fix slow dra unit test
2024-03-25 10:22:33 -07:00
Patrick Ohly
458e227de0 dra scheduler: unit tests
Coverage was checked with a cover profile. The biggest remaining gap is for
isSchedulableAfterClaimParametersChange and
isSchedulableAfterClassParametersChange which will get handled when refactoring
the
foreachPodResourceClaim (https://github.com/kubernetes/kubernetes/issues/123697).
2024-03-22 10:03:22 +01:00
Patrick Ohly
607261e4c5 dra scheduler: spelling fix 2024-03-22 10:03:22 +01:00
Patrick Ohly
4126e37f08 dra controller: unit tests 2024-03-22 10:03:22 +01:00
Patrick Ohly
95136db063 dra scheduler: fix re-allocation of claim with structured parameters
The code was incorrectly checking for a controller, but only the boolean
is set for allocated claims. As a result, deallocation was requested from
a non-existent control plane controller.

While at it, let's also clear the driver name. It's not needed when the
claim is deallocated.
2024-03-22 10:03:22 +01:00