Commit Graph

7435 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
8acb522c03
Merge pull request #74488 from xichengliudui/fixshellcheck19022502
fix shellcheck in test/e2e_node/jenkins/...
2019-03-01 12:49:08 -08:00
Thomas Runyon
1e44e33517 pulled kubeadm tests out of runTests to run before tests in test/cmd
Added timeout for https://github.com/kubernetes/kubeadm/issues/1430
2019-03-01 12:17:25 -05:00
danielqsj
696c98a5e6 fix golint failures for metrics api 2019-03-01 17:36:20 +08:00
Eric Walker
75df4dc04c Remove test/integration/* from hack/.golint_failures 2019-02-28 19:52:39 -07:00
Kubernetes Prow Robot
343bb4bd6b
Merge pull request #74561 from moshe010/start_kube_scheduler
Move start kubescheduler to it own function
2019-02-28 05:07:37 -08:00
Kubernetes Prow Robot
02b8056efb
Merge pull request #73288 from wangzhen127/npd-config
Decouple node-problem-detector release from kubernetes
2019-02-28 00:27:25 -08:00
SataQiu
11451bbb59 fix golint failures in staging/src/k8s.io/apiserver/pkg/storage/errors, staging/src/k8s.io/apiserver/pkg/storage/etcd 2019-02-28 15:51:05 +08:00
danielqsj
cee02e62b7 Fix golint failures for e2e/windows 2019-02-28 15:48:48 +08:00
Kubernetes Prow Robot
6af2e9afea
Merge pull request #74591 from xichengliudui/fixgolint190226
fix shellcheck in test/image/...
2019-02-27 20:39:25 -08:00
SataQiu
c0a0471b3b fix golint failures in test/e2e/instrumentation, test/e2e_node/environment 2019-02-28 12:29:22 +08:00
Kubernetes Prow Robot
d58ff3bfc0
Merge pull request #74176 from dims/containerized-kubelet-is-being-deprecated
Remove support for containerized-kubelet in local-up-cluster.sh
2019-02-27 14:40:06 -08:00
Zhen Wang
6df207bdaa allows configuring NPD image version in node e2e test and fix the test 2019-02-26 21:29:50 -08:00
Kubernetes Prow Robot
81e6407393
Merge pull request #74140 from Liujingfang1/kflag
add -k flag in cli-runtime and kubectl to process kustomization directories
2019-02-26 19:40:16 -08:00
Kubernetes Prow Robot
5ebdf3e3f2
Merge pull request #74574 from SataQiu/fix-golint-20190226
fix some golint failures in pkg/registry/...
2019-02-26 18:12:19 -08:00
Kubernetes Prow Robot
493b261057
Merge pull request #74586 from danielqsj/patch3
fix golint failures for test/e2e/cloud|kubectl|servicecatalog
2019-02-26 14:08:16 -08:00
Kubernetes Prow Robot
26f90e850d
Merge pull request #74540 from oomichi/golint-e2e-framework-ingress
Fix golint under test/e2e/framework/ingress
2019-02-26 14:08:06 -08:00
Kubernetes Prow Robot
0ecba229aa
Merge pull request #74512 from danielqsj/ui
fix golint failures for test/e2e/ui
2019-02-26 14:07:54 -08:00
Kenichi Omichi
ede5477697 Enable StorageObjectInUseProtection by default
StorageObjectInUseProtection plugin of admission controller adds
the flag `kubernetes.io/pvc-protection` or `kubernetes.io/pv-protection`
to newly created PVCs or PV. In case a user deletes a PVC or PV the PVC
or PV is not removed until the finalizer is removed from the PVC or PV
by PVC or PV Protection Controller.
We are testing this plugin on the e2e tests of "PV Protection" because
most setup scripts enable that like:

* cluster/centos/config-default.sh: Enabled
* cluster/gce/config-default.sh: Enabled
* cluster/gce/config-test.sh: Enabled
* cluster/kubemark/gce/config-default.sh: Enabled
* hack/local-up-cluster.sh: Enabled
* cluster/juju/layers/kubernetes-master/reactive/kubernetes_master.py: Disabled

As we are testing it normally, it is nice to enable the plugin by
default.
2019-02-26 18:08:44 +00:00
SataQiu
9e4c8950be fix some golint failures in pkg/registry/... 2019-02-26 22:36:52 +08:00
danielqsj
8911a2ddbb fix golint failures for test/e2e/kubectl 2019-02-26 18:27:01 +08:00
danielqsj
9ea1b3d86d fix golint failures for test/e2e/servicecatalog 2019-02-26 18:25:23 +08:00
danielqsj
84aeafee7b fix golint failures for test/e2e/cloud 2019-02-26 18:25:23 +08:00
SataQiu
f8c4aba0cb fix some golint failures for plugin/pkg/admission/... 2019-02-26 17:12:40 +08:00
Kubernetes Prow Robot
736baa5e33
Merge pull request #73593 from danielqsj/etcd
fix shellcheck failure in etcd shell
2019-02-25 23:11:50 -08:00
danielqsj
1ce7b0b2fa fix golint failures for test/e2e/ui 2019-02-26 14:03:34 +08:00
xichengliudui
4b38978329 fix shellcheck in test/e2e_node/jenkins/...
update pull request
2019-02-26 01:01:48 -05:00
xichengliudui
ec5fddfe4f fix shellcheck in hack/make-rules/...
update pull request

update pull request

update pull request

update pull request

update pull request

update pull request

update pull request

update pull request
2019-02-26 00:56:36 -05:00
Kubernetes Prow Robot
33a0afafe7
Merge pull request #74508 from danielqsj/uapps
Fix golint failures for e2e/upgrades/...
2019-02-25 21:48:42 -08:00
SataQiu
c6ae694b79 fix some shellcheck failures in hack 2019-02-26 12:45:38 +08:00
Kubernetes Prow Robot
5a2d587ac4
Merge pull request #74505 from SataQiu/fix-golint-20190225
fix golint failures for pkg/apis/...
2019-02-25 20:28:30 -08:00
Kubernetes Prow Robot
272d78f1d9
Merge pull request #73966 from alculquicondor/fix/lint-kubelet-server
Fix lint on pkg/kubelet/server/...
2019-02-25 20:27:48 -08:00
Moshe Levi
b9fb656546 Move start kubescheduler to it own function
Currently the kubescheduler starts in the start_kubeproxy
This change move it to ir own function start_kubescheduler

Change-Id: Iff93114d4becabe4b6b937c5077821e092abffd3
Signed-off-by: Moshe Levi <moshele@mellanox.com>
2019-02-26 04:30:11 +02:00
Kubernetes Prow Robot
1595089ec5
Merge pull request #74453 from xichengliudui/fixgolintfailures1902
fixgo lint failures test/integration/...
2019-02-25 17:25:34 -08:00
Kubernetes Prow Robot
483d19ccc4
Merge pull request #74420 from mattjmcnaughton/mattjmcnaughton/fix-shellcheck-for-more-scripts-in-hack
Fix shellcheck for more scripts in hack
2019-02-25 17:25:23 -08:00
Kubernetes Prow Robot
0ff7e463ee
Merge pull request #73746 from mrbobbytables/kubemark-shellcheck
Fix shellcheck lint errors in Kubemark scripts
2019-02-25 17:25:13 -08:00
Jingfang Liu
beacc87ebf add cmdline tests for -k 2019-02-25 16:31:03 -08:00
Jeff Grafton
392ad719eb add comments 2019-02-25 15:34:09 -08:00
Jeff Grafton
883b6cff0d Generate a repos_generated.bzl file with all staging repos
Additionally, ensure that every staging repo has a BUILD file at its
root.

Also, remove a gazelle directive we no longer need.
2019-02-25 15:33:46 -08:00
Kubernetes Prow Robot
3814176d42
Merge pull request #74455 from SataQiu/fix-shell-2019022302
Fix shellcheck lint errors in cluster and hack scripts
2019-02-25 15:15:19 -08:00
Kubernetes Prow Robot
a778f409ba
Merge pull request #74385 from SataQiu/fix-shell-20190222
Fix some shellcheck failures in hack
2019-02-25 13:54:32 -08:00
Kubernetes Prow Robot
0813567660
Merge pull request #74349 from mattjmcnaughton/mattjmcnaughton/fix-shellcheck-in-hack
Fix shellcheck for hack/verify-generated-*
2019-02-25 13:54:10 -08:00
Kenichi Omichi
215dee7dd2 Fix golint under test/e2e/framework/ingress 2019-02-25 20:55:03 +00:00
Bob Killen
e137f4702a
Fix shellcheck lint errors in test/kubemark/stop-kubemark.sh 2019-02-25 15:21:32 -05:00
Bob Killen
b8aae458a1
Fix shellcheck lint errors in test/kubemark/start-kubemark.sh 2019-02-25 15:21:31 -05:00
Bob Killen
46333a01b4
Fix shellcheck lint errors in test/kubemark/run-e2e-tests.sh 2019-02-25 15:21:31 -05:00
Bob Killen
adf4bf1741
Fix shellcheck lint errors in test/kubemark/resources/start-kubemark-master.sh 2019-02-25 15:21:31 -05:00
Bob Killen
f72ac1f5b7
Fix shellcheck lint errors in test/kubemark/master-log-dump.sh 2019-02-25 15:21:31 -05:00
Bob Killen
cb59cb33ff
Fix shellcheck lint errors in test/kubemark/iks/util.sh 2019-02-25 15:21:30 -05:00
Bob Killen
e3e2a96521
Fix shellcheck lint errors in test/kubemark/iks/startup.sh 2019-02-25 15:21:30 -05:00
Bob Killen
6310305d3b
Fix shellcheck lint errors in test/kubemark/iks/shutdown.sh 2019-02-25 15:21:30 -05:00
Bob Killen
186b83fe5b
Fix shellcheck lint errors in test/kubemark/gce/util.sh 2019-02-25 15:21:30 -05:00
Bob Killen
5f4b919887
Fix shellcheck lint errors in test/kubemark/common/util.sh 2019-02-25 15:21:29 -05:00
Bob Killen
9a4f4878f5
Fix shellcheck lint errors in cluster/kubemark/util.sh 2019-02-25 15:21:29 -05:00
Bob Killen
9a58913e8f
Fix shellcheck lint errors in cluster/kubemark/iks/config-default.sh 2019-02-25 15:21:25 -05:00
Bob Killen
ce4c85e3fd
Fix shellcheck lint errors in cluster/kubemark/gce/config-default.sh 2019-02-25 14:55:01 -05:00
Kubernetes Prow Robot
35a258d640
Merge pull request #73272 from danielqsj/juju
fix shellcheck in cluster/juju
2019-02-25 11:33:21 -08:00
Kubernetes Prow Robot
f288678cfa
Merge pull request #73261 from danielqsj/local
fix shellcheck in cluster/local
2019-02-25 11:33:11 -08:00
Davanum Srinivas
5d13f6f776
Remove support for containerized-kubelet in local-up-cluster.sh
Change-Id: I3435b02fbe052a88f6b88d5517de2d68ff636a66
2019-02-25 08:53:14 -05:00
SataQiu
09ba08f8f4 fix some golint failures for pkg/apis/... 2019-02-25 18:06:08 +08:00
SataQiu
7181c44230 fix some golint failures for pkg/cloudprovider/providers/vsphere/vclib and pkg/kubelet/apis/... 2019-02-25 18:01:41 +08:00
danielqsj
6322025d5c fix golint failures for test/e2e/upgrades 2019-02-25 16:36:26 +08:00
danielqsj
7c8498ab03 fix golint failures for test/e2e/upgrades/storage 2019-02-25 15:41:31 +08:00
danielqsj
8916ccabaf fix golint failures for test/e2e/upgrades/apps 2019-02-25 13:32:15 +08:00
mattjmcnaughton
b4d086f914 Fix shellcheck for hack/verify-generated-*
All of the `hack/verify-generated-*` files now pass shellcheck and are
removed from `hack/.shellcheck_failures`.
2019-02-24 23:50:59 -05:00
mattjmcnaughton
57c51c741d Fix shellcheck for more scripts in hack
Making more of the scripts in hack pass the shellcheck linter.
2019-02-24 23:48:21 -05:00
SataQiu
d357bcd2cd fix some shellcheck failures in hack 2019-02-25 11:38:56 +08:00
danielqsj
7e655e8666 fix shellcheck in cluster/juju 2019-02-24 20:40:59 +08:00
danielqsj
e698682a0e change a way to pass SC2164 in etcd.sh 2019-02-24 20:26:59 +08:00
danielqsj
c215966d22 fix shellcheck failure in etcd shell 2019-02-24 20:19:50 +08:00
SataQiu
9cda80e836 fix shellcheck lint errors in cluster and hack scripts 2019-02-24 11:15:35 +08:00
Kubernetes Prow Robot
139a13d312
Merge pull request #74269 from moshe010/kubelet_gen_cert
Move kubelet cert generation when starting kubelet
2019-02-23 18:41:10 -08:00
Kubernetes Prow Robot
1cf8001e53
Merge pull request #74449 from xichengliudui/fix190223
make more of the shell pass lints
2019-02-23 12:52:34 -08:00
Kubernetes Prow Robot
6a29f8ca5f
Merge pull request #74451 from xichengliudui/fixshellcheckout190223
fix shellcheck in hack/...
2019-02-23 10:23:15 -08:00
Kubernetes Prow Robot
0133d14170
Merge pull request #72939 from runyontr/test-cmd-what
Test cmd what
2019-02-23 02:54:36 -08:00
Kubernetes Prow Robot
8993fbc543
Merge pull request #74328 from daixiang0/delete-blank
delete all duplicate empty blanks
2019-02-23 01:43:58 -08:00
Kubernetes Prow Robot
795ae35201
Merge pull request #74318 from cblecker/fix-swagger
Fix verify-generated-swagger-docs script
2019-02-23 01:43:48 -08:00
Xiang Dai
36065c6dd7 delete all duplicate empty blanks
Signed-off-by: Xiang Dai <764524258@qq.com>
2019-02-23 10:28:04 +08:00
Kubernetes Prow Robot
743f864310
Merge pull request #73819 from coffeepac/move-fluentd-es-images
Move fluentd es images
2019-02-22 17:58:12 -08:00
Kubernetes Prow Robot
e2b74ad91d
Merge pull request #73864 from oomichi/cleanup-array_contains
Use kube::util::array_contains() in hack
2019-02-22 16:15:10 -08:00
Kubernetes Prow Robot
3afa003126
Merge pull request #73555 from bsalamat/priority_to_ga
Graduate PriorityClass API to GA
2019-02-22 16:14:49 -08:00
Bobby (Babak) Salamat
453498fe2c Graduate PriorityClass to GA 2019-02-22 10:51:13 -08:00
Patrick Christopher
1bd45ba6eb review updates 2019-02-22 10:00:10 -08:00
danielqsj
998147de59 fix shellcheck in pkg/kubectl/cmd/edit/testdata/record_testcase.sh 2019-02-22 15:10:38 +08:00
danielqsj
0e78dd2d17 fix shellcheck in pkg/util/verify-util-pkg.sh 2019-02-22 15:10:16 +08:00
danielqsj
5733241f7a fix shellcheck in plugin/pkg/admission/imagepolicy/gencerts.sh 2019-02-22 15:10:06 +08:00
Kubernetes Prow Robot
651faf2e0d
Merge pull request #74250 from SataQiu/fix-golint-20190219
Fix golint failures on pkg/kubectl/cmd/completion, pkg/kubectl/cmd/cp, pkg/kubectl/cmd/edit
2019-02-21 22:17:36 -08:00
Kubernetes Prow Robot
125dc6c8ea
Merge pull request #74187 from xichengliudui/fixgolint0218
Fix shellcheck lint errors in cluster/addons/fluentd-elasticsearch/fl……uentd-es-image/run.sh
2019-02-21 20:51:13 -08:00
Kubernetes Prow Robot
4f4695fefe
Merge pull request #73214 from danielqsj/metrics
fix shellcheck in k8s.io/metrics
2019-02-21 19:16:31 -08:00
Kubernetes Prow Robot
4763720dc1
Merge pull request #74338 from BenTheElder/testcmdshellcheck
make test/cmd/delete.sh pass shellcheck
2019-02-21 12:26:57 -08:00
Thomas Runyon
f97170ea38 Merge remote-tracking branch 'upstream/master' into test-cmd-what 2019-02-21 11:35:23 -05:00
Aldo Culquicondor
e61cd68bf3 Fix lint on pkg/kubelet/server/... 2019-02-21 10:31:41 -05:00
Kubernetes Prow Robot
59beb8c36b
Merge pull request #74299 from SataQiu/fix-shell-20190220
Fix some shellcheck failures in hack
2019-02-21 02:20:05 -08:00
Kubernetes Prow Robot
7d75b73e1d
Merge pull request #74057 from liggitt/ingress-network-v1beta1
Ingress extensions/v1beta1 -> networking.k8s.io/v1beta1
2019-02-21 01:07:48 -08:00
Benjamin Elder
da859ae734 make test/cmd/delete.sh pass shellcheck 2019-02-21 00:45:37 -08:00
xichengliudui
a499d81fc6 fix shellcheck in test/image/...
update pull request
2019-02-21 03:11:55 -05:00
Kubernetes Prow Robot
e24e944ce1
Merge pull request #74312 from oomichi/golint-e2e-framework-aws
Fix golint failures on e2e/[..]/(aws|azure)
2019-02-20 23:56:36 -08:00
Kubernetes Prow Robot
b3b9658954
Merge pull request #74286 from xichengliudui/fixshellcheck190220
Fix shellcheck lint errors in ./hack/...
2019-02-20 23:56:15 -08:00
xichengliudui
053332ad46 Fix shellcheck lint errors in cluster/addons/fluentd-elasticsearch/fluentd-es-image/run.sh
update pull request

update pull request

update pull request

update pull request

update pull request
2019-02-21 02:00:48 -05:00
Kubernetes Prow Robot
6c1f2077e5
Merge pull request #74192 from xichengliudui/fixshellcheck190218
make more of the shell pass lints
2019-02-20 21:41:25 -08:00
Kubernetes Prow Robot
61b676aae1
Merge pull request #73094 from oomichi/fix-golint-negociate
Fix golint failures on handlers/negotiation
2019-02-20 15:20:48 -08:00
Christoph Blecker
1f5dff7e53
Fix verify-generated-swagger-docs script 2019-02-20 14:37:46 -08:00
Jordan Liggitt
8c28d3f63c Add networking.k8s.io/v1beta1 Ingress 2019-02-20 16:41:14 -05:00
Jordan Liggitt
47cb9559be Move internal Ingress type from extensions to networking 2019-02-20 16:41:12 -05:00
Kubernetes Prow Robot
d60b7d6a64
Merge pull request #73866 from apelisse/add-ssa-tests
Add basic server-side apply test to test-cmd
2019-02-20 11:33:02 -08:00
Kenichi Omichi
36b80a4c61 Fix golint failures on e2e/[..]/(aws|azure) 2019-02-20 19:11:53 +00:00
Kenichi Omichi
302ec98591 Fix golint failures on handlers/negotiation
DefaultEndpointRestrictions is only used in the module,
so this renames it to defaultEndpointRestrictions.
2019-02-20 18:00:25 +00:00
SataQiu
0311c4ddc8 fix some shellcheck failures in hack 2019-02-20 20:37:51 +08:00
Kubernetes Prow Robot
b96342ab92
Merge pull request #72487 from dims/add-minimal-audit-policy-to-local-up-cluster
Add minimal audit policy to local-up-cluster
2019-02-19 23:20:30 -08:00
xichengliudui
9f6928c259 Fix shellcheck lint errors in ./hack/... 2019-02-20 01:31:58 -05:00
Kubernetes Prow Robot
155caa14f6
Merge pull request #74259 from mattjmcnaughton/mattjmcnaughton/fix-shellcheck-lint-failures
Fix shellcheck errors for some scripts in hack/
2019-02-19 21:41:27 -08:00
Kubernetes Prow Robot
f5989303b7
Merge pull request #74060 from SataQiu/fix-shellcheck-20190214
Fix shellcheck failures on kube-down.sh kubeadm.sh get-build.sh
2019-02-19 21:41:17 -08:00
Kubernetes Prow Robot
5cc52ce5d3
Merge pull request #74230 from xichengliudui/fixshellcheck19021902
fix eliminate shellcheck failures in /hack/e2e-internal/...
2019-02-19 19:58:00 -08:00
Kubernetes Prow Robot
9e55995a31
Merge pull request #73989 from oomichi/golint-e2e-framework-metrics
Fix golint failures under test/e2e/framework/metrics
2019-02-19 16:23:48 -08:00
Moshe Levi
33a81a7882 Move kubelet cert generation when starting kubelet
Running local-up-cluster with START_MODE='kubeletonly'
requires cert and kubeconfig. Currently, all the
certs and the kubeconfig are created in the start_apiserver
so it won't be created when only kubelet is started.

This change moves the creation of the kubelet cert and
kubeconfig to start_kubelet. This is helpful if you
want to run kubelet with local-up-cluster and to connect
to an existing master node.

Change-Id: Iaba0bf975297346fbede44342f163024caa256cf
Signed-off-by: Moshe Levi <moshele@mellanox.com>
2019-02-19 23:04:18 +02:00
Kubernetes Prow Robot
ee50d4784d
Merge pull request #74193 from xichengliudui/fixshellcheck19021802
fix shellcheck in test/integration/... and test/kubemark/...
2019-02-19 09:56:07 -08:00
Kubernetes Prow Robot
7fb16d9a8d
Merge pull request #74045 from xichengliudui/fixgolint
Fix golint failures on cmd/apis/extensions/...
2019-02-19 09:55:44 -08:00
mattjmcnaughton
214b910511 Fix shellcheck errors for some scripts in hack/
Five more of the hack/verify-* scripts now pass shellcheck and have been
removed from hack/.shellcheck_failures.
2019-02-19 10:08:15 -05:00
Kubernetes Prow Robot
d61e878533
Merge pull request #73997 from xichengliudui/fixlintcode
Fix golint failures
2019-02-19 01:44:48 -08:00
xichengliudui
0b184d35a1 fixgo lint failures test/integration/...
update pull request

update pull request

add files

update pull request
2019-02-19 04:41:50 -05:00
SataQiu
e2c1f43551 fix golint failures on pkg/kubectl/cmd/completion pkg/kubectl/cmd/cp pkg/kubectl/cmd/edit 2019-02-19 17:39:39 +08:00
xichengliudui
dd7acdcd55 make more of the shell pass lints 2019-02-18 22:50:03 -05:00
xichengliudui
783aa61979 fix shellcheck in hack/ 2019-02-18 19:11:21 -05:00
xichengliudui
b83b83f8e3 aaa 2019-02-18 17:50:55 -05:00
Davanum Srinivas
6b6bfb37fb
Add minimal audit policy to local-up-cluster
Change-Id: Ia2cdb5a6a891665ece5365698f2989ba3782a5ec
2019-02-18 11:18:34 -05:00
Kubernetes Prow Robot
92e0c231fa
Merge pull request #74107 from truongnh1992/adding-shebang
Adding '/usr/bin/env bash'
2019-02-18 00:23:35 -08:00
xichengliudui
641f883b82 fix shellcheck in test/integration/... and test/kubemark/... 2019-02-18 01:16:39 -05:00
danielqsj
d065dd28cd fix shellcheck in k8s.io/metrics 2019-02-18 13:54:11 +08:00
xichengliudui
fd044c5770 make more of the shell pass lints 2019-02-18 00:42:46 -05:00
Kubernetes Prow Robot
16e08f3e53
Merge pull request #73408 from Klaven/component-base-flags
Move flag util pkgs to k8s.io/component-base/cli
2019-02-15 16:46:08 -08:00
Kubernetes Prow Robot
fbee96d733
Merge pull request #73699 from pivotal-k8s/doc-links
Update deprecated and broken links
2019-02-15 14:05:09 -08:00
Kubernetes Prow Robot
256106e5d1
Merge pull request #74053 from SataQiu/fix-golint-20190214
Fix golint failures on cmd/kubeadm/app/util/config
2019-02-15 12:43:45 -08:00
Marek Counts
2e04569530 updated golint_failures to match new project structure. 2019-02-15 10:29:13 -05:00
Kubernetes Prow Robot
aeaeba4a6e
Merge pull request #72772 from lubinsz/pr_etcd
Bug fix: ./hack/install-etcd.sh is not work on Arm64 platform
2019-02-15 06:40:02 -08:00
Kubernetes Prow Robot
c0775786a4
Merge pull request #69250 from warmchang/lint-pkg/routes
fix golint errors in pkg/routes
2019-02-15 06:39:29 -08:00
Ben Moss
34ac4d9ee9 Update deprecated links 2019-02-15 09:13:07 -05:00
Kubernetes Prow Robot
bf20886f4e
Merge pull request #73990 from xichengliudui/fixlinterror
Fix golint failures pkg/kubelet/util/cache
2019-02-14 22:43:15 -08:00
Nguyen Hai Truong
848da13359 Adding '/usr/bin/env bash'
This commit aims to add '/usr/bin/env bash' as a shebang line
to indicates scripts use bash shell for interpreting.

Signed-off-by: Nguyen Hai Truong <truongnh@vn.fujitsu.com>
2019-02-14 19:18:49 -08:00
SataQiu
78e272a927 fix shellcheck failures on kube-down.sh kubeadm.sh get-build.sh 2019-02-14 15:12:08 +08:00
SataQiu
19c7f4cb0b fix golint failures on cmd/kubeadm/app/util/config 2019-02-14 12:11:24 +08:00
Kubernetes Prow Robot
03320c1436
Merge pull request #73985 from BenTheElder/manual-vendor
mark vendor build targets manual
2019-02-13 16:12:02 -08:00
Kenichi Omichi
89f6f1d0cc Fix golint failures under e2e/framework/metrics 2019-02-13 18:07:16 +00:00
SataQiu
a957c83181 fix golint failures on cmd/kubeadm/app 2019-02-13 12:02:28 +08:00
Benjamin Elder
cb68f3edf9 autotag vendor as manual in update-bazel 2019-02-12 18:38:36 -08:00
Kubernetes Prow Robot
5c780c8cb1
Merge pull request #73978 from oomichi/golint-e2e-framework-timer
Fix golint failures of test/e2e/framework/timer
2019-02-12 17:29:43 -08:00
Kubernetes Prow Robot
e4a8ffc9b5
Merge pull request #73218 from danielqsj/kube-aggregator
fix shellcheck in kube-aggregator
2019-02-12 17:28:54 -08:00
Benjamin Elder
d49953e8d0 add buildozer to deps 2019-02-12 15:04:58 -08:00
Kenichi Omichi
60ded1d54a Fix golint failures of test/e2e/framework/timer 2019-02-12 21:01:39 +00:00
xichengliudui
4c42d542dc Fix golint failures
update pull request

update pull request
2019-02-12 13:01:49 -05:00
xichengliudui
a89ee493dd Fix golint failures on cmd/apis/extensions/... 2019-02-12 12:39:48 -05:00
Kubernetes Prow Robot
df7c54fbe4
Merge pull request #73690 from ipuustin/verify-generated-files-remake-2
verify-generated-files-remake.sh: fix issues reported by shellcheck (part 2)
2019-02-12 06:40:50 -08:00
xichengliudui
5aa58efe07 Fix golint failures
update pull request
2019-02-12 07:14:57 -05:00
Kubernetes Prow Robot
a1539747db
Merge pull request #73926 from alculquicondor/fix/kubelet-app-lint
Fix cmd/kubelet/app lint issues
2019-02-12 00:19:06 -08:00
Kubernetes Prow Robot
0ae81c986a
Merge pull request #67678 from caesarxuchao/remove-storage-versions-flag
Remove storage versions flag
2019-02-11 17:40:27 -08:00
Elijah Oyekunle
805a9e7036 Fixes Golint Errors: staging/src/k8s.io/kube-aggregator (#73369)
* fixed golint errors in staging/src/k8s.io/kube-aggregator

* update openapi

* unexported autoRegisterController
2019-02-11 14:16:05 -08:00
Kubernetes Prow Robot
6912bbb153
Merge pull request #71223 from sttts/sttts-openapi-aggreation-without-clone
openapi-aggregation: speed up merging from 1 sec to 50-100 ms
2019-02-11 10:30:56 -08:00
Aldo Culquicondor
17a635448a Fix cmd/kubelet/app lint issues 2019-02-11 13:18:25 -05:00
Dr. Stefan Schimanski
2393799e2e hack/update-openapi-spec.sh: normalize indention of spec through jq 2019-02-11 13:16:36 +01:00
danielqsj
342dc93187 fix shellcheck in kube-aggregator 2019-02-11 10:30:34 +08:00
Kubernetes Prow Robot
e47973bd31
Merge pull request #69086 from bruceauyeung/log-useful-info-instead-of-silent-exit-when-etcd-already-installed
log useful information instead of silent exit without error
2019-02-10 18:14:26 -08:00
Ismo Puustinen
f1cb820b16 Remove verify-generated-files-remake.sh from shellcheck failures. 2019-02-09 22:41:53 +02:00
Ismo Puustinen
b06533af65 verify-generated-files-remake: quote return value.
Fix a shellcheck error by quoting a return value properly.
2019-02-09 22:41:53 +02:00
Ismo Puustinen
c23c83724c verify-generated-files-remake.sh: use strings instead of arrays.
Move away from arrays to strings to fix several shellcheck-reported
issues. It isn't useful to expand the found files into arrays, because
only things that are checked are if the array is empty or the contents
of the first array item.

Fix also a shellcheck issue about using a literal string as regexp
match. It appears that the original reason for using a regexp was to
avoid specifying the directory in which the script is run. However, due
to the need of calling 'make generated_files', the directory is fixed
anyway, and the regexp can be left out.

Testing the change can be done with the following script which emulates
the different cases which the script can see. In the output the variable
'X' is the array and 'Z' is the string.

  #!/bin/bash

  set -o errexit
  set -o nounset
  set -o pipefail

  function find_genfiles() {
      find .                         \
          \(                         \
            -not \(                  \
              \(                     \
                  -path ./_\* -o     \
                  -path ./.\*        \
              \) -prune              \
            \)                       \
          \) -name "$1"
  }

  # $1 = filename pattern as in "zz_generated.$1.go"
  # $2 timestamp file
  function newer() {
      find_genfiles "$1" | while read -r F; do
          if [[ "${F}" -nt "$2" ]]; then
              echo "${F}"
          fi
      done
  }

  STAMP=stamp

  mkdir -p xxx
  touch xxx/foobar

  touch "${STAMP}"

  mkdir -p foo
  touch foo/foobar

  mkdir -p bar
  touch bar/foobar

  # two newer files

  X=($(newer foobar "${STAMP}"))
  if [[ "${#X[*]}" != 0 ]]; then
      echo "X1:"
      echo "  ${X[*]:-(none)}"
  fi

  Z="$(newer foobar "${STAMP}")"
  if [[ -n "$Z" ]]; then
      echo "Z1:"
      echo "  ${Z}" | tr '\n' ' '
      echo ""
  fi

  # no newer files

  touch "${STAMP}"

  X=($(newer foobar "${STAMP}"))
  if [[ "${#X[*]}" != 0 ]]; then
      echo "X2:"
      echo "  ${X[*]:-(none)}"
  fi

  Z="$(newer foobar "${STAMP}")"
  if [[ -n "$Z" ]]; then
      echo "Z2:"
      echo "  ${Z}" | tr '\n' ' '
      echo ""
  fi

  # one newer file, name matches

  touch "${STAMP}"
  touch bar/foobar

  X=($(newer foobar "${STAMP}"))
  if [[ "${#X[@]}" != 1 || ! ( "${X[0]}" =~ "bar/foobar" ) ]]; then
      echo "X3:"
      echo "  ${X[*]:-(none)}"
  fi

  Z="$(newer foobar "${STAMP}")"
  if [[ -z "${Z}" || ${Z} != "./bar/foobar" ]]; then
      echo "Z3:"
      echo "  ${Z:-(none)}" | tr '\n' ' '
      echo ""
  fi

  # one newer file, name doesn't match

  touch "${STAMP}"
  touch foo/foobar

  X=($(newer foobar "${STAMP}"))
  if [[ "${#X[@]}" != 1 || ! ( "${X[0]}" =~ "bar/foobar" ) ]]; then
      echo "X4:"
      echo "  ${X[*]:-(none)}"
  fi

  Z="$(newer foobar "${STAMP}")"
  if [[ -z "${Z}" || ${Z} != "./bar/foobar" ]]; then
      echo "Z4:"
      echo "  ${Z:-(none)}" | tr '\n' ' '
      echo ""
  fi

The expected output from running this script:

X1:
  ./bar/foobar ./foo/foobar
Z1:
  ./bar/foobar ./foo/foobar
X4:
  ./foo/foobar
Z4:
  ./foo/foobar
2019-02-09 22:32:31 +02:00
Ismo Puustinen
fefdfc2ad7 verify-generated-files-remake.sh: fix BASH_SOURCE array. 2019-02-09 22:32:31 +02:00
Kubernetes Prow Robot
40a4c1f723
Merge pull request #73854 from RajatVaryani/master
Fix linting in cmd/kubemark package
2019-02-08 22:00:24 -08:00
Antoine Pelisse
308c981633 Add basic server-side apply test to test-cmd 2019-02-08 16:51:29 -08:00
Kenichi Omichi
4a91b593ba Use kube::util::array_contains() in hack
The common kube::util::array_contains() is already there, so this
makes both scripts use it.
2019-02-08 23:13:48 +00:00
Kubernetes Prow Robot
2a664f4820
Merge pull request #73213 from danielqsj/nodeapi
fix shellcheck in node-api
2019-02-08 13:14:25 -08:00
Patrick Christopher
947afbddb8 test to try and silence spurious spelling warnings 2019-02-08 11:51:31 -08:00
Kubernetes Prow Robot
b50c643be0
Merge pull request #73540 from rlenferink/patch-5
Updated OWNERS files to include link to docs
2019-02-08 09:05:56 -08:00
Rajat Varyani
17fd66946b Fix linting in cmd/kubemark package 2019-02-08 21:30:34 +05:30
Kubernetes Prow Robot
30397a3d23
Merge pull request #73219 from danielqsj/csi-api
fix shellcheck in csi-api
2019-02-08 06:53:52 -08:00
Kubernetes Prow Robot
999e2e0ce8
Merge pull request #73581 from krzysied/test_KUBE_JUNIT_REPORT_DIR_revert
KUBE_JUNIT_REPORT_DIR fixes
2019-02-08 02:39:14 -08:00
Kubernetes Prow Robot
92db54cc53
Merge pull request #73335 from oomichi/cleanup-hack
Add check-file-in-alphabetical-order for cleanup
2019-02-07 18:24:41 -08:00
Kubernetes Prow Robot
22b74dc67b
Merge pull request #73768 from mattjmcnaughton/mattjmcnaughton/support-what-subdirs-for-test
Support make test WHAT=path/to/pkg/...
2019-02-07 09:10:17 -08:00
danielqsj
81b7407557 fix shellcheck in csi-api 2019-02-07 22:08:28 +08:00
danielqsj
253c7aa0ca fix shellcheck in node-api 2019-02-07 21:58:11 +08:00
Krzysztof Siedlecki
c20262eb33 adding FULL_LOG flag 2019-02-07 12:04:43 +01:00
Krzysztof Siedlecki
f461759dc9 adding go-junit-report install 2019-02-07 11:48:22 +01:00
Benjamin Elder
bccf95b10c add bentheelder to reviewers 2019-02-06 16:26:51 -08:00
Kubernetes Prow Robot
fb4bbc72f8
Merge pull request #73257 from ds-ms/shellCheckFailures
Shellcheck failures print-workspace-status.sh, run-in-gopath.sh
2019-02-06 13:23:39 -08:00
Thomas Runyon
6770fa7ba5 Merge remote-tracking branch 'upstream/master' into test-cmd-what 2019-02-06 12:28:52 -05:00
Kubernetes Prow Robot
fcb0d60d4c
Merge pull request #73716 from deads2k/delete-all
add --all-namespaces to kubectl delete
2019-02-06 01:20:15 -08:00
ds-ms
b88195c575 Fixes shellcheck failures run-in-gopath.sh, test-go.sh
Signed-off-by: ds-ms <desattir@microsoft.com>

fixes shellcheck in hack/print-workspace-status.sh, /hack/test-integration.sh

Signed-off-by: ds-ms <desattir@microsoft.com>

reverting test-go.sh test-integration.sh

Signed-off-by: ds-ms <desattir@microsoft.com>

Removing export

Signed-off-by: ds-ms <desattir@microsoft.com>
2019-02-06 11:32:14 +05:30
Kubernetes Prow Robot
04cc8f67fb
Merge pull request #73740 from krzysied/prettybench_vendor
Adding prettybench and go-junit-report to the vendor
2019-02-05 17:27:13 -08:00
Thomas Runyon
4fc5be8d5a Merge remote-tracking branch 'upstream/master' into test-cmd-what 2019-02-05 19:23:21 -05:00
mattjmcnaughton
2d3ad78cf9 Support make test WHAT=path/to/pkg/...
In 99cdc069e2, we added a check for
whether the directory the user was attempting to test existed or not.
However, adding this check prevented us from running `make test
WHAT=./path/to/pkg/...`, because we believed that `./path/to/pkg/...`
wasn't a valid path to a directory.

Fix this by stripping `/...` before checking whether the directory
exists.
2019-02-05 18:57:02 -05:00
David Eads
66b1f5ba67 add --all-namespaces to 2019-02-05 13:37:14 -05:00
Krzysztof Siedlecki
4384845ec5 installing github.com/jstemmer/go-junit-report 2019-02-05 14:54:01 +01:00
Krzysztof Siedlecki
491c000eeb installing github.com/cespare/prettybench 2019-02-05 14:54:01 +01:00
Krzysztof Siedlecki
6c1a842248 adding prettybench and go-junit-report to vendor 2019-02-05 14:54:01 +01:00
Davanum Srinivas
0f2c948df7
Run verify generated files remake in a tmp directory
We already do this in hack/verify-generated-files.sh so we should do it
in verify-generated-files-remake.sh as well.

The idea is that any local changes made because of code generation
should not persist beyond the current run of the script.

Change-Id: I7af176773ae16c393dc2b46c006595243c9fa05b
2019-02-04 20:14:03 -05:00
Roy Lenferink
478880d232 Adding link to docs to godep-save.sh as well 2019-02-04 22:33:12 +01:00
Roy Lenferink
b43c04452f Updated OWNERS files to include link to docs 2019-02-04 22:33:12 +01:00
Thomas Runyon
31aac97a85 Merge remote-tracking branch 'upstream/master' into test-cmd-what 2019-02-01 11:40:18 -05:00
Kubernetes Prow Robot
1b741f4c77
Merge pull request #73246 from danielqsj/code-generator
fix shellcheck in code-generator
2019-01-31 21:58:21 -08:00
Kubernetes Prow Robot
85f1205efa
Merge pull request #73464 from ipuustin/verify-generated-files-remake
verify-generated-files-remake.sh: fix issues reported by shellcheck.
2019-01-31 13:00:04 -08:00
Kubernetes Prow Robot
3b02f17b35
Merge pull request #73477 from liggitt/storage-media-type
Allow control over media-type
2019-01-30 22:03:24 -08:00
Kubernetes Prow Robot
1f7e9fd9a2
Merge pull request #73488 from andrewsykim/replace-utils-file
Replace pkg/util/file with k8s.io/utils/path
2019-01-30 17:50:16 -08:00
Chao Xu
a76c266693 don't run test-update-storage-objects.sh 2019-01-30 13:28:48 -08:00
Daniel (Shijun) Qian
5a1b78ca0c
Merge branch 'master' into code-generator 2019-01-30 22:09:26 +08:00
Kubernetes Prow Robot
dcdd114d0a
Merge pull request #73252 from danielqsj/apie
fix shellcheck in k8s.io/apiextensions-apiserver
2019-01-30 04:06:36 -08:00
Kubernetes Prow Robot
529785e355
Merge pull request #73210 from danielqsj/sample
fix shellcheck pass in sample-apiserver
2019-01-30 00:57:00 -08:00
danielqsj
0b4397f928 fix shellcheck in sample-apiserver 2019-01-30 13:57:44 +08:00
Kubernetes Prow Robot
adc95eb214
Merge pull request #72804 from lubinsz/pr_local
Bug fix: ./hack/local-up-cluster.sh is not work on Arm64 platform
2019-01-29 20:49:25 -08:00
danielqsj
e5b634bb68 fix shellcheck in k8s.io/apiextensions-apiserver 2019-01-30 10:35:42 +08:00
danielqsj
57014c5e18 fix shellcheck in generate groups 2019-01-30 10:33:08 +08:00
danielqsj
46d7f7ca17 fix shellcheck codegen in code-generator 2019-01-30 10:30:19 +08:00
Bin Lu
5cdb762fb9 Bug fix: ./hack/install-etcd.sh is not work on Arm64 platform
Signed-off-by: Bin Lu <bin.lu@arm.com>
2019-01-30 09:52:06 +08:00
Bin Lu
44a36ea36e Bug fix: ./hack/local-up-cluster.sh is not work on Arm64 platform
Signed-off-by: Bin Lu <bin.lu@arm.com>
2019-01-30 09:49:46 +08:00
Andrew Kim
84191eb99b replace pkg/util/file with k8s.io/utils/path 2019-01-29 15:20:13 -05:00
Jordan Liggitt
6cec098771 Allow control over media-type 2019-01-29 10:39:24 -05:00
Kubernetes Prow Robot
34425974c8
Merge pull request #73117 from war-turtle/fixShellCheck
Fixes shellcheck warning in build/common.sh
2019-01-29 06:57:28 -08:00
Ismo Puustinen
83030b67fa verify-generated-files-remake.sh: use 'read -r'.
'read' will not handle backslashes properly. 'read -r' is safer to use.
The find_genfiles() will not insert backslashes, so if there are any,
they will be from directory names.
2019-01-29 13:11:25 +02:00
Ismo Puustinen
a911034e01 verify-generated-files-remake.sh: do not mix strings and arrays.
The pattern used in the file is this:

  echo "  ${X[@]:-(none)}"

What happens is that the array is expanded to separate strings, and it
is checked if that's set (for the default value assignment). However,
the correct way is to check if the concatenated array string is set to
avoid a type mismatch:

  echo "  ${X[*]:-(none)}"

Tests show that at least bash 4.4.23 behaves the same:

  X=(foo bar)
  echo "  ${X[@]:-(none)}"
  echo "  ${X[*]:-(none)}"

  X=()
  echo "  ${X[@]:-(none)}"
  echo "  ${X[*]:-(none)}"

produces:

  foo bar
  foo bar
  (none)
  (none)
2019-01-29 13:11:25 +02:00
Kubernetes Prow Robot
d9fbb9af5e
Merge pull request #73251 from danielqsj/api
fix shellcheck in k8s.io/apiserver
2019-01-29 01:21:13 -08:00
Kubernetes Prow Robot
b2d2432291
Merge pull request #73234 from baltendo/master
Fix golint failures
2019-01-29 01:21:03 -08:00
Kubernetes Prow Robot
6ebe874d11
Merge pull request #73212 from danielqsj/samplecontroller
fix shellcheck in sample-controller
2019-01-29 01:20:52 -08:00
Kubernetes Prow Robot
bbfc3be51b
Merge pull request #73096 from yuwenma/golint1
fix golint failure for pkg/controller/deployment/util
2019-01-28 21:52:15 -08:00
Kubernetes Prow Robot
3c34d28fe0
Merge pull request #72818 from humblec/md-2
Remove explicit nil initialization and correct error string.
2019-01-28 21:52:03 -08:00
Thomas Runyon
b308c53d6d Merge remote-tracking branch 'upstream/master' into test-cmd-what 2019-01-28 20:49:31 -05:00
Yuwen Ma
14a1e27ddd fix golint failure for pkg/controller/deployment/util 2019-01-28 11:00:40 -08:00
bruceauyeung
c53d76d535 log useful information instead of silent exit without error when etcd has already been installed 2019-01-28 15:34:59 +08:00
Dr. Stefan Schimanski
9377448667 Move hack/import-restrictions.yaml to staging/publishing 2019-01-26 19:53:51 +01:00
war-turtle
b1b7d0dbae fixing shellcheck warning in build/common.sh 2019-01-26 19:21:17 +05:30
Thomas Runyon
1a821ff5cf Merge remote-tracking branch 'upstream/master' into test-cmd-what
Conflicts:
	test/cmd/legacy-script.sh
2019-01-26 07:40:33 -05:00
Kubernetes Prow Robot
c6d0cdf309
Merge pull request #72694 from liggitt/integration-api-versions
Use apps/v1 APIs in integration, explicitly enable all resources for print/etcd/scale tests
2019-01-26 00:35:43 -08:00
Kubernetes Prow Robot
fb9e07c664
Merge pull request #70052 from neolit123/placeholder-docs
docs: stop tracking placeholder documentation
2019-01-26 00:35:33 -08:00
Kubernetes Prow Robot
e1605310a5
Merge pull request #72902 from andrewsykim/72649
E2E test for node deleted in cloud provider
2019-01-25 22:31:16 -08:00
Kenichi Omichi
c32d1acbb9 Add check-file-in-alphabetical-order for cleanup
Both verify-golint.sh and verify-shellcheck.sh have the same logic
which checks failure_file in alphabetical order.
In addition, we'd like to add another script which requires the
same logic. So this add a common function for cleanup.
2019-01-26 02:09:06 +00:00
Lubomir I. Ivanov
54e8d73920 docs: stop tracking placeholder documentation
The placeholder documentation introduces a couple of problems:
- it complicates the contributor-experience (forces the CI to run
N times before the contributor finds out that they need to call an .sh
script and include certain files from docs/)
- it forces CLI related pull requests for tools like kubeadm and kubectl
to require top level approval from docs/OWNERS as such PRs still need
to touch the .generated_docs file

Stop tracking the placeholder documentation by applying the
following actions:
- remove the utility set-placeholder-gen-docs()
- make verify-generated-docs.sh only generate in a temporary folder
and not match .generated_docs
- mark generate-docs.sh as an alias for update-generated-docs.sh
- remove all current placeholder files in docs folders admin, man,
user-guide, yaml
- ignore the above folders and .generated_docs in a .gitignore file
2019-01-26 01:07:10 +02:00
andrewsykim
596c6fbf03 e2e test for node deleted in cloud provider 2019-01-25 17:45:18 -05:00
Jordan Liggitt
89b0b0b84b Clean up initializer-related comments, test data 2019-01-25 12:37:45 -05:00
Kubernetes Prow Robot
b466308bbd
Merge pull request #73151 from tanshanshan/fixshell
fix shellcheck failure
2019-01-24 20:07:46 -08:00
Jordan Liggitt
b64075dbd0 explicitly enable apps/v1beta1, apps/v1beta2, extensions/v1beta1 for print,etcd,storage tests 2019-01-24 21:43:15 -05:00
Kubernetes Prow Robot
0210c0d869
Merge pull request #73253 from phenixblue/improve-syntax-for-shell-script
Updates to eliminate shellcheck failures - kubernetes/cluster/centos
2019-01-24 17:46:43 -08:00
Thomas Runyon
fc4bdd9e9d Removed test/kubeadm.sh from shellcheck failure list since it now passes 2019-01-24 19:44:51 -05:00
Kubernetes Prow Robot
2cbb16bc8d
Merge pull request #73243 from andrewsykim/update-utils-vendor
Update vendor k8s.io/utils and remove internal utils
2019-01-24 16:30:14 -08:00
Kubernetes Prow Robot
d1031b18fc
Merge pull request #73279 from dims/fix-problem-fetching-sudo
Run apt-get update before installing sudo
2019-01-24 14:55:33 -08:00
Kubernetes Prow Robot
e28c757e87
Merge pull request #72972 from liggitt/remove-alpha-initializers
Remove use of alpha initializers
2019-01-24 14:54:52 -08:00
Joe Searcy
e72a683f82 Updates to eliminate shellcheck failures in #72956
Extend quotes to full filepath strings

Fixes for reviewers comments
2019-01-24 15:57:26 -05:00
Andrew Kim
aab0ea4e41 allow k8s.io/utils in client-go import restrictions 2019-01-24 15:34:21 -05:00
Andrew Kim
93b086f6ea replace k8s.io/apiserver/pkg/util/trace with k8s.io/utils/trace 2019-01-24 15:34:21 -05:00
Andrew Kim
0bc5508aca replace client-go/util/integer with k8s.io/utils/integer 2019-01-24 15:34:21 -05:00
Davanum Srinivas
279e1ed117
Run apt-get update before installing sudo
recent changes to kubekins broke local-e2e with the following error
```
E: Unable to locate package sudo
```

Change-Id: I9ad324a2a070bc068ed1f0f88a912eafb191ad90
2019-01-24 11:45:42 -05:00
danielqsj
cd5e658518 fix shellcheck in cluster/local 2019-01-24 18:06:55 +08:00
ds-ms
0417d23a4c Fix linting issues in pkg/kubectl/cmd/version
Signed-off-by: ds-ms <desattir@microsoft.com>
2019-01-24 12:26:15 +05:30
Kubernetes Prow Robot
31311a6343
Merge pull request #73148 from liggitt/remove-deprecated-swagger-paths
remove deprecated openapi paths in favor of /openapi/v2
2019-01-23 22:06:21 -08:00
danielqsj
481c2d8e03 fix shellcheck in k8s.io/apiserver 2019-01-24 13:55:09 +08:00
Bernhard Altendorfer
736f35ec29 Fix golint failures 2019-01-24 00:14:25 +01:00
Kubernetes Prow Robot
a5d55f49b0
Merge pull request #73217 from kubernetes/revert-73071-reflector_trace
Revert "Adding trace to reflector initialization"
2019-01-23 12:20:27 -08:00