github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
105,471 Commits 1 Branch 31 Tags
30e06ecf1e893dffa0e17813acd39e49709f2fce
Commit Graph

43600 Commits

Author SHA1 Message Date
Jiekun
30e06ecf1e #106203 Added test cases for PriorityQueue Activate 2021-12-18 22:12:46 +08:00
Kubernetes Prow Robot
1426587e08 Merge pull request #106436 from dims/cleanup-owners-files-no-activity-in-a-year 
Cleanup OWNERS files (No Activity in the last year)
 2021-12-15 12:07:51 -08:00
Kubernetes Prow Robot
66931c9b8f Merge pull request #106703 from scottnice/patch-1 
Fixed skipping valid volume plugins when another plugin has an error
 2021-12-15 09:53:50 -08:00
Davanum Srinivas
497e9c1971 Cleanup OWNERS files (No Activity in the last year) 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2021-12-15 10:34:02 -05:00
BinacsLee
d484b1aa3d scheduler: cleanup return value 2021-12-15 21:51:42 +08:00
Kubernetes Prow Robot
8324868f89 Merge pull request #106950 from sunzhaochang/fix-unexpected-end-test 
Fix unexpected end of TestDependentsRace
 2021-12-14 15:16:49 -08:00
Scott Nice
d9cbe5d314 Added unit test for flex volume probe and updated DynamicPluginProber Probe() interface description 2021-12-14 10:48:51 -05:00
Jordan Liggitt
0b90b6ec5e Add field paths to expected unknown/duplicate errors 2021-12-13 09:38:13 -05:00
Kubernetes Prow Robot
ba200841fd Merge pull request #106366 from cyclinder/evictions_number_stable 
adding evictions_total metric and marking evictions_number deprecated
 2021-12-12 23:19:59 -08:00
cyclinder
b88b51c6e5 adding evictions_total metric and marking evictions_number deprecated 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2021-12-13 10:36:02 +08:00
Kubernetes Prow Robot
0cae5f5006 Merge pull request #106744 from BinacsLee/binacs/fix-race-condition-in-scheduler-eventhandler 
scheduler: fix race condition during cache refresh
 2021-12-11 00:31:59 -08:00
Kubernetes Prow Robot
030c3fbd58 Merge pull request #106936 from sbangari/windowsserviceflappingfix 
Skip creating HNS loadbalancer with empty endpoints
 2021-12-10 22:41:57 -08:00
Kubernetes Prow Robot
1d66302c42 Merge pull request #106458 from dims/lint-yaml-in-owners-files 
Lint/Beautify yaml in OWNERS files
 2021-12-10 06:39:12 -08:00
BinacsLee
1027b8de40 scheduler: fix race condition during cache refresh 2021-12-10 20:46:12 +08:00
Kubernetes Prow Robot
1b0d83f1d6 Merge pull request #106599 from klueska/fix-numa-bug 
Fix Bugs in CPUManager distribute NUMA policy option
 2021-12-10 04:41:12 -08:00
sunzhaochang
f0e74bfb7f Fix unexpected end of TestDependentsRace 2021-12-10 20:07:37 +08:00
Sravanth Bangari
26be8d6890 Skip creating HNS loadbalancer with empty endpoints 2021-12-09 20:03:21 -08:00
Kubernetes Prow Robot
15e5f2a19a Merge pull request #106291 from sbs2001/fix_invalid_comment 
Remove invalid comment in legacyregistry
 2021-12-09 19:03:10 -08:00
Davanum Srinivas
9405e9b55e Check in OWNERS modified by update-yamlfmt.sh 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2021-12-09 21:31:26 -05:00
David Porter
95264a418d kubelet: set failed phase during graceful shutdown 
Revert to previous behavior in 1.21/1.20 of setting pod phase to failed
during graceful node shutdown.

Setting pods to failed phase will ensure that external controllers that
manage pods like deployments will create new pods to replace those that
are shutdown. Many customers have taken a dependency on this behavior
and it was breaking change in 1.22, so this change reverts back to the
previous behavior.

Signed-off-by: David Porter <david@porter.me>
 2021-12-09 13:17:40 -08:00
Scott Nice
5183513661 Fix gofmt verify 2021-12-09 09:18:22 -05:00
Kubernetes Prow Robot
cdf3ad823a Merge pull request #97252 from dims/drop-dockershim 
Completely remove in-tree dockershim from kubelet
 2021-12-08 12:51:46 -08:00
Kubernetes Prow Robot
2daa3415ec Merge pull request #106838 from mengjiao-liu/remove-NamespaceDefaultLabelName-feature-gate 
Remove feature gate NamespaceDefaultLabelName
 2021-12-08 08:53:46 -08:00
Kubernetes Prow Robot
f356ae4ad9 Merge pull request #101719 from SergeyKanzhelev/removeReallyCrashForTesting 
Remove ReallyCrashForTesting and cleaned up some references to Handle…
 2021-12-07 23:39:45 -08:00
Kubernetes Prow Robot
b9977a7b17 Merge pull request #106851 from BinacsLee/binacs/cleanup-scheduler-profile 
cleanup: return frameworkruntime.NewFramework directly
 2021-12-07 19:28:52 -08:00
Kubernetes Prow Robot
d7f8234b6d Merge pull request #106747 from ahg-g/ahg-test 
Added an integration test for NodeResourcesFit scoring
 2021-12-07 19:28:06 -08:00
Kubernetes Prow Robot
022d49dcbc Merge pull request #106740 from wojtek-t/update_kubemark_clients 
Update kubemark to use EndpointSlices and proper user-agents
 2021-12-07 19:27:59 -08:00
Kubernetes Prow Robot
d16a5e5feb Merge pull request #106673 from qmloong/qmloong/master 
refactor: use utilerrors instead of join error msg
 2021-12-07 18:27:22 -08:00
Kubernetes Prow Robot
68b53cf940 Merge pull request #106581 from knabben/win-kernel-kproxy-metrics 
Registering kube-proxy metrics on windows kernel mode
 2021-12-07 18:26:09 -08:00
Kubernetes Prow Robot
75109026d0 Merge pull request #106447 from hyschumi/fix-noderesources 
cleanup duplicated method `makeNodeWithExtendedResource` in noderesources unit test
 2021-12-07 17:27:10 -08:00
Kubernetes Prow Robot
b8c1b38261 Merge pull request #106406 from cyclinder/remove_DeleteChain_TODO 
kube-proxy remove todo: call iptables -S first when delete chain
 2021-12-07 17:26:56 -08:00
Kubernetes Prow Robot
39b45fb040 Merge pull request #106381 from dims/update-dims-as-approver 
Update `dims` as approver for some top level dirs
 2021-12-07 17:26:48 -08:00
Kubernetes Prow Robot
12901b95c9 Merge pull request #106344 from ikeeip/fix_import_formatting 
Fix golang imports in k8s.io/pkg/controller/volume/persistentvolume package
 2021-12-07 17:26:40 -08:00
Kubernetes Prow Robot
a90f31f85a Merge pull request #106179 from vivek-koppuru/fix-secret-format 
Fix string output format for secret validations
 2021-12-07 17:26:10 -08:00
Kubernetes Prow Robot
b685b3982d Merge pull request #105360 from shuheiktgw/refactor_kubelet_config_validation_tests 
Refactor kubelet config validation tests
 2021-12-07 17:25:43 -08:00
Kubernetes Prow Robot
8174b0923c Merge pull request #105127 from astraw99/fix-dup-kubeClient 
Fix duplicate CSI kube client
 2021-12-07 17:25:30 -08:00
Davanum Srinivas
bc78dff42e update files to drop dockershim 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2021-12-07 15:15:13 -05:00
Davanum Srinivas
83265c9171 drop files deleted from pkg/kubelet/dockershim 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2021-12-07 15:15:13 -05:00
BinacsLee
ab413849cc cleanup: return frameworkruntime.NewFramework directly 2021-12-07 23:29:56 +08:00
Mengjiao Liu
f3c37c2c82 Remove feature gate NamespaceDefaultLabelName 2021-12-07 16:51:17 +08:00
Sascha Grunert
a063a2ba3e Revert dockershim CRI v1 changes 
We should not touch the dockershim ahead of removal and therefore
default to `v1alpha2` CRI instead of `v1`.

Partially reverts changes from https://github.com/kubernetes/kubernetes/pull/106501

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
 2021-12-03 18:37:11 +01:00
Sergey Kanzhelev
1918ecad04 update the grpc field name for consistency 2021-12-01 18:16:08 +00:00
Abdullah Gharaibeh
33a04dc5f5 Added an integration test for NodeResourcesFit scoring 2021-11-30 12:13:30 -05:00
Wojciech Tyczyński
243f4faa6d Update kubemark to use EndpointSlices and proper user-agents 2021-11-30 11:38:08 +01:00
Sergey Kanzhelev
a11453efbc remove ReallyCrashForTesting and cleaned up some references to HandleCrash behavior 2021-11-29 20:00:10 +00:00
menglong.qi
ea31d7b813 refactor: use utilerrors instead of join error msg 2021-11-28 17:16:17 +08:00
Scott Nice
1070eb7428 Fixed issue in plugin.go for bug #106696 
Fixed issue in plugin.go where valid plugin events would be skipped if any plugin had an error. This meant that valid plugins would never be installed if another was in an error state as the events fired only once.
 2021-11-27 15:07:19 -05:00
Kevin Klues
f8511877e2 Add regression test for CPUManager distribute NUMA algorithm 
We witnessed this exact allocation attempt in a live cluster and witnessed the
algorithm fail with an accounting error. This test was added to verify that
this case is now handled by the updates to the algorithm and that we don't
regress from it in the future.

"test" description="ensure previous failure encountered on live machine has been fixed (1/1)"
"combo remainderSet balance" combo=[2 4 6] remainderSet=[2 4 6] distribution=9 remainder=1 available=[14 2 4 4 0 3 4 1] balance=4.031
"combo remainderSet balance" combo=[2 4 6] remainderSet=[2 4] distribution=9 remainder=1 available=[0 3 4 1 14 2 4 4] balance=4.031
"combo remainderSet balance" combo=[2 4 6] remainderSet=[2 6] distribution=9 remainder=1 available=[1 14 2 4 4 0 3 4] balance=4.031
"combo remainderSet balance" combo=[2 4 6] remainderSet=[4 6] distribution=9 remainder=1 available=[1 3 4 0 14 2 4 4] balance=4.031
"combo remainderSet balance" combo=[2 4 6] remainderSet=[2] distribution=9 remainder=1 available=[4 0 3 4 1 14 2 4] balance=4.031
"combo remainderSet balance" combo=[2 4 6] remainderSet=[4] distribution=9 remainder=1 available=[3 4 0 14 2 4 4 1] balance=4.031
"combo remainderSet balance" combo=[2 4 6] remainderSet=[6] distribution=9 remainder=1 available=[1 13 2 4 4 1 3 4] balance=3.606
"bestCombo found" distribution=9 bestCombo=[2 4 6] bestRemainder=[6]

Signed-off-by: Kevin Klues <kklues@nvidia.com>
 2021-11-24 20:49:58 +00:00
Kevin Klues
e284c74d93 Add unit test for CPUManager distribute NUMA algorithm verifying fixes 
Before Change:
"test" description="ensure bestRemainder chosen with NUMA nodes that have enough CPUs to satisfy the request"
"combo remainderSet balance" combo=[0 1 2 3] remainderSet=[0 1] distribution=8 remainder=2 available=[-1 -1 0 6] balance=2.915
"combo remainderSet balance" combo=[0 1 2 3] remainderSet=[0 2] distribution=8 remainder=2 available=[-1 0 -1 6] balance=2.915
"combo remainderSet balance" combo=[0 1 2 3] remainderSet=[0 3] distribution=8 remainder=2 available=[5 -1 0 0] balance=2.345
"combo remainderSet balance" combo=[0 1 2 3] remainderSet=[1 2] distribution=8 remainder=2 available=[0 -1 -1 6] balance=2.915
"combo remainderSet balance" combo=[0 1 2 3] remainderSet=[1 3] distribution=8 remainder=2 available=[0 -1 0 5] balance=2.345
"combo remainderSet balance" combo=[0 1 2 3] remainderSet=[2 3] distribution=8 remainder=2 available=[0 0 -1 5] balance=2.345
"bestCombo found" distribution=8 bestCombo=[0 1 2 3] bestRemainder=[0 3]

--- FAIL: TestTakeByTopologyNUMADistributed (0.01s)
    --- FAIL: TestTakeByTopologyNUMADistributed/ensure_bestRemainder_chosen_with_NUMA_nodes_that_have_enough_CPUs_to_satisfy_the_request (0.00s)
        cpu_assignment_test.go:867: unexpected error [accounting error, not enough CPUs allocated, remaining: 1]

After Change:
"test" description="ensure bestRemainder chosen with NUMA nodes that have enough CPUs to satisfy the request"
"combo remainderSet balance" combo=[0 1 2 3] remainderSet=[3] distribution=8 remainder=2 available=[0 0 0 4] balance=1.732
"bestCombo found" distribution=8 bestCombo=[0 1 2 3] bestRemainder=[3]

SUCCESS

Signed-off-by: Kevin Klues <kklues@nvidia.com>
 2021-11-24 20:45:37 +00:00
Kevin Klues
031f11513d Fix accounting bug in CPUManager distribute NUMA policy 
Without this fix, the algorithm may decide to allocate "remainder" CPUs from a
NUMA node that has no more CPUs to allocate. Moreover, it was only considering
allocation of remainder CPUs from NUMA nodes such that each NUMA node in the
remainderSet could only allocate 1 (i.e. 'cpuGroupSize') more CPUs. With these
two issues in play, one could end up with an accounting error where not enough
CPUs were allocated by the time the algorithm runs to completion.

The updated algorithm will now omit any NUMA nodes that have 0 CPUs left from
the set of NUMA nodes considered for allocating remainder CPUs. Additionally,
we now consider *all* combinations of nodes from the remainder set of size
1..len(remainderSet). This allows us to find a better solution if allocating
CPUs from a smaller set leads to a more balanced allocation. Finally, we loop
through all NUMA nodes 1-by-1 in the remainderSet until all rmeainer CPUs have
been accounted for and allocated. This ensure that we will not hit an
accounting error later on because we explicitly remove CPUs from the remainder
set until there are none left.

A follow-on commit adds a set of unit tests that will fail before these
changes, but succeeds after them.

Signed-off-by: Kevin Klues <kklues@nvidia.com>
 2021-11-24 19:18:11 +00:00