Steve Kuznetsov
3939f3003e
storage: move the APIObjectVersioner definition to storage
...
The means by which we extract and parse the version of an API object is
not specific to etcd3. In order to allow for a generic suite of tests
against any storage.Interface imlpementation, we need this logic to live
outside of the etcd3 package, or import cycles will exist.
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com >
2022-05-11 08:19:32 -07:00
Kubernetes Prow Robot
efb62b3538
Merge pull request #108080 from astoycos/issue-132
...
Fix Panic Condition
2022-05-11 05:01:02 -07:00
Kubernetes Prow Robot
cf64022a0f
Merge pull request #109896 from superbrothers/kubectl-delete-fix-discovery-cache-ttl
...
Fix discovery cache TTL to 6 hours
2022-05-10 14:33:36 -07:00
Kubernetes Prow Robot
33b2e16372
Merge pull request #107213 from mk46/portname_validation
...
Fixed port name validation error message.
2022-05-10 10:03:42 -07:00
Kubernetes Prow Robot
cc66198570
Merge pull request #108492 from kerthcet/feature/add-NodeInclustionPolicies
...
Add NodeInclusionPolicy to TopologySpreadConstraint in PodSpec
2022-05-10 08:41:43 -07:00
Andrew Stoycos
6aa779f4ed
Fix Panic Condition
...
Currenlty an event recorder can send an event to a
broadcaster that is already stopped, resulting
in a panic. This ensures the broadcaster holds
a lock while it is shutting down and then forces
any senders to drop queued events following
broadcaster shutdown.
It also updates the Action, ActionOrDrop, Watch,
and WatchWithPrefix functions to return an error
in the case where data is sent on the closed bradcaster
channel rather than panicing.
Lastly it updates unit tests to ensure the fix works correctly
fixes: https://github.com/kubernetes/kubernetes/issues/108518
Signed-off-by: Andrew Stoycos <astoycos@redhat.com >
2022-05-10 09:52:08 -04:00
Kubernetes Prow Robot
e38dba7a15
Merge pull request #109925 from MikeSpreitzer/more-better-bench
...
Simplify and extend the benchmarks of prometheusextension timing histograms
2022-05-10 05:18:08 -07:00
Kubernetes Prow Robot
ccb7118c22
Merge pull request #109914 from stevekuznetsov/skuznets/generic-watch-cancel-test
...
storage/testing: move cancelled watch test to generic package
2022-05-10 05:17:44 -07:00
Kubernetes Prow Robot
0ee7906524
Merge pull request #109909 from stevekuznetsov/skuznets/generic-create-test
...
storage/testing: move creation test to generic package
2022-05-10 04:05:43 -07:00
Kubernetes Prow Robot
d60fb258d9
Merge pull request #109874 from jackfrancis/IPv6DualStack-ga-rm-featuregate
...
azure: remove GA IPv6DualStack feature-gate
2022-05-09 23:33:44 -07:00
kerthcet
02f0a3ee91
feat: add NodeInclusionPolicy to TopologySpreadConstraint in PodSpec
...
Signed-off-by: kerthcet <kerthcet@gmail.com >
2022-05-10 12:54:49 +08:00
Mike Spreitzer
f3068efcfb
Simplify and extend the benchmarks of timing histograms
...
Replace the use of a clock abstraction with direct provision of the
time-reading function.
Add benchmarks of two ways to fetch and use a vector member.
Following are the results using the revised benchmark suite.
(base) mspreitz@mjs12 prometheusextension % go test -benchmem -run=^$ -bench Histogram .
goos: darwin
goarch: amd64
pkg: k8s.io/component-base/metrics/prometheusextension
cpu: Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
BenchmarkTimingHistogramDirect-16 28562178 39.47 ns/op 0 B/op 0 allocs/op
BenchmarkTimingHistogramVecEltCached-16 29268819 39.41 ns/op 0 B/op 0 allocs/op
BenchmarkTimingHistogramVecEltFetched-16 8345041 142.5 ns/op 32 B/op 1 allocs/op
BenchmarkWeightedHistogram-16 49803134 24.22 ns/op 0 B/op 0 allocs/op
BenchmarkHistogram-16 41756210 29.40 ns/op 0 B/op 0 allocs/op
PASS
ok k8s.io/component-base/metrics/prometheusextension 6.488s
(base) mspreitz@mjs12 prometheusextension % go test -benchmem -run=^$ -bench Histogram .
goos: darwin
goarch: amd64
pkg: k8s.io/component-base/metrics/prometheusextension
cpu: Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
BenchmarkTimingHistogramDirect-16 28246786 39.60 ns/op 0 B/op 0 allocs/op
BenchmarkTimingHistogramVecEltCached-16 29318173 39.44 ns/op 0 B/op 0 allocs/op
BenchmarkTimingHistogramVecEltFetched-16 8441341 142.5 ns/op 32 B/op 1 allocs/op
BenchmarkWeightedHistogram-16 48469184 24.21 ns/op 0 B/op 0 allocs/op
BenchmarkHistogram-16 41001742 29.51 ns/op 0 B/op 0 allocs/op
PASS
ok k8s.io/component-base/metrics/prometheusextension 6.340s
(base) mspreitz@mjs12 prometheusextension % go test -benchmem -run=^$ -bench Histogram .
goos: darwin
goarch: amd64
pkg: k8s.io/component-base/metrics/prometheusextension
cpu: Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
BenchmarkTimingHistogramDirect-16 28983674 40.82 ns/op 0 B/op 0 allocs/op
BenchmarkTimingHistogramVecEltCached-16 29527742 43.83 ns/op 0 B/op 0 allocs/op
BenchmarkTimingHistogramVecEltFetched-16 8238685 143.8 ns/op 32 B/op 1 allocs/op
BenchmarkWeightedHistogram-16 49594070 24.24 ns/op 0 B/op 0 allocs/op
BenchmarkHistogram-16 41100378 29.35 ns/op 0 B/op 0 allocs/op
PASS
ok k8s.io/component-base/metrics/prometheusextension 6.554s
2022-05-09 23:21:49 -04:00
Steve Kuznetsov
2e118f4246
storage/testing: move creation test to generic package
...
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com >
2022-05-09 13:46:24 -07:00
Steve Kuznetsov
6d25e96ced
etcd3/store: make creation test validation generic
...
Different callers to this test may need to do different backend-specific
validation on the stored data, so we allow them a callback for this.
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com >
2022-05-09 13:46:22 -07:00
Steve Kuznetsov
1f24bd91c3
storage/testing: move cancelled watch test to generic package
...
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com >
2022-05-09 09:19:07 -07:00
Steve Kuznetsov
c0fc817255
etcd3/store: call a generic cancelled watch test
...
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com >
2022-05-09 08:23:03 -07:00
Steve Kuznetsov
774870611c
etcd3/store: update cancelled watch test to be generic
...
There's no reason to create the watch using the underlying watcher.
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com >
2022-05-09 08:22:04 -07:00
Steve Kuznetsov
f894f8196d
etcd3/store: update creation test to use storage client
...
There is no functional difference between checking for an empty key
using the database client and doing so with the storage interface. Using
the latter allows this test to be more portable.
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com >
2022-05-09 07:59:38 -07:00
Kazuki Suda
d2b4c017c8
Fix discovery cache TTL to 6 hours
...
Signed-off-by: Kazuki Suda <kazuki.suda@gmail.com >
2022-05-09 13:47:52 +09:00
Kubernetes Prow Robot
bf52c1fd46
Merge pull request #109891 from pohly/log-dependency-update
...
dependencies: logr and zapr v1.2.3
2022-05-08 17:59:18 -07:00
Kubernetes Prow Robot
7af5a7bfc5
Merge pull request #109602 from lavalamp/remove-clustername
...
Finish clustername removal
2022-05-07 08:01:16 -07:00
Kubernetes Prow Robot
af4dceeac2
Merge pull request #109308 from danwinship/traffic-policy-docs
...
Clarify ExternalTrafficPolicy/InternalTrafficPolicy definitions
2022-05-06 17:23:16 -07:00
Jack Francis
b2e40d8f32
azure: remove GA IPv6DualStack feature-gate
2022-05-06 14:40:51 -07:00
Daniel Smith
a427cd6569
compat
2022-05-06 21:25:20 +00:00
Kubernetes Prow Robot
f7457747f6
Merge pull request #109833 from stevekuznetsov/skuznets/move-simple-tests
...
storage/etcd3: factor tests to accept `storage.Interface`
2022-05-06 09:07:25 -07:00
Kubernetes Prow Robot
e84f62e695
Merge pull request #109836 from tnqn/fix-apiservice-error
...
Fix OpenAPI loading error caused by empty APIService
2022-05-06 07:57:16 -07:00
Patrick Ohly
3e6974e0ba
dependencies: logr and zapr v1.2.3
...
The updated zapr is more resilient against MarshalLog crashing. Not a known
problem in Kubernetes, though.
2022-05-06 15:16:56 +02:00
Daniel Smith
1dabd7be5c
generated files
2022-05-05 20:12:51 +00:00
Daniel Smith
331525670b
Remove ClusterName
2022-05-05 20:12:50 +00:00
Steve Kuznetsov
4ff560e4fa
storage/testing: wire things back together with imports
...
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com >
2022-05-05 11:32:20 -07:00
Quan Tian
b501b8c9c0
Fix OpenAPI loading error caused by empty APIService
...
SpecAggregator's GetAPIServiceNames method returned empty APIService
name by mistake, causing OpenAPI controller handling an invalid
APIService continuously.
Signed-off-by: Quan Tian <qtian@vmware.com >
2022-05-06 02:01:48 +08:00
Kubernetes Prow Robot
ac61dc624c
Merge pull request #109626 from logicalhan/watch-cache-metrics
...
refactor watch cache metrics so that they are in a single place
2022-05-05 09:44:43 -07:00
Kubernetes Prow Robot
8041606dfa
Merge pull request #109557 from mborsz/traces
...
Improve Create/Update traces.
2022-05-05 09:44:32 -07:00
Kubernetes Prow Robot
0bd2847019
Merge pull request #109435 from pohly/feature-gates-sorting
...
1.25: feature gate cleanup
2022-05-05 09:44:20 -07:00
Steve Kuznetsov
0bfeb72878
storage/etcd3: move reusable tests to importable files
...
These can't live in `_test.go` files, or others won't be able to re-use
them as you can't import from test files.
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com >
2022-05-05 09:29:12 -07:00
Steve Kuznetsov
117f674cab
storage/etcd3: factor tests to accept storage.Interface
...
This commit simply factors the test functionality into functions that
accept `storage.Interface`.
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com >
2022-05-05 09:27:49 -07:00
Kubernetes Prow Robot
64d1acd21b
Merge pull request #109711 from MushuEE/patch-1
...
Update Metrics doc as there is a typo in package
2022-05-05 08:14:20 -07:00
Kubernetes Prow Robot
b7c4d243de
Merge pull request #109804 from cici37/celUpdate
...
Bump cel-go to v0.11.2
2022-05-05 01:44:01 -07:00
Kubernetes Prow Robot
78f3b812ff
Merge pull request #109803 from liggitt/api-fixture-data
...
v1.24.0 API fixture data
2022-05-05 01:43:53 -07:00
Kubernetes Prow Robot
43575888fd
Merge pull request #109750 from aojea/spdy_tls
...
spdyroundtripper: don't need to verify server hostname twice
2022-05-05 01:42:59 -07:00
Kubernetes Prow Robot
a685faa798
Merge pull request #109607 from liggitt/drop-unused-third-party
...
Drop unused golang/template package and funcs
2022-05-05 01:42:20 -07:00
Maciej Borsz
56769e794b
Improve Create/Update/Patch traces.
2022-05-05 07:44:37 +00:00
Patrick Ohly
85513e4bca
features: reduce risk of merge conflicts
...
Merge conflicts become less likely when:
- features are sorted alphabetically because
then changes are more likely to be done in
different parts of the files
- blank lines separate the hash entries because
gofmt then doesn't change the formating of
other entries when adding or removing one
Merge conflicts where pretty common shortly before a code freeze when everyone
added new features at the end of the files.
2022-05-05 08:22:16 +02:00
cici37
a3587c12da
Update go-control-plane, cncf/xds/go, cncf/udpa/go and remove unused versions
2022-05-04 18:45:22 -07:00
cici37
334d8fb7a2
Update GRPC
2022-05-04 18:41:20 -07:00
cici37
e8f6184d86
Update genproto and antlr.
2022-05-04 18:37:30 -07:00
cici37
a86dd29157
Bump cel-go to v0.11.2
2022-05-04 18:32:06 -07:00
Kubernetes Prow Robot
cb7beb5912
Merge pull request #109440 from liggitt/gomod-1.18
...
update go.mod files to go 1.18
2022-05-04 18:16:19 -07:00
Jordan Liggitt
94035cff0e
Remove v1.22.0 API fixture data
2022-05-04 17:32:48 -04:00
Jordan Liggitt
b127b2735b
Add v1.24.0 fixture data
2022-05-04 17:32:29 -04:00