Commit Graph

46167 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
1d6ae20301 Merge pull request #114798 from kerthcet/cleanup/code-refactor
Code refactor for readability in `RunFilterPlugins`
2023-01-09 17:31:12 -08:00
Kubernetes Prow Robot
1e3946ce9d Merge pull request #114923 from mimowo/do-not-leak-pod-name-in-event
Adjust preemption event message to do not include preemptor pod metadata
2023-01-09 13:51:28 -08:00
Kubernetes Prow Robot
b3138ba1b3 Merge pull request #114907 from haoruan/doc-fix-typo
fix a typo in pkg/proxy/ipvs/proxier.go
2023-01-09 12:47:39 -08:00
Kubernetes Prow Robot
e7549eae87 Merge pull request #114905 from kannon92/sync-job-test-fix
Fix SyncPastDeadlineJobFinished for enabling finalizer path
2023-01-09 12:47:28 -08:00
Kubernetes Prow Robot
eb7fd7f51c Merge pull request #114914 from mimowo/do-not-leak-pod-name
Adjust DisruptionTarget condition message to do not include preemptor pod metadata
2023-01-09 11:15:40 -08:00
Kubernetes Prow Robot
bea405c581 Merge pull request #114876 from alculquicondor/fix-deadline-test
Ensure job is up to date in informer cache in test
2023-01-09 10:07:28 -08:00
Michal Wozniak
f79a34d267 Do not leak cross namespace pod metadata in preemption events 2023-01-09 18:30:19 +01:00
kannon92
0362c67859 Fix SyncPastDeadlineJobFinished for enabling finalizer path 2023-01-09 17:12:52 +00:00
Aldo Culquicondor
4c1b95ddfa Ensure job is up to date in informer cache in test
The fake client doesn't guarantee that the informer cache is updated.
If it's not up-to-date, the controller always tries to set the
StartTime, leading to a broken test.

Change-Id: I71f26d46ea44beff88f0d03517985348654aec95
2023-01-09 10:53:19 -05:00
Michal Wozniak
bdf58ce2eb Adjust DisruptionTarget condition message to do not include preemptor metadata 2023-01-09 12:22:19 +01:00
Hao Ruan
7f3de6e53a fix a typo in pkg/proxy/ipvs/proxier.go 2023-01-09 09:29:22 +08:00
Kensei Nakada
570c2d7036 cleanup(nodeaffinity): remove impossible scenario from test cases 2023-01-07 08:46:35 +00:00
Kante Yin
2ceadfe885 Code refactor for readability
Signed-off-by: Kante Yin <kerthcet@gmail.com>
2023-01-07 11:31:46 +08:00
Ian K. Coolidge
5533e49e2c cpuset: Add package comment
Describe use cases (node IDs, HT siblings, etc)

Call out novelty (Linux CPU list parse/dump)

Describe future work (relax immutable, refactor to use 'set')
2023-01-06 23:32:51 +00:00
Ian K. Coolidge
cbb985a310 cpuset: Delete 'builder' methods
All usage of builder pattern is convertible to cpuset.New()
with the same or fewer lines of code.

Migrate Builder.Add to a private method of CPUSet, with a comment
that it is only intended for internal use to preserve immutable
propoerty of the exported interface.

This also removes 'require' library dependency, which avoids
non-standard library usage.
2023-01-06 23:32:51 +00:00
Ian K. Coolidge
f3829c4be3 cpuset: Rename 'NewCPUSet' to 'New' 2023-01-06 23:32:51 +00:00
Ian K. Coolidge
768b1ecfb6 cpuset: hide 'Filter' API
FilterNot is only used in this file, and is trivially converted to a
'filter' call site by inverting the predicate.

Filter is only used in this file, so don't export it.
2023-01-06 23:32:51 +00:00
Ian K. Coolidge
e5143d16c2 cpuset: Make 'ToSlice*' methods look like 'set' methods
In 'set', conversions to slice are done also, but with different names:

ToSliceNoSort() -> UnsortedList()
ToSlice() -> List()

Reimplement List() in terms of UnsortedList to save some duplication.
2023-01-06 23:32:51 +00:00
Ian K. Coolidge
a0c989b99a cpuset: Remove *Int64 methods
These are rarely used and can be accommodated with a trivial helper.
2023-01-06 23:32:51 +00:00
Ian K. Coolidge
67a057d4f2 cpuset: Remove 'MustParse' method
Removes exit/fatal from cpuset library.

Usage in podresources test was not necessary.

Library reference in cpu_manager_test was moved to a local function, and
converted to use e2e test framework error catching.
2023-01-06 23:32:51 +00:00
Ian K. Coolidge
824bd57ad6 cpuset: Convert Union arguments to variadic
This allows Union to implement UnionAll easily.
2023-01-06 23:32:50 +00:00
Jordan Liggitt
e55c9843ab Regenerate openapi 2023-01-06 12:24:30 -05:00
Kubernetes Prow Robot
c549b59983 Merge pull request #114125 from sanposhiho/skip-reimplementation
feature(scheduler): won't run Filter if PreFilter returned a Skip status
2023-01-06 02:25:59 -08:00
Kubernetes Prow Robot
bd43394467 Merge pull request #114623 from Huang-Wei/feat/smart-preemption-identification
Enhanced logic to identify eligible preemption node
2023-01-06 00:23:59 -08:00
Kensei Nakada
e5b536755f feature(scheduler): won't run Filter if PreFilter returned a Skip status 2023-01-06 07:38:15 +00:00
Kubernetes Prow Robot
901c1de5ea Merge pull request #114870 from mattcary/mutation
Avoid mutation of PVC in stateful set controller shared cache
2023-01-05 23:16:09 -08:00
Matthew Cary
ed18ab54ba Avoid mutation of PVC in stateful set controller shared cache
Change-Id: Ieb8e443e460150d16524ca1c1fb3770f546b2c28
2023-01-05 18:09:05 -08:00
Kubernetes Prow Robot
fcaa32bd99 Merge pull request #114725 from danwinship/kube-proxy-startup-cleanup
(minor) kube-proxy startup cleanup
2023-01-05 13:57:59 -08:00
Kubernetes Prow Robot
8dd70a16ad Merge pull request #114699 from kerthcet/feat/distinguish-unschedulabel-with-unresolvable
Distinguish between Unschedulable and UnschedulableAndUnresolvable in scheduler's PostFilter
2023-01-05 12:53:57 -08:00
Kubernetes Prow Robot
e119680318 Merge pull request #114784 from TommyStarK/pkg-apis/replace-deprecated-pointer-function
pkg/apis: Replace deprecated pointer function
2023-01-05 11:08:09 -08:00
Wei Huang
9b64025f36 rename 'PreemptionByKubeScheduler' to 'PreemptionByScheduler' 2023-01-05 10:31:57 -08:00
Wei Huang
91742e2393 Enhanced logic to identify eligible preemption node 2023-01-05 10:31:57 -08:00
Kubernetes Prow Robot
67622be450 Merge pull request #114653 from kerthcet/cleanup/remove-waitstop
Stop Cache in scheduler when tests tear down
2023-01-05 09:11:59 -08:00
Kubernetes Prow Robot
cf272cf2c6 Merge pull request #110931 from claudiubelu/adds-unittests-3
tests: Ports volume unit tests to Windows
2023-01-05 05:31:58 -08:00
Kubernetes Prow Robot
d9af380f91 Merge pull request #114749 from danwinship/drop-endpointshandler
Drop unused EndpointsHandler / EndpointsConfig from pkg/proxy/config
2023-01-05 03:58:09 -08:00
TommyStarK
f166a52573 pkg/apis: Replace deprecated pointer function
Signed-off-by: TommyStarK <thomasmilox@gmail.com>
2023-01-05 11:48:05 +01:00
Kante Yin
2c205e291d Distinguish unschedulable with unresolvable in scheduler
Before, in RunPostFilterPlugins, we didn't distinguish between unschedulable and unresolvable
because we only have one postFilterPlugin by default, now, we have at least two, we should
make sure that once a postFilterPlugin returns unresolvable, we'll return directly

Signed-off-by: Kante Yin <kerthcet@gmail.com>
2023-01-05 16:59:19 +08:00
Kubernetes Prow Robot
492637878f Merge pull request #111660 from pacoxu/key-encipherment-v1.26
Key encipherment usage  v1.27
2023-01-04 15:51:57 -08:00
Kubernetes Prow Robot
ac889a0251 Merge pull request #113581 from aimuz/verify-tls-secret
Verify that the key matches the cert
2023-01-04 14:29:58 -08:00
Kubernetes Prow Robot
c1ca3191d5 Merge pull request #114803 from TommyStarK/registry/replace-deprecated-pointer-function
pkg/registry: Replace deprecated pointer function
2023-01-04 04:48:00 -08:00
weizhi
575616cc72 fix: kubelet event about unattached volumes is incorrect (#112719)
* fix kubelet event

* add ut

* fix ut
2023-01-04 01:51:59 -08:00
TommyStarK
e2d8fc3f62 pkg/registry: Replace deprecated pointer function
Signed-off-by: TommyStarK <thomasmilox@gmail.com>
2023-01-04 10:38:09 +01:00
Kubernetes Prow Robot
3f752b5edf Merge pull request #114629 from kerthcet/feat/change-return-type-of-Filter
Modify the return type of RunFilterPlugins to *Status
2023-01-03 15:31:31 -08:00
Kubernetes Prow Robot
5914f30fd7 Merge pull request #114757 from danwinship/drop-endpointstracker
Drop unused Endpoints-tracking code from pkg/proxy/
2023-01-03 10:35:35 -08:00
Kubernetes Prow Robot
12c71fdf1c Merge pull request #113542 from ardaguclu/fix-shortname-disperancy
Set singular names for core types to pass to discovery
2023-01-03 09:29:43 -08:00
Kubernetes Prow Robot
b532f2b3e7 Merge pull request #112136 from pacoxu/migrate-runtime-endpoint-flags
kubelet: migrate container runtime endpoint flag to config
2023-01-03 09:29:31 -08:00
Michal Wozniak
c3d0e8ff05 Fix clearing rate limiter in disruption controller 2023-01-03 15:06:06 +01:00
Dan Winship
fe2b658ef5 Drop unused Endpoints-only tracking code in kube-proxy
This leaves the code in a somewhat messy state but it can be improved
further later.
2023-01-03 09:03:49 -05:00
Dan Winship
c78b057d85 Port TestUpdateEndpointsMap from Endpoints tracker to EndpointSlice
This is an ugly-but-simple rewrite (particularly involving having to
rewrite "single Endpoints with multiple Subsets" as "multiple
EndpointSlices"). Can be cleaned up more later...

The slice code sorts the results slightly differently from the old
code in two cases, and it was simpler to just reorder the expectations
rather than fixing the comparison code. But other than that, the
expected results are exactly the same as before.
2023-01-03 09:03:46 -05:00
Dan Winship
cc1847e6ee Port TestLastChangeTriggerTime from Endpoints tracker to EndpointSlice
This exposed a bug in the EndpointSlice tracking code, which is that
we didn't properly reset the "last change time" when a slice was
deleted. (This means kube-proxy would report an erroneous value in the
"endpoint programming time" metric if a service was added/updated,
then deleted before kube-proxy processed the add/update, then later
added again.)
2023-01-03 09:03:34 -05:00