I'm moving/deleting some tests to make an upcoming RESTClient refactor
PR cleaner.
- TestDoRequestBearer is redundant to
pkg/client/transport.TestBearerAuthRoundTripper
- Added a case to pkg/client/transport.TestBasicAuthRoundTripper to
cover what TestDoRequestWithoutPassword was testing
- Moved TestSetsCodec, TestRESTClientRequires,
TestValidateHostParameter to helper_test.go since they were really
testing helper functions and not the RESTClient directly.
- Modified TestValidateHostParameter during the moved to just use
DefaultServerURL instead of creating a client.
Create error, stdin, stdout, stderr streams first, and only start
copying once all the streams have been created. This fixes an issue
where the client immediately starts sending data for stdin before all
the other streams have been created. This ends up blocking the spdy
connection frame handler and causes the entire exec/attach session to
time out.
This commit adds support for using kubectl scale to scale deployments. Makes use of the
deployments/scale endpoint instead of updating deployment.spec.replicas directly.
TestPortForward was failing occasionally due to the way the test was
written. It created a port forwarding session, then connected a client
to the local port, attempted to send some data, attempted to receive
some data, and then tore down the port forwarding session.
Unfortunately, some times the attempt to send data from the client to
the remote would be enqueued but not processed by the time the test tore
down everything. As a result, the data stream could get closed before
the client's data was transmitted to the server. If this happened, you'd
see an error such as 'forward 2 ports with bidirectional data: server
expected to receive "ghij", got "" for port 6000'.
This fixes the test by serializing the data flow: the client writes to
the remote, the remote waits to receive that data, the remote writes to
the client, and the client waits to receive the data from the remote.
This all takes place prior to the test tearing down port forwarding.
1. Closing test servers that we open.
2. Remove dependency on Config and just call NewRESTClient directly
3. Remove auth tests as they are redundant to the tests in transport_test.go
