github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
116,782 Commits 1 Branch 31 Tags 1,019 MiB
45aa59946a
Commit Graph

6156 Commits

Author SHA1 Message Date
bzsuni
16fcb1c708 optimise some code 2022-12-13 09:56:36 +08:00
Kubernetes Prow Robot
741bd5c382
Merge pull request #113947 from mowangdk/chore/change_adcontroller_log_level 
Lower volume attached touch log level
 2022-12-12 17:41:51 -08:00
John Howard
d9f2cc0c95 endpoints: remove obsolete ServiceSelectorCache 
Since https://github.com/kubernetes/kubernetes/pull/112648, we can
efficiently handle selectors from pre-existing `map[string]string`,
making the cache obsolete.

Benchmark:

```
name                         old time/op    new time/op    delta
GetPodServiceMemberships-48     189µs ± 1%     193µs ± 1%  +2.10%  (p=0.000 n=10+10)

name                         old alloc/op   new alloc/op   delta
GetPodServiceMemberships-48    59.0kB ± 0%    58.9kB ± 0%  -0.09%  (p=0.000 n=9+9)

name                         old allocs/op  new allocs/op  delta
GetPodServiceMemberships-48     1.02k ± 0%     1.02k ± 0%    ~     (all equal)
```
 2022-12-12 08:00:48 -08:00
Kubernetes Prow Robot
2118bc8aec
Merge pull request #114155 from aojea/mirroring_repack 
endpointslicemirroring handle endpoints with multiple subsets
 2022-12-10 07:53:42 -08:00
Kubernetes Prow Robot
9303ea836f
Merge pull request #114076 from akhilles/remove-unused-var 
Remove unused `numExistingEndpoints` variable
 2022-12-10 06:04:25 -08:00
Kubernetes Prow Robot
92ffe94592
Merge pull request #114033 from Octopusjust/k8s-pr14 
pkg/controller/deployment/util/deployment_util.go:Improving test cove…
 2022-12-10 06:03:55 -08:00
Antonio Ojea
ef6d9edea5 endpointslicemirroring handle endpoints with multiple subsets 
Endpoints generated by the endpoints controller are in the canonical
form, however, custom endpoints can not be in canonical format
(there was a time they were canonicalized in the apiserver, but this
caused performance issues because the endpoint controller kept
updating them since the created endpoint were different than the
stored one due to the canonicalization)

There are cases where a custom endpoint may generate multiple slices
due to the controller, per example, when the same address is present
in different subsets.

The endpointslice mirroring controller should canonicalize the
endpoints subsets before start processing them to be consistent
on the slices generated, there is no risk of hotlooping because
the endpoint is only used as input.

Change-Id: I2a8cd53c658a640aea559a88ce33e857fa98cc5c
 2022-12-10 11:44:10 +00:00
Kubernetes Prow Robot
0cd13e573c
Merge pull request #113196 from mimowo/job-controller-reviewer 
Self-nominate mimowo as a reviewer for pkg/controller/job & test/integration/job packages
 2022-12-10 02:01:39 -08:00
Gunju Kim
69fcde750a
Update daemonSet status even if syncDaemonSet fails 
This ensures that the daemonset controller updates daemonset statuses in
a best-effort manner even if syncDaemonSet fails.

In order to add an integration test, this also replaces
`cmd/kube-apiserver/app/testing.StartTestServer` with
`test/integration/framework.StartTestServer` and adds
`setupWithServerSetup` to configure the admission control of the
apiserver.
 2022-12-10 11:45:56 +09:00
Kubernetes Prow Robot
63a01a5465
Merge pull request #112260 from aryan9600/cidr-metrics 
Add metric for max no. of CIDRs available
 2022-12-09 15:42:59 -08:00
Kubernetes Prow Robot
da3d98277b
Merge pull request #111839 from ialidzhikov/cleanup/pkg-controller 
pkg/controller: Replace deprecated func usage from the `k8s.io/utils/pointer` pkg
 2022-12-09 15:42:37 -08:00
Kubernetes Prow Robot
4557c694ef
Merge pull request #111683 from lucming/code-cleanup5 
reorganize some logic of controller_utils.go
 2022-12-09 15:42:21 -08:00
Kubernetes Prow Robot
5fe12aae11
Merge pull request #111207 from lucming/code-cleanup2 
Reduce indentation in daemonset controller code
 2022-12-09 15:41:41 -08:00
Mengjiao Liu
c28b287253 clusterroleaggregation: use contextual logging 2022-12-09 11:02:47 +08:00
Sanskar Jaiswal
b501d6036a add metric for max no. of CIDRs that can be allocated from MultiCIDRSet 
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
 2022-12-05 15:18:45 +00:00
Sanskar Jaiswal
37f4d4624b add metric for max no. of CIDRs that can be allocated from CidrSet 
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
 2022-12-05 15:18:45 +00:00
ialidzhikov
aede3fbf40 pkg/controller: Replace deprecated func usage from the k8s.io/utils/pointer pkg 2022-11-23 17:40:23 +02:00
songxiao-wang87
9ae5af4b6a StorageVersionGC logger 
Signed-off-by: songxiao-wang87 <wang.xiaosong23@zte.com.cn>
 2022-11-23 03:20:12 +00:00
Akhil Velagapudi
70d31ea917 Remove unused numExistingEndpoints variable 2022-11-23 00:54:50 +00:00
ZhangYu
d61849e800 pkg/controller/deployment/util/deployment_util.go:Improving test coverage 2022-11-22 10:12:58 +08:00
mowangdk
bf244d3046 Lower volume attached touch log level 2022-11-16 16:49:07 +08:00
Michelle Au
524a8b32a6 add sig-storage reviewers, remove inactive sig-storage reviewers, remove redundant owners files 2022-11-15 23:51:57 +00:00
Aldo Culquicondor
7dc36bdf82
Wait for Pods to finish before considering Failed in Job (#113860) 
* Wait for Pods to finish before considering Failed

Limit behavior to feature gates PodDisruptionConditions and
JobPodFailurePolicy and jobs with a podFailurePolicy.

Change-Id: I926391cc2521b389c8e52962afb0d4a6a845ab8f

* Remove check for unsheduled terminating pod

Change-Id: I3dc05bb4ea3738604f01bf8cb5fc8cc0f6ea54ec
 2022-11-15 09:44:53 -08:00
Kubernetes Prow Robot
84a55ad8d2
Merge pull request #113147 from andrewsykim/storageversiongc-controller-tests 
add unit tests for storageversiongc controller
 2022-11-14 10:56:41 -08:00
Michal Wozniak
a910ca563b Fix race conditions 2022-11-14 10:11:26 +01:00
Michal Wozniak
3b5c3acd61 Improve stability if the taint_manager tests 2022-11-13 19:40:18 +01:00
Kubernetes Prow Robot
d1c0171aed
Merge pull request #111023 from pohly/dynamic-resource-allocation 
dynamic resource allocation
 2022-11-11 16:21:56 -08:00
Aldo Culquicondor
bc5afaf580
Fix match onExitCodes when Pod is not terminated 
Change-Id: Id1f9c46f8b6a12115577a1fadb12adc580c9ba6a
 2022-11-11 10:05:11 -05:00
Kubernetes Prow Robot
d7bff1c809
Merge pull request #111577 from brianpursley/troubleshoot-unit-test-flake 
Add logging for reconciler unit test
 2022-11-11 00:44:09 -08:00
Filip Křepinský
ec0b200f3d statefulset: handle API error on pod deletion 
when new revision is being rolled out
 2022-11-10 22:47:23 +01:00
Patrick Ohly
0133df3929 kube-controller-manager: add ResourceClaim controller 
The controller uses the exact same logic as the generic ephemeral inline volume
controller, just for inline ResourceClaimTemplate -> ResourceClaim.

In addition, it supports removal of pods from the ReservedFor field when those
pods are known to not need the claim anymore. At the moment, only this special
case is supported. Removal of arbitrary objects would imply granting full read
access to all types to determine whether a) an object is gone and b) if the
current incarnation is the one which is listed in ReservedFor. This may get
added later.
 2022-11-10 20:23:50 +01:00
Patrick Ohly
b87530af4f kube-controller-manager: clone resource controller from volume/ephemeral 2022-11-10 20:23:50 +01:00
Paco Xu 徐俊杰
fd4adba9ac
add sig/storage label for pkg/controller/volume package PR 2022-11-10 09:57:36 +08:00
Paco Xu
2557b35202 controller: add non-exist node test case 2022-11-10 09:43:53 +08:00
Andrew Sy Kim
dba7740115 pkg/controller/storageversiongc: add constructor function newKubeApiserverLease 
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
 2022-11-09 15:52:47 -05:00
Kubernetes Prow Robot
ff19efdf9b
Merge pull request #112744 from pwschuurman/statefulset-slice-impl 
Add implementation of KEP-3335, StatefulSetSlice
 2022-11-09 11:12:28 -08:00
wangxiaojian
02db35ab1c
Optimize case conditions 2022-11-10 00:49:20 +08:00
Andrew Sy Kim
1320adc83f pkg/controller/storageversiongc: add comments for Test_StorageVersionUpdatedWithAllEncodingVersionsEqualOnLeaseDeletion, Test_StorageVersionUpdatedWithDifferentEncodingVersionsOnLeaseDeletion, Test_StorageVersionContainsInvalidLeaseID, and Test_StorageVersionDeletedOnLeaseDeletion 
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
 2022-11-09 11:49:07 -05:00
Andrew Sy Kim
2fb8329eee pkg/controller/storageversiongc: add unit tests for storageversiongc controller 
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
 2022-11-09 11:48:20 -05:00
Michal Wozniak
c803892bd8 Enable the feature into beta 2022-11-09 09:02:40 +01:00
Kubernetes Prow Robot
694698ca38
Merge pull request #110485 from Octopusjust/k8s-pr 
cidr_set.go :  fix several typo
 2022-11-08 13:51:00 -08:00
Peter Schuurman
9258cb4041 Fix typo in function emptyInvariants() 2022-11-08 07:48:10 -08:00
Peter Schuurman
366997951b Update doc comments and change name of feature gate 2022-11-08 07:48:10 -08:00
Peter Schuurman
8a9c126eca Small updates and comment fixes 2022-11-08 07:48:09 -08:00
Peter Schuurman
7b3d77a41a Adding implementation of KEP-3335, StatefulSetSlice 2022-11-08 07:48:00 -08:00
Maciej Szulik
3c93d540c6
Revert "Update daemonSet status even if syncDaemonSet fails" 
This reverts commit 2ee024a4df.
 2022-11-08 15:01:09 +01:00
Kubernetes Prow Robot
aef9a37df9
Merge pull request #113010 from soltysh/promote_job_metrics 
Promote job metrics
 2022-11-08 03:16:32 -08:00
Kubernetes Prow Robot
3451501c2e
Merge pull request #112737 from gjkim42/cleanup-defer-from-sts 
StatefulSet: Cleanup the complex defer function updating the status
 2022-11-08 03:16:21 -08:00
Kubernetes Prow Robot
0e530f44af
Merge pull request #113544 from LiorLieberman/topology-hints-events 
Added: publishing events for topologyAwareHints changes
 2022-11-07 16:01:15 -08:00
Kubernetes Prow Robot
47952e0917
Merge pull request #112360 from mimowo/handling-pod-failures-beta-kubelet 
Add pod disruption conditions for kubelet-initiated failures
 2022-11-07 16:00:40 -08:00
Kubernetes Prow Robot
b4f42864f5
Merge pull request #112127 from gjkim42/update-status-despite-error 
Update daemonSet status even if syncDaemonSet fails
 2022-11-07 16:00:28 -08:00
Gunju Kim
6559050ee1
StatefulSet: Cleanup the complex defer function updating the status 
In the long term, the complex defer function makes the code harder to
maintain as code after it should take that into account. This removes
the complex defer function updating the status of a statefulset.
 2022-11-08 08:39:42 +09:00
Kubernetes Prow Robot
1c230d519e
Merge pull request #113262 from jsafrane/rework-reconstruction 
Rework volume reconstruction
 2022-11-07 12:42:29 -08:00
Lior Lieberman
4faede03fa Added events publishing for topologyHints changes 2022-11-07 19:45:40 +00:00
Maciej Szulik
39d9981dc2
Promote job-related metrics to stable 2022-11-07 19:28:40 +01:00
Kubernetes Prow Robot
ac95e5b701
Merge pull request #113510 from alculquicondor/finalizers-stable 
Graduate JobTrackingWithFinalizers to stable
 2022-11-07 08:06:41 -08:00
Michal Wozniak
52cd6755eb Add pod disruption conditions for kubelet initiated failures 2022-11-07 11:23:22 +01:00
Kubernetes Prow Robot
c519bc02e8
Merge pull request #112011 from pbeschetnov/ambiguous-selectors 
Add ambiguous selector check to HPA
 2022-11-06 21:08:16 -08:00
Aldo Culquicondor
4948918155
Graduate JobTrackingWithFinalizers to stable 
Change-Id: Ifc749a85b1270c0155ac511b91d4681d53236820
 2022-11-04 17:05:53 -04:00
Kubernetes Prow Robot
b20ddbd75a
Merge pull request #113351 from andrewsykim/endpointslice-terminating-ga 
Promote EndpointSliceTerminatingCondition to GA
 2022-11-04 09:36:39 -07:00
Kubernetes Prow Robot
ead17f3dc8
Merge pull request #113008 from soltysh/promote_cronjob_metrics 
Promote cronjob_job_creation_skew metric to stable
 2022-11-04 09:36:27 -07:00
Kubernetes Prow Robot
20ffe3bbf9
Merge pull request #111607 from tnqn/reduce-redundant-index 
Remove duplicate and unused index from PodIndexer
 2022-11-04 09:36:16 -07:00
Maciej Szulik
4af97e599a
Promote cronjob_job_creation_skew metric to stable 2022-11-04 13:55:32 +01:00
Pavel Beschetnov
caddfdd040 Add pod ambiguous selector check 2022-11-04 12:49:20 +00:00
Wojciech Tyczyński
e0002c7e26 Clean shutdown of nodeipam controller 2022-11-04 10:34:36 +01:00
Andrew Sy Kim
e282b6c6b3 pkg/controller/endpointslice: remove all references to the EndpointSliceTerminatingCondition feature gate 
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
 2022-11-03 20:26:51 -04:00
Kubernetes Prow Robot
d802bd56ac
Merge pull request #113559 from wojtek-t/clean_shutdown_5 
Clean shutdown of few more integration tests
 2022-11-03 09:01:45 -07:00
Kubernetes Prow Robot
38bcc0c153
Merge pull request #113519 from xing-yang/node_shutdown_metrics 
Add metric deleting_pods_total
 2022-11-03 09:01:37 -07:00
Jan Safranek
fc245b339b Refactor ConstructVolumeSpec 
Return a struct from ConstructVolumeSpec to be able to add more fields to
it later.
 2022-11-03 16:55:13 +01:00
Kubernetes Prow Robot
98742f9d77
Merge pull request #110747 from harshanarayana/cleanup/GIT-110737/logging-improvements 
structured-logging: replace KObjs with KObjSlice for logging
 2022-11-03 00:49:34 -07:00
Kubernetes Prow Robot
4b2aa18bde
Merge pull request #113478 from alculquicondor/finalizer_metric 
Add benchmark for large indexed job
 2022-11-02 16:29:13 -07:00
xing-yang
85f5583684 Address review comments 2022-11-02 22:40:02 +00:00
Wojciech Tyczyński
c84c27b6ac Clean shutdown of event broadcaster in controllers 2022-11-02 21:08:43 +01:00
xing-yang
b4e6bed525 Moved Register() to init() 2022-11-02 19:54:38 +00:00
Aldo Culquicondor
5e03865f65
Add benchmark for large indexed job 
Change-Id: I556f0cce5842699c98654cfb5a66e7c8d63b2e2e
 2022-11-02 11:56:26 -04:00
xing-yang
8ce37fde95 Add metric deleting_pods_total 2022-11-02 11:01:47 +00:00
Kubernetes Prow Robot
114a54c098
Merge pull request #113450 from neogopher/pv-controller-fix-log-message 
docs: Correct the log message for pv controller to make it more accurately descriptive
 2022-11-01 19:59:19 -07:00
Kubernetes Prow Robot
9b5fa57654
Merge pull request #113358 from mengjiao-liu/fix-StatefulSetAutoDeletePVC 
StatefulSet: fix kube-controller-manager panic due to StatefulSetPersistentVolumeClaimRetentionPolicy being nil
 2022-11-01 08:24:45 -07:00
Michał Woźniak
3628532311
Extend metrics with the new labels (#113324) 
* Extend job metrics

* Refactor TestMetrics to extract its checks into dedicated tests per feature
 2022-10-31 08:50:45 -07:00
neogopher
400c8f71cf docs: Correct the log message for pv controller to make it more accurately descriptive 2022-10-30 23:17:55 +05:30
Kubernetes Prow Robot
3c9928e4f8
Merge pull request #113304 from mimowo/handling-pod-failures-beta-ssa 
Use SSA to add pod failure conditions
 2022-10-28 07:32:32 -07:00
Kubernetes Prow Robot
f9f9f0107d
Merge pull request #112544 from abhijit-dev82/master 
HPA : Enhance error message to capture POD details
 2022-10-28 04:14:30 -07:00
Michal Wozniak
fea883687f SSA to add pod failure conditions - ready for review 2022-10-27 18:21:33 +02:00
Mengjiao Liu
b9740694f3 StatefulSet: fix kube-controller-manager panic due to StatefulSetPersistentVolumeClaimRetentionPolicy being nil 2022-10-27 23:13:36 +08:00
Roman Bednar
42422a1d16 add a metric for retroactive sc errors 2022-10-25 15:09:16 +02:00
Kubernetes Prow Robot
245d59273c
Merge pull request #113136 from jprzychodzen/kcm-remove-race-condition 
NodeLifecycleController: Remove race condition
 2022-10-24 15:48:34 -07:00
Jakub Przychodzeń
de25c5fdcf NodeLifecycleController: Remove race condition 
Patch request does not support RV by default, we need to include them explicitly and patching lists actually overwrites whole field. It means that there is a race condition, in which we can overwrite changes to taints that happened between GET and PATCH requests.
 2022-10-24 19:36:58 +00:00
Aldo Culquicondor
12d308f5c4 Add metric for terminated pods with tracking finalizer 
Change-Id: I26f3169588c30ed82250cb7baff8e277f8d13bb7
 2022-10-20 11:35:20 -04:00
Michal Wozniak
b1e575aaf7 Self-nominate mimowo as a reviewer for pkg/controller/job & test/integration/job 
I think I'm ready to start review and LGTM code changes within this
package, but not necessarily for the entire sig-apps.

My PRs to the packages:
https://github.com/kubernetes/kubernetes/pull/110292
https://github.com/kubernetes/kubernetes/pull/111113
https://github.com/kubernetes/kubernetes/pull/112948

PRs to the packages I contributed reviews to:
https://github.com/kubernetes/kubernetes/pull/113166
https://github.com/kubernetes/kubernetes/pull/110294
 2022-10-20 09:22:35 +02:00
Kubernetes Prow Robot
962235c86a
Merge pull request #110559 from danishprakash/danish-default-storageclass 
pkg/admission/storageclass: pick one storageclass conditionally if >1 present
 2022-10-19 13:56:55 -07:00
Kubernetes Prow Robot
bf14677914
Merge pull request #112546 from oscr/the-the 
grammar: replace all occurrences of "the the" with "the"
 2022-10-19 10:03:02 -07:00
danishprakash
f10f4d372c
pv_controller: update tests for multiple storageclasses 
Signed-off-by: danishprakash <grafitykoncept@gmail.com>
 2022-10-19 09:33:44 +05:30
Kubernetes Prow Robot
23721935d3
Merge pull request #113129 from chaunceyjiang/pr_remove_redundant_conversion 
Remove redundant type conversion
 2022-10-18 10:23:19 -07:00
Kubernetes Prow Robot
deb6712358
Merge pull request #113137 from RomanBednar/restart-sync-unbound 
restart claim sync when PVC is updated
 2022-10-18 07:33:19 -07:00
chaunceyjiang
d2b372e029 Remove redundant type conversion 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
 2022-10-18 14:37:40 +08:00
Kubernetes Prow Robot
85643c0f93
Merge pull request #108501 from zroubalik/hpa 
add `--concurrent-horizontal-pod-autoscaler-syncs` flag to kube-controller-manager
 2022-10-17 14:13:18 -07:00
Kubernetes Prow Robot
28ced69b76
Merge pull request #113054 from logicalhan/proxy-metric 
remove rate limiter metric as it is not in use
 2022-10-17 11:09:18 -07:00
Zbynek Roubalik
1cefcdea2d add --concurrent-horizontal-pod-autoscaler-syncs flag to kube-controller-manager 
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
 2022-10-17 17:39:31 +02:00
Roman Bednar
f5693a4008 restart claim sync when PVC is updated 
We should not rely on syncUnboundClaim() to do nothing after it updates
PVC with a default storage class until next re-sync but instead restart
the sync explicitly to make sure we hit isDelayBindingMode() and
findBestMatchForClaim() immediately right after the PVC update.
 2022-10-17 14:05:39 +02:00
Abhijit
ac56e6f34e HPA : Enhance error message to capture POD details 
HPA : Enhance error message to capture POD details
 2022-10-17 14:21:28 +05:30
Kubernetes Prow Robot
5e775e3c83
Merge pull request #112558 from aojea/ipam_owners 
update sig-network reviewers/approvers on controller manager
 2022-10-14 10:54:46 -07:00
Kubernetes Prow Robot
5c36a3c372
Merge pull request #110902 from 0xff-dev/master 
convert int32 to pointer using library function
 2022-10-14 08:48:46 -07:00
Oscar Utbult
e4f776f230 grammar: replace all occurrences of "the the" with "the" 2022-10-14 09:03:14 +02:00
Han Kang
2bbd445f50 remove rate limiter metric as it is not in use 
Change-Id: I91157653e3860eeecc3f572aee88da6ffc65faed
 2022-10-13 13:07:11 -07:00
Michal Wozniak
b64e5b2d15 Fix the occasional double-counting job_finished_total metric 
The reason for the issue is that the metrics were bumped before the
final job status update. In case the update failed the path was
repeated by the next syncJob leading to double-counting of the metrics.

The solution is to delay recording metrics and broadcasting events
after the job status update succeeds.
 2022-10-13 17:23:03 +02:00
Gunju Kim
2ee024a4df
Update daemonSet status even if syncDaemonSet fails 2022-10-11 22:55:50 +09:00
Kubernetes Prow Robot
afebf498d7
Merge pull request #111314 from BinacsLee/binacs/cleanup-use-clone-to-avoid-interim-slice 
cleanup: use sets.Clone() to avoid interim slice
 2022-10-04 07:34:22 -07:00
Kubernetes Prow Robot
4245895261
Merge pull request #111463 from pbetkier/hpa-comment-fix 
Fix comment in HPA's scale event replicaChange
 2022-09-30 04:08:28 -07:00
Wojciech Tyczyński
57c95fbfa1 Lock ServerSideApply feature to true 2022-09-27 13:48:28 +02:00
Kubernetes Prow Robot
ed8c302cc6
Merge pull request #112692 from liggitt/dot-cleanup 
Drop DOT dependency
 2022-09-23 13:02:06 -07:00
Jordan Liggitt
8221960b65
Reimplement GC dot graph dumping without gonum library 2022-09-23 13:12:33 -04:00
Michal Wozniak
bb561e0324 Fix controller policy and improve logging of related errors 
Improve error logging from timed workers which are used for pod eviction

Co-authored-by: Aldo Culquicondor <1299064+alculquicondor@users.noreply.github.com>
 2022-09-23 16:53:32 +02:00
Kubernetes Prow Robot
3a0dbe5749
Merge pull request #112335 from piotrnosek/fixcustomcrd 
Fix HPA E2E CustomResourceDefinition test
 2022-09-22 11:01:06 -07:00
Kubernetes Prow Robot
2dba4034f8
Merge pull request #112554 from kushagra98/variable-name-change 
variable name change for better understanding
 2022-09-22 03:37:02 -07:00
Kushagra
dc321b4d2a requeted changes: fix variables in test cases 2022-09-22 09:17:15 +00:00
Kushagra
01b553145c requested changes: fix return type variables 2022-09-22 08:59:02 +00:00
Piotr Nosek
96ff1b1bcb Fix HPA E2E CRD test 2022-09-21 22:39:47 +00:00
Aldo Culquicondor
524daa0a7d Fix flaky TestStalePodDisruption 
Change-Id: I3394caa54593b7e0206a2872cbdaafddd2fc47f8
 2022-09-20 15:17:07 -04:00
Kubernetes Prow Robot
60e2f6c519
Merge pull request #112509 from humblec/new-1 
various corrections in pkg/volume
 2022-09-19 09:09:18 -07:00
Kubernetes Prow Robot
f6f44bff90
Merge pull request #111708 from yangjunmyfm192085/fixloginfi 
use klog.InfoS instead of klog.V(0).InfoS
 2022-09-19 07:53:18 -07:00
Antonio Ojea
5598735370 update sig-network reviewers/approvers on controller manager 2022-09-19 10:34:39 +02:00
Kushagra
cbea8d2248 requested changes 2022-09-19 08:15:06 +00:00
Kushagra
79f5c7da33 varibale name change for better understanding 2022-09-19 05:05:01 +00:00
Antonio Ojea
c3259df151 fix endpoint slice controller logging format error 
Co-authored-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
 2022-09-16 16:47:51 +02:00
Humble Chirammal
4bafd53a02 Correct typos in pkg/controller/volume 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2022-09-16 16:50:20 +05:30
Kubernetes Prow Robot
03d688c4b8
Merge pull request #112178 from kushagra98/hpa-scale-down 
FIX: HPAs scale down with target >= 100
 2022-09-14 11:09:13 -07:00
Kubernetes Prow Robot
c7d47e4c94
Merge pull request #112353 from dgrisonnet/update-max-sync-backoff 
Update endpointslice controller maximum sync backoff delay to match expected sequence of delays
 2022-09-14 08:55:00 -07:00
Damien Grisonnet
0f0526cd6a endpointslice: update max sync backoff 
Update the maximum sync backoff value to 1000s to match the sequence of
delays expected by the endpointslice controller when syncing Services:

Before this change the sequence was:

> 1s, 2s, 4s, 8s, 16s, 32s, 64s, 100s

Now it is:

> 1s, 2s, 4s, 8s, 16s, 32s, 64s, 128s, 256s, 512s, 1000s

Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
 2022-09-09 16:27:16 +02:00
Kubernetes Prow Robot
2969000db3
Merge pull request #111122 from alexzielenski/informer 
support removal of event handlers from SharedIndexInformers
 2022-09-07 11:58:37 -07:00
Kushagra
de8245e952 added ut for the change 2022-09-05 14:56:24 +00:00
Kushagra
b75fbda0ed requested changes 2022-09-05 04:54:59 +00:00
Kushagra
bb735bf689 revert for non-utilization metrics 2022-09-05 04:54:59 +00:00
Kushagra
6bb73bae06 FIX: hpa scale down with target >= 100 2022-09-05 04:54:59 +00:00
Kubernetes Prow Robot
5ade6c833f
Merge pull request #110695 from lokichoggio/hpa 
code optimization: deal with error first to prevent unnecessary computing
 2022-09-01 17:52:04 -07:00
Kubernetes Prow Robot
4cb7524e5a
Merge pull request #110492 from j2gg0s/opt-var-name-in-hpa 
hpa: rename rebalanceIgnored to scaleUpWithUnready for understanding
 2022-08-30 23:43:00 -07:00
Kubernetes Prow Robot
239a19ecc1
Merge pull request #111170 from ping035627/k8s-220715 
HandleError of updateStatusIfNeeded in func reconcileAutoscaler
 2022-08-30 10:59:06 -07:00
Kubernetes Prow Robot
da6d8c997e
Merge pull request #109058 from oliviermichaelis/calculate-start-replicas 
Fix replica calculation at start of HPA scaling policy period
 2022-08-30 10:58:55 -07:00
Aldo Culquicondor
848eece7b7 Add alculquicondor to job OWNERS 
Change-Id: If974f0890ef4accbd7d2111fb1a1aa38718dc74b
 2022-08-26 11:29:37 -04:00
j2gg0s
755098cc31 hpa: rename rebalanceIgnored to scaleUpWithUnready for understanding 2022-08-26 15:36:11 +08:00
JunYang
2db4dea565 use klog.InfoS instead of klog.V(0).InfoS 2022-08-25 18:46:34 +08:00
cndoit18
ec43037d0f style: remove redundant judgment 
Signed-off-by: cndoit18 <cndoit18@outlook.com>
 2022-08-25 12:07:36 +08:00
Kubernetes Prow Robot
9c88c73de0
Merge pull request #109185 from kerthcet/fix/goroutine-leak-in-nodelifecycle-test 
resolve goroutine leak in nodelifecycle tests
 2022-08-23 21:19:48 -07:00
Kubernetes Prow Robot
69136c0c81
Merge pull request #111894 from wongma7/pvcnpd 
Fix PVC nil pointer dereference during migration-enabled volume expand
 2022-08-23 20:08:37 -07:00
Kubernetes Prow Robot
9451747366
Merge pull request #111690 from piroux/pv-controller-tests-structs-with-names 
Pv controller tests structs with names
 2022-08-23 17:17:26 -07:00
Kubernetes Prow Robot
3ac0e24940
Merge pull request #111205 from 249043822/br-volumeattach 
Fix problem in updating VolumeAttached in node status
 2022-08-23 16:05:09 -07:00
Matthew Wong
a322a708f3 Fix PVC nil pointer dereference during migration-enabled volume expand 2022-08-17 11:32:22 -07:00
Omer Tuchfeld
eb317ecd40 Fix capture loop vars in parallel or ginkgo tests 
Fixes instances of #98213 (to ultimately complete #98213 linting is
required).

This commit fixes a few instances of a common mistake done when writing
parallel subtests or Ginkgo tests (basically any test in which the test
closure is dynamically created in a loop and the loop doesn't wait for
the test closure to complete).

I'm developing a very specific linter that detects this king of mistake
and these are the only violations of it it found in this repo (it's not
airtight so there may be more).

In the case of Ginkgo tests, without this fix, only the last entry in
the loop iteratee is actually tested. In the case of Parallel tests I
think it's the same problem but maybe a bit different, iiuc it depends
on the execution speed.

Waiting for the CI to confirm the tests are still passing, even after
this fix - since it's likely it's the first time those test cases are
executed - they may be buggy or testing code that is buggy.

Another instance of this is in `test/e2e/storage/csi_mock_volume.go` and
is still failing so it has been left out of this commit and will be
addressed in a separate one
 2022-08-15 16:28:50 +02:00
Alexander Zielenski
063ef090e7
switch listeners to use a map, adapt tests 2022-08-08 14:01:10 -07:00
Uwe Krueger
92f04baac9
apply desired changes for handler registration 2022-08-08 14:01:09 -07:00
Uwe Krueger
7054ac16d4
rename handle to registration 2022-08-08 14:01:09 -07:00
Alexander Zielenski
7436af3302
support removal of event handlers from SharedIndexInformers 
To be able to implement controllers that are dynamically deciding
on which resources to watch, it is required to get rid of
dedicated watches and event handlers again. This requires the
possibility to remove event handlers from SharedIndexInformers again.
Stopping an informer is not sufficient, because there might
be multiple controllers in a controller manager that independently
decide which resources to watch.

Unfortunately the ResourceEventHandler interface encourages to use
value objects for handlers (like the ResourceEventHandlerFuncs
struct, that uses value receivers to implement the interface).
Go does not support comparison of function pointers and therefore
the comparison of such structs is not possible, also. To be able
to remove all kinds of handlers and to solve the problem of
multi-registrations of handlers a registration handle is introduced.
It is returned when adding a handler and can later be used to remove
the registration again. This handle directly stores the created
listener to simplify the deletion.
 2022-08-08 14:01:09 -07:00
Kubernetes Prow Robot
759785ea14
Merge pull request #109090 from sarveshr7/multicidr-rangeallocator 
Enhance NodeIPAM to support multiple ClusterCIDRs
 2022-08-07 15:40:18 -07:00
Sarvesh Rangnekar
5b801ba9f9 Introduce MultiCIDRRangeAllocator 
MultiCIDRRangeAllocator is a new Range Allocator which makes using
multiple ClusterCIDRs possible. It consists of two controllers, one for
reconciling the ClusterCIDR API objects and the other for allocating
Pod CIDRs to the nodes.

The allocation is based on the rules defined in
https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/2593-multiple-cluster-cidrs
 2022-08-06 00:10:39 +00:00
Aldo Culquicondor
c1e0dac461 Fix deleting UIDs tracking expectations 
Change-Id: I5dad644cf5cb232ebed0950a14b35a781a38eeb0
 2022-08-05 12:37:31 -04:00
Sarvesh Rangnekar
02d944d046 Add a priority queue to implement MultiCIDR tie-breaks 
The Priority is determined as follows:
P0: ClusterCIDR with higher number of matching labels has highest
priority.
P1: ClusterCIDR having cidrSet with fewer allocatable Pod CIDRs has
higher priority.
P2: ClusterCIDR with a PerNodeMaskSize having fewer IPs has higher
priority.
P3: ClusterCIDR having label with lower alphanumeric value has higher
priority.
P4: ClusterCIDR with a cidrSet having a smaller IP address value has
higher priority.
 2022-08-05 01:06:43 +00:00
Sarvesh Rangnekar
b6392a4b07 Add cidrset to support multiple CIDRs 
Add a new cidrset named `multicidrset` which extends the current
cidrset mechanism to track allocatable Pod and Service CIDRs.
multicidrset stores the info about allocated CIDRs in a Map as opposed
to the current cidrset implementation where it is stored in a bitmap.
 2022-08-05 01:06:43 +00:00
Kubernetes Prow Robot
eefcf6aa80
Merge pull request #111113 from mimowo/retriable-pod-failures-job-controller 
Support handling of pod failures with respect to the configured rules
 2022-08-04 13:35:46 -07:00
Michal Wozniak
bf9ce70de3 Support handling of pod failures with respect to the specified rules 2022-08-04 18:39:08 +02:00
piroux
34b54e7646 Add struct keys in PV controller tests 
Signed-off-by: piroux <pierre.roux01@gmail.com>
 2022-08-04 17:01:36 +02:00
Jan Safranek
cdb3ead5a9 Add SupportsSELinuxContextMount 
Add a new call to VolumePlugin interface and change all its
implementations.

Kubelet's VolumeManager will be interested whether a volume supports
mounting with -o conext=XYZ or not to hanle SetUp() / MountDevice()
accordingly.
 2022-08-04 10:51:28 +02:00
lucming
a6f75d8ded code cleanup 2022-08-04 11:16:52 +08:00
Kubernetes Prow Robot
4b6134b6dc
Merge pull request #111090 from kinvolk/rata/userns-support-2022 
Add support for user namespaces phase 1 (KEP 127)
 2022-08-03 13:05:47 -07:00
Rodrigo Campos
d07c2688fe kubelet: add GetHostIDsForPod() 
In future commits we will need this to set the user/group of supported
volumes of KEP 127 - Phase 1.

Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
 2022-08-03 19:53:22 +02:00
kerthcet
b4277e7ce4 Fix potential goroutine leakages in taint manager tests 
Signed-off-by: kerthcet <kerthcet@gmail.com>
 2022-08-04 00:00:48 +08:00
Kubernetes Prow Robot
cb41d5002c
Merge pull request #111061 from pacoxu/key-encipherment-optional 
modify the signing/approving controller to tolerate either set of usages for kubelet client and serving certificates
 2022-08-02 18:55:51 -07:00
Kubernetes Prow Robot
182e0989ec
Merge pull request #111646 from alculquicondor/fix_failed_suceeded 
Fix JobTrackingWithFinalizers when a pod succeeds after the job fails
 2022-08-02 17:45:52 -07:00
Aldo Culquicondor
ca8cebe5ba Fix JobTrackingWithFinalizers when a pod succeeds after the job fails 
Change-Id: I3be351fb3b53216948a37b1d58224f8fbbf22b47
 2022-08-02 19:33:06 -04:00
Kubernetes Prow Robot
90f9a52db6
Merge pull request #111467 from RomanBednar/retro-sc-assignment 
Allow retroactive storage class assigment to PVCs
 2022-08-02 15:05:57 -07:00
Paco Xu
e6176c28b7 modify the signing/approving controller to tolerate either set of usages for kubelet client and serving certificates 
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
 2022-08-03 05:12:04 +08:00
Kubernetes Prow Robot
369a465fae
Merge pull request #111301 from mattcary/migration-feature 
Upgrade CSIMigrationGCE feature gate to GA
 2022-08-02 13:58:57 -07:00
Roman Bednar
2f533cd572 add tests for pv controller 2022-08-02 20:52:04 +02:00
Roman Bednar
a0a5aa3680 allow retroactive storage class assignment in pv controller 2022-08-02 20:52:04 +02:00
Matthew Cary
e5d387c5d6 Upgrade CSIMigrationGCE feature gate to GA 
Change-Id: I620bc4913765c0d6562eb1008216a72e8b0a2970
 2022-08-02 09:14:27 -07:00
Aldo Culquicondor
4188d9b646 Add worker to clean up stale DisruptionTarget condition 
Change-Id: I907fbdf01e7ff08d823fb23aa168ff271d8ff1ee
 2022-08-02 11:25:01 -04:00
Aldo Culquicondor
dad8454ebb Add clock interface to disruption controller 
To be able to write more precise unit tests in the future

Change-Id: I8f45947dfacca501acd856849bd978fad0f735cd
 2022-08-02 11:17:29 -04:00
ZhangKe10140699
186ddce07b Fix problem in updating VolumeAttached in node status 2022-08-02 19:01:57 +08:00
Michal Wozniak
04fcbd721c Introduction of a pod condition type indicating disruption. Its reason field indicates the reason: 
- PreemptionByKubeScheduler (Pod preempted by kube-scheduler)
- DeletionByTaintManager (Pod deleted by taint manager due to NoExecute taint)
- EvictionByEvictionAPI (Pod evicted by Eviction API)
- DeletionByPodGC (an orphaned Pod deleted by PodGC)PreemptedByScheduler (Pod preempted by kube-scheduler)
 2022-08-02 11:12:16 +02:00
Quan Tian
f40067a8cc Remove duplicate and unused index from PodIndexer 
DaemonSetsController adds a "nodeName" index to PodIndexer, which is
redundant with the "spec.nodeName" index of NodeLifecycleController.
However, DaemonSetsController hasn't been using this index since #86730.
This patch removes the redundant and unused index to reduce memory and
CPU spent on it.

Signed-off-by: Quan Tian <qtian@vmware.com>
 2022-08-02 10:53:54 +08:00
Kubernetes Prow Robot
1e18ff5b37
Merge pull request #111479 from wongma7/migrationawsga 
Promote CSIMigrationAWS to GA
 2022-08-01 13:18:29 -07:00
Kubernetes Prow Robot
42b6b2887c
Merge pull request #110888 from likakuli/feature_ignoreeventforgc 
feat: ignore all event resource for gc
 2022-08-01 12:10:28 -07:00
Brian Pursley
a29fb9abae Add logging for reconciler unit test 2022-07-30 10:33:27 -04:00
Matthew Wong
777f43062c Remove unit tests that set & test CSIMigrationAWS false since it's now locked to true 2022-07-29 13:52:06 -07:00
Jakub Przychodzeń
7dd4e89a99 Enable 'running_managed_controllers' for KCM nodeipam controller 2022-07-27 14:30:40 +00:00
Piotr Betkier
f428705ec6 Fix comment in HPA's scale event replicaChange 
The field replicaChange in timestampedScaleEvent was wrongly described
as either positive or negative depending on the scale direction. In
fact the change is set as unsigned, positive or 0 even for downscales.
 2022-07-27 15:28:09 +02:00
Davanum Srinivas
a9593d634c
Generate and format files 
- Run hack/update-codegen.sh
- Run hack/update-generated-device-plugin.sh
- Run hack/update-generated-protobuf.sh
- Run hack/update-generated-runtime.sh
- Run hack/update-generated-swagger-docs.sh
- Run hack/update-openapi-spec.sh
- Run hack/update-gofmt.sh

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2022-07-26 13:14:05 -04:00
Kubernetes Prow Robot
7156c96e5d
Merge pull request #111194 from ravisantoshgudimetla/promote-maxSurge-ga 
Promote DS max surge to GA
 2022-07-25 06:20:46 -07:00
Kubernetes Prow Robot
a6afdf45dd
Merge pull request #110359 from MadhavJivrajani/remove-api-call-under-lock 
controller/nodelifecycle: Refactor to not make API calls under lock
 2022-07-25 06:20:34 -07:00
Madhav Jivrajani
3c0bc26d90 controller/nodelifecycle: Refactor to not make API calls under lock 
The evictorLock only protects zonePodEvictor and zoneNoExecuteTainter.
processTaintBaseEviction showed indications of increased lock contention
among goroutines (see issue 110341 for more details).

The refactor done is to ensure that all codepaths in that function that
hold the evictorLock AND make API calls under the lock, are now making
API calls outside the lock and the lock is held only for accessing either
zonePodEvictor or zoneNoExecuteTainter or both.

Two other places where the refactor was done is the doEvictionPass and
doNoExecuteTaintingPass functions which make multiple API calls under
the evictorLock.

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
 2022-07-25 15:16:26 +05:30
guiyong.ou
aa6d0f5bb0 code cleanup 
Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>
 2022-07-24 21:16:21 +08:00
BinacsLee
ae0c7b1ffb cleanup: use sets.Clone() to avoid interim slice 2022-07-21 20:21:01 +08:00
Michal Wozniak
2f61b6105c Add integration tests for podgc 2022-07-20 15:17:14 +02:00
Kubernetes Prow Robot
ddeb3ab90b
Merge pull request #111084 from mimowo/retriable-pod-failures-refactor-taint-mngr 
Refactor taint_manager to do not use getPod and getNode stubs
 2022-07-19 06:54:06 -07:00
Kubernetes Prow Robot
9cf4f15884
Merge pull request #110633 from wojtek-t/fix_leaking_goroutines_10 
Fix leaking goroutines in multiple integration tests
 2022-07-18 21:56:05 -07:00
Kubernetes Prow Robot
1c1efde70d
Merge pull request #109639 from Abirdcfly/fixduplicateimport 
cleanup: remove all duplicate import
 2022-07-18 16:55:23 -07:00
Ravi Gudimetla
7397c029e8 Promote DS MaxSurge to GA 2022-07-18 07:54:59 -04:00
lucming
fba637c33d code clean up 2022-07-18 16:06:20 +08:00
Kubernetes Prow Robot
3987c8ad91
Merge pull request #111134 from ldsdsy/modify1 
Improve the accuracy of output msg in pkg/controller/endpoint/endpoints_controller.go
 2022-07-17 23:51:15 -07:00
lucming
e536d565ea clean up code 2022-07-15 20:22:37 +08:00
PingWang
565d60ff15 HandleError of updateStatusIfNeeded in func reconcileAutoscaler 
Signed-off-by: PingWang <wang.ping5@zte.com.cn>
 2022-07-15 14:12:13 +08:00
Kubernetes Prow Robot
e5f4f8d71b
Merge pull request #110896 from ravisantoshgudimetla/promote-minReadySec-sts-update-ga 
Promote minReadySeconds to GA
 2022-07-14 09:45:09 -07:00
Michal Wozniak
4ec8cf08da This PR refactors taint_manager to eliminate the getPod and getNode stubs. 2022-07-14 18:00:44 +02:00
Kubernetes Prow Robot
27110bd821
Merge pull request #111070 from mimowo/retriable-pod-failures-refactor-gc-controller 
Refactor gc_controller to do not use the deletePod stub
 2022-07-14 06:11:09 -07:00
Wojciech Tyczyński
13e4f2b554 Clean shutdown of volume integration tests 2022-07-14 11:25:57 +02:00
ldsdsy
eacddf9f28 Optimising print information 2022-07-14 15:03:03 +08:00
Abirdcfly
00b9ead02c cleanup: remove duplicate import 
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
 2022-07-14 11:25:19 +08:00
Ravi Gudimetla
9144250a92 Promote minReadySeconds to GA 2022-07-13 11:37:10 -04:00
Michal Wozniak
778b8300bc fix nits 2022-07-12 10:16:00 +02:00
Michal Wozniak
2730d285cf do not store context 2022-07-12 10:13:47 +02:00
Michal Wozniak
4a3d51359a Refact GC controller to do not use stub deletePod 2022-07-12 10:13:47 +02:00
Andy Goldstein
a899441484
quota: add an update filter 
Fix a TODO to plumb an update filter from above in the resource quota
monitor code that was handling update events for quota-able objects,
instead of hard-coding the logic in the resource quota monitor.

Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
 2022-07-08 18:39:55 -04:00
Aldo Culquicondor
b492f49c9f Do not skip job requeue in conflict error 
Change-Id: Ie97977887a1cc3de58922d73dce92ae1965965bf
 2022-07-08 16:14:32 +00:00
Kubernetes Prow Robot
b3be343bc8
Merge pull request #110811 from Abirdcfly/clock 
Update golangci-lint to 1.46.2 and fix errors
 2022-07-06 16:03:32 -07:00
likakuli
74a3b8f4a9 feat: fix a bug thaat not all event be ignored by gc controller 
Signed-off-by: likakuli <1154584512@qq.com>
 2022-07-04 18:00:54 +08:00
0xff-dev
0a77a9122f convert int32 to pointer using library function 2022-07-01 14:58:26 +08:00
Harsha Narayana
c3cbc443ef
structured-logging: replace KObjs with KObjSlice for logging 2022-07-01 09:52:07 +05:30
Abirdcfly
2bca77a3d9 Update golangci-lint to 1.46.2 and fix errors 
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
 2022-06-29 17:42:46 +08:00
Kubernetes Prow Robot
7f920da442
Merge pull request #110827 from Abirdcfly/simple2 
cleanup:use append other than for loop
 2022-06-28 19:58:15 -07:00
Kubernetes Prow Robot
6269784cd0
Merge pull request #109250 from d-honeybadger/fix-cronjob-scheduling-every-syntax 
Fix requeueing of cronjobs with every-style schedule
 2022-06-28 04:37:57 -07:00
Abirdcfly
8e9a896483
cleanup:use append other than for loop 
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
 2022-06-28 16:31:59 +08:00
Kubernetes Prow Robot
aefb71d7ef
Merge pull request #110721 from jsafrane/fix-force-detach 
Don't force detach volume from healthy nodes
 2022-06-27 07:49:12 -07:00
Kubernetes Prow Robot
11686e1386
Merge pull request #110771 from alculquicondor/increase_timeout 
Wait for cache sync in TestSyncPastDeadlineJobFinished
 2022-06-24 13:28:59 -07:00
Aldo Culquicondor
62a25920e6 Wait for cache sync in TestSyncPastDeadlineJobFinished 
Change-Id: I6f023ca6999108f4f86a0f57831d47704cdbb42b
 2022-06-24 09:22:59 -04:00
Jan Safranek
3b94ac228a Don't force detach volume from healthy nodes 
6 minute force-deatch timeout should be used only for nodes that are not
healthy. 

In case a CSI driver is being upgraded or it's simply slow, NodeUnstage
can take more than 6 minutes. In that case, Pod is already deleted from the
API server and thus A/D controller will force-detach a mounted volume,
possibly corrupting the volume and breaking CSI - a CSI driver expects
NodeUnstage to succeed before Kubernetes can call ControllerUnpublish.
 2022-06-24 12:51:41 +02:00
Kubernetes Prow Robot
ae3537120b
Merge pull request #110639 from aojea/slice_no_node 
EndpointSlice with Pods without an existing Node
 2022-06-22 10:43:42 -07:00
Kubernetes Prow Robot
b60978629d
Merge pull request #110700 from alculquicondor/increase_timeout 
Increase timeout for TestSyncPastDeadlineJobFinished
 2022-06-22 08:23:56 -07:00
Kubernetes Prow Robot
18b5efceda
Merge pull request #110410 from Jiawei0227/master 
CSIMigration feature gate to GA
 2022-06-22 04:05:48 -07:00
Antonio Ojea
b8ba6ab005 endpointslices: node missing on Pod scenario 
When a Pod is referencing a Node that doesn't exist on the local
informer cache, the current behavior was to return an error to
retry later and stop processing.
However, this can cause scenarios that a missing node leaves a
Slice stuck, it can no reflect other changes, or be created.
Also, this doesn't respect the publishNotReadyAddresses options
on Services, that considers ok to publish pod Addresses that are
known to not be ready.

The new behavior keeps retrying the problematic Service, but it
keeps processing the updates, reflacting current state on the
EndpointSlice. If the publishNotReadyAddresses is set, a missing
node on a Pod is not treated as an error.
 2022-06-22 09:45:16 +02:00
Antonio Ojea
baecb1981e fix metrics for placeholder slice 
There is always a placeholder slice.

The ServicePortCache logic was considering always one endpointSlice
per Endpoint, but if there are multiple empty Endpoints, we just
use one placeholder slice, not multiple placeholder slices.
 2022-06-22 09:45:02 +02:00
Antonio Ojea
0d9689a55d fix a bug on endpointslices tests comparing the wrong metrics 2022-06-22 09:40:18 +02:00
Aldo Culquicondor
817c8bbf59 Increase timeout for TestSyncPastDeadlineJobFinished 
To mitigate flakiness

Change-Id: I1d0286d16d2b7dd3a605690e9a2d4d2f954701ff
 2022-06-21 14:49:10 -04:00
lokichoggio
a86f1672c3
code optimization 2022-06-21 23:36:07 +08:00
Kubernetes Prow Robot
375fd32b9f
Merge pull request #109957 from adammw/adammw/disruption-implements-scale 
disruptioncontroller: check for scale subresource correctly
 2022-06-21 08:00:26 -07:00
Adam Malcontenti-Wilson
af3594dfa5 disruptioncontroller: check for scale subresource correctly 2022-06-15 08:52:47 +10:00
Kubernetes Prow Robot
10066243df
Merge pull request #110365 from spencerhance/epslice-recycle-bug 
Fix unnecessary recreation of placeholder EndpointSlice
 2022-06-14 13:15:34 -07:00
Spencer Hance
5f8dc48fbe Fix unnecessary recreation of placeholder EndpointSlice 
Fixes Issue 108231 by checking `slicesToDelete` in the EndpointSlice
reconciler for a pre-existing placeholder slice.

Also adds a helper function for comparing the slices.
 2022-06-14 09:24:38 -07:00
Kubernetes Prow Robot
5503bb0570
Merge pull request #110529 from wojtek-t/fix_leaking_goroutines_7 
Fix leaking goroutines in multiple integration tests
 2022-06-14 09:09:54 -07:00
Wojciech Tyczyński
8a87681a39 Clean shutdown of resourcequota integration tests 2022-06-14 13:55:31 +02:00
Harsha Narayana
eea7dca085
GIT-110239: fix activeDeadlineSeconds enforcement bug 
GIT-110239: add additional tests with preset Status.StartTime

GIT-110239: add additional tests with preset Status.StartTime
 2022-06-13 20:06:44 +05:30
Wojciech Tyczyński
32cbd77121 Clean shutdown of garbagecollector integration tests 2022-06-13 00:14:19 +02:00
ZhangYu
0be333dd7d modify incorrect words 2022-06-10 09:18:42 +08:00
Kubernetes Prow Robot
6cd258f9f5
Merge pull request #110292 from mimowo/109904-avoid-duplicate-conditions 
Avoid duplicate Failed conditions in job status
 2022-06-09 14:01:45 -07:00
Kubernetes Prow Robot
e8d6b76f8b
Merge pull request #109624 from aryan9600/fix-endpointslice-deletion 
Ignore EndpointSlices that are marked for deletion
 2022-06-09 00:11:42 -07:00
Kubernetes Prow Robot
39b6e6c6a0
Merge pull request #110362 from wojtek-t/fix_leaking_goroutines_5 
Fix leaking goroutines in multiple integration tests
 2022-06-07 08:44:55 -07:00
Jiawei Wang
760365d5c9 CSIMigration feature gate to GA 2022-06-06 21:19:19 +00:00
Wojciech Tyczyński
006ff4510b Clean shutdown of nodecontroller integration tests 2022-06-06 20:33:20 +02:00
Sanskar Jaiswal
4314e58ae5 move the ignore logic higher up to the reconciler 
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
 2022-06-06 09:49:57 +05:30
Wojciech Tyczyński
d9d46d5326 Clean shutdown of certificates integration tests 2022-06-02 21:02:04 +02:00
Wojciech Tyczyński
783da34f54 Clean shutdown of disruption integration tests 2022-06-02 21:02:04 +02:00
Kubernetes Prow Robot
9f82d81e55
Merge pull request #110286 from FillZpp/add-test-for-statefulset-maxunavailable 
A calculation function for StatefulSet maxUnavailable and some tests for it
 2022-06-02 10:46:07 -07:00
Kubernetes Prow Robot
03d0e2c338
Merge pull request #110264 from wojtek-t/fix_leaking_goroutines_4 
Fix leaking goroutines in multiple integration tests
 2022-06-02 03:59:47 -07:00