Mike Spreitzer
92a35f5bca
Usse generics to simplify pkg/registry/flowcontrol/ensurer
...
Signed-off-by: Mike Spreitzer <mspreitz@us.ibm.com>
2023-06-22 00:56:54 -04:00
Abu Kashem
672614b57e
apf: refactor bootstrap ensure strategy
2023-06-09 13:31:23 -04:00
Jordan Liggitt
815578295a
Revert "support short name for flowschema and prioritylevelconfiguration"
...
This reverts commit 3dd0c41663
2023-05-13 11:11:04 -04:00
Mike Spreitzer
008576da07
Improve and simplify maintenance of APF bootstrap objects
...
Prepare to make deletion of unwanted object conditional on ResourceVersion.
Remove unnecessary split between finding unwanted objects and removing
them.
Remove unnecessary layers of indirection to reach constant logic.
Use interfaces to remove need for type assertions.
Threaded context into APF object maintenance
Note and respect immutability of desired bootstrap objects
2023-05-05 09:36:48 -04:00
Kubernetes Prow Robot
f5e361e4e6
Merge pull request #117107 from pohly/test-integration-race-detection-flowcontrol
...
pkg/registry/flowcontrol: avoid race condition during Create
2023-05-05 00:09:24 -07:00
Patrick Ohly
5e1c6cd0d4
pkg/registry/flowcontrol: avoid race condition during Create
...
k8s.io/kubernetes/test/integration/controlplane.TestReconcilerAPIServerLeaseMultiCombined
suffered from race conditions. The underlying reason is that
330b5a2b8d/staging/src/k8s.io/apimachinery/pkg/runtime/helper.go (L221-L243)
2023-04-05 15:59:22 +02:00
kkkkun
3dd0c41663
support short name for flowschema and prioritylevelconfiguration
2023-03-02 09:04:28 +00:00
Arda Güçlü
1abf94bec3
Remove GetSingularName for subresources
2022-11-18 12:21:19 +03:00
Arda Güçlü
672e0b1e01
Use correct singular name format for subresources
2022-11-18 12:21:19 +03:00
Arda Güçlü
578ddde80e
Add singular name for the rest of types
2022-11-18 12:21:13 +03:00
Abu Kashem
424b23bb15
apiserver: fix defaulting for apf bootstrap configuration
2022-11-08 13:23:09 -08:00
Abu Kashem
66fc0d7037
rename assuredConcurrencyShares for flowcontrol v1beta3
2022-09-26 15:34:10 -04:00
Abu Kashem
0a99e6ebb1
apiserver: update apf logic to use v1beta3
2022-09-21 18:54:20 -04:00
Abu Kashem
e1a764d635
apiserver: enable v1beta3 for apf
2022-09-21 18:54:19 -04:00
Davanum Srinivas
a9593d634c
Generate and format files
...
- Run hack/update-codegen.sh
- Run hack/update-generated-device-plugin.sh
- Run hack/update-generated-protobuf.sh
- Run hack/update-generated-runtime.sh
- Run hack/update-generated-swagger-docs.sh
- Run hack/update-openapi-spec.sh
- Run hack/update-gofmt.sh
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2022-07-26 13:14:05 -04:00
Wojciech Tyczyński
80060a502c
Implement Destroy() method for all registries
2022-04-19 15:59:13 +02:00
Kubernetes Prow Robot
9fbe66a486
Merge pull request #103516 from ykakarap/kubectl-subresources-apiserver
...
kubectl: apiserver changes to add --subresource support
2022-03-23 13:21:32 -07:00
Yuvaraj Kakaraparthi
801c39b478
kubectl: API changes to support --subresource in kubectl
...
Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
Co-authored-by: Nikhita Raghunath <nikitaraghunath@gmail.com>
Co-authored-by: Yuvaraj Kakaraparthi <kakaraparthy@vmware.com>
2022-03-23 11:19:58 +05:30
David Eads
a59b92e8c0
reduce API surface area of whether a resource is enabled
2022-02-23 13:36:33 -05:00
David Eads
0ec20f97d2
migrate more rest handlers to select by resource enablement
2022-02-22 12:07:43 -05:00
Abu Kashem
95b4ac4dbd
apf: create suggested pl before flowschema
2022-01-24 10:24:30 -05:00
Abu Kashem
df41fe5d84
apf: clarify with comment
2022-01-19 17:38:31 -05:00
Patrick Ohly
9eaa2dc554
avoid klog Info calls without verbosity
...
In the following code pattern, the log message will get logged with v=0 in JSON
output although conceptually it has a higher verbosity:
if klog.V(5).Enabled() {
klog.Info("hello world")
}
Having the actual verbosity in the JSON output is relevant, for example for
filtering out only the important info messages. The solution is to use
klog.V(5).Info or something similar.
Whether the outer if is necessary at all depends on how complex the parameters
are. The return value of klog.V can be captured in a variable and be used
multiple times to avoid the overhead for that function call and to avoid
repeating the verbosity level.
2022-01-12 07:48:36 +01:00
Mike Spreitzer
72403c8814
Concurrentize pkg/registry/flowcontrol/ensurer/strategy.go
...
Stop logging error messages when surprised by concurrent activity.
Concurrent activity is not an error, it is normal.
2022-01-04 22:55:21 -05:00
Kubernetes Prow Robot
9e209efd65
Merge pull request #107104 from tkashem/apf-use-v1beta2
...
apf: use v1beta2 in registry package
2022-01-04 13:06:42 -08:00
Abu Kashem
f30a34bc01
apf: use v1beta2 for registry
2021-12-17 10:35:37 -05:00
Ben Luddy
3f929b1634
Use a lister for bootstrap flowcontrol config objects.
...
Instead of listing all flowschemas and prioritylevelconfigurations on
each tick, read from local informer caches.
2021-10-20 11:40:00 -04:00
Abu Kashem
28f2b42a41
apf: update apf logic to use v1beta2
2021-09-09 08:28:58 -04:00
Abu Kashem
e2b8701545
apf: ebable v1beta2
2021-09-09 08:28:53 -04:00
Abu Kashem
d9e3fbff94
apf: fix bootstrap ensurer log message
2021-07-07 15:01:46 -04:00
Kubernetes Prow Robot
781382a74d
Merge pull request #102067 from tkashem/apf-always-create-suggested
...
apf: always create missing bootstrap configuration object
2021-05-25 12:12:43 -07:00
Kubernetes Prow Robot
c115435adc
Merge pull request #101688 from liggitt/field-warnings
...
Add field-level warning plumbing and add pod spec warnings
2021-05-19 17:23:04 -07:00
Jordan Liggitt
8c8a4cf3e4
Add WarningsOnCreate,WarningsOnUpdate
2021-05-18 10:42:36 -04:00
Abu Kashem
f9ee64007e
apf: always create missing bootstrap configuration object(s)
2021-05-17 12:08:39 -04:00
Abu Kashem
759a64136b
add auto update for apf bootstrap configuration
...
Take the following approach:
On a fresh install, all bootstrap configuration objects will
have auto update enabled via the following annotation :
`apf.kubernetes.io/autoupdate: 'true'`
The kube-apiserver periodically checks the bootstrap configuration
objects on the cluster and applies update if necessary.
We enforce an 'always auto-update' policy for the mandatory
configuration object(s).
We update the suggested configuration objects when:
- auto update is enabled (`apf.kubernetes.io/autoupdate: 'true'`) or
- auto update annotation key is missing but `generation` is `1`
If the configuration object is missing the annotation key, we add
it appropriately:
it is set to `true` if `generation` is `1`, `false` otherwise.
The above approach ensures that we don't squash changes made by an
operator. Please note, we can't protect the changes made by the
operator in the following scenario:
- the user changes the spec and then deletes and recreates
the same object. (generation resets to 1)
remove using a marker
2021-05-07 14:23:17 -04:00
Abu Kashem
b776109427
apf: handle error from PollImmediateUntil
...
We should not attempt creation of mandatory objects if ensuring
the suggested configuration resulted in an error.
We rely on the presence of the "exempt" priority level configuration
object in the cluster to indicate whether we should ensure
suggested configuration.
2021-03-19 14:37:44 -04:00
Kevin Delgado
a1fac8cbd9
Server-Side Apply: Status Wiping/Reset Fields
...
Adds and implements ResetFieldsProvder interface in order to ensure that
the fieldmanager no longer owns fields that get reset before the object
is persisted.
Co-authored-by: Kevin Wiesmueller <kwiesmul@redhat.com>
Co-authored-by: Kevin Delgado <kevindelgado@google.com>
2021-03-10 01:02:18 +00:00
David Eads
a375312fdc
stop re-use of alpha storage as beta for flowcontrol
2021-03-03 16:10:45 -05:00
Benjamin Elder
56e092e382
hack/update-bazel.sh
2021-02-28 15:17:29 -08:00
Adhityaa Chandrasekar
642b114830
flowcontrol bootstrap: give catch-all PL more concurrency share
...
Signed-off-by: Adhityaa Chandrasekar <adtac@google.com>
2020-11-13 23:20:42 +00:00
yue9944882
849be447f5
APF: graduate API and types to beta
...
Signed-off-by: Adhityaa Chandrasekar <adtac@google.com>
2020-11-13 23:20:39 +00:00
Davanum Srinivas
07d88617e5
Run hack/update-vendor.sh
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-05-16 07:54:33 -04:00
Davanum Srinivas
442a69c3bd
switch over k/k to use klog v2
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-05-16 07:54:27 -04:00
Mike Spreitzer
3501f7c470
Regularize the name of the post-start-hook that injects APF config objects
...
Name it analogously to its companion that launches the consumer of
APF config objects.
2020-04-09 20:59:56 -04:00
Antoine Pelisse
dfe1703ffa
Do not reset managedFields in status update strategy
2020-03-19 09:58:46 -07:00
Mike Spreitzer
b142868eaf
Version the API Priority and Fairness FieldManager values
2020-02-14 13:50:11 -05:00
Mike Spreitzer
73614ddd4e
Added API Priority and Fairness filter and config consumer
2020-02-10 22:54:40 -05:00
Mike Danese
25651408ae
generated: run refactor
2020-02-08 12:30:21 -05:00
Mike Danese
3aa59f7f30
generated: run refactor
2020-02-07 18:16:47 -08:00
yue9944882
70dea6e4a8
review: several fixes and addressing comments
2020-01-11 01:46:31 +08:00
