github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
93,054 Commits 1 Branch 31 Tags 1,019 MiB
479249b3a3
Commit Graph

8583 Commits

Author SHA1 Message Date
JieJhih Jhang
8bd9c994ca fix command variable exited with status 1 2020-01-30 12:52:09 +08:00
Aldo Culquicondor
3d83ef2e8e Autogenerated and build files for kubescheduler.config.k8s.io/v1alpha2 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
 2020-01-29 17:18:48 -05:00
Kubernetes Prow Robot
17936ff63b
Merge pull request #87544 from SenXuDC/staticcheck 
fix static check in pkg/volume/flocker
 2020-01-29 07:32:42 -08:00
Jin Hase
0ce49aea1f
Update get-build.sh 2020-01-29 09:27:51 +09:00
Elijah Oyekunle
558f6aab56 add staging directories to import-boss verify script 2020-01-28 10:51:46 +01:00
YuikoTakada
03974c1ea4 Fix static check failures in test/integration/deployment 2020-01-28 06:08:37 +00:00
Kubernetes Prow Robot
962a61f51f
Merge pull request #87446 from KobayashiD27/add-hack-comment 
add comment in several hack/ sh scripts.
 2020-01-27 20:33:39 -08:00
Kubernetes Prow Robot
63df400778
Merge pull request #87514 from hase1128/fix-verify-api-groups-script 
Fix bug of hack/verify-api-groups.sh
 2020-01-27 18:53:39 -08:00
Jin Hase
e992ec0d59 Add comments in several hack/*.sh 2020-01-28 09:27:40 +09:00
Kobayashi Daisuke
ee00497ea9 add comment in several hack/ sh scripts. 2020-01-27 11:13:09 +09:00
Jin Hase
08833c9180
Withdraw the change of getting version variable 2020-01-27 08:26:04 +09:00
Kubernetes Prow Robot
e2b823fa7d
Merge pull request #87243 from SenXuDC/fix-staticcheck 
fix static check in cluster/images/etcd-version-monitor
 2020-01-25 22:41:02 -08:00
Kubernetes Prow Robot
089d3e63e5
Merge pull request #86910 from RaunakShah/golint_vspherestorage 
Fix golint errors in test/e2e/storage/vsphere
 2020-01-25 07:41:01 -08:00
SenXuDC
7c72b5791b fix static check in pkg/volume/flocker 2020-01-25 10:51:55 +08:00
Kubernetes Prow Robot
58c67632e5
Merge pull request #87475 from liggitt/drop-ga-gates 
Remove deprecated GA feature gates that expire in 1.18
 2020-01-24 03:02:46 -08:00
Jin Hase
efd309b7da Fix bug of hack/verify-api-groups.sh 2020-01-24 17:49:42 +09:00
Kubernetes Prow Robot
6c693549a3
Merge pull request #87183 from Aresforchina/fix-staticcheck-test15 
fix-staticcheck:pkg/volume/scaleio/
 2020-01-23 22:20:31 -08:00
Kubernetes Prow Robot
c5d981583a
Merge pull request #87308 from KobayashiD27/fix-staticcheck 
Fix staticcheck in pkg/controller/podgc
 2020-01-23 11:34:11 -08:00
Jordan Liggitt
57724766bc Remove deprecated GA feature gates 2020-01-23 13:44:21 -05:00
Kubernetes Prow Robot
f0486a6b6a
Merge pull request #87178 from YuikoTakada/fix_81657_1 
Fix static check failures in test/e2e/instrumentation/logging/st…
 2020-01-23 06:00:49 -08:00
Sakura
9897f33f7d
fix static check errors in vendor/k8s.io/apimachinery/pkg/api/resource 
Signed-off-by: Sakura <longfei.shang@daocloud.io>
 2020-01-23 21:07:14 +08:00
drfish
a14ceeb2c0 Staticcheck: vendor/k8s.io/kubectl/pkg/cmd/exec|config|certificates 2020-01-23 14:03:11 +08:00
Kubernetes Prow Robot
4630690eae
Merge pull request #87457 from 928234269/fix_staticcheck03 
fix static check errors in test/integration/etcd
 2020-01-22 20:37:47 -08:00
Kubernetes Prow Robot
53a394e53f
Merge pull request #87188 from claudiubelu/test-images/centralization-cleanup 
test images: Image Promoter fixes
 2020-01-22 16:30:50 -08:00
Sakura
8c6d7a7086
fix static check errors in test/integration/etcd 
Signed-off-by: Sakura <longfei.shang@daocloud.io>
 2020-01-22 23:16:26 +08:00
Kubernetes Prow Robot
1735f7a2b6
Merge pull request #87377 from gavinfish/pkg-util-netsh 
Fix static check errors in pkg/util/netsh
 2020-01-21 22:02:35 -08:00
Antoine Pelisse
38c5f318c9 kubectl-diff: Test return code on failure and changes 2020-01-21 15:34:22 -08:00
Kubernetes Prow Robot
84beab6f26
Merge pull request #87386 from liggitt/local-up-token-signer 
Enable bound tokens in local-up-cluster
 2020-01-21 06:35:51 -08:00
Kubernetes Prow Robot
29a4b39536
Merge pull request #87382 from yiyang5055/fix-staticcheck 
fix static check failure in pkg/controller/disruption and pkg/control…
 2020-01-21 06:35:37 -08:00
Jin Hase
093fd4ab02 Add comments in several hack/verify-*.sh(s-v) 2020-01-21 19:10:46 +09:00
Kubernetes Prow Robot
a7b4459cd1
Merge pull request #87379 from hase1128/add-comment-to-several-verify-scripts_3 
Add comments in several hack/verify-*.sh(g-r)
 2020-01-21 01:30:09 -08:00
YuikoTakada
e5a2aeeae6 Fix static check failures in test/e2e/instrumentation/logging/stackdriver 2020-01-21 00:43:21 +00:00
Jordan Liggitt
2a2ce207f2 Enable bound tokens in local-up-cluster 2020-01-20 09:19:37 -05:00
Kubernetes Prow Robot
f680c261e6
Merge pull request #87074 from yuxiaobo96/k8s-staticcheck 
fix staticcheck: pkg/volume/awsebs
 2020-01-20 03:09:37 -08:00
yiyang5055
53aff819e0 fix static check failure in pkg/controller/disruption and pkg/controller/namespace/deletion 2020-01-20 09:10:46 +00:00
yuxiaobo
72f34b817e staticcheck: pkg/volume/fc, pkg/volume/portworx and pkg/volume/vsphere_volume 
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
 2020-01-20 16:47:54 +08:00
Jin Hase
c8df27c2b1 Add comments in several hack/verify-*.sh(g-r) 2020-01-20 17:10:55 +09:00
Kubernetes Prow Robot
3d8317ae91
Merge pull request #87139 from yuxiaobo96/k8s-staticcheck2 
fix staticcheck:pkg/volume/cinder
 2020-01-19 21:47:36 -08:00
drfish
f19f4e40f9 Fix static check errors in pkg/util/netsh 2020-01-20 13:25:34 +08:00
Sakura
203c7b4731
fix staticcheck errors in pkg/controller/daemon. 
Signed-off-by: Sakura <longfei.shang@daocloud.io>
 2020-01-19 21:09:05 +08:00
chendotjs
2afe0da8ee Unify --cluster-cidr in KCM and CCM 2020-01-19 13:51:02 +08:00
Kubernetes Prow Robot
66178b9cc1
Merge pull request #87307 from hase1128/add-comment-to-several-verify-scripts_2 
Add comments in several hack/verify-generated-*.sh
 2020-01-18 01:49:35 -08:00
Kubernetes Prow Robot
f256c0254f
Merge pull request #87221 from YuikoTakada/fix_81657_2 
Fix static check failures in test/e2e/instrumentation/monitoring
 2020-01-17 21:39:49 -08:00
Kubernetes Prow Robot
f88f58cb79
Merge pull request #87245 from 928234269/fix_staticcheck 
fix staticcheck errors in pkg/volume/hostpath.
 2020-01-17 12:15:18 -08:00
Kubernetes Prow Robot
acf64f4501
Merge pull request #87303 from k-toyoda-pi/modify_alias_e2ejob 
Modify alias of e2e/framework/job to e2ejob
 2020-01-17 10:15:10 -08:00
Kobayashi Daisuke
ed1381e35f Fix staticcheck in pkg/controller/podgc 2020-01-17 15:42:38 +09:00
Jin Hase
09a132be29 Add comments in several hack/verify-generated-*.sh 2020-01-17 14:20:48 +09:00
Kubernetes Prow Robot
56b140c6f5
Merge pull request #87272 from hase1128/add-comment-to-several-verify-scripts 
Add comments in several hack/verify-*.sh
 2020-01-16 18:57:08 -08:00
Kubernetes Prow Robot
9519d9764d
Merge pull request #87065 from tanjunchen/add-README-hack 
add README.md in hack/
 2020-01-16 18:56:55 -08:00
toyoda
0c12ae5240 Modify alias of e2e/framework/job to e2ejob 2020-01-17 10:56:05 +09:00
shahra
18f05ef5b9 Fix golint errors in test/e2e/storage/vsphere 2020-01-16 11:12:31 -08:00
Kubernetes Prow Robot
0c1d714627
Merge pull request #87128 from Aresforchina/fix-staticcheck-test12 
fix-staticcheck:pkg/volume/emptydir
 2020-01-16 07:48:50 -08:00
Kubernetes Prow Robot
47475c69d1
Merge pull request #87181 from tanjunchen/add-comment-hack-update 
add comment in hack/update-*.sh
 2020-01-15 21:21:38 -08:00
Kubernetes Prow Robot
7ffa2b9c46
Merge pull request #87042 from oomichi/e2e-alias 
Add import-aliases check of e2e sub framework
 2020-01-15 21:20:48 -08:00
Jin Hase
e1eabf8576 Add comments in several hack/verify-*.sh 2020-01-16 13:54:58 +09:00
YuikoTakada
aa2691eeac Fix static check failures in test/e2e/instrumentation/monitoring 2020-01-16 02:42:07 +00:00
tanjunchen
0c77101b90 add README.md in hack/ 2020-01-16 10:12:18 +08:00
tanjunchen
b2f76cc780 add comment in hack/update-*.sh 2020-01-16 10:05:49 +08:00
Kobayashi Daisuke
0c3112fff3 fix golint error in plugin/pkg/auth/authorizer/rbac/bootstrappolicy 2020-01-16 09:23:16 +09:00
Sakura
4143bc7a96
fix staticcheck errors in pkg/volume/hostpath. 
Signed-off-by: Sakura <longfei.shang@daocloud.io>
 2020-01-15 22:54:48 +08:00
SenXuDC
cc8e8401e2 fix static check in cluster/images/etcd-version-monitor 2020-01-15 21:31:33 +08:00
Kubernetes Prow Robot
12b77b8f16
Merge pull request #86955 from RainbowMango/pr_clean_cloud_controller_manager 
Cleanup cloud controller manager when closing cluster.
 2020-01-15 01:22:00 -08:00
Aresforchina
514bdbedac fix-static:pkg/volume/scaleio/ 2020-01-15 09:53:27 +08:00
Kubernetes Prow Robot
ded4f74133
Merge pull request #87082 from liggitt/cleanup-testapi 
Remove unused KUBE_TEST_API logic
 2020-01-13 13:59:19 -08:00
Kubernetes Prow Robot
e1cc36000f
Merge pull request #87002 from SataQiu/staticcheck-20200109 
Fix staticcheck failures of pkg/util/ipconfig pkg/util/iptables pkg/util/ipvs/testing
 2020-01-13 13:58:55 -08:00
Jordan Liggitt
2a47900620 Remove unused KUBE_TEST_API logic 2020-01-13 09:09:46 -05:00
yuxiaobo
da15570daa fix staticcheck:pkg/volume/cinder 
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
 2020-01-13 18:20:23 +08:00
Aresforchina
e62f9625cf fix-static:pkg/volume/emptydir 2020-01-13 15:23:45 +08:00
Kubernetes Prow Robot
ce6a9f97e5
Merge pull request #87076 from hase1128/add-simple-explanation-to-verify-linkcheck-script 
Add some comment to hack/verify-linkcheck.sh
 2020-01-10 21:19:36 -08:00
Jin Hase
8da4a1d97f Add some comment to hack/verify-linkcheck.sh 2020-01-10 20:12:30 +09:00
yuxiaobo
c5764735e2 fix staticcheck:pkg/volume/awsebs 
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
 2020-01-10 18:36:39 +08:00
Kobayashi Daisuke
fee0d43d23 fix golint error in pkg/apis/rbac 2020-01-10 11:22:05 +09:00
Kenichi Omichi
19daee7e60 Add import-aliases check for e2e framework 
This adds import-aliases check for e2e sub framework packages.
 2020-01-09 08:58:20 +00:00
SataQiu
51c742c1dd fix staticcheck failures of pkg/util/ipconfig pkg/util/iptables pkg/util/ipvs/testing 2020-01-09 16:05:11 +08:00
Kubernetes Prow Robot
968361dc83
Merge pull request #86945 from hase1128/add-simple-explanation-to-verify-spelling-script 
Add simple explanation to verify-spelling.sh
 2020-01-08 14:46:14 -08:00
Kubernetes Prow Robot
79bb357193
Merge pull request #84654 from liggitt/drop-openapi-version 
Drop version from static openapi json file
 2020-01-08 11:59:39 -08:00
RainbowMango
0f9c262eda Cleanup cloud controller manager when closing cluster. 2020-01-08 19:18:53 +08:00
Kubernetes Prow Robot
35434fdfea
Merge pull request #86901 from tanjunchen/staticcheck-002 
staticcheck:test/integration/master/
 2020-01-08 02:58:55 -08:00
Kubernetes Prow Robot
dbf3a46ec1
Merge pull request #86893 from RainbowMango/pr_support_external_cloud_provider_part2 
Remove variable EXTERNAL_CLOUD_VOLUME_PLUGIN default value
 2020-01-08 02:58:44 -08:00
Kubernetes Prow Robot
1f50be5d04
Merge pull request #86775 from Aresforchina/fix-staticcheck-test03 
fix staticcheck of pkg/util/ebtables
 2020-01-08 02:58:07 -08:00
Kubernetes Prow Robot
302cf556e0
Merge pull request #86604 from hase1128/add-simple-explanation-to-verify-golint-script 
Add simple explanation to verify golint script
 2020-01-08 01:49:40 -08:00
Jin Hase
ee967060c7 Add simple explanation to verify-spelling.sh 2020-01-08 15:55:10 +09:00
Kubernetes Prow Robot
8dca390262
Merge pull request #84927 from mattjmcnaughton/mattjmcnaughton/fix-kubelet-config-common 
Fix golint failures for pkg/kubelet/config/...
 2020-01-07 21:09:40 -08:00
Kubernetes Prow Robot
11a31590e4
Merge pull request #86900 from tanjunchen/staticcheck-001 
staticcheck:test/integration/auth/
 2020-01-07 07:36:31 -08:00
tanjunchen
8d313f333e staticcheck:test/integration/master/ 2020-01-07 21:56:37 +08:00
tanjunchen
264a1cf5f6 staticcheck:test/integration/auth/ 2020-01-07 15:23:19 +08:00
Kubernetes Prow Robot
8b8f2aa4a5
Merge pull request #85431 from irbull/api-doc 
Add public documentation for kubelet/apis/config
 2020-01-06 23:12:18 -08:00
RainbowMango
24ccd77a98 Remove variable EXTERNAL_CLOUD_VOLUME_PLUGIN default value in local-up-cluster.sh 2020-01-07 10:17:10 +08:00
Kubernetes Prow Robot
d6412b856f
Merge pull request #84345 from danielqsj/withdialer 
replace grpc.WithDialer which is deprecated
 2020-01-06 15:56:17 -08:00
Kubernetes Prow Robot
c409446d41
Merge pull request #86781 from SataQiu/staticcheck-20200102 
Fix staticcheck failures of test/integration/client test/integration/disruption
 2020-01-06 13:34:45 -08:00
Claudiu Belu
4c51eb9063 test images: Image Promoter fixes 
Prior to the Image Centralization part 4 (https://github.com/kubernetes/kubernetes/pull/81170),
a PR merged that enables the Image Promoter to run on the k/k test images.

The Image Promoter currently only builds the Conformance-related images, but the
Image Centralization part 4 centralized some of those images into agnhost, so they
need to be removed from the conformance_images list.

Additionally, https://github.com/kubernetes/kubernetes/pull/81226 proposes mounttest-user
image to be removed, and RunAsUser to be used in tests instead.

The image used by the Image Promoter (gcr.io/k8s-testimages/gcb-docker-gcloud:v20190906-745fed4)
is based on busybox, and thus, the sed binary is actually busybox. image-util.sh calls
kube::util::ensure-gnu-sed several times, which ensures that a GNU sed binary exists
(it checks by greping GNU in its --help output). Obviously, it won't match the busybox sed
binary. But the sed usage in image-util.sh is fairly simple, and the busybox sed is sufficient.

Bumps image versions for: jessie-dnsutils, nonewprivs, resource-consumer, sample-apiserver. These
images are included in the conformance_images that are being built by the Image Promoter, so
we're bumping them just to make sure we're not breaking anything and cause all the CIs to fall.
We're going to bump the image versions used in tests in a subsequent PR. The image version was not
bumped for: agnhost, kitten, nautilus, as they were already bumped by the Image Centralization part 4
PR.
 2020-01-06 09:08:51 -08:00
RainbowMango
eb074761bc Fix local-up-cluster.sh do not work with non-intree external cloud provider issue. 2020-01-06 22:54:38 +08:00
SataQiu
17b0b77026 fix staticcheck failures of test/integration/client test/integration/disruption 2020-01-03 17:23:35 +08:00
Aresforchina
bfc4a7a1c5 fix staticcheck of pkg/util/ebtables 2020-01-02 18:16:50 +08:00
Kubernetes Prow Robot
2099c00290
Merge pull request #86745 from Aresforchina/fix-staticcheck-test01 
Fix staticcheck failures of test/integration/replicationcontroller
 2019-12-31 20:31:39 -08:00
Kubernetes Prow Robot
4058cdcc2a
Merge pull request #86750 from RainbowMango/pr_postpone_swap_warning 
Postpone flag warning log to just before it be used
 2019-12-31 12:25:40 -08:00
RainbowMango
36cbce1182 Postpone flag warning log to just before it be used. 2019-12-31 20:05:53 +08:00
Aresforchina
bf47d14c27 Fix staticcheck failures of test/integration/replicationcontroller 2019-12-31 17:16:01 +08:00
Kubernetes Prow Robot
5da9113fd8
Merge pull request #85078 from k-toyoda-pi/add_apierrs_aliase 
Add apierrors as alias for k8s.io/apimachinery/pkg/api/errors
 2019-12-31 00:59:39 -08:00
Kubernetes Prow Robot
d0c719dbd9
Merge pull request #86716 from SataQiu/staticcheck-20191230 
Fix staticcheck failures of test/integration/scale test/integration/serviceaccount test/integration/serving test/integration/volume
 2019-12-30 20:39:39 -08:00
Kubernetes Prow Robot
9b59ba4ef8
Merge pull request #81895 from praseodym/fix-staticcheck-test/images 
Fix staticcheck failures for test/images
 2019-12-30 00:09:39 -08:00
SataQiu
8c77b96b75 fix staticcheck failures of test/integration/scale test/integration/serviceaccount test/integration/serving test/integration/volume 2019-12-30 13:35:13 +08:00
Kubernetes Prow Robot
cb19ce9e7b
Merge pull request #86533 from RainbowMango/pr_improve_update_openapi_spec_output 
Optimize error messages when updating openapi spec
 2019-12-26 22:27:38 -08:00
toyoda
01083988ae Add apierrors as alias for k8s.io/apimachinery/pkg/api/errors 2019-12-27 11:07:36 +09:00
RainbowMango
12d08d52ee Improve output of update-openapi-spec.sh when printing logs from file. 2019-12-27 09:22:16 +08:00
danielqsj
19fe9f8d94 replace grpc.WithDialer which is deprecated 2019-12-26 17:46:59 +08:00
Guangming Wang
faf27331bc fix shell checks errors in cluster/common.sh 
handle local variable in cluster/common.sh

add comment for shellcheck disable line, and fix error change

fix error: "read" parameters -r position

update function comment

refactor function find-release-tars

rm lines in .shellcheck_failures

Continue to cleanup common.sh
 2019-12-25 16:35:11 +08:00
Jin Hase
75b716a352 Fix simple typos 2019-12-25 17:09:27 +09:00
Jin Hase
17fa573e05 Add simple explanation to verify-golint.sh 2019-12-25 17:05:32 +09:00
Mark Janssen
a54e5cec54 Fix staticcheck failures for pkg/proxy/... 
Errors from staticcheck:
pkg/proxy/healthcheck/proxier_health.go:55:2: field port is unused (U1000)
pkg/proxy/healthcheck/proxier_health.go:162:20: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
pkg/proxy/healthcheck/service_health.go:166:20: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
pkg/proxy/iptables/proxier.go:737:2: this value of args is never used (SA4006)
pkg/proxy/iptables/proxier.go:737:15: this result of append is never used, except maybe in other appends (SA4010)
pkg/proxy/iptables/proxier.go:1287:28: this result of append is never used, except maybe in other appends (SA4010)
pkg/proxy/userspace/proxysocket.go:293:3: this value of n is never used (SA4006)
pkg/proxy/winkernel/metrics.go:74:6: func sinceInMicroseconds is unused (U1000)
pkg/proxy/winkernel/metrics.go:79:6: func sinceInSeconds is unused (U1000)
pkg/proxy/winuserspace/proxier.go:94:2: field portMapMutex is unused (U1000)
pkg/proxy/winuserspace/proxier.go:118:2: field owner is unused (U1000)
pkg/proxy/winuserspace/proxier.go:119:2: field socket is unused (U1000)
pkg/proxy/winuserspace/proxysocket.go:620:4: this value of n is never used (SA4006)
 2019-12-22 21:32:06 +01:00
Kubernetes Prow Robot
109810dfbb
Merge pull request #86473 from kireledan/kireledan/hack-aws-provider 
hack/local-up-cluster: modify cloud provider launch to work with aws
 2019-12-20 18:28:17 -08:00
kireledan
a8a00f690e hack/local-up-cluster: modify cloud provider launch to work with aws 
This commit updates the local-up-cluster script to set the proper provider id when the aws cloud provider is used.
 2019-12-19 22:54:10 -08:00
sshukun
12a5bdec00 Fix go-lint issues in package pkg/kubelet/checkpointmanager/testing/example_checkpoint_formats/v1 2019-12-19 12:53:33 +09:00
Kubernetes Prow Robot
127c47caf4
Merge pull request #85512 from serathius/remove-cluster-monitoring 
Remove cluster-monitoring
 2019-12-17 21:05:57 -08:00
Kubernetes Prow Robot
7a6090550a
Merge pull request #82971 from AnishShah/proxy.go 
Refactor `kubectl proxy` command to have similar design pattern as other kubectl commands.
 2019-12-17 11:59:58 -08:00
Kubernetes Prow Robot
623b697886
Merge pull request #86040 from haosdent/fix-staticcheck-annotate 
fix static check in kubectl/pkg/cmd/annotate.
 2019-12-17 06:18:27 -08:00
Kubernetes Prow Robot
fb0956c234
Merge pull request #85016 from hvaara/fix-golint-pkg-util-sysctl-testing 
Fix golint issues in pkg/util/sysctl/testing
 2019-12-17 06:18:13 -08:00
Anish Shah
0bd41a300f Refactor kubectl proxy command to have similar design pattern as other kubectl commands. 
Few days ago I watched this kubectl code base tour on Youtube
(https://www.youtube.com/watch?v=uz8TS3V9qqY). It talks about a design
pattern that almost every command follows. But I found out that
`kubectl proxy` command does not follow this pattern. So, I'm
refactoring this command to use similar design pattern as other kubectl
commands.
 2019-12-17 08:28:01 +05:30
carlory
2fe82075b4 fix staticcheck faulures in 'cmd' pkg 2019-12-16 18:32:54 +08:00
Mark Janssen
a634e254c1 Fix staticcheck failures for test/images 
Errors from staticcheck:
test/images/agnhost/dns/common.go:79:6: func runCommand is unused (U1000)
test/images/agnhost/inclusterclient/main.go:75:16: using time.Tick leaks the underlying ticker, consider using it only in endless functions, tests and the main package, and use time.NewTicker here (SA1015)
test/images/agnhost/net/nat/closewait.go:41:5: var leakedConnection is unused (U1000)
test/images/agnhost/netexec/netexec.go:157:17: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
test/images/agnhost/netexec/netexec.go:250:18: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
test/images/agnhost/netexec/netexec.go:317:18: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
test/images/agnhost/netexec/netexec.go:331:19: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
test/images/agnhost/netexec/netexec.go:345:19: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
test/images/agnhost/netexec/netexec.go:357:19: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
test/images/agnhost/netexec/netexec.go:370:19: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
test/images/agnhost/netexec/netexec.go:380:9: this value of err is never used (SA4006)
test/images/agnhost/netexec/netexec.go:381:17: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
test/images/agnhost/netexec/netexec.go:386:17: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
test/images/agnhost/pause/pause.go:43:23: syscall.SIGKILL cannot be trapped (did you mean syscall.SIGTERM?) (SA1016)
test/images/agnhost/serve-hostname/serve_hostname.go:125:15: the channel used with signal.Notify should be buffered (SA1017)
test/images/agnhost/webhook/patch_test.go:131:13: this value of err is never used (SA4006)
test/images/pets/peer-finder/peer-finder.go:155:6: this value of newPeers is never used (SA4006)
 2019-12-15 22:34:27 +01:00
Kubernetes Prow Robot
32883e46d6
Merge pull request #86238 from SataQiu/fix-staticcheck-20191213 
Fix staticcheck failures of test/e2e/manifest
 2019-12-15 11:07:37 -08:00
Kubernetes Prow Robot
6a919f2b54
Merge pull request #85903 from liggitt/disable-deprecated-apis 
Remove ability to re-enable serving deprecated APIs
 2019-12-13 16:19:36 -08:00
Jordan Liggitt
f2f22b84cd Delete ReplicationControllerDummy 2019-12-13 12:21:33 -05:00
Jordan Liggitt
18ba6f9482 Remove references to unserved types 2019-12-13 12:21:33 -05:00
Jordan Liggitt
424d5e20df Remove testapi 2019-12-13 11:56:29 -05:00
SataQiu
95bf226533 fix staticcheck failures of test/e2e/manifest 2019-12-13 14:03:44 +08:00
hwdef
64e49e187a add hwdef as a reviewer of hack 2019-12-12 16:10:06 +08:00
SataQiu
e70120f083 fix staticcheck failures of e2e/storage/utils e2e/storage/vsphere 2019-12-11 10:33:21 +08:00
SataQiu
3ed535a89a fix staticcheck failures of e2e/storage/drivers e2e/storage/testsuites 2019-12-10 16:09:29 +08:00
Marek Siarkowicz
31fb04fa98 Remove cluster-monitoring 
Heapster is deprecated and no longer supported
 2019-12-09 11:25:20 +01:00
Haosdent Huang
303c1a40bc fix static check in kubectl/pkg/cmd/annotate. 2019-12-08 23:25:50 +08:00
SataQiu
27d645dc5b fix staticcheck failures of test/e2e/storage 2019-12-07 21:32:11 +08:00
Kubernetes Prow Robot
8ef9caaded
Merge pull request #85676 from tanjunchen/fix-staticcheck-test-integration-apiserver 
fix staticcheck in test/integration/apiserver
 2019-12-06 19:49:08 -08:00
Kubernetes Prow Robot
e0f11a2fc3
Merge pull request #85893 from tanjunchen/fix-test-e2e-network 
fix staticcheck in test/e2e/network/
 2019-12-06 17:06:06 -08:00
tanjunchen
06c5901769 fix staticcheck in test/integration/apiserver 2019-12-06 23:05:20 +08:00
Kubernetes Prow Robot
c2b312bd22
Merge pull request #85790 from tanjunchen/fix-staticcheck-pkg-printers 
fix staticcheck in pkg/printers
 2019-12-05 13:50:54 -08:00
Kubernetes Prow Robot
fe80f32904
Merge pull request #85780 from hwdef/fix-staticcheck16 
test/e2e/auth: Fix static check failures
 2019-12-05 13:50:44 -08:00
Kubernetes Prow Robot
e68d7be680
Merge pull request #85457 from BenTheElder/typecheck-fun 
Typecheck support for verifying providerless build
 2019-12-05 13:50:17 -08:00
hwdef
d81dd48e2c test/e2e/auth: Fix static check failures 2019-12-05 22:42:04 +08:00
Kubernetes Prow Robot
8290c85b95
Merge pull request #82315 from beautytiger/fix_staticcheck_azure 
fix staticcheck errors in legacy-cloud-providers/azure
 2019-12-05 06:36:32 -08:00
Kubernetes Prow Robot
2f58d2e3fe
Merge pull request #85890 from tanjunchen/fix-golint-test-e2e_node-ruuner 
fix golint check in test/e2e_node/runner/remote
 2019-12-05 00:36:32 -08:00
Benjamin Elder
b24dbac09a add hack/verify-typecheck-providerless.sh 2019-12-04 22:30:23 -08:00
tanjunchen
d51b72d9e9 fix staticcheck in test/e2e/network/ 2019-12-05 13:58:28 +08:00
tanjunchen
40911e74c1 fix staticcheck in pkg/printers 2019-12-05 10:24:42 +08:00
Jan Chaloupka
f967c544ad scheduler benchmark: allow to override bench prefix 
Right now, hack/jenkins/dockerized.sh is solely utilized by scheduler perf jenkins job.
There's an effort to extend the scheduler performance suite. In order to run
individual subsuites separately, we need a way to select a subset of benchmark tests
to be run. Golang exposes -bench option which allows to specify a prefix
of benchmark tests to be run.
 2019-12-04 18:45:48 +01:00
Kubernetes Prow Robot
97a4e6683e
Merge pull request #85634 from hwdef/fix-staticcheck14 
pkg/master: Fix static check failures
 2019-12-04 07:18:57 -08:00
Guangming Wang
b304538942 fix staticcheck errors in legacy-cloud-providers/azure 
clean remaining static check errors in legacy-cloud-providers/azure

logging unhandled error in azure_backoff.go

delete unused var and func in azure_vmss_cache.go

run gofmt
 2019-12-04 21:58:26 +08:00
tanjunchen
29eb15c3a8 fix golint check in test/e2e_node/runner/remote 2019-12-04 18:14:52 +08:00
Kubernetes Prow Robot
6d5eee88e0
Merge pull request #84624 from hwdef/fix-staticcheck 
cmd/kube-controller-manager: fix staticcheck warning
 2019-12-04 01:54:57 -08:00
Kubernetes Prow Robot
0f332bae5d
Merge pull request #85853 from SataQiu/fix-staticcheck-20191203 
Fix staticcheck failures of test/e2e/upgrade
 2019-12-03 21:51:18 -08:00
Kubernetes Prow Robot
9acdf52877
Merge pull request #85744 from tanjunchen/fix-golint-problems 
Fix golint issues in test/e2e/lifecycle/
 2019-12-03 19:44:57 -08:00
Kubernetes Prow Robot
fe97fbb2e6
Merge pull request #85071 from hvaara/fix-golint-pkg-apis-batch-validation 
Fix golint issues in pkg/apis/batch/validation
 2019-12-03 17:00:57 -08:00
Kubernetes Prow Robot
bb9981e19f
Merge pull request #85046 from hvaara/fix-golint-pkg-registry--storage 
Fix golint issues in pkg/registry/.../storage
 2019-12-03 15:47:11 -08:00
Jacek Kaniuk
7eb6182a63 Revert "Fix shellcheck failure in log-dump/log-dump.sh" 
This reverts commit e99a325d4e.
 2019-12-03 18:17:54 +01:00
SataQiu
6fcd030877 fix staticcheck failures of test/e2e/upgrade 2019-12-03 23:36:09 +08:00
Kubernetes Prow Robot
716b4549b2
Merge pull request #85749 from SataQiu/golint-e2e-20191129 
Fix golint failures of test/e2e_node/remote
 2019-12-03 06:06:58 -08:00
tanjunchen
d2d68026fc Fix golint issues in test/e2e/lifecycle/ 2019-12-03 17:14:38 +08:00
hwdef
dddd631706 cmd/kube-controller-manager: fix staticcheck warning 2019-12-03 11:16:24 +08:00
Kubernetes Prow Robot
0810bc3386
Merge pull request #85363 from immutableT/encryption-config-defaulter 
Add defaulting and validation logic for EncryptionConfiguration type.
 2019-12-02 17:06:57 -08:00
immutablet
a151aa35dc Add defaulting logic for EncryptionConfiguration. 2019-12-02 13:21:05 -08:00
SataQiu
69aae3aa5a fix golint failures of test/e2e_node/remote 2019-11-29 18:11:55 +08:00
Jordan Liggitt
9a868766ee Enable mutation detection 2019-11-28 02:26:38 -05:00
Kubernetes Prow Robot
2eda47221a
Merge pull request #83604 from k-toyoda-pi/fix_shellcheck_log-dump 
Fix shellcheck failure in cluster/log-dump/log-dump.sh
 2019-11-27 21:03:03 -08:00
Kubernetes Prow Robot
0efe584db6
Merge pull request #85513 from liu-cong/benchmark-fix 
Fix benchmark artifact parsing.
 2019-11-27 16:41:03 -08:00
Kubernetes Prow Robot
c58b63267c
Merge pull request #85562 from gkarthiks/master 
golint fixes for /pkg/util/iptables/testing
 2019-11-27 10:46:45 -08:00
Kubernetes Prow Robot
ef1af14cab
Merge pull request #85172 from c3y1huang/fix/golint_failure/Remove-pkg.registry.apps.replicaset 
Fix golint failures for pkg/registry/apps/replicaset
 2019-11-27 01:09:21 -08:00
Kubernetes Prow Robot
93c2eed3cb
Merge pull request #84901 from SataQiu/golint-e2e-node-20191107 
Fix golint issues in test/e2e_node
 2019-11-26 23:19:21 -08:00
Kubernetes Prow Robot
6a48f55e56
Merge pull request #83714 from tanjunchen/fix-staticcheck-test/e2e/windows 
fix staticcheck  failures in test/e2e/windows
 2019-11-26 19:43:20 -08:00
Kubernetes Prow Robot
b94dca92a8
Merge pull request #85657 from liggitt/bazel-module 
Enable update-bazel.sh outside of GOPATH
 2019-11-26 18:23:20 -08:00
hwdef
e7172b3dbf pkg/master: Fix static check failures 2019-11-27 09:15:57 +08:00
Jordan Liggitt
a8991a108a Enable update-bazel.sh outside of GOPATH 2019-11-26 17:33:57 -05:00
Kubernetes Prow Robot
a82f7cdd5d
Merge pull request #85469 from hwdef/fix-staticcheck12 
test/e2e/apimachinery: fix staticcheck warning
 2019-11-26 12:17:34 -08:00
Cong Liu
016ab0b899 Fix benchmark artifact parsing. 
* Added a extractor to extract raw logs from json format and then pipe
it into benchmark parser.
* Also added -alsologtostderr=false -logtostderr=false to reduce noisy logs.
 2019-11-26 13:47:12 -05:00
hwdef
a0489c6ca8 test/e2e/apimachinery: fix staticcheck warning 2019-11-26 22:07:26 +08:00
SataQiu
d2bdf89a8b fix golint issues in test/e2e_node 2019-11-26 16:26:55 +08:00
Kubernetes Prow Robot
cec566d77a
Merge pull request #85451 from flix-tech/ruben.serradas 
Fix golint issues in pkg/kubelet/events/event.go
 2019-11-25 16:43:10 -08:00
Howard Zhang
09d4d65b1b fix etcd version check error on ARM 
"etcd -version" command output an additional line on ARM platform:
"running etcd on unsupported architecture "arm64" since
ETCD_UNSUPPORTED_ARCH is set"
Currently etcd version filtering code can not get correct version
number.

Signed-off-by: Howard Zhang <howard.zhang@arm.com>
 2019-11-25 20:02:37 +08:00
Lars Lehtonen
b1c39e9b16 apimachinery: Fix Dropped Test Error (#85427) 
* apimachinery: fix dropped test error in pkg/util/net

* apimachinery: fix dropped test error in pkg/runtime/serializer

* apimachinery: fix dropped test error in pkg/conversion

* apimachinery: fix staticcheck warning
 2019-11-23 15:31:50 -08:00
gkarthiks
a4abc1dd4d refactor(golint): lint fixes for iptables test file 
Signed-off-by: gkarthiks <github.gkarthiks@gmail.com>
 2019-11-22 19:58:56 -08:00
Kubernetes Prow Robot
1900edf44a
Merge pull request #85440 from gkarthiks/master 
Fix lint in /pkg/util/iptables
 2019-11-22 17:31:31 -08:00
Guinevere Saenger
81d0007716 Hi San Diego (#85424) 
* removed -staging/src/k8s.io/apimachinery/pkg/util/clock for golint failures

* first few code comments are done

* add correct comments for all packages
 2019-11-22 17:31:13 -08:00
Ian Bull
a232971d73 Add public documentation for kubelet/apis/config 
The `kubelet/apis/config` package had golint failures. This change-set
removes the `kubelet/apis/config` package from the `.golint_failures`
and fixes the golint errors. In particular, this change-set adds
documentation to the public types in the package.

This change-set works towards issue#68026
 2019-11-20 22:52:53 -08:00
Ruben
55c83e3397 Fix golint issues in pkg/kubelet/events/event.go 
Change the single const statement in favor of multiple const event lists.
This way we don't need to put the name of the constant in the comment
and it's clearer that the comment refers to the whole list.
 2019-11-19 13:15:08 +01:00
Karthikeyan Govindaraj
1f4cd65be5
chore(lint): removing the iptables pkg 2019-11-18 23:49:34 -08:00
Travis Rhoden
0c5c3d8bb9
Remove pkg/util/mount (moved out of tree) 
This patch removes pkg/util/mount completely, and replaces it with the
mount package now located at k8s.io/utils/mount. The code found at
k8s.io/utils/mount was moved there from pkg/util/mount, so the code is
identical, just no longer in-tree to k/k.
 2019-11-15 08:29:12 -07:00
tanjunchen
7420faab43 fix-staticcheck in /test/e2e/windows 2019-11-15 09:45:43 +08:00
Kubernetes Prow Robot
bfb99d809a
Merge pull request #85117 from hwdef/fix-staticcheck10 
pkg/kubeapiserver: fix staticcheck warning
 2019-11-14 13:31:15 -08:00
Kubernetes Prow Robot
5c772f5933
Merge pull request #84674 from hwdef/fix-staticcheck4 
pkg/client: fix staticcheck warning
 2019-11-14 13:30:45 -08:00
hwdef
b3377e61de pkg/kubeapiserver: fix staticcheck warning 2019-11-14 11:24:22 +08:00
hwdef
82b9cf1890 pkg/client: fix staticcheck warning 2019-11-14 10:08:16 +08:00
Kubernetes Prow Robot
64f4be5b32
Merge pull request #84390 from robscott/endpointslice-beta 
Promoting EndpointSlices to beta
 2019-11-13 17:27:50 -08:00
Kubernetes Prow Robot
8af6906d1f
Merge pull request #85220 from liggitt/revert-licenses 
Revert #76586, restructure LICENSES file generation
 2019-11-13 14:52:11 -08:00
Kubernetes Prow Robot
d85103b185
Merge pull request #85217 from kaoskater08/kaoskater08/fix-golint-pkg-apis-extensions 
fixed golint errors in pkg/apis/extensions register.go and types.go
 2019-11-13 14:51:46 -08:00
Rob Scott
a7e589a8c6
Promoting EndpointSlices to beta 2019-11-13 14:20:19 -08:00
Kubernetes Prow Robot
f501d8e59a
Merge pull request #85138 from liggitt/webhook-config-v1 
Promote apiserver.config.k8s.io/v1, kind=WebhookAdmissionConfiguration
 2019-11-13 13:03:54 -08:00
Kubernetes Prow Robot
195664db0e
Merge pull request #85099 from liggitt/quota-config-v1 
Promote apiserver.config.k8s.io/v1, kind=ResourceQuotaConfiguration
 2019-11-13 13:02:52 -08:00
Kubernetes Prow Robot
b49afbfa64
Merge pull request #85098 from liggitt/admission-config-v1 
Promote apiserver.config.k8s.io/v1, kind=AdmissionConfiguration
 2019-11-13 13:02:40 -08:00
Kubernetes Prow Robot
6eb2f25247
Merge pull request #85075 from hwdef/fix-staticcheck9 
pkg/credentialprovider: fix staticcheck warning
 2019-11-13 09:27:18 -08:00
Jordan Liggitt
cd4474ae4f Revert "76093 restructure LICENSES file generation" 
This reverts commit d39ac98cc5.
 2019-11-13 10:24:32 -05:00
Eddie Hale
566484366e fixed golint errors in pkg/apis/extensions register.go and types.go 2019-11-13 08:48:42 -06:00
Chin-Ya Huang
92c7e8e802 Fix golint failures 
* Remove pkg/registry/apps/replicaset

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
 2019-11-13 11:00:12 +08:00
Ji Shan Xing
d39ac98cc5 76093 restructure LICENSES file generation 2019-11-12 20:38:57 -05:00
Kubernetes Prow Robot
36373b37fd
Merge pull request #84672 from hwdef/fix-staticcheck2 
cmd:fix staticcheck warning
 2019-11-12 09:06:06 -08:00
Jordan Liggitt
71fad812ca Promote WebhookAdmissionConfiguration to v1 2019-11-12 09:56:58 -05:00
Jordan Liggitt
1234290adf AdmissionConfiguration v1 2019-11-12 09:05:50 -05:00
Jordan Liggitt
7d3012f297 Promote resource quota admission configuration to v1 2019-11-12 09:03:55 -05:00
Kubernetes Prow Robot
897ce3073c
Merge pull request #84533 from davidz627/fix/deprecatedPath 
Remove plugin watching of deprecated directory and CSI v0 support in accordance with deprecation policy
 2019-11-12 04:48:20 -08:00
toyoda
e99a325d4e Fix shellcheck failure in log-dump/log-dump.sh 2019-11-12 16:51:09 +09:00
David Zhu
802fe12803 Remove plugin watching of deprecated directory {kubelet_root_dir}/plugins and support for CSI V0 in accordance with deprecation announcement in https://v1-13.docs.kubernetes.io/docs/setup/release/notes/ 2019-11-11 11:42:58 -08:00
Roy Hvaara
896f84b652
Fix golint issues in pkg/apis/batch/validation 2019-11-11 04:03:34 +01:00
Clayton Coleman
c416ee584c
Remove deprecated-dynamic client 
It is now unused.
 2019-11-10 21:30:30 -05:00
hwdef
170eadc3d2 pkg/credentialprovider: fix staticcheck warning 2019-11-11 09:46:52 +08:00
Kubernetes Prow Robot
35cfd327c8
Merge pull request #84243 from Dingshujie/fix-golint 
Fix golint errors in pkg/apis/apps
 2019-11-10 16:29:54 -08:00
Kubernetes Prow Robot
ebbe4baf13
Merge pull request #83914 from guineveresaenger/ato-demo 
Removes pkg/registry/core/secret/storage from golint failures
 2019-11-10 16:29:41 -08:00
Kubernetes Prow Robot
a18303dfa4
Merge pull request #85042 from hvaara/fix-golint-pkg-apis-policy 
Fix golint issues in pkg/apis/policy
 2019-11-09 15:29:58 -08:00
Kubernetes Prow Robot
80b25a766a
Merge pull request #85037 from hvaara/fix-golint-pkg-apis-authorization 
Fix golint issues in pkg/apis/authorization
 2019-11-09 15:29:48 -08:00
Roy Hvaara
cfc34712c2
Fix golint issues in pkg/registry/.../storage 2019-11-10 00:22:51 +01:00
Roy Hvaara
cfc596b302 Fix golint issues in pkg/apis/autoscaling/validation (#85041) 
* Fix golint issues in pkg/apis/autoscaling/validation

* Fix spelling issue in field of Error
 2019-11-09 14:03:48 -08:00
Kubernetes Prow Robot
a258243f4c
Merge pull request #85009 from oomichi/enable-verify-import-aliases 
Enable verify-import-aliases check in CI
 2019-11-09 12:23:39 -08:00
Roy Hvaara
10c8508acd
Fix golint issues in pkg/apis/policy 2019-11-09 21:15:35 +01:00
Roy Hvaara
8d3c74aebc
Fix golint issues in pkg/apis/authorization 2019-11-09 17:45:37 +01:00
Roy Hvaara
e55fc5656c
Fix golint issues in pkg/util/sysctl/testing 2019-11-09 12:32:37 +01:00
Kubernetes Prow Robot
b15dfd778a
Merge pull request #84708 from yue9944882/feat/flowcontrol-storage 
Feature: Flowcontrol rest storage implementation
 2019-11-08 18:44:09 -08:00
Kubernetes Prow Robot
e4fdb82c01
Merge pull request #84302 from serathius/restrict-prometheus-import 
Restrict visibility of prometheus packages
 2019-11-08 13:48:26 -08:00
Kenichi Omichi
1b165fc440 Enable verify-import-aliases check in CI 
To block violation of import-aliases rule, this enables
verify-import-aliases in CI system.
 2019-11-08 19:17:39 +00:00
yue9944882
3d1b5d0e9a flowcontrol rest storage implementation 2019-11-08 14:27:14 +08:00
Kubernetes Prow Robot
e445d4d779
Merge pull request #84871 from liggitt/cmd-test 
Make test-cmd effective again
 2019-11-07 13:28:21 -08:00
Kubernetes Prow Robot
7a1eaa112e
Merge pull request #84696 from dims/BenTheElder-byebyehacke2e 
Remove hack/e2e.go
 2019-11-07 09:05:04 -08:00
mattjmcnaughton
d30319711e
Fix golint failures for pkg/kubelet/config/... 
Address the final golint failure by adding a comment explaining our
blank import.
 2019-11-07 09:36:22 -05:00
Kubernetes Prow Robot
0a46e374dc
Merge pull request #84772 from hvaara/golint-failures-support-comments 
Support comments in hack/.golint_failures
 2019-11-07 04:36:17 -08:00
Kubernetes Prow Robot
41a70bcc0a
Merge pull request #84750 from hvaara/fix-golint-test-e2e_kubeadm 
Fix golint issues in test/e2e_kubeadm
 2019-11-07 04:36:07 -08:00
Kubernetes Prow Robot
1183771545
Merge pull request #84748 from hvaara/fix-golint-controller-volume-persistentvolume-options 
Fix golint issues in pkg/controller/volume/persistentvolume/options
 2019-11-07 04:35:53 -08:00
Marek Siarkowicz
e7d5659943 Restrict visibility of prometheus to enforce usage of k8s.io/component-base/metrics 2019-11-07 09:12:55 +01:00
Jordan Liggitt
1678f42970 Fix run_kubectl_sort_by_tests 2019-11-07 02:26:45 -05:00
Jordan Liggitt
59dfac587f Fix assert methods 2019-11-07 02:26:45 -05:00
Jordan Liggitt
9f30c783bc bump kazel, bazel, gazelle 
hack/pin-dependency.sh k8s.io/repo-infra v0.0.1-alpha.1
To fix non-idempotent BUILD file generation

hack/pin-dependency.sh github.com/bazelbuild/bazel-gazelle v0.19.0
hack/pin-dependench.sh github.com/bazelbuild/buildtools 0.29.0
for go1.13.3 support

hack/lint-dependencies.sh

hack/pin-dependency.sh github.com/bazelbuild/buildtools v0.0.0-20190917191645-69366ca98f89
to pick up preferred version for repo-infra
 2019-11-06 17:39:05 -05:00
Jordan Liggitt
e3ff39ffa0 Update build to go1.13.4 2019-11-06 17:39:05 -05:00
Jordan Liggitt
ee2b887c74 Fix hack/pin-dependency.sh for go1.13 2019-11-06 17:39:05 -05:00
Jordan Liggitt
8618c09369 opt out of module mode for builds 2019-11-06 17:39:05 -05:00
Roy Hvaara
e16ee0b68e
Support comments in hack/.golint_failures 2019-11-05 22:59:42 +01:00
Kubernetes Prow Robot
8245a24c37
Merge pull request #84761 from thockin/make-better-find-filter 
Build: Use a better filter on find
 2019-11-05 11:44:54 -08:00
feifei.zhang@huawei.com
fdce8ef960 fix golint failures of pkg/security/apparmor 2019-11-05 18:56:15 +08:00
Tim Hockin
a1ad4910dc Build: Use a better filter on find 
In case the _workspace directory exists, filter it out.
 2019-11-04 21:00:58 -08:00
Roy Hvaara
a9ed936792
Fix golint issues in test/e2e_kubeadm 2019-11-04 23:20:24 +01:00
Roy Hvaara
dffcf7c8cd
Fix golint issues in pkg/controller/volume/persistentvolume/options 2019-11-04 21:45:21 +01:00
Kubernetes Prow Robot
7b6369c803
Merge pull request #84249 from odinuge/bump-shellcheck 
Bump shellcheck to v0.7.0
 2019-11-04 06:19:40 -08:00
Benjamin Elder
83c56a0373
remove hack/e2e.go 2019-11-03 19:36:59 -05:00
hwdef
5c6ed21d34 cmd:fix staticcheck warning 2019-11-03 00:00:54 +08:00
Kubernetes Prow Robot
510fb38f27
Merge pull request #83671 from yue9944882/flow-control-api-model 
Apiserver flowcontrol api models
 2019-11-01 22:49:40 -07:00
Kubernetes Prow Robot
df8706e60b
Merge pull request #84408 from mikedanese/cleanup 
delete unused cache
 2019-11-01 18:07:56 -07:00
Jordan Liggitt
b44d7c8d3c Drop version from static openapi json file 2019-11-01 13:35:10 -04:00
Kubernetes Prow Robot
7341803597
Merge pull request #84593 from mm4tt/benchmark_dockerized_gopath 
Don't use hardcoded /go GOPATH in benchmark-dockerized.sh
 2019-10-31 07:39:37 -07:00
Matt Matejczyk
68aebb4899 Don't use hardcoded /go GOPATH in benchmark-dockerized.sh 2019-10-31 13:57:04 +01:00
Kubernetes Prow Robot
ecec5cb2a4
Merge pull request #84540 from seans3/kubectl-get-staging 
Moves kubectl get subcommand to staging
 2019-10-30 21:56:37 -07:00
Kubernetes Prow Robot
5e468a49de
Merge pull request #84478 from hvaara/fix-golint-pkg/credentialprovider/gcp 
Fix golint issues in pkg/credentialprovider/gcp
 2019-10-30 06:38:54 -07:00
Kubernetes Prow Robot
e1d3cc74e5
Merge pull request #84329 from jingyih/update_etcd_server_to_3.4 
Update default etcd server to 3.4.3
 2019-10-30 02:30:52 -07:00
Sean Sullivan
907e3d61ab Fixes staticcheck failures and golint failures 2019-10-29 17:50:23 -07:00
Kubernetes Prow Robot
f8b45a12f4
Merge pull request #84464 from wojtek-t/remove_conversion_funcs_1 
Migrate couple manual conversions to the new AddConversionFunc() way
 2019-10-29 15:39:07 -07:00
Mike Danese
0e69316bb3 delete unused cache 
We aren't using this anywhere and it's not named properly for what it
is. We should either rename it or delete it (both break the package
API).
 2019-10-29 14:40:48 -07:00
Jingyi Hu
ccf4caf30f Update etcd.sh to use v3 endpoint 2019-10-29 13:10:29 -07:00
Kubernetes Prow Robot
a8e819746d
Merge pull request #83442 from serathius/remove-prometheus-addon 
Remove prometheus addon
 2019-10-29 01:34:43 -07:00
yue9944882
7c28a4b70e non-generated api models misc 
rule list

rule

rule 2
 2019-10-29 12:26:12 +08:00
Jingyi Hu
706cde51c5 Update default etcd server to 3.4.3 2019-10-28 18:29:37 -07:00
Roy Hvaara
e40c473334
Fix golint errors in pkg/credentialprovider/gcp 2019-10-28 21:54:45 +01:00
wojtekt
32759d33bf Cleanup conversions 2019-10-28 21:14:20 +01:00
Kubernetes Prow Robot
2896fb0be8
Merge pull request #83711 from tanjunchen/fix-staticcheck-test/e2e/network 
fix staticcheck failures in test/e2e/common directory
 2019-10-26 02:23:22 -07:00
Kubernetes Prow Robot
df8587f99f
Merge pull request #84062 from seans3/tableprinter-move 
Removes kubectl get dependency on Kubernetes core
 2019-10-24 16:55:52 -07:00
Asalle
49207027c6 Fix golint errors 
in staging/src/k8s.io/apiserver/plugin/pkg/authenticator/password
 2019-10-24 21:08:44 +02:00
Kubernetes Prow Robot
98442617cc
Merge pull request #81708 from RainbowMango/pr_fix_static_failure_for_code-generator 
Fix static failure for package: staging/src/k8s.io/code-generator
 2019-10-23 23:25:07 -07:00
Odin Ugedal
d467b8ea14
Fix shellcheck failures SC2128 2019-10-23 22:47:46 +02:00
Odin Ugedal
cce1f32ea5
Fix shellcheck failures SC2034 2019-10-23 22:47:46 +02:00
Odin Ugedal
65a66b9d7f
Bump shellcheck to v0.7.0 
Changelog:
https://github.com/koalaman/shellcheck/blob/master/CHANGELOG.md

We have some new erros due to the version bump.

- SC2034: VARIABLE_XYZ appears unused. Verify use (or export if used externally).
    - Applies to all scripts we source in other scripts
- SC2039: In POSIX sh, set option pipefail is undefined.
    - Applies to files using it with "sh" instead of "bash" in the shebang
- SC2054: Use spaces, not commas, to separate array elements.
    - Fixing Should make no difference in the code
- SC2128: Expanding an array without an index only gives the first element.
    - Fixing Should make no difference in the code
- SC2251: This ! is not on a condition and skips errexit. Use `&& exit 1` instead, or make sure $? is checked.
    - Not 100% sure if we can swap to `&& exit 1`. Applies to a lot of
    test code.

All changes should be straight forward to fix, but will be done in a
separate PR.
 2019-10-23 21:32:19 +02:00
DingShujie
171b486c34 Fix golint errors in pkg/apis/apps 2019-10-23 23:32:08 +08:00
Sean Sullivan
1b40a8849d Ignore staticcheck again for tableprinter.go 2019-10-22 23:45:08 -07:00
Kubernetes Prow Robot
75cd65ae0e
Merge pull request #82145 from shivi28/fix-controller-nodeipam-ipam-cidrset 
nodeipam-controller:fix static check failures
 2019-10-22 23:18:26 -07:00
Cristian Dima
a18de39166 fix golint errors in pkg/controller/service 2019-10-23 01:52:19 +03:00
ianlang
3359577d42 set default value of KUBE_MASTER_URL to empty 2019-10-22 10:08:55 +08:00
Kubernetes Prow Robot
c634276498
Merge pull request #83497 from pivotal-k8s/allow-custom-tags 
Allow users to use custom tags
 2019-10-20 22:17:37 -07:00
Kubernetes Prow Robot
ff7a09928b
Merge pull request #84070 from neolit123/1.17-remove-test-owners-ref 
remove usage of the test/test_owners.* files
 2019-10-19 02:13:36 -07:00
Kubernetes Prow Robot
b574074981
Merge pull request #84055 from odinuge/cherry_pick_indent 
Fix indent in cherry_pick_pull script
 2019-10-18 02:15:58 -07:00
Lubomir I. Ivanov
2c54160021 remove usage of the test/test_owners.* files 
- remove update_owners.py; seems responsible for generating
test_owners files
- remove the existing test/test_owners.* files
- remove verify-test-owners.sh and references to it
 2019-10-18 03:01:21 +03:00
Kubernetes Prow Robot
7ed388caa6
Merge pull request #83744 from neolit123/1.17-move-test-owners-sig-cl-gcp 
test/e2e: move some tests from cluster-lifecycle to cloud-provider-gcp
 2019-10-17 16:33:58 -07:00
Odin Ugedal
b840398be8
Fix indent in cherry_pick_pull script 2019-10-17 17:43:29 +02:00
Kubernetes Prow Robot
4887b0cac2
Merge pull request #84008 from notpad/fix_83985 
Change node name to env value of HOSTNAME_OVERRIDE
 2019-10-17 05:12:37 -07:00
Kubernetes Prow Robot
2eef011c38
Merge pull request #81345 from k-toyoda-pi/fix_shellcheck_validate-cluster 
Fix shellcheck failures in cluster/validate-cluster.sh
 2019-10-17 03:18:38 -07:00
Hongwei Yu
7574f95f7d optimize comments on exported constants (#83875) 
* optimize comments on exported constants

* remove package in hack/.golint_failures are passing golint
 2019-10-16 22:25:30 -07:00
Kubernetes Prow Robot
44674bf5d3
Merge pull request #83969 from yutedz/rm-update-storage 
Remove update-storage-objects.sh
 2019-10-16 11:37:55 -07:00
Kubernetes Prow Robot
d720a2269a
Merge pull request #83802 from seans3/rewrite-printer-tests 
Rewrite printer tests
 2019-10-16 09:33:42 -07:00
notpad
c13f2d4748 Change node name to env value of HOSTNAME_OVERRIDE 2019-10-16 22:39:52 +08:00
Kubernetes Prow Robot
99d40d3d44
Merge pull request #80137 from ialidzhikov/enh/better-naming 
Rename dashboard-controller.yaml to dashboard-deployment.yaml
 2019-10-16 05:51:41 -07:00
Kubernetes Prow Robot
63cf2e260b
Merge pull request #83819 from mrbobbytables/emeritus-jbeda 
Move jbeda to emeritus status.
 2019-10-15 23:06:20 -07:00
Sean Sullivan
30d8a93768 Cleanup printer test package. 
Updates internalversion BUILD file dependencies

Removes pkg/printers/internalversion from staticcheck failures
 2019-10-15 18:13:00 -07:00
Ted Yu
240546cb7f Remove update-storage-objects.sh 2019-10-15 13:13:19 -07:00
Kubernetes Prow Robot
cb3b715de2
Merge pull request #83804 from jpbetz/etcd-3_3_17_server 
Upgrade to etcd server 3.3.17
 2019-10-15 12:50:09 -07:00
ialidzhikov
b3dcbbf98c Rename dashboard-controller.yaml to dashboard-deployment.yaml 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
 2019-10-15 13:55:06 +03:00
guineveresaenger
82123dc261 Removes pkg/registry/core/secret/storage from golint failures 2019-10-14 14:28:32 -04:00
Joe Betz
c92bd5e7b5 Upgrade to etcd server 3.3.17 2019-10-13 17:17:15 -07:00
Lubomir I. Ivanov
db61aaa9d0 update staticcheck_failures 2019-10-12 22:53:09 +03:00
Kubernetes Prow Robot
457fa6b40d
Merge pull request #82413 from zhlhahaha/kube-proxy-error 
local-up-cluster kube-proxy terminated error
 2019-10-12 07:48:37 -07:00
tanjunchen
33dda68788 fix staticcheck in test/e2e/common directory 2019-10-12 11:30:47 +08:00