github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
93,054 Commits 1 Branch 31 Tags 1,019 MiB
479249b3a3
Commit Graph

2827 Commits

Author SHA1 Message Date
Rinat Shigapov
d55f037b7d HPA scale-to-zero for custom object/external metrics 
Add support for scaling to zero pods

minReplicas is allowed to be zero

condition is set once

Based on https://github.com/kubernetes/kubernetes/pull/61423

set original valid condition

add scale to/from zero and invalid metric tests

Scaling up from zero pods ignores tolerance

validate metrics when minReplicas is 0

Document HPA behaviour when minReplicas is 0

Documented minReplicas field in autoscaling APIs
 2019-07-16 08:46:21 -05:00
SataQiu
23b7ae6041 make taint.ToString() consistent with the reverse parsing logic 2019-07-16 21:06:01 +08:00
Kubernetes Prow Robot
3dd8add5d2
Merge pull request #79549 from liggitt/admission-webhooks-v1 
Promote admission webhook API to v1
 2019-07-11 17:01:34 -07:00
Jordan Liggitt
b15aed6409 Generated 2019-07-10 17:38:09 -04:00
Jordan Liggitt
0eeef7c2e6 Add defaulting tests 2019-07-10 17:38:09 -04:00
Jordan Liggitt
2dd7910442 Add mutatingwebhook validation tests 2019-07-10 17:38:09 -04:00
Jordan Liggitt
08b15d32f7 Require webhook names to be unique in v1 2019-07-10 17:38:09 -04:00
Jordan Liggitt
6c3891a25f Remove default admissionReviewVersions in v1, make required in validation 2019-07-10 17:38:09 -04:00
Jordan Liggitt
9dcc722d2e Remove default sideEffects in v1, make required in validation 2019-07-10 17:38:08 -04:00
Jordan Liggitt
7543b2ef55 Change default timeout to 10 seconds 2019-07-10 17:38:08 -04:00
Jordan Liggitt
08433067c3 Change default matchPolicy to Equivalent in v1 2019-07-10 17:38:08 -04:00
Ted Yu
ceceb68cee Remove unintended ampersand in front of in.Current.AverageValue 2019-07-08 10:23:41 -07:00
Jordan Liggitt
e050590182 Change default failurePolicy to Fail in v1 2019-07-08 09:49:29 -04:00
Jordan Liggitt
e24377f190 Install/register v1 admission registration types 2019-07-08 09:49:29 -04:00
Jordan Liggitt
d2a84a5619 Copy v1beta1 to v1 admission registration types 2019-07-08 09:49:29 -04:00
Pingan2017
e94d7b3802 clean up redundant conditiontype OutOfDisk 2019-07-03 14:34:52 +08:00
Khaled Henidak(Kal)
af552ab469 generated items 2019-07-02 22:26:26 +00:00
Khaled Henidak(Kal)
2b77667718 vendor updates 2019-07-02 22:26:26 +00:00
Khaled Henidak(Kal)
54d42e6a65 types modifications + conversion + conversion testing 2019-07-02 15:39:05 +00:00
Kubernetes Prow Robot
64a2be8e44
Merge pull request #79387 from tedyu/cont-helper-early 
Restore early return for podSpecHasContainer
 2019-07-01 15:09:45 -07:00
Kubernetes Prow Robot
9c8827f564
Merge pull request #78914 from liggitt/pod-spec-defaults 
Add tests to detect default changes to podspec and podspectemplate defaults
 2019-06-27 14:11:21 -07:00
Jordan Liggitt
617309cbce Add tests for podspec and podtemplatespec default changes 2019-06-27 12:56:43 -07:00
Johannes M. Scheuermann
94ce517212 Fix typo in network policy ingress rule 2019-06-26 19:27:09 +02:00
Ted Yu
cf7c164ae3 Restore early return for podSpecHasContainer 2019-06-26 14:17:13 +08:00
Kubernetes Prow Robot
22fb6fd174
Merge pull request #77595 from bertinatto/volume_limits 
Volume Scheduling Limits
 2019-06-25 17:01:16 -07:00
Kubernetes Prow Robot
1215aa73d2
Merge pull request #79176 from verb/debug-iterate-containers 
Add helpers for iterating containers in a pod
 2019-06-25 09:32:52 -07:00
Fabio Bertinatto
b90ca5b2a7 Auto-generated code for volume limits API 2019-06-25 16:30:54 +02:00
Fabio Bertinatto
13e30b6342 Add volume limits API changes 2019-06-25 16:30:54 +02:00
Kubernetes Prow Robot
ad095324bf
Merge pull request #79309 from draveness/feature/cleanup-CSIPersistentVolume-feature-gates 
feat: cleanup feature gates for CSIPersistentVolume
 2019-06-25 01:15:03 -07:00
Kubernetes Prow Robot
cff6e42005
Merge pull request #75223 from sjenning/fix-pod-qos-init-containers 
kubelet: include init containers when determining pod QoS
 2019-06-25 01:14:37 -07:00
draveness
8e9472ba79 feat: cleanup feature gates for CSIPersistentVolume 2019-06-25 09:00:12 +08:00
draveness
ca6003bc75 feat: cleanup PodPriority features gate 2019-06-23 11:57:24 +08:00
Lee Verberne
a0b57ad3db Update BUILD files for container helper 2019-06-21 08:32:04 +00:00
Lee Verberne
ee821e2a04 Create helpers for iterating containers in a pod 2019-06-21 08:32:04 +00:00
Eric Ernst
5e09568c8e pod-overhead: autogenerated code updates 
Signed-off-by: Eric Ernst <eric.ernst@intel.com>
 2019-06-18 08:05:35 -07:00
Eric Ernst
2c52cc3412 pod-overhead: add Overhead to RuntimeClass internal type 
Signed-off-by: Eric Ernst <eric.ernst@intel.com>
 2019-06-18 08:05:35 -07:00
Eric Ernst
bcb046a443 pod-overhead: add Overhead to RuntimeClass 
Co-authored-by: Tim Allclair <tallclair@google.com>
Signed-off-by: Eric Ernst <eric.ernst@intel.com>
 2019-06-18 08:05:35 -07:00
Eric Ernst
d0b0c0ae45 pod-overhead: add Overhead to PodSpec internal type 
Update internal PodSpec to make use of Overhead field. Add validation
and validation tests.

Signed-off-by: Eric Ernst <eric.ernst@intel.com>
 2019-06-18 08:05:35 -07:00
Jordan Liggitt
899d00a529 Fix incorrect procMount defaulting 2019-06-10 22:01:54 -04:00
Kubernetes Prow Robot
6e23ef6cdc
Merge pull request #78598 from yastij/revert-75744-runtimeclass-scheduling-api 
Revert "Introduce topology into the runtimeClass API"
 2019-06-01 20:14:16 -07:00
Kubernetes Prow Robot
bada1c6b1e
Merge pull request #78505 from caesarxuchao/dynamic-object-selector 
Adding ObjectSelector to admission webhooks
 2019-06-01 04:45:09 -07:00
Yassine TIJANI
480d5e47b6
Revert "Introduce topology into the runtimeClass API" 2019-05-31 20:49:40 +00:00
Kubernetes Prow Robot
b7fa33ec15
Merge pull request #77703 from ddebroy/inline-mig-1 
API changes to support migration of inline in-tree volumes to CSI
 2019-05-31 12:23:19 -07:00
Kubernetes Prow Robot
82bfa667ed
Merge pull request #76913 from j-griffith/cleaned_enable_pvc_datasource 
Cleaned enable pvc datasource
 2019-05-31 09:30:29 -07:00
Kubernetes Prow Robot
6273a7af1c
Merge pull request #75744 from yastij/runtimeclass-scheduling-api 
Introduce topology into the runtimeClass API
 2019-05-31 07:12:57 -07:00
j-griffith
62a4861c9b fix typo in types.go comment 2019-05-31 06:08:24 -06:00
j-griffith
60d991e59a add comments to validation testcases, and use const in util.go 2019-05-31 06:07:53 -06:00
j-griffith
54154f8ebb rework pvc datasource filter tests 2019-05-31 06:07:53 -06:00
j-griffith
ae4c2a1858 Enable PVC as DataSource for PVC creation 
This enables the ability to specify and existing PVC as a DataSource in
a new PVC Spec (eg "clone" and existing volume).
 2019-05-31 06:07:53 -06:00
j-griffith
a66bb3c63d Update unit tests and feature name 
Update the unit tests to include checks for incorrect APIGroup type in
PVC DataSource and change the name of the feature gate to be more clear:
s/VolumeDataSource/VolumePVCDataSource/
 2019-05-31 06:07:44 -06:00
j-griffith
123f1bac35 Enable PVC as DataSource for PVC creation 
This enables the ability to specify and existing PVC as a DataSource in
a new PVC Spec (eg "clone" and existing volume).
 2019-05-31 06:06:44 -06:00
wangqingcan
52f3380ef3 change preempting to PreemptionPolicy 2019-05-31 12:42:05 +08:00
wangqingcan
5c9438c691 non-preempting-priorityclass 
Co-authored-by: Vallery Lancey <vallery@zeitgeistlabs.io>
Co-authored-by: Tan shanshan <tan.shanshan@zte.com.cn>
 2019-05-31 12:37:07 +08:00
Chao Xu
4f5c47fb99 generated 2019-05-30 16:46:00 -07:00
Chao Xu
70f1b052e3 api 2019-05-30 16:46:00 -07:00
Joe Betz
95fa928ecb Add mutating admission webhook reinvocation 2019-05-30 14:31:09 -07:00
Joe Betz
939a04f0ed codegen: Add mutating admission webhook reinvocation 2019-05-30 14:31:09 -07:00
Joe Betz
55ecc45455 split admissionregistration.v1beta1/Webhook into MutatingWebhook and ValidatingWebhook 2019-05-30 14:31:09 -07:00
Joe Betz
9356561c86 codegen: split admissionregistration.v1beta1/Webhook into MutatingWebhook and ValidatingWebhook 2019-05-30 14:31:09 -07:00
Deep Debroy
df196226c4 Generated code for API changes to support CSI migration of inline volumes 
Signed-off-by: Deep Debroy <ddebroy@docker.com>
 2019-05-30 09:34:53 +00:00
Deep Debroy
c34309acdf API changes to support CSI migration of inline volumes 
Signed-off-by: Deep Debroy <ddebroy@docker.com>
 2019-05-30 09:34:47 +00:00
Vladimir Vivien
8e0cf65310 Enforce pod security policy for CSI inline 2019-05-29 15:38:21 -04:00
Kubernetes Prow Robot
864e5e564a
Merge pull request #78354 from kaleocheng/fix-golint-pkg-apis-abac-latest 
Fix golint issue in pkg/apis/abac/latest
 2019-05-29 09:45:16 -07:00
Kubernetes Prow Robot
d8fd232ea1
Merge pull request #78327 from caesarxuchao/pointer-remainingItemCount 
Make RemainingItemCount a pointer
 2019-05-29 07:59:29 -07:00
Kubernetes Prow Robot
cd9f430941
Merge pull request #78135 from liggitt/webhook-conversion 
Convert to admission webhook-recognized versions
 2019-05-29 00:52:36 -07:00
Kubernetes Prow Robot
3ccb63bb1b
Merge pull request #78385 from thz/externalNameTrailingDot 
Allow trailing dot for service.spec.externalName
 2019-05-28 15:53:49 -07:00
Jordan Liggitt
8504a0e556 generated: AdmissionRegistration changes 2019-05-28 14:26:06 -04:00
Jordan Liggitt
b6fa0f5b0f AdmissionRegistration API changes: MatchPolicy 2019-05-28 14:26:06 -04:00
Jordan Liggitt
0402f677f0 generated: AdmissionReview changes 2019-05-28 14:25:00 -04:00
Jordan Liggitt
7a9ecfd897 AdmissionReview API changes 2019-05-28 14:25:00 -04:00
yameiwang
81d25371e8 fix typo in helpers_test.go 2019-05-28 03:29:38 +08:00
Tobias Hintze
8829efaeb0
Allow trailing dot for service.spec.externalName 2019-05-27 11:28:07 +02:00
Kaleo
e672fb6b6a Fix golint issue in pkg/apis/abac/latest 2019-05-26 16:30:35 +08:00
Chao Xu
369314959c generated 2019-05-24 18:14:53 -07:00
Tim Allclair
2e384858f0 regenerate 2019-05-22 08:48:57 -07:00
Tim Allclair
10c514725b Update types from api review 2019-05-22 08:48:57 -07:00
Seth Jennings
bcfa60d955 kubelet: include init containers when determining pod QoS 2019-05-17 10:57:03 -05:00
Jean Rouge
181706b0f0 Auto-generated changes for Windows GMSA support 
This patch comprises the auto-generated changes for the API changes outlined in
the Windows GMSA KEP
(https://github.com/kubernetes/enhancements/blob/master/keps/sig-windows/20181221-windows-group-managed-service-accounts-for-container-identity.md)
to add GMSA support to Windows workloads.

Signed-off-by: Jean Rouge <rougej+github@gmail.com>
 2019-05-16 15:34:22 -07:00
Jean Rouge
a3e914528a API changes for Windows GMSA support 
This patch comprises the API changes outlined in the Windows GMSA KEP
(https://github.com/kubernetes/enhancements/blob/master/keps/sig-windows/20181221-windows-group-managed-service-accounts-for-container-identity.md)
to add GMSA support to Windows workloads.

It includes validation, as well as dropping fields if the `WindowsGMSA` feature
flag is not set, both with unit tests.

Signed-off-by: Jean Rouge <rougej+github@gmail.com>
 2019-05-16 15:32:59 -07:00
Kubernetes Prow Robot
de6ce5ee16
Merge pull request #69867 from HotelsDotCom/allow-updates-to-pdbs 
Allow updates/patches to pod disruption budgets
 2019-05-14 18:24:17 -07:00
David McCormick
3537eed826 Remove the generation altering code - validate an update for a PDB by running ValidatePodDisruptionBudget only. 2019-05-14 12:25:23 +01:00
David McCormick
5b9e4f1e88 Rebase allow updates to pdbs to latest upstream master 2019-05-14 12:25:22 +01:00
Joe Betz
332d88db1a Generate proto bindings for: Pass {Operation}Option to Webhooks 2019-05-13 23:10:58 -07:00
Joe Betz
140c8c73a6 Pass {Operation}Option to Webhooks 2019-05-13 23:10:52 -07:00
Elisiano Petrini
04f59751ec Fixed spelling in a couple of descriptions 2019-05-11 15:54:09 -04:00
Kubernetes Prow Robot
3e7fa617b3
Merge pull request #77516 from gnufied/implement-resize-secrets 
Add a new field for storing volume expansion secrets
 2019-05-09 17:51:58 -07:00
Hemant Kumar
69393291b6 Add a new field for storing volume expansion secrets 
Fix pv secret visitor tests
Allow SecretRef for resizing to be set if not already set
 2019-05-09 13:53:47 -04:00
Àbéjídé Àyodélé
25df4e69a5 Clean up pkg/apis. 
These are based on recommendation from
[staticcheck](http://staticcheck.io/).
 2019-05-09 15:25:41 +00:00
Kubernetes Prow Robot
09c4e10333
Merge pull request #74021 from andrewsykim/move-features-component-base 
Move feature gate package from k8s.io/apiserver to k8s.io/component-base
 2019-05-08 13:06:34 -07:00
Daniel (Shijun) Qian
5268f69405 fix duplicated imports of k8s code (#77484) 
* fix duplicated imports of api/core/v1

* fix duplicated imports of client-go/kubernetes

* fix duplicated imports of rest code

* change import name to more reasonable
 2019-05-08 10:12:47 -07:00
Andrew Kim
c919139245 update import of generic featuregate code from k8s.io/apiserver/pkg/util/feature -> k8s.io/component-base/featuregate 2019-05-08 10:01:50 -04:00
Kubernetes Prow Robot
9f1b04f906
Merge pull request #77514 from cmluciano/cml/ownernetapi 
organize sig-net-api-{reviewers,approvers} in OWNERS_ALIASES
 2019-05-06 19:18:05 -07:00
Tim Allclair
d419bdfcd9 Validate topology 2019-05-06 18:38:56 -07:00
Kubernetes Prow Robot
aafac3cfca
Merge pull request #77380 from SataQiu/fix-golint-apis-20190503 
Fix golint failures of pkg/apis/scheduling, pkg/apis/storage/util, etc
 2019-05-06 15:30:32 -07:00
Christopher M. Luciano
b785f95130
organize sig-net-api-{reviewers,approvers} in OWNERS_ALIASES 
Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
 2019-05-06 12:04:04 -04:00
Kubernetes Prow Robot
8136cfc512
Merge pull request #75987 from yastij/event-state-deprecation 
deprecate state field of eventSeries on Event API
 2019-05-03 01:02:21 -07:00
SataQiu
ed04c5f459 fix golint failures of pkg/apis/scheduling pkg/apis/storage/util pkg/apis/storage/v1/util pkg/apis/storage/v1beta1/util 2019-05-03 15:54:24 +08:00
Kubernetes Prow Robot
1adaf2cd5b
Merge pull request #77147 from wk8/wk8/win_sec_opts 
Adding a new `WindowsSecurityOptions` struct
 2019-05-02 16:22:44 -07:00
Jordan Liggitt
20ce402214 generated 2019-05-02 12:20:29 -04:00
Jordan Liggitt
38fbcb767d Remove unnecessary custom conversions 2019-05-02 12:17:46 -04:00
Kubernetes Prow Robot
6a48257627
Merge pull request #73795 from tallclair/runtimeclass-psp 
PodSecurityPolicy RuntimeClass support
 2019-05-02 00:46:17 -07:00
Tim Allclair
952c45f654 RuntimeClass PSP API validation 2019-05-01 13:43:41 -07:00
Tim Allclair
57c6eacdcf RuntimeClass PSP API generated files 2019-05-01 13:43:36 -07:00
Tim Allclair
821cb155ab PodSecurityPolicy RuntimeClass API 2019-04-30 16:45:09 -07:00
Kubernetes Prow Robot
a2afe45366
Merge pull request #76991 from yue9944882/chore/cleanup-hub-genclient-tags 
Clean up genclient tags for hub types
 2019-04-30 14:11:12 -07:00
Kubernetes Prow Robot
0f4b666469
Merge pull request #76778 from SataQiu/fix-golint-20190419 
Fix golint failures of pkg/apis/autoscaling
 2019-04-30 01:19:37 -07:00
Kubernetes Prow Robot
4ebe11a6cb
Merge pull request #76110 from DirectXMan12/infra/prune-owners 
Prune directxman12 from metrics/autoscaling OWNERS
 2019-04-29 14:35:36 -07:00
Yassine TIJANI
0f3e9ca700 deprecate count field on Event API 2019-04-28 23:32:50 +02:00
Jean Rouge
03907a3bf6 Auto-gen 
Signed-off-by: Jean Rouge <rougej+github@gmail.com>
 2019-04-26 22:14:47 +00:00
Jean Rouge
d7aa31858e Adding a new WindowsSecurityOptions struct 
As outlined in the KEP at
https://github.com/kubernetes/enhancements/blob/master/keps/sig-windows/20190418-windows-security-context.md
and improvements on it at
https://github.com/kubernetes/enhancements/pull/975

For now this struct is left empty, as discussed in the KEP (see above) and as
previously discussed with Jordan Liggitt.

It will allow adding GMSA and options as well as `RunAsUserName` options; both of which have already been pre-implemented respectively at
https://github.com/kubernetes/kubernetes/pull/75459
and https://github.com/kubernetes/kubernetes/pull/73609; and both of which
will need to be re-based to make use of the new struct.

Signed-off-by: Jean Rouge <rougej+github@gmail.com>
 2019-04-26 14:19:40 -07:00
Kubernetes Prow Robot
a2b50cdc9a
Merge pull request #77033 from guineveresaenger/guin-lint 
Remove golint failures from pkg/apis/admissionregistration
 2019-04-25 16:10:50 -07:00
guineveresaenger
fa0c81cbd1 Remove golint failures from pkg/apis/admissionregistration 
Adds test/integration/apiserver/admissionwebhook to golint_failures; it is failing on kubernetes/master currently
 2019-04-25 12:20:52 -07:00
Yassine TIJANI
a7ca6fa728 update gofmt 2019-04-25 20:50:26 +02:00
Kubernetes Prow Robot
20b76a2b4a
Merge pull request #77002 from SataQiu/fix-golint-apis-networking 
Fix golint failures of pkg/apis/networking
 2019-04-24 18:13:18 -07:00
Kubernetes Prow Robot
7a5bc7c3ad
Merge pull request #76972 from egernst/runtimeclass-fixup 
runtimeclass: update type description to beta
 2019-04-24 18:12:56 -07:00
Eric Ernst
3ebb8ddd8a runtime-class: update type description to indicate beta 
Signed-off-by: Eric Ernst <eric.ernst@intel.com>
 2019-04-24 09:09:33 -07:00
SataQiu
73ec7ad2d6 fix golint failures of pkg/apis/networking 2019-04-24 18:08:18 +08:00
yue9944882
71a58de48b clean up genclient tags for hub types 2019-04-24 16:53:21 +08:00
SataQiu
853c33358a fix golint failures of pkg/apis/autoscaling 2019-04-24 15:13:01 +08:00
Kubernetes Prow Robot
2a3d307fb9
Merge pull request #76765 from SataQiu/fix-golint-apis-20190418 
Fix golint failures of pkg/apis/authorization
 2019-04-23 22:10:00 -07:00
Tim Allclair
d2a87d5afc Clean up RuntimeClass Topology documentation 2019-04-23 17:06:09 -07:00
Kubernetes Prow Robot
3488cd346a
Merge pull request #76804 from SataQiu/fix-apis-golint-20190419 
Fix golint failures of pkg/apis/batch
 2019-04-22 09:23:46 -07:00
Yassine TIJANI
3285db8649 add output topology 2019-04-20 02:40:10 +02:00
Yassine TIJANI
02288bc34f reuse autoconversion 2019-04-20 01:52:00 +02:00
Kubernetes Prow Robot
29163600fe
Merge pull request #76796 from dims/remove-unused-methods 
Remove unused code
 2019-04-19 11:09:55 -07:00
Davanum Srinivas
7b8c9acc09
remove unused code 
Change-Id: If821920ec8872e326b7d85437ad8d2620807799d
 2019-04-19 08:36:31 -04:00
SataQiu
61478c04d8 fix golint failures of pkg/apis/batch 2019-04-19 18:04:54 +08:00
Kubernetes Prow Robot
f3ec8f0d99
Merge pull request #76546 from HotelsDotCom/kep/VolumeSubpathEnvExpansion-Beta 
Beta upgrade for feature gate VolumeSubpathEnvExpansion
 2019-04-19 01:05:56 -07:00
SataQiu
aa60494209 fix golint failures of pkg/apis/authorization 2019-04-19 04:06:06 +08:00
Kevin Taylor
bb5b4ad0b2 Beta upgrade for feature date VolumeSubpathEnvExpansion 2019-04-17 07:41:00 +01:00
Kubernetes Prow Robot
90b9ccf7f4
Merge pull request #74447 from WanLinghao/builder_ptr_replace 
Remove and replace ptr functions
 2019-04-16 16:19:38 -07:00
SataQiu
556ff16b0d fix golint failures of pkg/apis/core/helper 2019-04-16 07:21:20 +08:00
Yassine TIJANI
e39d18f0c0 introduce topology into the runtimeClass API 2019-04-16 01:12:12 +02:00
WanLinghao
d0138ca3fe This commit does two things in pkg package: 
1. Remove unused ptr functions.
2. Replace ptr functions with k8s.io/utils/pointer
 2019-04-09 10:56:35 +08:00
Mehdy Bohlool
c1076ba05a Fix API documentation, 'Port' to 'port' 2019-04-08 00:29:04 -07:00
Mehdy Bohlool
864cf3e33a Generated files 2019-04-08 00:29:04 -07:00
Mehdy Bohlool
11f37d757f Add port to ServiceResolvers 2019-04-08 00:19:52 -07:00
Mehdy Bohlool
404e2f7a30 Add port to ServiceReference of Admission Webhooks, ConversionWebhooks and AuditSync with defaulter and validator 2019-04-08 00:18:36 -07:00
Bobby (Babak) Salamat
8574e3e3f4 Use Scheduling V1 API instead of Scheduling v1beta1 2019-04-05 14:21:45 -07:00
Nikhita Raghunath
8a6449d16f Update deepcopy files with fixed distinction between 1st and 2nd comment block 
Ref: https://github.com/kubernetes/kubernetes/pull/71027
 2019-04-05 01:03:12 +05:30
Solly Ross
837976cb59 Prune directxman12 from metrics/autoscaling OWNERS 
Since I'm not really working on metrics or autoscaling stuff any more, I
figured it was time to remove myself from the approvers list.
 2019-04-03 16:24:51 -07:00
Humble Chirammal
ee9079f8ec Use better variable names in validation.go 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2019-04-01 09:43:36 +05:30
SataQiu
f82fb4059d fix some failures in pkg/apis 2019-03-23 12:20:49 +08:00
Kubernetes Prow Robot
6dc73a88d5
Merge pull request #75321 from ymlong/fix-2019031302 
Correcting some spelling errors
 2019-03-20 09:53:37 -07:00
Kubernetes Prow Robot
2f298724e2
Merge pull request #75083 from chi-xu/fix-20190307 
change an to a
 2019-03-20 09:52:58 -07:00
Kubernetes Prow Robot
9c5be7aa5f
Merge pull request #74686 from zhouhaibing089/add-trailing-period 
validation: allow trailing period in dns search
 2019-03-19 20:15:06 -07:00
ymlong
58f8c0207d Correcting some spelling errors 2019-03-13 15:00:32 +08:00
Vladimir Vivien
d998fc8f0f CSI Inline Volume - Generated files 2019-03-08 12:39:58 -05:00
Vladimir Vivien
4ec7d2305d CSI Inline Volume - API changes 2019-03-08 12:35:07 -05:00
Kubernetes Prow Robot
e318642946
Merge pull request #74998 from mbohlool/pippin 
Webhook configurations can choose which version of Review request they accept
 2019-03-08 03:01:26 -08:00
Kubernetes Prow Robot
183e6cc190
Merge pull request #74433 from tallclair/runtimeclass-internal 
Migrate RuntimeClass from a CRD to an internal API
 2019-03-07 21:19:30 -08:00
Mehdy Bohlool
cbe00023c0 Update generated files 2019-03-07 21:00:29 -08:00
David Zhu
41b3579345 Address review comments 2019-03-07 17:17:09 -08:00
Mehdy Bohlool
f7dff4725f Add AdmissionReviewVersions to admissionregistration and default it 2019-03-07 15:02:16 -08:00
David Zhu
7d2f4e97b8 Add ADC Fallback if Node doesn't have driver installed 2019-03-07 14:47:38 -08:00
Tim Allclair
428e9fa329 generated files 2019-03-07 11:57:12 -08:00
Tim Allclair
820a1dc96b Add node.k8s.io/v1beta1 API 2019-03-07 11:57:12 -08:00
Tim Allclair
63f61a6714 Migrate RuntimeClass to internal API 2019-03-07 11:07:54 -08:00
Kubernetes Prow Robot
b7bf26abc1
Merge pull request #74713 from WanLinghao/duplicate_package 
Remove duplicate package import
 2019-03-06 22:54:57 -08:00
xuchi
93983289ad change an to a 2019-03-07 10:34:00 +08:00
Kubernetes Prow Robot
8b052158c7
Merge pull request #74477 from liggitt/webhook-admission-scope 
Webhook admission scope
 2019-03-05 21:42:11 -08:00
Jordan Liggitt
1d4655c8ef generated files 
Change-Id: I5a43a4e1a601b85d21b551fcfc9fdbd16a095d06
 2019-03-05 00:30:12 +00:00
Jordan Liggitt
0797d81222 Add scope restrictions to webhook admission rules 2019-03-05 00:30:12 +00:00
Xing Yang
ba4ccfa8b1 Add review comments in the APIs 2019-03-02 18:40:22 -08:00
Xing Yang
743d3a26e9 Add generated files 2019-03-02 12:31:05 -08:00
Xing Yang
bb45b8ee34 Make CSINodeInfo and CSIDriver Core APIs 
This PR is the first step to transition CSINodeInfo and CSIDriver
CRD's to in-tree APIs. It adds them to the existing API group
“storage.k8s.io” as core storage APIs.
 2019-03-02 12:31:05 -08:00
WanLinghao
cb9da96cc9 Remove duplicate package import 2019-02-28 16:26:20 +08:00
zhouhaibing089
68beadefe4 validation: allow trailing period in dns search 
The trailing period tells the resolver to stop immediately instead
of trying recursively. With that said, trailing period should be
acceptable in searches.
 2019-02-27 14:21:52 -08:00
Kubernetes Prow Robot
218642e84e
Merge pull request #74562 from roycaihw/feat/admission-webhook-timeout 
admission webhook: timeout configuration
 2019-02-26 23:40:44 -08:00
Haowei Cai
1a25ced1c7 generated 2019-02-26 15:00:35 -08:00
Haowei Cai
ad0d523d6e tests 2019-02-26 14:44:31 -08:00
Haowei Cai
1cd9162c15 default and validation 2019-02-26 14:41:43 -08:00
Haowei Cai
609527a015 webhook timeout API change 2019-02-26 14:39:28 -08:00
Kubernetes Prow Robot
3f605a2337
Merge pull request #74285 from mourya007/selinux 
Adding Selinux test in validation
 2019-02-26 14:07:33 -08:00
SataQiu
09ba08f8f4 fix some golint failures for pkg/apis/... 2019-02-25 18:06:08 +08:00
Kubernetes Prow Robot
3afa003126
Merge pull request #73555 from bsalamat/priority_to_ga 
Graduate PriorityClass API to GA
 2019-02-22 16:14:49 -08:00
Bobby (Babak) Salamat
1dac6d03e3 generated files 2019-02-22 10:51:15 -08:00
Bobby (Babak) Salamat
453498fe2c Graduate PriorityClass to GA 2019-02-22 10:51:13 -08:00
Kubernetes Prow Robot
f08b2b8864
Merge pull request #74160 from mikedanese/updatedoc 
clarify PreStop hook intended behavior in doc
 2019-02-21 17:47:28 -08:00
Kubernetes Prow Robot
b9565bc98b
Merge pull request #73439 from cceckman/object 
Fix typo, and note BoundObjectRef isn't always checked
 2019-02-21 16:27:33 -08:00
Mike Danese
729ed4e67d clarify PreStop hook intended behavior in doc 2019-02-21 11:19:00 -08:00
Kubernetes Prow Robot
7d75b73e1d
Merge pull request #74057 from liggitt/ingress-network-v1beta1 
Ingress extensions/v1beta1 -> networking.k8s.io/v1beta1
 2019-02-21 01:07:48 -08:00
Jordan Liggitt
f139218ac0 generated files 2019-02-20 23:32:46 -05:00
Kubernetes Prow Robot
5bfea15e7b
Merge pull request #71351 from HotelsDotCom/kep/VolumeSubpathEnvExpansion 
kep/VolumeSubpathEnvExpansion
 2019-02-20 14:05:20 -08:00
Jordan Liggitt
8c28d3f63c Add networking.k8s.io/v1beta1 Ingress 2019-02-20 16:41:14 -05:00
Jordan Liggitt
6c0b1b87f0 generated files 2019-02-20 16:41:14 -05:00
Jordan Liggitt
47cb9559be Move internal Ingress type from extensions to networking 2019-02-20 16:41:12 -05:00
mourya007
3eada575b3 Adding Selinux test in validation 2019-02-20 11:33:59 +05:30
Kevin Taylor
a64b854137 Implementation of KEP Feature Gate VolumeSubpathEnvExpansion 2019-02-20 01:37:16 +00:00
Kubernetes Prow Robot
f09848a301
Merge pull request #74110 from smarterclayton/fix_apitypo 
api: Correct a typo in the API docs for rolling update strategy
 2019-02-19 15:05:39 -08:00
Kubernetes Prow Robot
7fb16d9a8d
Merge pull request #74045 from xichengliudui/fixgolint 
Fix golint failures on cmd/apis/extensions/...
 2019-02-19 09:55:44 -08:00
Kubernetes Prow Robot
de2ceac50d
Merge pull request #74124 from truongnh1992/fix-typo 
Correcting error on source codes
 2019-02-18 20:16:46 -08:00
Kubernetes Prow Robot
7a5ea30b3d
Merge pull request #73961 from mattjmcnaughton/mattjmcnaughton/clarify-NetworkPolicy-policyTypes-in-docs 
Clarify NetworkPolicy policyTypes in docs
 2019-02-18 20:16:25 -08:00
Clayton Coleman
a5ba311260
api: Correct a typo in the API docs for rolling update strategy 2019-02-18 22:46:37 -05:00
Kubernetes Prow Robot
16e08f3e53
Merge pull request #73408 from Klaven/component-base-flags 
Move flag util pkgs to k8s.io/component-base/cli
 2019-02-15 16:46:08 -08:00
Kubernetes Prow Robot
fbee96d733
Merge pull request #73699 from pivotal-k8s/doc-links 
Update deprecated and broken links
 2019-02-15 14:05:09 -08:00
Marek Counts
7744f90830 Moved flag and globalflag 
Moved all flag code from `staging/src/k8s.io/apiserver/pkg/util/[flag|globalflag]` to `component-base/cli/[flag|globalflag]` except for the term function because of unwanted dependencies.
 2019-02-15 10:28:13 -05:00
Kubernetes Prow Robot
928bb2b993
Merge pull request #73262 from jimmy-zh/optimize-PV-AccessMode-comment 
Optimize PersistentVolumeAccessMode comment
 2019-02-15 06:40:14 -08:00
Ben Moss
34ac4d9ee9 Update deprecated links 2019-02-15 09:13:07 -05:00
Nguyen Hai Truong
34961dc16c trivial fix typo: resouce -> resource 
Although it is spelling mistakes, it might make an affects while reading.

Signed-off-by: Nguyen Hai Truong <truongnh@vn.fujitsu.com>
 2019-02-15 02:05:28 -08:00
Kubernetes Prow Robot
9f3b4b588d
Merge pull request #70521 from wenjun93/test 
minor fix type missing
 2019-02-15 01:36:29 -08:00
Kubernetes Prow Robot
808f2cf0ef
Merge pull request #72525 from justinsb/owners_should_not_be_executable 
Remove executable file permission from OWNERS files
 2019-02-14 23:55:45 -08:00
mattjmcnaughton
41f05222e1 Clarify NetworkPolicy policyTypes in docs 
Update the NetWorkPolicy `policyTypes` definition in the spec documentation so its
clear there are only three options: "Ingress", "Egress", and
"Ingress,Egress".
 2019-02-14 09:28:50 -05:00
xichengliudui
a89ee493dd Fix golint failures on cmd/apis/extensions/... 2019-02-12 12:39:48 -05:00
Nikolaos Moraitis
c7e103fd44 apis:core:validation: remove unused, changes to idiomatic go 2019-02-09 18:07:18 +01:00
Kubernetes Prow Robot
5b7a790d35
Merge pull request #72185 from dcbw/owners-label-sig-network 
OWNERS: add label:sig/network to a bunch of places
 2019-02-08 10:36:16 -08:00
Kubernetes Prow Robot
b50c643be0
Merge pull request #73540 from rlenferink/patch-5 
Updated OWNERS files to include link to docs
 2019-02-08 09:05:56 -08:00
Kubernetes Prow Robot
8d8157f490
Merge pull request #73809 from mourya007/validation_test 
Add missing testcases
 2019-02-07 11:47:07 -08:00
mourya007
90b9808681 Add missing testcases 2019-02-07 11:14:53 +05:30
Kubernetes Prow Robot
152b09ac55
Merge pull request #73774 from liggitt/SCTPSupport 
Ensure conditional validation has knowledge of old and new object
 2019-02-06 17:35:17 -08:00
Jordan Liggitt
34ac165a44 Move conditional validation for SCTPSupport to validation functions with knowledge of old objects 2019-02-05 23:09:31 -05:00
Kubernetes Prow Robot
70e8d092a0
Merge pull request #73766 from liggitt/hugepages-cleanup 
Remove HugePages feature gate check in validation
 2019-02-05 19:06:56 -08:00
Kubernetes Prow Robot
017d87dd20
Merge pull request #73657 from krmayankk/service-account 
add positive ut for service account projection
 2019-02-05 15:14:50 -08:00
Jordan Liggitt
d2dbd3997b Remove HugePages feature gate check in validation 2019-02-05 17:36:24 -05:00
Kubernetes Prow Robot
dc1244c6cd
Merge pull request #72785 from derekwaynecarr/hugepages-ga 
Graduate HugePages feature to GA
 2019-02-05 13:56:51 -08:00
Kubernetes Prow Robot
f3a6dbceb2
Merge pull request #68925 from casusbelli/fix_65312 
Adding Quobyte Tenant to QuobyteVolumeSource to enable deletion of persistent volumes
 2019-02-05 12:08:37 -08:00
Antoine Pelisse
fcd4985ce4 Fix SubjectAccessReview Validation with ManagedFields 2019-02-04 13:51:49 -08:00
Roy Lenferink
b43c04452f Updated OWNERS files to include link to docs 2019-02-04 22:33:12 +01:00
Mayank Kumar
b03d0e31ad add positive ut for service account projection 2019-02-02 01:15:13 -08:00
Derek Carr
deae071d78 Graduate HugePages feature to GA 2019-02-02 00:21:10 -05:00
Kubernetes Prow Robot
30566b990a
Merge pull request #73645 from andrewsykim/remove-dep-node-addresses 
move AddToNodeAddresses to k8s.io/cloud-provider/node/helpers
 2019-02-01 18:29:29 -08:00
Kubernetes Prow Robot
235b32e8ad
Merge pull request #72832 from MrHohn/pod-dns-config-ga 
Graduate CustomPodDNS feature to GA
 2019-02-01 18:29:17 -08:00
Charles Eckman
e6c26da886
Address comment on TokenReview 2019-02-01 16:49:51 -08:00
Charles Eckman
48f7f6fb67
Fix typo, and note when BoundObjectRef isn't checked 
- s/objet/object/
- A relying party (validating a token) may not have access to the
  resource named in the `BoundObjectRef`; only the API server can be asserted to
  have access.
  Note this in the field's documentation.
 2019-02-01 16:49:46 -08:00
Andrew Kim
369fd95a9f move AddToNodeAddresses to k8s.io/cloud-provider/node/helpers 
Co-authored-by: Weibin Lin <linweibin1@huawei.com>
 2019-02-01 14:47:07 -05:00
Kubernetes Prow Robot
2da120b086
Merge pull request #73066 from humblec/validation 
Better documented exported functions and variables
 2019-01-25 15:27:58 -08:00
Jimmy Zhang
28528fd4d8 optimize PersistentVolumeAccessMode comment 2019-01-24 18:18:06 +08:00
Jordan Liggitt
1a15d80967 generated 2019-01-23 16:34:44 -05:00
Jordan Liggitt
dc1fa870bf Remove alpha InitializerConfiguration types, Initializers admission plugin 2019-01-23 11:37:39 -05:00
Silvan Kaiser
cc71b0aebd Adding Tenant to QuobyteVolumeSource 
Adds the tenant id to the QuobyteVolumeSource type and
updates the quobyte api client to support looking up
volume ids.
 2019-01-22 14:42:12 +01:00
Humble Chirammal
602c3eb0e6 Better documented exported functions and variables 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2019-01-18 15:08:25 +05:30
wenjgao
01d4ccacc9 minor fix type missing 2019-01-12 19:28:01 +08:00
Justin SB
dd19b923b7
Remove executable file permission from OWNERS files 2019-01-11 16:42:59 -08:00
Kubernetes Prow Robot
52d4500f23
Merge pull request #72714 from mourya007/features_gate 
Move TokenRequestProjection feature gate out of validation
 2019-01-11 15:53:51 -08:00
Zihong Zheng
f2750dd043 Graduate CustomPodDNS feature to GA 2019-01-11 11:28:26 -08:00
Rajath Agasthya
da6c97f710 Remove ExpandPersistentVolumes feature gate from validation 
Drops new PV Status.Conditions if old PV Status.Conditions was not set.
 2019-01-10 12:43:20 -08:00
mourya007
d0b35d1b05 Move TokenRequestProjection feature gate out of validation 2019-01-11 00:49:30 +05:30
Rajath Agasthya
5de2d7694d Remove Sysctls feature gate from validation 2019-01-09 18:56:11 -08:00
Kubernetes Prow Robot
49891cc270
Merge pull request #72698 from rajathagasthya/podsharepsnamespace-72651 
Move PodShareProcessNamespace feature gate out of validation
 2019-01-09 07:40:00 -08:00
Rajath Agasthya
86165ac878 Move pod ReadinessGates feature gate out of validation 2019-01-08 21:37:43 -08:00
Kubernetes Prow Robot
45b54f5c44
Merge pull request #72686 from sbezverk/PersistentLocalVolumes 
Moving PersistentLocalVolumes feature gate check from validation
 2019-01-08 19:22:40 -08:00
Kubernetes Prow Robot
3035edcc36
Merge pull request #72666 from rajathagasthya/pvc-72651 
Move VolumeSnapshotDataSource feature gate check from validation
 2019-01-08 19:22:30 -08:00
Rajath Agasthya
4e1d4caa8f Move PodShareProcessNamespace feature gate out of validation 2019-01-08 14:31:51 -08:00
Serguei Bezverkhi
8915e90398 PersistentLocalVolumes validation and tests 
Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com>
 2019-01-08 11:00:29 -05:00
Kubernetes Prow Robot
8728ecc27d
Merge pull request #72664 from sbezverk/ResourceQuotaScopeSelectors 
Move ResourceQuotaSelector out of validation
 2019-01-08 02:02:59 -08:00
Serguei Bezverkhi
d79475c801 add ResourceQuotaSelector validation and tests 
Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com>
 2019-01-07 23:15:39 -05:00
Rajath Agasthya
88abcb7419 Move VolumeSnapshotDataSource feature gate check from validation 2019-01-07 20:02:01 -08:00
Jordan Liggitt
cd4f626f66 Move AppArmor feature-gate checking out of validation 2019-01-07 15:10:11 -05:00
Jordan Liggitt
c5dfe6b612 Update feature-gate handling of TTLSecondsAfterFinished 2018-12-29 19:36:43 -05:00
Kubernetes Prow Robot
43f0423de6
Merge pull request #72419 from liggitt/allowed-proc-mount-validation 
Validate PSP allowedProcMountTypes
 2018-12-29 13:41:11 -08:00
Serguei Bezverkhi
e61b76fb8c node config_source 
Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com>
 2018-12-29 13:19:37 -05:00
Jordan Liggitt
cb76da9fd7 Validate PSP allowedProcMountTypes 2018-12-29 00:18:01 -05:00
Kubernetes Prow Robot
456ffa0453
Merge pull request #72375 from sbezverk/containers_volumedevices 
VolumeDevices validation and tests
 2018-12-27 17:39:05 -08:00
Kubernetes Prow Robot
66bf481114
Merge pull request #72382 from liggitt/volumescheduling-ga 
Stop checking VolumeScheduling feature gate
 2018-12-27 15:54:18 -08:00
Jordan Liggitt
73dcfe12da Stop checking VolumeScheduling feature gate 2018-12-27 17:45:45 -05:00
Serguei Bezverkhi
5bf84db713 VolumeDevices validation and tests 
Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com>
 2018-12-27 17:31:10 -05:00
Serguei Bezverkhi
4ad98db3c0 EmptyVolume SizeLimit validation and tests 
Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com>
 2018-12-27 13:07:26 -05:00
Kubernetes Prow Robot
d61286987d
Merge pull request #72251 from sbezverk/VolumeMode 
VolumeMode - Update DropDisabled[Alpha]Fields behaviour
 2018-12-26 16:20:36 -08:00
Kubernetes Prow Robot
52b6b4086f
Merge pull request #72250 from sbezverk/AllowVolumeExpansion 
AllowVolumeExpansion validation and tests
 2018-12-26 16:20:24 -08:00
Serguei Bezverkhi
a5d5a174af VolumeMode Validation and tests 
Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com>
 2018-12-26 14:28:53 -05:00
Serguei Bezverkhi
587c5d7263 PodPriority validation and tests 
Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com>
 2018-12-22 08:54:40 -05:00
Kubernetes Prow Robot
91b81544d3
Merge pull request #72213 from sbezverk/containers_procmount 
ProcMount - Update DropDisabled[Alpha]Fields behaviour
 2018-12-21 11:28:57 -08:00
Kubernetes Prow Robot
5354f8bdfe
Merge pull request #72239 from wojtek-t/v1_lease_api 
Promote Lease API to v1
 2018-12-21 10:03:36 -08:00
Serguei Bezverkhi
082f23ab1b AllowVolumeExpansion validation and tests 
Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com>
 2018-12-20 17:04:47 -05:00
Serguei Bezverkhi
0050a649f0 Generated files 
Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com>
 2018-12-20 14:43:52 -05:00
Serguei Bezverkhi
1778d64a59 ProcMount validation and testing 
Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com>
 2018-12-20 14:43:52 -05:00
wojtekt
9664779bdd Autogenerated code 2018-12-20 20:22:11 +01:00
Kubernetes Prow Robot
b2a0315bf5
Merge pull request #72184 from sbezverk/RuntimeClassName_field 
RuntimeClassName - Update DropDisabled[Alpha]Fields behaviour
 2018-12-20 10:52:53 -08:00
wojtekt
73d14dede6 Promote Lease API to v1 2018-12-20 15:39:57 +01:00
Serguei Bezverkhi
27a8967555 RuntimeClass validation and tests 
Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com>
 2018-12-19 15:01:28 -05:00
Jordan Liggitt
fd9e9b01b1 Remove uses of extensions/v1beta1 clients 2018-12-19 11:18:53 -05:00
Dan Williams
2e339188ed OWNERS: add label:sig/network to a bunch of places 2018-12-19 00:00:02 -06:00
Jordan Liggitt
901ddba812 Pass new and old object to DropDisabledFields 2018-12-18 17:50:22 -05:00
Jordan Liggitt
88284f637b Rename DropDisabledAlphaFields to DropDisabledFields 2018-12-18 17:45:37 -05:00
Jordan Liggitt
c4a0254201 remove subpath feature validation failure 2018-12-18 10:21:22 -05:00
Kubernetes Prow Robot
809eaa7025
Merge pull request #71744 from yue9944882/fixes-autoscaling-conversion 
Fixes nil pointer panic on autoscaling types conversion
 2018-12-05 13:01:27 -08:00
zuoxiu.jm
e85924e164 fixes autoscaling types conversion 2018-12-05 23:53:03 +08:00
k8s-ci-robot
79e5cb2cb7
Merge pull request #71302 from liggitt/verify-unit-test-feature-gates 
Split mutable and read-only access to feature gates, limit tests to readonly access
 2018-11-29 21:45:12 -08:00
k8s-ci-robot
9829585260
Merge pull request #70847 from krmayankk/active-dead 
fix error type when using activeDeadlineSeconds with RS/RC
 2018-11-29 19:04:36 -08:00
Jordan Liggitt
2498ca7606 drop VerifyFeatureGatesUnchanged 2018-11-21 11:51:33 -05:00
Jordan Liggitt
70ad4dff48 Fix unit tests calling SetFeatureGateDuringTest incorrectly 2018-11-21 11:51:33 -05:00
Jordan Liggitt
4dca07ef7e Fixup incorrect use of DefaultFeatureGate.Set in tests 2018-11-21 11:51:33 -05:00
Jan Safranek
0c4b89fad6 Fix typo 2018-11-19 15:28:14 +01:00
k8s-ci-robot
ec2e767e59
Merge pull request #71167 from msau42/block-beta 
Promote raw block volume support to beta
 2018-11-16 20:28:03 -08:00
Mike Danese
162699ca30 autogenerated 2018-11-16 17:54:33 -05:00
Mike Danese
04837fdef1 authn: add Audiences to TokenReview 2018-11-16 17:54:33 -05:00
Matthew Wong
9bbf768ad6 Fix BlockVolume feature gate toggling in validation & defaults unit tests 2018-11-16 13:38:59 -05:00
Matthew Wong
dd517c9ff2 Update all tests to account for BlockVolume enabled by default 2018-11-16 13:38:59 -05:00
Matthew Wong
2ff98f7832 Promote BlockVolume to beta 2018-11-16 13:38:59 -05:00
Jordan Liggitt
248d661327 Add tests to ensure storage feature gate changes don't escape packages 2018-11-16 10:52:53 -05:00
Jordan Liggitt
358c092abe fix storage unit tests leaking feature flag changes 2018-11-16 10:52:52 -05:00
Michelle Au
fd64c08240 Fix storage feature gate test setting 2018-11-16 10:49:40 -05:00
Jordan Liggitt
eaff4fd4d2 Tolerate existing CSI fields in PVs when the feature is disabled 2018-11-14 17:57:54 -05:00
Jan Safranek
8cfce0af99 Tighten up validation of VolumeAttachment fields 2018-11-14 16:46:59 +01:00
Michelle Au
498cd61f41 Add volumeattachment status subresource 2018-11-14 14:01:16 +01:00
Jan Safranek
e95b188656 Generated files 2018-11-14 14:01:16 +01:00
Jan Safranek
633431c38a Promote CSIPersistentVolumeSource to GA 2018-11-14 14:01:16 +01:00
Davanum Srinivas
954996e231
Move from glog to klog 
- Move from the old github.com/golang/glog to k8s.io/klog
- klog as explicit InitFlags() so we add them as necessary
- we update the other repositories that we vendor that made a similar
change from glog to klog
  * github.com/kubernetes/repo-infra
  * k8s.io/gengo/
  * k8s.io/kube-openapi/
  * github.com/google/cadvisor
- Entirely remove all references to glog
- Fix some tests by explicit InitFlags in their init() methods

Change-Id: I92db545ff36fcec83afe98f550c9e630098b3135
 2018-11-10 07:50:31 -05:00
Mayank Kumar
57d6650339 fix error type when using activeDeadlineSeconds with RS/RC 2018-11-09 14:25:15 -08:00
k8s-ci-robot
040cc281f4
Merge pull request #70469 from WanLinghao/audit_validation_fix 
fix auditsink validation output
 2018-11-08 08:44:18 -08:00
k8s-ci-robot
3c10143967
Merge pull request #60195 from humblec/glusterfs-pvspec-3 
Refactor GlusterFS PV spec.
 2018-11-08 00:24:39 -08:00
Humble Chirammal
bdb051c72d Refactor GlusterFS PV spec. 
This patch introduces glusterfsPersistentVolumeSource addition
to glusterfsVolumeSource. All fields remains same as glusterfsVolumeSource
with an addition of a new field
called `EndpointsNamespace` to define namespace of endpoint in the
spec.

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2018-11-06 15:51:01 +05:30
Jordan Liggitt
35178d352d auth policy subproject approvers/reviewers 2018-11-06 00:57:39 -05:00
Jordan Liggitt
4ebe084376 certificates subproject approvers/reviewers 2018-11-06 00:57:38 -05:00
Jordan Liggitt
9ae79f9653 authorizers subproject approvers/reviewers 2018-11-06 00:57:38 -05:00
Jordan Liggitt
4fa2a0cc8a authenticators subproject approvers/reviewers 2018-11-06 00:57:38 -05:00
k8s-ci-robot
2f837b15e4
Merge pull request #69681 from knightXun/patch-9 
cleanup pkg/apis/core/types.go
 2018-11-05 11:41:37 -08:00
Humble Chirammal
e031513a9b Correct test name typo in validation. 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2018-11-02 16:40:06 +05:30
k8s-ci-robot
08351b6d6d
Merge pull request #68230 from bertinatto/remove_mount_propagation_gate 
Remove mount propagation feature gate
 2018-11-02 01:13:43 -07:00
Mehdy Bohlool
e27096cdb4 Update generated files 2018-10-31 14:47:13 -07:00
Mehdy Bohlool
1587d189cb Refactor webhookclientConfig validation of admission and audit registration 2018-10-31 11:14:47 -07:00
Mehdy Bohlool
530c79939f API Types for CRD conversion 2018-10-31 11:14:47 -07:00
Fabio Bertinatto
6c9b854542 Remove mount propagation feature gate logic 2018-10-31 15:51:37 +01:00
WanLinghao
0438cdf413 fix auditsink validation output 2018-10-31 15:21:05 +08:00
Jordan Liggitt
572dfe6cb7 generated files 2018-10-25 21:12:57 -04:00
Jordan Liggitt
d0577ace6b fixup extensions->apps references 2018-10-25 21:12:57 -04:00
Jordan Liggitt
b502bc093c stop generating GetScale/UpdateScale for internal clients 2018-10-25 21:12:57 -04:00
Jordan Liggitt
dda0a68521 Change registration and custom conversion from extensions to apps 2018-10-25 21:12:57 -04:00
Jordan Liggitt
8a43e52d18 Move fuzzing from extensions to apps 2018-10-25 21:11:52 -04:00
Jordan Liggitt
283e282515 Move extensions validation to apps 2018-10-25 21:11:52 -04:00
Jordan Liggitt
4e980bbf08 Move extensions types to apps 2018-10-25 21:11:52 -04:00
Jordan Liggitt
7df2f9785e remove CustomMetricTarget 2018-10-25 21:11:52 -04:00
k8s-ci-robot
1fe288ec02
Merge pull request #70138 from liggitt/optional-ca-bundle 
Correct optional/omitempty indicator on webhook cabundle
 2018-10-23 13:52:38 -07:00
k8s-ci-robot
f827a98257
Merge pull request #69596 from logicalhan/abac-lint 
fix lint issues in the apis/abac directory (except latest.go)
 2018-10-23 11:17:31 -07:00
Jordan Liggitt
d00906f44e Fix omitempty/optional indicator on CABundle fields 2018-10-23 13:50:03 -04:00
k8s-ci-robot
b3d10d044f
Merge pull request #69988 from bradhoekstra/fix-69445 
Set the default for EnableServiceLinks only in Pod
 2018-10-22 19:44:20 -07:00
Matt Matejczyk
6ffd88aeda Update the doc to say that we will use RFC 3339 format to store the timestamp. 2018-10-22 15:47:09 -04:00
Matt Matejczyk
f005ea8976 Make it clear that the timestamp is a unix time in millis. 2018-10-22 14:14:58 -04:00
Matt Matejczyk
d99b68a6e2 Update annotation name and documentation. 2018-10-19 16:57:49 -04:00
Matt Matejczyk
536cee71b4 Merge branch 'master' into annotation 2018-10-19 13:54:06 -04:00
Matt Matejczyk
4cdab7c985 Rename and update the doc. 2018-10-19 13:11:56 -04:00
Matt Matejczyk
7f7a4590b9 Specify in the documentation that the timestamp will be expressed in milliseconds. 2018-10-19 12:19:02 -04:00
Brad Hoekstra
409a48ef91 Set the default for EnableServiceLinks only in Pod 2018-10-18 13:44:21 -04:00
Han Kang
56cd8ecf08 fix lint issues in the apis/abac directory (except latest.go) 2018-10-18 09:05:04 -07:00
Matt Matejczyk
803ee8426d Add EndpointsLastTriggerTime annotation. 2018-10-18 09:25:27 -04:00
k8s-ci-robot
0652e098d0
Merge pull request #67547 from pbarker/audit-api 
dynamic audit configuration api
 2018-10-17 16:19:39 -07:00
Slava Semushin
14c969b604 Remove myself from OWNERS files. 2018-10-16 22:47:44 +01:00
Patrick Barker
b8e1250487 adds dynamic audit api generated 2018-10-16 13:07:27 +00:00
Patrick Barker
381d0a5d14 adds dynamic audit api 2018-10-16 06:46:34 -06:00
k8s-ci-robot
d20912c83f
Merge pull request #69728 from SataQiu/fix-2018101201 
fix some typos
 2018-10-13 21:47:08 -07:00
k8s-ci-robot
b462f37639
Merge pull request #68281 from TinySong/update-api-import 
update import in doc.go of staging/src/k8s.io/api/storage/v1
 2018-10-12 19:13:24 -07:00
k8s-ci-robot
53e85280f4
Merge pull request #69714 from ericchiang/owners 
Remove ericchiang from OWNERS files
 2018-10-12 16:01:52 -07:00
k8s-ci-robot
e23a3af013
Merge pull request #67802 from krmayankk/dockershimtests 
Implement RunAsGroup Strategy in PSP
 2018-10-12 11:19:39 -07:00
SataQiu
e1d5b97f3f fix some typos 2018-10-12 22:29:18 +08:00
k8s-ci-robot
b3033a7278
Merge pull request #67934 from tanshanshan/typo828 
fix spelling mistakes
 2018-10-11 18:26:24 -07:00
Eric Chiang
766f5875bf Remove ericchiang from OWNERS files 
Kept myself in the OpenID Connect ones for now.
 2018-10-11 18:11:15 -07:00
knight
ce7ad36b23
cleanup pkg/apis/core/types.go 
cleanup pkg/apis/core/types.go
 2018-10-11 22:40:09 +08:00
Mayank Kumar
bc3e3afc46 api changes for psp runasgroup policy 2018-10-09 17:32:09 -07:00
k8s-ci-robot
8fa5d386a1
Merge pull request #66605 from islinwb/default_RevisionHistoryLimit 
Default extensions/v1beta1 Deployment's RevisionHistoryLimit to MaxInt32
 2018-10-08 10:41:46 -07:00
Rongxiang Song
5de60655cd Add canonical import paths to storage packages 
The comment will ensure that only imports with
this path will compile.This is needed to make sure
that the vanity url k8s.io is used as the import path
instead of github.com.

See https://golang.org/doc/go1.4#canonicalimports
for more details.
 2018-10-08 17:52:13 +08:00
Christoph Blecker
97b2992dc1
Update gofmt for go1.11 2018-10-05 12:59:38 -07:00
k8s-ci-robot
0b3a5cd64f
Merge pull request #65135 from stlaz/psp_group_mayrunas 
Add "MayRunAs" value among other GroupStrategies
 2018-09-29 19:44:55 -07:00
Stanislav Laznicka
a577b50012
Add "MayRunAs" value among other GroupStrategies 
Adds "MayRunAs" value among other group strategies. This strategy
allows to define a certain range of GIDs for FSGroupStrategy and
SupplementalGroupStrategy in a PSP.

This new strategy works similarly to the "MustRunAs" one, except that
when no GID is specified in a pod/container security context then no
GID is generated for the respective containers.

Resolves #56173
 2018-09-27 12:47:21 +02:00
k8s-ci-robot
f289353b1a
Merge pull request #68575 from prameshj/ep-validation 
Allow nodeName updates when endPoint is updated.
 2018-09-25 14:41:01 -07:00
k8s-ci-robot
a67689dfca
Merge pull request #68245 from jingyih/remove_tagName_in_goDoc 
*: Remove comment tags in GoDoc
 2018-09-25 06:13:23 -07:00
k8s-ci-robot
0805860dba
Merge pull request #67870 from yue9944882/refactor/externalize-resource-quota-admission-controller 
Externalize resource quota admission controller & controller reconciliation
 2018-09-25 02:41:40 -07:00
Brad Hoekstra
a596030cb3 Update bazel 2018-09-22 00:10:08 -04:00
Brad Hoekstra
42da186b62 Address review comments 2018-09-21 20:06:32 -04:00
Brad Hoekstra
2c5cc79eed Add comment to specify default 2018-09-21 16:21:32 -04:00
Brad Hoekstra
ac8799a80d kubelet: Make service environment variables optional 2018-09-17 16:27:36 -04:00
Pavithra Ramesh
e588ae5e04 Allow nodeName updates when endPoint is updated. 
One scenario where nodeName can change for the same ip address is if
the endpoints are in hostNetwork mode and nodes are being added/deleted.
With the current validation check, if endpoints controller misses a pod
delete event, future endpoint updates will never succeed.

removed unused helper functions
 2018-09-14 14:00:46 -07:00
Jingyi Hu
61117761cd *: Remove comment tags in GoDoc 
Adding blank line between comment tag and package name in doc.go. So
that the comment tags such as '+k8s:deepcopy-gen=package' do not show up
in GoDoc.
 2018-09-13 20:27:32 -07:00
Xing Yang
897e3c8d11 Add generated files 2018-09-12 17:34:51 -07:00
Xing Yang
6ec1ebd6ce Make APIGroup optional and modify validation 2018-09-12 17:05:29 -07:00
Kubernetes Submit Queue
c3062bae21
Merge pull request #68233 from luxas/ccm_cleanup 
Automatic merge from submit-queue (batch tested with PRs 68171, 67945, 68233). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

Move the CloudControllerManagerConfiguration to an API group in `cmd/`

**What this PR does / why we need it**:
This PR is the last piece of https://github.com/kubernetes/kubernetes/issues/67233.
It moves the `CloudControllerManagerConfiguration` to its own `cloudcontrollermanager.config.k8s.io` config API group, but unlike the other components this API group is "private" (only available in `k8s.io/kubernetes`, which limits consumer base), as it's located entirely in `cmd/` vs a staging repo.
This decision was made for now as we're not sure what the story for the ccm loading ComponentConfig files is, and probably a "real" file-loading ccm will never exist in core, only helper libraries. Eventually the ccm will only be a library in any case, and implementors will/can use the base types the ccm library API group provides. It's probably good to note that there is no practical implication of this change as the ccm **cannot** read ComponentConfig files. Hencec the code move isn't user-facing.

With this change, we're able to remove `pkg/apis/componentconfig`, as this was the last consumer. That is hence done in this PR as well (so the move is easily visible in git, vs first one "big add" then a "big remove"). The only piece of code that was used was the flag helper structs, so I moved them to `pkg/util/flag` that I think makes sense for now.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
ref: kubernetes/community#2354

**Special notes for your reviewer**:

This PR builds on top of (first two commits, marked as `Co-authored by: @stewart-yu`) https://github.com/kubernetes/kubernetes/pull/67689

**Release note**:

```release-note
NONE
```
/assign @liggitt @sttts @thockin @stewart-yu
 2018-09-05 21:36:41 -07:00
Lucas Käldström
3ff1e53111
Move the flag registration code from pkg/apis/componentconfig to pkg/util/flag 2018-09-05 14:03:05 +03:00
Lucas Käldström
7e10810ed0
Move CloudControllerManagerConfiguration from pkg/apis/componentconfig to cmd/cloud-controller-manager/app/apis/config 2018-09-05 14:02:25 +03:00
Janet Kuo
47d06c446d Validate Job .spec.ttlSecondsAfterFinished; clear it when feature disabled 
1. If TTLAfterFinished feature is enabled, the value should be non-negative.
2. If TTLAfterFinished feature is disabled, the field value should not
be kept.
 2018-09-04 14:21:14 -07:00
Janet Kuo
1d6dd86407 Autogen API docs 2018-09-04 11:35:30 -07:00
Janet Kuo
209b32684e Add TTLAfterFinished alpha feature 2018-09-04 11:35:30 -07:00
Kubernetes Submit Queue
9c86087dba
Merge pull request #63011 from NickrenREN/local-plugin-change 
Automatic merge from submit-queue (batch tested with PRs 63011, 68089, 67944, 68132). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

Support both directory and block device for local volume plugin FileSystem VolumeMode

Support both directory and block device for local volume plugin FileSystem VolumeMode 

xref: [local storage dynamic provisioning design #1914](https://github.com/kubernetes/community/pull/1914)

**What this PR does / why we need it**:

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #

**Special notes for your reviewer**:

**Release note**:
```release-note
Support both directory and block device for local volume plugin FileSystem VolumeMode 
```
 2018-09-04 10:24:36 -07:00
stewart-yu
cef2ab756c [kube-controller-manager] auto-generated file 2018-09-04 19:40:10 +08:00
stewart-yu
a226928dc9 [kube-controller-manager] fix some reference from pkg/apis/componentconfig about kube-controller-manager api 2018-09-04 19:39:41 +08:00
stewart-yu
be4a437e71 [kube-controller-manager] just only remove struct and default about KubeControllerManagerConfiguration from pkg/apis/componentconfig 2018-09-04 19:38:48 +08:00
Kubernetes Submit Queue
5b355f5d40
Merge pull request #68122 from krzysztof-jastrzebski/scale_down 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

Replace scale down window

**What this PR does / why we need it**:
Replace scale down forbidden window with scale down stabilization window.

This allows scale down based on more than one sample, to avoid rapidly changing size up and down for controllers with fluctuating load.

A bit more in https://docs.google.com/document/d/1IdG3sqgCEaRV3urPLA29IDudCufD89RYCohfBPNeWIM

This PR is copy of #67771 with resolved comments.

**Release note**:
```release-note
Replace scale down forbidden window with scale down stabilization window. Rather than waiting a fixed period of time between scale downs HPA now scales down to the highest recommendation it during the scale down stabilization window.
```
 2018-09-03 21:39:02 -07:00
Kubernetes Submit Queue
ed958b7d79
Merge pull request #68019 from damemi/hpa-v2beta2-conversion-fix 
Automatic merge from submit-queue (batch tested with PRs 67397, 68019). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

Fix conversion for autoscaling/v1 ObjectMetricSource and add fuzzer

**What this PR does / why we need it**:
Selectors in ObjectMetricSource's weren't being persisted through roundtrip conversions, and this wasn't caught because we had no fuzzer testing MetricIdentifier selectors

**Which issue(s) this PR fixes**:
none

**Special notes for your reviewer**:

**Release note**:
```release-note
NONE
```
 2018-09-03 08:23:31 -07:00
Kubernetes Submit Queue
5e9a3adafc
Merge pull request #68021 from krzysztof-jastrzebski/hpa5 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

Increase Horizontal Pod Autoscaler update frequency to every 15s

**What this PR does / why we need it**:
PR increases Horizontal Pod Autoscaler default update interval (30s -> 15s). It will improve HPA reaction time for metric changes.

**Release note**:
```release-note
Increase Horizontal Pod Autoscaler default update interval (30s -> 15s). It will improve HPA reaction time for metric changes.
```
 2018-09-03 06:23:40 -07:00
NickrenREN
159a4358e8 auto generated files 2018-09-03 13:34:26 +08:00
NickrenREN
25caf91b1c add fstype for local volume source 2018-09-03 09:49:39 +08:00
Lucas Käldström
b17d7bf9b3
autogenerated 2018-09-02 14:11:11 +03:00
Lucas Käldström
3187f2221a
Refactor the kube-controller-manager ComponentConfig structs to they can be moved out 2018-09-02 14:10:21 +03:00
Kubernetes Submit Queue
39004e852b
Merge pull request #64283 from jessfraz/ProcMountType 
Automatic merge from submit-queue (batch tested with PRs 64283, 67910, 67803, 68100). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

Add a ProcMount option to the SecurityContext & AllowedProcMountTypes to PodSecurityPolicy

So there is a bit of a chicken and egg problem here in that the CRI runtimes will need to implement this for there to be any sort of e2e testing.

**What this PR does / why we need it**: This PR implements design proposal https://github.com/kubernetes/community/pull/1934. This adds a ProcMount option to the SecurityContext and AllowedProcMountTypes to PodSecurityPolicy

Relies on https://github.com/google/cadvisor/pull/1967

**Release note**:

```release-note
ProcMount added to SecurityContext and AllowedProcMounts added to PodSecurityPolicy to allow paths in the container's /proc to not be masked.
```

cc @Random-Liu @mrunalp
 2018-08-31 16:46:33 -07:00
Krzysztof Jastrzebski
b54524075d Update auto generated files. 2018-08-31 20:26:04 +02:00
Krzysztof Jastrzebski
958cba1c82 Replace scale down forbidden window 
Replacement is scale down stabilization window. HPA will scale down only
    to max of recommendations it made during that window. More details in

    https://docs.google.com/document/d/1IdG3sqgCEaRV3urPLA29IDudCufD89RYCohfBPNeWIM
 2018-08-31 20:24:38 +02:00
Kubernetes Submit Queue
2548fb08cd
Merge pull request #68068 from krzysztof-jastrzebski/hpas2 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

Change CPU sample sanitization in HPA.

**What this PR does / why we need it**:
Change CPU sample sanitization in HPA.
    Ignore samples if:
    - Pod is beeing initalized - 5 minutes from start defined by flag
        - pod is unready
        - pod is ready but full window of metric hasn't been colected since
        transition
    - Pod is initialized - 5 minutes from start defined by flag:
        - Pod has never been ready after initial readiness period.

**Release notes:**
```release-note
Improve CPU sample sanitization in HPA by taking metric's freshness into account.
```
 2018-08-31 10:17:44 -07:00
Jess Frazelle
1a4cf7a36e
make update 
Signed-off-by: Jess Frazelle <acidburn@microsoft.com>
 2018-08-30 18:24:23 -04:00
Jess Frazelle
40d238b91a
address comments 
Signed-off-by: Jess Frazelle <acidburn@microsoft.com>
 2018-08-30 17:53:34 -04:00
Krzysztof Jastrzebski
62f771fbd4 Update auto generated files. 2018-08-30 23:13:33 +02:00
Krzysztof Jastrzebski
5357bf9eac Change CPU sample sanitization in HPA. 
Ignore samples if:
- Pod is beeing initalized - 5 minutes from start defined by flag
    - pod is unready
    - pod is ready but full window of metric hasn't been colected since
    transition
- Pod is initialized - 5 minutes from start defined by flag:
    - Pod has never been ready after initial readiness period.
 2018-08-30 23:13:14 +02:00
Jess Frazelle
30dcca6233
ProcMount: add api options and feature gate 
Signed-off-by: Jess Frazelle <acidburn@microsoft.com>
 2018-08-30 11:40:02 -04:00
Kubernetes Submit Queue
37b29297aa
Merge pull request #67432 from lichuqiang/topo_provision_beta 
Automatic merge from submit-queue (batch tested with PRs 67745, 67432, 67569, 67825, 67943). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

Move volume dynamic provisioning scheduling to beta

**What this PR does / why we need it**:

*  Combine feature gate VolumeScheduling and DynamicProvisioningScheduling into one
* Add allowedTopologies description in kubectl

**Special notes for your reviewer**:
Wait until related e2e and downside plugins are ready.

/hold

**Release note**:

```release-note
Move volume dynamic provisioning scheduling to beta (ACTION REQUIRED: The DynamicProvisioningScheduling alpha feature gate has been removed. The VolumeScheduling beta feature gate is still required for this feature)
```
 2018-08-29 15:19:34 -07:00
Mike Dame
3bb36411da Fix conversion for autoscaling/v1 ObjectMetricSource and add MetricIdentifier fuzzer 
Selectors in ObjectMetricSource's weren't being persisted through roundtrip conversions, and this wasn't caught because we had no fuzzer testing MetricIdentifier selectors
 2018-08-29 15:29:19 -04:00
Krzysztof Jastrzebski
a12193aff6 Increase Horizontal Pod Autoscaler update frequency (every 30s -> every 
15s).
 2018-08-29 20:02:01 +02:00
lichuqiang
4c43d626f2 related test update 2018-08-29 10:30:16 +08:00
lichuqiang
b4a57f6855 combine feature gate VolumeScheduling and DynamicProvisioningScheduling into one 2018-08-29 10:30:08 +08:00
Xing Yang
de00a66370 Modify DataSource comments 2018-08-28 13:26:53 -07:00
Xing Yang
9c1b29ece1 Modify comments for DataSource 2018-08-28 13:26:52 -07:00
Xing Yang
2e4f6eca0e Clarify comments for DataSource 2018-08-28 13:26:52 -07:00
Xing Yang
46fdfeb4eb Modify comments for DataSource 2018-08-28 13:26:52 -07:00
Xing Yang
5a6c5b07a2 Address Tim's comments 2018-08-28 13:26:51 -07:00