github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
93,054 Commits 1 Branch 31 Tags 1,019 MiB
479249b3a3
Commit Graph

355 Commits

Author SHA1 Message Date
Patrick Ohly
8270fe81e4 bazel update 2019-08-22 08:57:53 +02:00
Patrick Ohly
7bbc06fcd4 storage: check CSIDriver.Spec.VolumeLifecycleModes 
Using a "normal" CSI driver for an inline ephemeral volume may have
unexpected and potentially harmful effects when the driver gets a
NodePublishVolume call that it isn't expecting. To prevent that mistake,
driver deployments for a driver that supports such volumes must:
- deploy a CSIDriver object for the driver
- set CSIDriver.Spec.VolumeLifecycleModes such that it contains "ephemeral"

The default for that field is "persistent", so existing deployments
continue to work and are automatically protected against incorrect
usage.

For the E2E tests we need a way to specify the driver mode. The
existing cluster-driver-registrar doesn't support that and also was
deprecated, so we stop using it altogether and instead deploy and
patch a CSIDriver object.
 2019-08-13 23:12:52 +02:00
Madhu Rajanna
ec5ff52b88 Fix logging message during unmounting 
use errors.New() if formatting is not  required

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2019-08-12 09:18:35 +05:30
Kubernetes Prow Robot
07afde1559
Merge pull request #80935 from wongma7/initcsinode-error 
Return error returned by CSINode Get if initialization failed
 2019-08-06 23:57:29 -07:00
Kubernetes Prow Robot
521b5c3fed
Merge pull request #80994 from verult/csi-deregistration-loglevel 
Bump log level of CSI driver de-registration to match registration handler
 2019-08-06 06:06:09 -07:00
Kubernetes Prow Robot
1bc3d1abde
Merge pull request #80866 from ethan-daocloud/dev-ethan-csi-log 
cleanup: remove package csi duplicated error log
 2019-08-05 18:18:19 -07:00
Matthew Wong
bd42e728a8 Return error returned by CSINode Get if initialization failed 2019-08-05 23:01:50 +00:00
Cheng Xing
da64ca0c54 Bumped log level of CSI driver de-registration to match registration handler 2019-08-05 15:55:28 -07:00
ethan
d26e352fe7 cleanup: remove package csi duplicated error log 
return err directly in func; delete new line in error message

cleanup: use errors.New(log()) to uniform error message
 2019-08-05 20:35:28 +08:00
Kubernetes Prow Robot
9f6ebf0feb
Merge pull request #79144 from tedyu/csi-x-recur 
Remove recursion in csiAttacher#waitForVolumeAttachmentInternal
 2019-08-03 00:05:51 -07:00
Kubernetes Prow Robot
36391966f2
Merge pull request #78736 from endocrimes/dani/comment-fix 
csi: Fix socket extension comment
 2019-08-02 20:27:53 -07:00
Danielle Lancashire
d4c189d52b
csi: Fix socket extension comment 
The CSI socket has used a sock extension since 179d8e108e. This removes
the stale TODO for updating it.
 2019-08-01 14:52:46 +02:00
Kubernetes Prow Robot
4ce69dd32e
Merge pull request #80848 from cwdsuzhou/Aug/fix_ut 
Fix some unreasonable places int csi ut
 2019-08-01 03:30:14 -07:00
caiweidong
7b5dac03ce Fix some unreasonable places int csi ut 2019-08-01 14:19:11 +08:00
Kubernetes Prow Robot
3a4cda9def
Merge pull request #80522 from ethan-daocloud/patch-3 
cleanup: remove duplicated logging error message in csi_mounter.go, also some typos.
 2019-07-31 22:36:39 -07:00
ethan
ec2c5dff43 fix some log typos in csi_mounter.go 
cleanup: remove logging duplicated error message
fix error msg, include err in new returned errors.
Signed-off-by: ethan <guangming.wang@daocloud.io>
 2019-08-01 02:39:32 +00:00
AllenZMC
8833e4072c
fix typos in csi_attacher.go 2019-07-26 09:48:51 +08:00
Kubernetes Prow Robot
a3750501b0
Merge pull request #79983 from pohly/persistent-and-ephemeral-csi-volumes 
persistent and ephemeral csi volumes
 2019-07-25 16:01:54 -07:00
Kubernetes Prow Robot
0e3b593ded
Merge pull request #79851 from jparklab/master 
Fix nil pointer dereference error in volume_stat_calculator
 2019-07-25 14:33:58 -07:00
Patrick Ohly
555ff7ef10 CSI: allow drivers that can handle persistent and ephemeral volumes 
The conceptual change is that the mode in which a volume gets handled
is derived from it's spec, not from the ability of the driver. In
practice, that is already how the code worked because it didn't
actually look at CSIDriver.Spec.Mode at all.

Therefore the code change itself is mostly just renaming "driver mode"
to "volume mode". In some places (CanDeviceMount, CanAttach) the
feature check that was used elsewhere seemed to be missing. Now their
code path for ephemeral volumes are also only entered if that feature
is enabled.

The sanity check whether a CSI driver is being used correctly still
needs to be implemented.

Related-to: https://github.com/kubernetes/kubernetes/issues/79624
 2019-07-25 16:45:46 +02:00
Kubernetes Prow Robot
da3daf2e8a
Merge pull request #80451 from cwdsuzhou/July/fix_error_override 
Fix error override when saveVolumeData occurs error
 2019-07-24 02:02:15 -07:00
caiweidong
a5bf98a43e Fix error overrided when saveVolumeData occurs error 2019-07-24 10:19:22 +08:00
Ted Yu
f4fbfcb46a Remove recursion in csiAttacher#waitForVolumeAttachmentInternal 2019-07-23 14:29:24 -07:00
caiweidong
45c52d1314 Fix potential panic in nodeGetVolumeStatsV1 2019-07-23 13:47:35 +08:00
caiweidong
8789143062 Fix csi attacher unit tests using t.Run() 2019-07-22 15:42:31 +08:00
David Zhu
831cd29f4e Add passthrough for MountOptions for NodeStageVolume for CSI 2019-07-16 16:17:47 -07:00
Kubernetes Prow Robot
10a1d1f5bd
Merge pull request #79920 from cwdsuzhou/July/block_not_support_attach 
Bugfix: csi plugin supporting raw block that does not need attach mounted failed
 2019-07-15 08:39:21 -07:00
caiweidong
0c628e101a Bugfix: csi raw block that does not need attach mounted failed 
Add unit test

fix verify-test-featurefates failed
 2019-07-15 10:34:12 +08:00
Kubernetes Prow Robot
9915047d3d
Merge pull request #79113 from tedyu/stop-w-detach 
Close watcher early for volume detachment
 2019-07-12 06:31:18 -07:00
Kubernetes Prow Robot
021ad88ac4
Merge pull request #79894 from odinuge/csi-client-dead-code 
Remove dead code from csi_client
 2019-07-10 06:20:25 -07:00
Kubernetes Prow Robot
d59a603f1b
Merge pull request #78267 from mucahitkurt/cleanup/operation-generator-migration-scenarios-unit-tests 
unit tests for operationGenerator.GenerateUnmapVolumeFunc
 2019-07-09 18:20:25 -07:00
Odin Ugedal
542c335fca Remove dead code from csi_client 
When removing a feature flag in
35bc5dc6b6, a few of the lines were
removed, resulting in some dead code.
 2019-07-08 17:53:52 +02:00
Ji-Young Park
528521cfae Return MetricsError with ErrCodeNotSupported code 
GetMetrics function expects MetricsError error
with ErrCodeNotSupported code when driver for the volume
does not support metrics
Updated csi_metrics to return error when underlying csi
driver does not have GET_VOLUME_STATS capability
 2019-07-06 10:49:06 -04:00
Kubernetes Prow Robot
a3be4b6817
Merge pull request #79529 from andyzhangx/change-csi-timeout 
fix: change default timeout value in csi plugin
 2019-07-03 09:12:58 -07:00
Kubernetes Prow Robot
2501a9083d
Merge pull request #68513 from codenrhoden/mount-refactor 
Refactor util/mount interface in prep for moving out of k/k
 2019-06-28 13:57:28 -07:00
andyzhangx
d8c92f5c09 fix: change timeout value in csi plugin 2019-06-28 14:27:22 +00:00
Fabio Bertinatto
33c8bacd41 Update nodeinfomanager to store volume limits in CSINode 2019-06-25 16:30:54 +02:00
draveness
35bc5dc6b6 feat: cleanup feature gates for KubeletPluginsWatcher 2019-06-23 16:59:36 +08:00
Ted Yu
005065f8fc Close watcher early for volume detachment 2019-06-17 15:09:43 -07:00
Kubernetes Prow Robot
365283e202
Merge pull request #78532 from cwdsuzhou/simplify_construct_volume_spec 
Simplify func ConstructVolumeSpec
 2019-06-17 11:05:49 -07:00
Kubernetes Prow Robot
e46b9ca656
Merge pull request #78754 from cwdsuzhou/June/csi_attach_close_chan 
Avoid to keep the watcher open for too long
 2019-06-17 04:36:37 -07:00
Kubernetes Prow Robot
bde744eb97
Merge pull request #78839 from tedyu/cleaner-err 
Check correct error for cleanup in csiAttacher#MountDevice
 2019-06-14 20:47:01 -07:00
Travis Rhoden
be7da5052f Refactor pkg/util/mount to be more reusable 
This patch refactors pkg/util/mount to be more usable outside of
Kubernetes. This is done by refactoring mount.Interface to only contain
methods that are not K8s specific. Methods that are not relevant to
basic mount activities but still have OS-specific implementations are
now found in a mount.HostUtils interface.
 2019-06-14 09:35:18 -06:00
Kubernetes Prow Robot
70b46ca5fb
Merge pull request #78529 from cwdsuzhou/remove_verbose_err 
Remove dead codes
 2019-06-14 04:09:13 -07:00
Mucahit Kurt
db1c07750a unit tests for the volume plugin name that's used inside GeneratedUnmapVolumeFunc for csi migration on/off scenarios 
Signed-off-by: Mucahit Kurt <mucahitkurt@gmail.com>
 2019-06-11 08:32:25 +03:00
Ted Yu
de92897e26 Check correct error for cleanup 2019-06-09 21:29:28 -07:00
caiweidong
0508bea9b6 Fix keep the watcher open for too long 2019-06-07 21:40:50 +08:00
caiweidong
4ce2f296f5 Simplify func ConstructVolumeSpec 2019-06-05 10:22:13 +08:00
caiweidong
b726db66d2 Remove dead codes 2019-06-03 22:15:53 +08:00
Kubernetes Prow Robot
b7fa33ec15
Merge pull request #77703 from ddebroy/inline-mig-1 
API changes to support migration of inline in-tree volumes to CSI
 2019-05-31 12:23:19 -07:00
Deep Debroy
de7be9d613 Populate InlineVolumeSpec in CSI attacher and translation library 
Signed-off-by: Deep Debroy <ddebroy@docker.com>
 2019-05-30 09:35:22 +00:00
Robert Krawitz
5b97b2860d Change fsGroup to mounterArgs in volume.SetUp() to allow for future extension. 2019-05-29 15:12:28 -04:00
Hemant Kumar
0ab6bdfa36 Wait for waitforattach goroutine before exiting 
This test suite fails in weird ways without waiting for the
goroutine
 2019-05-21 09:57:47 -04:00
Kubernetes Prow Robot
fad34e404e
Merge pull request #76188 from humblec/csi-in-m 
csi: Implement NodeServiceCapability_RPC_GET_VOLUME_STATS rpc call
 2019-05-17 20:26:09 -07:00
Humble Chirammal
c511c90b59 csi: Implement NodeServiceCapability_RPC_GET_VOLUME_STATS rpc call 
and implement Metrics Provider for CSI driver

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2019-05-17 17:10:53 +05:30
Andrew Kim
c919139245 update import of generic featuregate code from k8s.io/apiserver/pkg/util/feature -> k8s.io/component-base/featuregate 2019-05-08 10:01:50 -04:00
Kubernetes Prow Robot
e332051416
Merge pull request #77433 from cwdsuzhou/common_func_for_ad 
Add common func for NewAttacher and NewDetacher
 2019-05-07 09:51:56 -07:00
Kubernetes Prow Robot
2e6f58ddf8
Merge pull request #77431 from cwdsuzhou/Add_detacher_assert_check 
Add detacher assertion for csiAttacher
 2019-05-07 09:51:44 -07:00
Kubernetes Prow Robot
a8787dac30
Merge pull request #76927 from mrkm4ntr/unnecessary-goroutine 
Do not generate unnecessary goroutines
 2019-05-06 21:31:53 -07:00
Kubernetes Prow Robot
e0d39be7b5
Merge pull request #76785 from dims/typo-extra-space-in-fatalf-format-string 
typo - extra space - in Fatalf format string
 2019-05-06 14:01:39 -07:00
caiweidong
62fe5fe7b8 add common func for NewAttacher and NewDetacher 2019-05-04 11:08:28 +08:00
caiweidong
5d89ab26e9 Add detacher assert for csiAttacher 2019-05-04 10:43:46 +08:00
Kubernetes Prow Robot
b5c34d0c43
Merge pull request #74734 from codenrhoden/move-mountspath 
Move MountsInGlobalPDPath from mount pkg to volume
 2019-05-01 17:28:18 -07:00
Humble Chirammal
a3c1a6da02 Error message corrections 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2019-05-01 13:36:52 +05:30
Ted Yu
ebe499ec80 Remove variable nodeExpandSet 2019-04-30 06:44:29 -07:00
Ted Yu
565c88de14 Return early when node expansion is determined 2019-04-29 14:05:08 -07:00
Travis Rhoden
78d109e201 Always use filepath.Join instead of path.Join 
This patch cleans up pkg/util/mount/* and pkg/util/volume/* to always
use filepath.Join instead of path.Join. filepath.Join is preferred
because path.Join can have issues on Windows.
 2019-04-29 09:56:05 -06:00
Shintaro Murakami
f8e81337da Do not generate unnecessary goroutine 2019-04-23 16:22:14 +09:00
Kubernetes Prow Robot
29163600fe
Merge pull request #76796 from dims/remove-unused-methods 
Remove unused code
 2019-04-19 11:09:55 -07:00
Davanum Srinivas
7b8c9acc09
remove unused code 
Change-Id: If821920ec8872e326b7d85437ad8d2620807799d
 2019-04-19 08:36:31 -04:00
Vladimir Vivien
d564d2e74d CSI - Prevents unsupported device mount with CanMountDevice(spec) check 2019-04-18 19:54:28 -04:00
Davanum Srinivas
22ffdc6063
typo - extra space - in Fatalf format string 
Change-Id: Ifeff0ee29aa6ccdc4c3ebdd2a071cebfafaf937e
 2019-04-18 14:42:21 -04:00
Vladimir Vivien
b138e6d1e2 CSI - Surfaces klog flags; common tests aggregation 2019-04-12 15:38:06 -04:00
Vladimir Vivien
cfafde983b Volume AttachablePlugin.CanAttach() now returns both bool and error 2019-04-08 16:53:22 -04:00
Xing Yang
000ab86788 Move CSIDriver Lister to the controller 2019-04-05 12:20:11 -07:00
Kubernetes Prow Robot
60638c71bd
Merge pull request #75481 from mucahitkurt/refactor/nodeinfomanager-tests 
Add expectedCSINode for csiNodeEnabled test cases on nodeinfomanager tests
 2019-03-29 17:33:08 -07:00
Kubernetes Prow Robot
7a478a4609
Merge pull request #75844 from vladimirvivien/volume-skip-device-mount 
Volume DeviceMountablePlugin.CanDeviceMount check when retrieving plugins
 2019-03-29 13:02:13 -07:00
Mucahit Kurt
6113cd57bc add expectedCSINode and expectedNode for test cases to compare CSINode and Node object instead of field based comparisons 
Signed-off-by: Mucahit Kurt <mucahitkurt@gmail.com>
 2019-03-29 23:01:26 +03:00
Vladimir Vivien
3777514f83 Adds DeviceMountablePlugin.CanDeviceMount check when retrieving plugins 2019-03-28 10:39:32 -04:00
Michelle Au
ab6a2530fb return empty devicepath for csi attach 2019-03-27 17:28:21 -07:00
Kubernetes Prow Robot
4bd421502e
Merge pull request #75211 from wongma7/csi-attacher-test-flake 
Fix unit test volumeattachments watch not working
 2019-03-20 00:55:14 -07:00
Kubernetes Prow Robot
517922f31a
Merge pull request #75308 from msau42/csi-beta-e2e 
ignore kubeclient nil in csi plugin init
 2019-03-13 05:49:46 -07:00
Michelle Au
398777f261 ignore kubeclient nil in csi plugin init 2019-03-12 16:29:08 -07:00
Yecheng Fu
fa926ed6e0 Delay CSI client initialization 2019-03-09 13:45:03 +08:00
Matthew Wong
cfea406c1c Fix unit test volumeattachments watch not working 2019-03-08 15:20:31 -05:00
Vladimir Vivien
923ad369c8 CSI Inline Volume - Kubelet/Driver code impl 2019-03-08 12:40:09 -05:00
Hemant Kumar
a8f318779b Add CSI volume resizing tests 
Add some tests for checking node expansion
Add new tests for expander
 2019-03-08 09:23:18 -05:00
Hemant Kumar
529cd7119b Move resize function parameters to a new ResizeOptions type 
This enables us to pass CSI volume phase
 2019-03-08 09:21:44 -05:00
Hemant Kumar
63eb25eb4b Introduce feature gate for volume expansion 
Update CSI library version
 2019-03-08 09:21:44 -05:00
David Zhu
41b3579345 Address review comments 2019-03-07 17:17:09 -08:00
David Zhu
7d2f4e97b8 Add ADC Fallback if Node doesn't have driver installed 2019-03-07 14:47:38 -08:00
David Zhu
34d9ee5b9b Add CSINode initialization for CSIMigration on node startup before pod ready 2019-03-07 14:47:38 -08:00
Xing Yang
6265f4f78c CSINodeInfo/CSIDriver controller changes 
This is the 2nd PR to move CSINodeInfo/CSIDriver APIs to
v1beta1 core storage APIs. It includes controller side changes.
It depends on the PR with API changes:
https://github.com/kubernetes/kubernetes/pull/73883
 2019-03-04 16:41:58 -08:00
Andrew Kim
01933b02a3 replace usage of v1beta1 VolumeAttachments with v1 2019-02-27 15:42:12 -05:00
Jordan Liggitt
d1e865ee34 Update client callers to use explicit versions 2019-02-26 08:36:30 -05:00
Kubernetes Prow Robot
b8b143410f
Merge pull request #74076 from bertinatto/reg_error 
Don't return CSI driver unregistration error
 2019-02-19 08:37:29 -08:00
Fabio Bertinatto
d6c642b46a Only return CSI driver registration error 2019-02-16 10:06:33 +01:00
David Zhu
5dde1df1cd Migration shim logic for Persistent Volumes for Attach/Detach 2019-02-14 17:04:23 -08:00
Kubernetes Prow Robot
f0b72df47e
Merge pull request #73789 from vladimirvivien/volume-plugin-can-attach 
AttachableVolumePlugin CanAttach() method for attachable check
 2019-02-08 09:06:17 -08:00
Kubernetes Prow Robot
b50c643be0
Merge pull request #73540 from rlenferink/patch-5 
Updated OWNERS files to include link to docs
 2019-02-08 09:05:56 -08:00
Vladimir Vivien
0a653b3b80 Adds method CanAttach() to check plugin attachability 2019-02-08 08:04:15 -05:00
Kubernetes Prow Robot
2d956389dc
Merge pull request #73313 from pivotal-k8s/csi-drivers-list 
Refactor csiDriversStore
 2019-02-06 09:31:06 -08:00
Roy Lenferink
b43c04452f Updated OWNERS files to include link to docs 2019-02-04 22:33:12 +01:00
Kubernetes Prow Robot
8f1082c6af
Merge pull request #73455 from danielqsj/keymutex 
Migrate to k8s.io/utils/keymutex and k8s.io/utils/strings
 2019-01-31 09:56:19 -08:00
danielqsj
657a1a1a34 change import alias of utils/strings 2019-01-30 10:44:09 +08:00
danielqsj
093328e57f migrate to k8s.io/utils/strings 2019-01-30 10:24:00 +08:00
Tara Gu
1f822030a4 Correct error message 2019-01-29 21:14:26 -05:00
Tara Gu
ad4bd8bdac Add exponential backoff for plugin registration 2019-01-29 21:13:02 -05:00
Hannes Hörl
84c46629c5 Refactor to use new csi.DriversList & csi.Driver 2019-01-25 12:23:28 +00:00
Hannes Hörl
96aa4fb5d2 Implement DriversStore as a struct 
This allows us to hide
- the mutex handling
- the initialization
as implementation details.

Signed-off-by: Maria Ntalla <mntalla@pivotal.io>
 2019-01-25 12:23:15 +00:00
David Zhu
d8c9dc5bb5 Add IsMigratableToCSI to volume plugin interface 2019-01-17 14:43:52 -08:00
oleksiys
f6a0359c9d Fix CSI volume unmount and cleanup logic 2019-01-05 09:00:17 -08:00
k8s-ci-robot
79e5cb2cb7
Merge pull request #71302 from liggitt/verify-unit-test-feature-gates 
Split mutable and read-only access to feature gates, limit tests to readonly access
 2018-11-29 21:45:12 -08:00
saad-ali
18050e308c Allow CSI Drivers suporting 0.x/1.x to use old dir 
Allow drivers implmenting both CSI 0.x and 1.x to use the old volume
plugin directory in addition to the the new volume plugin directory.
 2018-11-28 11:11:37 -08:00
saad-ali
aa8244beb5 Modify CSI to handle both 0.3 and 1.0 
Modify the CSI volume plugin to handle CSI version 0.x as well as 1.x
 2018-11-21 18:37:31 -08:00
saad-ali
d1b44857ad Add missing feature gate to CSI driver uninstall 2018-11-21 18:37:31 -08:00
saad-ali
2b44ec5e9c Reduce csipb dependencies 
Remove csipb dependency from everywhere except the CSI client in
preperation for supporting multiple CSI clients.
 2018-11-21 18:37:31 -08:00
saad-ali
8f666d9e41 Modify kubelet watcher to support old versions 
Modify kubelet plugin watcher to support older CSI drivers that use an
the old plugins directory for socket registration.
Also modify CSI plugin registration to support multiple versions of CSI
registering with the same name.
 2018-11-21 18:37:31 -08:00
Jordan Liggitt
2498ca7606 drop VerifyFeatureGatesUnchanged 2018-11-21 11:51:33 -05:00
k8s-ci-robot
4821291398
Merge pull request #71095 from msau42/csi-devicepath 
Remove devicePath dependency for CSI volumes
 2018-11-16 18:22:24 -08:00
Michelle Au
974d47ecf8 Remove devicePath dependency for CSI volumes 2018-11-16 15:40:35 -08:00
Cheng Xing
ca18690ceb Augmenting API call retry in nodeinfomanager 2018-11-16 13:00:22 -08:00
Jordan Liggitt
248d661327 Add tests to ensure storage feature gate changes don't escape packages 2018-11-16 10:52:53 -05:00
Jordan Liggitt
358c092abe fix storage unit tests leaking feature flag changes 2018-11-16 10:52:52 -05:00
k8s-ci-robot
6fc60428a7
Merge pull request #71020 from saad-ali/updateCSI10 
Bump CSI Spec to 1.0.0 and gRPC to 1.13.0
 2018-11-16 01:53:21 -08:00
k8s-ci-robot
cde4c9ebe1
Merge pull request #68635 from mkimuram/issue/68424 
CSI block volume refactor to fix target path
 2018-11-15 21:35:42 -08:00
saad-ali
09d3dce38a Update CSI client to pick up CSI v1.0.0 changes 2018-11-15 16:39:59 -08:00
Masaki Kimura
9c56b53390 Fix the comment for csi block pathes to make look the same to filesystem 2018-11-15 23:26:19 +00:00
Masaki Kimura
6d7b5f1d1b Delegate creation of publishPath to driver and allow creating device file directly 2018-11-15 01:14:12 +00:00
Masaki Kimura
d8c6fe5202 Change stagingPath to be a directory 2018-11-14 20:53:28 +00:00
Masaki Kimura
f0354ad605 Fix for adding block volume support to CSI RBD driver 2018-11-14 19:20:56 +00:00
Michelle Au
498cd61f41 Add volumeattachment status subresource 2018-11-14 14:01:16 +01:00
Deep Debroy
05759a9091 Handle validation of drivers in Spec and Status 
Signed-off-by: Deep Debroy <ddebroy@docker.com>
 2018-11-13 02:35:30 -08:00
Deep Debroy
af73d7bdc1 Add validation of CSINodeInfo before Create/Update calls 
Signed-off-by: Deep Debroy <ddebroy@docker.com>
 2018-11-13 00:48:56 -08:00
Davanum Srinivas
954996e231
Move from glog to klog 
- Move from the old github.com/golang/glog to k8s.io/klog
- klog as explicit InitFlags() so we add them as necessary
- we update the other repositories that we vendor that made a similar
change from glog to klog
  * github.com/kubernetes/repo-infra
  * k8s.io/gengo/
  * k8s.io/kube-openapi/
  * github.com/google/cadvisor
- Entirely remove all references to glog
- Fix some tests by explicit InitFlags in their init() methods

Change-Id: I92db545ff36fcec83afe98f550c9e630098b3135
 2018-11-10 07:50:31 -05:00
David Zhu
06f3b26012 Change semantics of driver install and uninstall in CSINodeInfo to use new fields. 2018-11-08 19:45:01 -08:00
David Zhu
4621887037 Updated test files with new fields 2018-11-08 19:45:01 -08:00
k8s-ci-robot
af583b1c5f
Merge pull request #70540 from gnufied/fix-csi-attach-limit-node-update 
Fix csi attach limit node update
 2018-11-02 16:44:30 -07:00
Hemant Kumar
889468b1ab Fix csi volume attach limit 2018-11-02 15:10:31 -04:00
Vladimir Vivien
df280251e7 CSI Kubelet Plugin Watcher unregistration 2018-11-01 13:53:55 -04:00
k8s-ci-robot
56796f3bf4
Merge pull request #67898 from NetApp/csi-mount-options 
Add support for mount options to CSI drivers
 2018-10-30 19:48:20 -07:00
k8s-ci-robot
322d0df3d2
Merge pull request #70053 from gman0/fix-csiclient-lock 
CSI client: added missing lock when reading from csiDrivers
 2018-10-23 02:08:32 -07:00
k8s-ci-robot
91ac9d50fa
Merge pull request #69371 from pivotal-k8s/fix-well-tested-fake 
Add tests for `csiDriverClient`
 2018-10-22 18:28:37 -07:00
gman
571ad40fa1 CSI client: added missing lock when reading from csiDrivers 2018-10-20 22:43:17 +02:00
Hannes Hörl
6330cee9ea Add tests for csiDriverClient 
As #69219 outlines the unit tests in `csi_client_test.go` where not
testing the actual implementation of the `csiDriverClient` but was
testing the fake.

To fix this, we changed the `csiDriverClient` to use a
`nodeClientCreator` which is responsible for creating a new
`NodeClient`, a real one in prod and a fake one in the tests.

The setup of the gRPC connection has been pushed into that creator. The
node client uses that connection; that's transparent to the driver
client. It's the responsibility of the driver client to close the
connection when it is done with the node client. To achieve this, we
have the node client creator return a closer which handles the
connection teardown.

In the tests we now also check if the driver client actually calls
this closer, thus closing the gRPC connection.

Closes: #69219

Co-authored-by: Rosie Bloxsom <rbloxsom@pivotal.io>
Co-authored-by: Maria Ntalla <mntalla@pivotal.io>
 2018-10-15 20:55:37 +01:00
Ben Swartzlander
85b224856d Add unit tests for CSI mount options 2018-10-12 12:16:20 -04:00
Ben Swartzlander
65d3beb820 Add support for mount options to CSI drivers 2018-10-11 13:39:19 -04:00
k8s-ci-robot
2d67d782de
Merge pull request #69225 from gnufied/volume-limit-tidy-up 
Enable volume limit feature by default
 2018-10-02 17:03:32 -07:00
Hemant Kumar
575f79e03e Enable volume limit feature by default 
Also add tests for it.
 2018-10-01 14:37:45 -04:00
k8s-ci-robot
e019addcaa
Merge pull request #68931 from mlmhl/check_volume_attachment 
extract volume attachment status checking operation as a common function when attaching a CSI volume
 2018-09-29 19:45:06 -07:00