Commit Graph

10808 Commits

Author SHA1 Message Date
Stephen Augustus
1171ae7153 [go1.15] apimachinery/pkg/util/proxy: Drop identity transfer-encoding
ref: https://tip.golang.org/doc/go1.15#net/http

Parsing is now stricter as a hardening measure against request smuggling
attacks: non-ASCII white space is no longer trimmed like SP and HTAB,
and support for the "identity" Transfer-Encoding was dropped.

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
2020-07-25 16:45:01 -04:00
Kubernetes Prow Robot
7348ab957c
Merge pull request #93356 from justaugustus/vdf
[VDF] Normalize container image references to k8s.gcr.io
2020-07-25 02:58:17 -07:00
Kubernetes Prow Robot
19caf38665
Merge pull request #93425 from liggitt/string-cast
Fix int->string casts
2020-07-24 23:12:16 -07:00
Kubernetes Prow Robot
54e2070722
Merge pull request #93410 from nikhita/apimachinery-triage-labels
Don't apply triage/needs-information on apimachinery and instrumentation PRs
2020-07-24 19:08:16 -07:00
Kubernetes Prow Robot
6f7b6b6d13
Merge pull request #93426 from liggitt/test-certs
Add subjectAltName to test serving certificates
2020-07-24 14:26:16 -07:00
Jordan Liggitt
124a5ddf72 Fix int->string casts 2020-07-24 16:23:12 -04:00
Kubernetes Prow Robot
b826d394af
Merge pull request #93398 from liggitt/apiserver-integration-startup
Allow integration test servers extra time to start
2020-07-24 09:26:22 -07:00
Nikhita Raghunath
3a74f461a2 Revert "Merge pull request #93160 from logicalhan/triage-instrumentation"
This reverts commit 1ed2cf1895, reversing
changes made to 04ecdb9eb6.
2020-07-24 18:09:07 +05:30
Nikhita Raghunath
c00dae0607 Revert "Merge pull request #93156 from logicalhan/triage-api-machinery"
This reverts commit 32438cf269, reversing
changes made to bb6a6aa391.
2020-07-24 13:01:02 +05:30
Jordan Liggitt
22c9236741 Allow integration test servers extra time to start 2020-07-23 17:46:59 -04:00
Jordan Liggitt
acce8871d6 Add subjectAltName to test serving certificates 2020-07-23 15:57:44 -04:00
Kubernetes Prow Robot
1ed2cf1895
Merge pull request #93160 from logicalhan/triage-instrumentation
auto triage sig-instrumentation tagged PRs
2020-07-23 11:19:26 -07:00
Kubernetes Prow Robot
e6ee924f6c
Merge pull request #93316 from feiskyer/fix-93287-2
Fix instance not found issues when an Azure Node is recreated in a short time
2020-07-22 16:53:40 -07:00
Stephen Augustus
99dd7570eb [VDF] Remove references to gcr.io/google-containers
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
2020-07-22 16:10:12 -04:00
Kubernetes Prow Robot
32438cf269
Merge pull request #93156 from logicalhan/triage-api-machinery
automatically assign triage labels to api-machinery tagged PRs
2020-07-21 19:52:34 -07:00
Kubernetes Prow Robot
bb6a6aa391
Merge pull request #93138 from nikhita/publishing-defaultgoversion
publishing: use go 1.14.6 for master and release-1.19
2020-07-21 19:52:20 -07:00
Pengfei Ni
358885660d Fix instance not found issues when an Azure Node is recreated in a short time 2020-07-22 10:47:33 +08:00
Kubernetes Prow Robot
5df1e53dac
Merge pull request #93107 from DataDog/azure-per-vmss-vmssvm-incremental-cache
Azure: use per-vmss vmssvm incremental cache
2020-07-21 15:00:06 -07:00
Kubernetes Prow Robot
37cb765a85
Merge pull request #93211 from liggitt/crdlist
Make CRDList lifecycle consistent with CRD
2020-07-21 01:55:14 -07:00
Kubernetes Prow Robot
275eabdf72
Merge pull request #93259 from jpbetz/revert-88936
Revert nested trace PR#88936
2020-07-20 19:51:47 -07:00
Joe Betz
02cf58102a Revert nested trace PR#88936 2020-07-20 09:55:05 -07:00
Benjamin Pineau
fcb3f1f64c Tests fixes for Azure per-VMSS VMs caches
Signed-off-by: Benjamin Pineau <benjamin.pineau@datadoghq.com>
2020-07-20 18:35:23 +02:00
Benjamin Pineau
85ecd0e17c Azure: per VMSS, incremental VMSS VMs cache
Azure's cloud provider VMSS VMs API accesses are mediated through
a cache holding and refreshing all VMSS together.

Due to that we hit VMSSVM.List API more often than we could: an
instance's cache miss or expiration should only require a single
VMSS re-list, while it's currently O(n) relative to the number of
attached Scale Sets.

Under hard pressure (clusters with many attached VMSS that can't all
be listed in one sequence of successive API calls) the controller
manager might be stuck trying to re-list everything from scratch,
then aborting the whole operation; then re-trying and re-triggering
API rate-limits, affecting the whole Subscription.

This patch replaces the global VMSS VMs cache by per-VMSS VMs caches.
Refreshes (VMSS VMs lists) are scoped to the single relevant VMSS; under
severe throttling the various caches can be incrementally refreshed.

Signed-off-by: Benjamin Pineau <benjamin.pineau@datadoghq.com>
2020-07-20 18:35:23 +02:00
Jordan Liggitt
7aacbeac14 Update k8s.io/utils 2020-07-20 11:12:29 -04:00
Nikhita Raghunath
c3b75416a8 publishing: use go 1.14.6 for master and release-1.19
The `default-go-version` field specifies the go version used for the
master branch, and if the go version is not explicitly specified for a
release branch.

This commit also uses go 1.14.6 for the `release-1.19` branch.
2020-07-20 14:02:30 +05:30
Kubernetes Prow Robot
43fbe17dc6
Merge pull request #93128 from gaurav1086/convertMaptoMapPointer_fix_range_iterator_issue
[staging/azure] azure_utils: fix range iterator issue in convertMaptoMapPointer
2020-07-19 21:02:50 -07:00
Kubernetes Prow Robot
6ceb6c6845
Merge pull request #93134 from logicalhan/metric-handler
Add reset handler to the instrumentation metric library and expose Reset on the metric registries
2020-07-19 15:48:50 -07:00
Kubernetes Prow Robot
eda07adf6e
Merge pull request #91177 from MikeSpreitzer/more-concurrency-details
Introduce more metrics on concurrency
2020-07-18 19:20:50 -07:00
Jordan Liggitt
5678d40f76 Make CRDList lifecycle consistent with CRD 2020-07-18 13:53:49 -04:00
Kubernetes Prow Robot
1f14cbac54
Merge pull request #93118 from bart0sh/PR0091-update-etcd
go.mod: update etcd to fix e2e tests
2020-07-18 10:24:50 -07:00
Kubernetes Prow Robot
05f6812c2d
Merge pull request #90822 from deads2k/csr-separate-signer-flags-02
allow setting different certificates for kube-controller-managed CSR signers
2020-07-18 03:10:50 -07:00
Kubernetes Prow Robot
0a7050f531
Merge pull request #93043 from aramase/vmss-dualstack-ipconfig
fix: determine the correct ip config based on ip family
2020-07-17 15:02:50 -07:00
Kubernetes Prow Robot
f9ad7db9a6
Merge pull request #92349 from jingyih/update_etcd_server_3p4p9
Update default etcd server to 3.4.9
2020-07-17 07:53:01 -07:00
Ed Bartosh
016eb06d8b go.mod: update etcd to fix e2e tests
Updated etcd to v3.4.10 to include this fix:
 - change protobuf field type from int to int64

This should fix increased flakyness in a lot of node e2e tests.
2020-07-17 12:15:43 +03:00
Han Kang
f3c02d7221 auto triage sig-instrumentation tagged PRs
Change-Id: Ibae7373fb197485aeb222f1455515178cc3b4d13
2020-07-16 13:48:25 -07:00
Han Kang
9129dbc98b automatically assign triage labels to api-machinery tagged PRs
Change-Id: Ifcc8a85d190d6370423af27f6e6c4c90b8472981
2020-07-16 13:13:59 -07:00
Han Kang
45af3ae0cb refactor wrapped functions into variables
Change-Id: I1eec309c537920ba520c7a90f9a1f557ec53cf2c
2020-07-16 09:54:23 -07:00
Han Kang
6b994af680 port over apiserver metric handler to use the instrumentation library
Change-Id: Ifabb726120c1c4f90ff3e4d71fdbba468fe74e8a
2020-07-16 09:26:47 -07:00
Han Kang
ef00707ccf add metric reset to wrapped prometheus registry
Change-Id: I035863210e19184eb2e8861772e58d2d1de8ec5e
2020-07-16 09:26:34 -07:00
Kubernetes Prow Robot
96c057ab48
Merge pull request #92001 from huffmanca/include-csidriver-fsgroup
Include CSIDriver capability to indicate fsGroup support
2020-07-16 09:11:42 -07:00
Gaurav Singh
744ea3a930 [staging/azure] azure_utils: fix range iterator issue in convertMaptoMapPointer
Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>

Use local variable for the copy of iterator variable
2020-07-16 11:10:45 -04:00
Kubernetes Prow Robot
75b5552415
Merge pull request #93034 from matthias50/matthias50/ensure-vmss-fix
Skip ensuring VMSS in pool for nodes which should be excluded from lb
2020-07-16 06:31:56 -07:00
Mike Spreitzer
57ecea2229 Introduce more metrics on concurrency
Introduce min, average, and standard deviation for the number of
executing mutating and readOnly requests.

Introduce min, max, average, and standard deviation for the number
waiting and number waiting per priority level.

Later:

Revised to use a series of windows

Use three individuals instead of array of powers

Later:

Add coarse queue count metrics, removed windowed avg and stddev

Add metrics for number of queued mutating and readOnly requests,
to complement metrics for number executing.

Later:

Removed windowed average and standard deviation because consumers can
derive such from integrals of consumer's chosen window.

Also replaced "requestKind" Prometheus label with "request_kind".

Later:

Revised to focus on sampling

Make the clock intrinsic to a TimedObserver

... so that the clock can be read while holding the observer's lock;
otherwise, forward progress is not guaranteed (and violations were
observed in testing).

Bug fixes and histogram buckets revision

SetX1 to 1 when queue length limit is zero, beause dividing by zero is nasty.

Remove obsolete argument in gen_test.go.

Add a bucket boundary at 0 for sample-and-water-mark histograms, to
distinguish zeroes from non-zeros.

This includes adding Integrator test.

Simplified test code.

More pervasively used "ctlr" instead of "ctl" as abbreviation for
"controller".
2020-07-15 15:46:05 -04:00
Anish Ramasekar
b1f0e9884a determine the correct ip config based on ip family 2020-07-15 00:27:20 +00:00
Mike Spreitzer
f3fdd5cf9f Add test for windup problem in APF
The current design for Fair Queueing for Server Requests has a
problem: if the min-max fair result stays different from an even
division for a long time and no queue involved in the imbalance goes
empty then the imbalance keeps accruing in queue virtual state times.

This commit adds a test that demonstrates the problem.

It also has some other tweaks to make other tests less flaky.

Factor the big scenario-testing func into pieces, with supporting
structs.
2020-07-14 10:04:58 -04:00
Kubernetes Prow Robot
6079cebfae
Merge pull request #90187 from julianvmodesto/last-applied-updater
Implement server-side apply upgrade and downgrade
2020-07-13 16:45:20 -07:00
Matt Martin
ee8f9f26b9 Skip ensuring VMSS in pool for nodes which should be excluded from lb
Such nodes should not be added to backend pools. This has particular impact
for nodes which are not master nodes (such as nodes running an etcd cluster)
and are incorrectly added to the pool prior to this change.
2020-07-13 13:30:31 -05:00
Kubernetes Prow Robot
240a72b5c0
Merge pull request #88936 from jpbetz/http-trace
Add nested tracing and endpoint filter tracing to apiserver
2020-07-13 11:27:21 -07:00
Kubernetes Prow Robot
bb8a5d2ada
Merge pull request #90959 from ica10888/master
Better understanding of kubectl attach description
2020-07-12 21:04:33 -07:00
Kubernetes Prow Robot
2234e2b9db
Merge pull request #92310 from verb/cli-debug-node+aylei
kubectl debug: support debugging nodes
2020-07-12 17:42:33 -07:00