shashidharatd
d8ff4870cb
Fix goroutine leak in federation service controller
2016-09-23 12:39:54 +05:30
deads2k
483af28944
fix up service lister
2016-09-22 09:12:37 -04:00
Antoine Pelisse
938872582e
Revert "simplify RC and SVC listers"
2016-09-21 15:49:38 -07:00
guangxuli
a6ad0e1a5c
directly break the loop if condition map
2016-09-21 12:56:52 +08:00
deads2k
16fbb47189
fix up service lister
2016-09-20 08:24:33 -04:00
Mike Danese
a765d59932
move informer and controller to pkg/client/cache
...
Signed-off-by: Mike Danese <mikedanese@google.com>
2016-09-15 12:50:08 -07:00
lojies
9498b227a1
change infof to Errorf in some codes
2016-09-12 15:55:42 +08:00
Jedrzej Nowak
6aaad93908
Typos and englishify federation
2016-09-09 09:53:24 +02:00
Kubernetes Submit Queue
83ded2858c
Merge pull request #28568 from xiangpengzhao/check_ensureDnsRecords_return_value
...
Automatic merge from submit-queue
Check return value when calling ensureDnsRecords
When [lockedUpdateDNSRecords](https://github.com/xiangpengzhao/kubernetes/blob/check_ensureDnsRecords_return_value/federation/pkg/federation-controller/service/servicecontroller.go#L723 ) calls `ensureDnsRecords`, it should check the return value. If it returns error, the `ensuredCount ` should not increment.
2016-08-18 16:25:09 -07:00
Jess Frazelle
7e9d82129e
fix go vet errors
...
Signed-off-by: Jess Frazelle <jessfraz@google.com>
fix composites
Signed-off-by: Jess Frazelle <me@jessfraz.com>
2016-08-10 16:45:41 -07:00
Kubernetes Submit Queue
3e006ea298
Merge pull request #29817 from xiangpengzhao/opt-print-info
...
Automatic merge from submit-queue
Separate long comment into lines
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.kubernetes.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/29817 )
<!-- Reviewable:end -->
2016-08-09 20:14:14 -07:00
Kubernetes Submit Queue
2537f66f0e
Merge pull request #29230 from luxas/goimport
...
Automatic merge from submit-queue
Run goimport for the whole repo
While removing GOMAXPROC and running goimports, I noticed quite a lot of other files also needed a goimport format. Didn't commit `*.generated.go`, `*.deepcopy.go` or files in `vendor`
This is more for testing if it builds.
The only strange thing here is the gopkg.in/gcfg.v1 => github.com/scalingdata/gcfg replace.
cc @jfrazelle @thockin
2016-08-05 16:22:01 -07:00
Lucas Käldström
c88a07ce1a
Run goimports
2016-08-02 15:12:39 +03:00
xiangpengzhao
14adb38018
Delete useless code
2016-08-01 13:00:46 -04:00
xiangpengzhao
4ccd90d741
Log error in each loop it appears and fix wrong count of missed cluster.
2016-08-01 06:39:12 -04:00
xiangpengzhao
dfd12276df
Keep track of missed and unensured counts
2016-08-01 05:21:40 -04:00
xiangpengzhao
d4fa23feb8
Check return value when calling ensureDnsRecords
2016-08-01 05:21:40 -04:00
xiangpengzhao
6c9907b042
Separate long comment into lines.
2016-07-29 22:27:24 -04:00
xiangpengzhao
60798e7c48
Keep retry times the same for each place where ensureDnsRecords is called.
2016-07-29 12:30:27 -04:00
Justin Santa Barbara
6463a220ee
Expose Changesets (transactions) in dns provider
...
This makes the dnsprovider usable in more scenarios, and it also solves
some TODOs in the federation code.
2016-07-22 08:43:20 -04:00
k8s-merge-robot
72a697a13d
Merge pull request #28182 from quinton-hoole/2016-06-28-compare-rrsets-properly
...
Automatic merge from submit-queue
Federation: Use equivalent() instead of == to compare DNS ResourceRecordSets. Fixes #28135
Without this we sometimes incorrectly assume that DNS records hosted on cloud DNS servers need to be replaced when they don't need to be. This results in unnecessary churn on DNS records.
cc: @nikhiljindal @madhusudancs @mfanjie FYI
2016-07-22 00:41:06 -07:00
Quinton Hoole
3dd1c0088e
Use ResourceRecordSetsEquivalent() instead of == to compare rrsets. Fixes #28135
2016-07-20 15:49:19 -07:00
nikhiljindal
11ba8943fe
Updating federation controllers to use release_1_4 clientset instead of release_1_3 clientset
2016-07-20 10:56:57 -07:00
Davanum Srinivas
2b0ed014b7
Use Go canonical import paths
...
Add canonical imports only in existing doc.go files.
https://golang.org/doc/go1.4#canonicalimports
Fixes #29014
2016-07-16 13:48:21 -04:00
Matt Liggett
a8b1c2e903
Add printf formatting for rrset objects.
...
Without this you just get two pointers in the debug log.
Before:
I0627 21:48:44.136615 1 dns.go:215] Existing recordset {0xc820168830 0xc820691540} is not equal to needed recordset &{0xc820168848 0xc820686040}, removing existing and adding needed.
After:
I0627 22:26:46.221856 1 dns.go:215] Existing recordset <(clouddns) "federated-service.e2e-tests-service-cuza5.federation.svc.us-central1-c.us-central1.kube.5yetis.net." type=CNAME rrdatas=["federated-service.e2e-tests-service-cuza5.federation.svc.us-central1.kube.5yetis.net."] ttl=180>
I0627 22:26:46.221885 1 dns.go:216] ... not equal to needed recordset <(clouddns) "federated-service.e2e-tests-service-cuza5.federation.svc.us-central1-c.us-central1.kube.5yetis.net." type=CNAME rrdatas=["federated-service.e2e-tests-service-cuza5.federation.svc.us-central1.kube.5yetis.net."] ttl=180>
I0627 22:26:46.221919 1 dns.go:217] ... removing existing and adding needed.
2016-06-30 16:40:44 -07:00
David McMahon
ef0c9f0c5b
Remove "All rights reserved" from all the headers.
2016-06-29 17:47:36 -07:00
nikhiljindal
7fcf8daf6b
Moving federation/v1alpha1 to federation/v1beta1
2016-06-28 17:12:58 -07:00
Quinton Hoole
8d5d7e9013
Address outstanding review comments in #27999 .
2016-06-24 08:35:12 -07:00
Quinton Hoole
6b435a6415
Fixes #27989
2016-06-23 19:06:22 -07:00
k8s-merge-robot
c5afca10f4
Merge pull request #27748 from mfanjie/service-controller
...
Automatic merge from submit-queue
Federation: Improve the handling of service deletion in underlying clusters
fixes #27623
[]()
2016-06-22 16:21:16 -07:00
mfanjie
669bf0773f
add kubernetes service back when it is deleted in kubernetes cluster
2016-06-22 10:46:31 +08:00
k8s-merge-robot
9f06e0f1a6
Merge pull request #27665 from iamthemuffinman/master
...
Automatic merge from submit-queue
Fix spelling errors
2016-06-21 09:54:07 -07:00
k8s-merge-robot
4468e15fc7
Merge pull request #27695 from quinton-hoole/2016-06-17-create-federation-dns-zone-if-missing
...
Automatic merge from submit-queue
Create federation dns zone if missing
1. Added Zones.Add() method to generic dnsprovider interface, as well as Google and AWS implementations.
2. Automatically add the configured zone name to the dnsprovider if it does not already exist.
2016-06-21 07:45:13 -07:00
k8s-merge-robot
d2f5bbc0d7
Merge pull request #27742 from mml/fed-err-shadow
...
Automatic merge from submit-queue
Fix block-local err bug in service_helper.go
2016-06-20 23:33:40 -07:00
Quinton Hoole
c1604d84b8
Added managed zone creation to all dnsproviders.
2016-06-20 22:47:05 -07:00
Matt Liggett
3ec2b19611
Fix block-local err bug in service_helper.go
...
The real error message goes out of scope before we try to log it.
2016-06-20 17:47:43 -07:00
Matt Liggett
3659c6ff32
Check for an error before checking for nil.
...
The error object, if it exists, probably has more specific information
to hand to the caller.
2016-06-20 17:13:16 -07:00
Robert Deusser
cd1450b3ec
Fix spelling errors
...
More spelling fixes
2016-06-20 11:36:11 -04:00
k8s-merge-robot
090e6ff660
Merge pull request #27625 from goltermann/spell2
...
Automatic merge from submit-queue
Fix several spelling errors in comments
What the title says
2016-06-18 23:08:28 -07:00
k8s-merge-robot
0ea74dae5c
Merge pull request #27511 from quinton-hoole/2016-06-15-improve-logging-in-federation-service-controller
...
Automatic merge from submit-queue
Improve error logging on DNS updates for federated services
This makes debugging easier. Prior to this, the logs would e.g. contain "Successfully updated 4 out of 4 DNS records", when in fact zero DNS records had been successfully updated. It's difficult to debug what's happening with such confusing log messages.
2016-06-17 11:24:25 -07:00
goltermann
218645b346
Fix several spelling errors in comments.
2016-06-17 10:41:18 -07:00
mfanjie
8630e46336
only reachable endpoint should be treated as healthy
2016-06-16 11:09:34 +08:00
Quinton Hoole
7b5265c493
Improve error detection and logging on DNS updates for federated services.
2016-06-15 17:30:08 -07:00
mfanjie
dd78dd8e2b
1. ensure dns record when ingress ip is assigned after ready address creation
...
2. ensure dns record removal when service being removed
2016-06-14 15:36:37 +08:00
mfanjie
72a0806103
only update dns records when ready address available for endpoints
2016-06-14 15:36:37 +08:00
mfanjie
318f37ce0f
add federation-name and zone-name as controller manager flags
2016-06-14 15:36:37 +08:00
mfanjie
29cc7c009c
add dns provider initialzation
2016-06-14 15:36:37 +08:00
mfanjie
640d7dc7d1
fix clusterSyncLoop to always update services from latest cache
2016-06-08 15:54:22 +08:00
mfanjie
6dde087f69
change clientset of service controller to versioned one
2016-06-06 17:04:26 +08:00
Quinton Hoole
65e1fecab5
Integrate federated service DNS record management
2016-06-01 16:24:14 -07:00
mfanjie
6133db345f
add federation service controller
2016-05-29 00:25:07 +08:00