Yu-Ju Hong
4a72addaeb
Factor out API defaulting from validation logic
...
Currently, the validation logic validates fields in an object and supply default
values wherever applies. This change factors out defaulting to a set of
defaulting callback functions for decoding (see #1502 for more discussion).
* This change is based on pull request 2587.
* Most defaulting has been migrated to defaults.go where the defaulting
functions are added.
* validation_test.go and converter_test.go have been adapted to not testing the
default values.
* Fixed all tests with that create invalid objects with the absence of
defaulting logic.
2015-02-03 00:55:42 -08:00
Clayton Coleman
a7c9a12286
Add name generation and normalize common create flows
...
Adds `ObjectMeta.GenerateName`, an optional string field that defines
name generation behavior if a Name is not provided.
Adds `pkg/api/rest`, which defines the default Kubernetes API pattern
for creation (and will cover update as well). Will allow registries
and REST objects to be merged by moving logic on api out of those places.
Add `pkg/api/rest/resttest`, which will be the test suite that verifies
a RESTStorage object follows the Kubernetes API conventions and begin
reducing our duplicated tests.
2015-02-02 14:44:53 -05:00
Brian Grant
6e415f760b
Merge pull request #4017 from smarterclayton/relax_annotation_validations
...
Slightly relax annotation validation
2015-02-02 11:42:38 -08:00
Clayton Coleman
b30173658f
Slightly relax annotation validation
...
The more aggressive validation on annotations broke openshift (and
backwards compat for our data). This change relaxes to allow mixed
case so we can continue working in the short term, try to see if we
can agree on relaxation, and if we can't, apply the stronger
validation here.
2015-02-01 19:03:04 -05:00
Vishnu Kannan
5e36f63f8b
Adding ResourceRequirementSpec to v1beta1, v1beta2, and v1beta3 APIs. The old resource
...
quantities 'CPU' and 'Memory' will be preserved until support for v1beta1 and v1beta2 APIs are
dropped.
Improved resource validation in the process.
2015-02-01 02:19:55 +00:00
Deyuan Deng
c793c4f0ab
Sync node status from node controller to master.
2015-01-29 23:17:15 -05:00
Tim Hockin
d01ea11a6e
Merge pull request #3856 from smarterclayton/validation_logic_needs_cleanup
...
Validation of ObjectMeta is inconsistently applied
2015-01-29 14:12:44 -08:00
derekwaynecarr
829fa69527
Introduce a ResourceQuota object
2015-01-28 15:03:19 -05:00
Clayton Coleman
a0356bca96
Unify validation logic for create and update paths
...
Ensure ObjectMeta is consistently validated on both create and update
Make PortalIP uncleareable
2015-01-28 13:10:37 -05:00
derekwaynecarr
74f368f50e
Modified LimitRangeItem.Kind to LimitRangeItem.Type, added example files
2015-01-27 16:41:28 -05:00
derekwaynecarr
091cbe5fa2
Add a limit range resource
2015-01-27 16:41:27 -05:00
Brendan Burns
99583fc8c5
Fix a bug in validation that was leftover from the previous way of externalizing services.
2015-01-26 13:19:27 -08:00
markturansky
131ce993c4
Added validation for annotations
2015-01-26 09:32:09 -05:00
Vishnu Kannan
c32295a180
Adding a 'Typename' strongtype for representing all compute resource types.
2015-01-23 22:17:56 +00:00
Tim Hockin
30219f8dfa
Merge pull request #3664 from thockin/pull-if
...
Pull if
2015-01-21 13:05:28 -08:00
Tim Hockin
81343aac63
Change PullPolicy constants to match
2015-01-21 12:48:56 -08:00
Tim Hockin
819803b79f
Make VolumeSource not be a pointer
...
There's no reason for it to be a pointer.
2015-01-20 17:54:04 -08:00
Brian Grant
dd45246150
Merge pull request #3587 from dchen1107/image
...
Clean up Kubernetes PullPolicy
2015-01-20 17:18:26 -08:00
Tim Hockin
60ec08db93
Rename HostDir to HostPath in v1beta3
2015-01-20 15:56:44 -08:00
Dawn Chen
aec4594a8d
Introduce validatePullPolicyWithDefault to validation.
2015-01-20 11:54:22 -08:00
Tim Hockin
6ff26d924c
Merge pull request #3619 from smarterclayton/expose_validate_labels
...
Expose ValidateLabels in validation.go for reuse by other components
2015-01-20 09:11:08 -08:00
Clayton Coleman
48146e01cd
Expose ValidateLabels in validation.go for reuse by other components
...
Label validation is common to anyone building kube resources.
2015-01-19 22:33:52 -05:00
Andrew Seidl
6dee1d7fa4
Fix typos in user-facing strings
2015-01-18 01:32:34 -06:00
Paul Morie
fd834ae84d
Pods should see services only from their own ns
2015-01-14 17:06:36 -05:00
Tim Hockin
4fcd496d59
change everything to use new util/errors
2015-01-08 22:10:03 -08:00
Daniel Smith
2050131b9a
ParseOrDie -> MustParse; stop returning pointer
2015-01-07 15:21:35 -08:00
Daniel Smith
7f49ba0dcf
Put quantity into packages
...
kubelet, GCE, validation, client
2015-01-07 15:21:34 -08:00
Tim Hockin
1ec3457fc9
Beef up validation tests
2015-01-06 13:02:42 -08:00
Brendan Burns
9884142061
Clear node status before the validation check.
2014-12-22 11:57:31 -08:00
Brendan Burns
36bc3604b9
Merge pull request #2893 from brendandburns/pd3
...
Make it easier to update nodes, make it possible to update capacity.
2014-12-18 10:18:54 -08:00
Brendan Burns
cf0b41535f
Make it easier to update nodes, make it possible to update capacity.
2014-12-17 21:50:26 -08:00
George Kuan
5e1fc1f4e0
Fixes #1605 : make ErrorList introspectable by replacing ErrorList and
...
ErrorList#ToError with []error and util.SliceToError() respectively
2014-12-12 10:56:31 -08:00
Clayton Coleman
19379b5a38
Internal rename api.Minion -> api.Node
2014-12-10 12:08:18 -05:00
Clayton Coleman
2c27f7d332
Allow an empty service
2014-12-09 12:48:53 -05:00
Tim Hockin
89875ef09d
Loosen DNS 952 for labels
2014-12-01 12:30:43 -08:00
Tim Hockin
c857dc1196
Add namespacing for label keys
2014-12-01 12:30:43 -08:00
Tim Hockin
d5a6a54391
clean up error message on labels validation errs
2014-12-01 12:30:43 -08:00
Tim Hockin
b08e5b24b0
Change ValidationError to a pointer
...
In Prep for adding at leats one more field, make this operate more list
StatusError.
2014-11-24 17:28:42 -08:00
Deyuan Deng
b5fce5021f
gitrepo validation
2014-11-23 23:03:11 -05:00
Deyuan Deng
a4e7604266
Merge pull request #2478 from smarterclayton/refactor_minion_to_match_v1beta3
...
Move the internal minion representation to match v1beta3
2014-11-20 21:37:43 -05:00
Clayton Coleman
156000ef6d
Move the internal minion representation to match v1beta3
...
Moves to 'Spec' and 'Status' internally and removes duplicate
fields. Moves Capacity into Spec and drops use of NodeResources
2014-11-20 20:53:08 -05:00
Tim Hockin
ea960711ff
Clean up error logs.
...
Use %v for errors, tidy some messages, make error messages start lowe-case
(as per go guidelines). Just accumulated nits.
2014-11-21 09:45:26 +08:00
markturansky
8af4ccb111
v1beta3 Pod refactor
2014-11-18 09:25:42 -05:00
Deyuan Deng
a07661dcea
Add pod restart policy validation for replication controller.
2014-11-17 23:08:23 -05:00
Deyuan Deng
c20ceea170
Add more validation for updating node.
2014-11-17 13:42:31 -05:00
Daniel Smith
0348a67413
Merge pull request #2195 from smarterclayton/prepare_pod_template_v1beta3
...
Allow an internal pod template reference or object
2014-11-12 10:55:08 -08:00
derekwaynecarr
b326cbbe0c
Centralize minion validation
2014-11-12 12:38:15 -05:00
Clayton Coleman
72bf12c86d
Update the validation logic to test PodTemplateSpec
2014-11-10 11:33:51 -05:00
Brian Grant
535785e3b9
Update api/validation service validation with service fields moved by #2086
2014-11-05 06:52:06 +00:00
bgrant0607
fc0dab630c
Merge pull request #2086 from markturansky/v1beta3_refactor
...
Refactor internal API for Services to match v1beta3
2014-11-04 21:48:02 -08:00