github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
121,600 Commits 1 Branch 31 Tags 1,019 MiB
4ed7f6b4c4
Commit Graph

1380 Commits

Author SHA1 Message Date
Ziqi Zhao
dfc1838379 Migrated pkg/controller/volume|util|replicaset|nodeipam to contextual logging 
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
 2023-07-06 07:39:52 +08:00
Patrick Ohly
02efe09abe component-base/logs: improve handling of re-applying a configuration 
Normal binaries should never have to do this. It's not safe when there are
already some goroutines running which might do logging. Therefore the new
default is to return an error when a binary accidentally re-applies.

A few unit ensure that there are no goroutines and have to call the functions
more then once. The new ResetForTest API gets used by those to enable changing the
logging settings more than once in the same process.

Integration tests use the same code as the normal binaries. To make reuse of
that code safe, component-base/logs can be configured to silently ignore any
additional calls. This addresses data races that were found when enabling -race
for integration tests. To catch cases where the integration test does want
to modify the config, the old and new config get compared and an error is
raised when it's not the same.

To avoid having to modify all integration tests which start test servers,
reconfiguring component-base/logs is done by the test server packages.
 2023-07-05 19:08:54 +02:00
Patrick Ohly
7f5a02fc7e dra resourceclaim controller: enhance logging 
Adding logging to event handlers makes it more obvious why (or why not) claims
and pods need to be processed.
 2023-07-05 16:10:20 +02:00
Kubernetes Prow Robot
52457842d1
Merge pull request #117055 from cyclinder/csi_migration 
remove CSI-migration gate
 2023-06-28 04:28:31 -07:00
Kubernetes Prow Robot
4f6a750bbf
Merge pull request #115813 from atiratree/controller-aliases 
Introduce controller aliases for KCM and CCM
 2023-06-22 04:55:39 -07:00
Kubernetes Prow Robot
28296ba59e
Merge pull request #113994 from mengjiao-liu/contextual-logging-controller-certificates 
certificate controller: use contextual logging
 2023-06-21 09:03:42 -07:00
Filip Křepinský
4e6a3fb9c1 deduplicate cloud provider controller names 
and move the to cloud-provider module
 2023-06-19 15:01:01 +02:00
Filip Křepinský
e5f5a9bfdb use controller names for CLI FlagSets to show the names in help 2023-06-19 15:01:01 +02:00
Filip Křepinský
cd56748ec5 reference controllers correctly from CLI help 2023-06-19 15:01:01 +02:00
Filip Křepinský
94792d85de simplify TestValidateControllersOptions test 2023-06-19 15:00:59 +02:00
Filip Křepinský
9730951136 introduce KCM controller aliases and unify controller names 2023-06-19 14:59:33 +02:00
Kubernetes Prow Robot
47e79b8156
Merge pull request #116910 from fatsheep9146/job-controller-contextual-logging 
Migrated pkg/controller/job to contextual logging
 2023-06-14 08:00:18 -07:00
Ziqi Zhao
7bc449d7e0 add contextual logging to job-controller 
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
 2023-06-14 13:40:02 +08:00
carlory
5e048041e4 remove helper function for unused storage feature in pkg/proxy/util 2023-06-13 09:22:59 +08:00
Kubernetes Prow Robot
32048b1467
Merge pull request #117550 from borgerli/cron-job-syncs 
add --concurrent-cron-job-syncs flag for kube-controller-manager
 2023-06-12 13:46:19 -07:00
Kubernetes Prow Robot
8a0b1bbf24
Merge pull request #118095 from carlory/patch-002 
remove unused pv informer from expand_controller
 2023-06-12 11:43:58 -07:00
cyclinder
8e4228a8c1 remove CSI-migration gate 2023-06-04 18:40:17 +08:00
Andy Zhang
1ce285ad3d
Revert "removed the deprecated azureFile in-tree storage plugin" 2023-06-02 10:20:53 +08:00
carlory
07a1aea2de remove unused cloudprovider param from the ProbeControllerVolumePlugins func 2023-05-31 23:08:41 +08:00
Kubernetes Prow Robot
a6f641b656
Merge pull request #118236 from andyzhangx/remove-azurefile 
removed the deprecated `azureFile` in-tree storage plugin
 2023-05-29 09:25:54 -07:00
tinatingyu
133eff3df4 implement LegacyServiceAccountTokenCleanUp alpha 2023-05-24 23:20:17 +00:00
andyzhangx
485d1631cd Remove Azure file in-tree storage plugin 2023-05-24 14:10:34 +00:00
carlory
bea71a3e4e remove unused pv informer from expand_controller 2023-05-18 15:58:38 +08:00
Joe Betz
f0f92853ad Add api-machinery TL owners permissions for jpbetz 2023-05-15 11:09:54 -04:00
Daniel Smith
1ffe3f467e lavalamp is taking a long break 2023-05-11 16:43:38 +00:00
Li Bo
f9bab9a60b add --concurrent-cron-job-syncs flag 2023-04-24 18:28:14 +08:00
Kubernetes Prow Robot
c3e3ff989a
Merge pull request #116896 from thockin/apimachinery_util_diff_cleanup 
apimachinery util/diff cleanups
 2023-04-13 02:26:37 -07:00
Kubernetes Prow Robot
5d8c99a6fe
Merge pull request #117138 from tosi3k/job-syncs 
Add `--concurrent-job-syncs` flag to kube-controller-manager
 2023-04-12 09:58:42 -07:00
Tim Hockin
bc302fa414
Replace uses of ObjectReflectDiff with cmp.Diff 
ObjectReflectDiff is already a shim over cmp.Diff, so no actual output
or behavior changes
 2023-04-12 08:48:03 -07:00
Antoni Zawodny
c69689659a Add --concurrent-job-syncs flag to kube-controller-manager 2023-04-12 14:19:39 +02:00
Kubernetes Prow Robot
2308086e29
Merge pull request #116503 from codetalks-new/br_fix_text 
[fix][typing] startResourceClaimController errrorf message has typos
 2023-04-11 23:18:31 -07:00
Mengjiao Liu
017bb93887 certificate controller: use contextual logging 2023-03-15 11:26:08 +08:00
Kubernetes Prow Robot
27e23bad7d
Merge pull request #116529 from pohly/controllers-with-name 
kube-controller-manager: convert to structured logging
 2023-03-14 14:12:55 -07:00
Kubernetes Prow Robot
466c48bdc7
Merge pull request #116002 from charles-chenzz/master 
resourceClaimController should be registered like the others one to keep code clean
 2023-03-14 14:12:40 -07:00
Patrick Ohly
99151c39b7 kube-controller-manager: convert to structured logging 
Most of the individual controllers were already converted earlier. Some log
calls were missed or added and then not updated during a rebase. Some of those
get updated here to fill those gaps.

Adding of the name to the logger used by each controller gets
consolidated in this commit. By using the name under which the
controller is registered we ensure that the names in the log
are consistent.
 2023-03-14 19:16:32 +01:00
Kubernetes Prow Robot
49649c89ea
Merge pull request #113584 from yangjunmyfm192085/volume-contextual-logging 
volume: use contextual logging
 2023-03-14 10:40:16 -07:00
Kubernetes Prow Robot
f769c66aa8
Merge pull request #113622 from 249043822/br-context-logging-daemon 
daemonset: use contextual logging
 2023-03-14 09:38:28 -07:00
Patrick Ohly
29941b8d3e api: resource.k8s.io v1alpha1 -> v1alpha2 
For Kubernetes 1.27, we intend to make some breaking API changes:
- rename PodScheduling -> PodSchedulingHints (https://github.com/kubernetes/kubernetes/issues/114283)
- extend ResourceClaimStatus (https://github.com/kubernetes/enhancements/pull/3802)

We need to switch from v1alpha1 to v1alpha2 for that.
 2023-03-14 07:52:03 +01:00
ZhangKe10140699
7198bcffcd daemonset: use contextual logging 2023-03-14 08:50:27 +08:00
杨军10092085
361e4ff0fa volume: use contextual logging 2023-03-14 08:37:30 +08:00
Kubernetes Prow Robot
02a654a635
Merge pull request #116043 from sanposhiho/featuregate-check 
fix(HPA): ignore the container resource metrics in HPA controller when the feature gate is disabled
 2023-03-13 12:14:50 -07:00
Kubernetes Prow Robot
3106a5c553
Merge pull request #116301 from andyzhangx/remove-azuredisk-code 
Remove Azure disk in-tree storage plugin
 2023-03-13 10:38:48 -07:00
Kubernetes Prow Robot
a0b1bee7c5
Merge pull request #115840 from atosatto/remove-taint-manager-cli 
Remove enable-taint-manager and pod-eviction-timeout CLI flags
 2023-03-13 08:13:10 -07:00
Kubernetes Prow Robot
492a08c916
Merge pull request #113525 from 249043822/br-context-logging-deployment 
deployment controller: use contextual logging
 2023-03-13 08:13:02 -07:00
Kubernetes Prow Robot
185cd95b9c
Merge pull request #113443 from yangjunmyfm192085/namespace-contextual-logging 
namespace controller: use contextual logging
 2023-03-13 04:34:44 -07:00
ZhangKe10140699
66bda6c092 deployment controller: use contextual logging 2023-03-13 19:00:44 +08:00
JunYang
f5bd8c86d4 namespace controller: use contextual logging 2023-03-13 14:59:17 +08:00
Kubernetes Prow Robot
16bc942a6b
Merge pull request #113464 from mengjiao-liu/contextual-logging-controller-bootstrap 
Migrate `pkg/controller/bootstrap` to contextual logging
 2023-03-12 20:12:42 -07:00
Mengjiao Liu
e56f3e0781 Migrate pkg/controller/bootstrap to contextual logging 2023-03-13 10:18:40 +08:00
codetalks
c94bcabd7e [fix][typing] startResourceClaimController errrorf message has typos 2023-03-12 12:06:33 +08:00
Kubernetes Prow Robot
c88b61f553
Merge pull request #113910 from mengjiao-liu/contextual-logging-pkg-controller-certificates 
clusterroleaggregation: use contextual logging
 2023-03-10 04:34:50 -08:00
Kubernetes Prow Robot
cb00077cd3
Merge pull request #113471 from ncdc/gc-contextual-logging 
garbagecollector: use contextual logging
 2023-03-10 04:34:39 -08:00
andyzhangx
5d0a54dcb5 remove Azure Disk in-tree driver code 
fix
 2023-03-09 13:24:08 +00:00
Andy Goldstein
26e3dab78b garbagecollector: use contextual logging 
Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
 2023-03-08 08:37:56 -05:00
ZhangKe10140699
a239b9986b Migrated the StatefulSet controller (within `kube-controller-manager) to use [contextual logging](https://k8s.io/docs/concepts/cluster-administration/system-logs/#contextual-logging) 2023-03-08 18:57:57 +08:00
Andrea Tosatto
cae19f9e85 Remove deprecated pod-eviction-timeout flag from controller-manager 2023-03-07 18:14:18 +00:00
kerthcet
98bbeae99f address comments 
Signed-off-by: kerthcet <kerthcet@gmail.com>
 2023-03-07 18:11:51 +00:00
kerthcet
15daa48e30 Deprecate CLI flag pod-eviction-timeout 
Signed-off-by: kerthcet <kerthcet@gmail.com>
 2023-03-07 18:11:51 +00:00
kerthcet
e5c812bbe7 Remove CLI flag enable-taint-manager 
Signed-off-by: kerthcet <kerthcet@gmail.com>
 2023-03-07 18:11:49 +00:00
Kubernetes Prow Robot
37326f7cea
Merge pull request #112670 from yangjunmyfm192085/delklogV0 
use contextual logging（nodeipam and nodelifecycle part）
 2023-03-07 09:40:33 -08:00
Kubernetes Prow Robot
4401af2c3e
Merge pull request #116219 from SataQiu/fix-kube-controller-manager-20230302 
kube-controller-manager: fix a bug that the kubeconfig field of kubecontrollermanager.config.k8s.io configuration is not populated correctly
 2023-03-07 08:28:46 -08:00
Kubernetes Prow Robot
637bd66165
Merge pull request #115332 from obaranov1/ttlafterfinished-logging-migration 
Migrate /pkg/controller/ttlafterfinished to structured and contextual logging
 2023-03-07 04:20:08 -08:00
Naman Lakhwani
b6f9a65558
Migrating pkg/controller/serviceaccount to contextual logging (#114918) 
* migrating pkg/controller/serviceaccount to contextual logging

Signed-off-by: Naman <namanlakhwani@gmail.com>

* small nit

Signed-off-by: Naman <namanlakhwani@gmail.com>

* capitalising first letter of error

Signed-off-by: Naman <namanlakhwani@gmail.com>

* addressed review comments

Signed-off-by: Naman <namanlakhwani@gmail.com>

* small nit to add key

Signed-off-by: Naman <namanlakhwani@gmail.com>

---------

Signed-off-by: Naman <namanlakhwani@gmail.com>
 2023-03-07 04:19:59 -08:00
Naman Lakhwani
8f45b64c93
Migrated pkg/controller/replicaset to contextual logging (#114871) 
* migrated controller/replicaset to contextual logging

Signed-off-by: Naman <namanlakhwani@gmail.com>

* small nits

Signed-off-by: Naman <namanlakhwani@gmail.com>

* addressed changes

Signed-off-by: Naman <namanlakhwani@gmail.com>

* small nit

Signed-off-by: Naman <namanlakhwani@gmail.com>

* taking t as input

Signed-off-by: Naman <namanlakhwani@gmail.com>

---------

Signed-off-by: Naman <namanlakhwani@gmail.com>
 2023-03-07 04:19:51 -08:00
Kubernetes Prow Robot
4aaa4df840
Merge pull request #113986 from songxiao-wang87/runwxs-test2 
Migrate StorageVersionGC to contextual logging
 2023-03-07 04:19:43 -08:00
Kubernetes Prow Robot
471b392f43
Merge pull request #113916 from songxiao-wang87/runwxs-test1 
Migrate ttl_controller to contextual logging
 2023-03-07 04:18:30 -08:00
Kubernetes Prow Robot
3489796d5c
Merge pull request #113428 from mengjiao-liu/contextual-logging-controller-cronjob 
Update `pkg/controller/cronjob/` for contextual logging
 2023-03-07 01:28:18 -08:00
JunYang
780ef3afb0 use klog.InfoS instead of klog.V(0),Info 2023-03-07 15:50:01 +08:00
torredil
6aebda9b1e Remove AWS legacy cloud provider + EBS in-tree storage plugin 
Signed-off-by: torredil <torredil@amazon.com>
 2023-03-06 14:01:15 +00:00
SataQiu
eb541bb819 controller-manager: fix a bug that the kubeconfig field of kubecontrollermanager.config.k8s.io configuration is not set correctly 2023-03-04 11:17:55 +08:00
Kensei Nakada
33daba24fb fix(HPA): ignore the container resource metrics in HPA controller when the feature gate is disabled 2023-02-25 23:04:07 +00:00
charles-chenzz
0891ba9739 resourceClaimController should be registered like the others one to keep code clean 2023-02-23 17:26:30 +08:00
obaranov1
21adaa1490 logging migration of the ttlafterfinished 
Signed-off-by: Oksana Baranova <oksana.baranova@intel.com>
 2023-02-21 14:55:03 +02:00
Kubernetes Prow Robot
d9ed2ff4b0
Merge pull request #114687 from freddie400/migrate-hpa 
Migrate pkg/controller/podautoscaler to contextual logging
 2023-02-17 05:44:03 -08:00
Freddie
dee494ece1 squashing without rebase 2023-02-17 01:47:52 +05:30
Andy Goldstein
71ec5ed81d
resourcequota: use contexual logging (#113315) 
Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
 2023-02-14 07:19:31 -08:00
Artem Minyaylov
f573e14942 Update k8s.io/utils to latest version 
Update all usages of FakeExec to pointer to avoid copying the mutex
 2023-02-04 11:05:22 -08:00
Mengjiao Liu
6f2cd1b5bd Update pkg/controller/cronjob/ for contextual logging 2023-02-02 14:27:13 +08:00
songxiao-wang87
8c7f3c2116 Making a run test. 
Signed-off-by: songxiao-wang87 <wang.xiaosong23@zte.com.cn>
 2023-01-28 03:14:57 +00:00
Lucas Severo Alves
096d2e5895 remove unwanted newlines 2023-01-24 21:45:32 +01:00
Lucas Severo Alves
636f8e1a3e chore: changes needed before #111155 2023-01-24 17:55:32 +01:00
Clayton Coleman
95051a63b3
wait: Use a context implementation for ContextForChannel 
ContextForChannel uses a goroutine to transform a channel close to
a context cancel. However, this exposes a synchronization issue if
we want to unify the underlying implementation between contextless
and with context - a ConditionFunc that closes the channel today
expects the behavior that no subsequent conditions will be invoked
(we have a test in wait_test.go TestUntilReturnsImmediately that
verifies this expectation). We can't unify the implementation
without ensuring this property holds.

To do that this commit changes from the goroutine propagation to
implementing context.Context and using stopCh as the Done(). We
then implement Err() by returning context.Canceled and stub the
other methods. Since our context cannot be explicitly cancelled
by users, we cease to return the cancelFn and callers that need
that behavior must wrap the context as normal.

This should be invisible to clients - they would already observe
the same behavior from the context, and the existing error
behavior of Poll* is preserved (which ignores ctx.Err()).

As a side effect, one less goroutine is created making it more
efficient.
 2023-01-18 10:00:47 -05:00
Andrew Sy Kim
99d83fac37 kube-controller-manager: don't run cloud IPAM controller when cloud provider is not enabled 
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
 2022-12-20 10:29:02 -05:00
Jordan Liggitt
78cb3862f1
Fix indentation/spacing in comments to render correctly in godoc 2022-12-17 23:27:38 -05:00
Shihang Zhang
4fd09a06d6 lock LegacyServiceAccountTokenNoAutoGeneration 2022-12-16 10:45:35 -08:00
TommyStarK
454290c583 cmd/kube-controller-manager/app/options: Improving test coverage 
Add a snippet of the expected error string related to the aspect being tested

Signed-off-by: TommyStarK <thomasmilox@gmail.com>
 2022-12-13 14:05:48 +01:00
TommyStarK
270141aa0b cmd/kube-controller-manager/app/options: Improving test coverage 
Signed-off-by: TommyStarK <thomasmilox@gmail.com>
 2022-12-10 13:36:12 +01:00
Mengjiao Liu
c28b287253 clusterroleaggregation: use contextual logging 2022-12-09 11:02:47 +08:00
songxiao-wang87
9ae5af4b6a StorageVersionGC logger 
Signed-off-by: songxiao-wang87 <wang.xiaosong23@zte.com.cn>
 2022-11-23 03:20:12 +00:00
Patrick Ohly
0133df3929 kube-controller-manager: add ResourceClaim controller 
The controller uses the exact same logic as the generic ephemeral inline volume
controller, just for inline ResourceClaimTemplate -> ResourceClaim.

In addition, it supports removal of pods from the ReservedFor field when those
pods are known to not need the claim anymore. At the moment, only this special
case is supported. Removal of arbitrary objects would imply granting full read
access to all types to determine whether a) an object is gone and b) if the
current incarnation is the one which is listed in ReservedFor. This may get
added later.
 2022-11-10 20:23:50 +01:00
Kubernetes Prow Robot
2f22404003
Merge pull request #113747 from thockin/safer-controller-init-map 
Make static controller registration slightly safer
 2022-11-08 12:43:25 -08:00
Tim Hockin
d577e2bfb1
Make static controller registration slightly safer 
As we have more and more of these, the risk of a dup name seems
non-zero.
 2022-11-08 09:44:19 -08:00
kerthcet
b6d021b7e3 Deprecate CLI flag pod-eviction-timeout in KCM 
Signed-off-by: kerthcet <kerthcet@gmail.com>
 2022-11-08 00:21:56 +08:00
PingWang
015ca0c6a5 Correct some incorrect comments 
Signed-off-by: PingWang <wang.ping5@zte.com.cn>
 2022-10-26 10:06:24 +08:00
Kubernetes Prow Robot
85643c0f93
Merge pull request #108501 from zroubalik/hpa 
add `--concurrent-horizontal-pod-autoscaler-syncs` flag to kube-controller-manager
 2022-10-17 14:13:18 -07:00
Zbynek Roubalik
1cefcdea2d add --concurrent-horizontal-pod-autoscaler-syncs flag to kube-controller-manager 
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
 2022-10-17 17:39:31 +02:00
Han Kang
2bbd445f50 remove rate limiter metric as it is not in use 
Change-Id: I91157653e3860eeecc3f572aee88da6ffc65faed
 2022-10-13 13:07:11 -07:00
Han Kang
bd2417b435 add 'metrics/slis' to kcm health checks 
Change-Id: I8c2114e538bb417deff8c3f9f107758c089227dc
 2022-10-11 09:18:42 -07:00
Han Kang
e95179ffb6 Wire up feature_gate.go with metrics via AddMetrics method 
wire up feature_gate.go with metrics via AddMetrics method

Change-Id: I9b4f6b04c0f4eb9bcb198b16284393d21c774ad8

wire in metrics to kubernetes components

Change-Id: I6d4ef8b26f149f62b03f32d1658f04f3056fe4dc

rename metric since we're using the value to determine if enabled is true or false

Change-Id: I13a6b6df90a5ffb4b9c5b34fa187562413bea029

Update staging/src/k8s.io/component-base/featuregate/feature_gate.go

Co-authored-by: Jordan Liggitt <jordan@liggitt.net>
 2022-09-26 08:44:42 -07:00
Kubernetes Prow Robot
ee94dce5b1
Merge pull request #112015 from humblec/glusterfs-gone 
Removal of GlusterFS code from the repo
 2022-09-14 10:03:00 -07:00