Commit Graph

7375 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
72418519ff Merge pull request #75865 from xichengliudui/fixshellcheckfailure-03
Fix shellcheck failures in godep-save.sh and godep-restore.sh
2019-03-30 15:57:08 -07:00
Kubernetes Prow Robot
66dad3bb09 Merge pull request #75868 from xichengliudui/patch-4
Add @xichengliudui to hack/OWNERS reviewers
2019-03-29 23:53:21 -07:00
Kubernetes Prow Robot
c7a8596a39 Merge pull request #75867 from SataQiu/fix-kubeadm-golint-20190329
Fix golint failures in cmd/kubeadm/app/util/system
2019-03-29 17:33:57 -07:00
Kubernetes Prow Robot
259f706c73 Merge pull request #75834 from jlucktay/golint_pkg/auth/authorizer/abac
Golint pkg/auth/authorizer/abac
2019-03-29 11:48:50 -07:00
Kubernetes Prow Robot
733f2478d3 Merge pull request #75584 from SataQiu/fix-golint-20190322
fix some golint failures in pkg/apis
2019-03-29 10:28:40 -07:00
James Lucktaylor
dbb696508a Enact golint recommendations per issue 68026.
Remove the 'abac' package from the golint exclusion list.
Add/edit comments per golint feedback.
Set PolicyList to be exported, as not exporting was breaking one of
golint's rules around exported funcs returning an unexported type.
Fix a broken test
2019-03-29 12:50:31 +00:00
lIuDuI
6f970d3d70 Update OWNERS 2019-03-29 12:15:39 +08:00
SataQiu
a41c85ea07 fix golint failures in cmd/kubeadm/app/util/system 2019-03-29 12:03:25 +08:00
Sean Sullivan
d4d6e19f1e kubectl: removes pkg/version dependency 2019-03-28 16:08:34 -07:00
fabriziopandini
2cb2a979d4 e2e-kubeadm-first-class 2019-03-28 16:29:56 +01:00
Kubernetes Prow Robot
f6c51d6e99 Merge pull request #75751 from BenTheElder/bash-fun
fix kube::golang::is_instrumented_package
2019-03-26 23:19:01 -07:00
Kubernetes Prow Robot
29353452c4 Merge pull request #75668 from bart0sh/PR0068-hack-lib-golang.sh-fix-mac-build
fix 'make generated_files' build on MacOS
2019-03-26 20:45:01 -07:00
Kubernetes Prow Robot
d24fe8a801 Merge pull request #75735 from andrewsykim/update-install-etcd-link
fix link to etcd install docs for integration tests
2019-03-26 18:11:29 -07:00
Kubernetes Prow Robot
4b3eb60081 Merge pull request #75531 from dims/add-new-staging-repository-for-cri-api
New staging repository for cri-api
2019-03-26 18:10:49 -07:00
Benjamin Elder
0833a9cc38 fix kube::golang::is_instrumented_package 2019-03-26 17:17:16 -07:00
Davanum Srinivas
33081c1f07 New staging repository for cri-api
Change-Id: I2160b0b0ec4b9870a2d4452b428e395bbe12afbb
2019-03-26 18:21:04 -04:00
Kubernetes Prow Robot
2086f81546 Merge pull request #74678 from pmcalpine/lint-bs_cj
Fix some golint failures for pkg/controller
2019-03-26 15:10:16 -07:00
Andrew Sy Kim
e26157df07 fix link to etcd install docs 2019-03-26 13:40:18 -04:00
Ed Bartosh
3d5d38607d fix 'make generated_files' build on MacOS
Recent change to hack/lib/golang.sh broke the build on MacOS this way:

$ make clean && make generated_files
+++ [0325 13:38:22] Verifying Prerequisites....
+++ [0325 13:38:23] Removing _output directory
k8s.io/kubernetes/vendor/github.com/spf13/pflag
k8s.io/kubernetes/hack/make-rules/helpers/go2make
+++ [0325 13:38:40] Building go targets for darwin/amd64:
    ./vendor/k8s.io/code-generator/cmd/deepcopy-gen
can't load package: package k8s.io/kubernetes: no Go files in k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes
!!! [0325 13:38:40] Call tree:
!!! [0325 13:38:40]  1: k8s.io/kubernetes/hack/lib/golang.sh:629 kube::golang::build_some_binaries(...)
!!! [0325 13:38:40]  2: k8s.io/kubernetes/hack/lib/golang.sh:764 kube::golang::build_binaries_for_platform(...)
!!! [0325 13:38:40]  3: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
make[1]: *** [_output/bin/deepcopy-gen] Error 1
make: *** [generated_files] Error 2

It was caused by 'binaries' array not being declared with 'local -a'.
It looks like MacOS' old bash version makes an array to contain first
empty element if declared this way.

The fix has been tested on MacOS High Sierra and Linux openSUSE 42.3 (x86_64)

Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
2019-03-25 17:08:13 +01:00
s-ito-ts
8cc3718e69 fix eliminate shellcheck failures in hack/local-up-cluster.sh 2019-03-25 07:17:06 +00:00
SataQiu
f82fb4059d fix some failures in pkg/apis 2019-03-23 12:20:49 +08:00
Kubernetes Prow Robot
9c53f24012 Merge pull request #75179 from rosti/kill-v1alpha3
kubeadm: remove v1alpha3
2019-03-22 17:02:21 -07:00
Kubernetes Prow Robot
ffd8f3dacb Merge pull request #73255 from ds-ms/golint
Fix linting issues in pkg/kubectl/cmd/version
2019-03-22 17:02:08 -07:00
Kubernetes Prow Robot
a3bc56fffb Merge pull request #74746 from oomichi/golint-e2e-framework-gce
Fix golint failures under test/e2e/[..]/gce
2019-03-22 15:46:08 -07:00
Kubernetes Prow Robot
fcb102b2a4 Merge pull request #75158 from k-toyoda-pi/fix_shellcheck_failure_golang_sh
fix eliminate shellcheck failures in hack/lib/golang.sh
2019-03-22 14:09:37 -07:00
Kenichi Omichi
da7c9f70c3 Fix golint failures under test/e2e/[..]/gce
This fixes golint failures under test/e2e/framework/providers/gce/.

Cleanup:
* FirewallTimeoutDefault is not used at all, so remove it.
* FirewallTestTcpTimeout, FirewallTestHttpPort and FirewallTestUdpPort
  are used at test/e2e/network/firewall.go only. So move them.
2019-03-22 15:59:17 +00:00
Kubernetes Prow Robot
22621ca415 Merge pull request #74739 from moshe010/nokubeproxy
Add nokubeproxy option in START_MODE
2019-03-21 22:50:44 -07:00
Kubernetes Prow Robot
51b5d28c15 Merge pull request #74333 from SataQiu/fix-shell-20190221
Fix some shellcheck failures in hack
2019-03-21 22:50:18 -07:00
Kubernetes Prow Robot
4c16fb78b3 Merge pull request #74242 from xichengliudui/fixshellcheck19021903
fix shellcheck in hack/make-rules/...
2019-03-21 21:36:17 -07:00
toyoda
a52af3a9d5 fix shellcheck failure golang.sh 2019-03-22 13:29:26 +09:00
Kubernetes Prow Robot
c48ed1c5ac Merge pull request #74356 from oomichi/golint-e2e-framework-kubemark
Fix golint failures for e2e/[..]/kubemark
2019-03-21 19:26:32 -07:00
Kubernetes Prow Robot
4499275cb9 Merge pull request #72800 from stewart-yu/stewart-component-base
Move config local to every controller in KCM
2019-03-21 19:26:19 -07:00
aaa
64f8f30c07 fix shellcheck failures in ./hack/jenkins/... 2019-03-21 05:30:11 -04:00
aaa
f82870291f Fix shellcheck failures in godep-save.sh and godep-restore.sh
update pull request

update pull request
2019-03-21 05:02:47 -04:00
SataQiu
112af136df update verify-staging-meta-files.sh 2019-03-21 12:44:39 +08:00
Han Kang
a5ddc3943a bump required minimum go version to 1.12.1 (strings package compatibility) 2019-03-20 16:07:07 -07:00
aaa
46799b6dd4 Fix shellcheck failures in bootstrap.sh and create_block.sh 2019-03-20 17:37:50 -04:00
Kubernetes Prow Robot
481de197c0 Merge pull request #75156 from smarterclayton/diff_invalid
Handle nil interface inputs to diff.ObjectReflectDiff
2019-03-20 00:55:01 -07:00
Kubernetes Prow Robot
6a2936dcbf Merge pull request #74642 from SataQiu/fix-golint-20190227
Fix golint failures in client-go/scale/scheme/appsint, client-go/scale/scheme/extensionsint, client-go/scale/scheme
2019-03-19 20:14:54 -07:00
Kubernetes Prow Robot
d261549a1c Merge pull request #71813 from booxter/make-update-errors-visibility
Expose errors from godep_restored to caller
2019-03-19 19:00:25 -07:00
Peter McAlpine
ac88e13821 Fix lint warnings in pkg/controller/cronjob. 2019-03-19 14:36:26 -04:00
Peter McAlpine
4cfcf0519d Fix lint warnings in pkg/controller/bootstrap 2019-03-19 14:36:26 -04:00
Moshe Levi
dcebfd82ac Add nokubeproxy option in START_MODE
Some CNIs such as OVN don't use kubeproxy and provide
there own implementation for network proxy .
This patch allow to disable the kubeproxy start in the
local-up-cluster.sh script.

It is also move the generation of the certificate and
kubeconfig to  start_kubeproxy function so it will be
generated only when it needed.

This is useful for us for developement and CI testing.
Signed-off-by: Moshe Levi <moshele@mellanox.com>
2019-03-14 02:29:31 +02:00
Haowei Cai
2fde54c1f3 staging: include generated code in godep verification
as we now commit up-to-date generated definitions in
apiextensions-apiserver
2019-03-13 17:11:05 -07:00
Haowei Cai
5d0bef342a apiextensions: commit generated openapi definition 2019-03-13 15:15:34 -07:00
Davanum Srinivas
eb4865fbe5 Hack to ignore stale packages in godep
Change-Id: Ibf0877521310d6f2baad605bf1216940e95cb9cd
2019-03-12 09:49:03 -04:00
Kubernetes Prow Robot
f71ac0fc5f Merge pull request #75048 from dims/add-verify-check-for-publish-bot-dependencies
verify script to ensure publishing bot rules and godeps are in sync
2019-03-08 15:41:11 -08:00
Kubernetes Prow Robot
9fd3d2718b Merge pull request #75184 from liggitt/verify-godeps-generated
ignore uncommitted generated openapi files in verify-godeps
2019-03-08 14:19:47 -08:00
Jordan Liggitt
060e44ae85 ignore uncommitted generated openapi files in verify-godeps 2019-03-08 11:46:11 -05:00
Kubernetes Prow Robot
f229aa0ad6 Merge pull request #75044 from errordeveloper/move-cli-runtime-subpackages
Move printers & resources packages
2019-03-08 05:43:26 -08:00