github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
105,139 Commits 1 Branch 31 Tags
51b94de68f0889e4e9bd5bc7673041f1275ca175
Commit Graph

43518 Commits

Author SHA1 Message Date
Shivanshu Raj Shrivastava
3c87c43cef Migrated scheduler files server.go, node_label.go, csi.go, non_csi.go to structured logging (#105855) 
* migrated server.go

* fixed migration

* resolving review comments

* added storageClass

* review comments

* review comments
 2021-10-26 13:21:22 -07:00
Francesco Romani
2f426fdba6 devicemanager: checkpoint: support pre-1.20 data 
The commit a8b8995ef2
changed the content of the data kubelet writes in the checkpoint.
Unfortunately, the checkpoint restore code was not updated,
so if we upgrade kubelet from pre-1.20 to 1.20+, the
device manager cannot anymore restore its state correctly.

The only trace of this misbehaviour is this line in the
kubelet logs:
```
W0615 07:31:49.744770    4852 manager.go:244] Continue after failing to read checkpoint file. Device allocation info may NOT be up-to-date. Err: json: cannot unmarshal array into Go struct field PodDevicesEntry.Data.PodDeviceEntries.DeviceIDs of type checkpoint.DevicesPerNUMA
```

If we hit this bug, the device allocation info is
indeed NOT up-to-date up until the device plugins register
themselves again. This can take up to few minutes, depending
on the specific device plugin.

While the device manager state is inconsistent:
1. the kubelet will NOT update the device availability to zero, so
   the scheduler will send pods towards the inconsistent kubelet.
2. at pod admission time, the device manager allocation will not
   trigger, so pods will be admitted without devices actually
   being allocated to them.

To fix these issues, we add support to the device manager to
read pre-1.20 checkpoint data. We retroactively call this
format "v1".

Signed-off-by: Francesco Romani <fromani@redhat.com>
 2021-10-26 09:54:11 +02:00
cyclinder
ab47b8b94b fix some lint error 
Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
 2021-10-26 13:56:29 +08:00
Kubernetes Prow Robot
17da6a2345 Merge pull request #105699 from yuzhiquan/remove-format-pods 
Remove format.pods func, instead with klog.Kobjs
 2021-10-25 15:53:30 -07:00
Kubernetes Prow Robot
6166203f45 Merge pull request #105828 from ahg-g/ahg-legacy 
Remove scheduler's legacy policy config
 2021-10-25 09:38:23 -07:00
Hemant Kumar
481068c0d2 rename volume_fsgroup_recursive_apply metric to volume_apply_access_control 2021-10-25 12:27:53 -04:00
Hemant Kumar
f4ddf15c1f Move ConfigurableFSGroupPolicy feature to GA 2021-10-25 12:21:43 -04:00
Abdullah Gharaibeh
faf0ce68a0 Remove scheduler's legacy policy config 2021-10-24 21:58:12 -04:00
Kubernetes Prow Robot
89dd275dde Merge pull request #105584 from goofy-z/fix-extension-point-postfilter-comment 
update extension point PostFilter comment
 2021-10-22 20:00:20 -07:00
Kubernetes Prow Robot
7fbb384e15 Merge pull request #105682 from pohly/generic-ephemeral-volume-raw-block 
storage validation: accept generic ephemeral volumes as volume device
 2021-10-22 18:04:50 -07:00
Kubernetes Prow Robot
cc25656b00 Merge pull request #105030 from liggitt/json-stdlib 
switch from json-iterator to forked stdlib json decoder
 2021-10-21 20:40:37 -07:00
Shivanshu Raj Shrivastava
d3350f45e5 Migrated proxier_health.go , proxier.go to structured logging (#105767) 
* fixed improperly migrated logs

* Update pkg/proxy/winkernel/proxier.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>
 2021-10-21 10:17:48 -07:00
Kubernetes Prow Robot
c767c9d993 Merge pull request #105663 from Jefftree/feature-openapiv3 
Add feature flag for OpenAPI v3
 2021-10-21 10:17:37 -07:00
Shivanshu Raj Shrivastava
86aed49a18 Migrated ipvs/proxier.go(remaining) to structured logging (#105770) 
* fixed improperly migrated logs

* fixed improperly migrated logs

* add
 2021-10-21 08:41:57 -07:00
Eric Ernst
2c0fad1f52 kuberuntime: populate sandbox resources, overhead 
Populate Resources and Overhead fields which, are now part of
LinuxPodSandboxConfig.

Signed-off-by: Eric Ernst <eric_ernst@apple.com>
 2021-10-20 11:30:23 -07:00
Eric Ernst
ddcf815d12 kuberuntime: refactor linux resources for better reuse 
Seperate the CPU/Memory req/limit -> linux resource conversion into its
own function for better reuse.

Elsewhere in kuberuntime pkg, we will want to leverage this
requests/limits to Linux Resource type conversion.

Signed-off-by: Eric Ernst <eric_ernst@apple.com>
 2021-10-20 11:30:23 -07:00
Eric Ernst
ac88cd7691 helpers: refactor and expose function for sum of container req/limits 
Currently we only care about the sum of sandbox resources, which
includes a pod overhead if defined. We have a need for also calculating
*just* the sum of container requests/limits for CPU / Memory, so let's
do a refactor and expose this new helper function.

Signed-off-by: Eric Ernst <eric_ernst@apple.com>
 2021-10-20 11:30:23 -07:00
Eric Ernst
b1361aed93 kuberuntime: augment linux container config unit test 
Signed-off-by: Eric Ernst <eric_ernst@apple.com>
 2021-10-20 11:30:23 -07:00
Eric Ernst
a73502a0be kuberuntime: augment linux container config unit test 
Signed-off-by: Eric Ernst <eric_ernst@apple.com>
 2021-10-20 11:29:22 -07:00
sanposhiho
9dc0489c1a Fix: move parallelize package to non-internal file 2021-10-21 02:39:23 +09:00
Kubernetes Prow Robot
9c97ae286c Merge pull request #105588 from kerthcet/cleanup/remove-servfice-affinity-plugin 
Cleanup/remove service affinity plugin
 2021-10-20 10:24:10 -07:00
Jordan Liggitt
bba877d3a6 Switch from json-iterator to utiljson 2021-10-20 12:49:23 -04:00
Kubernetes Prow Robot
18104ecf1f Merge pull request #105405 from verb/1.23-ec-beta 
Promote EphemeralContainers to beta
 2021-10-20 09:24:10 -07:00
Shivanshu Raj Shrivastava
81636f2158 Fixed improperly migrated logs (#105763) 
* fixed improperly migrated logs

* small fixes

* small fix

* Update pkg/proxy/iptables/proxier.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>

* Update pkg/proxy/healthcheck/service_health.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>

* Update pkg/proxy/iptables/proxier.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>

* Update pkg/proxy/iptables/proxier.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>

* Update pkg/proxy/iptables/proxier.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>

* Update pkg/proxy/iptables/proxier.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>

* Update pkg/proxy/ipvs/proxier.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>

* Update pkg/proxy/ipvs/proxier.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>

* Update pkg/proxy/ipvs/proxier.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>

* Update pkg/proxy/winkernel/proxier.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>

* Update pkg/proxy/winkernel/proxier.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>

* Update pkg/proxy/winkernel/proxier.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>

* Update pkg/proxy/winkernel/proxier.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>

* Update pkg/proxy/winkernel/proxier.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>

* Update pkg/proxy/winkernel/proxier.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>

* Update pkg/proxy/winkernel/proxier.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>

* Update pkg/proxy/winkernel/proxier.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>

* Update pkg/proxy/winkernel/proxier.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>

* Update pkg/proxy/winkernel/proxier.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>

* Update pkg/proxy/winkernel/proxier.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>

* Update pkg/proxy/winkernel/proxier.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>

* refactoring

* refactoring

* refactoring

* reverted some files back to master

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>
 2021-10-20 03:55:58 -07:00
Shivanshu Raj Shrivastava
d3f81a1be6 Migrated server.go, ipvs/proxier.go(partial) to structured logging (#105769) 
* fixed improperly migrated logs

* fixed improperly migrated logs

* fixed improperly migrated logs

* fixed improperly migrated logs

* Update cmd/kube-proxy/app/server.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>

* Update pkg/proxy/ipvs/proxier.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>

* Update pkg/proxy/ipvs/proxier.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>

* Update pkg/proxy/ipvs/proxier.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>

* Update pkg/proxy/ipvs/proxier.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>
 2021-10-20 02:54:11 -07:00
Kubernetes Prow Robot
c6eedc74a7 Merge pull request #105564 from cyclinder/revise_kube_proxy_md 
revise kubeProxy filed as part of the kubeadm configuration
 2021-10-19 22:53:58 -07:00
Kubernetes Prow Robot
dea14dbdcc Merge pull request #105495 from ikeeip/storageobjectinuseprotection_lock_to_default 
Lock StorageObjectInUseProtection feature gate to default
 2021-10-19 21:45:57 -07:00
Lee Verberne
d33bbb8940 Allow volumeDevices in ephemeral containers 2021-10-19 23:04:05 -04:00
Lee Verberne
d874cf8ffd List disallowed ephemeral container fields 
Listing these explicitly makes it easier to determine whether a new
Container field has been evaluated for use with ephemeral containers.
This does not change the behavior of ephemeral containers.
 2021-10-19 23:03:57 -04:00
Lee Verberne
f81c48cd0a Disallow subpath for ephemeral container mounts 2021-10-19 23:01:15 -04:00
Lee Verberne
d1d7882186 Add test for EphemeralContainerCommon struct tags 
The tags for type EphemeralContainerCommon should be kept in sync with
those of type Container.

Co-authored-by: Jordan Liggitt <liggitt@google.com>
 2021-10-19 23:01:07 -04:00
Lee Verberne
26e183b9d9 Clarify EphemeralContainer behavior in docs 
- Apply doc style guide
- Specify behavior when namespace targeting isn't supported by runtime
 2021-10-19 23:00:51 -04:00
Lee Verberne
764859081a Validate ephemeralContainerStatuses during update 2021-10-19 23:00:51 -04:00
cyclinder
dd2d2ea7a7 revise kubeProxy filed as part of the kubeadm configuration 
Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
 2021-10-20 10:32:29 +08:00
Aldo Culquicondor
60fc90967b Count ready pods in job controller 
When the feature gate JobReadyPods is enabled.

Change-Id: I86f93914568de6a7029f9ae92ee7b749686fbf97
 2021-10-19 15:18:37 -04:00
Aldo Culquicondor
1bff5eb44d Add ready field to Job status 
to keep a count of the pods that have the ready condition.

Also:
- Add feature gate JobReadyPods.
- Add Ready to describe.

Change-Id: Ib934730a430a8e2a2f485671e345fe2330006939
 2021-10-19 15:18:34 -04:00
Kubernetes Prow Robot
c733594040 Merge pull request #105687 from alculquicondor/job-tracking 
Graduate JobTrackingWithFinalizers to beta
 2021-10-19 11:40:37 -07:00
Kubernetes Prow Robot
b2c4269992 Merge pull request #105631 from klueska/upstream-distribute-cpus-across-numa 
Add CPUManager policy option to distribute CPUs across NUMA nodes instead of packing them
 2021-10-19 11:40:24 -07:00
Kubernetes Prow Robot
2dbdd9461d Merge pull request #105748 from marosset/host-process-emphemeral-contianer-validation 
Adding unit test coverage for API validation for ephemeral containers in hostprocess pods on Windows
 2021-10-19 08:11:04 -07:00
Lee Verberne
6f4b8da9a3 Promote EphemeralContainers feature to beta 2021-10-19 08:47:57 -04:00
Lee Verberne
83a4ec90ae Always set feature gates for ContainerVisitor test 
This fixes a bug where the test was dependent on the current set of
feature gates. Since AllFeatureEnabledContainers() depends on the
feature gates it must be evaluated after the test case is initialized.
 2021-10-19 08:47:57 -04:00
Patrick Ohly
a40d2eb18c storage validation: accept generic ephemeral volumes as volume device 
Raw block devices are possible with generic ephemeral volumes, so rejecting a
pod with that combination is wrong.
 2021-10-19 13:30:32 +02:00
Gunju Kim
3bce245279 Ensure there is one running static pod with the same full name 2021-10-19 16:30:18 +09:00
Kubernetes Prow Robot
1af8a8c026 Merge pull request #105465 from marosset/remove-host-process-contianer-kubelet-annotations 
Stop passing WindowsHostProcessContainer annotations for CRI calls in kubelet
 2021-10-18 15:50:02 -07:00
Kubernetes Prow Robot
e595d79dfc Merge pull request #104574 from 249043822/br-repeat-package 
fix duplicate package import in pod_worker
 2021-10-18 15:49:46 -07:00
Mark Rossetti
3ddff55fe6 Adding unit test coverage for API validation for emphermal contaienrs in hostprocess pods on Windows 
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
 2021-10-18 15:46:27 -07:00
Kubernetes Prow Robot
5889fb4fbc Merge pull request #105652 from wzshiming/feat/structure-shutdown-config 
Refactor to use structure to pass parameters for GracefulNodeShutdown
 2021-10-18 14:45:20 -07:00
Kevin Klues
86f9c266bc Add optimizations to reduce iterations in distributed NUMA algorithm 
Signed-off-by: Kevin Klues <kklues@nvidia.com>
 2021-10-18 08:53:25 +00:00
Kevin Klues
70e0f47191 Support full-pcpus-only with the new NUMA distribution policy option 
Signed-off-by: Kevin Klues <kklues@nvidia.com>
 2021-10-16 19:31:02 +00:00
Kevin Klues
d54445a84d Generalize the NUMA distribution algorithm to take cpuGroupSize 
This parameter ensures that CPUs are always allocated in groups of size
'cpuGroupSize'. This is important, for example, to ensure that all CPUs (i.e.
hyperthreads) from the same core are handed out together.

Signed-off-by: Kevin Klues <kklues@nvidia.com>
 2021-10-16 19:31:02 +00:00