github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
90,326 Commits 1 Branch 31 Tags 1,019 MiB
59a28111be
Commit Graph

4884 Commits

Author SHA1 Message Date
Jan Safranek
2c1b743766 Promote block volume features to GA 2020-02-28 20:48:38 +01:00
Patrick Ohly
6329b17d2f volume scheduler: introduce special string type 
This makes it possible to search for the special strings more easily
(https://github.com/kubernetes/kubernetes/pull/88230#discussion_r382367043).
 2020-02-28 10:09:19 +01:00
Patrick Ohly
6eb0b034ac volume scheduler: move reason strings into volume code 
The scheduler doesn't really need to know in detail which reasons
rendered a node unusable for a node. All it needs from the volume
binder is a list of reasons that it then can present to the user.

This seems a bit cleaner. But the main reason for the change is that
it simplifies the checking of CSI inline volumes and perhaps later
capacity checking. Both will lead to new failure reasons, which then
can be added without changing the interface.
 2020-02-28 10:09:18 +01:00
James Munnelly
d5dae04898 certificates: update controllers to understand signerName field 
Signed-off-by: James Munnelly <james.munnelly@jetstack.io>
 2020-02-27 15:54:31 +00:00
James Munnelly
a983356caa Add signerName field to CSR resource spec 
Signed-off-by: James Munnelly <james.munnelly@jetstack.io>
 2020-02-27 10:17:55 +00:00
Kubernetes Prow Robot
f3d38fcd4f
Merge pull request #88516 from boddumanohar/issues/87447 
Use servicePatch methods from cloud-provider repo in service-controller
 2020-02-26 19:39:44 -08:00
Kubernetes Prow Robot
55f2d91c8c
Merge pull request #88447 from taesunny/pkg/controller 
Fix pkg/controller typos in some error messages, comments etc
 2020-02-26 19:39:19 -08:00
Kubernetes Prow Robot
a726c9c9cb
Merge pull request #88435 from andrewsykim/ccm-clean-up 
move well known cloud provider taints to k8s.io/cloud-provider/api
 2020-02-26 13:33:41 -08:00
Kubernetes Prow Robot
d98975217a
Merge pull request #88525 from mborsz/bench3 
Reorder conditions in FindMatchingVolume to avoid calling volumeutil.CheckNodeAffinity in trivial cases
 2020-02-26 09:46:40 -08:00
taesun_lee
79680b5d9b Fix pkg/controller typos in some error messages, comments etc 
- applied review results by LuisSanchez
- Co-Authored-By: Luis Sanchez <sanchezl@redhat.com>

genernal -> general
iniital -> initial
initalObjects -> initialObjects
intentionaly -> intentionally
inforer -> informer
anotother -> another
triger -> trigger
mutli -> multi
Verifyies -> Verifies
valume -> volume
unexpect -> unexpected
unfulfiled -> unfulfilled
implenets -> implements
assignement -> assignment
expectataions -> expectations
nexpected -> unexpected
boundSatsified -> boundSatisfied
externel -> external
calcuates -> calculates
workes -> workers
unitialized -> uninitialized
afater -> after
Espected -> Expected
nodeMontiorGracePeriod -> NodeMonitorGracePeriod
estimateGrracefulTermination -> estimateGracefulTermination
secondrary -> secondary
ShouldRunDaemonPodOnUnscheduableNode -> ShouldRunDaemonPodOnUnschedulableNode
rrror -> error
expectatitons -> expectations
foud -> found
epackage -> package
succesfulJobs -> successfulJobs
namesapce -> namespace
ConfigMapResynce -> ConfigMapResync
 2020-02-27 00:15:33 +09:00
Maciej Borsz
7d59ea8394 Reorder conditions in FindMatchingVolume to avoid checking NodeAffinity 
in trivial cases.
 2020-02-26 09:20:38 +01:00
Rob Scott
6a33727632
Adding AppProtocol to Service and Endpoints Ports 2020-02-25 17:42:34 -08:00
Manohar Reddy
7b2a0a4260 update bazel 2020-02-26 06:14:19 +05:30
Manohar Reddy
08473a4949 remote patch.go and patch_test.go files 2020-02-25 20:13:43 +05:30
Manohar Reddy
1c0a78a4fd Use servicePatch methods from cloud-provider repo in service-controller 2020-02-25 16:28:37 +05:30
andrewsykim
8c633356df move well known cloud provider taints to k8s.io/cloud-provider/api 
Signed-off-by: andrewsykim <kim.andrewsy@gmail.com>
 2020-02-23 19:54:59 -05:00
Andrew Sy Kim
8b490dea3a service controller: add OnAdd and OnDelete node event handlers 
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
 2020-02-20 12:56:47 -05:00
s-ito-ts
e6b9a7a309 Fix golint errors in pkg/controller/garbagecollector 2020-02-20 04:46:02 +00:00
Kubernetes Prow Robot
da9f47eadf
Merge pull request #88146 from gnufied/avoid-multiple-pv-delete 
Prevent deletion of PVs that are already deleted
 2020-02-19 12:40:48 -08:00
Kubernetes Prow Robot
3a24c32345
Merge pull request #87980 from tnqn/endpointslicetracker 
EndpointSliceTracker should track updated resource version
 2020-02-18 19:10:25 -08:00
Hemant Kumar
d9f7a1f311 Don't call delete for already deleted volumes 2020-02-18 15:59:47 -05:00
Nan Yu
89bb7d8454 Honor the RevisionHistoryLimit in StatefulSetSpec 
The StatefulSet controller cleans up ControllerRevisions at the end of
the reconcile loop. If something goes wrong during reconcile, it bails
out without actually performing this step. This commit moves the cleanup
to a deferred function call to guarantee it will be executed.

Fixes issue: https://github.com/kubernetes/kubernetes/issues/85690
 2020-02-18 10:42:38 -08:00
Kubernetes Prow Robot
1a0f923a65
Merge pull request #87712 from alena1108/jan30kubelet 
Ineffassign fixes for pkg/controller and kubelet
 2020-02-14 14:29:27 -08:00
Kubernetes Prow Robot
7fe64ccb82
Merge pull request #84984 from cofyc/fix84942 
apps/StatefulSets: Garbage collector should be able to orphan ControllerRevisions too
 2020-02-14 01:06:18 -08:00
David Zhu
81668cb887 Change migrated-to annoation key to follow best practices by removing beta and using 'pv' prefix 2020-02-12 10:33:08 -08:00
Quan Tian
c2d3e54551 EndpointSliceTracker should track updated resource version 
During EndpointSlice reconcilation, EndpointSliceTracker is supposed to
track expected EndpointSlice resource versions so that external changes
to them can be detected. But it actually tracked the stale resource
version and resulted in every Service was handled twice as it always
received an EndpointSlice update with a different resource version but
was actually created/updated by itself during the first processing.
 2020-02-10 21:47:07 +08:00
Yecheng Fu
bb2b50f3db Garbage collector should orphan ControllerRevisions too 
Signed-off-by: Yecheng Fu <fuyecheng@pingcap.com>
 2020-02-10 20:58:28 +08:00
Mike Danese
bfc75d9a5c manual fixes 2020-02-08 12:32:33 -05:00
Mike Danese
25651408ae generated: run refactor 2020-02-08 12:30:21 -05:00
Mike Danese
2637772298 some manual fixes 2020-02-07 18:17:40 -08:00
Mike Danese
3aa59f7f30 generated: run refactor 2020-02-07 18:16:47 -08:00
Kubernetes Prow Robot
8215619ba4
Merge pull request #87642 from pohly/volume-binder-testing 
volume binder testing
 2020-02-07 05:56:39 -08:00
Alexander Zimmermann
e0b1e9206d
Clarified comments 2020-02-07 09:09:49 +01:00
Kubernetes Prow Robot
9c1e124b15
Merge pull request #87823 from tallclair/test-tokens 
Ensure testing credentials are labeled as such
 2020-02-06 17:47:29 -08:00
Kubernetes Prow Robot
04e28b3674
Merge pull request #87098 from davidz627/feature/migratedRollback 
Add annotation updating for migration for PVs and PVCs
 2020-02-06 17:45:32 -08:00
Alexander Zimmermann
a1c837022c
Fixed Golint errors in pkg/controller/podautoscaler 2020-02-06 17:16:38 +01:00
Tim Allclair
9d3670f358 Ensure testing credentials are labeled as such 2020-02-04 10:36:05 -08:00
Kubernetes Prow Robot
fa4bc10ef1
Merge pull request #86793 from prameshj/gce-finalizer 
Attach a new finalizer in GCE ILB creation.
 2020-01-30 21:20:32 -08:00
Alena Prokharchyk
6c3093f970 Ineffassign fixes for pkg/controller and kubelet 2020-01-30 14:35:10 -08:00
Kubernetes Prow Robot
7164152844
Merge pull request #87664 from liggitt/revert-parallel-volume 
Revert "Merge pull request #87258 from verult/slow-rxm-attach"
 2020-01-29 22:12:01 -08:00
Jordan Liggitt
cd1059e3c4 Revert "Merge pull request #87258 from verult/slow-rxm-attach" 
This reverts commit 15c3f1b119, reversing
changes made to 52d7614a8c.
 2020-01-29 14:58:32 -05:00
Mike Danese
968adfa993 cleanup req.Context() and ResponseWrapper 2020-01-29 08:50:45 -08:00
Mike Danese
d55d6175f8 refactor 2020-01-29 08:50:45 -08:00
Patrick Ohly
a3c434510d volume binder: enable klog flags in test 
When debugging the test runs it is useful to increase the log level:

go test -v ./pkg/controller/volume/scheduling -args -v 5
 2020-01-29 10:37:39 +01:00
Patrick Ohly
5c8929d95e volume binder: convert to sub-tests 
Using t.Run() has some advantages:
- individual sub-tests can be selected with -run
- test failures are automatically associated with
  the scenario, therefore the test name no longer
  needs to be passed around

A "run" function is used primarily to avoid large indention changes,
but also because this can be used to extend the test with additional
parameters later on.
 2020-01-29 10:37:27 +01:00
Kubernetes Prow Robot
f5a008746a
Merge pull request #83526 from eloyekunle/feat/gengo-reverse-import 
import-boss reverse import
 2020-01-28 18:50:13 -08:00
Pavithra Ramesh
1de2327afc Attach a new finalizer in GCE ILB creation. 
Add logic in service_controller to skip create/update
if finalizer from a different controller is found.

The newly added finalizer will be checked by other controllers
implementing ILB services to determine if a given service is
already being managed by service_controller.

Moved finalizer check into cloudprovider code.

added unit test to verify new finalizer.

Modified existing unit test to create a fake service so that
attach/remove finalizer step can be tested.
 2020-01-28 15:02:19 -08:00
Oleg Atamanenko
427f0f9463 Add apiVersion to involvedObject 2020-01-28 09:24:08 -08:00
Elijah Oyekunle
07e3cca6d0 update existing import-restrictions files 2020-01-28 10:51:45 +01:00
David Zhu
b7817a2981 Add annotation annealing for migration for PVs and PVCs during syncVolume and syncClaim. This allows external-provisioners to pick up and delete volumes when they have been rolled up from previous kubernetes versions. 2020-01-27 16:14:53 -08:00
Cheng Xing
c6a03fa5be Parallelize attach operations across different nodes for volumes that allow multi-attach 2020-01-27 15:02:25 -08:00
Kubernetes Prow Robot
dc090f80d1
Merge pull request #87406 from haosdent/remove-algo 
Remove `scheduler/algorithm/priorities` in import-restrictions
 2020-01-23 11:34:24 -08:00
Kubernetes Prow Robot
c5d981583a
Merge pull request #87308 from KobayashiD27/fix-staticcheck 
Fix staticcheck in pkg/controller/podgc
 2020-01-23 11:34:11 -08:00
David Eads
5c2d2c5ef1 rename dynamic cert loading to be more accurate 2020-01-22 15:00:46 -05:00
David Eads
6ccfc3aecf add dynamic reloading for CSR signing controllers 2020-01-22 15:00:46 -05:00
Kubernetes Prow Robot
e4926e2d70
Merge pull request #85421 from terrytangyuan/patch-1 
Fix grammar: have -> has
 2020-01-22 08:40:58 -08:00
Haosdent Huang
b09e35257a Remove scheduler/algorithm/priorities in import-restrictions 2020-01-22 11:54:28 +08:00
yiyang5055
53aff819e0 fix static check failure in pkg/controller/disruption and pkg/controller/namespace/deletion 2020-01-20 09:10:46 +00:00
Sakura
203c7b4731
fix staticcheck errors in pkg/controller/daemon. 
Signed-off-by: Sakura <longfei.shang@daocloud.io>
 2020-01-19 21:09:05 +08:00
Kubernetes Prow Robot
073da1588a
Merge pull request #86801 from likakuli/fix_syncsts_orphanrevision 
fix a bug that orphan revision cannot be adopted and statefulset cannot be synced
 2020-01-19 00:07:35 -08:00
Kobayashi Daisuke
ed1381e35f Fix staticcheck in pkg/controller/podgc 2020-01-17 15:42:38 +09:00
Paul Morie
afaea605f4 Remove Brad Childs from OWNERS files 2020-01-16 15:21:34 -05:00
Jordan Liggitt
054e3846fc Use v1 subjectaccessreview API in controller-manager CSR approver 2020-01-13 15:55:52 -05:00
Kubernetes Prow Robot
ace98e1382
Merge pull request #84433 from yamt/comment-typo 
Fix a comment typo in legacyNodeRoleBehaviorFeature
 2020-01-10 17:17:38 -08:00
Kubernetes Prow Robot
240782c7f7
Merge pull request #87043 from zjs/topic/propagate-providerid-errors 
Ensure a provider ID is set on a node if expected
 2020-01-10 14:33:50 -08:00
Zach Shepherd
2b554079af
Ensure a provider ID is set on a node if expected 
A transient issue might occur that causes an error to be returned by
InstanceID(). When this is ignored, the external cloud provider taint
will be removed and neither AddCloudNode() nor UpdateCloudNode() will
try to set a provider ID in the future.

By returning the error we can ensure that the external cloud provider
taint is not removed prematurely, allowing the operation to be retried
(until the provider ID can be set).

Preserve support for external cloud providers that do not use IDs by
continuing if a NotImplemented error is returned, making a distinction
between lack of support for provider IDs and an actual error.

Introduce pair of unit tests that show a provider ID will eventually
be set if an error is returned, unless that error is a NotImplemented,
in which case the external cloud provider taint will be removed.
 2020-01-10 11:00:54 -08:00
Kubernetes Prow Robot
3ccdad175a
Merge pull request #86210 from draveness/feature/remove-ga-flags 
feat: remove several feature gates in 1.18
 2020-01-09 13:28:50 -08:00
Kubernetes Prow Robot
1e0bfae887
Merge pull request #86871 from gosoon/master 
fix log message error in nodelifecycle
 2020-01-08 02:58:33 -08:00
likakuli
10864d3366 fix a bug that orphan revision cannot be adopted and sts cannot be synced 2020-01-08 17:56:41 +08:00
Kubernetes Prow Robot
f3df7a2fdb
Merge pull request #86727 from mattjmcnaughton/mattjmcnaughton/remove-recorder-PastEventf 
Remove `recorder.PastEventf` method
 2020-01-07 04:38:49 -08:00
tianfeiyu
fddf50cf88
fix log message error in nodelifecycle 2020-01-06 21:02:08 +08:00
Abdullah Gharaibeh
041e5b5560 addressed comments 2020-01-04 01:14:24 -05:00
Abdullah Gharaibeh
7d604c318c Break DS controller on scheduler predicates and predicate errors 2020-01-03 13:05:07 -05:00
mattjmcnaughton
92940fa80d
Remove recorder.PastEventf method 
The `recorder.PastEventf` method wasn't actually working as advertised.
It was supposed to accept a timestamp, which would be used when
generating the event. However, as the
[source code](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/tools/record/event.go#L316)
shows, this `timestamp` was never actually used.

In other words, `PastEventf` is identical to `Eventf`.

We have two options: one would be to fix `PastEventf` so that it works
as advertised. The other would be to delete `PastEventf` and only
support `Eventf`.

Ultimately, I could only find one use of `PastEventf` in the code base,
so I propose we just delete `PastEventf` and convert all uses to
`Eventf`.
 2019-12-30 12:00:23 -05:00
Kubernetes Prow Robot
d4ba10ec80
Merge pull request #85703 from robscott/endpointslice-controller-race-fix 
Fixing Potential Race Condition in EndpointSlice Controller.
 2019-12-26 17:59:52 -08:00
Rob Scott
c75787bb77
Fixing Potential Race Condition in EndpointSlice Controller. 
This adds a new EndpointSlice tracker to keep track of the expected resource versions of EndpointSlices associated with each Service managed by the EndpointSlice controller. This should prevent a potential race where a syncService call could happen with an incomplete view of EndpointSlices if additions or deletions hadn't fully propagated to the cache yet. Additionally, this ensures that external changes to EndpointSlices will be handled by the EndpointSlice controller.
 2019-12-26 12:15:38 -08:00
danielqsj
5bc0e26c19 unify alias of api errors under pkg and staging 2019-12-26 16:42:28 +08:00
Alvaro Aleman
18fa7bdb6e Cloud node controller: Only call once into cloud provider 2019-12-17 20:03:27 +01:00
Kubernetes Prow Robot
42fe74cd2c
Merge pull request #86142 from raz-bn/add-complete-event 
Adding new job completed event
 2019-12-16 23:43:58 -08:00
raz-bn
0224c48120 Job completed event added 2019-12-16 21:41:15 +00:00
Kubernetes Prow Robot
69410eca4b
Merge pull request #86256 from liggitt/testapi 
Remove use of testapi package
 2019-12-13 12:55:50 -08:00
Jordan Liggitt
5d5b444c4d Remove use of testapi codecs, selflink, resourcepath functions 2019-12-13 11:56:29 -05:00
Kubernetes Prow Robot
f67d3b1a7d
Merge pull request #86229 from ahg-g/ahg-ds 
Remove daemonset controller's dependency on scheduler metadata
 2019-12-13 00:26:54 -08:00
Kubernetes Prow Robot
ae717afc0d
Merge pull request #86140 from yutedz/rs-rm-timeout 
Do not swallow timeout in manageReplicas
 2019-12-12 18:33:07 -08:00
Abdullah Gharaibeh
288609ecf5 remove ds dependeny on scheduler metadata 2019-12-12 19:04:36 -05:00
Ted Yu
9cff345770 Do not swallow timeout in manageReplicas 2019-12-12 11:27:36 -08:00
draveness
dcea6ff065 fix: remove TaintNodesByCondition feature gate in daemon controller 2019-12-12 18:17:14 +08:00
Kubernetes Prow Robot
928817a26a
Merge pull request #74525 from gliush/configurable-hpa-limits 
Configurable HorizontalPodAutoscaler
 2019-12-11 03:18:05 -08:00
Arjun Naik
8ab226263a Adds tests 
Signed-off-by: Arjun Naik <arjun@arjunnaik.in>
 2019-12-10 18:09:20 +01:00
Ivan Glushkov
27ffe439b6
Adds the algorithm implementation for the Configurable HPA 2019-12-10 20:37:33 +04:00
Kubernetes Prow Robot
fcc35b0468
Merge pull request #85899 from gongguan/slim_down_lister 
slim down some lister expansions
 2019-12-09 07:20:17 -08:00
louisgong
7f5076d8ee slim down some lister expansions 2019-12-07 08:27:06 +08:00
Nan Yu
1fb0dd4ec5 Rename PodDisruptionsAllowed to DisruptionsAllowed in type PodDisruptionBudgetStatus 2019-12-03 14:26:35 -08:00
Kubernetes Prow Robot
41757d673e
Merge pull request #85521 from gaorong/check-return-value 
check service status value returned by EnsureLoadBalancer
 2019-11-25 22:51:10 -08:00
Rob Scott
4229b99203
Deep copying EndpointSlices in reconciler before modifying them. 2019-11-23 20:57:50 -08:00
Rong Gao
99603e105a check service status value returned by EnsureLoadBalancer 
when service status returned by EnsureLoadBalancer is nil, return the
function directly to avoid NPE
 2019-11-22 09:19:06 +08:00
Benjamin Elder
cf510ac285 fix multiple node cidr masks in providerless build 2019-11-19 09:47:45 -08:00
Yuan Tang
dd308ca576
Fix grammar: have -> has 2019-11-18 11:17:58 -05:00
Kubernetes Prow Robot
c3f8d700ac
Merge pull request #85367 from aramase/node-cidr-followup 
[kube controller manager] add comments for compatibility
 2019-11-15 19:09:54 -08:00
Kubernetes Prow Robot
9c26a752a9
Merge pull request #85231 from davidz627/flags 
Flip CSIMigration and CSIMigrationGCE to Beta
 2019-11-15 17:57:41 -08:00