github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
90,326 Commits 1 Branch 31 Tags 1,019 MiB
59a28111be
Commit Graph

38704 Commits

Author SHA1 Message Date
Oleg Chunikhin
b651178849 fix incorrect configuration of kubepods.slice unit by kubelet (issue #88197) 2020-02-17 13:22:45 -05:00
Kubernetes Prow Robot
ea5cef1c65
Merge pull request #87870 from tedyu/restore-proxier-updater 
Use ProxierHealthUpdater directly to avoid panic
 2020-02-17 10:13:29 -08:00
Maciej Szulik
e77df88200
Present more concrete information about pod readiness 2020-02-17 17:10:23 +01:00
Jan Safranek
073d0b2340 Add getPublishDir and getVolumePluginDir 
So we don't need to compute these backwards from getPublishPath and
getVolumeDevicePluginDir.
 2020-02-17 10:51:39 +01:00
Kubernetes Prow Robot
48def7e7c3
Merge pull request #88105 from Huang-Wei/pts-e2e 
Graduate PodTopologySpread to Beta
 2020-02-16 18:59:28 -08:00
gkarthiks
8853a985fd fix: golint failures 
Signed-off-by: gkarthiks <github.gkarthiks@gmail.com>
 2020-02-16 15:09:45 -08:00
Kubernetes Prow Robot
8b2f08f39d
Merge pull request #88201 from andyzhangx/update-max-disk-count 
fix: update azure disk max count
 2020-02-16 01:47:28 -08:00
andyzhangx
6a773fb9c2 fix: update max azure disk max count 2020-02-16 02:46:27 +00:00
Kubernetes Prow Robot
3b22fcc7bd
Merge pull request #88189 from skilxn-go/RemovePreScoreNodeListArguments 
[Scheduler Framework]Remove `FilteredNodesStatuses` argument from `PreScore`'s interface
 2020-02-15 13:29:28 -08:00
Kubernetes Prow Robot
1c60045db0
Merge pull request #88173 from BenTheElder/gives-a-whole-new-pause 
upgrade pause everywhere
 2020-02-15 02:11:27 -08:00
Kubernetes Prow Robot
2e0cf7e4b6
Merge pull request #86557 from soltysh/fix_events 
If lastTimestamp is not set use firstTimestamp when printing event
 2020-02-14 23:09:28 -08:00
Kubernetes Prow Robot
3e3a3599ca
Merge pull request #87711 from alena1108/jan30volume 
Ineffassign fixes for pkg/volume
 2020-02-14 21:53:28 -08:00
skilxn-go
8fd0d8028f Remove FilteredNodesStatuses argument from PreScore interface 2020-02-15 13:53:04 +08:00
Julian V. Modesto
d97169f59a Clean up --dry-run values. 
- Clean up --dry-run values in tests, docs, and scripts
- Fix --dry-run for auth reconcile and add a test
 2020-02-15 00:43:30 -05:00
Kubernetes Prow Robot
954d8b13ca
Merge pull request #88171 from MikeSpreitzer/version-field-managers 
Version the API Priority and Fairness FieldManager values
 2020-02-14 18:57:28 -08:00
Wei Huang
c93dffdfc4
E2E tests for PodTopologySpread 2020-02-14 16:48:35 -08:00
Kubernetes Prow Robot
1a0f923a65
Merge pull request #87712 from alena1108/jan30kubelet 
Ineffassign fixes for pkg/controller and kubelet
 2020-02-14 14:29:27 -08:00
Kubernetes Prow Robot
bde718d100
Merge pull request #87948 from notpad/feature/pod_backoff 
Remove PodBackoffMap
 2020-02-14 13:11:28 -08:00
James DeFelice
0e178f9341 rename to sharedLimitWriter 2020-02-14 13:48:41 -06:00
Benjamin Elder
1631825e44 bump pause to 3.2 in kubelet 2020-02-14 11:40:15 -08:00
Mike Spreitzer
b142868eaf Version the API Priority and Fairness FieldManager values 2020-02-14 13:50:11 -05:00
andyzhangx
6068ce96b1 fix: get azure disk lun timeout issue 2020-02-14 12:51:42 +00:00
Kubernetes Prow Robot
7fe64ccb82
Merge pull request #84984 from cofyc/fix84942 
apps/StatefulSets: Garbage collector should be able to orphan ControllerRevisions too
 2020-02-14 01:06:18 -08:00
Kubernetes Prow Robot
ad68c4a8b5
Merge pull request #87699 from michaelbeaumont/fix_66766 
kube-proxy: Only open ipv4 sockets for ipv4 clusters
 2020-02-13 23:54:18 -08:00
Kubernetes Prow Robot
48434c3677
Merge pull request #87117 from aojea/proxyv6LB 
kube-proxy crash when load balancers use a different IP family
 2020-02-13 22:44:17 -08:00
Kubernetes Prow Robot
3273cd99b1
Merge pull request #88138 from thockin/sig-net-driver-approvers 
Create an OWNERS alias for net-driver-approvers
 2020-02-13 21:10:40 -08:00
Kubernetes Prow Robot
498b58eff1
Merge pull request #86982 from gnufied/add-pvc-mount-failure-events 
Add events to PV when mount fails on filesystem mismatch
 2020-02-13 21:10:17 -08:00
Julian V. Modesto
932500c015 Remove deprecated rolling-update command 2020-02-13 23:52:53 -05:00
Kubernetes Prow Robot
77e8c75f32
Merge pull request #87754 from MikeSpreitzer/apf-filter5 
Add twice refactored filter and config consumer for API Priority and Fairness
 2020-02-13 16:54:46 -08:00
notpad
a4e4a99435 Remove PodBackoffMap 2020-02-14 08:31:07 +08:00
Tim Hockin
fc5b08569f Create an OWNERS alias for net-driver-approvers 2020-02-13 14:43:45 -08:00
James DeFelice
a4230055f3 address review feedback 2020-02-13 11:44:11 -06:00
Hemant Kumar
c058073046 Add a event to PV when mount fails because of fs mismatch 
Filesystem mismatch is a special event. This could indicate
either user has asked for incorrect filesystem or there is a error
from which mount operation can not recover on retry.

Co-Authored-By: Jordan Liggitt <jordan@liggitt.net>
 2020-02-13 12:29:42 -05:00
Aldo Culquicondor
99bda6fac0 Remove HardPodAffinityWeight from v1alpha2 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
 2020-02-13 11:59:56 -05:00
Aldo Culquicondor
666bc6aeb4 Scheduler: Exclude plugin config for empty policy arguments 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
 2020-02-13 11:11:47 -05:00
Jan Safranek
0bd2e629c7 Fix unit tests 2020-02-13 12:20:03 +01:00
Jan Safranek
e2d8e575f0 Add CSI block volume directory cleanup 
CSI volume plugin creates number of files/directories when processing block
volumes. These files must be cleaned when the plugin is done with the
volume, i.e. at the end on TearDownDevice().
 2020-02-13 12:19:31 +01:00
Kubernetes Prow Robot
8ca96f3e07
Merge pull request #80724 from cceckman/provider-info-e2e 
Provide OIDC discovery for service account token issuer
 2020-02-13 01:38:35 -08:00
Maciej Borsz
c78c0e949d Remove unnecessary calls to GCE API after PD is created. 2020-02-13 09:57:25 +01:00
Kubernetes Prow Robot
177506d87c
Merge pull request #87945 from andyzhangx/azure-writeaccelerator 
add azure disk WriteAccelerator support
 2020-02-12 21:37:24 -08:00
Kubernetes Prow Robot
f0c14f291f
Merge pull request #87751 from skilxn-go/Rename 
[Scheduler Framework] Rename `PostFilter` plugin to `PreScore`
 2020-02-12 21:37:12 -08:00
Kubernetes Prow Robot
bd1042080f
Merge pull request #81678 from verb/debug-list 
Add ephemeral containers to streamLocation name suggestions
 2020-02-12 21:36:35 -08:00
Kubernetes Prow Robot
e92ecdd7ee
Merge pull request #88032 from davidz627/master 
Change migrated-to annoation key to follow best practices by removing beta
 2020-02-12 17:54:48 -08:00
Kubernetes Prow Robot
b9c57a1aa2
Merge pull request #87353 from aojea/kproxy_dual 
kube-proxy: validate dual-stack cidrs
 2020-02-12 17:54:35 -08:00
Kubernetes Prow Robot
f7eafa1a83
Merge pull request #86896 from yutedz/copy-into-err 
Return the error from copyInto
 2020-02-12 13:54:51 -08:00
David Zhu
81668cb887 Change migrated-to annoation key to follow best practices by removing beta and using 'pv' prefix 2020-02-12 10:33:08 -08:00
skilxn-go
f5b7e3cca3 Rename PostFilter plugin to PreScore 2020-02-12 23:25:08 +08:00
Lee Verberne
cc32702e8f Add ephemeral containers to streamLocation name suggestions 
This combines container names into a single list because separating them
into a long, variable length string isn't particularly useful in the
context of an streaming error message.
 2020-02-12 14:49:42 +01:00
Kubernetes Prow Robot
ed0d6ee3ce
Merge pull request #85617 from andrewsykim/optimize-external-ips 
proxier: only get local addresses once per sync loop
 2020-02-12 02:22:51 -08:00
Kubernetes Prow Robot
c4df69d241
Merge pull request #88024 from notpad/weight 
Add RegisterPluginAsExtensionsWithWeight
 2020-02-11 23:16:20 -08:00
Kubernetes Prow Robot
92be16ce82
Merge pull request #88014 from andyzhangx/azure-csi-migration 
fix: add azure disk migration support on CSINode
 2020-02-11 23:16:09 -08:00
Kubernetes Prow Robot
17a6248f76
Merge pull request #87939 from shaloulcy/pod_storage_indexer 
add indexer for pod storage
 2020-02-11 23:15:22 -08:00
Kubernetes Prow Robot
fd0b34d69d
Merge pull request #87911 from tedyu/rm-exp-backoff 
Remove the exponential backoff in NodeGetInfo
 2020-02-11 23:15:10 -08:00
Kubernetes Prow Robot
52fb02fdbe
Merge pull request #87718 from wojtek-t/kubelet_not_watching_immutable_secret_configmaps 
WatchBasedManager stops  watching immutable objects
 2020-02-11 23:14:33 -08:00
Charles Eckman
5a176ac772 Provide OIDC discovery endpoints 
- Add handlers for service account issuer metadata.
- Add option to manually override JWKS URI.
- Add unit and integration tests.
- Add a separate ServiceAccountIssuerDiscovery feature gate.

Additional notes:
- If not explicitly overridden, the JWKS URI will be based on
  the API server's external address and port.

- The metadata server is configured with the validating key set rather
than the signing key set. This allows for key rotation because tokens
can still be validated by the keys exposed in the JWKs URL, even if the
signing key has been rotated (note this may still be a short window if
tokens have short lifetimes).

- The trust model of OIDC discovery requires that the relying party
fetch the issuer metadata via HTTPS; the trust of the issuer metadata
comes from the server presenting a TLS certificate with a trust chain
back to the from the relying party's root(s) of trust. For tests, we use
a local issuer (https://kubernetes.default.svc) for the certificate
so that workloads within the cluster can authenticate it when fetching
OIDC metadata. An API server cannot validly claim https://kubernetes.io,
but within the cluster, it is the authority for kubernetes.default.svc,
according to the in-cluster config.

Co-authored-by: Michael Taufen <mtaufen@google.com>
 2020-02-11 16:23:31 -08:00
Andrew Sy Kim
1653476e3f proxier: use IPSet from k8s.io/utils/net to store local addresses 
This allows the proxier to cache local addresses instead of fetching all
local addresses every time in IsLocalIP.

Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
 2020-02-11 16:44:34 -05:00
Andrew Sy Kim
77feb1126e userspace proxy: get local addresses only once per sync loop 
This avoids fetching all local network interfaces everytime we sync an
external IP. For clusters with many external IPs this gets really
expensive. This change caches all local addresses once per sync.

Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
 2020-02-11 16:35:49 -05:00
Andrew Sy Kim
126bf5a231 ipvs proxier: use util proxy methods for getting local addresses 
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
 2020-02-11 16:35:49 -05:00
Andrew Sy Kim
313c3b81e3 iptables proxier: get local addresses only once per sync loop 
This avoids fetching all local network interfaces everytime we sync an
external IP. For clusters with many external IPs this gets really
expensive. This change caches all local addresses once per sync.

Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
 2020-02-11 16:35:49 -05:00
notpad
89066cceb9 Add RegisterPluginAsExtensionsWithWeight 2020-02-11 23:11:53 +08:00
Kubernetes Prow Robot
574acbe310
Merge pull request #87847 from notpad/feature/slow_path 
Cleanup "slow-path" logic in scheduler Filters
 2020-02-11 06:46:04 -08:00
andyzhangx
9cb7f54c0b fix: add azure disk migration support for CSINode 2020-02-11 11:39:55 +00:00
Antonio Ojea
11263bb57f
kube-proxy filter Load Balancer Status ingress 
kube-proxy, if is configured with an IP family, filters out the
incorrect IP version of the services.

This commit fix a bug caused by not filtering out the IPs in the
LoadBalancer Status Ingress field.
 2020-02-11 10:25:59 +01:00
notpad
fb895056c6 Add test 2020-02-11 16:51:21 +08:00
Mike Spreitzer
73614ddd4e Added API Priority and Fairness filter and config consumer 2020-02-10 22:54:40 -05:00
shaloulcy
fe312ed74a add index for pod cacher 
Signed-off-by: shaloulcy <lcy041536@gmail.com>
 2020-02-11 09:25:27 +08:00
Ted Yu
7a0690cd59 Use ProxierHealthUpdater directly to avoid panic 2020-02-10 09:41:09 -08:00
Kubernetes Prow Robot
db9123e50e
Merge pull request #87936 from Huang-Wei/waitingPods-glitch 
Refine WaitingPod interface for scheduler Permit plugin
 2020-02-10 09:23:54 -08:00
notpad
a7057f8df0 Cleanup "slow-path" logic in scheduler Filters 2020-02-10 22:48:49 +08:00
Quan Tian
c2d3e54551 EndpointSliceTracker should track updated resource version 
During EndpointSlice reconcilation, EndpointSliceTracker is supposed to
track expected EndpointSlice resource versions so that external changes
to them can be detected. But it actually tracked the stale resource
version and resulted in every Service was handled twice as it always
received an EndpointSlice update with a different resource version but
was actually created/updated by itself during the first processing.
 2020-02-10 21:47:07 +08:00
Yecheng Fu
bb2b50f3db Garbage collector should orphan ControllerRevisions too 
Signed-off-by: Yecheng Fu <fuyecheng@pingcap.com>
 2020-02-10 20:58:28 +08:00
Kevin Klues
0b168f0243 Change devicemanager to implement HintProvider.Allocate() 
This change will not work on its own. Higher level code needs to make
sure and call Allocate() before AddContainer is called. This is already
being done in cases when the TopologyManager feature gate is enabled (in
the PodAdmitHandler of the TopologyManager). However, we need to make
sure we add proper logic to call it in cases when the TopologyManager
feature gate is disabled.
 2020-02-10 03:27:47 +00:00
Kevin Klues
91f91858a5 Change CPUManager to implement HintProvider.Allocate() 
This change will not work on its own. Higher level code needs to make
sure and call Allocate() before AddContainer is called. This is already
being done in cases when the TopologyManager feature gate is enabled (in
the PodAdmitHandler of the TopologyManager). However, we need to make
sure we add proper logic to call it in cases when the TopologyManager
feature gate is disabled.
 2020-02-10 03:27:47 +00:00
Kevin Klues
9e4ee5ecc3 Add Allocate() call to TopologyManager's HintProvider interface 
Having this interface allows us to perform a tight loop of:

    for each container {
        containerHints = {}
        for each provider {
	    containerHints[provider] = provider.GatherHints(container)
        }

        containerHints.MergeAndPublish()

        for each provider {
	    provider.Allocate(container)
        }
    }

With this in place we can now be sure that the hints gathered in one
iteration of the loop always consider the allocations made in the
previous.
 2020-02-10 03:27:47 +00:00
Kevin Klues
a3f099ea4d Split devicemanager Allocate into two functions 
Instead of having a single call for Allocate(), we now split this into two
functions Allocate() and UpdatePluginResources().

The semantics split across them:

// Allocate configures and assigns devices to a pod. From the requested
// device resources, Allocate will communicate with the owning device
// plugin to allow setup procedures to take place, and for the device
// plugin to provide runtime settings to use the device (environment
// variables, mount points and device files).
Allocate(pod *v1.Pod) error

// UpdatePluginResources updates node resources based on devices already
// allocated to pods. The node object is provided for the device manager to
// update the node capacity to reflect the currently available devices.
UpdatePluginResources(
    node *schedulernodeinfo.NodeInfo,
    attrs *lifecycle.PodAdmitAttributes) error

As we move to a model in which the TopologyManager is able to ensure
aligned allocations from the CPUManager, devicemanger, and any
other TopologManager HintProviders in the same synchronous loop, we will
need to be able to call Allocate() independently from an
UpdatePluginResources(). This commit makes that possible.
 2020-02-10 03:27:47 +00:00
Kubernetes Prow Robot
ac97b2d65e
Merge pull request #83507 from lyft/support-resetting-cpuacct 
Prevent returning invalid usageNanoCores value when cpuacct is reset in a live container
 2020-02-09 08:45:53 -08:00
Kubernetes Prow Robot
652f52b51c
Merge pull request #85637 from dims/cinder-migration-flag 
Flip CSIMigrationOpenStack flag to be beta and off by default
 2020-02-08 21:49:52 -08:00
Kubernetes Prow Robot
abe6321296 Merge pull request #87952 from mikedanese/opts 
add *Options to Create, Update, and Patch in generated clientsets
 2020-02-08 20:43:53 -08:00
Kubernetes Prow Robot
d09f8b9d54
Merge pull request #79409 from takmatsu/add-phase 
Modify Kubelet Pod Resources API to get only active pods
 2020-02-08 16:09:52 -08:00
Kubernetes Prow Robot
a280a967a5 Merge pull request #87853 from alculquicondor/fix/options_test 
Do lenient decoding only for kubescheduler.config.k8s.io/v1alpha1
 2020-02-08 14:46:21 -08:00
Kubernetes Prow Robot
0c6470115e
Merge pull request #86578 from tnqn/except-validation 
Validate Except of IPBlock for NetworkPolicy spec
 2020-02-08 14:45:53 -08:00
Mike Danese
bfc75d9a5c manual fixes 2020-02-08 12:32:33 -05:00
Mike Danese
25651408ae generated: run refactor 2020-02-08 12:30:21 -05:00
Kubernetes Prow Robot
dde6e8e746 Merge pull request #87858 from smarterclayton/different_type 
kubelet: Debug pod status output diff is wrong
 2020-02-08 06:44:06 -08:00
Kubernetes Prow Robot
334d788f08 Merge pull request #87299 from mikedanese/ctx 
context in client-go
 2020-02-08 06:43:52 -08:00
andyzhangx
657dedc3be add azure disk WriteAccelerator support 2020-02-08 07:43:21 +00:00
Kubernetes Prow Robot
b3ba969756 Merge pull request #87913 from cheftako/master 
Add code to fix kubelet/metrics memory issue.
 2020-02-07 21:51:53 -08:00
Kubernetes Prow Robot
6d4e2d722e
Merge pull request #87381 from yuxiaobo96/k8s-staticcheck3 
staticcheck: pkg/volume/fc, pkg/volume/portworx and pkg/volume/vspher…
 2020-02-07 18:32:58 -08:00
Kubernetes Prow Robot
b61f89dd25
Merge pull request #85321 from MikeSpreitzer/apf-printers 
Added server-side printers for API priority and fairness
 2020-02-07 18:31:58 -08:00
Kubernetes Prow Robot
e1d6c0d095
Merge pull request #84620 from seans3/tablegenerator-test 
Adds initial unit tests for tablegenerator.go
 2020-02-07 18:31:45 -08:00
Mike Danese
2637772298 some manual fixes 2020-02-07 18:17:40 -08:00
Mike Danese
3aa59f7f30 generated: run refactor 2020-02-07 18:16:47 -08:00
Wei Huang
b8e2b0d990
Refine WaitingPod interface 2020-02-07 16:32:48 -08:00
Kubernetes Prow Robot
9617322727
Merge pull request #87904 from alculquicondor/rm_v1alpha2_deprecated 
Remove deprecated fields from kubescheduler.config.k8s.io/v1alpha2
 2020-02-07 15:20:32 -08:00
Kubernetes Prow Robot
d8b325b534
Merge pull request #85856 from adelina-t/cpu_requests_fix_ctrd 
Fix Cpu Requests priority Windows.
 2020-02-07 15:19:58 -08:00
Walter Fender
9802bfcec0 Add code to fix kubelet/metrics memory issue. 
Bucketing url paths based on concept/handling.
Bucketing code placed by handling code to encourage usage.
Added unit tests.
Fix format.
 2020-02-07 15:12:24 -08:00
James DeFelice
6f8dfdfb0e Fix docker/journald logging conformance 
See issue #86367
 2020-02-07 16:04:27 -06:00
Aldo Culquicondor
2ffb13e822 Do lenient decoding only for kubescheduler config v1alpha1 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
 2020-02-07 15:41:00 -05:00
Kubernetes Prow Robot
77de56994e
Merge pull request #87885 from alexzimmer96/68026-lint-pkg-registry-core-pod 
Fix Golint errors in pkg/registry/core/pod
 2020-02-07 12:32:41 -08:00
Kubernetes Prow Robot
7cfa396e7c
Merge pull request #87725 from alculquicondor/rm_affinity_weight 
Add defaults to pod affinity args
 2020-02-07 12:32:17 -08:00
Kubernetes Prow Robot
cbffb19c76
Merge pull request #87609 from mvisonneau/rbd_mount_ro_fix 
Fixed a failing test on a RBD mount scenario
 2020-02-07 12:32:03 -08:00
Kubernetes Prow Robot
8af70aeafc
Merge pull request #87390 from mattjmcnaughton/mattjmcnaughton/refactor-docker-specific-oom-out-of-qos-pkg 
Refactor docker specific oom const out of qos pkg
 2020-02-07 12:31:48 -08:00
Ted Yu
f48e5de963 Remove the exponential backoff in NodeGetInfo 2020-02-07 06:39:12 -08:00
Kubernetes Prow Robot
cf3ba4a26e
Merge pull request #87900 from alculquicondor/rm_log 
Remove Error log for nil StartTime in preemption candidates
 2020-02-07 05:58:18 -08:00
Kubernetes Prow Robot
8215619ba4
Merge pull request #87642 from pohly/volume-binder-testing 
volume binder testing
 2020-02-07 05:56:39 -08:00
Kubernetes Prow Robot
c24fa741ae
Merge pull request #87499 from ejweber/fc-mount-options 
FC mount options
 2020-02-07 05:55:56 -08:00
Alexander Zimmermann
e0b1e9206d
Clarified comments 2020-02-07 09:09:49 +01:00
Kubernetes Prow Robot
fc6f878a65
Merge pull request #87845 from Huang-Wei/pts-exclude-terminating-pods 
PodTopologySpread plugin now excludes terminatingPods
 2020-02-07 00:08:20 -08:00
Kubernetes Prow Robot
c5bf3fbdf0
Merge pull request #87612 from enj/enj/i/oidc_audience_token_review 
Make oidc authenticator audience agnostic
 2020-02-07 00:07:56 -08:00
Takeaki Matsumoto
785fac6826 Make updateAllocatedDevices() as a public method and call it in 
podresources api
 2020-02-07 13:26:56 +09:00
Kubernetes Prow Robot
69e01784c1
Merge pull request #87838 from Ikuyadeu/path2filepath 
Move 'path' package usage to 'path/filepath' (repeat the #87713)
 2020-02-06 17:48:11 -08:00
Kubernetes Prow Robot
9c1e124b15
Merge pull request #87823 from tallclair/test-tokens 
Ensure testing credentials are labeled as such
 2020-02-06 17:47:29 -08:00
Kubernetes Prow Robot
ef4e2c9f04
Merge pull request #87818 from tedyu/node-info-err 
Check getNodeInfoError against nil
 2020-02-06 17:47:13 -08:00
Kubernetes Prow Robot
3dc3c7c653
Merge pull request #87788 from ahg-g/ahg-filter 
Reduce overhead of error message formatting and allocation for NodeResource filter
 2020-02-06 17:46:50 -08:00
Kubernetes Prow Robot
6ac8f2c70c
Merge pull request #87758 from klueska/upstream-cleanup-topology-manager 
Cleanup TopologyManager and update policy.Merge()
 2020-02-06 17:46:27 -08:00
Kubernetes Prow Robot
04e28b3674
Merge pull request #87098 from davidz627/feature/migratedRollback 
Add annotation updating for migration for PVs and PVCs
 2020-02-06 17:45:32 -08:00
Aldo Culquicondor
1071eb89f3 Remove deprecated fields from kubescheduler.config.k8s.io/v1alpha2 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
 2020-02-06 16:22:30 -05:00
Aldo Culquicondor
e9e11de4e1 Remove Error log for nil StartTime 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
 2020-02-06 14:09:44 -05:00
Ted Yu
871739e4df Check getNodeInfoError against nil 2020-02-06 10:57:43 -08:00
marosset
999fdfaddf Calling hcsshim instead of docker api to get stats for windows to greatly reduce latency 2020-02-06 17:59:10 +00:00
Alexander Zimmermann
a1c837022c
Fixed Golint errors in pkg/controller/podautoscaler 2020-02-06 17:16:38 +01:00
Wei Huang
815206685c
PodTopologySpread excludes terminatingPods when making scheduling decision 2020-02-06 07:38:50 -08:00
Alexander Zimmermann
22bd92a390
Changed comments to match with interfaces method description 2020-02-06 11:48:57 +01:00
Alexander Zimmermann
026ba54961
Fixed Golint errors in pkg/registry/core/pod 2020-02-06 11:40:37 +01:00
Kubernetes Prow Robot
a67238eed6
Merge pull request #87007 from wojtek-t/cleanup_manual_conversions 
Cleanup manual conversions
 2020-02-06 02:27:33 -08:00
Clayton Coleman
aed4d639a5
kubelet: Debug pod status output diff is wrong 
The types were different so the diff output is not useful, both
should be pointers:

```
Feb 05 19:44:40 ci-ln-6k7l4-w-c-w9wbb.c.openshift-gce-devel-ci.internal hyperkube[2737]: I0205 19:44:40.222259    2737 status_manager.go:642] Pod status is inconsistent with cached status for pod "prometheus-k8s-1_openshift-monitoring(0e9137b8-3bd2-4353-b7f5-672749106dc1)", a reconciliation should be triggered:
Feb 05 19:44:40 ci-ln-6k7l4-w-c-w9wbb.c.openshift-gce-devel-ci.internal hyperkube[2737]:    interface{}(
Feb 05 19:44:40 ci-ln-6k7l4-w-c-w9wbb.c.openshift-gce-devel-ci.internal hyperkube[2737]: -         s"&PodStatus{Phase:Running,Conditions:[]PodCondition{PodCondition{Type:Initialized,Status:True,LastProbeTime:0001-01-01 00:00:00 +0000 UTC,LastTransitionTime:2020-02-05 19:13:30 +0000 UTC,Reason:,Message:,},PodCondit>
Feb 05 19:44:40 ci-ln-6k7l4-w-c-w9wbb.c.openshift-gce-devel-ci.internal hyperkube[2737]: +         v1.PodStatus{
Feb 05 19:44:40 ci-ln-6k7l4-w-c-w9wbb.c.openshift-gce-devel-ci.internal hyperkube[2737]: +                 Phase: "Running",
Feb 05 19:44:40 ci-ln-6k7l4-w-c-w9wbb.c.openshift-gce-devel-ci.internal hyperkube[2737]: +                 Conditions: []v1.PodCondition{
```
 2020-02-05 14:52:46 -05:00
ksubrmnn
378fcc809a Check for node IP 2020-02-05 11:44:26 -08:00
Kubernetes Prow Robot
d90dd93855
Merge pull request #82111 from xieyanker/xieyanker-patch-2 
remove stateCheckPeriod
 2020-02-05 04:17:55 -08:00
Yuki Ueda
d1bc1875aa Move 'path' package usage to 'path/filepath' 2020-02-05 14:29:27 +09:00
Monis Khan
9b23f22472
Make oidc authenticator audience agnostic 
This change removes the audience logic from the oidc authenticator
and collapses it onto the same logic used by other audience unaware
authenticators.

oidc is audience unaware in the sense that it does not know or
understand the API server's audience.  As before, the authenticator
will continue to check that the token audience matches the
configured client ID.

The reasoning for this simplification is:

1. The previous code tries to make the client ID on the oidc token
a valid audience.  But by not returning any audience, the token is
not valid when used via token review on a server that is configured
to honor audiences (the token works against the Kube API because the
audience check is skipped).

2. It is unclear what functionality would be gained by allowing
token review to check the client ID as a valid audience.  It could
serve as a proxy to know that the token was honored by the oidc
authenticator, but that does not seem like a valid use case.

3. It has never been possible to use the client ID as an audience
with token review as it would have always failed the audience
intersection check.  Thus this change is backwards compatible.

It is strange that the oidc authenticator would be considered
audience unaware when oidc tokens have an audience claim, but from
the perspective of the Kube API (and for backwards compatibility),
these tokens are only valid for the API server's audience.

This change seems to be the least magical and most consistent way to
honor backwards compatibility and to allow oidc tokens to be used
via token review when audience support in enabled.

Signed-off-by: Monis Khan <mok@vmware.com>
 2020-02-04 13:24:49 -08:00
Tim Allclair
9d3670f358 Ensure testing credentials are labeled as such 2020-02-04 10:36:05 -08:00
Quan Tian
ea693833c8 Validate Except of IPBlock for NetworkPolicy spec 
This patch enhances the validation of Except field that the values will
be rejected if they are not strictly within the CIDR range.
 2020-02-05 01:35:44 +08:00
Abdullah Gharaibeh
0a476eb7d4 reduce overhead of error message formatting and allocation for scheudler NodeResource filter 2020-02-04 11:02:29 -05:00
wojtekt
1fc80c57ee Autogenerated 2020-02-04 16:06:36 +01:00
wojtekt
881dde8bee Remove unnecessary manual conversions 2020-02-04 16:05:25 +01:00
Kubernetes Prow Robot
76c89645c5
Merge pull request #87713 from kkmsft/filepath-fixes-windows 
Move 'path' package usage to 'path/filepath'.
 2020-02-03 17:07:25 -08:00
Eric Weber
adcdb2fd72 Enable FC mount options 2020-02-03 16:13:58 -06:00
Aldo Culquicondor
60c972098c Add defaults to pod affinity args 
And remove pod affinity parameter from algorithm provider registry

Signed-off-by: Aldo Culquicondor <acondor@google.com>
 2020-02-03 14:58:28 -05:00
Kubernetes Prow Robot
845b232321
Merge pull request #87451 from jnaulty/jnaulty/fix-aws-ebs-createvolume-signature 
Fix CreateVolume signature in comment
 2020-02-03 10:51:21 -08:00
Kevin Klues
d5addb4090 Cleanup logging and creation logic of TopologyManager in prep for beta 2020-02-03 17:13:29 +00:00
Kevin Klues
bc686ea27b Update TopologyManager.GetTopologyHints() to take pointers 
Previously, this function was taking full Pod and Container objects
unnecessarily. This commit updates this so that they will take pointers
instead.
 2020-02-03 17:13:28 +00:00
Kevin Klues
adaa58b6cb Update TopologyManager.Policy.Merge() to return a simple bool 
Previously, the verious Merge() policies of the TopologyManager all
eturned their own lifecycle.PodAdmitResult result. However, for
consistency in any failed admits, this is better handled in the
top-level Topology manager, with each policy only returning a boolean
about whether or not they would like to admit the pod or not. This
commit changes the semantics to match this logic.
 2020-02-03 17:13:28 +00:00
Kevin Klues
95a3ac447f Fix bug in TopologManager RemoveContainer() 
Previously, we unconditionally removed *all* topology hints from a pod
whenever just one container was being removed. This commit makes it so
we only remove the hints for the single container being removed, and
then conditionally remove the pod from the podTopologyHints[podUID] when
no containers left in it.
 2020-02-03 17:13:14 +00:00
Kubernetes Prow Robot
5caeec8023
Merge pull request #87710 from alena1108/jan30proxy 
Ineffassign fixes for pkg/proxy
 2020-02-02 19:09:20 -08:00
Kubernetes Prow Robot
7e5bfe4417
Merge pull request #85472 from dcbw/kubelet-network-approvers 
kubelet/network: add sig-network-approvers to OWNERS
 2020-02-01 12:55:19 -08:00
Kubernetes Prow Robot
35dfa2c4df
Merge pull request #87565 from SomtochiAma/more-unit-tests-scheduler 
More unit tests for scheduler
 2020-02-01 01:11:20 -08:00
Kubernetes Prow Robot
536c2c8918
Merge pull request #87706 from liggitt/fix-statefulset-conversion 
Fix statefulset conversion
 2020-01-31 20:08:16 -08:00
Somtochi Onyekwere
0e00e0af11 Adds more unit test on Bind extension for the scheduler 2020-01-31 22:37:22 +01:00
wojtekt
b11b7d354d WatchBasedManager stops watching immutable objects 2020-01-31 20:53:21 +01:00
Mike Spreitzer
ff8256de3f Added server-side print column about FlowSchema referential integrity 2020-01-31 13:33:07 -05:00
Alena Prokharchyk
331cd94ccc Ineffassign fixes for pkg/volume 
Along resolves errors whitelisted in hack/.staticcheck_failures
 2020-01-31 10:14:45 -08:00
Antonio Ojea
4844b382dc
kube-proxy: validate dual-stack cidrs 
kube-proxy was not validating correctly the clusterCIDRs, if
dual-stack it MAY have 1 or more clusterCIDRs. If it has 2 cidrs and
at least one of each IP family.

It also fixes a bug where validation was not taking into account
the feature gates global state.
 2020-01-31 16:00:17 +01:00
Kubernetes Prow Robot
7f0ea141d2
Merge pull request #87692 from everpeace/fix-scheduler-queue-metrics 
Fix some scheduler metrics(pending_pods and schedule_attempts_total) are not recorded.
 2020-01-31 05:30:19 -08:00
Jordan Liggitt
82107ff8ab Restore statefulset conversion that populates apiVersion/kind in volume templates 2020-01-31 07:47:35 -05:00
Shingo Omura
c9c4be66d3 Fix pending_pods, schedule_attempts_total was not recorded 
because metric initializations are too early. This causes actual metric
instance become no-op.

modification made in thie commit to make sure actual metric instance won't be no-op metrics:

- re-initialize scheduler/metrics.PodSchedule{Successes, Failure, Errors} after metric creation
- scheduler/metrics.Register() should be called before initializing SchedulingQueue,
 2020-01-31 17:03:41 +09:00
Kubernetes Prow Robot
1baceba376
Merge pull request #87394 from mattjmcnaughton/mattjmcnaughton/delete-sysctl-runtime-admit-handler 
Delete the sysctl runtime admit handler
 2020-01-30 21:20:45 -08:00
Kubernetes Prow Robot
fa4bc10ef1
Merge pull request #86793 from prameshj/gce-finalizer 
Attach a new finalizer in GCE ILB creation.
 2020-01-30 21:20:32 -08:00
Kubernetes Prow Robot
95a1d5e699
Merge pull request #82820 from odinuge/hugetlb-node-multiple-size 
Add support for pre-allocated hugepages with 2+ sizes
 2020-01-30 21:20:18 -08:00
Kubernetes Prow Robot
5ced53c0c4
Merge pull request #87628 from alculquicondor/cc-v1alpha2 
Add kubescheduler.config.k8s.io/v1alpha2
 2020-01-30 16:59:33 -08:00
Kubernetes Prow Robot
ff536eec2e
Merge pull request #87602 from wojtek-t/cleanup_immutable_validation 
Cleanup validation for immutable secrets/configmaps
 2020-01-30 16:59:23 -08:00
Kubernetes Prow Robot
0b18af6d43
Merge pull request #87384 from yuxiaobo96/k8s-cleanup 
cleanup: delete unused func
 2020-01-30 16:58:47 -08:00
Krishnakumar R(KK)
72fe307b35 Move 'path' package usage to 'path/filepath'. 
In case of windows, the path package functions such as 'Dir' returns faulty directory path.
For eg: 'path.Dir' on 'c:\var\lib\kubelet\pods' returns '.', where as the result should
have been 'c:\var\lib\kubelet'. The filepath package returns the right values.
 2020-01-30 15:53:18 -08:00
Kubernetes Prow Robot
8be2f8c626
Merge pull request #86144 from tahsinrahman/dont-serialize-internal 
Do not serialize internal types in ComponentConfig tests
 2020-01-30 15:02:19 -08:00
Alena Prokharchyk
6c3093f970 Ineffassign fixes for pkg/controller and kubelet 2020-01-30 14:35:10 -08:00
Alena Prokharchyk
43ce2eb1ff Ineffassign fixes for pkg/proxy 2020-01-30 14:34:33 -08:00
Michael Beaumont
3eea0d1405
kube-proxy: Only open ipv4 sockets for ipv4 clusters 2020-01-30 18:54:16 +01:00
Lee Verberne
d05bcf6800 Add namespace mode targeting to dockershim 2020-01-30 15:31:43 +01:00
Lee Verberne
4d4e111f01 Generated code for kubelet namespace targeting 2020-01-30 15:31:43 +01:00
Lee Verberne
9a6d50cb2a Add namespace targeting to the kubelet 2020-01-30 15:31:43 +01:00
Kubernetes Prow Robot
7164152844
Merge pull request #87664 from liggitt/revert-parallel-volume 
Revert "Merge pull request #87258 from verult/slow-rxm-attach"
 2020-01-29 22:12:01 -08:00
Kubernetes Prow Robot
ec3fc59f1b
Merge pull request #87627 from tallclair/rc-metrics 
Register RunPodSandbox* metrics
 2020-01-29 22:11:25 -08:00
Kubernetes Prow Robot
8df708d676
Merge pull request #87616 from alculquicondor/backoff 
Fix back off when scheduling cycle is delayed
 2020-01-29 22:11:13 -08:00
Aldo Culquicondor
3d83ef2e8e Autogenerated and build files for kubescheduler.config.k8s.io/v1alpha2 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
 2020-01-29 17:18:48 -05:00
Aldo Culquicondor
11c4bcd9dd Copy kubescheduler.config.k8s.io/v1alpha1 files onto v1alpha2 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
 2020-01-29 17:18:41 -05:00
Aldo Culquicondor
8daa761757 Clean ups on kubescheduler.config.k8s.io/v1alpha1 files 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
 2020-01-29 17:17:53 -05:00
Jordan Liggitt
cd1059e3c4 Revert "Merge pull request #87258 from verult/slow-rxm-attach" 
This reverts commit 15c3f1b119, reversing
changes made to 52d7614a8c.
 2020-01-29 14:58:32 -05:00
Aldo Culquicondor
9d2786c383 Fix back off when scheduling cycle is delayed 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
 2020-01-29 13:15:13 -05:00
Mike Danese
968adfa993 cleanup req.Context() and ResponseWrapper 2020-01-29 08:50:45 -08:00
Mike Danese
d55d6175f8 refactor 2020-01-29 08:50:45 -08:00
Kubernetes Prow Robot
3dccf54175
Merge pull request #87566 from skilxn-go/Speard 
Skip default spreading scoring plugin for pods that define TopologySpreadConstraints
 2020-01-29 07:32:53 -08:00
Kubernetes Prow Robot
17936ff63b
Merge pull request #87544 from SenXuDC/staticcheck 
fix static check in pkg/volume/flocker
 2020-01-29 07:32:42 -08:00
Kubernetes Prow Robot
649391af22
Merge pull request #84154 from ohsewon/hugepage_per_container 
Implement support for setting hugepages limit on container cgroup sandbox.
 2020-01-29 07:32:14 -08:00
Patrick Ohly
a3c434510d volume binder: enable klog flags in test 
When debugging the test runs it is useful to increase the log level:

go test -v ./pkg/controller/volume/scheduling -args -v 5
 2020-01-29 10:37:39 +01:00
Patrick Ohly
5c8929d95e volume binder: convert to sub-tests 
Using t.Run() has some advantages:
- individual sub-tests can be selected with -run
- test failures are automatically associated with
  the scenario, therefore the test name no longer
  needs to be passed around

A "run" function is used primarily to avoid large indention changes,
but also because this can be used to extend the test with additional
parameters later on.
 2020-01-29 10:37:27 +01:00
Kubernetes Prow Robot
f5a008746a
Merge pull request #83526 from eloyekunle/feat/gengo-reverse-import 
import-boss reverse import
 2020-01-28 18:50:13 -08:00
Pavithra Ramesh
1de2327afc Attach a new finalizer in GCE ILB creation. 
Add logic in service_controller to skip create/update
if finalizer from a different controller is found.

The newly added finalizer will be checked by other controllers
implementing ILB services to determine if a given service is
already being managed by service_controller.

Moved finalizer check into cloudprovider code.

added unit test to verify new finalizer.

Modified existing unit test to create a fake service so that
attach/remove finalizer step can be tested.
 2020-01-28 15:02:19 -08:00
Tim Allclair
43c7f3be29 Register RunPodSandbox* metrics 2020-01-28 13:26:11 -08:00
Oleg Atamanenko
427f0f9463 Add apiVersion to involvedObject 2020-01-28 09:24:08 -08:00
Kubernetes Prow Robot
15c3f1b119
Merge pull request #87258 from verult/slow-rxm-attach 
Parallelize attach operations across different nodes for volumes that allow multi-attach
 2020-01-28 08:33:41 -08:00
skilxn-go
a4d1624fec Skip default spreading scoring plugin for pods that define TopologySpreadConstraints 2020-01-28 22:25:03 +08:00
Elijah Oyekunle
bae4ff565f fix apiextensions reference in controller/clusterauthenticationtrust 2020-01-28 14:11:12 +01:00
Maxime VISONNEAU
bea4b61158
Fixed a failing test on a RBD mount scenario 2020-01-28 12:44:34 +00:00
Elijah Oyekunle
07e3cca6d0 update existing import-restrictions files 2020-01-28 10:51:45 +01:00
wojtekt
39f6c784b7 Cleanup validation for immutable secrets/configmaps 2020-01-28 09:40:12 +01:00
sewon.oh
463442aa29
Update container hugepage limit when creating the container 
Unit test for updating container hugepage limit
Add warning message about ignoring case.
Update error handling about hugepage size requirements

Signed-off-by: sewon.oh <sewon.oh@samsung.com>
 2020-01-28 09:35:02 +09:00
David Zhu
b7817a2981 Add annotation annealing for migration for PVs and PVCs during syncVolume and syncClaim. This allows external-provisioners to pick up and delete volumes when they have been rolled up from previous kubernetes versions. 2020-01-27 16:14:53 -08:00
Cheng Xing
c6a03fa5be Parallelize attach operations across different nodes for volumes that allow multi-attach 2020-01-27 15:02:25 -08:00
Cheng Xing
37957e2a0d Refactor operation keys for NestedPendingOperations 2020-01-27 10:42:16 -08:00
Jiahui Feng
b2bb3dfb59 add logging before kubelet waiting for cert 
during bootstrapping.
 2020-01-27 10:12:36 -08:00
Kubernetes Prow Robot
2059ad6573
Merge pull request #87548 from skilxn-go/AddLoging 
Add logging to scheduler's event handlers
 2020-01-27 06:31:02 -08:00
skilxn-go
24844c5fc5 Add logging to scheduler's event handlers 2020-01-27 13:00:00 +08:00
Kubernetes Prow Robot
51bb3238f2
Merge pull request #87528 from MikeSpreitzer/refactor/catch-all 
Make API Priority and Fairness suggested config avoid the mandatory catch-all
 2020-01-26 18:35:02 -08:00
Kubernetes Prow Robot
93b2e42124
Merge pull request #87455 from SomtochiAma/scheduler-unit-tests 
Adds unit test on Bind extension for the scheduler
 2020-01-25 14:29:01 -08:00
Kubernetes Prow Robot
2cd685a020
Merge pull request #87250 from starizard/adding-taint-toleration-error-reasons 
Adding taint toleration error reasons
 2020-01-25 01:23:01 -08:00
Kubernetes Prow Robot
98f63eee1b
Merge pull request #87460 from nolancon/policies_refactor 
Refactor Topology Manager policies to reduce code duplication
 2020-01-24 21:11:15 -08:00
Kubernetes Prow Robot
4af73508f5
Merge pull request #87509 from Gridasov/ar-hosts 
Whitelisting *.pkg.dev for the GCP credential provider
 2020-01-24 19:21:38 -08:00
Kubernetes Prow Robot
02c1b7f220
Merge pull request #87237 from ialidzhikov/cleanup/commented-assertions 
Clean up commented assertions in tests
 2020-01-24 19:21:02 -08:00
SenXuDC
7c72b5791b fix static check in pkg/volume/flocker 2020-01-25 10:51:55 +08:00
Somtochi Onyekwere
8ae868b4e0 Adds more test cases in TestRunBindPlugins for the scheduler 2020-01-25 00:22:07 +01:00
Mike Spreitzer
a8e0747043 Updated API Priority and Fairness validation to track change in catch-all priority level 2020-01-24 14:05:43 -05:00
Yuriy Gridasov
f641ecd6f8 Whitelisting *.pkg.dev for the GCP credential provider 2020-01-24 10:19:19 -08:00
Kubernetes Prow Robot
58c67632e5
Merge pull request #87475 from liggitt/drop-ga-gates 
Remove deprecated GA feature gates that expire in 1.18
 2020-01-24 03:02:46 -08:00
Kubernetes Prow Robot
6c693549a3
Merge pull request #87183 from Aresforchina/fix-staticcheck-test15 
fix-staticcheck:pkg/volume/scaleio/
 2020-01-23 22:20:31 -08:00
Kubernetes Prow Robot
92f8a31f15
Merge pull request #82235 from mrkm4ntr/preemption-same-pdb 
Fix numPDBViolations when victims on same node are assigned same PDB
 2020-01-23 14:04:32 -08:00
Shawn Rebello
22bd26fefb Adding taint toleration error reasons 2020-01-24 02:50:55 +05:30
Kubernetes Prow Robot
dc090f80d1
Merge pull request #87406 from haosdent/remove-algo 
Remove `scheduler/algorithm/priorities` in import-restrictions
 2020-01-23 11:34:24 -08:00
Kubernetes Prow Robot
c5d981583a
Merge pull request #87308 from KobayashiD27/fix-staticcheck 
Fix staticcheck in pkg/controller/podgc
 2020-01-23 11:34:11 -08:00
Jordan Liggitt
57724766bc Remove deprecated GA feature gates 2020-01-23 13:44:21 -05:00
Md Tahsin Rahman
a85815823e Do not serialize internal type, fix roundtrip 2020-01-23 23:45:35 +06:00
Odin Ugedal
6e411b6c0a
Add support for pre-allocated hugepages with 2 sizes 
Remove the validation for pre-allocated hugepages on node level.
Validation is currently the only thing making it impossible to use
pre-allocated huge pages in more than one size.

We have now quite a few reports from real users that this feature is
welcome.
 2020-01-23 17:38:22 +01:00
Ted Yu
5b49d03b84 Return the error from copyInto 2020-01-23 07:48:39 -08:00
Kubernetes Prow Robot
0724871162
Merge pull request #86816 from deads2k/auto-reload-csr 
add dynamic reloading for CSR signing controllers
 2020-01-22 18:46:49 -08:00
Shintaro Murakami
577b2dcdac Fix numPDBViolations when victims on same node are assigned same PDB 2020-01-23 10:14:53 +09:00
Kubernetes Prow Robot
e41bb325c2
Merge pull request #87449 from SataQiu/fix-kube-proxy-20200122 
kube-proxy: fix incorrect log information
 2020-01-22 16:31:04 -08:00
Kubernetes Prow Robot
f409793eb6
Merge pull request #87458 from liu-cong/framework-metrics-new 
Record overall Filter latency for all nodes in a scheduling cycle.
 2020-01-22 14:48:50 -08:00
Kubernetes Prow Robot
81acde7adc
Merge pull request #87430 from alculquicondor/feat/bind_plugin 
Move default binding to a plugin
 2020-01-22 12:40:38 -08:00
David Eads
5c2d2c5ef1 rename dynamic cert loading to be more accurate 2020-01-22 15:00:46 -05:00
David Eads
6ccfc3aecf add dynamic reloading for CSR signing controllers 2020-01-22 15:00:46 -05:00
Aldo Culquicondor
4a5ab84dcc Move default binding to a plugin 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
 2020-01-22 14:13:33 -05:00
Cong Liu
e0aeb4d6a3 Record overall Filter latency for all nodes in a scheduling cycle. 2020-01-22 13:46:38 -05:00
Kubernetes Prow Robot
e4926e2d70
Merge pull request #85421 from terrytangyuan/patch-1 
Fix grammar: have -> has
 2020-01-22 08:40:58 -08:00
mattjmcnaughton
9e1c99c4e2
Delete the sysctl runtime admit handler 
As of https://github.com/kubernetes/kubernetes/pull/72831, the minimum
docker version is 1.13.1. (and the minimum API version is 1.26). The
only time the `RuntimeAdmitHandler` returns anything other than accept
is when the Docker API version < 1.24. In other words, we can be
confident that Docker will always support sysctl.

As a result, we can delete this unnecessary and docker-specific code.
 2020-01-22 08:51:39 -05:00
Kubernetes Prow Robot
1e252ceaad
Merge pull request #87439 from Huang-Wei/rm-sched-algorithm-folder 
Remove folder pkg/scheduler/algorithm
 2020-01-22 02:58:35 -08:00
nolancon
4d76b1c8de Add mergeFilteredHints: 
- Move remaining logic from mergeProvidersHints to generic top level
mergeFilteredHints function.
- Add numaNodes as parameter in order to make generic.
- Move single NUMA node specific check to single-numa-node Merge
function.
 2020-01-22 09:07:41 +00:00
John Naulty
80c3f500b6
Fix CreateVolume signature in comment 
The CreateVolume function for aws-ebs provsiioner returns fstype, which
was missing from the commented section above the function declaration.
 2020-01-22 01:06:26 -08:00
nolancon
fc300e0e7d Move filterSingleNumaHints call to top level Merge 2020-01-22 08:39:22 +00:00
SataQiu
c4f7308e11 kube-proxy: fix incorrect log information 2020-01-22 16:35:58 +08:00
nolancon
45660fd3a2 Add filterProvidersHints function: 
- Move initial 'filtering' functionality to generic function
filterProvidersHints level policy.go.
- Call new function from top level Merge function.
- Rename some variables/parameters to reflect changes.
 2020-01-22 08:35:28 +00:00
nolancon
df9b2595f3 Update filterHints to filterSingleNumaHints: 
- Change function name
- Remove policy parameter (unnecessary)
- Update unit test to reflect change
 2020-01-22 07:15:00 +00:00
Kubernetes Prow Robot
1735f7a2b6
Merge pull request #87377 from gavinfish/pkg-util-netsh 
Fix static check errors in pkg/util/netsh
 2020-01-21 22:02:35 -08:00
Haosdent Huang
b09e35257a Remove scheduler/algorithm/priorities in import-restrictions 2020-01-22 11:54:28 +08:00
Kubernetes Prow Robot
8cd0c42845
Merge pull request #87407 from haosdent/remove-registry-args 
Deprecate scheduler's framework.plugins.RegistryArgs
 2020-01-21 16:26:57 -08:00
Wei Huang
170714e532
Remove folder pkg/scheduler/algorithm 2020-01-21 14:33:08 -08:00
Kubernetes Prow Robot
c9b4cf3d25
Merge pull request #87342 from Huang-Wei/move-predicates-to-kubelet 
Move GeneralPredicates logic to kubelet.
 2020-01-21 12:58:47 -08:00
Kubernetes Prow Robot
95fcc5f777
Merge pull request #87072 from fenggw-fnst/work 
Fix typo in comments for func GetFullContainerName
 2020-01-21 12:58:34 -08:00
Wei Huang
3f8b202266
Move GeneralPredicates logic to kubelet. 2020-01-21 09:27:00 -08:00
Kubernetes Prow Robot
37f98ac3b6
Merge pull request #87401 from zouyee/move 
Move scheduler's SchedulerExtender interface to core/extenders.go
 2020-01-21 09:21:50 -08:00
Haosdent Huang
50d511d4b8 Deprecate scheduler's framework.plugins.RegistryArgs 2020-01-21 23:50:58 +08:00
Kubernetes Prow Robot
29a4b39536
Merge pull request #87382 from yiyang5055/fix-staticcheck 
fix static check failure in pkg/controller/disruption and pkg/control…
 2020-01-21 06:35:37 -08:00
zouyee
d6b449b5c7 Move scheduler's SchedulerExtender interface to core/extenders.go 
Signed-off-by: Zou Nengren <zouyee1989@gmail.com>
 2020-01-21 20:20:20 +08:00
Kubernetes Prow Robot
48cb968825
Merge pull request #87297 from alculquicondor/cleanup/get_binder 
Replace Scheduler.GetBinder with a method
 2020-01-20 21:25:36 -08:00
Kubernetes Prow Robot
9822016bf8
Merge pull request #87397 from klueska/upstream-cpu-manager-set-initial-containers 
Initialize CPUManager containerMap to set of initial containers
 2020-01-20 17:39:50 -08:00
Kubernetes Prow Robot
e6b5194ec1
Merge pull request #84300 from klueska/upstream-cpu-manager-reconcile-on-container-state 
Update logic in `CPUManager` `reconcileState()`
 2020-01-20 12:27:37 -08:00
Kevin Klues
bd9d8fa42f Initialize CPUManager containerMap to set of initial containers 
A recent change made it so that the CPUManager receives a list of
initial containers that exist on the system at startup. This list can be
non-empty, for example, after a kubelet retart.

This commit ensures that the CPUManagers containerMap structure is
initialized with the containers from this list.
 2020-01-20 20:42:29 +01:00
Aldo Culquicondor
eb265bc7db Remove GetBinder member and replace it with a method. 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
 2020-01-20 14:10:02 -05:00
Kubernetes Prow Robot
37ee6425ef
Merge pull request #87255 from klueska/upstream-remove-redundant-active-pods-check 
Remove check for empty activePods list in CPUManager removeStaleState
 2020-01-20 09:05:50 -08:00
Aldo Culquicondor
7a39e1396a Remove unnecessary slow binding test 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
 2020-01-20 11:49:45 -05:00
Kubernetes Prow Robot
23fa359d6c
Merge pull request #84705 from whypro/cpumanager-panic-master 
Return error instead of panic when cpu manager fails on startup.
 2020-01-20 07:25:37 -08:00
mattjmcnaughton
73b2d83125
Refactor docker specific oom const out of qos pkg 
Previously, `pkg/kubelet/qos` contained two different docker-specific
OOM constants. One set the oom adj for sandbox docker containers and the
other set the oom adj for the docker daemon. Move both to be closer to
their actual usages in `dockershim`.

This change addresses a TODO and leads us towards the overall goal of
making `pkg/kubelet` runtime agnostic except for `dockershim`.
 2020-01-20 10:22:31 -05:00
Kevin Klues
7be9b0fe55 Update comments and error messages in the CPUManager 2020-01-20 15:31:01 +01:00
Kevin Klues
f2acbf6607 Base CPUManager state reconciliation on container state, not pod state 2020-01-20 13:57:30 +00:00
Kevin Klues
f6cf9b8ce9 Move CPUManager Pod Status logic before container loop 2020-01-20 13:57:30 +00:00
Kubernetes Prow Robot
f680c261e6
Merge pull request #87074 from yuxiaobo96/k8s-staticcheck 
fix staticcheck: pkg/volume/awsebs
 2020-01-20 03:09:37 -08:00
yuxiaobo
221396ac35 cleanup: delete unused func 
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
 2020-01-20 18:20:57 +08:00
yiyang5055
53aff819e0 fix static check failure in pkg/controller/disruption and pkg/controller/namespace/deletion 2020-01-20 09:10:46 +00:00
yuxiaobo
72f34b817e staticcheck: pkg/volume/fc, pkg/volume/portworx and pkg/volume/vsphere_volume 
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
 2020-01-20 16:47:54 +08:00
Mike Spreitzer
ce12105edc Added server-side printers for the API object types for API priority and fairness 2020-01-20 01:49:05 -05:00
Kubernetes Prow Robot
3d8317ae91
Merge pull request #87139 from yuxiaobo96/k8s-staticcheck2 
fix staticcheck:pkg/volume/cinder
 2020-01-19 21:47:36 -08:00
drfish
f19f4e40f9 Fix static check errors in pkg/util/netsh 2020-01-20 13:25:34 +08:00
Sakura
203c7b4731
fix staticcheck errors in pkg/controller/daemon. 
Signed-off-by: Sakura <longfei.shang@daocloud.io>
 2020-01-19 21:09:05 +08:00
Kubernetes Prow Robot
073da1588a
Merge pull request #86801 from likakuli/fix_syncsts_orphanrevision 
fix a bug that orphan revision cannot be adopted and statefulset cannot be synced
 2020-01-19 00:07:35 -08:00
Kubernetes Prow Robot
f4b6b751cd
Merge pull request #87081 from dims/updating-protobuf-and-grpc 
Updating protobuf (v1.3.1) and grpc (v1.26.0)
 2020-01-18 13:01:36 -08:00
Kubernetes Prow Robot
37d9c22abe
Merge pull request #86377 from wojtek-t/immutable_secrets_api 
API for immutable Secrets and ConfigMaps
 2020-01-18 05:25:35 -08:00
Kubernetes Prow Robot
c1b696d672
Merge pull request #87313 from MikeSpreitzer/apf-validation 
Update validation for API Priority and Fairness
 2020-01-18 01:49:51 -08:00
Kubernetes Prow Robot
967b40f051
Merge pull request #86137 from robscott/endpointslice-proxy-feature 
Creating new EndpointSliceProxying feature gate for kube-proxy, enabling EndpointSlice feature gate by default
 2020-01-17 21:39:36 -08:00
Mike Spreitzer
47ad6db1dc Fixup comments in internalbootstrap 2020-01-17 22:16:50 -05:00
Kubernetes Prow Robot
3538320d74
Merge pull request #87165 from alculquicondor/cleanup/mv_snapshot_2 
Move Snapshot to internal/cache
 2020-01-17 17:14:07 -08:00
Rob Scott
469de65c25
Enabling EndpointSlice feature gate by default 
This enables the EndpointSlice controller by default, but does not make
kube-proxy a consumer of the EndpointSlice API.
 2020-01-17 16:19:29 -08:00
Rob Scott
47b2593d59
Creating new EndpointSliceProxying feature gate for kube-proxy 
This creates a new EndpointSliceProxying feature gate to cover EndpointSlice
consumption (kube-proxy) and allow the existing EndpointSlice feature gate to
focus on EndpointSlice production only. Along with that addition, this enables
the EndpointSlice feature gate by default, now only affecting the controller.

The rationale here is that it's really difficult to guarantee all EndpointSlices
are created in a cluster upgrade process before kube-proxy attempts to consume
them. Although masters are generally upgraded before nodes, and in most cases,
the controller would have enough time to create EndpointSlices before a new node
with kube-proxy spun up, there are plenty of edge cases where that might not be
the case. The primary limitation on EndpointSlice creation is the API rate limit
of 20QPS. In clusters with a lot of endpoints and/or with a lot of other API
requests, it could be difficult to create all the EndpointSlices before a new
node with kube-proxy targeting EndpointSlices spun up.

Separating this into 2 feature gates allows for a more gradual rollout with the
EndpointSlice controller being enabled by default in 1.18, and EndpointSlices
for kube-proxy being enabled by default in the next release.
 2020-01-17 16:17:40 -08:00
Mike Spreitzer
4d88acee51 Made internalbootstrap gin up its own Scheme 
doing our part to reduce usage of legacyscheme.Scheme
 2020-01-17 16:47:40 -05:00
Mike Spreitzer
5330bd7440 dogged insistence on full verbosity 2020-01-17 15:46:36 -05:00
Kubernetes Prow Robot
f88f58cb79
Merge pull request #87245 from 928234269/fix_staticcheck 
fix staticcheck errors in pkg/volume/hostpath.
 2020-01-17 12:15:18 -08:00
Aldo Culquicondor
f53d7e55df Move Snapshot from nodeinfo/snapshot to internal/cache 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
 2020-01-17 13:29:41 -05:00
Kubernetes Prow Robot
0040920045
Merge pull request #87293 from pmorie/brad-childs-owners 
Remove Brad Childs from OWNERS files
 2020-01-17 09:00:56 -08:00
Aldo Culquicondor
6a14203658 Rename cache's Snapshot to Dump 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
 2020-01-17 11:28:08 -05:00
Davanum Srinivas
b3853138a4
update generated files 2020-01-17 11:23:53 -05:00
Kubernetes Prow Robot
50f9ea7999
Merge pull request #85798 from nolancon/merge-policy-rebase 
Updated - topologymanager: Add Merge method to Policy
 2020-01-17 05:14:56 -08:00
Kubernetes Prow Robot
6278df2a97
Merge pull request #82223 from rikatz/issue77493 
Check first if ipvs module is builtin
 2020-01-17 03:52:56 -08:00
Sakura
fe8b32317f
delete unused field 
Signed-off-by: Sakura <longfei.shang@daocloud.io>
 2020-01-17 19:34:48 +08:00
Mike Spreitzer
ec5321c6a9 Update validation for API Priority and Fairness 
This PR fixes oversights and adds validation that rejects writes
of wrong Spec values for the four mandatory objects.
 2020-01-17 02:43:52 -05:00
Kobayashi Daisuke
ed1381e35f Fix staticcheck in pkg/controller/podgc 2020-01-17 15:42:38 +09:00
Wei Huang
c712230ac1
Implement default queue sort logic as a scheduler plugin 2020-01-16 19:10:43 -08:00
Paul Morie
afaea605f4 Remove Brad Childs from OWNERS files 2020-01-16 15:21:34 -05:00
Kubernetes Prow Robot
9701baea0f
Merge pull request #87283 from klueska/update-printing-for-tm-bitmask 
Update bitmask printing to print in groups of 2 instead of all 64 bits
 2020-01-16 12:04:32 -08:00
Kevin Klues
708278098a Update bitmask printing to print in groups of 2 instead of all 64 bits 2020-01-16 17:28:52 +01:00
Kubernetes Prow Robot
0c1d714627
Merge pull request #87128 from Aresforchina/fix-staticcheck-test12 
fix-staticcheck:pkg/volume/emptydir
 2020-01-16 07:48:50 -08:00
Kevin Klues
7069b1d6e8 Update TopologyManager single-numa-node logic to handle "don't cares" 
The logic has been updated to match the logic of the best-effort policy
except in two places:

1) The hint filtering frunction has been updated to allow "don't care"
hints encoded with a `nil` affinity mask, to pass through the filter in
addition to hints that have just a single NUMA bit set.

2) After calculating the `bestHint` we transform "don't care" affinities
encoded as having all NUMA bits set in their affinity masks into "don't
care" affinities encoded as `nil`.
 2020-01-16 08:50:35 +00:00
Kevin Klues
2905ffffa7 Rename TopologyManager test TestPolicyBestEffortMerge for consistency 2020-01-16 08:50:21 +00:00
Kevin Klues
94489c137c Cleanup use of defaultAffinity in mergePermutation of TopologyManager 2020-01-16 08:50:12 +00:00
nolancon
5e23517ebf Use reflect.DeepEqual check in policy_test.go 2020-01-16 08:13:07 +00:00
nolancon
92eb7cd601 Update "Single NUMA hint generation" expected affinity to nil 2020-01-16 08:13:07 +00:00
nolancon
8b3f6e61a2 Move test case "Two providers, 1 with 2 hints, 1 with single 
non-preferred hint matching" into specific policy tests
 2020-01-16 08:13:07 +00:00
nolancon
681c42bfc2 Move test case "Two providers, 1 hint each, same mask, 1 preferred, 1 
not 2/2" into specific policy tests
 2020-01-16 08:13:07 +00:00
nolancon
a38a2562b2 Move test case "Two providers, 1 hint each, same mask, 1 preferred, 1 
not 1/2" into specific policy test.
 2020-01-16 08:13:07 +00:00
nolancon
f639da7637 Move test case "Two providers, 1 hint each, no common mask" into 
specific policy tests.
 2020-01-16 08:13:07 +00:00
nolancon
401a2bb285 Move test case "Single TopologyHint with Preferred as false and 
NUMANodeAffinity as nil" into specific policy tests.
 2020-01-16 08:13:06 +00:00
nolancon
6460ef6392 Move test case "Single TopologyHint with Preferred as true and 
NUMANodeAffinity as nil" into specific policy tests.
 2020-01-16 08:13:06 +00:00
nolancon
baeff9ec5d Move test case "HintProvider returns empty non-nil map[string][]TopologyHint from 
provider" into specific policy tests.
 2020-01-16 08:13:06 +00:00
nolancon
599217d482 Move test case "HintProvider returns -nil map[string][]TopologyHint from provider" into specific policy tests 2020-01-16 08:13:06 +00:00
nolancon
57661ee946 Move test case 'HintProvider returns empty non-nil map[string][]TopologyHint' into specific policy tests. 2020-01-16 08:13:06 +00:00
nolancon
51f1af0395 Move test case 'TopologyHint not set' into individual policy tests 2020-01-16 08:13:06 +00:00
nolancon
8466a5852a Restore policy_test.go to upstream 
Following commits will contain incremental changes to this file to ease
review process and ensure all tests are accounted for.
 2020-01-16 08:13:06 +00:00
nolancon
59bb6c4d6f Update checks in mergeProvidersHints: 
- Initialize best Hint to TopologyHint{}
- Update checks.
- Move generic unit test case into policy specific tests and updated
expected outcome to reflect changes.
 2020-01-16 08:13:06 +00:00
nolancon
6758f95117 Restore original policy none test cases: 
Mistakenly overwritten in earlier commit
 2020-01-16 08:13:06 +00:00
nolancon
2d1a535a35 Make mergePermutation generic: 
- Remove policy parameters to make function generic
- Move function into top level policy.go
 2020-01-16 08:13:06 +00:00
nolancon
5487941485 Refactor filterHints: 
- Restructure function
- Remove bug fix for catching {nil true} - To be fixed in later commit
- Restore unit tests to original state for testing filterHints
 2020-01-16 08:13:06 +00:00
nolancon
adfd11f38f Make iterateAllProviderTopologyHints generic: 
- Remove policy parameters to make this function generic.
- Move function out of individual policies and into policy.go
 2020-01-16 08:13:06 +00:00
nolancon
e43f0a5293 Reinstate canAdmitPodResult in policy_none: 
This is to keep consistency with the other policies.
This change may be made across all policies in a future PR, but removing it
from the scope of this PR for now.
 2020-01-16 08:13:05 +00:00
nolancon
4cc5b9e46c Edit hints returned from policies and unit tests: 
- Best Effort Policy: Return hint with nil affinity as opposed to
defaultAffinity when provider has no preference for NUMA affinty or no
possible NUMA affinities.
- Single NUMA Node Policy: Remove defaultHint from mergeProvidersHints.
Instead return appropriate TopologyHint where required.
- Update unit tests to reflect changes. Some test cases moved into
individual policy test functions due to differing returned affinties
per policy.
 2020-01-16 08:13:05 +00:00
nolancon
e3d0c9397f Updates to single-numa-node policy: 
- Remove getHintMatch method.
- Replace with simplified versions of mergePermutation and
iterateAllProviderTopologyHints methods - as used in best-effort.
- Remove getHintMatch unit tests.
 2020-01-16 08:13:05 +00:00
nolancon
b5ca4989e3 Update unit tests: 
- Update filterHints test to reflect changes in previous commit.
- Some common test cases achieve differing expected results based on
policy due to independent merge strategies. These cases are moved into
individual policy based test functions.
 2020-01-16 08:13:05 +00:00
nolancon
17d615bca2 Update filterHints: 
- Only append valid preferred-true hints to filtered
- Return true if allResourceHints only consist of
nil-affinity/preferred-true hints: {nil true}, update defaultHint
preference accordingly.
 2020-01-16 08:13:05 +00:00
Adrian Chiris
9f21f49493 Additional unit tests for Topology Manager methods 2020-01-16 08:13:05 +00:00
Adrian Chiris
f886d2a832 Update single-numa-node policy unit tests 2020-01-16 08:13:05 +00:00
Adrian Chiris
2825a7be1a Add new functionality for single-numa-node policy: 
Explanation taken from original commit:
- Change the current method of finding the best hint.
  Instead of going over all permutations, sort the hints and find
  the narrowest hint common to all resources.
- Break out early when merging to a preferred hint is not possible
 2020-01-16 08:13:05 +00:00
Adrian Chiris
5ce2ea2773 Return defaultAffinity from PolicyBestEffort: 
Now that PolicySingleNUMANode is not considered here, return
defaultAffinity as was the original case before previous bug fix
 2020-01-16 08:13:05 +00:00
Adrian Chiris
eda1521562 Make mergeProviderHints policy-specific: 
- Remove need to pass policy and numaNodes as arguments
- Remove PolicySingleNUMANode special case check in policy_best_effort
- Add mergeProviderHints base to policy_single_numa_node for upcoming
commit
 2020-01-16 08:13:05 +00:00
Adrian Chiris
dc36924c37 Update policy_none removing canAdmitPodResult 
Update unit tests for none_policy
Add Name test for policy_restricted
 2020-01-16 08:13:05 +00:00
Adrian Chiris
cf8b098dda Refactor policy-best-effort 
- Modularize code with mergePermutation method
 2020-01-16 08:13:05 +00:00
Sascha Grunert
278717bc57
Fix ineffectual assignment to CPUSets 
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
 2020-01-16 08:57:42 +01:00
Guangwen Feng
e2e5bf5e0b Fix golint warning for pkg/util/procfs/procfs_linux.go 
Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
 2020-01-16 15:16:47 +08:00
Kubernetes Prow Robot
f437ff75d4
Merge pull request #87254 from egernst/lame-typo-fix 
simple typo fix
 2020-01-15 21:21:57 -08:00
Kubernetes Prow Robot
550034022f
Merge pull request #87238 from yuzhiquan/patch-scheduler 
cleanup(scheduler): remove unused function, remove duplicate comment
 2020-01-15 21:21:46 -08:00
yuzhiquan
0e81e39465 cleanup(scheduler): remove unused function, remove duplicate comment, implement interface 
update bazel
 2020-01-16 09:07:09 +08:00
Kevin Klues
34b942a41d Remove check for empty activePods list in CPUManager removeStaleState 
This check is redundant since we protect this call with a call to
`m.sourcesReady.AllReady()` earlier on. Moreover, having this check in
place means that we will leave some stale state around in cases where
there are actually no active pods in the system and this loop hasn't
cleaned them up yet. This can happen, for example, if a pod exits while
the kubelet is down for some reason. We see this exact case being
triggered in our e2e tests, where a test has been failing since October
when this change was first introduced.
 2020-01-15 20:09:24 +01:00
Kevin Klues
5802f3a910 Add proper activePods list in TestGetTopologyHints for CPUManager 2020-01-15 20:08:41 +01:00
Eric Ernst
cdd92d39b7 preemption: typo cleanup 
Signed-off-by: Eric Ernst <eric.ernst@intel.com>
 2020-01-15 10:55:40 -08:00
Kubernetes Prow Robot
15aa065e86
Merge pull request #86569 from zouyee/btos 
using string instead of byte
 2020-01-15 08:25:49 -08:00
Kubernetes Prow Robot
97d68d014c
Merge pull request #86172 from liggitt/intstr 
Clarify intstr.IntValue() behavior
 2020-01-15 08:25:35 -08:00
Sakura
4143bc7a96
fix staticcheck errors in pkg/volume/hostpath. 
Signed-off-by: Sakura <longfei.shang@daocloud.io>
 2020-01-15 22:54:48 +08:00
ialidzhikov
a038a33dcf Clean up commented assertions in tests 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
 2020-01-15 11:34:27 +02:00
Kubernetes Prow Robot
208cc18c69
Merge pull request #86728 from mattjmcnaughton/mattjmcnaughton/add-test-coverage-oom-watcher 
Add test coverage for oom watcher
 2020-01-15 01:21:33 -08:00
Kubernetes Prow Robot
de34d2ce1e
Merge pull request #87193 from mattjmcnaughton/mattjmcnaughton/cleanup-rkt-code-in-pleg 
Clean up rkt specific code in `pkg/kubelet/pleg`
 2020-01-14 22:21:46 -08:00
Aresforchina
514bdbedac fix-static:pkg/volume/scaleio/ 2020-01-15 09:53:27 +08:00
Kubernetes Prow Robot
9173a5f93f
Merge pull request #87164 from liggitt/sar-approver-v1 
Use v1 subjectaccessreview API in controller-manager CSR approver
 2020-01-14 17:22:58 -08:00
Kubernetes Prow Robot
88cf4e5c25
Merge pull request #87091 from ahg-g/ahg-cleanup 
Remove last scheduler dependencies on predicates package
 2020-01-14 17:21:39 -08:00
Kubernetes Prow Robot
b046f742bd
Merge pull request #87038 from alculquicondor/cleanup/mv_snapshot 
Remove direct use of Snapshot's data structures
 2020-01-14 17:21:29 -08:00
mattjmcnaughton
9077603b97
Add richer unit tests for OomWatcher 
Add unit tests for OomWatcher that actually test the logic defined in
the `Start` method. As a result of an earlier refactor, its now trivial
to mock the OOMInstance events which the `oom_watcher` is supposed to be
watching.
 2020-01-14 07:57:06 -05:00
mattjmcnaughton
ab7e0f58d5
Clean up rkt specific code in pkg/kubelet/pleg 
Clean up code in PLEG which was only necessary for the `rkt` runtime.

Rkt is no longer a built-in runtime and docker(shim) uses the CRI, so
its safe to remove this code entirely.

This diff removes the last mentions of `rkt` in the kubelet.
 2020-01-14 07:42:30 -05:00
Kubernetes Prow Robot
be26fbc638
Merge pull request #86282 from RainbowMango/pr_refactor_resource_endpoint 
Refactor kubelet resource metrics
 2020-01-14 02:23:09 -08:00
Kubernetes Prow Robot
f4db8212be
Merge pull request #76496 from danielqsj/metrics-2 
Clean deprecated metrics
 2020-01-13 20:53:09 -08:00
Kubernetes Prow Robot
61d36e4a43
Merge pull request #85850 from danwinship/kubelet-ipv6-node-ip 
Allow "kubelet --node-ip ::" to mean prefer IPv6
 2020-01-13 17:41:08 -08:00
Kubernetes Prow Robot
e1cc36000f
Merge pull request #87002 from SataQiu/staticcheck-20200109 
Fix staticcheck failures of pkg/util/ipconfig pkg/util/iptables pkg/util/ipvs/testing
 2020-01-13 13:58:55 -08:00
Antonio Ojea
de15774e10 kube-proxy unit test FilterIncorrectIPVersion 
Add an unit test to the kube-proxy FilterIncorrectIPVersion function
 2020-01-13 22:44:22 +01:00
Jordan Liggitt
054e3846fc Use v1 subjectaccessreview API in controller-manager CSR approver 2020-01-13 15:55:52 -05:00
Aldo Culquicondor
187d711225 Split findNodesThatFit into framework and extenders logic 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
 2020-01-13 14:10:17 -05:00
Aldo Culquicondor
63c1c68d0c Remove direct use of Snapshot's data structures 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
 2020-01-13 14:10:17 -05:00
Abdullah Gharaibeh
fb66e807cd Remove scheduler framework dependency on predicates package 2020-01-13 13:02:31 -05:00
yuxiaobo
da15570daa fix staticcheck:pkg/volume/cinder 
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
 2020-01-13 18:20:23 +08:00
Aresforchina
e62f9625cf fix-static:pkg/volume/emptydir 2020-01-13 15:23:45 +08:00
wojtekt
9174905ae7 Autogenerated 2020-01-12 21:09:05 +01:00
wojtekt
e612ebfdff Immutable field and validation 2020-01-12 20:51:31 +01:00
Kubernetes Prow Robot
c0e245fa0e
Merge pull request #85268 from yue9944882/feat/flow-control-defaulting 
Bootstrap flow-control objects
 2020-01-11 12:27:37 -08:00
sunxiaofei03
330159c0a4 fix orphaned pod flexvolume can not be cleaned up 2020-01-11 14:54:48 +08:00
Kubernetes Prow Robot
ace98e1382
Merge pull request #84433 from yamt/comment-typo 
Fix a comment typo in legacyNodeRoleBehaviorFeature
 2020-01-10 17:17:38 -08:00
Kubernetes Prow Robot
8467561f2c
Merge pull request #86783 from mattjmcnaughton/mattjmcnaughton/remove-unnecessary-modification-container-pid-namespace 
Remove no longer needed `modifyContainerPIDNamespaceOverrides`
 2020-01-10 15:43:50 -08:00
Kubernetes Prow Robot
befc371364
Merge pull request #86702 from mattjmcnaughton/mattjmcnaughton/refactor-oom-watcher-to-allow-greater-test-coverage 
Refactor oom watcher to allow greater test coverage
 2020-01-10 15:43:37 -08:00
Kubernetes Prow Robot
240782c7f7
Merge pull request #87043 from zjs/topic/propagate-providerid-errors 
Ensure a provider ID is set on a node if expected
 2020-01-10 14:33:50 -08:00
Kubernetes Prow Robot
dc2099ea11
Merge pull request #87055 from denkensk/clean-unused-predicate-error 
Cleanup unused predicate error types.
 2020-01-10 12:25:16 -08:00
Kubernetes Prow Robot
942b526e5c
Merge pull request #87051 from Huang-Wei/remove-prio-util-pkg 
Remove scheduler/algorithm/priorities/util package
 2020-01-10 12:25:01 -08:00
Kubernetes Prow Robot
6e2a2855ef
Merge pull request #87034 from ritazh/azure-owners 
Update Azure owners
 2020-01-10 12:24:49 -08:00
Zach Shepherd
2b554079af
Ensure a provider ID is set on a node if expected 
A transient issue might occur that causes an error to be returned by
InstanceID(). When this is ignored, the external cloud provider taint
will be removed and neither AddCloudNode() nor UpdateCloudNode() will
try to set a provider ID in the future.

By returning the error we can ensure that the external cloud provider
taint is not removed prematurely, allowing the operation to be retried
(until the provider ID can be set).

Preserve support for external cloud providers that do not use IDs by
continuing if a NotImplemented error is returned, making a distinction
between lack of support for provider IDs and an actual error.

Introduce pair of unit tests that show a provider ID will eventually
be set if an error is returned, unless that error is a NotImplemented,
in which case the external cloud provider taint will be removed.
 2020-01-10 11:00:54 -08:00
yue9944882
70dea6e4a8 review: several fixes and addressing comments 2020-01-11 01:46:31 +08:00
Kubernetes Prow Robot
a66adcb4f1
Merge pull request #87050 from KobayashiD27/fixgolint 
fix golint error in pkg/apis/rbac
 2020-01-10 08:58:48 -08:00
Kubernetes Prow Robot
a5a48d0bf3
Merge pull request #87037 from Huang-Wei/remove-util-pkg 
Cleanup scheduler/algorithm/predicates package
 2020-01-10 08:58:35 -08:00
Kubernetes Prow Robot
3341611480
Merge pull request #87001 from chendotjs/ipvs-typofix 
fix typo in ipvs proxier README
 2020-01-10 06:24:34 -08:00
yuxiaobo
c5764735e2 fix staticcheck:pkg/volume/awsebs 
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
 2020-01-10 18:36:39 +08:00
danielqsj
ab182552b4 clean SinceInMicroseconds, convert to SinceInSeconds 2020-01-10 17:05:38 +08:00
danielqsj
a8f2feaeb5 remove deprecated metrics of proxy 2020-01-10 17:05:38 +08:00
danielqsj
8ae3f80048 remove deprecated metrics of dockershim 2020-01-10 17:05:38 +08:00
danielqsj
85931af1ee remove deprecated metrics of scheduler 2020-01-10 17:03:40 +08:00
danielqsj
1a9b121764 remove deprecated metrics of kubelet 2020-01-10 16:46:52 +08:00
Kubernetes Prow Robot
9269b5d430
Merge pull request #87014 from notpad/fix/comments 
Fix comment
 2020-01-09 21:58:55 -08:00
Alex Wang
0bab010b45 clean unused predicate error 2020-01-10 13:06:29 +08:00
Wei Huang
b2159b5d66
Remove scheduler/algorithm/priorities/util package 2020-01-09 20:16:05 -08:00
Kubernetes Prow Robot
7a50fdb2a6
Merge pull request #85993 from chendotjs/fix-cidr 
kubenet: replace gateway with cni result
 2020-01-09 20:13:04 -08:00
Wei Huang
6aaf0bb41b
Cleanup scheduler/algorithm/predicates package 2020-01-09 19:01:31 -08:00
Rita Zhang
b062fcb117
Update Azure owners 2020-01-09 18:35:18 -08:00
Kobayashi Daisuke
fee0d43d23 fix golint error in pkg/apis/rbac 2020-01-10 11:22:05 +09:00
draveness
2c3c6721ce refactor(scheduling): remove priorities package 2020-01-10 09:05:39 +08:00
Kubernetes Prow Robot
adb8b08e91
Merge pull request #86905 from draveness/feature/disable-scheduling-plugin 
feat(scheduling): address disabled plugins in scheduling framework
 2020-01-09 16:10:47 -08:00
Kubernetes Prow Robot
e648e944e0
Merge pull request #86848 from haosdent/clean-filter-deps-nodeunschedulable 
Break nodeunschedulable Filter plugins dependency on predicates package
 2020-01-09 16:10:34 -08:00
Kubernetes Prow Robot
aef336d712
Merge pull request #86999 from draveness/feature/remove-ErrTopologySpreadConstraintsNotMatch 
fix: remove ErrTopologySpreadConstraintsNotMatch
 2020-01-09 13:29:42 -08:00
Kubernetes Prow Robot
95c9878b78
Merge pull request #86964 from alculquicondor/fix/snapshot_rm_node 
Remove nodes from cache immediately on delete events
 2020-01-09 13:29:32 -08:00
Kubernetes Prow Robot
f634ee6fe2
Merge pull request #86545 from xiaoanyunfei/cleanup/enhance_scheduler_metrics 
Cleanup/Enhance scheduler metrics
 2020-01-09 13:29:22 -08:00
Kubernetes Prow Robot
3ccdad175a
Merge pull request #86210 from draveness/feature/remove-ga-flags 
feat: remove several feature gates in 1.18
 2020-01-09 13:28:50 -08:00
Kubernetes Prow Robot
eedf1945b5
Merge pull request #86998 from denkensk/rm-errserviceaffinityviolated 
Remove ErrServiceAffinityViolated scheduler predicate error
 2020-01-09 11:33:42 -08:00
Kubernetes Prow Robot
407b29fa05
Merge pull request #86981 from alculquicondor/fix/node_info_list_2 
Remove uses of NodeInfoMap outside of snapshot and cache
 2020-01-09 11:33:31 -08:00
Aldo Culquicondor
afe3b907a1 Remove nodes from cache immediately on delete events 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
 2020-01-09 12:58:12 -05:00
draveness
50deec25bc feat(scheduling): address disabled plugins in scheduling framework 
+ Custom plugins run after the default plugins.
+ Disable default plugins and re-enable them in the configuration could update
  the execution order.
+ Use `*` to disable all the default plugins of specific extension points.
 2020-01-09 23:59:59 +08:00
Aldo Culquicondor
bcab9b4c9e Remove uses of NodeInfoMap outside of snapshot and cache 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
 2020-01-09 10:04:11 -05:00
Kubernetes Prow Robot
32d8799ef1
Merge pull request #86979 from ahg-g/ahg-cleanup2 
Move TaintToleration predicate to its plugin
 2020-01-09 06:53:45 -08:00
Abdullah Gharaibeh
50b697bacb move TaintToleration predicate to its plugin 2020-01-09 08:14:53 -05:00
notpad
228891de9c Fix comment 2020-01-09 20:06:56 +08:00
Kubernetes Prow Robot
edad4bbfc8
Merge pull request #86940 from skilxn-go/master 
Add VolumeBinder to FrameworkHandle interface
 2020-01-09 03:01:45 -08:00
SataQiu
51c742c1dd fix staticcheck failures of pkg/util/ipconfig pkg/util/iptables pkg/util/ipvs/testing 2020-01-09 16:05:11 +08:00
draveness
0278d793c8 fix: remove ErrTopologySpreadConstraintsNotMatch 2020-01-09 16:01:13 +08:00
chenyaqi01
f893486191 ipvs proxier README: fix typo 2020-01-09 15:12:05 +08:00
Alex Wang
80127fe10f rm errserviceaffinityviolated 2020-01-09 15:08:59 +08:00
Haosdent Huang
864600f05f Break nodeunschedulable Filter plugins dependency on predicates package 2020-01-09 14:54:28 +08:00
Kubernetes Prow Robot
2c800c5a70
Merge pull request #86985 from ahg-g/ahg-cleanup4 
Remove test/integration dependency on predicates and algorithmprovider
 2020-01-08 21:29:58 -08:00
Kubernetes Prow Robot
4d41f4809f
Merge pull request #86890 from damemi/move-selector-spread-to-plugin 
Move selector spreading priority code to plugin
 2020-01-08 21:29:45 -08:00
sunxiaofei03
6c58cc0ad0 change framework_extension_point_duration_seconds from sampling to always record 2020-01-09 12:23:05 +08:00
Kubernetes Prow Robot
b3c94d3fb9
Merge pull request #86966 from bharaththiruveedula/master 
Fix interpodaffinity issue
 2020-01-08 19:12:20 -08:00
Kubernetes Prow Robot
4426ccb2a6
Merge pull request #86963 from ahg-g/ahg-status 
Update scheduler's RunFilterPlugins to return a plugin to status map
 2020-01-08 19:12:12 -08:00
Kubernetes Prow Robot
4d95d40a41
Merge pull request #86836 from haosdent/clean-filter-deps-interpodaffinity 
Break interpodaffinity Filter plugins dependency on predicates package
 2020-01-08 19:11:53 -08:00
skilxn-go
5def91d778 Add VolumeBinder to FrameworkHandle interface 2020-01-09 10:29:35 +08:00
Abdullah Gharaibeh
c86f59610c remove test/integration dependency on predicates and algorithmprovider 2020-01-08 19:51:22 -05:00
Kubernetes Prow Robot
720e6de6b9
Merge pull request #85168 from Jefftree/admission-wh-proxy 
Use Network Proxy for Admission Webhooks
 2020-01-08 16:07:40 -08:00
Jefftree
1289bdaba4 network proxy with admission wh 2020-01-08 15:01:38 -08:00
Kubernetes Prow Robot
b558cff8f5
Merge pull request #86950 from yuzhiquan/patch-pod 
cleanup(api-machinery): remove unused struct and variable
 2020-01-08 14:46:48 -08:00
Kubernetes Prow Robot
792fe793a1
Merge pull request #86946 from cchord/fix_typo 
fix typo
 2020-01-08 14:46:24 -08:00
Kubernetes Prow Robot
ca05f4c63b
Merge pull request #86930 from alculquicondor/fix/node_info_list 
Use Snapshot.NodeInfoList for listing operations
 2020-01-08 14:46:03 -08:00
Abdullah Gharaibeh
f3c7a4c823 Update scheduler's RunFilterPlugins to return a plugin to status map 2020-01-08 16:44:51 -05:00
Bharath Thiruveedula
8e3c1b54a7 Fix interpodaffinity issue 
Signed-off-by: Bharath Thiruveedula <bharath_ves@hotmail.com>
 2020-01-09 01:18:49 +05:30
Mike Dame
d227b7822f Move selector spreading priority code to plugin 2020-01-08 13:37:37 -05:00
Kubernetes Prow Robot
b34c96b62c
Merge pull request #86764 from haosdent/migrate-servie-affinity 
Break serviceaffinity Filter plugins dependency on predicates package
 2020-01-08 08:47:39 -08:00
Aldo Culquicondor
5d916e20dd Use Snapshot.NodeInfoList for listing operations 
instead of iterating over NodeInfoMap.

Also remove redundant queries to NodeInfoMap.

Signed-off-by: Aldo Culquicondor <acondor@google.com>
 2020-01-08 09:45:36 -05:00
Kubernetes Prow Robot
1e0bfae887
Merge pull request #86871 from gosoon/master 
fix log message error in nodelifecycle
 2020-01-08 02:58:33 -08:00
Kubernetes Prow Robot
1f50be5d04
Merge pull request #86775 from Aresforchina/fix-staticcheck-test03 
fix staticcheck of pkg/util/ebtables
 2020-01-08 02:58:07 -08:00
Kubernetes Prow Robot
b1e8bed5be
Merge pull request #86755 from mwmix/scheduler_server_unit_tests 
Adding in missing Registry unit tests.
 2020-01-08 02:57:54 -08:00
Kubernetes Prow Robot
fd0358fd21
Merge pull request #86689 from klueska/upstream-fix-cpumanager-v1-state-checksum 
Lock checksum calculation for v1 CPUManager state to pre 1.18 logic
 2020-01-08 02:57:40 -08:00
likakuli
10864d3366 fix a bug that orphan revision cannot be adopted and sts cannot be synced 2020-01-08 17:56:41 +08:00
yuzhiquan
8d7f383785 cleanup(api-machinery): remove unused struct and variable 2020-01-08 16:57:02 +08:00
Jiahao Zhu
680df17f39 fix typo 2020-01-08 15:48:58 +08:00
Haosdent Huang
a1053e4835 Break interpodaffinity Filter plugins dependency on predicates package 2020-01-08 14:37:51 +08:00
Kubernetes Prow Robot
8dca390262
Merge pull request #84927 from mattjmcnaughton/mattjmcnaughton/fix-kubelet-config-common 
Fix golint failures for pkg/kubelet/config/...
 2020-01-07 21:09:40 -08:00
mattjmcnaughton
8897c435ad
Refactor oom watcher to allow greater test coverage 
This diff contains a strict refactor; there are no behavioral changes.

Address a long standing TODO in `oom_watcher_linux_test.go` around test
coverage. We refactor our `oom.Watcher` so it takes in a struct
fulfulling the `streamer` interface (i.e. defines `StreamOoms` method).
In production, we will continue to use the `oomparser` from `cadvisor`.
However, for testing purposes, we can now create our own `fakeStreamer`,
and control how it streams `oomparser.OomInstance`. With this fake, we
can implement richer unit testing for the `oom.Watcher` itself.

Actually adding the additional unit tests will come in a later commit.
 2020-01-07 21:48:14 -05:00
Kubernetes Prow Robot
6099a739d8
Merge pull request #86919 from ahg-g/ahg-fix 
Fix how we check for node info list consistency
 2020-01-07 14:09:05 -08:00
Kubernetes Prow Robot
99600ae9a7
Merge pull request #86852 from haosdent/clean-filter-deps-volumezone 
Break volumezone Filter plugins dependency on predicates package
 2020-01-07 14:08:55 -08:00
Kubernetes Prow Robot
c867fdbc1c
Merge pull request #86847 from haosdent/clean-filter-deps-nodelabel 
Break nodelabel Filter plugins dependency on predicates package
 2020-01-07 14:08:46 -08:00
Christopher M. Luciano
bff24f41bf
core: fix dead links in core api comments 
Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
 2020-01-07 16:32:05 -05:00
Kubernetes Prow Robot
c7af1da206
Merge pull request #86913 from ahg-g/ahg-nodelimit 
fix a bug in scheduler's node resource limits score
 2020-01-07 12:34:25 -08:00
Abdullah Gharaibeh
e26fbe6f08 fix a bug in scheduler's node resource limits score 2020-01-07 13:43:44 -05:00
Kubernetes Prow Robot
d4d3d4b55e
Merge pull request #86875 from ahg-g/ahg1-cleanup 
Move RequestedToCapacityRatio argument processing to its plugin
 2020-01-07 10:14:42 -08:00
Kubernetes Prow Robot
dc084fe131
Merge pull request #86849 from haosdent/clean-filter-deps-nodevolumelimits 
Break nodevolumelimits Filter plugins dependency on predicates package
 2020-01-07 10:14:33 -08:00
Haosdent Huang
320c9bfeed Break volumezone Filter plugins dependency on predicates package 2020-01-08 01:03:01 +08:00
Abdullah Gharaibeh
591b870691 fix how we check for node info list consistency 2020-01-07 11:45:25 -05:00
Kubernetes Prow Robot
49e24adf3e
Merge pull request #86832 from mattjmcnaughton/mattjmcnaughton/remove-dead-code-in-fake-docker-client 
Remove dead code in fake docker client
 2020-01-07 07:36:18 -08:00
Matt Mix
42afa0a2cc Adding in missing Registry unit tests. 2020-01-07 10:20:39 -05:00
Haosdent Huang
6a82609902 Break serviceaffinity Filter plugins dependency on predicates package 2020-01-07 22:43:37 +08:00
Dan Winship
ce68edf700 Allow "kubelet --node-ip ::" to mean prefer IPv6 2020-01-07 07:53:21 -05:00
Kubernetes Prow Robot
f3df7a2fdb
Merge pull request #86727 from mattjmcnaughton/mattjmcnaughton/remove-recorder-PastEventf 
Remove `recorder.PastEventf` method
 2020-01-07 04:38:49 -08:00
Kubernetes Prow Robot
5373fa3f59
Merge pull request #82462 from vllry/dualstack-iptables 
Dualstack support for kube-proxy iptables mode
 2020-01-07 04:38:20 -08:00
Kubernetes Prow Robot
dd5272b76f
Merge pull request #86575 from gongguan/nkubemark 
kubemark use remote cri
 2020-01-07 03:20:46 -08:00
Kubernetes Prow Robot
38173d586a
Merge pull request #86877 from ahg-g/ahg1-cleanup2 
Remove unused scheduler types
 2020-01-07 01:13:33 -08:00
Kubernetes Prow Robot
08ae3b490a
Merge pull request #86859 from silenceshell/ExtenderConfig-rename-Extender 
rename ExtenderConfig to Extender in comments
 2020-01-07 01:13:24 -08:00
Kubernetes Prow Robot
195e8e3ad9
Merge pull request #86844 from mattjmcnaughton/mattjmcnaughton/update-cadvisor-stats-provider-comment 
Correct comment around which integrations require cadvisor_stats
 2020-01-07 01:13:14 -08:00
Haosdent Huang
4ef31f81c7 Break nodelabel Filter plugins dependency on predicates package 2020-01-07 16:37:52 +08:00
Kubernetes Prow Robot
8b8f2aa4a5
Merge pull request #85431 from irbull/api-doc 
Add public documentation for kubelet/apis/config
 2020-01-06 23:12:18 -08:00
louisgong
8d54a84507 fix kubemark use fake CRI 2020-01-07 11:39:58 +08:00
louisgong
324e5ce7e3 hollow-node use remote CRI 2020-01-07 11:00:45 +08:00
Abdullah Gharaibeh
729c37373a Remove unused scheduler types 2020-01-06 21:19:42 -05:00
Kubernetes Prow Robot
59b4933fb8
Merge pull request #86724 from gongguan/fix-fake-CRI 
fix fake remote CRI
 2020-01-06 18:06:57 -08:00
Kubernetes Prow Robot
e7c79050b4
Merge pull request #86718 from ahg-g/ahg1-err 
Copy nodeaffinity predicate to its filter plugin
 2020-01-06 18:06:46 -08:00
Kubernetes Prow Robot
49bc696614
Merge pull request #86251 from bboreham/pleg-last-seen-metric 
Kubelet: add a metric to observe time since PLEG last seen
 2020-01-06 18:06:18 -08:00
Kubernetes Prow Robot
d6412b856f
Merge pull request #84345 from danielqsj/withdialer 
replace grpc.WithDialer which is deprecated
 2020-01-06 15:56:17 -08:00
Kubernetes Prow Robot
19ecd690fa
Merge pull request #86646 from yutedz/client-protocol 
Require client / server protocols
 2020-01-06 13:34:18 -08:00
Kubernetes Prow Robot
b112ad4f0b
Merge pull request #86845 from mattjmcnaughton/mattjmcnaughton/remove-rkt-from-runtime-options 
Remove `rkt` from container runtime options
 2020-01-06 11:12:29 -08:00
Abdullah Gharaibeh
4e67476867 move nodeaffinity predicate to its filter plugin 2020-01-06 13:22:51 -05:00
Kubernetes Prow Robot
9acf7d11fe
Merge pull request #86344 from klueska/upstream-cm-approver 
Add klueska as an approver in pkg/kubelet/cm/OWNERS
 2020-01-06 09:54:16 -08:00
Abdullah Gharaibeh
b9e2389e0d Move RequestedToCapacityRatio argument processing to its plugin 2020-01-06 11:54:09 -05:00
Ted Yu
906adbdfcd Require client / server protocols 2020-01-06 08:50:04 -08:00
tianfeiyu
fddf50cf88
fix log message error in nodelifecycle 2020-01-06 21:02:08 +08:00
yue9944882
fe8ad90afa bootstrap flow-control objects 
typo

wrap bootstrap-creation-flow w/ wait.PollUtil

go wait
 2020-01-06 20:35:03 +08:00
Kubernetes Prow Robot
0f61791bc7
Merge pull request #86850 from haosdent/clean-filter-deps-volumerestrictions 
Break volumerestrictions Filter plugins dependency on predicates package
 2020-01-05 20:57:41 -08:00
silenceshell
7254517c5c rename ExtenderConfig to Extender 2020-01-06 11:18:51 +08:00
Kubernetes Prow Robot
10dc4a0c79
Merge pull request #86822 from ahg-g/ahg-cleanup 
Cleanup deprecated scheduler functions/files
 2020-01-05 12:37:41 -08:00
Haosdent Huang
9bcca31e52 Break volumerestrictions Filter plugins dependency on predicates package 2020-01-06 02:59:47 +08:00
Haosdent Huang
aae9a7f704 Break nodevolumelimits Filter plugins dependency on predicates package 2020-01-06 02:30:40 +08:00
mattjmcnaughton
794d0d9b4d
Remove rkt from container runtime options 
Part of efforts to clean up mentions of rkt in kubelet.

rkt was removed entirely in 1.11, in favor of using `rktlet` and CRI
instead. It should no longer be listed at all as a runtime.
 2020-01-05 09:27:38 -05:00
Kubernetes Prow Robot
862c8bf818
Merge pull request #85561 from cwdsuzhou/Nov/return_when_failed 
Return when removePod failed
 2020-01-05 06:23:40 -08:00
mattjmcnaughton
06b44c76fd
Correct comment around which integrations require cadvisor_stats 
This commit is part of a larger effort to clean up references to `rkt`
in the kubelet.

Previously, this comment hard-coded which integrations required
the cadvisor stats provider. The comment has grown stale
(i.e. referenced rkt and did not reference cri-o).

Update the comment to instead point to the code which determines which
integrations need the cadvisor stats provider.
 2020-01-05 09:23:09 -05:00
mattjmcnaughton
f2cb1f35fe
Remove dead code in fake docker client 
The `FakeDockerClient` had a number of methods defined on it which were
not being called anywhere. The majority were of the form `Assert...`.

In the spirit of removing dead code, remove the methods which aren't
being called.
 2020-01-05 08:31:59 -05:00
Kubernetes Prow Robot
2d56d75061
Merge pull request #86730 from ahg-g/ahg1-ds 
Break DS controller dependency on scheduler predicates and predicate errors
 2020-01-04 14:39:40 -08:00
Kubernetes Prow Robot
fd98df37b5
Merge pull request #86742 from haosdent/clean-filter-deps 
Break volumebinding Filter plugins dependency on predicates package
 2020-01-04 12:21:40 -08:00
Haosdent Huang
d27dc6751e Break volumebinding Filter plugins dependency on predicates package 2020-01-05 01:37:22 +08:00
Abdullah Gharaibeh
041e5b5560 addressed comments 2020-01-04 01:14:24 -05:00
Kubernetes Prow Robot
135ddf1ccc
Merge pull request #86820 from Huang-Wei/cleanup-SetPredicatesOrdering 
Cleanup SetPredicatesOrderingDuringTest due to deprecation of predicates
 2020-01-03 16:59:41 -08:00
louisgong
e8eb5c656b fix fake remote CRI 2020-01-04 08:43:17 +08:00
Abdullah Gharaibeh
d31dcecd20 cleanup unused scheduler functions/files 2020-01-03 19:09:14 -05:00
Wei Huang
051be8fe80
Cleanup SetPredicatesOrderingDuringTest due to deprecation of predicates 2020-01-03 11:57:17 -08:00
Wei Huang
64d7b224d9
Cleanup unused parameter of NewGenericScheduler 2020-01-03 11:42:39 -08:00
Abdullah Gharaibeh
7d604c318c Break DS controller on scheduler predicates and predicate errors 2020-01-03 13:05:07 -05:00
Kubernetes Prow Robot
180e1c9f51
Merge pull request #86584 from xiaoanyunfei/cleanup/deprecate_scheduler_metrics 
deprecate scheduling_algorithm_predicate_evaluation_seconds and sched…
 2020-01-03 03:41:40 -08:00
Bryan Boreham
cc0b3e82eb Kubelet: add a metric to observe time since PLEG last seen 
Expose the measurement that kubelet uses to judge that "PLEG is
unhealthy". If we can observe the measurement growing then we can
alert before the node goes unhealthy.

Note that the existing metrics PLEGRelistInterval and
PLEGRelistDuration are poor for this, because when relist() gets
stuck they are never updated.

Signed-off-by: Bryan Boreham <bryan@weave.works>
 2020-01-03 10:01:27 +00:00
Kubernetes Prow Robot
47d5c3ef8d
Merge pull request #86785 from cwdsuzhou/Jan/update_comments 
update comments of some funs in scheduling_queue
 2020-01-02 22:26:02 -08:00
Kubernetes Prow Robot
b3c4c90a72
Merge pull request #86673 from ahg-g/ahg1-provider 
Define algorithm providers in terms of plugins
 2020-01-02 22:25:53 -08:00
Kubernetes Prow Robot
30090d0809
Merge pull request #86665 from SataQiu/clean-proxy-20191227 
kube-proxy: add some interface type assertions
 2020-01-02 22:25:40 -08:00
Kubernetes Prow Robot
fdfcb00ede
Merge pull request #86586 from xiaoanyunfei/cleanup/deprecate_scheduler_duration_seconds 
Deprecate scheduling_duration_seconds Summary metric
 2020-01-02 19:15:55 -08:00
SataQiu
2a83443782 add error handler of unix.Setrlimit 2020-01-03 10:49:06 +08:00
Abdullah Gharaibeh
b535ed3b0c Merge scheduler's ConfigProducerRegistry into LegacyRegistry 2020-01-02 16:40:33 -05:00
caiweidong
02e217759e update comments of some funs in scheduling_queue 2020-01-02 23:35:12 +08:00
mattjmcnaughton
d09fe8e247
Remove no longer needed modifyContainerPIDNamespaceOverrides 
As of https://github.com/kubernetes/kubernetes/pull/72831/, the minimum
kubernetes version is now 1.13.1. As a result, this function becomes a
no-op. As the TODO indicates, we should delete it.
 2020-01-02 09:09:02 -05:00
Aresforchina
bfc4a7a1c5 fix staticcheck of pkg/util/ebtables 2020-01-02 18:16:50 +08:00
Kubernetes Prow Robot
26b52e84a4
Merge pull request #86230 from hex108/skip_schedule 
Scheduler handles pod annotation updates during scheduling more gracefully
 2019-12-31 17:03:40 -08:00
Abdullah Gharaibeh
a6b7b0d95e Define algorithm providers in terms of plugins. 2019-12-31 15:28:09 -05:00
notpad
7f79516705 Move resource-based priority functions to their Score plugins 2019-12-31 23:50:11 +08:00
Jun Gong
706e90a033 Skip scheduling the pod if it has been assumed and the pod updates could be skipped. 2019-12-31 14:21:41 +08:00
caiweidong
6410ac3173 Return when removePod failed 2019-12-31 10:11:12 +08:00
mattjmcnaughton
92940fa80d
Remove recorder.PastEventf method 
The `recorder.PastEventf` method wasn't actually working as advertised.
It was supposed to accept a timestamp, which would be used when
generating the event. However, as the
[source code](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/tools/record/event.go#L316)
shows, this `timestamp` was never actually used.

In other words, `PastEventf` is identical to `Eventf`.

We have two options: one would be to fix `PastEventf` so that it works
as advertised. The other would be to delete `PastEventf` and only
support `Eventf`.

Ultimately, I could only find one use of `PastEventf` in the code base,
so I propose we just delete `PastEventf` and convert all uses to
`Eventf`.
 2019-12-30 12:00:23 -05:00
Kubernetes Prow Robot
a443014dfc
Merge pull request #86621 from yuzhiquan/patch-pod 
refactor (pod log) container valiate
 2019-12-30 02:41:39 -08:00
yuzhiquan
ca69051475 refactor(pod log):refactor for container valiate, little cleanup 
bug(pod log):TestCheckLogLocation should point out pod name

modify container if statement

fix typo
 2019-12-30 16:16:45 +08:00
Kubernetes Prow Robot
6d53021196
Merge pull request #86511 from aojea/v6example 
Add ipv6 examples for network policy API
 2019-12-29 19:39:39 -08:00
Wei Huang
78352240f6
Move podtopologyspread priority logic to its Score plugin 2019-12-28 19:29:37 -08:00
Kevin Klues
b373121a14 Make CPUManagerCheckpointV2 type an alias of CPUManagerCheckpoint 
This change is to prevent problems when we remove the V1->V2 migration
code in the future. Without this, the checksums of all checkpoints would
be hashed with the name CPUManagerCheckpointV2 embedded inside of them,
which is undesirable. We want the checkpoints to be hashed with the name
CPUManagerCheckpoint instead.
 2019-12-28 19:29:13 +01:00
Kubernetes Prow Robot
f796b750c6
Merge pull request #86681 from Huang-Wei/interpodaffinity-typo 
Fix a typo in interpodaffinity score plugin
 2019-12-28 08:23:38 -08:00
Kevin Klues
5faf8f4c52 Lock checksum calculation for v1 CPUManager state to pre 1.18 logic 
The updated CPUManager from PR #84462 implements logic to migrate the
CPUManager checkpoint file from an old format to a new one. To do so, it
defines the following types:

```
type CPUManagerCheckpoint = CPUManagerCheckpointV2
type CPUManagerCheckpointV1 struct {  ...  }
type CPUManagerCheckpointV2 struct {  ...  }
```

This replaces the old definition of just:

```
type CPUManagerCheckpoint struct {  ...  }
```

Code was put in place to ensure proper migration from checkpoints in V1
format to checkpoints in V2 format. However (and this is a big however),
all of the unit tests were performed on V1 checkpoints that were
generated using the type name `CPUManagerCheckpointV1` and not the
original type name of `CPUManagerCheckpoint`. As such, the checksum in
the checkpoint file uses the `CPUManagerCheckpointV1` type to calculate
its checksum and not the original type name of `CPUManagerCheckpoint`.

This causes problems in the real world since all pre-1.18 checkpoint
files will have been generated with the original type name of
`CPUManagerCheckpoint`. When verifying the checksum of the checkpoint
file across an upgrade to 1.18, the checksum is calculated assuming
a type name of `CPUManagerCheckpointV1` (which is incorrect) and the
file is seen to be corrupt.

This patch ensures that all V1 checksums are verified against a type
name of `CPUManagerCheckpoint` instead of ``CPUManagerCheckpointV1`.
It also locks the algorithm used to calculate the checksum in place,
since it wil never change in the future (for pre-1.18 checkpoint
files at least).
 2019-12-28 14:17:55 +01:00
Kubernetes Prow Robot
d605766c89
Merge pull request #86662 from draveness/feature/cloud-specific-predicates 
feat(scheduling): implement azure, cinder, ebs and gce as filter plugin
 2019-12-27 22:23:38 -08:00
Wei Huang
b3bebddb30
Fix a typo in interpodaffinity score plugin 2019-12-27 20:23:28 -08:00
Kubernetes Prow Robot
8bf6504661
Merge pull request #86583 from libnux/change_random_fully_log_level 
Change log level to 3 when --random-fully is not supported
 2019-12-27 19:47:39 -08:00
draveness
320ac4e277 feat(scheduling): implement azure, cinder, ebs and gce as filter plugin 2019-12-28 11:46:40 +08:00
Kubernetes Prow Robot
f1cbbda291
Merge pull request #86650 from RainbowMango/pr_testapi_cleanup 
Cleanup testapi after it has been removed
 2019-12-27 14:05:38 -08:00
Antonio Ojea
31e59fd5e3
Add ipv6 examples for network policy API 
Add IPv6 examples to the network policy API
 2019-12-27 22:47:20 +01:00
Kubernetes Prow Robot
0387ee4244
Merge pull request #86625 from zouyee/cnu 
Move CheckNodeUnschedulable predicate to its filter plugin
 2019-12-27 09:27:39 -08:00
Kubernetes Prow Robot
429ad7db4f
Merge pull request #86659 from Huang-Wei/eps-move-pred 
Move pod topology spread predicate logic to its filter plugin
 2019-12-27 07:53:38 -08:00
Kubernetes Prow Robot
b52cdca17d
Merge pull request #86638 from danielqsj/ServiceAntiAffinityPriority 
Move ServiceAntiAffinityPriority to score plugin
 2019-12-27 04:05:38 -08:00
SataQiu
134c545b96 proxy: add some interface type assertions 2019-12-27 18:30:25 +08:00
Wei Huang
8a4dce5431
Move pod topology spread predicate logic to its filter plugin 2019-12-26 23:56:03 -08:00
Kubernetes Prow Robot
9d31c9387c
Merge pull request #86635 from draveness/feature/move-volume-limits-predicates 
feat(scheduling): move csi volume predicates to csi filter plugin
 2019-12-26 22:27:51 -08:00
RainbowMango
eea91c018b Cleanup testapi after it has been removed 2019-12-27 14:11:15 +08:00
danielqsj
f53c81f4a2 Move ServiceAntiAffinityPriority to score plugin 2019-12-27 10:02:13 +08:00
Kubernetes Prow Robot
d4ba10ec80
Merge pull request #85703 from robscott/endpointslice-controller-race-fix 
Fixing Potential Race Condition in EndpointSlice Controller.
 2019-12-26 17:59:52 -08:00
Kubernetes Prow Robot
4158e7c1de
Merge pull request #85123 from danielqsj/apierrs 
Unify aliases for "k8s.io/apimachinery/pkg/api/errors"
 2019-12-26 17:59:38 -08:00
draveness
291a7bb164 feat(scheduling): move csi volume predicates to csi filter plugin 2019-12-27 09:14:35 +08:00
Kubernetes Prow Robot
40320be679
Merge pull request #86612 from andyzhangx/azuredisk-excludepath 
fix: azure disk could not mounted on Standard_DC4s/DC2s instances
 2019-12-26 13:43:51 -08:00
Rob Scott
c75787bb77
Fixing Potential Race Condition in EndpointSlice Controller. 
This adds a new EndpointSlice tracker to keep track of the expected resource versions of EndpointSlices associated with each Service managed by the EndpointSlice controller. This should prevent a potential race where a syncService call could happen with an incomplete view of EndpointSlices if additions or deletions hadn't fully propagated to the cache yet. Additionally, this ensures that external changes to EndpointSlices will be handled by the EndpointSlice controller.
 2019-12-26 12:15:38 -08:00
zouyee
89867e1c21 Move CheckNodeUnschedulable predicate to its filter plugin 
Signed-off-by: Zou Nengren <zouyee1989@gmail.com>
 2019-12-26 21:38:27 +08:00
zouyee
c4331b0369 Move VolumeZone predicate to its Filter plugin 
Signed-off-by: Zou Nengren <zouyee1989@gmail.com>
 2019-12-26 21:36:11 +08:00
Kubernetes Prow Robot
04d71d8a7b
Merge pull request #86614 from ahg-g/ahg1-default2 
Deprecate scheduler predicate and priority factory registration and associated types
 2019-12-26 05:21:38 -08:00
danielqsj
19fe9f8d94 replace grpc.WithDialer which is deprecated 2019-12-26 17:46:59 +08:00
danielqsj
5bc0e26c19 unify alias of api errors under pkg and staging 2019-12-26 16:42:28 +08:00
Kubernetes Prow Robot
f13e2ed491
Merge pull request #86591 from ahg-g/ahg1-default 
Added scheduler algorithm provider registrey.
 2019-12-25 18:25:38 -08:00
Abdullah Gharaibeh
2b3df3587e Deprecate scheduler predicate and priority factory registration 2019-12-25 20:33:08 -05:00
Kubernetes Prow Robot
c84b1a8a10
Merge pull request #86601 from angao/no-disk-conflict 
move NoDiskConflict predicate to its filter plugin
 2019-12-25 15:27:38 -08:00
Kubernetes Prow Robot
bd1195c28e
Merge pull request #86580 from zouyee/rlp 
Move ResourceLimitsPriority to its Score plugin
 2019-12-25 07:39:38 -08:00
andyzhangx
36393390f4 fix: azure disk could not mounted on Standard_DC4s/DC2s instances 2019-12-25 13:55:58 +00:00
Alex Wang
e5168cc7bb move nodepreferavoidpods to score plugin 2019-12-25 17:26:58 +08:00
zouyee
bf2b709e82 Move ResourceLimitsPriority to its Score plugin 
Signed-off-by: Zou Nengren <zouyee1989@gmail.com>
 2019-12-25 16:41:40 +08:00
Kubernetes Prow Robot
26253903b5
Merge pull request #86595 from draveness/feature/move-node-affinity-to-score-plugin 
feat: implement node affinity priority as score plugin
 2019-12-25 00:01:43 -08:00