Commit Graph

110 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
d6412b856f Merge pull request #84345 from danielqsj/withdialer
replace grpc.WithDialer which is deprecated
2020-01-06 15:56:17 -08:00
SataQiu
17b0b77026 fix staticcheck failures of test/integration/client test/integration/disruption 2020-01-03 17:23:35 +08:00
Aresforchina
bf47d14c27 Fix staticcheck failures of test/integration/replicationcontroller 2019-12-31 17:16:01 +08:00
Kubernetes Prow Robot
d0c719dbd9 Merge pull request #86716 from SataQiu/staticcheck-20191230
Fix staticcheck failures of test/integration/scale test/integration/serviceaccount test/integration/serving test/integration/volume
2019-12-30 20:39:39 -08:00
Kubernetes Prow Robot
9b59ba4ef8 Merge pull request #81895 from praseodym/fix-staticcheck-test/images
Fix staticcheck failures for test/images
2019-12-30 00:09:39 -08:00
SataQiu
8c77b96b75 fix staticcheck failures of test/integration/scale test/integration/serviceaccount test/integration/serving test/integration/volume 2019-12-30 13:35:13 +08:00
danielqsj
19fe9f8d94 replace grpc.WithDialer which is deprecated 2019-12-26 17:46:59 +08:00
Mark Janssen
a54e5cec54 Fix staticcheck failures for pkg/proxy/...
Errors from staticcheck:
pkg/proxy/healthcheck/proxier_health.go:55:2: field port is unused (U1000)
pkg/proxy/healthcheck/proxier_health.go:162:20: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
pkg/proxy/healthcheck/service_health.go:166:20: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
pkg/proxy/iptables/proxier.go:737:2: this value of args is never used (SA4006)
pkg/proxy/iptables/proxier.go:737:15: this result of append is never used, except maybe in other appends (SA4010)
pkg/proxy/iptables/proxier.go:1287:28: this result of append is never used, except maybe in other appends (SA4010)
pkg/proxy/userspace/proxysocket.go:293:3: this value of n is never used (SA4006)
pkg/proxy/winkernel/metrics.go:74:6: func sinceInMicroseconds is unused (U1000)
pkg/proxy/winkernel/metrics.go:79:6: func sinceInSeconds is unused (U1000)
pkg/proxy/winuserspace/proxier.go:94:2: field portMapMutex is unused (U1000)
pkg/proxy/winuserspace/proxier.go:118:2: field owner is unused (U1000)
pkg/proxy/winuserspace/proxier.go:119:2: field socket is unused (U1000)
pkg/proxy/winuserspace/proxysocket.go:620:4: this value of n is never used (SA4006)
2019-12-22 21:32:06 +01:00
Kubernetes Prow Robot
623b697886 Merge pull request #86040 from haosdent/fix-staticcheck-annotate
fix static check in kubectl/pkg/cmd/annotate.
2019-12-17 06:18:27 -08:00
carlory
2fe82075b4 fix staticcheck faulures in 'cmd' pkg 2019-12-16 18:32:54 +08:00
Mark Janssen
a634e254c1 Fix staticcheck failures for test/images
Errors from staticcheck:
test/images/agnhost/dns/common.go:79:6: func runCommand is unused (U1000)
test/images/agnhost/inclusterclient/main.go:75:16: using time.Tick leaks the underlying ticker, consider using it only in endless functions, tests and the main package, and use time.NewTicker here (SA1015)
test/images/agnhost/net/nat/closewait.go:41:5: var leakedConnection is unused (U1000)
test/images/agnhost/netexec/netexec.go:157:17: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
test/images/agnhost/netexec/netexec.go:250:18: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
test/images/agnhost/netexec/netexec.go:317:18: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
test/images/agnhost/netexec/netexec.go:331:19: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
test/images/agnhost/netexec/netexec.go:345:19: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
test/images/agnhost/netexec/netexec.go:357:19: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
test/images/agnhost/netexec/netexec.go:370:19: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
test/images/agnhost/netexec/netexec.go:380:9: this value of err is never used (SA4006)
test/images/agnhost/netexec/netexec.go:381:17: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
test/images/agnhost/netexec/netexec.go:386:17: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
test/images/agnhost/pause/pause.go:43:23: syscall.SIGKILL cannot be trapped (did you mean syscall.SIGTERM?) (SA1016)
test/images/agnhost/serve-hostname/serve_hostname.go:125:15: the channel used with signal.Notify should be buffered (SA1017)
test/images/agnhost/webhook/patch_test.go:131:13: this value of err is never used (SA4006)
test/images/pets/peer-finder/peer-finder.go:155:6: this value of newPeers is never used (SA4006)
2019-12-15 22:34:27 +01:00
Kubernetes Prow Robot
32883e46d6 Merge pull request #86238 from SataQiu/fix-staticcheck-20191213
Fix staticcheck failures of test/e2e/manifest
2019-12-15 11:07:37 -08:00
Jordan Liggitt
f2f22b84cd Delete ReplicationControllerDummy 2019-12-13 12:21:33 -05:00
SataQiu
95bf226533 fix staticcheck failures of test/e2e/manifest 2019-12-13 14:03:44 +08:00
SataQiu
e70120f083 fix staticcheck failures of e2e/storage/utils e2e/storage/vsphere 2019-12-11 10:33:21 +08:00
SataQiu
3ed535a89a fix staticcheck failures of e2e/storage/drivers e2e/storage/testsuites 2019-12-10 16:09:29 +08:00
Haosdent Huang
303c1a40bc fix static check in kubectl/pkg/cmd/annotate. 2019-12-08 23:25:50 +08:00
SataQiu
27d645dc5b fix staticcheck failures of test/e2e/storage 2019-12-07 21:32:11 +08:00
Kubernetes Prow Robot
8ef9caaded Merge pull request #85676 from tanjunchen/fix-staticcheck-test-integration-apiserver
fix staticcheck in test/integration/apiserver
2019-12-06 19:49:08 -08:00
Kubernetes Prow Robot
e0f11a2fc3 Merge pull request #85893 from tanjunchen/fix-test-e2e-network
fix staticcheck in test/e2e/network/
2019-12-06 17:06:06 -08:00
tanjunchen
06c5901769 fix staticcheck in test/integration/apiserver 2019-12-06 23:05:20 +08:00
Kubernetes Prow Robot
c2b312bd22 Merge pull request #85790 from tanjunchen/fix-staticcheck-pkg-printers
fix staticcheck in pkg/printers
2019-12-05 13:50:54 -08:00
Kubernetes Prow Robot
fe80f32904 Merge pull request #85780 from hwdef/fix-staticcheck16
test/e2e/auth: Fix static check failures
2019-12-05 13:50:44 -08:00
hwdef
d81dd48e2c test/e2e/auth: Fix static check failures 2019-12-05 22:42:04 +08:00
Kubernetes Prow Robot
8290c85b95 Merge pull request #82315 from beautytiger/fix_staticcheck_azure
fix staticcheck errors in legacy-cloud-providers/azure
2019-12-05 06:36:32 -08:00
tanjunchen
d51b72d9e9 fix staticcheck in test/e2e/network/ 2019-12-05 13:58:28 +08:00
tanjunchen
40911e74c1 fix staticcheck in pkg/printers 2019-12-05 10:24:42 +08:00
Kubernetes Prow Robot
97a4e6683e Merge pull request #85634 from hwdef/fix-staticcheck14
pkg/master: Fix static check failures
2019-12-04 07:18:57 -08:00
Guangming Wang
b304538942 fix staticcheck errors in legacy-cloud-providers/azure
clean remaining static check errors in legacy-cloud-providers/azure

logging unhandled error in azure_backoff.go

delete unused var and func in azure_vmss_cache.go

run gofmt
2019-12-04 21:58:26 +08:00
Kubernetes Prow Robot
6d5eee88e0 Merge pull request #84624 from hwdef/fix-staticcheck
cmd/kube-controller-manager: fix staticcheck warning
2019-12-04 01:54:57 -08:00
SataQiu
6fcd030877 fix staticcheck failures of test/e2e/upgrade 2019-12-03 23:36:09 +08:00
hwdef
dddd631706 cmd/kube-controller-manager: fix staticcheck warning 2019-12-03 11:16:24 +08:00
Kubernetes Prow Robot
6a48f55e56 Merge pull request #83714 from tanjunchen/fix-staticcheck-test/e2e/windows
fix staticcheck  failures in test/e2e/windows
2019-11-26 19:43:20 -08:00
hwdef
e7172b3dbf pkg/master: Fix static check failures 2019-11-27 09:15:57 +08:00
Kubernetes Prow Robot
a82f7cdd5d Merge pull request #85469 from hwdef/fix-staticcheck12
test/e2e/apimachinery: fix staticcheck warning
2019-11-26 12:17:34 -08:00
hwdef
a0489c6ca8 test/e2e/apimachinery: fix staticcheck warning 2019-11-26 22:07:26 +08:00
Lars Lehtonen
b1c39e9b16 apimachinery: Fix Dropped Test Error (#85427)
* apimachinery: fix dropped test error in pkg/util/net

* apimachinery: fix dropped test error in pkg/runtime/serializer

* apimachinery: fix dropped test error in pkg/conversion

* apimachinery: fix staticcheck warning
2019-11-23 15:31:50 -08:00
Travis Rhoden
0c5c3d8bb9 Remove pkg/util/mount (moved out of tree)
This patch removes pkg/util/mount completely, and replaces it with the
mount package now located at k8s.io/utils/mount. The code found at
k8s.io/utils/mount was moved there from pkg/util/mount, so the code is
identical, just no longer in-tree to k/k.
2019-11-15 08:29:12 -07:00
tanjunchen
7420faab43 fix-staticcheck in /test/e2e/windows 2019-11-15 09:45:43 +08:00
Kubernetes Prow Robot
bfb99d809a Merge pull request #85117 from hwdef/fix-staticcheck10
pkg/kubeapiserver: fix staticcheck warning
2019-11-14 13:31:15 -08:00
Kubernetes Prow Robot
5c772f5933 Merge pull request #84674 from hwdef/fix-staticcheck4
pkg/client: fix staticcheck warning
2019-11-14 13:30:45 -08:00
hwdef
b3377e61de pkg/kubeapiserver: fix staticcheck warning 2019-11-14 11:24:22 +08:00
hwdef
82b9cf1890 pkg/client: fix staticcheck warning 2019-11-14 10:08:16 +08:00
Kubernetes Prow Robot
6eb2f25247 Merge pull request #85075 from hwdef/fix-staticcheck9
pkg/credentialprovider: fix staticcheck warning
2019-11-13 09:27:18 -08:00
Kubernetes Prow Robot
36373b37fd Merge pull request #84672 from hwdef/fix-staticcheck2
cmd:fix staticcheck warning
2019-11-12 09:06:06 -08:00
hwdef
170eadc3d2 pkg/credentialprovider: fix staticcheck warning 2019-11-11 09:46:52 +08:00
hwdef
5c6ed21d34 cmd:fix staticcheck warning 2019-11-03 00:00:54 +08:00
Sean Sullivan
907e3d61ab Fixes staticcheck failures and golint failures 2019-10-29 17:50:23 -07:00
Kubernetes Prow Robot
2896fb0be8 Merge pull request #83711 from tanjunchen/fix-staticcheck-test/e2e/network
fix staticcheck failures in test/e2e/common directory
2019-10-26 02:23:22 -07:00
Kubernetes Prow Robot
df8587f99f Merge pull request #84062 from seans3/tableprinter-move
Removes kubectl get dependency on Kubernetes core
2019-10-24 16:55:52 -07:00