github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
87,997 Commits 1 Branch 31 Tags 1,019 MiB
5bb1838c5c
Commit Graph

8327 Commits

Author SHA1 Message Date
SataQiu
6fcd030877 fix staticcheck failures of test/e2e/upgrade 2019-12-03 23:36:09 +08:00
Kubernetes Prow Robot
716b4549b2
Merge pull request #85749 from SataQiu/golint-e2e-20191129 
Fix golint failures of test/e2e_node/remote
 2019-12-03 06:06:58 -08:00
tanjunchen
d2d68026fc Fix golint issues in test/e2e/lifecycle/ 2019-12-03 17:14:38 +08:00
hwdef
dddd631706 cmd/kube-controller-manager: fix staticcheck warning 2019-12-03 11:16:24 +08:00
Kubernetes Prow Robot
0810bc3386
Merge pull request #85363 from immutableT/encryption-config-defaulter 
Add defaulting and validation logic for EncryptionConfiguration type.
 2019-12-02 17:06:57 -08:00
immutablet
a151aa35dc Add defaulting logic for EncryptionConfiguration. 2019-12-02 13:21:05 -08:00
SataQiu
69aae3aa5a fix golint failures of test/e2e_node/remote 2019-11-29 18:11:55 +08:00
Jordan Liggitt
9a868766ee Enable mutation detection 2019-11-28 02:26:38 -05:00
Kubernetes Prow Robot
2eda47221a
Merge pull request #83604 from k-toyoda-pi/fix_shellcheck_log-dump 
Fix shellcheck failure in cluster/log-dump/log-dump.sh
 2019-11-27 21:03:03 -08:00
Kubernetes Prow Robot
0efe584db6
Merge pull request #85513 from liu-cong/benchmark-fix 
Fix benchmark artifact parsing.
 2019-11-27 16:41:03 -08:00
Kubernetes Prow Robot
c58b63267c
Merge pull request #85562 from gkarthiks/master 
golint fixes for /pkg/util/iptables/testing
 2019-11-27 10:46:45 -08:00
Kubernetes Prow Robot
ef1af14cab
Merge pull request #85172 from c3y1huang/fix/golint_failure/Remove-pkg.registry.apps.replicaset 
Fix golint failures for pkg/registry/apps/replicaset
 2019-11-27 01:09:21 -08:00
Kubernetes Prow Robot
93c2eed3cb
Merge pull request #84901 from SataQiu/golint-e2e-node-20191107 
Fix golint issues in test/e2e_node
 2019-11-26 23:19:21 -08:00
Kubernetes Prow Robot
6a48f55e56
Merge pull request #83714 from tanjunchen/fix-staticcheck-test/e2e/windows 
fix staticcheck  failures in test/e2e/windows
 2019-11-26 19:43:20 -08:00
Kubernetes Prow Robot
b94dca92a8
Merge pull request #85657 from liggitt/bazel-module 
Enable update-bazel.sh outside of GOPATH
 2019-11-26 18:23:20 -08:00
hwdef
e7172b3dbf pkg/master: Fix static check failures 2019-11-27 09:15:57 +08:00
Jordan Liggitt
a8991a108a Enable update-bazel.sh outside of GOPATH 2019-11-26 17:33:57 -05:00
Kubernetes Prow Robot
a82f7cdd5d
Merge pull request #85469 from hwdef/fix-staticcheck12 
test/e2e/apimachinery: fix staticcheck warning
 2019-11-26 12:17:34 -08:00
Cong Liu
016ab0b899 Fix benchmark artifact parsing. 
* Added a extractor to extract raw logs from json format and then pipe
it into benchmark parser.
* Also added -alsologtostderr=false -logtostderr=false to reduce noisy logs.
 2019-11-26 13:47:12 -05:00
hwdef
a0489c6ca8 test/e2e/apimachinery: fix staticcheck warning 2019-11-26 22:07:26 +08:00
SataQiu
d2bdf89a8b fix golint issues in test/e2e_node 2019-11-26 16:26:55 +08:00
Kubernetes Prow Robot
cec566d77a
Merge pull request #85451 from flix-tech/ruben.serradas 
Fix golint issues in pkg/kubelet/events/event.go
 2019-11-25 16:43:10 -08:00
Howard Zhang
09d4d65b1b fix etcd version check error on ARM 
"etcd -version" command output an additional line on ARM platform:
"running etcd on unsupported architecture "arm64" since
ETCD_UNSUPPORTED_ARCH is set"
Currently etcd version filtering code can not get correct version
number.

Signed-off-by: Howard Zhang <howard.zhang@arm.com>
 2019-11-25 20:02:37 +08:00
Lars Lehtonen
b1c39e9b16 apimachinery: Fix Dropped Test Error (#85427) 
* apimachinery: fix dropped test error in pkg/util/net

* apimachinery: fix dropped test error in pkg/runtime/serializer

* apimachinery: fix dropped test error in pkg/conversion

* apimachinery: fix staticcheck warning
 2019-11-23 15:31:50 -08:00
gkarthiks
a4abc1dd4d refactor(golint): lint fixes for iptables test file 
Signed-off-by: gkarthiks <github.gkarthiks@gmail.com>
 2019-11-22 19:58:56 -08:00
Kubernetes Prow Robot
1900edf44a
Merge pull request #85440 from gkarthiks/master 
Fix lint in /pkg/util/iptables
 2019-11-22 17:31:31 -08:00
Guinevere Saenger
81d0007716 Hi San Diego (#85424) 
* removed -staging/src/k8s.io/apimachinery/pkg/util/clock for golint failures

* first few code comments are done

* add correct comments for all packages
 2019-11-22 17:31:13 -08:00
Ian Bull
a232971d73 Add public documentation for kubelet/apis/config 
The `kubelet/apis/config` package had golint failures. This change-set
removes the `kubelet/apis/config` package from the `.golint_failures`
and fixes the golint errors. In particular, this change-set adds
documentation to the public types in the package.

This change-set works towards issue#68026
 2019-11-20 22:52:53 -08:00
Ruben
55c83e3397 Fix golint issues in pkg/kubelet/events/event.go 
Change the single const statement in favor of multiple const event lists.
This way we don't need to put the name of the constant in the comment
and it's clearer that the comment refers to the whole list.
 2019-11-19 13:15:08 +01:00
Karthikeyan Govindaraj
1f4cd65be5
chore(lint): removing the iptables pkg 2019-11-18 23:49:34 -08:00
Travis Rhoden
0c5c3d8bb9
Remove pkg/util/mount (moved out of tree) 
This patch removes pkg/util/mount completely, and replaces it with the
mount package now located at k8s.io/utils/mount. The code found at
k8s.io/utils/mount was moved there from pkg/util/mount, so the code is
identical, just no longer in-tree to k/k.
 2019-11-15 08:29:12 -07:00
tanjunchen
7420faab43 fix-staticcheck in /test/e2e/windows 2019-11-15 09:45:43 +08:00
Kubernetes Prow Robot
bfb99d809a
Merge pull request #85117 from hwdef/fix-staticcheck10 
pkg/kubeapiserver: fix staticcheck warning
 2019-11-14 13:31:15 -08:00
Kubernetes Prow Robot
5c772f5933
Merge pull request #84674 from hwdef/fix-staticcheck4 
pkg/client: fix staticcheck warning
 2019-11-14 13:30:45 -08:00
hwdef
b3377e61de pkg/kubeapiserver: fix staticcheck warning 2019-11-14 11:24:22 +08:00
hwdef
82b9cf1890 pkg/client: fix staticcheck warning 2019-11-14 10:08:16 +08:00
Kubernetes Prow Robot
64f4be5b32
Merge pull request #84390 from robscott/endpointslice-beta 
Promoting EndpointSlices to beta
 2019-11-13 17:27:50 -08:00
Kubernetes Prow Robot
8af6906d1f
Merge pull request #85220 from liggitt/revert-licenses 
Revert #76586, restructure LICENSES file generation
 2019-11-13 14:52:11 -08:00
Kubernetes Prow Robot
d85103b185
Merge pull request #85217 from kaoskater08/kaoskater08/fix-golint-pkg-apis-extensions 
fixed golint errors in pkg/apis/extensions register.go and types.go
 2019-11-13 14:51:46 -08:00
Rob Scott
a7e589a8c6
Promoting EndpointSlices to beta 2019-11-13 14:20:19 -08:00
Kubernetes Prow Robot
f501d8e59a
Merge pull request #85138 from liggitt/webhook-config-v1 
Promote apiserver.config.k8s.io/v1, kind=WebhookAdmissionConfiguration
 2019-11-13 13:03:54 -08:00
Kubernetes Prow Robot
195664db0e
Merge pull request #85099 from liggitt/quota-config-v1 
Promote apiserver.config.k8s.io/v1, kind=ResourceQuotaConfiguration
 2019-11-13 13:02:52 -08:00
Kubernetes Prow Robot
b49afbfa64
Merge pull request #85098 from liggitt/admission-config-v1 
Promote apiserver.config.k8s.io/v1, kind=AdmissionConfiguration
 2019-11-13 13:02:40 -08:00
Kubernetes Prow Robot
6eb2f25247
Merge pull request #85075 from hwdef/fix-staticcheck9 
pkg/credentialprovider: fix staticcheck warning
 2019-11-13 09:27:18 -08:00
Jordan Liggitt
cd4474ae4f Revert "76093 restructure LICENSES file generation" 
This reverts commit d39ac98cc5.
 2019-11-13 10:24:32 -05:00
Eddie Hale
566484366e fixed golint errors in pkg/apis/extensions register.go and types.go 2019-11-13 08:48:42 -06:00
Chin-Ya Huang
92c7e8e802 Fix golint failures 
* Remove pkg/registry/apps/replicaset

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
 2019-11-13 11:00:12 +08:00
Ji Shan Xing
d39ac98cc5 76093 restructure LICENSES file generation 2019-11-12 20:38:57 -05:00
Kubernetes Prow Robot
36373b37fd
Merge pull request #84672 from hwdef/fix-staticcheck2 
cmd:fix staticcheck warning
 2019-11-12 09:06:06 -08:00
Jordan Liggitt
71fad812ca Promote WebhookAdmissionConfiguration to v1 2019-11-12 09:56:58 -05:00
Jordan Liggitt
1234290adf AdmissionConfiguration v1 2019-11-12 09:05:50 -05:00
Jordan Liggitt
7d3012f297 Promote resource quota admission configuration to v1 2019-11-12 09:03:55 -05:00
Kubernetes Prow Robot
897ce3073c
Merge pull request #84533 from davidz627/fix/deprecatedPath 
Remove plugin watching of deprecated directory and CSI v0 support in accordance with deprecation policy
 2019-11-12 04:48:20 -08:00
toyoda
e99a325d4e Fix shellcheck failure in log-dump/log-dump.sh 2019-11-12 16:51:09 +09:00
David Zhu
802fe12803 Remove plugin watching of deprecated directory {kubelet_root_dir}/plugins and support for CSI V0 in accordance with deprecation announcement in https://v1-13.docs.kubernetes.io/docs/setup/release/notes/ 2019-11-11 11:42:58 -08:00
Roy Hvaara
896f84b652
Fix golint issues in pkg/apis/batch/validation 2019-11-11 04:03:34 +01:00
Clayton Coleman
c416ee584c
Remove deprecated-dynamic client 
It is now unused.
 2019-11-10 21:30:30 -05:00
hwdef
170eadc3d2 pkg/credentialprovider: fix staticcheck warning 2019-11-11 09:46:52 +08:00
Kubernetes Prow Robot
35cfd327c8
Merge pull request #84243 from Dingshujie/fix-golint 
Fix golint errors in pkg/apis/apps
 2019-11-10 16:29:54 -08:00
Kubernetes Prow Robot
ebbe4baf13
Merge pull request #83914 from guineveresaenger/ato-demo 
Removes pkg/registry/core/secret/storage from golint failures
 2019-11-10 16:29:41 -08:00
Kubernetes Prow Robot
a18303dfa4
Merge pull request #85042 from hvaara/fix-golint-pkg-apis-policy 
Fix golint issues in pkg/apis/policy
 2019-11-09 15:29:58 -08:00
Kubernetes Prow Robot
80b25a766a
Merge pull request #85037 from hvaara/fix-golint-pkg-apis-authorization 
Fix golint issues in pkg/apis/authorization
 2019-11-09 15:29:48 -08:00
Roy Hvaara
cfc34712c2
Fix golint issues in pkg/registry/.../storage 2019-11-10 00:22:51 +01:00
Roy Hvaara
cfc596b302 Fix golint issues in pkg/apis/autoscaling/validation (#85041) 
* Fix golint issues in pkg/apis/autoscaling/validation

* Fix spelling issue in field of Error
 2019-11-09 14:03:48 -08:00
Kubernetes Prow Robot
a258243f4c
Merge pull request #85009 from oomichi/enable-verify-import-aliases 
Enable verify-import-aliases check in CI
 2019-11-09 12:23:39 -08:00
Roy Hvaara
10c8508acd
Fix golint issues in pkg/apis/policy 2019-11-09 21:15:35 +01:00
Roy Hvaara
8d3c74aebc
Fix golint issues in pkg/apis/authorization 2019-11-09 17:45:37 +01:00
Roy Hvaara
e55fc5656c
Fix golint issues in pkg/util/sysctl/testing 2019-11-09 12:32:37 +01:00
Kubernetes Prow Robot
b15dfd778a
Merge pull request #84708 from yue9944882/feat/flowcontrol-storage 
Feature: Flowcontrol rest storage implementation
 2019-11-08 18:44:09 -08:00
Kubernetes Prow Robot
e4fdb82c01
Merge pull request #84302 from serathius/restrict-prometheus-import 
Restrict visibility of prometheus packages
 2019-11-08 13:48:26 -08:00
Kenichi Omichi
1b165fc440 Enable verify-import-aliases check in CI 
To block violation of import-aliases rule, this enables
verify-import-aliases in CI system.
 2019-11-08 19:17:39 +00:00
yue9944882
3d1b5d0e9a flowcontrol rest storage implementation 2019-11-08 14:27:14 +08:00
Kubernetes Prow Robot
e445d4d779
Merge pull request #84871 from liggitt/cmd-test 
Make test-cmd effective again
 2019-11-07 13:28:21 -08:00
Kubernetes Prow Robot
7a1eaa112e
Merge pull request #84696 from dims/BenTheElder-byebyehacke2e 
Remove hack/e2e.go
 2019-11-07 09:05:04 -08:00
mattjmcnaughton
d30319711e
Fix golint failures for pkg/kubelet/config/... 
Address the final golint failure by adding a comment explaining our
blank import.
 2019-11-07 09:36:22 -05:00
Kubernetes Prow Robot
0a46e374dc
Merge pull request #84772 from hvaara/golint-failures-support-comments 
Support comments in hack/.golint_failures
 2019-11-07 04:36:17 -08:00
Kubernetes Prow Robot
41a70bcc0a
Merge pull request #84750 from hvaara/fix-golint-test-e2e_kubeadm 
Fix golint issues in test/e2e_kubeadm
 2019-11-07 04:36:07 -08:00
Kubernetes Prow Robot
1183771545
Merge pull request #84748 from hvaara/fix-golint-controller-volume-persistentvolume-options 
Fix golint issues in pkg/controller/volume/persistentvolume/options
 2019-11-07 04:35:53 -08:00
Marek Siarkowicz
e7d5659943 Restrict visibility of prometheus to enforce usage of k8s.io/component-base/metrics 2019-11-07 09:12:55 +01:00
Jordan Liggitt
1678f42970 Fix run_kubectl_sort_by_tests 2019-11-07 02:26:45 -05:00
Jordan Liggitt
59dfac587f Fix assert methods 2019-11-07 02:26:45 -05:00
Jordan Liggitt
9f30c783bc bump kazel, bazel, gazelle 
hack/pin-dependency.sh k8s.io/repo-infra v0.0.1-alpha.1
To fix non-idempotent BUILD file generation

hack/pin-dependency.sh github.com/bazelbuild/bazel-gazelle v0.19.0
hack/pin-dependench.sh github.com/bazelbuild/buildtools 0.29.0
for go1.13.3 support

hack/lint-dependencies.sh

hack/pin-dependency.sh github.com/bazelbuild/buildtools v0.0.0-20190917191645-69366ca98f89
to pick up preferred version for repo-infra
 2019-11-06 17:39:05 -05:00
Jordan Liggitt
e3ff39ffa0 Update build to go1.13.4 2019-11-06 17:39:05 -05:00
Jordan Liggitt
ee2b887c74 Fix hack/pin-dependency.sh for go1.13 2019-11-06 17:39:05 -05:00
Jordan Liggitt
8618c09369 opt out of module mode for builds 2019-11-06 17:39:05 -05:00
Roy Hvaara
e16ee0b68e
Support comments in hack/.golint_failures 2019-11-05 22:59:42 +01:00
Kubernetes Prow Robot
8245a24c37
Merge pull request #84761 from thockin/make-better-find-filter 
Build: Use a better filter on find
 2019-11-05 11:44:54 -08:00
feifei.zhang@huawei.com
fdce8ef960 fix golint failures of pkg/security/apparmor 2019-11-05 18:56:15 +08:00
Tim Hockin
a1ad4910dc Build: Use a better filter on find 
In case the _workspace directory exists, filter it out.
 2019-11-04 21:00:58 -08:00
Roy Hvaara
a9ed936792
Fix golint issues in test/e2e_kubeadm 2019-11-04 23:20:24 +01:00
Roy Hvaara
dffcf7c8cd
Fix golint issues in pkg/controller/volume/persistentvolume/options 2019-11-04 21:45:21 +01:00
Kubernetes Prow Robot
7b6369c803
Merge pull request #84249 from odinuge/bump-shellcheck 
Bump shellcheck to v0.7.0
 2019-11-04 06:19:40 -08:00
Benjamin Elder
83c56a0373
remove hack/e2e.go 2019-11-03 19:36:59 -05:00
hwdef
5c6ed21d34 cmd:fix staticcheck warning 2019-11-03 00:00:54 +08:00
Kubernetes Prow Robot
510fb38f27
Merge pull request #83671 from yue9944882/flow-control-api-model 
Apiserver flowcontrol api models
 2019-11-01 22:49:40 -07:00
Kubernetes Prow Robot
df8706e60b
Merge pull request #84408 from mikedanese/cleanup 
delete unused cache
 2019-11-01 18:07:56 -07:00
Jordan Liggitt
b44d7c8d3c Drop version from static openapi json file 2019-11-01 13:35:10 -04:00
Kubernetes Prow Robot
7341803597
Merge pull request #84593 from mm4tt/benchmark_dockerized_gopath 
Don't use hardcoded /go GOPATH in benchmark-dockerized.sh
 2019-10-31 07:39:37 -07:00
Matt Matejczyk
68aebb4899 Don't use hardcoded /go GOPATH in benchmark-dockerized.sh 2019-10-31 13:57:04 +01:00
Kubernetes Prow Robot
ecec5cb2a4
Merge pull request #84540 from seans3/kubectl-get-staging 
Moves kubectl get subcommand to staging
 2019-10-30 21:56:37 -07:00
Kubernetes Prow Robot
5e468a49de
Merge pull request #84478 from hvaara/fix-golint-pkg/credentialprovider/gcp 
Fix golint issues in pkg/credentialprovider/gcp
 2019-10-30 06:38:54 -07:00
Kubernetes Prow Robot
e1d3cc74e5
Merge pull request #84329 from jingyih/update_etcd_server_to_3.4 
Update default etcd server to 3.4.3
 2019-10-30 02:30:52 -07:00
Sean Sullivan
907e3d61ab Fixes staticcheck failures and golint failures 2019-10-29 17:50:23 -07:00
Kubernetes Prow Robot
f8b45a12f4
Merge pull request #84464 from wojtek-t/remove_conversion_funcs_1 
Migrate couple manual conversions to the new AddConversionFunc() way
 2019-10-29 15:39:07 -07:00
Mike Danese
0e69316bb3 delete unused cache 
We aren't using this anywhere and it's not named properly for what it
is. We should either rename it or delete it (both break the package
API).
 2019-10-29 14:40:48 -07:00
Jingyi Hu
ccf4caf30f Update etcd.sh to use v3 endpoint 2019-10-29 13:10:29 -07:00
Kubernetes Prow Robot
a8e819746d
Merge pull request #83442 from serathius/remove-prometheus-addon 
Remove prometheus addon
 2019-10-29 01:34:43 -07:00
yue9944882
7c28a4b70e non-generated api models misc 
rule list

rule

rule 2
 2019-10-29 12:26:12 +08:00
Jingyi Hu
706cde51c5 Update default etcd server to 3.4.3 2019-10-28 18:29:37 -07:00
Roy Hvaara
e40c473334
Fix golint errors in pkg/credentialprovider/gcp 2019-10-28 21:54:45 +01:00
wojtekt
32759d33bf Cleanup conversions 2019-10-28 21:14:20 +01:00
Kubernetes Prow Robot
2896fb0be8
Merge pull request #83711 from tanjunchen/fix-staticcheck-test/e2e/network 
fix staticcheck failures in test/e2e/common directory
 2019-10-26 02:23:22 -07:00
Kubernetes Prow Robot
df8587f99f
Merge pull request #84062 from seans3/tableprinter-move 
Removes kubectl get dependency on Kubernetes core
 2019-10-24 16:55:52 -07:00
Kubernetes Prow Robot
98442617cc
Merge pull request #81708 from RainbowMango/pr_fix_static_failure_for_code-generator 
Fix static failure for package: staging/src/k8s.io/code-generator
 2019-10-23 23:25:07 -07:00
Odin Ugedal
d467b8ea14
Fix shellcheck failures SC2128 2019-10-23 22:47:46 +02:00
Odin Ugedal
cce1f32ea5
Fix shellcheck failures SC2034 2019-10-23 22:47:46 +02:00
Odin Ugedal
65a66b9d7f
Bump shellcheck to v0.7.0 
Changelog:
https://github.com/koalaman/shellcheck/blob/master/CHANGELOG.md

We have some new erros due to the version bump.

- SC2034: VARIABLE_XYZ appears unused. Verify use (or export if used externally).
    - Applies to all scripts we source in other scripts
- SC2039: In POSIX sh, set option pipefail is undefined.
    - Applies to files using it with "sh" instead of "bash" in the shebang
- SC2054: Use spaces, not commas, to separate array elements.
    - Fixing Should make no difference in the code
- SC2128: Expanding an array without an index only gives the first element.
    - Fixing Should make no difference in the code
- SC2251: This ! is not on a condition and skips errexit. Use `&& exit 1` instead, or make sure $? is checked.
    - Not 100% sure if we can swap to `&& exit 1`. Applies to a lot of
    test code.

All changes should be straight forward to fix, but will be done in a
separate PR.
 2019-10-23 21:32:19 +02:00
DingShujie
171b486c34 Fix golint errors in pkg/apis/apps 2019-10-23 23:32:08 +08:00
Sean Sullivan
1b40a8849d Ignore staticcheck again for tableprinter.go 2019-10-22 23:45:08 -07:00
Kubernetes Prow Robot
75cd65ae0e
Merge pull request #82145 from shivi28/fix-controller-nodeipam-ipam-cidrset 
nodeipam-controller:fix static check failures
 2019-10-22 23:18:26 -07:00
Cristian Dima
a18de39166 fix golint errors in pkg/controller/service 2019-10-23 01:52:19 +03:00
ianlang
3359577d42 set default value of KUBE_MASTER_URL to empty 2019-10-22 10:08:55 +08:00
Kubernetes Prow Robot
c634276498
Merge pull request #83497 from pivotal-k8s/allow-custom-tags 
Allow users to use custom tags
 2019-10-20 22:17:37 -07:00
Kubernetes Prow Robot
ff7a09928b
Merge pull request #84070 from neolit123/1.17-remove-test-owners-ref 
remove usage of the test/test_owners.* files
 2019-10-19 02:13:36 -07:00
Kubernetes Prow Robot
b574074981
Merge pull request #84055 from odinuge/cherry_pick_indent 
Fix indent in cherry_pick_pull script
 2019-10-18 02:15:58 -07:00
Lubomir I. Ivanov
2c54160021 remove usage of the test/test_owners.* files 
- remove update_owners.py; seems responsible for generating
test_owners files
- remove the existing test/test_owners.* files
- remove verify-test-owners.sh and references to it
 2019-10-18 03:01:21 +03:00
Kubernetes Prow Robot
7ed388caa6
Merge pull request #83744 from neolit123/1.17-move-test-owners-sig-cl-gcp 
test/e2e: move some tests from cluster-lifecycle to cloud-provider-gcp
 2019-10-17 16:33:58 -07:00
Odin Ugedal
b840398be8
Fix indent in cherry_pick_pull script 2019-10-17 17:43:29 +02:00
Kubernetes Prow Robot
4887b0cac2
Merge pull request #84008 from notpad/fix_83985 
Change node name to env value of HOSTNAME_OVERRIDE
 2019-10-17 05:12:37 -07:00
Kubernetes Prow Robot
2eef011c38
Merge pull request #81345 from k-toyoda-pi/fix_shellcheck_validate-cluster 
Fix shellcheck failures in cluster/validate-cluster.sh
 2019-10-17 03:18:38 -07:00
Hongwei Yu
7574f95f7d optimize comments on exported constants (#83875) 
* optimize comments on exported constants

* remove package in hack/.golint_failures are passing golint
 2019-10-16 22:25:30 -07:00
Kubernetes Prow Robot
44674bf5d3
Merge pull request #83969 from yutedz/rm-update-storage 
Remove update-storage-objects.sh
 2019-10-16 11:37:55 -07:00
Kubernetes Prow Robot
d720a2269a
Merge pull request #83802 from seans3/rewrite-printer-tests 
Rewrite printer tests
 2019-10-16 09:33:42 -07:00
notpad
c13f2d4748 Change node name to env value of HOSTNAME_OVERRIDE 2019-10-16 22:39:52 +08:00
Kubernetes Prow Robot
99d40d3d44
Merge pull request #80137 from ialidzhikov/enh/better-naming 
Rename dashboard-controller.yaml to dashboard-deployment.yaml
 2019-10-16 05:51:41 -07:00
Kubernetes Prow Robot
63cf2e260b
Merge pull request #83819 from mrbobbytables/emeritus-jbeda 
Move jbeda to emeritus status.
 2019-10-15 23:06:20 -07:00
Sean Sullivan
30d8a93768 Cleanup printer test package. 
Updates internalversion BUILD file dependencies

Removes pkg/printers/internalversion from staticcheck failures
 2019-10-15 18:13:00 -07:00
Ted Yu
240546cb7f Remove update-storage-objects.sh 2019-10-15 13:13:19 -07:00
Kubernetes Prow Robot
cb3b715de2
Merge pull request #83804 from jpbetz/etcd-3_3_17_server 
Upgrade to etcd server 3.3.17
 2019-10-15 12:50:09 -07:00
ialidzhikov
b3dcbbf98c Rename dashboard-controller.yaml to dashboard-deployment.yaml 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
 2019-10-15 13:55:06 +03:00
guineveresaenger
82123dc261 Removes pkg/registry/core/secret/storage from golint failures 2019-10-14 14:28:32 -04:00
Joe Betz
c92bd5e7b5 Upgrade to etcd server 3.3.17 2019-10-13 17:17:15 -07:00
Lubomir I. Ivanov
db61aaa9d0 update staticcheck_failures 2019-10-12 22:53:09 +03:00
Kubernetes Prow Robot
457fa6b40d
Merge pull request #82413 from zhlhahaha/kube-proxy-error 
local-up-cluster kube-proxy terminated error
 2019-10-12 07:48:37 -07:00
tanjunchen
33dda68788 fix staticcheck in test/e2e/common directory 2019-10-12 11:30:47 +08:00
Bob Killen
e65d8bb11f
Move jbeda to emeritus status. 2019-10-11 17:46:18 -04:00
mattjmcnaughton
b92a51285b
Address staticcheck failures for test/e2e/lifecycle/bootstrap 
Make small, non-functional changes to make the
`test/e2e/lifecycle/bootstrap` pass staticcheck.
 2019-10-11 10:28:15 -04:00
Kubernetes Prow Robot
3db6d3abcf
Merge pull request #83551 from dims/move-external-facing-kubelet-apis-to-staging 
Move external facing kubelet apis to staging
 2019-10-10 13:41:36 -07:00
Kubernetes Prow Robot
4f1c5b8cac
Merge pull request #81940 from carlory/fix-appserver 
fix static check failures
 2019-10-10 12:07:21 -07:00
carlory
f6bb24129e fix static check failures 2019-10-10 22:59:09 +08:00
mattjmcnaughton
69a473be38
Address staticcheck failures for test/e2e/node/... 
Fix the `staticcheck` failures for `test/e2e/node`. All of the
staticcheck errors were for variables which were never used. When these
values were `err`, we added processing for the errors. When they were
values that were just never used, we stopped giving them a name.
 2019-10-09 10:26:11 -04:00
Jonathan Tomer
d34f49b913 Up minimum go version to 1.12.4 
https://github.com/kubernetes/kubernetes/pull/77222 removed a workaround for a
Go standard library bug (https://github.com/golang/go/issues/31125) that was
not fixed until that version, so we need to require it.
 2019-10-07 15:55:33 -07:00
Kubernetes Prow Robot
7c4ba5909f
Merge pull request #82968 from uzuku/fix-golint-failures 
Fix golint failures of pkg/kubelet/status/...
 2019-10-07 07:47:08 -07:00
Davanum Srinivas
1bc8ec2508
fix generated-kubelet-plugin-registration 
Change-Id: I8c5b024a416293d01611d63a4a141bd90be52d9f
 2019-10-06 20:23:55 -04:00
Davanum Srinivas
f29d2272c8
fix gofmt and golint failures 
Change-Id: I6535b506f50558b31663a13cd270b15023afa2c6
 2019-10-06 18:43:17 -04:00
Davanum Srinivas
d30c489c54
Move pkg/kubelet/pluginregistration and deviceplugin 
Change-Id: I06adcb43bd278b430ffad2010869e1524c8cc4ff
 2019-10-06 15:28:38 -04:00
Kubernetes Prow Robot
469d6db33a
Merge pull request #83297 from m3ngyang/controller-comment 
fix golint errors for pkg/master
 2019-10-05 15:25:11 -07:00
Kubernetes Prow Robot
7c540ecdac
Merge pull request #83454 from dims/cleanup-hyperkube-from-release-artifacts 
Remove hyperkube from release artifacts
 2019-10-05 10:33:12 -07:00
Kubernetes Prow Robot
e0cb1617db
Merge pull request #78357 from sbueringer/fix-golint-pkg-util 
Fix golint issues in pkg/util/env
 2019-10-05 08:41:10 -07:00
mengyang02
ed8767cded fix golint errors for pkg/master, together with cheftako 2019-10-05 21:42:52 +08:00
mattjmcnaughton
bd6d411010
Fix test/integration/kubelet staticcheck failures 
`test/integration/kubelet` was failing staticcheck because it was
calling `t.Fatal` from the non-main Go routine. Address this by sending
errors causing t.Fatal back to a channel. The main thread can then
iterate through this channel, and call t.Fatal if there are any errors
in the channel.
 2019-10-04 11:37:59 -04:00
Kubernetes Prow Robot
791bfac90f
Merge pull request #83084 from yutedz/ns-prune 
Prune should respect namespace option
 2019-10-04 02:46:12 -07:00
Kubernetes Prow Robot
8387de4b4f
Merge pull request #82237 from SataQiu/fix-shellcheck-20190902 
Fix shellcheck failures of cluster/addons/addon-manager/kube-addons.sh
 2019-10-04 02:45:59 -07:00
Hannes Hörl
6b1d1ccbf5 Allow users to use custom tags 
When discovering the kube version we only consider tags that match the
glob 'v*'. By doing so users can create/use their custom tags as long as
they don't look like a version (starting with a 'v').

We already do a similar thing when building the pause container, see how
the `REV` is set in git.k8s.io/kubernetes/build/pause/Makefile.
 2019-10-04 12:18:18 +03:00
shivi28
a0109f00df nodeipam-controller:fix static check failures 2019-10-04 12:40:09 +05:30
Davanum Srinivas
138571b23f
Remove hyperkube from release artifacts 
Change-Id: Ie09248d6fc688ffffbeb0271824817a5129346a0
 2019-10-03 13:33:17 -04:00
Marek Siarkowicz
887e84e330 Remove Prometheus addon and it's tests 
Prometheus addon was developed for exterimental and test purpose only.
As readme states it should not be used by anyone.
 2019-10-03 14:15:58 +02:00
mattjmcnaughton
42f8596b13
Fix staticcheck failures in test/utils/... 
The `err` return value was being overwritten in an unintended way, which
means the function may not return the proper error value. This diff
ensures it does.
 2019-10-01 09:46:45 -04:00
toyoda
d9c7255ab4 Fix shellcheck failures in cluster/validate-cluster.sh 2019-10-01 15:35:39 +09:00
Kubernetes Prow Robot
3d40c4cea2
Merge pull request #83322 from wojtek-t/remove_scalability_tests 
Remove deprecated scalability tests
 2019-09-30 11:47:59 -07:00
wojtekt
59533f0cd1 Remove deprecated scalability tests 2019-09-30 16:04:09 +02:00
Kubernetes Prow Robot
2b795b9825
Merge pull request #83284 from odinuge/node-e2e-host-reuse 
Fix host reuse for e2e tests
 2019-09-29 16:47:50 -07:00
Kubernetes Prow Robot
7066107ae3
Merge pull request #83117 from zouyee/valid 
using short flags instead of validate
 2019-09-29 16:47:37 -07:00
Odin Ugedal
d17dc136a0
Fix host reuse for e2e tests 
This will now filter the hosts in gcloud by project, instance name and
zone, to make sure we only reuse the correct hosts. Previously it would
try to reuse images outside the selected zone, resulting in a crash.

The resulting command will look like this:
$ gcloud compute instances list --project="my-project-123" --filter="name:'test-cos-beta-78-12499-16-0' AND zone:'europe-west6-b'"
 2019-09-29 11:10:08 +02:00
Stefan Bueringer
fa36b19e79
Fix golint issues in pkg/util/env 2019-09-27 17:25:19 +02:00
Kubernetes Prow Robot
d82ab4054d
Merge pull request #81989 from RainbowMango/pr_cleanup_staticcheck_for_apiextension 
Cleanup staticcheck issues for apiextension
 2019-09-26 01:25:23 -07:00
Ted Yu
88e2f8e04f Prune should respect namespace 2019-09-25 16:43:08 -07:00
Kubernetes Prow Robot
05588f769d
Merge pull request #82928 from chendotjs/simplify-regex 
simplify regexp with raw string
 2019-09-25 11:07:02 -07:00
Mahendra Kariya
3698100224 Fix golint errors in pkg/apis/core (#82919) 
* Fix lint errors related to receiver name

Ref #68026

* Fix lint errors related to comments

Ref #68026

* Fix package name in comments

Ref #68026

* Rename Cpu to CPU

Ref #68026

* Fix lint errors related to naming convention

Ref #68026

* Remove deprecated field

DoNotUse_ExternalID has been deprecated and is not in use anymore.
It has been removed to fix lint errors related to underscores in field
names.

Ref #68026, #61966

* Include pkg/apis/core in golint check

Ref #68026

* Rename var to fix lint errors

Ref #68026

* Revert "Remove deprecated field"

This reverts commit 75e9bfc168077fcb9346e334b59d60a2c997735b.

Ref #82919

* Remove math from godoc

Ref #82919, #68026

* Remove underscore from var name

Ref #68026

* Rename var in staging core api type

Ref #68026
 2019-09-25 11:06:51 -07:00
zouyee
11746bcc19 using short flags instead with validate 
Signed-off-by: Zou Nengren <zouyee1989@gmail.com>
 2019-09-25 23:08:50 +08:00
RainbowMango
ea75ee32c0 Fix staticcheck issues: 
Dealing with unused functions/variables/types. (staticcheck U1000)
Dealing with value never used issue. (staticcheck SA4006)
Dealing with concurrency issue. (staticcheck SA2002 SA4010)
Remove packages from staticcheck failure files: apiextensions-apiserver
 2019-09-25 09:40:25 +08:00
Kubernetes Prow Robot
512eccac1f
Merge pull request #83008 from reith/local-cluster-webhook-conf 
hack/local-up-cluster.sh: ability to configure auth webhooks
 2019-09-24 08:58:34 -07:00
Kubernetes Prow Robot
6c9d3a6ea9
Merge pull request #83031 from Katharine/specify-coverage-dir 
Add KUBE_COVER_REPORT_DIR to specify coverage output dir.
 2019-09-24 00:25:52 -07:00
Mark Janssen
1a1b7001d6 Fix staticcheck failures for scheduler packages 
Errors from staticcheck:
cmd/kube-scheduler/app/server.go:297:27: prometheus.Handler is deprecated: Please note the issues described in the doc comment of InstrumentHandler. You might want to consider using promhttp.Handler instead.  (SA1019)
pkg/apis/scheduling/v1alpha1/defaults.go:27:6: func addDefaultingFuncs is unused (U1000)
pkg/apis/scheduling/v1beta1/defaults.go:27:6: func addDefaultingFuncs is unused (U1000)
test/e2e/scheduling/predicates.go:757:6: func verifyReplicasResult is unused (U1000)
test/e2e/scheduling/predicates.go:765:6: func getPodsByLabels is unused (U1000)
test/e2e/scheduling/predicates.go:772:6: func runAndKeepPodWithLabelAndGetNodeName is unused (U1000)
test/e2e/scheduling/limit_range.go:172:3: this value of pod is never used (SA4006)
test/e2e/scheduling/limit_range.go:177:3: this value of pod is never used (SA4006)
test/e2e/scheduling/limit_range.go:196:3: this value of pod is never used (SA4006)
test/e2e/scheduling/limit_range.go:201:3: this value of pod is never used (SA4006)
test/e2e/scheduling/limit_range.go:240:3: this value of pod is never used (SA4006)
test/e2e/scheduling/taints.go:428:13: this value of err is never used (SA4006)
test/e2e/scheduling/ubernetes_lite.go:219:2: this value of pods is never used (SA4006)
test/integration/scheduler/extender_test.go:78:4: this value of resp is never used (SA4006)
test/integration/volumescheduling/volume_binding_test.go:529:15: this result of append is never used, except maybe in other appends (SA4010)
test/integration/volumescheduling/volume_binding_test.go:538:15: this result of append is never used, except maybe in other appends (SA4010)
 2019-09-23 22:52:57 +02:00
Mark Janssen
345e528c86 Fix staticcheck failures for pkg/scheduler/... 2019-09-23 22:49:59 +02:00
Katharine Berry
a6e25d5e67 Add KUBE_COVER_REPORT_DIR to specify coverage output dir. 2019-09-23 10:36:00 -07:00
Amir Ghassemi
2550b31beb hack/local-up-cluster.sh: ability to configure auth webhooks 
AUTHORIZATION_WEBHOOK_CONFIG_FILE and AUTHENTICATION_WEBHOOK_CONFIG_FILE
if set, will pass webhook configuration paths to API server
 2019-09-23 10:43:47 +03:30
Kubernetes Prow Robot
dcf94c6d33
Merge pull request #82947 from notpad/master 
Replace hyperkube with apiserver for binary path guess
 2019-09-22 22:49:22 -07:00
Uzuku
5a2e6bd000 Fix golint failures of pkg/kubelet/status/... 2019-09-21 23:43:37 +08:00
Kubernetes Prow Robot
946df1a914
Merge pull request #81932 from palnabarun/fix-staticcheck-tests-e2e_node 
Fixes static check failures in test/e2e_node/*
 2019-09-20 22:55:37 -07:00
Kubernetes Prow Robot
3a55875465
Merge pull request #81512 from odinuge/preemptible-node-tests 
Add support for preemptible instances in node-e2e
 2019-09-20 22:55:24 -07:00
Kubernetes Prow Robot
23ec5b6e9e
Merge pull request #82357 from beautytiger/fix_shellcheck_config-common.sh 
fix shellcheck in cluster/gce/config-common.sh
 2019-09-20 16:17:24 -07:00
Kubernetes Prow Robot
a2760c9c13
Merge pull request #78110 from praseodym/fix-golint-pkg/kubelet/qos 
Fix golint failures of pkg/kubelet/qos
 2019-09-20 09:41:46 -07:00
liuweixuan
ce25cd7fca Replace hyperkube with apiserver for binary path guess 2019-09-20 23:28:58 +08:00
chenyaqi01
3175c9e226 simplify regexp with raw string 2019-09-20 16:53:56 +08:00
Kubernetes Prow Robot
d05183be41
Merge pull request #82858 from hwdef/del-unused-var 
delete unused var
 2019-09-19 11:05:49 -07:00
hwdef
4e7ef9ad36 delete unused var 2019-09-19 18:04:13 +08:00
Kubernetes Prow Robot
9ac74b2a92
Merge pull request #82273 from beautytiger/goreg_fix 
fix regex for go file, make it more accurate
 2019-09-18 20:43:13 -07:00
Kubernetes Prow Robot
257040c472
Merge pull request #81882 from phenixblue/master 
Updates to resolve shellcheck issues in hack/lib/test.sh
 2019-09-18 20:43:00 -07:00
Guangming Wang
cd929a98a0 fix shellcheck in cluster/gce/config-common.sh 
add comment for exported values
 2019-09-19 00:03:16 +08:00