Commit Graph

8347 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
614aab80f5
Merge pull request #78740 from oomichi/extend-check
Make the check strict to use ExpectNoError()
2019-07-30 01:59:04 -07:00
Sean Sullivan
a1de0e9331 Move pkg/kubectl/metricsutil to staging 2019-07-29 16:26:10 -07:00
Sean Sullivan
6c96a059dd Move pkg/kubectl/cmd/util and subdirs to staging 2019-07-29 13:08:41 -07:00
Aldo Culquicondor
a626a2972e Fix/Add comments on cadvisor implementations
Fix lint issues.

Signed-off-by: Aldo Culquicondor <acondor@google.com>
2019-07-29 09:31:35 -04:00
Kubernetes Prow Robot
12e462b21a
Merge pull request #80656 from seans3/move-kubectl-version
Move pkg/kubectl/version to staging
2019-07-27 07:33:56 -07:00
RainbowMango
0e0e1f7dab 1. Fix lint errors for the whole directory staging/src/k8s.io/client-go/tools/cache;
2. Remove staging/src/k8s.io/client-go/tools/cache from .golint_failures;
3. Fix some typo from comments.
2019-07-27 15:49:03 +08:00
Sean Sullivan
fb44be2d97 Move pkg/kubectl/version to staging 2019-07-26 15:48:09 -07:00
Sean Sullivan
49f5b423cf Move pkg/kubectl/describe to staging 2019-07-26 10:41:49 -07:00
Sean Sullivan
70984d8385 Moves pkg/kubectl/util/i18n to staging 2019-07-25 23:09:34 -07:00
Kubernetes Prow Robot
b234dd06aa
Merge pull request #80548 from seans3/move-kubectl-history
Move some pkg/kubectl into polymorphichelpers
2019-07-25 20:48:49 -07:00
Kubernetes Prow Robot
a172e197b1
Merge pull request #77355 from apelisse/test-new-protoc
Use new reverse protobuf marshalling
2019-07-25 16:01:14 -07:00
Kubernetes Prow Robot
d793279dee
Merge pull request #80094 from ZP-AlwaysWin/dev03
Fix golint failure in pkg/quota/v1/evaluator/core
2019-07-25 14:34:24 -07:00
Antoine Pelisse
170bcd9262 Fix pkg-names script that doesn't select files properly 2019-07-25 11:54:00 -07:00
Sean Sullivan
775b670e8b Move some pkg/kubectl into polymorphichelpers 2019-07-25 11:36:04 -07:00
Kubernetes Prow Robot
bf2dd03083
Merge pull request #80318 from davidxia/fix-err-caps
cleanup: fix some log and error capitalizations
2019-07-25 10:41:28 -07:00
Rostislav M. Georgiev
8157c4c4a8 Remove unused package //pkg/util/normalizer
Signed-off-by: Rostislav M. Georgiev <rostislavg@vmware.com>
2019-07-25 15:36:00 +03:00
Kubernetes Prow Robot
eb6bcfb345
Merge pull request #80096 from ZP-AlwaysWin/dev05
Fix golint failure in pkg/util/netsh/testing/
2019-07-23 17:14:41 -07:00
Kubernetes Prow Robot
0ba6ecca72
Merge pull request #77155 from draveness/feature/refactor-util-service
refactor: move service related functions in service pkg
2019-07-23 15:52:15 -07:00
David Xia
fabfd950b1
cleanup: fix some log and error capitalizations
Part of https://github.com/kubernetes/kubernetes/issues/15863
2019-07-20 18:26:16 -04:00
Kubernetes Prow Robot
3c332a9487
Merge pull request #80125 from sttts/sttts-bazel-openapi-fix
bazel: add openapi generation for non-main spec and fix main spec
2019-07-19 14:25:50 -07:00
ZP-AlwaysWin
a988719722 Fix golint failure in pkg/util/netsh/testing/ 2019-07-19 16:03:44 +08:00
draveness
c38ae01f8e feat: move service_util to separated package 2019-07-19 08:32:39 +08:00
Xiangyang Chu
313044abd7 Fix shellcheck failures in test/cmd/l.*.sh 2019-07-17 17:07:22 +08:00
Xiangyang Chu
3a344c7168 Fix shellcheck failures in test/cmd/d.*.sh 2019-07-17 17:07:22 +08:00
Kubernetes Prow Robot
8e3a2f2a5b
Merge pull request #80165 from SataQiu/fix-kubeadm-20190715
kubeadm: fix the bug that bazel build does not respect hack/print-workspace-status.sh
2019-07-16 03:55:24 -07:00
Kubernetes Prow Robot
7163dcbf3f
Merge pull request #80189 from wongma7/audit-local-up
Fix no audit policy by default in hack/local-up-cluster.sh
2019-07-15 21:51:37 -07:00
SataQiu
298909e20e kubeadm: use local copy of kubectl's version package 2019-07-16 09:51:10 +08:00
Matthew Wong
e18f7a9ec6 Fix no audit policy by default in hack/local-up-cluster.sh 2019-07-15 23:52:32 +00:00
Kubernetes Prow Robot
b8a10b4e12
Merge pull request #79753 from alejandrox1/framework-metrics
Refactored metrics-related functions from framework/metrics_util.go
2019-07-15 14:54:02 -07:00
Dr. Stefan Schimanski
53a7dcdee9 bazel: add openapi generation for non-main spec and fix main spec 2019-07-13 16:18:32 +02:00
Kubernetes Prow Robot
25ab6d82ec
Merge pull request #79645 from wojtek-t/cleanup_etcd_dir_3
Move etcd/util to etcd3/
2019-07-12 22:39:04 -07:00
Dr. Stefan Schimanski
e920d9bc14 Makefile.generated_files: build code-generator+sample-apiserver OpenAPI schemas 2019-07-12 20:52:21 +02:00
ZP-AlwaysWin
c690591a60 Fix golint failure in pkg/quota/v1/evaluator/core 2019-07-12 21:25:04 +08:00
Kubernetes Prow Robot
3dd8add5d2
Merge pull request #79549 from liggitt/admission-webhooks-v1
Promote admission webhook API to v1
2019-07-11 17:01:34 -07:00
Kubernetes Prow Robot
f2093cc383
Merge pull request #79366 from yastij/dep-path-update-yaml
reference paths to bump dependencies
2019-07-10 18:49:06 -07:00
Clayton Coleman
bc89c37f32
Add fake client, informer factory, and lister to metadata client
These will be used by the garbage collector controller and others that
use higher level primitives.
2019-07-10 14:31:18 -04:00
Yassine TIJANI
4bed9b7046 reference paths to update to bump dependencies
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
2019-07-10 20:11:40 +02:00
Mike Danese
b9c7007ca0 enable token review when openapi is generated 2019-07-09 13:45:41 -07:00
Kubernetes Prow Robot
5a7e336689
Merge pull request #79944 from liggitt/golang-deps
Allow hack/lint-dependencies.sh to skip golang.org/x/... deps, verify in verify-vendor.sh
2019-07-09 12:17:30 -07:00
Jordan Liggitt
dd2766251a Allow hack/lint-dependencies.sh to skip golang.org/x/... deps, verify in verify-vendor.sh 2019-07-09 14:07:55 -04:00
Kubernetes Prow Robot
d228123ad6
Merge pull request #79840 from sttts/sttts-chain-prepare-run
apiserver: chain delegated PrepareRun
2019-07-08 20:30:14 -07:00
alejandrox1
348fd0805e Refactored metrics-related functions from framework/metrics_util.go
This a refactoring of framework/metrics_utils.go into framework/metrics.

Signed-off-by: alejandrox1 <alarcj137@gmail.com>
2019-07-08 19:35:10 -04:00
Kubernetes Prow Robot
17e9b21001
Merge pull request #79790 from ramnar/master
Remove duplicate error messages
2019-07-08 16:00:27 -07:00
Anish Ramasekar
2878270f5b
Fix golint failures in pkg/proxy
Review feedback - remove alias from imports

fix comments
2019-07-08 11:48:33 -07:00
Jordan Liggitt
e24377f190 Install/register v1 admission registration types 2019-07-08 09:49:29 -04:00
Dr. Stefan Schimanski
f82bc712de aggregator: wire OpenAPI correctly into PrepareRun flow 2019-07-08 13:59:00 +02:00
Haines Chan
2d3893d2c1 Fix wrong indentation in shell 2019-07-05 17:11:15 +08:00
Davanum Srinivas
543093e775
Add go-runner to the list of e2e test targets
Change-Id: I9c837d8f0a74014434308b46291ad1f81d67109a
2019-07-04 13:34:44 -04:00
ramnar
fd9dd13cc2
Remove duplicate error messages
Remove duplicate error messages when command fails
2019-07-04 17:25:33 +05:30
Kubernetes Prow Robot
8f7bb1fe71
Merge pull request #79321 from shufanhao/fix_golint_issue_for_network
Fix golint failure in pkg/kubelet/dockershim/network/cni
2019-07-03 13:52:26 -07:00
Kubernetes Prow Robot
3c38115a32
Merge pull request #79045 from odinuge/file-perms
Fix file permissions for non executable files
2019-07-03 09:12:45 -07:00
Benjamin Elder
675f4bb642 correct flag order in make-help 2019-07-02 23:42:01 -07:00
fanhao01
24a95a6c3e Fix golint failure in pkg/kubelet/dockershim/network/cni 2019-07-03 12:57:24 +08:00
Kubernetes Prow Robot
e79dcc2174
Merge pull request #79284 from johnSchnake/conformanceGoRunner
Adds an optional golang runner to the conformance test image
2019-07-02 15:41:11 -07:00
wojtekt
23d9d6b1d0 Move etcd/util to etcd3/ 2019-07-02 10:39:12 +02:00
Kubernetes Prow Robot
6d8dd21111
Merge pull request #79594 from wojtek-t/cleanup_etcd_dir_2
Cleanup etcd directory - part 2
2019-07-01 21:33:34 -07:00
John Schnake
b3f5a086ab Adds an optional golang runner to the conformance test image
Adds a go app which runs the e2e tests with ginkgo.

 - Supports all the existing env vars of the bash script
 - Improved flow control to avoid and better report issues
regarding the process PID
 - Adds flags for modifying where to find the test binary and
ginkgo binary so that you can run it locally
 - Adds 3 flags for specifying extra args before the double-dash,
extra args after the double-dash, and the seperator to use between
values in those env vars. This allows setting arbitrary, complex
values for use on the command such as flags which include spaces
or other characters.
2019-07-01 16:26:13 -05:00
Odin Ugedal
65d93bbe48
Fix ordering settings in verify bazel
In coreutils LC_ALL=C is required to make sorting stable across
platoforms and locales.

$ echo "a-c\nabc" | LANG=C LC_ALL=C sort
a-c
abc

$ echo "a-c\nabc" | LANG=C sort
abc
a-c
2019-07-01 20:17:35 +02:00
wojtekt
7497260e54 Move etcd/testing to etcd3/testing 2019-07-01 15:02:49 +02:00
Kubernetes Prow Robot
6a2d0f67d1
Merge pull request #79527 from wojtek-t/cleanup_etcd_dir_1
Cleanup etcd code
2019-06-29 07:37:22 -07:00
wojtekt
cba13eb9ad Autogenerate code 2019-06-29 15:26:09 +02:00
Kubernetes Prow Robot
5154a61325
Merge pull request #79374 from Huang-Wei/podpriority-cleanup
followup of 79262 to cleanup PodPriority leftover
2019-06-28 21:01:23 -07:00
Kubernetes Prow Robot
2837c32d60
Merge pull request #79543 from BenTheElder/bash-failure
fix hack/update-vendor.sh array expansion
2019-06-28 19:21:37 -07:00
Wei Huang
6f10758446
followup of 79262 to cleanup PodPriority leftover 2019-06-28 14:19:26 -07:00
Benjamin Elder
b388865c00 fix hack/update-vendor.sh array expansion 2019-06-28 14:01:38 -07:00
Kubernetes Prow Robot
7334492260
Merge pull request #79502 from BenTheElder/silent-errors
suppress libseccomp pkg-config errors
2019-06-28 13:57:54 -07:00
Kubernetes Prow Robot
9fbf364a13
Merge pull request #79506 from BenTheElder/auto-mark-integration
automatically tag tests in test/integration/* as integration
2019-06-28 10:03:38 -07:00
Kubernetes Prow Robot
ce9d4a947e
Merge pull request #79500 from BenTheElder/node-run-tests
fix shellcheck failures in test/e2e_node/conformance/run_test.sh
2019-06-28 08:05:51 -07:00
Andrea Nodari
1da7f0fc12 Remove tests/e2e/scalability from the list of golint failures 2019-06-28 12:33:06 +01:00
Benjamin Elder
5c6d68caba automatically tag tests in test/integration/* as integration 2019-06-27 23:19:06 -07:00
Benjamin Elder
74939b6b17 supress libseccomp pkg-config errors 2019-06-27 22:52:48 -07:00
Kubernetes Prow Robot
9138fa5805
Merge pull request #79190 from falcon78921/wip-k8s-hack-fix
hack: fixed issues from previous refactor PR
2019-06-27 21:19:20 -07:00
Benjamin Elder
30bf22c10e fix shellcheck failures in test/e2e_node/conformance/run_test.sh 2019-06-27 21:12:08 -07:00
Kubernetes Prow Robot
85aaf7ea36
Merge pull request #79407 from BenTheElder/super-minor-shellcheck
clarify elasticsearch script as bash
2019-06-27 18:53:45 -07:00
Kubernetes Prow Robot
d86823a75f
Merge pull request #79320 from BenTheElder/more-swagger
fix hack/lib/swagger.sh, hack/lib/init.sh, hack/lib/version.sh shellcheck failures
2019-06-27 18:53:33 -07:00
Kubernetes Prow Robot
e74f75a98b
Merge pull request #79448 from falcon78921/wip-k8s-boilerplate
hack/boilerplate: added regex to strip Python shebang
2019-06-27 17:43:59 -07:00
Kubernetes Prow Robot
22305274d3
Merge pull request #79410 from BenTheElder/always-restore-etcd-with-spooky-bash
fix shellcheck failures in cluster/restore-from-backup.sh
2019-06-27 17:43:46 -07:00
Kubernetes Prow Robot
dfb7748542
Merge pull request #78347 from obitech/fix_golint_pkg_kubelet_prober
Fix golint issues in pkg/kubelet/{prober,secret}
2019-06-27 17:43:21 -07:00
James McClune
452c7be40e hack/boilerplate: added regex to strip Python shebang
Fixes Prow Build Error:
Boilerplate header is wrong for: /home/prow/go/src/k8s.io/kubernetes/hack/update_owners.py

Signed-off-by: James McClune <jmcclune@mcclunetechnologies.net>
2019-06-26 21:10:44 -04:00
Benjamin Elder
59c4eb2a38 fix hack/lib/version.sh shellcheck failures 2019-06-26 09:20:17 -07:00
David Eads
c1f8f6230b remove dead KUBE_TEST_API_VERSIONS from test-integration 2019-06-26 11:55:50 -04:00
Benjamin Elder
6fe891b737 fix shellcheck failures in cluster/restore-from-backup.sh 2019-06-25 23:45:07 -07:00
Benjamin Elder
1a28fbde4d clarify elastisearch script as bash 2019-06-25 22:19:45 -07:00
Benjamin Elder
9b4b5098e1 fix hack/lib/init.sh shellcheck failures 2019-06-25 22:09:32 -07:00
Benjamin Elder
a101acc7eb fix hack/lib/swagger.sh shellcheck failures 2019-06-25 22:09:31 -07:00
Kubernetes Prow Robot
c58f94caf1
Merge pull request #79318 from BenTheElder/old-skool
fix hack/make-rules/make-help.sh shellcheck failures
2019-06-25 18:16:04 -07:00
Kubernetes Prow Robot
4ca3974953
Merge pull request #79287 from BenTheElder/libseccomp
update Libseccomp to tagged release (0.9.1)
2019-06-25 11:44:23 -07:00
Benjamin Elder
0fad8eb36c fix hack/make-rules/make-help.sh shellcheck failures 2019-06-25 09:49:45 -07:00
Kubernetes Prow Robot
38e95b1a78
Merge pull request #79317 from BenTheElder/yikeshell
fix test/e2e_node/gubernator.sh shellcheck failures
2019-06-25 01:15:29 -07:00
Kubernetes Prow Robot
dac0bd9029
Merge pull request #79316 from BenTheElder/shellll
fix vendor scripts shellcheck failures
2019-06-25 01:15:16 -07:00
James McClune
9c45e799ad hack: fixed issues from previous refactor PR
Fixed pathlib definitions & print statements, thanks to another
GitHub member.

Signed-off-by: James McClune <jmcclune@mcclunetechnologies.net>
2019-06-24 21:33:00 -04:00
Benjamin Elder
4aaa7b4da2 document KUBE_ROOT in util.sh 2019-06-24 11:43:04 -07:00
Benjamin Elder
7e96be30ca fix hack/verify-no-vendor-cycles.sh shellcheck failures 2019-06-24 11:43:04 -07:00
Benjamin Elder
1741d9393d fix hack/pin-dependency.sh shellcheck failures 2019-06-24 11:43:04 -07:00
Benjamin Elder
47daf195a4 fix hack/update-vendor.sh shellcheck failures 2019-06-24 11:43:04 -07:00
Benjamin Elder
29b7b2c4f8 add kube::util::list_staging_repos 2019-06-24 11:43:04 -07:00
Benjamin Elder
d596093925 automatically set clinkopts 2019-06-24 11:11:44 -07:00
Nikhita Raghunath
ab3cdd57b7 publishing: use deps in replace directive in rules
The list of dependencies for a repo right now is equal to the list of deps
mentioned in the require directive in the repo's go.mod file.
This means that we loose all transitive deps mentioned in the replace
directive in go.mod files.

So instead use all deps mentioned in the replace directive, and prune
any extra dependencies.

Also add a test for this in verify-publishing-bot.py
2019-06-24 14:01:20 +05:30
Benjamin Elder
21d1d273c8 fix test/e2e_node/gubernator.sh shellcheck failures 2019-06-23 17:01:54 -07:00
Benjamin Elder
c8a6a720c3 use kube::util::md5 for update-vendor-licenses.sh 2019-06-23 12:08:05 -07:00
Benjamin Elder
7b0ea99a3e copy kube::release:md5 to kube::util::md5 2019-06-23 12:08:05 -07:00
Jordan Liggitt
6ca80760fd Switch test manifests to apps/v1, remove beta workloads calls 2019-06-22 13:58:07 -07:00
Kubernetes Prow Robot
3c7e2a7221
Merge pull request #78718 from SataQiu/fix-golint-20190605
Fix some golint failures of pkg/registry
2019-06-21 18:52:37 -07:00
Kubernetes Prow Robot
2bb849fdc0
Merge pull request #79199 from k-toyoda-pi/local-up-cluster_change_sed_to_SED
use ${SED} variable in local-up-cluster.sh
2019-06-21 05:10:36 -07:00
Kubernetes Prow Robot
0f2b01ab33
Merge pull request #78022 from xychu/fix-shellchecks-g
Fix shellcheck failures in test/cmd/g.*sh
2019-06-20 20:46:35 -07:00
Kubernetes Prow Robot
5a7b978c74
Merge pull request #79192 from pswica/util-term
Move pkg/kubectl/util/term, pkg/kubectl/util/interrupt, pkg/kubectl/util/templates to staging
2019-06-20 17:14:47 -07:00
Peter Swica
123fa89f21 Moved pkg/kubectl/util/term, pkg/kubectl/util/templates, pkg/kubectl/util/interrupt, and pkg/kubectl/util/interrupt to staging 2019-06-20 15:50:16 -04:00
Aaron Crickenberger
72093011c4 add import-alias for k8s.io/kubernetes/pkg/scheduler/apis/config/v1alpha1 2019-06-20 11:41:30 -07:00
Aaron Crickenberger
946a90904f add import-alias for k8s.io/kubernetes/pkg/proxy/apis/config/v1alpha1 2019-06-20 11:41:28 -07:00
Aaron Crickenberger
f03781c8b1 add import-alias for k8s.io/kubernetes/pkg/kubelet/apis/stats/v1alpha1 2019-06-20 11:41:25 -07:00
Aaron Crickenberger
cb88d87dab add import-alias for k8s.io/kubernetes/pkg/kubelet/apis/resourcemetrics/v1alpha1 2019-06-20 11:41:23 -07:00
Aaron Crickenberger
4ca8821154 add import-alias for k8s.io/kubernetes/pkg/kubelet/apis/podresources/v1alpha1 2019-06-20 11:41:21 -07:00
Aaron Crickenberger
6f141d879e add import-alias for k8s.io/kubernetes/pkg/kubelet/apis/pluginregistration/v1beta1 2019-06-20 11:41:19 -07:00
Aaron Crickenberger
e8f5f399f4 add import-alias for k8s.io/kubernetes/pkg/kubelet/apis/pluginregistration/v1alpha1 2019-06-20 11:41:16 -07:00
Aaron Crickenberger
833a4aaf6b add import-alias for k8s.io/kubernetes/pkg/kubelet/apis/pluginregistration/v1 2019-06-20 11:41:14 -07:00
Aaron Crickenberger
4d5d5b71d2 add import-alias for k8s.io/kubernetes/pkg/kubelet/apis/deviceplugin/v1beta1 2019-06-20 11:41:12 -07:00
Aaron Crickenberger
d448651e9d add import-alias for k8s.io/kubernetes/pkg/kubelet/apis/deviceplugin/v1alpha 2019-06-20 11:41:09 -07:00
Aaron Crickenberger
339a0506e0 add import-alias for k8s.io/kubernetes/pkg/kubelet/apis/config/v1beta1 2019-06-20 11:41:07 -07:00
Aaron Crickenberger
44367bfc14 add import-alias for k8s.io/kubernetes/pkg/controller/apis/config/v1alpha1 2019-06-20 11:41:04 -07:00
Aaron Crickenberger
efe97e4b0a add import-alias for k8s.io/api/storage/v1beta1 2019-06-20 11:41:02 -07:00
Aaron Crickenberger
b6fbfbbb57 add import-alias for k8s.io/api/storage/v1alpha1 2019-06-20 11:40:59 -07:00
Aaron Crickenberger
9a6600f9f4 add import-alias for k8s.io/api/storage/v1 2019-06-20 11:40:57 -07:00
Aaron Crickenberger
35cef7369e add import-alias for k8s.io/api/settings/v1alpha1 2019-06-20 11:40:54 -07:00
Aaron Crickenberger
73287fa721 add import-alias for k8s.io/api/scheduling/v1beta1 2019-06-20 11:40:51 -07:00
Aaron Crickenberger
20675803b3 add import-alias for k8s.io/api/scheduling/v1alpha1 2019-06-20 11:40:49 -07:00
Aaron Crickenberger
9d5aac1845 add import-alias for k8s.io/api/scheduling/v1 2019-06-20 11:40:47 -07:00
Aaron Crickenberger
e4716f397a add import-alias for k8s.io/api/rbac/v1beta1 2019-06-20 11:40:44 -07:00
Aaron Crickenberger
4228000e60 add import-alias for k8s.io/api/rbac/v1alpha1 2019-06-20 11:40:42 -07:00
Aaron Crickenberger
32f8aef97b add import-alias for k8s.io/api/rbac/v1 2019-06-20 11:40:39 -07:00
Aaron Crickenberger
1d0d98dbc5 add import-alias for k8s.io/api/policy/v1beta1 2019-06-20 11:40:37 -07:00
Aaron Crickenberger
9c02d21d2d add import-alias for k8s.io/api/node/v1beta1 2019-06-20 11:40:34 -07:00
Aaron Crickenberger
0ba9e9144a add import-alias for k8s.io/api/node/v1alpha1 2019-06-20 11:40:31 -07:00
Aaron Crickenberger
40d0fbd682 add import-alias for k8s.io/api/networking/v1beta1 2019-06-20 11:40:29 -07:00
Aaron Crickenberger
9d6a045bf1 add import-alias for k8s.io/api/networking/v1 2019-06-20 11:40:27 -07:00
Aaron Crickenberger
9d90a0231f add import-alias for k8s.io/api/imagepolicy/v1alpha1 2019-06-20 11:40:24 -07:00
Aaron Crickenberger
2a8bee4b37 add import-alias for k8s.io/api/extensions/v1beta1 2019-06-20 11:40:21 -07:00
Aaron Crickenberger
6b39285307 add import-alias for k8s.io/api/events/v1beta1 2019-06-20 11:40:18 -07:00
Aaron Crickenberger
b8d0ce4019 add import-alias for k8s.io/api/core/v1 2019-06-20 11:40:15 -07:00
Aaron Crickenberger
f3fd3cff8e add import-alias for k8s.io/api/coordination/v1beta1 2019-06-20 11:40:12 -07:00
Aaron Crickenberger
ee6e6179da add import-alias for k8s.io/api/coordination/v1 2019-06-20 11:40:09 -07:00
Aaron Crickenberger
291658725b add import-alias for k8s.io/api/certificates/v1beta1 2019-06-20 11:40:06 -07:00
Aaron Crickenberger
4b38206230 add import-alias for k8s.io/api/batch/v1beta1 2019-06-20 11:40:04 -07:00
Aaron Crickenberger
03ad7d2d6f add import-alias for k8s.io/api/batch/v1 2019-06-20 11:40:01 -07:00
Aaron Crickenberger
9a9f224ba5 add import-alias for k8s.io/api/autoscaling/v1 2019-06-20 11:39:59 -07:00
Aaron Crickenberger
b36ee2bff1 add import-alias for k8s.io/api/authorization/v1beta1 2019-06-20 11:39:57 -07:00
Aaron Crickenberger
a4d08ada9c add import-alias for k8s.io/api/authorization/v1 2019-06-20 11:39:54 -07:00
Aaron Crickenberger
43d27a6422 add import-alias for k8s.io/api/authentication/v1beta1 2019-06-20 11:39:52 -07:00
Aaron Crickenberger
d3b2f4c514 add import-alias for k8s.io/api/authentication/v1 2019-06-20 11:39:49 -07:00
Aaron Crickenberger
426ffe0913 add import-alias for k8s.io/api/auditregistration/v1alpha1 2019-06-20 11:39:47 -07:00
Aaron Crickenberger
f38e47dd9d add import-alias for k8s.io/api/apps/v1beta2 2019-06-20 11:39:45 -07:00
Aaron Crickenberger
1ca8ebce4c add import-alias for k8s.io/api/apps/v1beta1 2019-06-20 11:39:43 -07:00
Aaron Crickenberger
0aae740ede add import-alias for k8s.io/api/apps/v1 2019-06-20 11:39:40 -07:00
Aaron Crickenberger
1aa22b8e22 add import-alias for k8s.io/api/admission/v1beta1 2019-06-20 11:39:38 -07:00
Aaron Crickenberger
ba36cc9ebb add import-alias for k8s.io/api/admissionregistration/v1beta1 2019-06-20 11:39:35 -07:00
obitech
cbdfccc9f8 Fix golint issues in pkg/kubelet/secret 2019-06-20 19:56:29 +02:00
obitech
b767b1b250 Fix golint issues in pkg/kubelet/prober/results 2019-06-20 19:55:15 +02:00
Kubernetes Prow Robot
ab3b24ac0a
Merge pull request #77798 from xychu/fix-shellchecks-b
Fix shellchecks in test/cmd/{b,c}.*.sh
2019-06-20 10:00:52 -07:00
Kubernetes Prow Robot
0ce16a3992
Merge pull request #79186 from oomichi/remove-mapfile
Replace mapfile with kube::util::read-array
2019-06-20 04:42:49 -07:00
Kubernetes Prow Robot
465e96535d
Merge pull request #78836 from dims/verify-import-aliases-during-typecheck
Verify import aliases
2019-06-19 21:11:01 -07:00
toyoda
d7215f0bce change sed to ${SED} in local-up-cluster.sh 2019-06-20 11:38:58 +09:00
Kubernetes Prow Robot
96a2f12b4e
Merge pull request #79088 from s-ito-ts/golint_e2e_storage_testsuites
Fix golint failures of test/e2e/storage/testsuites
2019-06-19 18:37:25 -07:00
Kenichi Omichi
5628b6b50e Replace mapfile with kube::util::read-array
During the review of https://github.com/kubernetes/kubernetes/pull/78779
we've known mapfile doesn't work on macOS.
So we need to use alternative way instead and this is it.
2019-06-20 00:25:06 +00:00
Kubernetes Prow Robot
c2ff62c28c
Merge pull request #78779 from odinuge/test-cleanup
Enforce test style on e2e_node and e2e_kubeadm tests
2019-06-19 14:56:49 -07:00
Kenichi Omichi
d5bc1ae8aa Make the check strict to use ExpectNoError()
As https://github.com/kubernetes/kubernetes/pull/78478 we can use
ExpectNoError() instead of Expect(err).ToNot(HaveOccurred()) also.
This makes the test code check strict to cover the above case and
replaces the remaining in test/e2e/common/expansion.go
2019-06-18 16:55:16 +00:00
Kubernetes Prow Robot
1545b28b58
Merge pull request #79097 from xychu/fix-shellchecks-n
Fix shellcheck failures in test/cmd
2019-06-18 01:08:15 -07:00
s-ito-ts
85ba101947 Fix golint failures of test/e2e/storage/testsuites 2019-06-18 03:02:46 +00:00
Yassine TIJANI
c3904bbce6 move initsystem to kubeadm
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
2019-06-17 12:21:01 +02:00
Xiangyang Chu
99b2184993 Fix shellcheck faulures in test/cmd
Including files after test/cmd/n*
2019-06-17 14:04:34 +08:00
Davanum Srinivas
a6f8d575ba
Add kubeletstatsv1alpha1 as the preferred alias for k8s.io/kubernetes/pkg/kubelet/apis/stats/v1alpha1
Change-Id: I05a8390a667dba307c09d95f836e08e0759c12ee
2019-06-15 22:31:51 -04:00
Davanum Srinivas
9f0050cb44
verify import aliases
- Added scripts for update and verify
- golang AST code for scanning and fixing imports
- default regex allows it to run on just test/e2e.* file paths
- exclude verify-import-aliases.sh from running in CI jobs

Change-Id: I7f9c76f5525fb9a26ea2be60ea69356362957998
Co-Authored-By: Aaron Crickenberger <spiffxp@google.com>
2019-06-15 22:31:39 -04:00
Kubernetes Prow Robot
1493757d69
Merge pull request #79031 from liggitt/suppress-error-message
Suppress irrelevant jq error message when propagating pinned dependencies
2019-06-15 12:56:59 -07:00
Kubernetes Prow Robot
088411f77f
Merge pull request #78978 from sttts/sttts-staging-unit-tests
hack/make-rules/test.sh: run all staging unit tests
2019-06-15 03:46:24 -07:00
Kubernetes Prow Robot
480457994d
Merge pull request #78015 from SataQiu/fix-golint-kubelet-20190517
Fix golint failures of pkg/kubelet/configmap pkg/kubelet/custommetrics
2019-06-15 00:46:09 -07:00
qingsenLi
7a0efd326b fix golint failures for pkg/volume/scaleio and pkg/volume/storageos 2019-06-15 10:53:50 +08:00
Kubernetes Prow Robot
f75bfe9f58
Merge pull request #78666 from aojea/shellcheck
Fix verify-shellcheck comments
2019-06-14 13:26:35 -07:00
Odin Ugedal
35cb87f9cf
Fix file permissions for non executable files
Normal files should have permissions 644 by default,
and does not require the last bit to be
executable

Signed-off-by: Odin Ugedal <odin@ugedal.com>
2019-06-14 21:04:50 +02:00
Kubernetes Prow Robot
9f1548cdd9
Merge pull request #78656 from liggitt/compatibility-test-cleanup
Add helper script to regenerate API compatibility data, testdata README
2019-06-14 11:53:15 -07:00
Odin Ugedal
b0a1cba71a
Run verify-test-code on all e2e tests 2019-06-14 17:51:49 +02:00
Kubernetes Prow Robot
a08084d475
Merge pull request #78571 from SataQiu/fix-golint-kubelet-20190531
Fix golint failures of pkg/kubelet/prober pkg/kubelet/secret
2019-06-14 05:32:51 -07:00
Kubernetes Prow Robot
08922a1399
Merge pull request #78148 from endyman/fix-golint-test/e2e/storage/utils
fix golint errors in test/e2e/storage/utils
2019-06-14 02:50:51 -07:00
Kubernetes Prow Robot
d30fbab4b8
Merge pull request #77915 from SataQiu/fix-golint-util-20190515
Fix golint failures of pkg/util/parsers pkg/util/sysctl pkg/util/system
2019-06-14 00:29:00 -07:00
Kubernetes Prow Robot
3b9c761212
Merge pull request #75928 from falcon78921/wip-k8s-cleanup
hack: refactored code in update_owners.py
2019-06-13 20:37:00 -07:00
Kubernetes Prow Robot
0f5650d68b
Merge pull request #75859 from k-toyoda-pi/fix_shellcheck_failure_make-rules
fix shellcheck failures in /hack/make-rules/test.sh
2019-06-13 20:36:47 -07:00
Kubernetes Prow Robot
8305729d7a
Merge pull request #74635 from xychu/fix-with-assert
Fix shellchecks follow the `${var:?}` pattern
2019-06-13 19:12:45 -07:00
Dr. Stefan Schimanski
e2c6bc35a9 hack/make-rules/test.sh: run all staging unit tests 2019-06-13 14:07:37 +02:00
Jordan Liggitt
696eb32d4b Suppress irrelevant jq error message when propagating pinned dependencies 2019-06-10 13:09:12 -04:00
Davanum Srinivas
e0821ca3dd
Remove ovirt/cloudstack/photon cloud providers
Change-Id: Iddb80bdc2a9d75d444b8a3cfe0b142acb78e9097
2019-06-10 12:50:53 -04:00
SataQiu
213d07af8d fix some golint failures of pkg/registry 2019-06-05 15:29:59 +08:00
Xiangyang Chu
81eb22900b Fix shellchecks in test/cmd/{b,c}.*.sh 2019-06-04 14:42:01 +08:00
Antonio Ojea
bd65a9ca26
Fix verify-shellcheck comments
Replace  "files" instead of packages in the script
hack/verify-shellcheck.sh
2019-06-03 23:58:52 +02:00
Jordan Liggitt
7a96057755 Add helper script to regenerate API compatibility data 2019-06-03 10:18:08 -04:00
Kubernetes Prow Robot
c449dbf128
Merge pull request #78518 from dims/tolerate-missing-pyyaml-dependency
Bail out on missing pyyaml dependency
2019-06-01 08:00:32 -07:00
Kubernetes Prow Robot
bada1c6b1e
Merge pull request #78505 from caesarxuchao/dynamic-object-selector
Adding ObjectSelector to admission webhooks
2019-06-01 04:45:09 -07:00
Kubernetes Prow Robot
ebdae0b3b7
Merge pull request #78485 from oomichi/add-use-ExpectError
Check e2e test code to use ExpectError()
2019-06-01 02:54:42 -07:00
Davanum Srinivas
a1e511abda
Bail out on missing pyyaml dependency
Change-Id: Ib1e3b92f8e18ae554f77fede34917d5222c677af
2019-05-31 10:16:11 -04:00
Kubernetes Prow Robot
e87679cfaa
Merge pull request #74733 from wk8/wk8/misc_fixes
Not asking for sudo passwords for password-less sudo users any more
2019-05-31 07:12:43 -07:00
Kubernetes Prow Robot
fe37733a12
Merge pull request #73891 from taragu/plugin-manager
Add kubelet plugin manager
2019-05-31 07:12:29 -07:00
SataQiu
c6a0f820d8 fix golint failures of pkg/kubelet/prober pkg/kubelet/secret 2019-05-31 17:08:53 +08:00
wangqingcan
52f3380ef3 change preempting to PreemptionPolicy 2019-05-31 12:42:05 +08:00
wangqingcan
5c9438c691 non-preempting-priorityclass
Co-authored-by: Vallery Lancey <vallery@zeitgeistlabs.io>
Co-authored-by: Tan shanshan <tan.shanshan@zte.com.cn>
2019-05-31 12:37:07 +08:00
Tara Gu
5e18554442 Implement plugin manager - a controller that manages plugin registration/unregistration 2019-05-30 19:00:59 -04:00
Joe Betz
55ecc45455 split admissionregistration.v1beta1/Webhook into MutatingWebhook and ValidatingWebhook 2019-05-30 14:31:09 -07:00
Kubernetes Prow Robot
b8eecd671d
Merge pull request #69941 from miguelbernadi/fix-golint-issues-68026
Fix golint issues in plugin/pkg/admission
2019-05-30 08:38:26 -07:00
Kubernetes Prow Robot
6dfec4a2ec
Merge pull request #78386 from SataQiu/fix-test-golint-20190527
Fix golint failures of test/e2e/chaosmonkey
2019-05-29 22:54:45 -07:00
Jean Rouge
1bd3d8b929 Not asking for sudo passwords for password-less sudo users any more
Running hack/make-rules/test-e2e-node.sh or test/e2e_node/conformance/run_test.sh
with a password-less sudo user on a dev box right now requires to first
create a password for that user, and then type it every time one wants
to run these tests. This patch is fixing this by not asking for sudo
credentials if it seems the user can run any command without a
password.

Signed-off-by: Jean Rouge <rougej+github@gmail.com>
2019-05-29 14:04:13 -07:00
Kubernetes Prow Robot
38468e4338
Merge pull request #70536 from mysunshine92/golint-hostpath
fix golint for pkg/volume/host_path
2019-05-29 11:25:46 -07:00
Kenichi Omichi
63e0507fd9 Check e2e test code to use ExpectError()
We can use framework.ExpectError() for checking the expected error
happens. However Expect(err).To(HaveOccurred()) can be used instead
and that makes the e2e test code unreadable.
This adds the check to use framework.ExpectError() for readable code.
2019-05-29 17:04:58 +00:00
Kubernetes Prow Robot
864e5e564a
Merge pull request #78354 from kaleocheng/fix-golint-pkg-apis-abac-latest
Fix golint issue in pkg/apis/abac/latest
2019-05-29 09:45:16 -07:00
Kubernetes Prow Robot
dcf2dd332a
Merge pull request #77612 from oomichi/add-check-test-code
Add hack/verify-test-code.sh
2019-05-29 05:33:00 -07:00
Kubernetes Prow Robot
501092c7d0
Merge pull request #78232 from SataQiu/fix-golint-20190523
Fix golint failures of pkg/controller/namespace/deletion pkg/controller/serviceaccount
2019-05-29 00:53:02 -07:00
James McClune
19fbb1356c hack: refactored code in update_owners.py
Introduced pathlib as an alternative to os.path. Updated the urllib2
module to urllib.request. Structured the code to align more with Python3.

Signed-off-by: James McClune <jmcclune@mcclunetechnologies.net>
2019-05-28 22:34:55 -04:00
Nils Domrose
cc93ec05e8 Merge branch 'master' of https://github.com/kubernetes/kubernetes into fix-golint-test/e2e/storage/utils 2019-05-28 22:18:42 +02:00
obitech
16d64d6925 Fix golint issues in pkg/kubelet/client
Add comments to exported functions in `pkg/kubelet/client/client.go`

In `KubeletClientConfig` rename `EnableHttps` to `EnableHTTPS`. This requires
renaming it in `pkg/kubelet/client/client_test.go`
2019-05-27 22:03:21 +02:00
SataQiu
a6e0614dd9 fix golint failures of test/e2e/chaosmonkey 2019-05-27 18:30:12 +08:00
Kaleo
e672fb6b6a Fix golint issue in pkg/apis/abac/latest 2019-05-26 16:30:35 +08:00
Dr. Stefan Schimanski
ab6eae3621 hack/verify-symbols: add TrackStorageCleanup from storage testing 2019-05-24 10:20:07 +02:00
Miguel Bernabeu
f47da8a75d Fix golint violations in several plugins 2019-05-23 20:00:06 +02:00
Dr. Stefan Schimanski
c487eb3551 hack/verify-symbols: fix nm call through go tool 2019-05-23 18:45:23 +02:00
SataQiu
b87d006a50 fix golint failures of pkg/controller/namespace/deletion pkg/controller/serviceaccount 2019-05-23 12:09:01 +08:00
Kubernetes Prow Robot
5666982b27
Merge pull request #77793 from SataQiu/fix-golint-client-go-20190513
Fix golint failures of client-go/tools/auth client-go/tools/portforward
2019-05-22 18:44:24 -07:00
Kubernetes Prow Robot
25b0d2dbf4
Merge pull request #78216 from mtaufen/update-klog
Update klog to v0.3.1
2019-05-22 15:14:49 -07:00
Kubernetes Prow Robot
4f33b5f421
Merge pull request #77820 from dims/charrywanganthony-pr-71835-delete-kubelet-security-controls
Remove deprecated Kubelet security controls
2019-05-22 13:52:25 -07:00
Michael Taufen
ee7bcc53a2 Update klog to v0.3.1
Includes recent fixes, notably https://github.com/kubernetes/klog/pull/66
2019-05-22 10:55:37 -07:00
Kenichi Omichi
496a18febc Add hack/verify-test-code.sh
This script checks coding style for test code.
It is useful to enforce developers to use framework methods for
keeping readable test code for example.
2019-05-22 14:15:25 +00:00
Kubernetes Prow Robot
3371378506
Merge pull request #78096 from SataQiu/fix-golint-test-20190520
Fix golint failures of test/e2e/storage/drivers
2019-05-22 04:00:52 -07:00
Kubernetes Prow Robot
ec0f8b843f
Merge pull request #77913 from s-ito-ts/golint_test_e2e_autoscaling
Fix golint failures of test/e2e/autoscaling
2019-05-22 04:00:25 -07:00
Kubernetes Prow Robot
932d8031ab
Merge pull request #77756 from jpbetz/crd-conversion-tests
Add webhook converter integration test suite
2019-05-22 02:40:12 -07:00
Joe Betz
e23769f018 Add webhook converter integration test suite 2019-05-21 13:07:44 -07:00
s-ito-ts
992773a4d9 Add transforming of "pillar['dns_memory_limit']" to local-up-cluster.sh. 2019-05-21 10:31:38 +00:00
Nils Domrose
d14c2cca8a fix golint errors in test/e2e/storage/utils 2019-05-21 11:11:21 +02:00
SataQiu
b828e570b1 fix golint failures of test/e2e/storage/drivers 2019-05-20 13:12:38 +08:00
s-ito-ts
c101f40e18 Fix golint failures of test/e2e/autoscaling 2019-05-20 02:20:39 +00:00
SataQiu
80bee6d965 fix golint failures of pkg/kubelet/configmap pkg/kubelet/custommetrics 2019-05-20 09:56:19 +08:00
hui luo
6c8aabc832 Check KUBE_SERVER_PLATFORMS existence
when compile kubectl on platform other than
linux/amd64, we need to check the KUBE_SERVER_PLATFORMS
array emptiness before assign it.

the example command is:
make WHAT=cmd/kubectl KUBE_BUILD_PLATFORMS="darwin/amd64 windows/amd64"
2019-05-18 09:17:22 -07:00
Christoph Blecker
b8481b62fc
Don't use declare -g in build 2019-05-17 12:22:42 -07:00
Kubernetes Prow Robot
d45cc1019e
Merge pull request #77985 from adisky/patch-2
fix unbound variable build/lib/release.sh bash 4.3
2019-05-17 10:12:21 -07:00
Kubernetes Prow Robot
46a80259f6
Merge pull request #77980 from SataQiu/fix-golint-test-20190516
Fix golint failures of test/e2e
2019-05-17 07:01:04 -07:00
Xiangyang Chu
eee32a6a88 Fix shellcheck failures in test/cmd/g.*sh 2019-05-17 15:40:14 +08:00
Kohei Toyoda
62d5eb524b
Merge branch 'master' into fix_shellcheck_failure_make-rules 2019-05-17 08:43:08 +09:00
adisky
7e2aa46f64
fix unbound variable release.sh 2019-05-16 23:09:19 +05:30
chaowang
9ba0d47465
Remove deprecated Kubelet security controls
Change-Id: I9f770e6780b60e881092690f6f177d726f474fe3
2019-05-16 13:33:52 -04:00
Kubernetes Prow Robot
06047953f2
Merge pull request #77910 from adisky/patch-1
fix hack/lib/golang.sh for bash 4.3
2019-05-16 08:48:39 -07:00
Kubernetes Prow Robot
dfcc60d4e5
Merge pull request #77908 from SataQiu/fix-golint-test-20190515
Fix golint failures of test/e2e_node/services
2019-05-16 08:48:26 -07:00
SataQiu
be8a072655 fix golint failures of test/e2e 2019-05-16 23:31:47 +08:00
Kubernetes Prow Robot
34aa283c65
Merge pull request #77643 from atoato88/fix-golint-e2e-framework-asterisk
Fix golint failures of e2e/framework/*.go
2019-05-16 01:10:21 -07:00
Kubernetes Prow Robot
aba8040669
Merge pull request #77189 from xiaojingchen/fix-golint-failures
Fix golint failures in cmd/kube-controller-manager
2019-05-15 22:56:34 -07:00
Kubernetes Prow Robot
ce3ce9a57a
Merge pull request #77023 from obitech/fix_golint_issues_in_kubelet_packages_oom
Fix golint issues in pkg/kubelet/oom
2019-05-15 22:56:21 -07:00
Kubernetes Prow Robot
37281a400d
Merge pull request #76442 from viegasdom/fix-golint-utils-bandwith
Fix golint failures of util/bandwith/*.go
2019-05-15 22:56:08 -07:00
Kubernetes Prow Robot
fe895f0411
Merge pull request #76420 from k-toyoda-pi/fix_shellcheck_failure_make-rules_3
fix shellcheck failures in /hack/make-rules/update.sh,verify.sh
2019-05-15 19:19:42 -07:00
Kubernetes Prow Robot
c50ff35a55
Merge pull request #77839 from mcrute/migrate-fake-cp
Staging legacy fake cloud provider
2019-05-15 12:32:23 -07:00
SataQiu
b36d8d431f fix golint failures of pkg/util/parsers pkg/util/sysctl pkg/util/system 2019-05-15 23:19:47 +08:00
Kubernetes Prow Robot
6a40ed1005
Merge pull request #77751 from baasbank/fix-lint-errors-staging/src/k8s.io
Fix lint errors staging/src/k8s.io
2019-05-15 07:06:26 -07:00
adisky
38b7f2125f
fix unbound array variable 2019-05-15 13:47:48 +05:30
SataQiu
7fa953fcb5 fix golint failures of test/e2e_node/services 2019-05-15 15:37:21 +08:00
Mike Crute
7d62316f8f Migrate fake cloud provider to staging 2019-05-14 13:32:18 -07:00
danielqsj
ccecc67a5b fix golint error in test/e2e/scheduling 2019-05-14 14:18:52 +08:00
Kubernetes Prow Robot
5f728452ea
Merge pull request #77841 from liggitt/restore-verify-script
Revert "fix shellcheck failures of hack/verify-no-vendor-cycles.sh"
2019-05-13 19:47:33 -07:00
Kubernetes Prow Robot
a60d2126ad
Merge pull request #77715 from danielqsj/t2
fix golint error make test error checking more readable in test/e2e/node
2019-05-13 19:47:09 -07:00
Jordan Liggitt
43c8eb6c36 Revert "fix shellcheck failures of hack/verify-no-vendor-cycles.sh"
This reverts commit e25e5a63e7.
2019-05-13 19:14:03 -04:00
Akihito INOH
dddc6a53d4 Fix golint failures of e2e/framework/*.go
This fixes golint failures of the following files:
- test/e2e/framework/networking_utils.go
- test/e2e/framework/service_util.go
- test/e2e/framework/util.go

All golint failures in test/e2e/framework are fixed at this commit.
Remove 'test/e2e/framework' from 'hack/.golint_failures'
2019-05-14 07:04:57 +09:00
Kubernetes Prow Robot
b957c6d7d7
Merge pull request #76869 from gambtho/master
Fix golint failures in pkg/securitycontext
2019-05-13 11:52:17 -07:00
SataQiu
a89d75e3b8 fix golint failures of client-go/tools/auth client-go/tools/portforward 2019-05-13 11:23:45 +08:00
SataQiu
a4825d1cb8 fix golint failures of test/e2e/auth 2019-05-12 22:57:24 +08:00
Baasbank
55d45867e6 fixes golint error in staging/src/k8s.io/sample-controller/pkg/apis/samplecontroller/v1alpha1
fixes golint error in staging/src/k8s.io/sample-controller/pkg/apis/samplecontroller

fixes golint errors in staging/src/k8s.io/sample-apiserver/pkg/cmd/server

fixex golint errors in staging/src/k8s.io/sample-apiserver/pkg/apiserver
2019-05-12 13:12:19 +01:00
Kubernetes Prow Robot
44881eb658
Merge pull request #77783 from cblecker/codegen-mapfile
Swap mapfile out in update-codegen
2019-05-11 20:40:09 -07:00
danielqsj
124efde4f8 fix golint error in e2e/node 2019-05-12 07:35:13 +08:00
Christoph Blecker
badac1b31c
Swap mapfile out in update-codegen 2019-05-11 16:19:26 -07:00
Kubernetes Prow Robot
d01c015346
Merge pull request #77777 from SataQiu/fix-golint-test-20190511
Fix golint failures of test/e2e/storage
2019-05-11 15:22:10 -07:00
Kubernetes Prow Robot
73c83a82fc
Merge pull request #77668 from SataQiu/fix-golint-test-20190509
Fix golint failures of test/e2e/network
2019-05-11 13:30:11 -07:00
SataQiu
01d38fec16 fix golint failures of test/e2e/storage 2019-05-11 23:30:17 +08:00
SataQiu
515f8342d3 fix golint failures of test/e2e/network 2019-05-11 22:29:40 +08:00
Kubernetes Prow Robot
1c18c3263a
Merge pull request #77386 from SataQiu/fix-shellcheck-20190503
Fix shellcheck failures of cluster/gce/upgrade-aliases.sh
2019-05-10 21:30:24 -07:00
Kubernetes Prow Robot
6f6890b09e
Merge pull request #77753 from liggitt/prune-replace
Prune matching replace directives in staging repos more effectively
2019-05-10 19:28:48 -07:00
Kubernetes Prow Robot
a245408f38
Merge pull request #76734 from oomichi/conformance-req-01
Check conformance test should not call any Skip
2019-05-10 19:28:11 -07:00
Kubernetes Prow Robot
9e87f8d620
Merge pull request #77696 from bradhoekstra/fix-lint
Fix some lint errors in pkg/proxy
2019-05-10 17:56:37 -07:00
Jordan Liggitt
d9d5968947 Prune matching replace directives in staging repos more effectively 2019-05-10 15:36:03 -04:00
Kubernetes Prow Robot
07e3b7cdca
Merge pull request #74639 from xychu/fix-shellchecks-a
Make test/cmd/a*.sh pass shellcheck
2019-05-10 10:38:12 -07:00
Khaled Henidak(Kal)
205eaed1a7 add legacy cloud providers unit tests to [make test] 2019-05-09 22:55:15 +00:00
Brad Hoekstra
62e58a66aa Fix some lint errors in pkg/proxy 2019-05-09 16:48:29 -04:00
xiaojingchen
2b19a4db9e fix cmd/kube-controller-manager's golint failures 2019-05-09 17:56:08 +08:00
toyoda
34a120fc42 fix shellcheck failures in /hack/make-rules/test.sh 2019-05-09 17:47:12 +09:00
Kubernetes Prow Robot
6ced4fe2cb
Merge pull request #76475 from s-ito-ts/shellcheck_hack_verify
fix shellcheck failures in /hack/verify-[a-g]*.sh.
2019-05-08 23:06:48 -07:00
toyoda
bbe4a9fdc5 fix shellcheck failures in /hack/make-rules/clean.sh,test.sh,vet.sh 2019-05-09 13:40:35 +09:00
Andrew Kim
c919139245 update import of generic featuregate code from k8s.io/apiserver/pkg/util/feature -> k8s.io/component-base/featuregate 2019-05-08 10:01:50 -04:00
Andrew Kim
b2831a686c move generic feature gate code from k8s.io/apiserver to k8s.io/component-base 2019-05-08 09:58:55 -04:00
Kubernetes Prow Robot
0ff81d04dc
Merge pull request #76953 from Rand01ph/fix#69896
fix Remove hyperkube short aliases
2019-05-08 04:54:34 -07:00
Kubernetes Prow Robot
43284ecbfc
Merge pull request #77442 from cofyc/fix77084
Fix go lint failures in volume scheduling packages
2019-05-07 00:24:07 -07:00
Kubernetes Prow Robot
8ea9edbb02
Merge pull request #77495 from wanghaoran1988/fix_local_up_script
Enhance the local-up-cluster.sh script to start kubelet using correct cgroup driver.
2019-05-06 22:54:05 -07:00
toyoda
9a5655c915 fix shellcheck failures in /hack/make-rules/update.sh,verify.sh 2019-05-07 14:27:26 +09:00
Kubernetes Prow Robot
b3a73f761f
Merge pull request #77362 from cblecker/fix-bash-3
Don't use mapfile as it isn't bash 3 compatible
2019-05-06 21:32:32 -07:00
s-ito-ts
beca6c7c02 fix shellcheck failures in /hack/verify-[a-g]*.sh. 2019-05-07 02:32:54 +00:00
Kubernetes Prow Robot
d2b8f3e145
Merge pull request #77034 from atoato88/fix-golint-e2e-framework-providers-gce
Fix golint failures of e2e/framework/providers/gce/recreate_node.go
2019-05-06 19:17:40 -07:00
Christoph Blecker
eaafa5952f
Don't use mapfile as it isn't bash 3 compatible 2019-05-06 15:55:12 -07:00
Kubernetes Prow Robot
aafac3cfca
Merge pull request #77380 from SataQiu/fix-golint-apis-20190503
Fix golint failures of pkg/apis/scheduling, pkg/apis/storage/util, etc
2019-05-06 15:30:32 -07:00
Rand01ph
f6bf44a205 Remove hyperkube short aliases used in local-up-cluster.sh 2019-05-07 01:02:01 +08:00
Haoran Wang
37cb774918 Enhance the local-cluster-up.sh script to work with docker 19.03.0-beta3 2019-05-06 15:03:06 +08:00
SataQiu
d413e3f18d fix golint failures of pkg/kubectl/cmd/help pkg/kubectl/cmd/proxy pkg/kubectl/cmd/util/openapi 2019-05-05 23:40:09 +08:00
Yecheng Fu
3315474f55 Fix go lint failures in a few packages
- pkg/controller/volume/persistentvolume/testing
- pkg/controller/volume/scheduling
2019-05-05 09:45:25 +08:00
Kubernetes Prow Robot
ef550e6989
Merge pull request #75434 from cofyc/fix56098
Refactor PV scheduling library into a separate package
2019-05-03 22:17:38 -07:00
Kubernetes Prow Robot
4e1e5af09d
Merge pull request #77403 from liggitt/apimachinery-protobuf
Generate and verify apimachinery protobuf
2019-05-03 15:12:04 -07:00
Niko Pen
22a2ca453f
durable link to cherry pick instructions 2019-05-03 20:17:36 +00:00
Kenichi Omichi
52885a8ec3 Check conformance test should not call any Skip
Basically conformance test checks the target k8s cluster works all
features which are specified in each test and that should not depend
on any condition.
This adds checking that conformance test should not call any Skip
methods. And it detects the existing conformance test
"creating/deleting custom resource definition objects works"
calls framework.SkipUnlessServerVersionGTE(). So this removes the
Skip also.
2019-05-03 18:37:31 +00:00
Jordan Liggitt
54e948ce82 Verify apimachinery protobuf 2019-05-03 11:59:41 -04:00
SataQiu
2ba0231670 fix shellcheck failures of cluster/gce/upgrade-aliases.sh 2019-05-03 17:01:15 +08:00
SataQiu
ed04c5f459 fix golint failures of pkg/apis/scheduling pkg/apis/storage/util pkg/apis/storage/v1/util pkg/apis/storage/v1beta1/util 2019-05-03 15:54:24 +08:00
Akihito INOH
2562d4d0fd Fix golint failures of e2e/framework/providers/gce/recreate_node.go
This fixes golint failures of the following file:

test/e2e/framework/providers/gce/recreate_node.go

And also, replaces functions using gomega with framework functions.
2019-05-03 07:20:37 +09:00
Kubernetes Prow Robot
b07f311322
Merge pull request #76882 from SataQiu/fix-golint-controller-20190422
Fix golint failures of pkg/controller/certificates/approver, etc
2019-05-02 03:16:18 -07:00
Kubernetes Prow Robot
1626aa56d0
Merge pull request #77053 from SataQiu/fix-golint-test-20190425
Fix golint failures of test/e2e/lifecycle
2019-05-02 02:00:17 -07:00
Yecheng Fu
842fed658c Refactor PV scheduling library into separate package 2019-05-02 14:45:52 +08:00
Kubernetes Prow Robot
0230664642
Merge pull request #77039 from cblecker/update-owners
Update some OWNERS files
2019-05-01 22:10:30 -07:00
SataQiu
3c35e4e2d6 fix golint failures of pkg/controller/certificates/approver 2019-05-02 10:37:38 +08:00
SataQiu
538776d6ad fix golint failures of pkg/registry/rbac/role 2019-05-02 10:36:35 +08:00
SataQiu
55d1b5e3d4 fix golint failures of pkg/registry/rbac/clusterrole 2019-05-02 10:35:47 +08:00
SataQiu
d76f1a8fd6 fix golint failures of pkg/volume/util/recyclerclient 2019-05-02 10:27:56 +08:00
Kubernetes Prow Robot
576ec2cee4
Merge pull request #77137 from Huang-Wei/make-clean-regression
Fixed a `make clean` regression
2019-05-01 15:50:32 -07:00
Baasbank
d97b7f20f8 fixes golint errors in pkg/printers/storage
fixes golint errors in pkg/printers

fixes golint errors for pkg/printers/internalversion

implements recommended changes
2019-05-01 17:02:55 +01:00
Kubernetes Prow Robot
55a052481d
Merge pull request #76944 from SataQiu/fix-golint-volume-20190423
Fix golint failures of pkg/volume/nfs
2019-04-30 17:31:12 -07:00
Kubernetes Prow Robot
0f4b666469
Merge pull request #76778 from SataQiu/fix-golint-20190419
Fix golint failures of pkg/apis/autoscaling
2019-04-30 01:19:37 -07:00
Kubernetes Prow Robot
855c291cb8
Merge pull request #76858 from SataQiu/fix-cluster-clientbin-20190420
Fix shellcheck failures of cluster/clientbin.sh
2019-04-29 07:46:22 -07:00
Kubernetes Prow Robot
74a70262c5
Merge pull request #76974 from mtaufen/fix-golang-sh
Restrict builds to officially supported platforms
2019-04-29 02:10:22 -07:00
Kubernetes Prow Robot
2dc3509b6d
Merge pull request #76867 from xichengliudui/fixshellcheckfailures-29
fix shellcheck failures on vet.sh
2019-04-27 16:48:21 -07:00
aaa
a4a4abd428 update pull request
update pull request on vet.sh
2019-04-27 10:56:43 -04:00
obitech
ccfb6379f3 Remove pkg/kubelet/pod from .golint_failures 2019-04-27 10:36:38 +02:00
obitech
9e35d3d709 Fix golint issues in pkg/kubelet/oom 2019-04-27 10:00:07 +02:00
Wei Huang
7193252386
Fixed a make clean regression. 2019-04-26 11:52:21 -07:00
Kubernetes Prow Robot
332d62a94a
Merge pull request #76710 from rosti/introduce-v1beta2
kubeadm: Introduce v1beta2 config
2019-04-26 10:38:27 -07:00
Kubernetes Prow Robot
2776cc1e72
Merge pull request #77099 from dims/remove-rancher-credential-provider-from-upstream-kubernetes
Remove Rancher Credential Provider from upstream kubernetes
2019-04-26 04:32:39 -07:00
SataQiu
aacab2ee75 fix shellcheck failures of cluster/clientbin.sh 2019-04-26 18:43:33 +08:00
Xiangyang Chu
2260cc29b9 Make test/cmd/a*.sh pass shellcheck 2019-04-26 11:39:11 +08:00
Kubernetes Prow Robot
5ab36f8cee
Merge pull request #77055 from SataQiu/fix-shell-20190426
Fix shellcheck failures of hack/verify-no-vendor-cycles.sh
2019-04-25 16:11:02 -07:00
Kubernetes Prow Robot
a2b50cdc9a
Merge pull request #77033 from guineveresaenger/guin-lint
Remove golint failures from pkg/apis/admissionregistration
2019-04-25 16:10:50 -07:00
Davanum Srinivas
edf8577654
Remove Rancher Credential Provider from upstream kubernetes
This is useful only in rancher environment, they are using this in a
very old branch (1.6), they are currently at 2.2.x. There is just no
point in us carrying this code as this is not useful to anyone else
outside of the rancher environment. Let us please remove this code from
upstream.

Change-Id: I5196d0edd79a7809c3a04e6028ddbd01063f224b
2019-04-25 19:10:01 -04:00
Michael Taufen
dcee810a3f Restrict builds to officially supported platforms
Prior to this change, including windows/amd64 in KUBE_BUILD_PLATFORMS
would, for example, attempt to build the server binaries/tars/images for
Windows, which is not supported. This can break downstream build steps.
2019-04-25 14:05:44 -07:00
Kubernetes Prow Robot
35cbe3f849
Merge pull request #77001 from SataQiu/fix-golint-capabilities-20190424
Fix golint failures of pkg/capabilities
2019-04-25 13:37:17 -07:00
Kubernetes Prow Robot
5b43333291
Merge pull request #76884 from SataQiu/fix-golint-pkg/kubelet/pod
Fix golint failures of pkg/kubelet/pod
2019-04-25 13:37:06 -07:00
guineveresaenger
fa0c81cbd1 Remove golint failures from pkg/apis/admissionregistration
Adds test/integration/apiserver/admissionwebhook to golint_failures; it is failing on kubernetes/master currently
2019-04-25 12:20:52 -07:00
SataQiu
e25e5a63e7 fix shellcheck failures of hack/verify-no-vendor-cycles.sh 2019-04-26 00:19:07 +08:00
SataQiu
1d8615a0a2 fix golint failures of test/e2e/lifecycle 2019-04-25 23:40:22 +08:00
Rostislav M. Georgiev
9e1ac76c1a kubeadm: Introduce v1beta2 config
Signed-off-by: Rostislav M. Georgiev <rostislavg@vmware.com>
2019-04-25 17:10:04 +03:00
Kubernetes Prow Robot
78190f0758
Merge pull request #76881 from xichengliudui/fixshellcheckfailures-30
fix shellcheck failures list-resources.sh
2019-04-25 02:00:47 -07:00
Kubernetes Prow Robot
6c664746e4
Merge pull request #76840 from xichengliudui/fixshellcheckfailures-26
Fix shellcheck failures on clean.sh and cache_go_dirs.sh
2019-04-24 23:04:56 -07:00
SataQiu
1581055c3a fix golint failures of pkg/kubelet/pod 2019-04-25 11:54:14 +08:00
Christoph Blecker
c932ea2aec
Update hack/ OWNERS 2019-04-24 19:13:48 -07:00
SataQiu
bf37c8a217 fix golint failures of pkg/kubelet/checkpointmanager/checksum 2019-04-25 09:56:43 +08:00
Kubernetes Prow Robot
20b76a2b4a
Merge pull request #77002 from SataQiu/fix-golint-apis-networking
Fix golint failures of pkg/apis/networking
2019-04-24 18:13:18 -07:00
Kubernetes Prow Robot
e8f28b5577
Merge pull request #76937 from xichengliudui/fixshellcheckfailures-34
Fix shellcheck failures on ginkgo-e2e.sh
2019-04-24 16:50:57 -07:00
yameiwang
f130e48deb fix golint errors in pkg/volume/host_path 2019-04-25 06:46:47 +08:00
Kubernetes Prow Robot
e53118df1b
Merge pull request #76945 from SataQiu/fix-golint-volume-2019042302
Fix golint failures of pkg/volume/portworx
2019-04-24 14:20:58 -07:00
Kubernetes Prow Robot
d711b28cca
Merge pull request #75910 from andrewsykim/vsphere-staging
Staging the vSphere Cloud Provider
2019-04-24 12:24:40 -07:00
Kubernetes Prow Robot
8ec6167f61
Merge pull request #74942 from WanLinghao/event_replace
Migrate oom watcher not relying on cAdviosr's API any more
2019-04-24 05:50:05 -07:00
SataQiu
73ec7ad2d6 fix golint failures of pkg/apis/networking 2019-04-24 18:08:18 +08:00
SataQiu
c66f636d0b fix golint failures of pkg/capabilities 2019-04-24 17:16:48 +08:00
Kubernetes Prow Robot
5a790bce3b
Merge pull request #76763 from SataQiu/ifx-golint-kubelet-20190419
Fix golint failures of pkg/kubelet/apis
2019-04-24 01:24:14 -07:00
SataQiu
853c33358a fix golint failures of pkg/apis/autoscaling 2019-04-24 15:13:01 +08:00
Kubernetes Prow Robot
ea38af74a9
Merge pull request #76925 from SataQiu/fix-golint-kubelet-2019042302
Fix golint failures of pkg/kubelet/dockershim/cm
2019-04-23 23:50:50 -07:00
Kubernetes Prow Robot
c7cd03cc38
Merge pull request #76900 from SataQiu/fix-shellcheck-test-20190422
Fix shellcheck failures of test/e2e_node/environment/setup_host.sh
2019-04-23 23:50:39 -07:00
Kubernetes Prow Robot
a73980e1e6
Merge pull request #76855 from SataQiu/fix-hack-shell-20190420
fix bug of hack/verify-test-featuregates.sh
2019-04-23 23:50:27 -07:00
Kubernetes Prow Robot
19b96c968c
Merge pull request #76812 from SataQiu/fix-hack-shellcheck-2019041904
Fix shellcheck failures of hack/grab-profiles.sh
2019-04-23 23:50:16 -07:00
Kubernetes Prow Robot
2c2e7a01bb
Merge pull request #76655 from SataQiu/fix-shell-cluster-20190417
Fix shellcheck failures of cluster/gce/gci/shutdown.sh
2019-04-23 23:50:04 -07:00
Kubernetes Prow Robot
970e5929fe
Merge pull request #76806 from SataQiu/fix-kubelet-golint-20190419
Fix golint failures of pkg/kubelet/checkpoint
2019-04-23 22:10:11 -07:00
Kubernetes Prow Robot
2a3d307fb9
Merge pull request #76765 from SataQiu/fix-golint-apis-20190418
Fix golint failures of pkg/apis/authorization
2019-04-23 22:10:00 -07:00
SataQiu
828125c725 fix golint failures of pkg/kubelet/apis 2019-04-24 12:56:28 +08:00
SataQiu
58caa7474f fix bug of hack/verify-test-featuregates.sh 2019-04-24 11:30:28 +08:00
Andrew Sy Kim
a58942625d staging the vsphere cloud provider under k8s.io/legacy-cloud-providers/vsphere
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
2019-04-23 22:17:59 -05:00
SataQiu
a37adceadf fix golint failures of pkg/volume/portworx 2019-04-23 23:26:41 +08:00
SataQiu
d6d329b0eb fix golint failures of pkg/volume/nfs 2019-04-23 22:25:46 +08:00
Kubernetes Prow Robot
e6390ce3ff
Merge pull request #76835 from SataQiu/fix-shellcheck-hack-20190420
Fix shellcheck failures of hack/verify-boilerplate.sh verify-cli-conventions.sh verify-codegen.sh
2019-04-23 03:14:12 -07:00
Kubernetes Prow Robot
fd0a140673
Merge pull request #76890 from xichengliudui/fixshellcheckfailures-31
fix shellcheck failures on and verify-test-featuregates.sh
2019-04-23 00:46:26 -07:00
SataQiu
2704abf844 fix shellcheck failures of hack/verify-boilerplate.sh verify-cli-conventions.sh verify-codegen.sh 2019-04-23 13:39:00 +08:00
SataQiu
423e8f0292 fix golint failures of pkg/kubelet/dockershim/cm 2019-04-23 12:59:13 +08:00
Kubernetes Prow Robot
4ec29a1a2b
Merge pull request #76889 from SataQiu/fix-golint-kubelet-util-20190422
Fix golint failures of pkg/kubelet/util
2019-04-22 20:44:25 -07:00
Kubernetes Prow Robot
b9606bef8d
Merge pull request #76860 from SataQiu/fix-golint-volume-20190420
Fix golint failures of pkg/volume/local
2019-04-22 20:44:07 -07:00
Kubernetes Prow Robot
588ea5d757
Merge pull request #76871 from cblecker/shellcheck-colour
Fix malformed JUNIT XML with shellcheck failures
2019-04-22 14:38:19 -07:00
Kubernetes Prow Robot
b57387b333
Merge pull request #76767 from SataQiu/fix-shellcheck-20190418
Fix shellcheck failures of hack/verify-openapi-spec.sh
2019-04-22 13:17:46 -07:00
Kubernetes Prow Robot
dc395391bc
Merge pull request #76834 from SataQiu/fix-hack-shell-2019041905
Fix bug and golint failures of hack/verify-api-groups.sh
2019-04-22 10:44:00 -07:00
Kubernetes Prow Robot
0ca27bfee2
Merge pull request #76139 from SataQiu/fix-golint-kubectl-20190404
Fix golint failures of pkg/kubectl/apps
2019-04-22 10:43:44 -07:00
Kubernetes Prow Robot
3488cd346a
Merge pull request #76804 from SataQiu/fix-apis-golint-20190419
Fix golint failures of pkg/apis/batch
2019-04-22 09:23:46 -07:00
SataQiu
741caa4475 fix bug and golint failures of hack/verify-api-groups.sh 2019-04-22 22:20:04 +08:00
SataQiu
c892beca8b fix shellcheck failures of test/e2e_node/environment/setup_host.sh 2019-04-22 22:08:26 +08:00
SataQiu
cd6828bae0 fix golint failures of pkg/kubelet/util 2019-04-22 15:23:07 +08:00
SataQiu
903c5a53b3 fix shellcheck failures of cluster/gce/gci/shutdown.sh 2019-04-22 11:46:45 +08:00
SataQiu
b4bc5cb4fe
Merge branch 'master' into fix-shellcheck-20190418 2019-04-22 11:32:17 +08:00
aaa
c4898d6f56 fix shellcheck failures list-resources.sh
update pull request

update pull request

update pull request
2019-04-21 18:17:44 -04:00
aaa
2fb859db42 Fix shellcheck failures on
update pull request

update pull request
2019-04-21 12:40:12 -04:00
Kubernetes Prow Robot
75d45bdfc9
Merge pull request #76856 from SataQiu/fix-hack-cherrypick-20190420
Fix shellcheck failures of hack/cherry_pick_pull.sh
2019-04-21 09:25:44 -07:00
aaa
5f719707f2 Fix shellcheck failures on clean.sh and cache_go_dirs.sh
update pull request
2019-04-21 06:24:08 -04:00
Kubernetes Prow Robot
1377108c08
Merge pull request #76808 from SataQiu/fix-hack-shellcheck-20190419
Fix shellcheck failures of hack/verify-readonly-packages.sh
2019-04-21 00:47:44 -07:00
Christoph Blecker
5236850989
Fix malformed JUNIT XML with shellcheck failures 2019-04-20 18:22:28 -07:00
Thomas Gamble
344dd90881 Fix golint failures in pkg/securitycontext 2019-04-20 20:38:40 -04:00
SataQiu
1f40880615 fix golint failures of pkg/volume/local 2019-04-20 18:18:25 +08:00
aaa
5c8ec1ce9c fix shellcheck failures
update pull request

update pull request
2019-04-20 05:08:00 -04:00
SataQiu
e7e517434b fix shellcheck failures of hack/cherry_pick_pull.sh 2019-04-20 15:49:34 +08:00
SataQiu
43095d9218 fix shellcheck failures of hack/verify-readonly-packages.sh 2019-04-20 14:10:58 +08:00
Kubernetes Prow Robot
f980370fc0
Merge pull request #76608 from suigh/b1_etcd.sh
update the output of install-etcd.sh, show how to export the environment of etcd
2019-04-19 20:29:42 -07:00
aaa
ad5bccc510 fix shellcheck in test-smoke.sh and test-network.sh
update pull request

update pull request

update pull request

update pull request
2019-04-19 16:15:10 -04:00
aaa
e05f85a611 Fix shellcheck failures on verify-readonly-packages.sh 2019-04-19 14:59:50 -04:00
Kubernetes Prow Robot
e4f9d8fe3f
Merge pull request #76331 from xichengliudui/fixshellcheckfailures-17
Fix shellcheck failures in stage-upload.sh
2019-04-19 09:47:55 -07:00
SataQiu
a20aec8d2d fix shellcheck failures of hack/verify-openapi-spec.sh 2019-04-19 23:28:34 +08:00
SataQiu
14775c4057 fix shellcheck failures of hack/grab-profiles.sh 2019-04-19 22:19:41 +08:00
Kubernetes Prow Robot
3b12266c06
Merge pull request #76803 from cblecker/goldflags-fix
Fix shellcheck in hack/lib/golang.sh
2019-04-19 05:53:56 -07:00
SataQiu
0e1956b762 fix golint failures of pkg/kubelet/checkpoint 2019-04-19 18:27:32 +08:00
SataQiu
61478c04d8 fix golint failures of pkg/apis/batch 2019-04-19 18:04:54 +08:00
suigh
c056a46ba9 update the output of install-etcd.sh, show how to export the environment of etcd. 2019-04-19 16:43:00 +08:00
Kubernetes Prow Robot
b54053924e
Merge pull request #76810 from SataQiu/fix-hack-shellcheck-2019041903
Fix shellcheck failures of hack/test-update-storage-objects.sh
2019-04-19 01:06:13 -07:00
SataQiu
4d6319b9b2 fix shellcheck failures of hack/test-update-storage-objects.sh 2019-04-19 20:00:58 +08:00
Kubernetes Prow Robot
3cbb20c694
Merge pull request #76809 from SataQiu/fix-hack-shellcheck-2019041902
Fix shellcheck failures of hack/verify-description.sh and hack/verify-import-boss.sh
2019-04-18 23:40:26 -07:00
SataQiu
04ab994cc3 fix shellcheck failures of hack/verify-description.sh and hack/verify-import-boss.sh 2019-04-19 18:59:24 +08:00
Kubernetes Prow Robot
f0022d87e5
Merge pull request #76744 from xichengliudui/fixshellcheckfailures-25
Fix shellcheck failures on test-e2e-node.sh and test-integration.sh
2019-04-18 23:40:10 -07:00
Christoph Blecker
4543e68ae5
Fix shellcheck in hack/lib/golang.sh 2019-04-18 18:53:13 -07:00
Kubernetes Prow Robot
d308368b2d
Merge pull request #76417 from SataQiu/fix-shell-update-generated-runtime-dockerized-20190411
Fix shellcheck failures of hack/update-generated-runtime-dockerized.sh
2019-04-18 14:27:54 -07:00
SataQiu
aa60494209 fix golint failures of pkg/apis/authorization 2019-04-19 04:06:06 +08:00
SataQiu
bd7f7fefae fix shellcheck failures of hack/update-generated-runtime-dockerized.sh 2019-04-18 22:36:22 +08:00
Davanum Srinivas
7e01702a88
Move "-s -w" flags to GOLDFLAGS as an overridable default.
If GOLDFLAGS is set, whether it is empty or not, we should honor it.
Only if the GOLDFLAGS is totally not set, then we use "-s -w"

See Parameter Expansion section in the urls below:

https://stackoverflow.com/questions/3601515/how-to-check-if-a-variable-is-set-in-bash/16753536
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_02

Change-Id: I826c34efc63c77f0e3e9677fff30a3eb2219a377
2019-04-17 21:55:13 -04:00
Kubernetes Prow Robot
401cc19548
Merge pull request #76622 from oomichi/enable-conformance-check
Enable conformance requirement check
2019-04-17 12:16:53 -07:00
Kubernetes Prow Robot
f625bef870
Merge pull request #76478 from SataQiu/fix-shell-hack-20190412
Fix shellcheck failures of hack/update-generated-kms-dockerized.sh and hack/update-generated-protobuf-dockerized.sh
2019-04-17 12:16:36 -07:00
Kubernetes Prow Robot
23e6f80304
Merge pull request #76132 from SataQiu/fix-e2e-apps-golint-20190404
Fix golint failures of test/e2e/apps
2019-04-17 12:16:04 -07:00
SataQiu
4c713e94d9 fix golint failures of pkg/kubectl/apps 2019-04-17 19:37:35 +08:00
SataQiu
03180ec2b2 fix golint failures of test/e2e/apps 2019-04-17 19:04:51 +08:00
Kubernetes Prow Robot
c3bec0bae4
Merge pull request #74601 from mrbobbytables/fix-test-image-shellcheck
Fix shellcheck lint errors in test/images/* scripts
2019-04-17 02:22:03 -07:00
Kenichi Omichi
08dc056480 Replace false with exit 1
Some scripts contained `false` for returning 1 to callers instead of
`exit 1` and that works like:

  $ false
  $ echo $?
  1
  $

But that made confusion in a PR review process.
So this replaces `false` with `exit 1` for long-term maintenance.
2019-04-16 23:13:00 +00:00
Kenichi Omichi
c76bb08357 Enable conformance requirement check 2019-04-16 22:54:16 +00:00
Kubernetes Prow Robot
1a0a75750c
Merge pull request #76613 from SataQiu/fix-golint-20190416
Fix golint failures of pkg/apis/core/helper
2019-04-16 10:27:31 -07:00
Kubernetes Prow Robot
123b9c9e10
Merge pull request #76313 from SataQiu/fix-hack-2019040902
Fix shellcheck failures of hack/update-openapi-spec.sh
2019-04-16 10:27:10 -07:00
Kubernetes Prow Robot
98b6f35999
Merge pull request #74610 from oomichi/issue/74038-2
Enable StorageObjectInUseProtection by default
2019-04-16 02:11:29 -07:00
Kubernetes Prow Robot
35669df1ab
Merge pull request #76066 from SataQiu/golint-test-20190403
Fix golint failures of e2e/apimachinery
2019-04-15 23:31:22 -07:00
SataQiu
91bd1ac1ea fix golint failures of test/e2e/apimachinery 2019-04-16 19:03:26 +08:00
Kubernetes Prow Robot
9f49dd2811
Merge pull request #76582 from danielqsj/gofmt
run update-gofmt when make update
2019-04-15 21:01:19 -07:00
Kubernetes Prow Robot
92562d5bc0
Merge pull request #76253 from YoubingLi/bugfix
Fixes # 76094 - Check the content of WHAT for Makefile's verify target
2019-04-15 18:05:05 -07:00
Bob Killen
5518defffc
Fix shellcheck lint errors in test/images/volume/nfs/run_nfs.sh 2019-04-15 20:02:03 -04:00
Bob Killen
f795e22932
Fix shellcheck lint errors in test/images/volume/iscsi/create_block.sh 2019-04-15 20:01:25 -04:00
Bob Killen
346bcdaa27
Fix shellcheck lint errors in test/images/volume/gluster/run_gluster.sh 2019-04-15 20:01:25 -04:00
SataQiu
556ff16b0d fix golint failures of pkg/apis/core/helper 2019-04-16 07:21:20 +08:00
Kubernetes Prow Robot
8d38f3f2cf
Merge pull request #75795 from mrbobbytables/shellcheck-ignore-third-party
Update hack/verify-shellcheck.sh to ignore ./third_party/*
2019-04-15 13:11:08 -07:00
SataQiu
142e458a97 fix shellcheck failures of hack/update-openapi-spec.sh 2019-04-16 03:40:56 +08:00
Kubernetes Prow Robot
4628133bda
Merge pull request #76558 from liggitt/lint-pin-improvements
propagate pinned versions to staging repos, output cleanup commands
2019-04-15 11:47:09 -07:00
Kubernetes Prow Robot
631bf8cbc8
Merge pull request #76497 from SataQiu/fix-golint-20190413
Fix golint failures of cmd/kube-proxy/app
2019-04-15 10:26:53 -07:00
Jordan Liggitt
77690137a9 propagate pinned versions to staging repos, output cleanup commands 2019-04-15 11:30:07 -04:00
Kubernetes Prow Robot
4a5151b2c4
Merge pull request #75524 from oomichi/issue/74432
Add check-conformance-test-requirements.go
2019-04-15 03:54:09 -07:00
danielqsj
187986cb65 run update-gofmt in make update 2019-04-15 15:01:54 +08:00
Kubernetes Prow Robot
76b877a93f
Merge pull request #76495 from h00130372/fix-unbound-variable
Fix older bash failing on unbound array variables
2019-04-14 20:56:01 -07:00
h00130372
de95a3344b Fix older bash failing on unbound array variables
Older bash versions fail when trying to expand array variables
when the array is empty.
2019-04-15 09:47:26 +08:00
SataQiu
db8bc68946 fix shellcheck failures of hack/update-generated-kms-dockerized.sh hack/update-generated-protobuf-dockerized.sh 2019-04-15 01:57:36 +08:00
Kubernetes Prow Robot
56817f2543
Merge pull request #76115 from SataQiu/fix-shell-20190404
Fix shellcheck failures of zookeeper-installer/install.sh, etc
2019-04-13 21:20:01 -07:00
Kubernetes Prow Robot
0e157cbc36
Merge pull request #75713 from SataQiu/fix-e2e_node-builder-20190326
Fix golint failures in test/e2e_node/builder
2019-04-13 19:18:00 -07:00
SataQiu
d735aaadd6 fix shellcheck failures of zookeeper-installer/install.sh zookeeper-installer/on-start.sh 2019-04-14 07:07:50 +08:00
Kubernetes Prow Robot
92918dc285
Merge pull request #76448 from xichengliudui/fixshellcheckfailures-20
update benchmark-dockerized.sh and verify-dockerized.sh
2019-04-13 14:02:01 -07:00
Bob Killen
db01d68d05
Update hack/verify-shellcheck.sh to ignore ./third_party/*
The ./third_party/* directory contains scripts, libraries and
other components from external sources. These should be omitted
from lints and checks with the exception of things that are
forked and modified (located in ./third_party/forked/*) for
project related reasons.
2019-04-13 16:58:20 -04:00
Kubernetes Prow Robot
df6ca6ab9f
Merge pull request #76156 from chardch/recreate-master-retry
Recreate nodes e2e test
2019-04-12 23:26:02 -07:00
Kubernetes Prow Robot
e68888384b
Merge pull request #76522 from liggitt/prune-replace
Prune replace directives
2019-04-12 20:00:04 -07:00
Kubernetes Prow Robot
ed5c7e6bfb
Merge pull request #76511 from liggitt/fixup-vendor-gopath
stop clearing GOPATH in vendor scripts
2019-04-12 18:08:47 -07:00
Kubernetes Prow Robot
ae11829495
Merge pull request #76499 from SataQiu/fix-bug-shellcheck
Follow up of #76314
2019-04-12 18:08:32 -07:00
Kubernetes Prow Robot
a08107fe99
Merge pull request #76482 from SataQiu/fix-shell-hack-2019041202
Fix shellcheck failures of hack/update-codegen.sh
2019-04-12 18:08:18 -07:00
Jiaying Zhang
8175579a0c add recreate node e2e test
Move recreate_node test to gce provider tests.
2019-04-12 16:00:19 -07:00
Kubernetes Prow Robot
90a939ec33
Merge pull request #76131 from SataQiu/fix-hack-20190404
Fix shellcheck failures of hack/lib/logging.sh hack/lib/protoc.sh
2019-04-12 15:56:45 -07:00
Kubernetes Prow Robot
969c1106f1
Merge pull request #76084 from SataQiu/fix-shell-20190403
Fix shellcheck failures of test/images/pets/redis-installer/on-start.sh
2019-04-12 15:56:32 -07:00
SataQiu
cc199c74fc fix golint failures of cmd/kube-proxy/app 2019-04-13 06:20:52 +08:00
Jordan Liggitt
aaa8802acb Prune unnecessary replace directives from staging go.mod files 2019-04-12 16:48:01 -04:00
SataQiu
84a0478d1b fix bug of hack/update-gofmt.sh 2019-04-13 03:29:51 +08:00
Jordan Liggitt
fb0cea22dc stop clearing GOPATH in vendor scripts
if unset, go defaults to $HOME/go, and fails if $GOROOT is also set to the same directory

we were only doing this to be doubly sure that only modules were being used.
just depend on export GO111MODULE=on for that.
2019-04-12 12:56:05 -04:00
Kubernetes Prow Robot
5b434eefc3
Merge pull request #74180 from mrbobbytables/fix-third-party-shellcheck
Fix shellcheck lint errors in third_party/* scripts
2019-04-12 06:14:46 -07:00
SataQiu
9863f26706 fix shellcheck failures of hack/update-codegen.sh 2019-04-12 19:15:56 +08:00
Kubernetes Prow Robot
b2db8c77ad
Merge pull request #76426 from SataQiu/join-hack-20190411
add @SataQiu as a reviewer of hack
2019-04-12 03:23:31 -07:00
Kubernetes Prow Robot
28d5023137
Merge pull request #76244 from cblecker/dep-script-fixups
Couple of dependency script cleanups
2019-04-12 03:23:17 -07:00
SataQiu
4231fa0980 fix shellcheck failures of hack/lib/logging.sh hack/lib/protoc.sh 2019-04-12 16:00:23 +08:00
aaa
9768ba9eb3 Fix shellcheck failures in stage-upload.sh
update pull request

update pull request

update pull request

update pull request
2019-04-12 02:42:48 -04:00
aaa
7a39c99297 Fix shellcheck failures on test-e2e-node.sh and test-integration.sh 2019-04-11 13:47:34 -04:00
Bob Killen
9e719d8d9c
Fix shellcheck lint errors in third_party/forked/shell2junit/sh2ju.sh 2019-04-11 10:25:41 -07:00
SataQiu
10b52bae28
Merge branch 'master' into fix-hack-2019040903 2019-04-11 23:29:10 +08:00
SataQiu
318af5f45a add @SataQiu as a reviewer of hack 2019-04-11 23:07:48 +08:00
viegasdom
1c468bf2e2 Fix golint failures of util/bandwith/*.go 2019-04-11 15:07:41 +01:00
Kubernetes Prow Robot
ef830e2bcf
Merge pull request #76311 from SataQiu/fix-hack-20190409
Fix shellcheck failures of hack/update-vendor-licenses.sh
2019-04-10 22:42:21 -07:00
yue9944882
cabe69faeb clean up unused vars in codegen scripts 2019-04-10 13:14:36 +08:00
Kubernetes Prow Robot
e2091b769a
Merge pull request #71136 from yue9944882/chore/prune-all-kk-internal-clientset
Prune literally all kube-apiserver internal client
2019-04-09 13:58:45 -07:00
aaa
037729b357 update benchmark-dockerized.sh and verify-dockerized.sh
update pull request
2019-04-09 15:07:26 -04:00
Jordan Liggitt
aaeecd86dc make pin-dependency.sh only work at the module level 2019-04-09 11:45:13 -04:00
yue9944882
ced03fb698 remove internal client from udpate-codegen script 2019-04-09 21:43:54 +08:00
SataQiu
67509020ca fix shellcheck failures of hack/update-vendor-licenses.sh 2019-04-09 13:47:30 +08:00
SataQiu
0f09703c48 fix shellcheck failures of hack/update-gofmt.sh hack/update-translations.sh 2019-04-09 12:30:58 +08:00
Kubernetes Prow Robot
fbc28fd15f
Merge pull request #76280 from xichengliudui/fixshellcheck0409
Fix shellcheck failures in update-workspace-mirror.sh
2019-04-08 20:29:18 -07:00
Youbing Li
8a56ebed82 Check the content of WHAT for Makefile's verify target 2019-04-08 22:53:23 -04:00
aaa
961f1621aa Fix shellcheck failures in update-workspace-mirror.sh 2019-04-08 14:40:26 -04:00
aaa
e544da8aae Fix shellcheck failures in test-dockerized.sh and upload-to-gcs.sh
update pull request

update pull request
2019-04-08 14:14:47 -04:00
Kubernetes Prow Robot
8a2f8e69ed
Merge pull request #76197 from liggitt/generated-vendor
Mark staging go module files as generated, add script to lint dependencies
2019-04-08 10:16:51 -07:00
Jordan Liggitt
f250dcf70a Prune unneeded replace directives from staging go.mod files 2019-04-08 09:42:22 -04:00
Jordan Liggitt
fdd241a858 Mark staging go module files as generated, add script to lint dependencies 2019-04-08 09:42:22 -04:00
Mehdy Bohlool
8702550beb Support service port other than 443 for kube-aggregator 2019-04-08 00:19:57 -07:00
Kubernetes Prow Robot
f873d2a056
Merge pull request #75862 from xichengliudui/fixshellcheckfailures
Fix shellcheck failures in bootstrap.sh and create_block.sh
2019-04-07 21:52:24 -07:00
Christoph Blecker
2363136f2c
Remove has_changes logic from vendor scripts 2019-04-07 12:11:18 -07:00
Christoph Blecker
668a288595
Remove unneeded scripts 2019-04-07 12:08:41 -07:00
Kubernetes Prow Robot
06655abd87
Merge pull request #76168 from caesarxuchao/local-up-followup
Follow up of https://github.com/kubernetes/kubernetes/pull/76050#discussion_r271540758
2019-04-05 07:43:44 -07:00
Kubernetes Prow Robot
5756bfbf8d
Merge pull request #76180 from nikhita/verify-publishing-bot-deps
Show all missing deps when publishing-bot rules has no listed dependencies
2019-04-05 06:27:19 -07:00
Kubernetes Prow Robot
0c32c22b2e
Merge pull request #75546 from fabriziopandini/e2e-kubeadm-first-class
Implement make test-e2e-kubeadm
2019-04-05 04:59:19 -07:00
Nikhita Raghunath
d474631e38 Show all missing deps when publishing-bot has no listed dependencies
Before this, it only showed one dependency in the error message.

Also, replace godeps.json with go.mod in the error message.
2019-04-05 13:08:12 +05:30
Kubernetes Prow Robot
54ba23eec6
Merge pull request #76169 from BenTheElder/hack-the-planet
add bentheelder to hack/ approvers
2019-04-04 23:53:54 -07:00
Kubernetes Prow Robot
470bda42c3
Merge pull request #76153 from liggitt/update-vendor-cleanup
Update vendor cleanup
2019-04-04 23:53:42 -07:00
Kubernetes Prow Robot
87247f5357
Merge pull request #75915 from xichengliudui/fixshellcheckfailures-05
fix shellcheck failures in ./hack/jenkins/...
2019-04-04 22:31:19 -07:00
Benjamin Elder
d3c405c7c3 add bentheelder to hack/ approvers 2019-04-04 15:23:52 -07:00
Chao Xu
ce0cd866c0 followup https://github.com/kubernetes/kubernetes/pull/76050#discussion_r271540758 2019-04-04 14:38:26 -07:00
Jordan Liggitt
86f29e210b Clean up generated file warnings, add recursive dependency detection 2019-04-04 12:06:45 -04:00
Jordan Liggitt
892ad8b449 Make pin-dependency.sh work with things other than docker 2019-04-04 09:20:55 -04:00
Jordan Liggitt
2ea3cbdcbc Update hack scripts to use go mod 2019-04-03 10:19:39 -04:00
Jordan Liggitt
7f246d461b Remove third_party/forked/godep 2019-04-03 10:19:39 -04:00
SataQiu
b732a53c6b fix shellcheck failures of test/images/pets/redis-installer/on-start.sh 2019-04-03 21:55:05 +08:00
Jordan Liggitt
8ead4b059f Add kubernetes/kubernetes tools.go imports 2019-04-03 09:15:39 -04:00
Kubernetes Prow Robot
658c290ed5
Merge pull request #76063 from Huang-Wei/option-clean-stdout
give users option to suppress detailed output in integration test
2019-04-03 03:24:19 -07:00
Kubernetes Prow Robot
42877480ad
Merge pull request #75747 from msau42/remove-alpha-crd
Remove alpha csi CRD
2019-04-02 22:47:41 -07:00
Kubernetes Prow Robot
28ac3063da
Merge pull request #76050 from caesarxuchao/fix-local-up-cluster
Fix kubelet start in local-up-cluster.sh
2019-04-02 20:11:42 -07:00
Wei Huang
66a3094419
give users option to suppress detailed output in integration test 2019-04-02 17:27:32 -07:00
Kubernetes Prow Robot
b274fb3570
Merge pull request #75984 from umohnani8/e2e
Add RUNTIME_REQUEST_TIMEOUT to local-up-cluster.sh
2019-04-02 15:45:20 -07:00
Chao Xu
1b953aaa59 Fix kubelet start in local-up-cluster.sh 2019-04-02 12:59:32 -07:00
Michelle Au
d2aa8178f2 Remove alpha CRD install 2019-04-02 10:59:11 -07:00
Kubernetes Prow Robot
aa52140928
Merge pull request #75346 from seans3/version-fix
kubectl: removes pkg/version dependency
2019-04-02 10:19:18 -07:00
Urvashi Mohnani
8b96021c67 Add RUNTIME_REQUEST_TIMEOUT to local-up-cluster.sh
The changes to local-cluster-up.sh from #75662 is causing the
CRI-O CI to break since it picks up the --runtime-request-timeout
flag as part of the container-runtime-endpoint flag.
Adding a new env so that we can set the runtime-request-timeout
value for our CI.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
2019-04-02 11:25:55 -04:00
Kubernetes Prow Robot
d7d852a3ed
Merge pull request #75994 from mrunalp/fix_unbound_args_array
Fix older bash failing on unbound array variables
2019-04-02 08:22:48 -07:00
Mrunal Patel
8c9b169f17 Fix older bash failing on unbound array variables
Older bash versions fail when trying to expand array variables
when the array is empty.

Signed-off-by: Mrunal Patel <mpatel@redhat.com>
2019-04-01 21:04:48 -07:00
Benjamin Elder
2b7cc095cc enable external sources in verify-shellcheck 2019-04-01 11:03:37 -07:00
Kubernetes Prow Robot
997d5182d0
Merge pull request #75662 from s-ito-ts/shellcheck_local-up-cluster.sh
fix shellcheck failures in hack/local-up-cluster.sh
2019-03-31 18:24:32 -07:00
Kubernetes Prow Robot
72418519ff
Merge pull request #75865 from xichengliudui/fixshellcheckfailure-03
Fix shellcheck failures in godep-save.sh and godep-restore.sh
2019-03-30 15:57:08 -07:00
Kubernetes Prow Robot
66dad3bb09
Merge pull request #75868 from xichengliudui/patch-4
Add @xichengliudui to hack/OWNERS reviewers
2019-03-29 23:53:21 -07:00
Kubernetes Prow Robot
c7a8596a39
Merge pull request #75867 from SataQiu/fix-kubeadm-golint-20190329
Fix golint failures in cmd/kubeadm/app/util/system
2019-03-29 17:33:57 -07:00
Kubernetes Prow Robot
259f706c73
Merge pull request #75834 from jlucktay/golint_pkg/auth/authorizer/abac
Golint pkg/auth/authorizer/abac
2019-03-29 11:48:50 -07:00
Kubernetes Prow Robot
733f2478d3
Merge pull request #75584 from SataQiu/fix-golint-20190322
fix some golint failures in pkg/apis
2019-03-29 10:28:40 -07:00
James Lucktaylor
dbb696508a Enact golint recommendations per issue 68026.
Remove the 'abac' package from the golint exclusion list.
Add/edit comments per golint feedback.
Set PolicyList to be exported, as not exporting was breaking one of
golint's rules around exported funcs returning an unexported type.
Fix a broken test
2019-03-29 12:50:31 +00:00
lIuDuI
6f970d3d70
Update OWNERS 2019-03-29 12:15:39 +08:00
SataQiu
a41c85ea07 fix golint failures in cmd/kubeadm/app/util/system 2019-03-29 12:03:25 +08:00
Sean Sullivan
d4d6e19f1e kubectl: removes pkg/version dependency 2019-03-28 16:08:34 -07:00
fabriziopandini
2cb2a979d4 e2e-kubeadm-first-class 2019-03-28 16:29:56 +01:00
Kubernetes Prow Robot
f6c51d6e99
Merge pull request #75751 from BenTheElder/bash-fun
fix kube::golang::is_instrumented_package
2019-03-26 23:19:01 -07:00
Kubernetes Prow Robot
29353452c4
Merge pull request #75668 from bart0sh/PR0068-hack-lib-golang.sh-fix-mac-build
fix 'make generated_files' build on MacOS
2019-03-26 20:45:01 -07:00
Kubernetes Prow Robot
d24fe8a801
Merge pull request #75735 from andrewsykim/update-install-etcd-link
fix link to etcd install docs for integration tests
2019-03-26 18:11:29 -07:00
Kubernetes Prow Robot
4b3eb60081
Merge pull request #75531 from dims/add-new-staging-repository-for-cri-api
New staging repository for cri-api
2019-03-26 18:10:49 -07:00
Benjamin Elder
0833a9cc38 fix kube::golang::is_instrumented_package 2019-03-26 17:17:16 -07:00
Davanum Srinivas
33081c1f07
New staging repository for cri-api
Change-Id: I2160b0b0ec4b9870a2d4452b428e395bbe12afbb
2019-03-26 18:21:04 -04:00
Kubernetes Prow Robot
2086f81546
Merge pull request #74678 from pmcalpine/lint-bs_cj
Fix some golint failures for pkg/controller
2019-03-26 15:10:16 -07:00
Andrew Sy Kim
e26157df07 fix link to etcd install docs 2019-03-26 13:40:18 -04:00
SataQiu
b1cb58fdf2 fix golint failures in test/e2e_node/builder 2019-03-26 14:12:45 +08:00
Ed Bartosh
3d5d38607d fix 'make generated_files' build on MacOS
Recent change to hack/lib/golang.sh broke the build on MacOS this way:

$ make clean && make generated_files
+++ [0325 13:38:22] Verifying Prerequisites....
+++ [0325 13:38:23] Removing _output directory
k8s.io/kubernetes/vendor/github.com/spf13/pflag
k8s.io/kubernetes/hack/make-rules/helpers/go2make
+++ [0325 13:38:40] Building go targets for darwin/amd64:
    ./vendor/k8s.io/code-generator/cmd/deepcopy-gen
can't load package: package k8s.io/kubernetes: no Go files in k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes
!!! [0325 13:38:40] Call tree:
!!! [0325 13:38:40]  1: k8s.io/kubernetes/hack/lib/golang.sh:629 kube::golang::build_some_binaries(...)
!!! [0325 13:38:40]  2: k8s.io/kubernetes/hack/lib/golang.sh:764 kube::golang::build_binaries_for_platform(...)
!!! [0325 13:38:40]  3: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
make[1]: *** [_output/bin/deepcopy-gen] Error 1
make: *** [generated_files] Error 2

It was caused by 'binaries' array not being declared with 'local -a'.
It looks like MacOS' old bash version makes an array to contain first
empty element if declared this way.

The fix has been tested on MacOS High Sierra and Linux openSUSE 42.3 (x86_64)

Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
2019-03-25 17:08:13 +01:00
s-ito-ts
8cc3718e69 fix eliminate shellcheck failures in hack/local-up-cluster.sh 2019-03-25 07:17:06 +00:00
SataQiu
f82fb4059d fix some failures in pkg/apis 2019-03-23 12:20:49 +08:00
Kubernetes Prow Robot
9c53f24012
Merge pull request #75179 from rosti/kill-v1alpha3
kubeadm: remove v1alpha3
2019-03-22 17:02:21 -07:00
Kubernetes Prow Robot
ffd8f3dacb
Merge pull request #73255 from ds-ms/golint
Fix linting issues in pkg/kubectl/cmd/version
2019-03-22 17:02:08 -07:00
Kubernetes Prow Robot
a3bc56fffb
Merge pull request #74746 from oomichi/golint-e2e-framework-gce
Fix golint failures under test/e2e/[..]/gce
2019-03-22 15:46:08 -07:00
Kenichi Omichi
3d64667507 Add check-conformance-test-requirements.go
We have defined requirements of conformance test as [1], and this
adds coding check for one requirement "it works for all providers".

[1]: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md#conformance-test-requirements
2019-03-22 21:56:07 +00:00
Kubernetes Prow Robot
fcb102b2a4
Merge pull request #75158 from k-toyoda-pi/fix_shellcheck_failure_golang_sh
fix eliminate shellcheck failures in hack/lib/golang.sh
2019-03-22 14:09:37 -07:00
Kenichi Omichi
da7c9f70c3 Fix golint failures under test/e2e/[..]/gce
This fixes golint failures under test/e2e/framework/providers/gce/.

Cleanup:
* FirewallTimeoutDefault is not used at all, so remove it.
* FirewallTestTcpTimeout, FirewallTestHttpPort and FirewallTestUdpPort
  are used at test/e2e/network/firewall.go only. So move them.
2019-03-22 15:59:17 +00:00
Kubernetes Prow Robot
22621ca415
Merge pull request #74739 from moshe010/nokubeproxy
Add nokubeproxy option in START_MODE
2019-03-21 22:50:44 -07:00
Kubernetes Prow Robot
51b5d28c15
Merge pull request #74333 from SataQiu/fix-shell-20190221
Fix some shellcheck failures in hack
2019-03-21 22:50:18 -07:00
Kubernetes Prow Robot
4c16fb78b3
Merge pull request #74242 from xichengliudui/fixshellcheck19021903
fix shellcheck in hack/make-rules/...
2019-03-21 21:36:17 -07:00
toyoda
a52af3a9d5 fix shellcheck failure golang.sh 2019-03-22 13:29:26 +09:00
Kubernetes Prow Robot
c48ed1c5ac
Merge pull request #74356 from oomichi/golint-e2e-framework-kubemark
Fix golint failures for e2e/[..]/kubemark
2019-03-21 19:26:32 -07:00