Commit Graph

262 Commits

Author SHA1 Message Date
Mike Danese
25651408ae generated: run refactor 2020-02-08 12:30:21 -05:00
Mike Danese
3aa59f7f30 generated: run refactor 2020-02-07 18:16:47 -08:00
Pavithra Ramesh
1de2327afc Attach a new finalizer in GCE ILB creation.
Add logic in service_controller to skip create/update
if finalizer from a different controller is found.

The newly added finalizer will be checked by other controllers
implementing ILB services to determine if a given service is
already being managed by service_controller.

Moved finalizer check into cloudprovider code.

added unit test to verify new finalizer.

Modified existing unit test to create a fake service so that
attach/remove finalizer step can be tested.
2020-01-28 15:02:19 -08:00
Kubernetes Prow Robot
ace98e1382
Merge pull request #84433 from yamt/comment-typo
Fix a comment typo in legacyNodeRoleBehaviorFeature
2020-01-10 17:17:38 -08:00
Jordan Liggitt
5d5b444c4d Remove use of testapi codecs, selflink, resourcepath functions 2019-12-13 11:56:29 -05:00
louisgong
7f5076d8ee slim down some lister expansions 2019-12-07 08:27:06 +08:00
Rong Gao
99603e105a check service status value returned by EnsureLoadBalancer
when service status returned by EnsureLoadBalancer is nil, return the
function directly to avoid NPE
2019-11-22 09:19:06 +08:00
YAMAMOTO Takashi
361cd7212e Fix a comment typo in legacyNodeRoleBehaviorFeature 2019-11-15 11:30:34 +09:00
Zihong Zheng
0833e8840e Amend service controller code/test regarding finalizer GA 2019-11-12 15:04:07 -08:00
yuxiaobo
81e9f21f83 Correct spelling mistakes
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
2019-11-06 20:25:19 +08:00
wojtekt
7b6bcdf780 Autogenerated code 2019-10-24 20:21:00 +02:00
Cristian Dima
da759609dc in pkg/controller/service rename service_controller.go to controller.go 2019-10-23 01:52:19 +03:00
Cristian Dima
a18de39166 fix golint errors in pkg/controller/service 2019-10-23 01:52:19 +03:00
Kubernetes Prow Robot
de9a7d863d
Merge pull request #83934 from wccsama/wcc-service-dev
Convert error messages to use event recorder
2019-10-18 12:37:46 -07:00
wccsama
18cf49e3df Convert error messages to use event recorder
remove mix protocol validation
remove check nil
2019-10-18 13:30:00 +08:00
Kubernetes Prow Robot
6a5f0e6eda
Merge pull request #81348 from yastij/code-org-service-controller
move service helpers to k8s.io/cloud-provider
2019-10-17 00:20:38 -07:00
Yassine TIJANI
d796baea27 move service helpers to k8s.io/cloud-provider
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
2019-10-16 14:12:11 +02:00
Bob Killen
30053bb00f
Prune inactive owners from pkg/controller/* network related OWNERS files. 2019-10-13 08:50:18 -04:00
Yassine TIJANI
c1487840bc move util/metrics to component-base
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
2019-10-08 14:42:31 +02:00
Ted Yu
fd8f2bd91f Defer the removal of labelAlphaNodeRoleExcludeBalancer to 1.18 2019-09-19 12:06:55 -07:00
Yassine TIJANI
3fe7a57000 use directly DeletionHandlingMetaNamespaceKeyFunc from client-go
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
2019-08-29 11:51:14 +01:00
Clayton Coleman
0f49d892d5
Service controller should begin moving away from node-role labels
The service load balancer controller should honor the
LegacyNodeRoleBehavior feature gate for checks that use node-roles,
switch to using a non alpha annotation behind the gate, and prepare
to graduate to beta.
2019-08-28 10:29:08 -04:00
Kubernetes Prow Robot
bdfc8f62b4
Merge pull request #81949 from yastij/remove-ftg-name-dep
remove dependency to pkg/features on service controller package
2019-08-28 05:12:15 -07:00
Kubernetes Prow Robot
ab13cf1055
Merge pull request #81691 from MrHohn/svc-finalizer-beta
Promote service load balancer finalizer to Beta
2019-08-27 19:37:48 -07:00
Yassine TIJANI
19fa57bca3 remove dependency to pkg/features on service controller package
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
2019-08-27 18:00:10 +01:00
Kubernetes Prow Robot
4e83be80b1
Merge pull request #81844 from yastij/remove-slice-dep
remove slice dependency from service_controller
2019-08-27 09:25:24 -07:00
Yassine TIJANI
6ad40ba51f remove slice dependency
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
2019-08-27 11:26:06 +01:00
Yassine TIJANI
7e4c3096fe move WaitForCacheSync to the sharedInformer package
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
2019-08-22 16:13:41 +01:00
Zihong Zheng
0a7c085b14 Check service finalizer on upgrade test and fix-up test cases 2019-08-21 15:19:56 -07:00
Pavithra Ramesh
ecad65a3f8 Added comment after invoking ensureLoadBalancer 2019-08-02 11:24:24 -07:00
Pavithra Ramesh
da887e85e9 Updated comment about ImplementedElsewhere
Removed handling ImplementedElsewhere error in call to EnsureLoadBalancerDeleted.
2019-08-02 10:54:09 -07:00
Pavithra Ramesh
987677c201 Setting log level to 4 since default is 2 or 3.
Depending on how the cluster is created. Test clusters set a default
level of 4.
2019-08-02 10:54:09 -07:00
Pavithra Ramesh
dbfc876e83 Fixed review comments, lint.
Added error check to EnsureLoadBalancerDeleted.
2019-08-02 10:54:09 -07:00
Pavithra Ramesh
d4210b94e2 addressed review comments 2019-08-02 10:54:09 -07:00
Pavithra Ramesh
d79d4e8525 Handle ImplementedElsewhere error in service_controller
This is used when the cloudprovider layer is not implementing loadBalancer service.
Implementation will be in a different controller running on master.
2019-08-02 10:54:09 -07:00
David Xia
fabfd950b1
cleanup: fix some log and error capitalizations
Part of https://github.com/kubernetes/kubernetes/issues/15863
2019-07-20 18:26:16 -04:00
Hongcai Ren
9618d1d955 Fix service controller not release loadBalancer issue in corner case. 2019-06-27 09:12:16 +08:00
Kubernetes Prow Robot
bc70f33e3a
Merge pull request #79294 from tedyu/svc-ctrl-lock
Use RWMutex to improve locking for serviceCache
2019-06-24 11:24:28 -07:00
Ted Yu
e86b0d3cd3 Use RWMutex to improve locking for serviceCache 2019-06-22 06:49:40 -07:00
Kubernetes Prow Robot
4b8a1163aa
Merge pull request #77712 from Sn0rt/check-target-port-check
service controller: if targetPort has changed will process by cloud-p…
2019-06-21 18:52:12 -07:00
guohaowang
d41f7b99ef service controller: if targetPort has changed will process by cloud-provider
Signed-off-by: guohaowang <wangguohao.2009@gmail.com>
2019-06-21 15:26:45 +08:00
Hongcai Ren
fa80c0072a Remove redundant initilization for service controller 2019-06-21 11:38:36 +08:00
Kubernetes Prow Robot
8d8c54bd73
Merge pull request #79082 from timoreimann/delete-unused-service-controller-load-balancer-name-method
Remove unused ServiceController.loadBalancerName method
2019-06-19 18:37:13 -07:00
Hongcai Ren
f0fae66001 Minor change: delete unused constant from service controller 2019-06-18 15:45:34 +08:00
Kubernetes Prow Robot
541cc51c7d
Merge pull request #72809 from hanxiaoshuai/fix0111
when SessionAffinityConfig is different, enqueueService in update Service handler
2019-06-17 05:54:09 -07:00
Timo Reimann
77c9950098 Remove unused ServiceController.loadBalancerName method
Its only caller lives in the corresponding test file. Hence, we move the
method called by loadBalancerName over to the test and remove
loadBalancerName.
2019-06-17 00:45:22 +02:00
Zihong Zheng
89a7a35607 Don't mask k8s error returned from patch 2019-06-04 16:40:51 -07:00
Zihong Zheng
64198a43e7 Auto-generated BUILD files 2019-05-30 21:09:04 -07:00
Zihong Zheng
2ab3681648 Fix-up and add unit test for Load Balancer finalizer 2019-05-30 21:09:04 -07:00
Zihong Zheng
aa3f81d657 Add Load Balancer finalizer support
- Always try to remove finalizer upon load balancer cleanup
- Add finalizer prior to load balancer creation (feature gated)
- Cache logic fix-ups
- Event type/message fix-ups
- Use runtime.HandleError() on eaten errors

Co-authored-by: Josh Horwitz <horwitzja@gmail.com>
2019-05-30 21:09:04 -07:00