Kubernetes Prow Robot
9cf4f15884
Merge pull request #110633 from wojtek-t/fix_leaking_goroutines_10
...
Fix leaking goroutines in multiple integration tests
2022-07-18 21:56:05 -07:00
Wojciech Tyczyński
13e4f2b554
Clean shutdown of volume integration tests
2022-07-14 11:25:57 +02:00
Abirdcfly
00b9ead02c
cleanup: remove duplicate import
...
Signed-off-by: Abirdcfly <fp544037857@gmail.com >
2022-07-14 11:25:19 +08:00
Jiawei Wang
760365d5c9
CSIMigration feature gate to GA
2022-06-06 21:19:19 +00:00
Deepak Kinni
a7b1fcba40
Add or Remove PV deletion protection finalizer considering the recalimPolicy
...
Signed-off-by: Deepak Kinni <dkinni@vmware.com >
2022-04-07 00:48:35 +05:30
Deepak Kinni
836ace46a0
Default enable flag for beta feature HonorPVReclaimPolicy
...
Signed-off-by: Deepak Kinni <dkinni@vmware.com >
2022-03-26 06:48:28 +05:30
Konstantin Misyutin
438d224f0e
Cleanup k8s.io/component-helpers/storage/volume package
...
Signed-off-by: Konstantin Misyutin <konstantin.misyutin@huawei.com >
2022-03-16 15:43:09 +08:00
Konstantin Misyutin
4ba98a8610
cleanup: remove unnecessary import aliases
2022-03-16 15:43:09 +08:00
Konstantin Misyutin
1d7cefe9c4
Move volume helpers to "k8s.io/component-helpers/storage/volume".
...
This patch aims to simplify decoupling "pkg/scheduler/framework/plugins"
from internal "k8s.io/kubernetes" packages. More described in
issue #89930 and PR #102953 .
Some helpers from "k8s.io/kubernetes/pkg/controller/volume/persistentvolume"
package moved to "k8s.io/component-helpers/storage/volume" package:
- IsDelayBindingMode
- GetBindVolumeToClaim
- IsVolumeBoundToClaim
- FindMatchingVolume
- CheckVolumeModeMismatches
- CheckAccessModes
- GetVolumeNodeAffinity
Also "CheckNodeAffinity" from "k8s.io/kubernetes/pkg/volume/util"
package moved to "k8s.io/component-helpers/storage/volume" package
to prevent diamond dependency conflict.
Signed-off-by: Konstantin Misyutin <konstantin.misyutin@huawei.com >
2022-03-16 15:43:09 +08:00
Deepak Kinni
d37f14d0ae
Support for in-tree PV Deletion protection finalizer
...
Signed-off-by: Deepak Kinni <dkinni@vmware.com >
2022-03-10 21:37:43 -08:00
Kubernetes Prow Robot
184daed0db
Merge pull request #107559 from liggitt/invalid-selectors
...
Handle invalid selectors properly
2022-01-19 14:49:31 -08:00
Jordan Liggitt
c0af728f43
Handle invalid selectors properly
2022-01-14 12:11:02 -05:00
Wojciech Tyczyński
551790729f
Remove selflink references in different testing-related files
2022-01-14 12:58:05 +01:00
Kubernetes Prow Robot
abfe397ceb
Merge pull request #107166 from jsafrane/fix-pv-controller-tests
...
Fix PV controller unit test 5-7
2022-01-04 23:03:27 -08:00
Jan Safranek
0f9832d095
Fix PV name in unit test
...
Test 5-5 should use PV with "5-5"i in the name. It makes log analysys
much easier.
2022-01-03 15:20:12 +01:00
Kubernetes Prow Robot
f0dbc32ed9
Merge pull request #106853 from gnufied/disable-exp-backoff-volume-not-inuse
...
When volume is not marked in-use, do not backoff
2021-12-22 19:46:37 -08:00
Jan Safranek
045ca75c03
Deflake PV metrics unit test
...
Test 5-7 tries to delete a PVC at the very same time when it detects that
the PV controller started processing the PVC. The controller then sometimes
can't update the PVC and generate an event for it that the test expects.
From PV controller logs (not shown in CI):
> I1221 14:36:34.548160 104481 pv_controller.go:815] updating PersistentVolumeClaim[default/claim5-7] status: set phase Lost failed: cannot update claim claim5-7: claim not found
Typical error in CI:
> FAIL: TestControllerSync (83.22s)
> framework_test.go:202: Event "Warning ClaimLost" not emitted
Therefore wait for the PVC to be fully processed before deleting the PVC to
avoid races.
2021-12-21 15:36:44 +01:00
Jan Safranek
e323306ce0
Add new watchers to PV controller tests
...
Add fake Pod and Node watchers to the tests. It only reduces test noise:
Failed to watch *v1.Pod: unhandled watch: testing.WatchActionImpl{ActionImpl:testing.ActionImpl{Namespace:"", Verb:"watch", Resource:schema.GroupVersionResource{Group:"", Version:"v1", Resource:"pods"}, Subresource:""}, WatchRestrictions:testing.WatchRestrictions{Labels:labels.internalSelector(nil), Fields:fields.andTerm{}, ResourceVersion:""}}
2021-12-21 15:36:34 +01:00
Hemant Kumar
7989f27044
use node informer to check volumes attachment status before backoff
...
fix unit tests
2021-12-20 11:57:05 -05:00
Davanum Srinivas
9405e9b55e
Check in OWNERS modified by update-yamlfmt.sh
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com >
2021-12-09 21:31:26 -05:00
Kubernetes Prow Robot
12901b95c9
Merge pull request #106344 from ikeeip/fix_import_formatting
...
Fix golang imports in k8s.io/pkg/controller/volume/persistentvolume package
2021-12-07 17:26:40 -08:00
Léiyì Zhang
275fdf0884
fixing unit test failures induced by turning on CSIMigrationGCE
...
disable CSIMigrationGCE in some unit tests
2021-11-16 19:26:30 +00:00
Jan Safranek
bb8157d780
Fix deletion protection unit test
...
The test should not depend on current set of default feature gates, it
should always ensure the ones necessary for the tests are set.
2021-11-12 10:47:15 +01:00
Konstantin Misyutin
7434fdf1d4
fix import formatting in k8s.io/pkg/controller/volume/persistentvolume package
...
Signed-off-by: Konstantin Misyutin <konstantin.misyutin@huawei.com >
2021-11-11 16:31:38 +08:00
Deepak Kinni
bfd5f23a0b
PV controller changes to support PV Deletion protection finalizer
...
Signed-off-by: Deepak Kinni <dkinni@vmware.com >
2021-11-08 10:35:58 -08:00
Konstantin Misyutin
808c8f42d5
Remove StorageObjectInUseProtection feature gate logic
...
This feature has graduated to GA in v1.11 and will always be
enabled. So no longe need to check if enabled.
Signed-off-by: Konstantin Misyutin <konstantin.misyutin@huawei.com >
2021-11-03 00:13:50 +03:00
Mike Dame
4960d0976a
Wire contexts to Core controllers
2021-11-01 10:29:00 -04:00
Konstantin Misyutin
dbc9d7b71a
Remove tests when StorageObjectInUseProtection feature is disabled
...
As well as feature gate are locked, the tests when this feature is
disabled will crash. So we should remove them together with locking
the feature.
Signed-off-by: Konstantin Misyutin <konstantin.misyutin@huawei.com >
2021-10-15 19:39:37 +08:00
torubylist
f28a8d7f2b
fix:cached claim is not the newest will cause unexpected issue
2021-10-13 20:03:00 +08:00
Kubernetes Prow Robot
bcd2ffbdc1
Merge pull request #104590 from Jiawei0227/anno
...
Add GA AnnStorageProvisioner annotation to PVC
2021-09-03 06:09:49 -07:00
Jiawei Wang
8de0f11946
Add GA AnnStorageProvisioner annotation to PVC
...
This PR adds GA AnnStorageProvisioner annotation to
a PVC if the PVC requires dynamic provisioning. This
also deprecates the beta AnnStorageProvisioner annotation
and it will be removed in a later release.
2021-08-26 12:46:47 -07:00
Stephen Augustus
481cf6fbe7
generated: Run hack/update-gofmt.sh
...
Signed-off-by: Stephen Augustus <foo@auggie.dev >
2021-08-24 15:47:49 -04:00
Chris Henzie
83e3ee780a
Rename access mode contains helper method
...
So it is consistent with other methods performing the same check (one
for internal and external types)
2021-06-28 21:24:56 -07:00
Kubernetes Prow Robot
894803ab2e
Merge pull request #98199 from yangjunmyfm192085/run-test3
...
fix mistake about [avaliable] for index_test.go
2021-05-25 02:46:22 -07:00
Kubernetes Prow Robot
838a967be5
Merge pull request #101175 from lojies/cleanupforpvcontroller
...
code cleanup:remove redundant return statement in pv_controller.go
2021-05-24 21:48:49 -07:00
wangyx1992
fd51e654af
cleanup: fix errors in wrapped format and log capitalization in controller
...
Signed-off-by: wangyx1992 <wang.yixiang@zte.com.cn >
2021-04-22 15:40:54 +08:00
卢振兴10069964
8009823867
code cleanup:remove redundant return statement in pv_controller.go
2021-04-16 09:02:21 +08:00
Kubernetes Prow Robot
5155865ae2
Merge pull request #99326 from sunpa93/fs_resize_fix
...
fix: use pv annotation to trigger filesystem resize when necessary
2021-03-09 11:05:18 -08:00
Kubernetes Prow Robot
dc74b9d0c7
Merge pull request #98753 from Jiawei0227/length
...
Relax csiNodeIDMaxLength to longer limit
2021-03-09 09:19:00 -08:00
Sung Jun Park
5f69cf74d8
fix: when newly binding pvc to a pv, adjust pvc.status.capacity to pv's annotation that denotes the pre-resize capacity of the original pvc that pv was bound to if it has one
...
test: confirm that pvc's status capacity is adjusted if pv has a pre-resize capacity annotation
2021-03-09 07:55:10 +00:00
Jiawei Wang
1e16615fb0
Relax csiNodeIDMaxLength to longer limit
...
Update csiNodeIDMaxLength to 192 bytes
2021-03-08 13:52:43 -08:00
Jan Safranek
219cbc818a
Refactor CSI migration plugin manager to get featureGates as a parameter
...
This allows caller to provide fake ones for testing of various corner cases
(migration on A/D controller disabled while enabled on kubelet).
2021-03-08 13:50:01 +01:00
Kubernetes Prow Robot
5498ee641b
Merge pull request #99561 from BenTheElder/remove-bazel
...
Remove Bazel
2021-03-01 09:55:27 -08:00
Kubernetes Prow Robot
f6152d1521
Merge pull request #97086 from xing-yang/check_datasource
...
Only CSI plugin can have a DataSource
2021-03-01 06:53:26 -08:00
Benjamin Elder
56e092e382
hack/update-bazel.sh
2021-02-28 15:17:29 -08:00
Kubernetes Prow Robot
c200a8f9b7
Merge pull request #98433 from damemi/remove-helper-from-volume-zone
...
Move GetPersistentVolumeClaimClass to component-helpers
2021-02-26 12:38:15 -08:00
xing-yang
676a3a7012
Only CSI plugin can have a DataSource
2021-02-25 15:27:26 +00:00
Jiawei Wang
3d61b56bcd
update bazel
2021-02-12 17:50:40 -08:00
Jiawei Wang
6a7222cf4e
Add migrated field to storage_operation_duration_seconds metric
2021-02-12 17:35:01 -08:00
wzshiming
fb518af0fc
Speed up pkg/controller/volume/persistentvolume unit tests
2021-02-05 15:09:36 +08:00