github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
113,301 Commits 1 Branch 31 Tags
773b45abc56200633596d9246e3510cb2c8ea26c
Commit Graph

3007 Commits

Author SHA1 Message Date
Patrick Ohly
9eaa2dc554 avoid klog Info calls without verbosity 
In the following code pattern, the log message will get logged with v=0 in JSON
output although conceptually it has a higher verbosity:

   if klog.V(5).Enabled() {
       klog.Info("hello world")
   }

Having the actual verbosity in the JSON output is relevant, for example for
filtering out only the important info messages. The solution is to use
klog.V(5).Info or something similar.

Whether the outer if is necessary at all depends on how complex the parameters
are. The return value of klog.V can be captured in a variable and be used
multiple times to avoid the overhead for that function call and to avoid
repeating the verbosity level.
 2022-01-12 07:48:36 +01:00
Davanum Srinivas
ba1f853b5a Add mwielgus back 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2022-01-10 09:02:53 -05:00
Davanum Srinivas
9682b7248f OWNERS cleanup - Jan 2021 Week 1 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2022-01-10 08:14:29 -05:00
Kubernetes Prow Robot
36746baa5f Merge pull request #104429 from shawnhanx/ut_3 
Add unit tests for registry/apiserverinternal/storageversion
 2022-01-06 01:26:28 -08:00
Kubernetes Prow Robot
b18efc2e9c Merge pull request #104807 from shawnhanx/ut_4 
Add unit tests for  pkg/registry/authorization/util
 2022-01-05 18:06:27 -08:00
Mike Spreitzer
72403c8814 Concurrentize pkg/registry/flowcontrol/ensurer/strategy.go 
Stop logging error messages when surprised by concurrent activity.
Concurrent activity is not an error, it is normal.
 2022-01-04 22:55:21 -05:00
Kubernetes Prow Robot
1945829906 Merge pull request #104846 from andrewsykim/fix-internal-traffic-policy-validation 
Stop defaulting Service internalTrafficPolicy when type is ExternalName
 2022-01-04 17:40:32 -08:00
Kubernetes Prow Robot
9e209efd65 Merge pull request #107104 from tkashem/apf-use-v1beta2 
apf: use v1beta2 in registry package
 2022-01-04 13:06:42 -08:00
Andrew Sy Kim
f68f478e66 core/v1: update unit tests to not expect internalTrafficPolicy when Service Type=ExternalName 
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
 2022-01-04 14:48:04 -05:00
Andrew Sy Kim
438b90fbc4 core/v1: drop Service spec.internalTrafficPolicy on read when type is ExternalName 
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
 2022-01-04 14:36:19 -05:00
Kubernetes Prow Robot
7dcad28ab0 Merge pull request #105800 from benluddy/apf-bootstrap-configuration-lister 
Use a lister for bootstrap flowcontrol config objects.
 2022-01-04 07:30:52 -08:00
Abu Kashem
f30a34bc01 apf: use v1beta2 for registry 2021-12-17 10:35:37 -05:00
Lars Ekman
1ef96752da Mark ServiceLBNodePortControl as GA 2021-12-16 16:48:58 +01:00
Davanum Srinivas
497e9c1971 Cleanup OWNERS files (No Activity in the last year) 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2021-12-15 10:34:02 -05:00
Davanum Srinivas
9405e9b55e Check in OWNERS modified by update-yamlfmt.sh 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2021-12-09 21:31:26 -05:00
Mengjiao Liu
f3c37c2c82 Remove feature gate NamespaceDefaultLabelName 2021-12-07 16:51:17 +08:00
Paco Xu
15558d6972 remove ValidateProxyRedirects and StreamingProxyRedirects in 1.24 2021-12-06 14:47:06 +08:00
Matthew Cary
f1d5d4df5a tests for statefulset PersistentVolumeClaimDeletePolicy api change 2021-11-17 16:46:48 -08:00
Matthew Cary
98c37f9e2a statefulset PersistentVolumeClaimDeletePolicy api change 2021-11-17 16:46:47 -08:00
Antonio Ojea
d126b14838 migrate nolint coments to golangci-lint 2021-11-17 13:58:53 +01:00
Hanna Lee
07a883d8e6 Remove //lint:ignore pragmas that aren't being used anymore 2021-11-17 08:56:54 +01:00
Hanna Lee
0f3836dcc5 Ignore deprecation warnings with //nolint:staticcheck 2021-11-17 08:55:57 +01:00
Kubernetes Prow Robot
39c76ba2ed Merge pull request #106455 from soltysh/cronjob_warning 
Add warning about using unsupported CRON_TZ
 2021-11-16 17:44:31 -08:00
Maciej Szulik
d0518848b5 Add warning about using unsupported CRON_TZ 
CRON_TZ variable slipped in during upgrading github.com/robfig/cron
library.  It allows setting a time zone which is a long requested
feature but one that is not officially supported. This adds warning
event since users should not rely on unsupported features.
 2021-11-16 17:41:37 +01:00
Hemant Kumar
63fffd37b1 Implement API changes necessary for recovery from resize failure 2021-11-15 18:39:30 -05:00
Dan Williams
a04997e1a1 pod/storage: remove always-empty 'oldMachine' in setPodHostAndAnnotations() 
There's only one caller of setPodHostAndAnnotations() and it always
passes an empty 'oldMachine'.

Signed-off-by: Dan Williams <dcbw@redhat.com>
 2021-11-11 16:29:20 -06:00
Kubernetes Prow Robot
1ff64edffb Merge pull request #104636 from hbagdi/ingress-class-namespaced-params-ga 
Graduate IngressClassNamespacedParams to GA
 2021-11-10 12:53:26 -08:00
Kubernetes Prow Robot
3128afa69a Merge pull request #106296 from thockin/svc-logging-cleanup 
Clean up some service logging
 2021-11-10 11:51:38 -08:00
Harry Bagdi
d09a8c0a88 Graduate IngressClassNamespacedParams to GA 2021-11-10 08:58:39 -08:00
Tim Hockin
049e158a8f Don't write fake logs to the real test log 
This caused consternation as errors were logged but tests did not fail.
It was expected to log!
 2021-11-09 22:56:34 -08:00
Tim Hockin
26db11f3dc Clean up some service logging 
This is a holdover from previous work.  It is not complete, but it
should be incrementally better.
 2021-11-09 22:46:22 -08:00
wangyysde
d2abddd909 rename v2beta2 to v2 
Signed-off-by: wangyysde <net_use@bzhy.com>

Generation swagger.json.

Use v2 path for hpa_cpu_field.

run update-codegen.sh

Signed-off-by: wangyysde <net_use@bzhy.com>
 2021-11-09 10:34:54 +08:00
Kubernetes Prow Robot
23df2b97f7 Merge pull request #105302 from ml-/fix-typos 
fix multiple typos in go files
 2021-11-03 03:20:58 -07:00
Ruochen Xu
6cc9bedfab add condition pre-check for pod uid and pod resource version in bind api 2021-11-02 09:51:15 +08:00
ml
a2441a256b fix multiple typos 2021-10-29 21:43:52 +02:00
Kubernetes Prow Robot
c592bd40f2 Merge pull request #105609 from pohly/generic-ephemeral-volume-ga 
generic ephemeral volume GA
 2021-10-28 17:36:50 -07:00
Patrick Ohly
d55f7c85ef psp: remove unused PodSecurityPolicyValidationOptions 
Since the only member of that struct is gone, the struct itself can also be
removed. If for whatever reason the struct is needed again, then this commit
can be reverted to bring it back.
 2021-10-28 17:25:07 +02:00
Ben Luddy
3f929b1634 Use a lister for bootstrap flowcontrol config objects. 
Instead of listing all flowschemas and prioritylevelconfigurations on
each tick, read from local informer caches.
 2021-10-20 11:40:00 -04:00
Abdullah Gharaibeh
335817cbce Allow updating node affinity, selector and tolerations for suspended jobs that never started 2021-10-14 10:04:47 -04:00
Patrick Ohly
a8c930ef46 generic ephemeral volume: graduation to GA 
The feature gate gets locked to "true", with the goal to remove it in two
releases.

All code now can assume that the feature is enabled. Tests for "feature
disabled" are no longer needed and get removed.

Some code wasn't using the new helper functions yet. That gets changed while
touching those lines.
 2021-10-11 20:54:20 +02:00
shawnhanx
90bcd710f4 Add unit tests for pkg/registry/authorization/util 2021-10-09 17:23:41 +08:00
Sahil Vazirani
3988405c8d GA TTLAfterFinish 2021-10-07 16:58:50 -07:00
Tom Payne
21755f9ec0 Speed up counting of bits in allocator 
Benchmark:

goos: linux
goarch: amd64
pkg: k8s.io/kubernetes/pkg/registry/core/service/allocator
cpu: Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz

Before:

BenchmarkCountBits-8     9459236               140.4 ns/op

After:

BenchmarkCountBits-8    140667842                9.541 ns/op
 2021-10-01 17:09:56 +02:00
Tom Payne
125312a8cf Add extra test and benchmark for count bits 2021-10-01 17:08:36 +02:00
Khaled Henidak (Kal)
a53e2eaeab move IPv6DualStack feature to stable. (#104691) 
* kube-proxy

* endpoints controller

* app: kube-controller-manager

* app: cloud-controller-manager

* kubelet

* app: api-server

* node utils + registry/strategy

* api: validation (comment removal)

* api:pod strategy (util pkg)

* api: docs

* core: integration testing

* kubeadm: change feature gate to GA

* service registry and rest stack

* move feature to GA

* generated
 2021-09-24 16:30:22 -07:00
Tim Hockin
52f54ce90d Svc REST: clean up defaultOnRead to be consistent 
Headless+selectorless -> RequireDualStack

Headless+selector -> SingleStack

Add test cases to cover this and ExternalName and dual-stack init (which
I think can never trigger, but best to be safe).
 2021-09-16 11:17:45 -07:00
Kubernetes Prow Robot
c10be982d1 Merge pull request #96345 from ingvagabund/disable-insecure-port-in-scheduler 
refactor: disable insecure serving in kube-scheduler
 2021-09-14 08:01:09 -07:00
Jan Chaloupka
07af6697e9 refactor: disable insecure serving in kube-scheduler 2021-09-14 07:52:16 +02:00
Kubernetes Prow Robot
cdcf2a239e Merge pull request #104399 from tkashem/apf-v1beta2 
apf: introduce v1beta2
 2021-09-13 18:01:08 -07:00
Tim Hockin
009aa36c89 Svc REST: Make transaction-accumulating funcs safe 
Identified in review, these funcs are now more reslient to future
changes.
 2021-09-11 11:30:02 -07:00