github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
120,629 Commits 1 Branch 31 Tags 1,019 MiB
7801173f6e
Commit Graph

9894 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
418ae605ec
Merge pull request #122879 from liggitt/verbose-local-up 
Make local-up-cluster non-verbose by default
 2024-01-20 03:50:35 +01:00
Kubernetes Prow Robot
fbb2e6293f
Merge pull request #122871 from oxxenix/minor-fix 
Print error message regardless verbosity value
 2024-01-19 21:04:18 +01:00
Jordan Liggitt
6ae264464c
Make local-up-cluster non-verbose by default 2024-01-19 08:27:28 -08:00
Oksana Baranova
a4afaeda37 print error message regardless verbosity level 
Signed-off-by: Oksana Baranova <oksana.baranova@intel.com>
 2024-01-19 13:57:27 +02:00
Jordan Liggitt
1192f313b8
Fix local-up-cluster on darwin 2024-01-18 08:51:45 -08:00
Tim Hockin
0d366dd99a
codegen: Use long flag names for clarity 2024-01-14 16:12:09 -08:00
Kubernetes Prow Robot
dcee8834b5
Merge pull request #122775 from thockin/codegen_s_base_file_g 
update-codegen: rename "base"->"file" for clarity
 2024-01-15 01:08:39 +01:00
Kubernetes Prow Robot
908a958bb1
Merge pull request #122771 from thockin/make_verify-fieldname-docs_actually_error 
Make verify-fieldname-docs actually error
 2024-01-14 23:57:44 +01:00
Tim Hockin
0f849d3b55
update-codegen: rename "base"->"file" for clarity 2024-01-14 10:41:59 -08:00
Tim Hockin
f2b550180c
codegen: don't use xargs w/ maybe-empty input 
GNU xargs has a `-r, --no-run-if-empty` option but I don't think we want
to depend on GNU (thanks, MacOS).

Why?  Sometimes, when you are messing with codegens, you end up with an
empty input and then it just hangs.
 2024-01-14 10:38:34 -08:00
Tim Hockin
8b8f0a70cd
Make verify-fieldname-docs actually error 
Sadly, cmd/fieldnamedocscheck did not exit non-zero when it needed to.

Fix the one thing it flagged.
Add it to verify-quick
 2024-01-14 10:32:08 -08:00
Benjamin Elder
08645984b0 Revert "Save a list of images used by e2e.test" 
This reverts commit a3c4a60995.
 2024-01-12 13:15:01 -08:00
Patrick Ohly
d954b25b11 hack/tools: bump logcheck to v0.8.1 
This enables the usage of the new SafePtr in code which needs to support
contextual logging.
 2024-01-12 14:39:50 +01:00
Davanum Srinivas
ddbf3ab662
local-up-cluster: use the newly built library always 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2024-01-11 08:13:21 -05:00
Kubernetes Prow Robot
c9158e9a19
Merge pull request #122595 from dims/support-building-with-and-without-cloud-providers 
KUBE_PROVIDERLESS - Support building with and without cloud providers
 2024-01-11 05:42:23 +01:00
Davanum Srinivas
ce263d8828
Address comments during Review 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2024-01-09 15:52:16 -05:00
Ziqi Zhao
6b5e973e5f
Migrate cmd/kube-proxy to contextual logging (#122197) 
* cmd/kube-proxy support contextual logging

Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>

* use ktesting.NewTestContext(t) in unit test

Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>

* use ktesting.NewTestContext(t) in unit test

Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>

* remove unnecessary blank line & add cmd/kube-proxy to contextual section in logcheck.conf

Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>

* add more contextual logging

Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>

* new lint yaml

Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>

---------

Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
 2024-01-08 17:30:18 +01:00
Davanum Srinivas
e25e1d39bd
Add KUBE_PROVIDERLESS for CI jobs to run with providerless tag 
Also ensure `test/e2e` works with providerless tag in the verify
script

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2024-01-07 15:20:57 -05:00
Nikola
5704a58810 add test for the registered feature gates 2024-01-07 18:10:25 +02:00
Davanum Srinivas
2431a964af
Drop hack/verify-govet-levee 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2024-01-04 21:06:52 -05:00
Kubernetes Prow Robot
7db7824d85
Merge pull request #122178 from saschagrunert/cni-plugins 
Update cni-plugins to v1.4.0
 2024-01-04 18:00:07 +01:00
Kubernetes Prow Robot
88d497d401
Merge pull request #118626 from borg-land/use-e2-instance-types 
Switch to e2 machine types
 2024-01-04 16:49:14 +01:00
Davanum Srinivas
a3c4a60995
Save a list of images used by e2e.test 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2024-01-03 08:07:47 -05:00
Kubernetes Prow Robot
be62153915
Merge pull request #122416 from pohly/e2e-gomega-be-true-or-false 
e2e: forbid usage of gomega.BeTrue/False
 2024-01-02 16:46:57 +01:00
Kubernetes Prow Robot
9680c84b9c
Merge pull request #121836 from skitt/verify-no-vendor-cycles-go 
verify-no-vendor-cycles: set up Go environment
 2024-01-02 16:46:39 +01:00
Kubernetes Prow Robot
58d023e178
Merge pull request #121894 from thockin/build_trimpath 
build: use -trimpath in non-DBG mode
 2023-12-29 04:38:51 +01:00
Tim Hockin
e3686246ea
Fix update-openapi-spec to not change caller CWD 2023-12-25 13:59:10 -08:00
Kubernetes Prow Robot
40c729c680
Merge pull request #122436 from pohly/log-warn-context 
hack/tools: bump logtools to v0.8.0
 2023-12-22 14:32:38 +01:00
Patrick Ohly
51f3b705c6 hack/tools: bump logtools to v0.8.0 
This adds support for marking functions and methods as "don't use in code which
supports contextual logging".
 2023-12-21 15:12:40 +01:00
Mohamed Omar Zaian
c8a2d5684d etcd: Update to version 3.5.11 2023-12-20 11:18:35 +01:00
Patrick Ohly
36cceff0a3 e2e: forbid usage of gomega.BeTrue/False 
`BeTrue` without explanation in `Should` just prints "false is not true", which
isn't a useful failure message. Even with an explanation that message is still
printed, which is just noise. The new BeTrue/FalseBecause avoid that by
requiring that an explanation is provided and using that instead of "false is
not true".

In Kubernetes, we can enforce the usage of those better alternatives or the
if+Fail combination via forbidigo. Because we have existing code which still
needs to be updated, this can only be a hint for now.

Some examples found with this:

ERROR: test/e2e/apimachinery/protocol.go:75:20: use of `o.BeTrue` forbidden because "it does not produce a good failure message, use BeTrueBecause with an explicit printf-style failure message instead or plain Go: if ... { ginkgo.Fail(...) }" (forbidigo)
ERROR: 			o.Expect(ok).To(o.BeTrue())
ERROR: 			                ^

ERROR: test/e2e_node/unknown_pods_test.go:163:52: use of `gomega.BeTrue` forbidden because "it does not produce a good failure message, use BeTrueBecause with an explicit printf-style failure message instead or plain Go: if ... { ginkgo.Fail(...) }" (forbidigo)
ERROR: 			}, f.Timeouts.PodStart, f.Timeouts.Poll).Should(gomega.BeTrue())
ERROR: 			                                                ^

The solution might also be to write a custom matcher, but that is a bit hard to
explain in the forbidigo message.
 2023-12-20 10:11:56 +01:00
James Blair
b6c1f8ef08
Fix etcd repository path to prevent redirects. 
Signed-off-by: James Blair <mail@jamesblair.net>
 2023-12-16 19:50:02 +13:00
Kubernetes Prow Robot
d19420f3ec
Merge pull request #122210 from dims/trying-to-fix-local-up-cluster 
Explicitly stop/start docker to fix local-up-cluster.sh
 2023-12-15 09:45:49 +01:00
Patrick Ohly
ced99383d5 logcheck: remove redundant entry for pkg/scheduler 
Contextual implies structured, so listing pkg/scheduler as contextual is
enough.
 2023-12-14 20:22:04 +01:00
Patrick Ohly
b450224c12 golangci-lint: inline logcheck configuration 
This has the advantage that the golangci-lint cache gets invalidated
automatically each time the logcheck config changes.
 2023-12-14 20:21:58 +01:00
Patrick Ohly
49084fe577 golangci-lint: logcheck v0.7.0, golangci-lint v1.55.2 
This adds support for the new golangci-lint plugin interface and settings
mechanism.
 2023-12-14 20:21:19 +01:00
Kubernetes Prow Robot
e12d4b63d6
Merge pull request #121773 from pohly/zapr-update 
dependencies: zapr v1.3.0, zap v1.26.0
 2023-12-14 18:14:22 +01:00
Kubernetes Prow Robot
485e57c395
Merge pull request #122250 from thockin/fix_verify-licenses 
Fix verify-licenses.sh
 2023-12-14 07:27:39 +01:00
Kubernetes Prow Robot
407c2c3015
Merge pull request #122230 from thockin/update-vendor_cleanups 
Small update-vendor cleanup
 2023-12-14 07:27:12 +01:00
Kubernetes Prow Robot
abb336b9c9
Merge pull request #122228 from thockin/cleaner_make_clean 
Simpler and less noisy make-clean
 2023-12-14 07:26:54 +01:00
Ricardo Lopes
86ab185fa1
Migrate client-go/metadata to contextual logging (#122225) 
* client-go: migrate metadata to contextual logging

Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>

* client-go: test for metadata contextual logs

Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>

* refactor: extract context for table driven testing

Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>

* refactor: pass context as first parameter

Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>

---------

Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>
 2023-12-14 07:26:45 +01:00
Kubernetes Prow Robot
909ad7e232
Merge pull request #121722 from danwinship/fix-typecheck 
Make verify-typecheck.sh only check valid targets for a platform
 2023-12-13 22:35:18 +01:00
Kubernetes Prow Robot
6d58ef4a7b
Merge pull request #121493 from BenTheElder/etcd-current 
automatically setup etcd when running {verify,update}-openapi-spec.sh
 2023-12-13 21:26:54 +01:00
Kubernetes Prow Robot
e8c265169b
Merge pull request #121478 from pohly/golangci-lint-message 
verify-golangci-lint.sh: clarify intended usage of warnings
 2023-12-13 21:26:45 +01:00
Sascha Grunert
1ae5594fb2
Update cni-plugins to v1.4.0 
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
 2023-12-13 09:33:31 +01:00
Tim Hockin
87c6b0d69f
Smallish update-vendor cleanup 2023-12-11 13:29:47 -08:00
Tim Hockin
7dfe3d866b
Fix verify-licenses.sh 
This still feels like a hack, but less horrible now.  Running this pases
without error.
 2023-12-09 17:48:48 -08:00
Tim Hockin
b9ff6b25f2
Simpler and less noisy make-clean 2023-12-08 09:20:44 -08:00
Davanum Srinivas
48671a3a20
explicitly stop/start docker to fix up local-up-cluster.sh 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2023-12-06 20:54:08 -05:00
Tim Hockin
37b7ae6b93
build: use -trimpath in non-DBG mode 2023-11-27 09:12:45 -08:00