Mike Spreitzer
008576da07
Improve and simplify maintenance of APF bootstrap objects
...
Prepare to make deletion of unwanted object conditional on ResourceVersion.
Remove unnecessary split between finding unwanted objects and removing
them.
Remove unnecessary layers of indirection to reach constant logic.
Use interfaces to remove need for type assertions.
Threaded context into APF object maintenance
Note and respect immutability of desired bootstrap objects
2023-05-05 09:36:48 -04:00
Patrick Ohly
5e1c6cd0d4
pkg/registry/flowcontrol: avoid race condition during Create
...
k8s.io/kubernetes/test/integration/controlplane.TestReconcilerAPIServerLeaseMultiCombined
suffered from race conditions. The underlying reason is that
330b5a2b8d/staging/src/k8s.io/apimachinery/pkg/runtime/helper.go (L221-L243)
2023-04-05 15:59:22 +02:00
Abu Kashem
424b23bb15
apiserver: fix defaulting for apf bootstrap configuration
2022-11-08 13:23:09 -08:00
Abu Kashem
66fc0d7037
rename assuredConcurrencyShares for flowcontrol v1beta3
2022-09-26 15:34:10 -04:00
Abu Kashem
0a99e6ebb1
apiserver: update apf logic to use v1beta3
2022-09-21 18:54:20 -04:00
Davanum Srinivas
a9593d634c
Generate and format files
...
- Run hack/update-codegen.sh
- Run hack/update-generated-device-plugin.sh
- Run hack/update-generated-protobuf.sh
- Run hack/update-generated-runtime.sh
- Run hack/update-generated-swagger-docs.sh
- Run hack/update-openapi-spec.sh
- Run hack/update-gofmt.sh
Signed-off-by: Davanum Srinivas <davanum@gmail.com >
2022-07-26 13:14:05 -04:00
Abu Kashem
df41fe5d84
apf: clarify with comment
2022-01-19 17:38:31 -05:00
Patrick Ohly
9eaa2dc554
avoid klog Info calls without verbosity
...
In the following code pattern, the log message will get logged with v=0 in JSON
output although conceptually it has a higher verbosity:
if klog.V(5).Enabled() {
klog.Info("hello world")
}
Having the actual verbosity in the JSON output is relevant, for example for
filtering out only the important info messages. The solution is to use
klog.V(5).Info or something similar.
Whether the outer if is necessary at all depends on how complex the parameters
are. The return value of klog.V can be captured in a variable and be used
multiple times to avoid the overhead for that function call and to avoid
repeating the verbosity level.
2022-01-12 07:48:36 +01:00
Mike Spreitzer
72403c8814
Concurrentize pkg/registry/flowcontrol/ensurer/strategy.go
...
Stop logging error messages when surprised by concurrent activity.
Concurrent activity is not an error, it is normal.
2022-01-04 22:55:21 -05:00
Kubernetes Prow Robot
9e209efd65
Merge pull request #107104 from tkashem/apf-use-v1beta2
...
apf: use v1beta2 in registry package
2022-01-04 13:06:42 -08:00
Abu Kashem
f30a34bc01
apf: use v1beta2 for registry
2021-12-17 10:35:37 -05:00
Ben Luddy
3f929b1634
Use a lister for bootstrap flowcontrol config objects.
...
Instead of listing all flowschemas and prioritylevelconfigurations on
each tick, read from local informer caches.
2021-10-20 11:40:00 -04:00
Abu Kashem
28f2b42a41
apf: update apf logic to use v1beta2
2021-09-09 08:28:58 -04:00
Abu Kashem
f9ee64007e
apf: always create missing bootstrap configuration object(s)
2021-05-17 12:08:39 -04:00
Abu Kashem
759a64136b
add auto update for apf bootstrap configuration
...
Take the following approach:
On a fresh install, all bootstrap configuration objects will
have auto update enabled via the following annotation :
`apf.kubernetes.io/autoupdate: 'true'`
The kube-apiserver periodically checks the bootstrap configuration
objects on the cluster and applies update if necessary.
We enforce an 'always auto-update' policy for the mandatory
configuration object(s).
We update the suggested configuration objects when:
- auto update is enabled (`apf.kubernetes.io/autoupdate: 'true'`) or
- auto update annotation key is missing but `generation` is `1`
If the configuration object is missing the annotation key, we add
it appropriately:
it is set to `true` if `generation` is `1`, `false` otherwise.
The above approach ensures that we don't squash changes made by an
operator. Please note, we can't protect the changes made by the
operator in the following scenario:
- the user changes the spec and then deletes and recreates
the same object. (generation resets to 1)
remove using a marker
2021-05-07 14:23:17 -04:00
