Commit Graph

17685 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
f0485f5098
Merge pull request #93557 from knight42/fix/snat-test
fix(e2e::network): refactor NoSNAT test
2020-08-01 20:21:41 -07:00
Kubernetes Prow Robot
0051d65f9f
Merge pull request #92954 from sbueringer/pr-fix-delete-orphan-test
conformance-tests: make orpan RS created by deployment test more resilient
2020-07-31 13:51:40 -07:00
Jing Xu
015f2998e5 Update e2e storage tests for Windows cluster
This PR fixes a few things for e2e storage suite to run on Windows
cluster.
1. increaes timeout due to longer pod startup time for windows
2. Only set SELinuxOptions or fsGroup if os is not windows
3. Add VolumeSnapshot delete policy for windows3. Add VolumeSnapshot
delete policy for windows3. Add VolumeSnapshot delete policy for windows
2020-07-31 10:09:28 -07:00
knight42
7b07b33094
fix(e2e::network): refactor NoSNAT test
Signed-off-by: knight42 <anonymousknight96@gmail.com>
2020-08-01 00:51:51 +08:00
wojtekt
76b3fe7f6d Wait for both endpoints and endpointslices in e2e tests 2020-07-31 17:24:53 +02:00
hasheddan
242176ab31
Make typecheck default parallelism 3
Typecheck is still hitting memory limits semi-regularly on periodic CI
jobs. This bumps the default parallelism down to 3 from 4 to make it
slightly less memory intensive.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
2020-07-31 07:42:31 -05:00
Claudiu Belu
72a26aed7d tests: Fixes variable expansion false positive test
Some of the tests are negative test cases which are supposed to ensure that those
invalid usecases are handled properly.

However, some of the tests are false positives, they can pass due to various reasons.
One such example is: "should fail substituting values in a volume subpath with absolute path".
This test can pass if:

- the Pod cannot start due to various reasons (e.g.: the container image cannot be pulled or does
  not exist).
- the Pod ran to completion, even though the container was not supposed to start in the first place.
2020-07-31 01:23:09 -07:00
Kubernetes Prow Robot
20fbf09c3e
Merge pull request #93551 from brianpursley/runtimeclass-e2e-fix
Remove special case for node e2e tests when expecting pod rejection
2020-07-30 23:53:06 -07:00
Kubernetes Prow Robot
62b8faed40
Merge pull request #93539 from Jefftree/conformance-format
Update formatting of conformance comment
2020-07-30 22:11:07 -07:00
Kubernetes Prow Robot
debcc37798
Merge pull request #93327 from aojea/dnsipv6
e2e dns test autodetect the IP family
2020-07-30 18:39:09 -07:00
James Sturtevant
faa84d61c7 mark this test serial due to race conditions 2020-07-30 15:41:22 -07:00
Jordan Liggitt
2cea9c5d51 Clean up daemonset test names 2020-07-30 17:33:38 -04:00
Hemant Kumar
20934d7e50 Create service for gluster endpoint
Creating an endpoint without a service can cause endpoint to disappear

https://github.com/kubernetes/kubernetes/issues/12964
2020-07-30 16:34:11 -04:00
Jordan Liggitt
c866cb7dd0 Make verify-typecheck detect errors better 2020-07-30 13:23:34 -04:00
Jordan Liggitt
7cbdb4fb14 Limit typecheck parallelism by default 2020-07-30 11:10:08 -04:00
Kubernetes Prow Robot
9af4ad5c45
Merge pull request #93550 from Huang-Wei/refix-postfilter-flake
Deflake scheduler PostFilter and Filter integration test
2020-07-30 04:30:31 -07:00
Luigi Bitonti
19793bd3fa Update k8s.io/utils dependency and use ebtables from there 2020-07-30 08:58:21 +01:00
Yecheng Fu
930409c993 integration: Wait for PV to be available 2020-07-30 13:37:20 +08:00
Jefftree
fca714f4b7 Fix conformance ordering 2020-07-29 20:50:45 -07:00
Jefftree
ace97738e2 Update formatting of conformance comment 2020-07-29 20:50:44 -07:00
Brian Pursley
6029346d0d Remove special case for node e2e tests when expecting pod rejection 2020-07-29 22:28:03 -04:00
Wei Huang
539272cb73
Deflake scheduler PostFilter and Filter integration test
- Revert "Fix integration test flake on TestFilter and TestPostFilter"
  This reverts commit 94fc18c2dc.
- Relax checking logic on expected Filter/PostFilter counters.
2020-07-29 18:37:47 -07:00
Wei Huang
0e71facefe
Hold Pod in cache until all other cleanup work is completed
- Move "ForgetPod" after "RunReservePluginsUnreserve", so that the cache would hold the pod to
  avoid it's being retried simutaneously until Unreserve is completed.
- Move "assume" ahead of "RunReservePluginsReserve". This is based on the fact that "ForgetPod" is
  the last step of failure path, so "assume" should be reversly treated as the first step. The
  current failure path is like this:
  assume -> reserve -> unreserve -> forgetPod -> recordingFailure
- Make subtests of TestReservePluginUnreserve stateless
2020-07-29 11:27:19 -07:00
Kubernetes Prow Robot
d3edcb7924
Merge pull request #93490 from Huang-Wei/flake-post-filter
Fix integration test flake on TestFilter and TestPostFilter
2020-07-29 08:59:48 -07:00
Kubernetes Prow Robot
aec30be5b3
Merge pull request #93433 from dcbw/netexec-errors
agnhost/netexec: logging cleanup and print more verbose errors
2020-07-28 21:04:01 -07:00
Kubernetes Prow Robot
01ae0ae8c6
Merge pull request #93429 from sjenning/fix-examples-template
e2e: examples: fix test image reference
2020-07-28 21:03:47 -07:00
Wei Huang
94fc18c2dc
Fix integration test flake on TestFilter and TestPostFilter 2020-07-28 20:51:01 -07:00
Kubernetes Prow Robot
f105cfc210
Merge pull request #93487 from ii/fix-missing-e2e-test-metadata
Add missing release metadata for e2e tests
2020-07-28 19:26:10 -07:00
Kubernetes Prow Robot
5ca6d567c4
Merge pull request #93086 from ii/heyste-create-delete-core-v1-collection-namespaced-pod-test
Promote Delete Collection Pods e2e test to conformance +1 endpoint coverage
2020-07-28 19:25:48 -07:00
Kubernetes Prow Robot
d2d8c63a87
Merge pull request #90939 from ii/ii-promote-endpoint-resource-lifecycle-test
Promote Endpoints resource lifecycle test - +4 endpoint coverage
2020-07-28 16:31:47 -07:00
Kubernetes Prow Robot
22329fbe13
Merge pull request #93495 from Huang-Wei/flake-node-affinity-priority
Fix an integration test flake on NodeAfffinity ScorePlugin
2020-07-28 14:21:47 -07:00
Kubernetes Prow Robot
498b1e2279
Merge pull request #93491 from robscott/endpointslice-test-logging
Improving logging in EndpointSlice e2e tests
2020-07-28 10:09:48 -07:00
Wei Huang
862fdaaf79
Fix an integration test flake on NodeAfffinity ScorePlugin 2020-07-28 08:57:02 -07:00
Kubernetes Prow Robot
8d74486a6a
Merge pull request #93497 from robscott/endpointslicemirroring-integration-fix
Increasing allowed delay for EndpointSlice mirroring integration tests
2020-07-28 04:13:08 -07:00
Rob Scott
eb196be139
Increasing allowed delay for EndpointSlice mirroring integration tests.
The shorter 5s delay had become a source of flakes.
2020-07-27 21:43:15 -07:00
Rob Scott
6051a16edd
Improving logging in EndpointSlice e2e tests
When these tests failed it was unclear that the reason for the failure
could have been more EndpointSlices than expected. It was also unclear
what EndpointSlices were actually found when that occurred. This fixes
both of those issues.
2020-07-27 21:36:51 -07:00
Wei Huang
8936f9e4bf
Fix integration test flake on TestScorePlugin 2020-07-27 18:13:38 -07:00
Stephen Heywood
1077a9e862 Add missing release metadata for e2e tests 2020-07-27 21:56:49 +00:00
Kubernetes Prow Robot
00da04ba23
Merge pull request #92163 from knight42/fix/large-cluster-network-e2e
fix(e2e::network): eliminate the dependency of external ips
2020-07-27 07:30:17 -07:00
yue9944882
40f3242cd9 apf integration test: ensure no rejection 2020-07-27 10:42:37 +08:00
Caleb Woodbine
e311df70e1 Promote Endpoint resource lifecycle test 2020-07-27 09:11:42 +12:00
Jordan Liggitt
f33dc28094 generated: hack/update-hack-tools.sh && hack/update-vendor.sh 2020-07-25 16:45:02 -04:00
Stephen Augustus
479249b3a3 [go1.15] dependencies.yaml: Update to go1.15rc1
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
2020-07-25 16:45:02 -04:00
Stephen Augustus
05ffc95347 [go1.15] Remove client support for darwin/386
Removed in go1.15 (GH/golang/go/issues/37610).

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
2020-07-25 16:45:01 -04:00
Kubernetes Prow Robot
17a2e5e990
Merge pull request #93402 from robscott/endpointslice-test-fix
Updating EndpointSlice e2e tests to be less flaky and easier to debug
2020-07-25 12:20:16 -07:00
Kubernetes Prow Robot
7348ab957c
Merge pull request #93356 from justaugustus/vdf
[VDF] Normalize container image references to k8s.gcr.io
2020-07-25 02:58:17 -07:00
Kubernetes Prow Robot
54e2070722
Merge pull request #93410 from nikhita/apimachinery-triage-labels
Don't apply triage/needs-information on apimachinery and instrumentation PRs
2020-07-24 19:08:16 -07:00
Kubernetes Prow Robot
c0a4d4b0b6
Merge pull request #93427 from liggitt/default-ingress-class
Mark default ingressclass tests serial, do not set default ingressclass in conformance
2020-07-24 14:26:30 -07:00
Kubernetes Prow Robot
6f7b6b6d13
Merge pull request #93426 from liggitt/test-certs
Add subjectAltName to test serving certificates
2020-07-24 14:26:16 -07:00
Dan Williams
31c563a46f agnhost/netexec: logging cleanup and print more verbose errors
There's currently no way to know whether an error is for SCTP or
UDP, for example:

Jul 24 09:55:54.469: INFO: netserver-0[e2e-nettest-3476].container[webserver].log
2020/07/24 09:53:52 Started UDP server
2020/07/24 09:53:52 Error occurred. error:protocol not supported

In this case the "Error occurred. error:protocol not supported" is
actually for the SCTP socket. Make that more apparent.
2020-07-24 14:40:58 -05:00
Rob Scott
3e4745ddaf
Updating EndpointSlice e2e tests to be less flaky and easier to debug
This adjusts tests that were waiting for Pods to be ready to instead
just wait for them to have IPs assigned to them. This relies on the
associated publishNotReadyAddresses field on Services. Additionally this
increases the the length of time we'll wait for EndpointSlices to be garbage
collected from 12s to 30s. Finally, this adds additional logging to
ExpectNoError calls so it's easier to understand where and why a test
failed.
2020-07-24 10:35:13 -07:00
Seth Jennings
78bdf89e50 e2e: examples: fix test image reference 2020-07-24 11:22:20 -05:00
Jordan Liggitt
4c203fd96e Mark default ingressclass tests serial, do not set default ingressclass in conformance 2020-07-24 12:12:20 -04:00
Nikhita Raghunath
3a74f461a2 Revert "Merge pull request #93160 from logicalhan/triage-instrumentation"
This reverts commit 1ed2cf1895, reversing
changes made to 04ecdb9eb6.
2020-07-24 18:09:07 +05:30
Kubernetes Prow Robot
607c5daabd
Merge pull request #93405 from liggitt/revert-pod-lifecycle-flake
Revert "Merge pull request #90942 from ii/ii-create-pod%2Bpodstatus-resource-lifecycle-test"
2020-07-24 04:30:22 -07:00
Kubernetes Prow Robot
55476fb872
Merge pull request #93373 from liggitt/deflake-pod-collection
Delete pod collection immediately
2020-07-24 02:08:22 -07:00
Nikhita Raghunath
c00dae0607 Revert "Merge pull request #93156 from logicalhan/triage-api-machinery"
This reverts commit 32438cf269, reversing
changes made to bb6a6aa391.
2020-07-24 13:01:02 +05:30
Jordan Liggitt
3fa8b15636 Revert "Merge pull request 92589 from ii/create-deployment-resource-lifecycle-test" 2020-07-24 00:30:13 -04:00
Jordan Liggitt
bf6f87c637 Revert "Merge pull request 90942 from ii/ii-create-pod%2Bpodstatus-resource-lifecycle-test" 2020-07-24 00:24:27 -04:00
Kubernetes Prow Robot
8a3fc2d7e2
Merge pull request #92589 from ii/create-deployment-resource-lifecycle-test
Create AppsV1Deployment resource lifecycle test - +6 endpoint coverage
2020-07-23 19:30:23 -07:00
Jordan Liggitt
c778008420 Shorten watch restart test, run in parallel 2020-07-23 17:17:29 -04:00
Kubernetes Prow Robot
8e5c02255c
Merge pull request #90942 from ii/ii-create-pod%2Bpodstatus-resource-lifecycle-test
Create Pod+PodStatus resource lifecycle test - +4 endpoint coverage
2020-07-23 13:54:23 -07:00
Jordan Liggitt
acce8871d6 Add subjectAltName to test serving certificates 2020-07-23 15:57:44 -04:00
Kubernetes Prow Robot
1ed2cf1895
Merge pull request #93160 from logicalhan/triage-instrumentation
auto triage sig-instrumentation tagged PRs
2020-07-23 11:19:26 -07:00
Kubernetes Prow Robot
04ecdb9eb6
Merge pull request #93332 from hasheddan/wait-for-owned
Wait for resources owned by pod to be cleaned up in sig-storage tests
2020-07-23 08:59:40 -07:00
Artyom Lukianov
ab7acb9ee3 e2e node: fix kubelet service restart failure
Under e2e tests possible the situation when we restart the kubelet
number of times in the short time frame. When it happens the systemd
can fail the service restart with the `Failed with result 'start-limit-hit'.`
error.

To avoid this situation the code will reset the kubelet service start failures
on each call to the kubelet restart command.

Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
2020-07-23 10:56:32 +03:00
Kubernetes Prow Robot
09e2230951
Merge pull request #92891 from ii/update-and-improve-endpoint-resource-lifecycle-test
Update and improve Endpoints resource lifecycle test
2020-07-23 00:31:40 -07:00
Kubernetes Prow Robot
77d5f10b82
Merge pull request #93340 from liggitt/test-name
Stabilize integration test names
2020-07-22 23:09:39 -07:00
Jordan Liggitt
6ef0fa6244 Delete pod collection immediately 2020-07-23 00:01:46 -04:00
Caleb Woodbine
642bed3c6c Update test images to use conformance images 2020-07-23 14:13:40 +12:00
Caleb Woodbine
ee29022ac8 Update test images to use conformance images 2020-07-23 14:07:01 +12:00
hasheddan
efe3747c22
Wait for resources owned by pod to be cleaned up in ephemeral volume tests
sig-storage tests that delete pods need to wait for owned resources to
also be cleaned up before returning in the case that resources such as
ephemeral inline volumes are being used. This was previously implemented
by modifying the pod delete call of the e2e framework, which negatively
impacted other tests. This was reverted and now the logic has been moved
to StopPodAndDependents, which is local to the sig-storage tests.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
2020-07-22 17:52:19 -05:00
Kubernetes Prow Robot
2fbe301b2d
Merge pull request #93296 from chelseychen/event-e2e-conformance
Add conformance test for events Update operation
2020-07-22 13:51:41 -07:00
Caleb Woodbine
c9acca7c48 Update and improve Endpoints resource lifecycle test 2020-07-23 08:42:07 +12:00
Stephen Augustus
99dd7570eb [VDF] Remove references to gcr.io/google-containers
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
2020-07-22 16:10:12 -04:00
Stephen Augustus
90c223fa5c [VDF] Remove references to us.gcr.io/k8s-artifacts-prod
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
2020-07-22 16:08:30 -04:00
Jordan Liggitt
8f9be8af13 Stabilize integration test names 2020-07-22 11:58:54 -04:00
Kubernetes Prow Robot
c2b7aa0353
Merge pull request #93000 from hakman/node-os-arch
Skip arch dependent kubectl test for non AMD64 nodes
2020-07-22 04:28:05 -07:00
Antonio Ojea
4bbf2c4a3e e2e dns test autodetect the IP family
instead of using tag to discriminate the e2e test, we can use
the e2e framework IPFamily method.
2020-07-22 12:23:21 +02:00
Caleb Woodbine
080ad0990a Add logs for Pod observations while watching for a running state 2020-07-22 16:44:18 +12:00
Caleb Woodbine
a0861aeb52 Fix fmt and staticcheck 2020-07-22 15:23:56 +12:00
Kubernetes Prow Robot
b0140227fb
Merge pull request #93306 from bart0sh/PR0092-revert-foreground-deletion
Revert "e2epod: use foreground deletion"
2020-07-21 19:52:43 -07:00
Kubernetes Prow Robot
32438cf269
Merge pull request #93156 from logicalhan/triage-api-machinery
automatically assign triage labels to api-machinery tagged PRs
2020-07-21 19:52:34 -07:00
Caleb Woodbine
d26cb7150a Remove created check 2020-07-22 13:55:29 +12:00
Caleb Woodbine
84de375921 Fix error message 2020-07-22 11:17:37 +12:00
Caleb Woodbine
d60a57ad73 Update watches to use watchtools.Until, namespace var name 2020-07-22 10:33:55 +12:00
Caleb Woodbine
bd34e1c445 Fix label patch and check 2020-07-22 10:07:18 +12:00
Caleb Woodbine
11492f7b91 Add check for Modified after patch; Update checks for scale 2020-07-22 09:57:11 +12:00
Caleb Woodbine
fc8e24c686 Add watchtools.Until for fetching watch events; Remove plain watch 2020-07-22 09:29:09 +12:00
Caleb Woodbine
9c2330db4c Revert ginkgoRecover 2020-07-22 08:48:28 +12:00
Ed Bartosh
6a40cc90e9 Revert "e2epod: use foreground deletion"
This reverts commit af91e76d "e2epod: use foreground deletion"
and fixes node-kubelet-conformance tests.
2020-07-21 22:40:31 +03:00
Chelsey Chen
5b1bdd8e38 Add comformance test for event Update 2020-07-21 14:53:26 -04:00
Kubernetes Prow Robot
a1a2f8c5f8
Merge pull request #93225 from hasheddan/storage-panic
Return error instead of panic if container index outside bounds
2020-07-21 09:15:15 -07:00
Kubernetes Prow Robot
adabcc31f0
Merge pull request #93212 from liggitt/gcepd-delete
Deflake GCEPD namespace deletion test
2020-07-21 01:55:28 -07:00
Stephen Heywood
86ba88d52f Promote: Discovery PreferredVersion test 2020-07-21 00:30:25 +00:00
Kubernetes Prow Robot
5feab0aa1e
Merge pull request #93207 from hasheddan/nvidia-gpu-installer
Use local daemonset manifest for installing Nvidia drivers
2020-07-20 09:02:51 -07:00
Kubernetes Prow Robot
c237804533
Merge pull request #92755 from chelseychen/event-e2e-conformance
Promote Event CRUD tests to conformance
2020-07-20 05:50:51 -07:00
Caleb Woodbine
125e839d77 Fix formatting 2020-07-20 13:16:35 +12:00
Caleb Woodbine
05163497bc Fix bazel build 2020-07-20 11:15:57 +12:00
Caleb Woodbine
b38d7f25fe Remove watch tooling 2020-07-20 11:00:37 +12:00
Caleb Woodbine
dc30156fb8 Update error handling formatting, handling of type conversion in watch event loop 2020-07-20 10:03:49 +12:00
Caleb Woodbine
6e04fbdde1 Update error statements 2020-07-20 10:03:49 +12:00
Caleb Woodbine
a2c19d7ae0 Add watch checks 2020-07-20 10:03:49 +12:00
Caleb Woodbine
a4e29f2481 Fix formatting 2020-07-20 10:03:49 +12:00
Caleb Woodbine
cb7835bcb0 Add check for unmarshalling onto a Pod object type 2020-07-20 10:03:49 +12:00
Caleb Woodbine
c6a86b5fed Fix test to use values from v1, wording; Update variables to be more templatable 2020-07-20 10:03:49 +12:00
Caleb Woodbine
47cd8dde56 Update to check response data of UpdateStatus instead of listing after updating the status 2020-07-20 10:03:49 +12:00
Caleb Woodbine
19e9368eb8 Create Pod+PodStatus resource lifecycle test 2020-07-20 10:03:49 +12:00
Kubernetes Prow Robot
363c3b89f5
Merge pull request #93198 from justaugustus/go1146
Update Golang to v1.14.6
2020-07-19 09:10:50 -07:00
hasheddan
4e4d629af7
Return error instead of panic if container index outside bounds
Adds check for index out of bounds error instead of panic when passing
container to kubectl exec.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
2020-07-19 10:04:53 -05:00
Kubernetes Prow Robot
66020d2292
Merge pull request #93110 from dims/adding-dims-as-reviewer-for-test
Adding dims as reviewer for test/
2020-07-19 04:32:50 -07:00
Kubernetes Prow Robot
92e471a0bd
Merge pull request #93216 from liggitt/deflake-preferred-version
Deflake PreferredVersion e2e test
2020-07-18 21:44:50 -07:00
Jordan Liggitt
9718e7906f Deflake PreferredVersion e2e test 2020-07-18 22:51:56 -04:00
hasheddan
e990698d5f
Use local daemonset manifest for installing Nvidia drivers
Updates sig-scheduling e2e Nvidia GPU tests to install drivers using
local manifest by default. Currently the DaemonSet is fetched from the
GoogleCloudPlatform/container-enginer-accelerators repo by default.
Using a local manifest allows for manually specifying the image
cos-gpu-installer image rather than always using latest. A remote
manifest can still be fetched by setting
NVIDIA_DRIVER_INSTALLER_DAEMONSET env var.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
2020-07-18 21:01:00 -05:00
Kubernetes Prow Robot
a789d56b65
Merge pull request #93119 from dcbw/e2e-ingress-misisng-return
test/e2e/ingress: add missing return to fix panics on !GCE
2020-07-18 13:58:49 -07:00
Jordan Liggitt
9d83ca4b02 Deflake GCEPD namespace deletion test 2020-07-18 15:32:02 -04:00
Kubernetes Prow Robot
3a0b683c01
Merge pull request #93084 from ii/heyste-get-code-version-test
Promote Check Server Version e2e test to conformance - 1 Endpoint Coverage
2020-07-18 06:14:50 -07:00
Stephen Augustus
3bbcba9b84 Update Golang to v1.14.6
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
2020-07-17 14:47:21 -04:00
Kenichi Omichi
80c19e4cef Move MasterUpgrade() out from e2e framework
MasterUpgrade() is called only from cloud/gcp/cluster_upgrade.go.
And the function depends on GCP, so it is nice to move this function
from e2e framework.
2020-07-17 18:27:35 +00:00
Kubernetes Prow Robot
f9ad7db9a6
Merge pull request #92349 from jingyih/update_etcd_server_3p4p9
Update default etcd server to 3.4.9
2020-07-17 07:53:01 -07:00
Kubernetes Prow Robot
a3e3b355fa
Merge pull request #92619 from ii/heyste-get-apigroup-list-test
Write checkAPIGroupPreferredVersion Test - +16 Endpoint coverage
2020-07-17 02:51:01 -07:00
Kubernetes Prow Robot
23b66eaabd
Merge pull request #93038 from ii/fix-ingress-status
Write readNetworkingV1NamespacedIngressStatus test - +1 endpoint coverage
2020-07-16 23:05:00 -07:00
Stephen Heywood
ca550a280a Relocate preferred version e2e test to discovery.go 2020-07-16 21:13:55 +00:00
Stephen Heywood
6e3919fae7 Check that empty sets are passed through the test 2020-07-16 20:50:14 +00:00
Stephen Heywood
a0410c8789 Claify the intention of the e2e test 2020-07-16 20:50:14 +00:00
Stephen Heywood
f886164491 Validate that PreferredVersion contains a valid option 2020-07-16 20:50:14 +00:00
Stephen Heywood
e81b6dce15 Update BUILD 2020-07-16 20:50:14 +00:00
Stephen Heywood
bc873c192c Fix naming for apigroup list 2020-07-16 20:50:14 +00:00
Stephen Heywood
dcf72dfd32 Update bazel BUILD 2020-07-16 20:50:14 +00:00
Stephen Heywood
a9cb510c7f Fix test name and log formatting 2020-07-16 20:50:14 +00:00
Stephen Heywood
6a6ccbc45c Add e2e test for get*APIGroupList endpoints 2020-07-16 20:50:14 +00:00
Han Kang
f3c02d7221 auto triage sig-instrumentation tagged PRs
Change-Id: Ibae7373fb197485aeb222f1455515178cc3b4d13
2020-07-16 13:48:25 -07:00
Han Kang
9129dbc98b automatically assign triage labels to api-machinery tagged PRs
Change-Id: Ifcc8a85d190d6370423af27f6e6c4c90b8472981
2020-07-16 13:13:59 -07:00
Dan Williams
e24f9ed1cd test/e2e/ingress: add missing return to fix panics on !GCE
A missing 'return' causes the AfterEach() to try to clean up
GCE ingress objects when they haven't been created, because
the test was skipped in BeforeEach().

2020-07-15T17:21:10.3690332Z [BeforeEach] GCE [Slow] [Feature:kubemci]
2020-07-15T17:21:10.3690715Z   /home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/network/ingress.go:592
2020-07-15T17:21:10.3690970Z Jul 15 17:21:10.368: INFO: Only supported for providers [gce gke] (not )
2020-07-15T17:21:10.3694003Z [AfterEach] GCE [Slow] [Feature:kubemci]
2020-07-15T17:21:10.3696927Z   /home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/network/ingress.go:614
2020-07-15T17:21:10.3697845Z [1mSTEP[0m: No ingress created, no cleanup necessary
2020-07-15T17:21:10.3698213Z [1mSTEP[0m: Cleaning up cloud resources
2020-07-15T17:21:15.3709789Z E0715 17:21:15.370134   78875 runtime.go:78] Observed a panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer dereference)
2020-07-15T17:21:15.3710883Z goroutine 63 [running]:
2020-07-15T17:21:15.3711892Z [AfterEach] [sig-network] Loadbalancing: L7
2020-07-15T17:21:15.3712802Z k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/runtime.logPanic(0x40215e0, 0x7b71700)
2020-07-15T17:21:15.3713654Z   /home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/framework/framework.go:179
2020-07-15T17:21:15.3714871Z 	/home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:74 +0xa3
2020-07-15T17:21:15.3715130Z Jul 15 17:21:15.370: INFO: Waiting up to 3m0s for all (but 0) nodes to be ready
2020-07-15T17:21:15.3715703Z k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/runtime.HandleCrash(0x0, 0x0, 0x0)
2020-07-15T17:21:15.3716215Z 	/home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:48 +0x82
2020-07-15T17:21:15.3716610Z panic(0x40215e0, 0x7b71700)
2020-07-15T17:21:15.3717184Z 	/opt/hostedtoolcache/go/1.13.4/x64/src/runtime/panic.go:679 +0x1b2
2020-07-15T17:21:15.3717803Z k8s.io/kubernetes/test/e2e/framework/providers/gce.(*IngressController).deleteForwardingRule(0x0, 0x0, 0xc0034cce04, 0x2)
2020-07-15T17:21:15.3718372Z 	/home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/framework/providers/gce/ingress.go:158 +0x20b
2020-07-15T17:21:15.3718859Z k8s.io/kubernetes/test/e2e/framework/providers/gce.(*IngressController).Cleanup(0x0, 0x0, 0x1, 0xc0034ccd68)
2020-07-15T17:21:15.3719369Z 	/home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/framework/providers/gce/ingress.go:724 +0x38
2020-07-15T17:21:15.3719947Z k8s.io/kubernetes/test/e2e/framework/providers/gce.(*IngressController).CleanupIngressControllerWithTimeout.func1(0xc0034ccd78, 0xc00315e8a0, 0xc0002acf88)
2020-07-15T17:21:15.3720474Z 	/home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/framework/providers/gce/ingress.go:88 +0x33
2020-07-15T17:21:15.3720968Z k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait.runConditionWithCrashProtection(0xc0034ccfa0, 0xc0034cce00, 0x0, 0x0)
2020-07-15T17:21:15.3721508Z 	/home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:211 +0x6f
2020-07-15T17:21:15.3722020Z k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait.WaitFor(0xc003393120, 0xc0034ccfa0, 0xc00341ae40, 0x0, 0x0)
2020-07-15T17:21:15.3722542Z 	/home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:528 +0x159
2020-07-15T17:21:15.3723233Z k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait.pollInternal(0xc003393120, 0xc0034ccfa0, 0x0, 0x0)
2020-07-15T17:21:15.3723771Z 	/home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:414 +0x9f
2020-07-15T17:21:15.3724305Z k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait.Poll(0x12a05f200, 0xd18c2e2800, 0xc0034ccfa0, 0xc0000a4940, 0xc0034ccfb0)
2020-07-15T17:21:15.3724872Z 	/home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:408 +0x4d
2020-07-15T17:21:15.3725377Z k8s.io/kubernetes/test/e2e/framework/providers/gce.(*IngressController).CleanupIngressControllerWithTimeout(0x0, 0xd18c2e2800, 0x0, 0x0)
2020-07-15T17:21:15.3726709Z 	/home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/framework/providers/gce/ingress.go:87 +0x69
2020-07-15T17:21:15.3743725Z k8s.io/kubernetes/test/e2e/framework/providers/gce.(*IngressController).CleanupIngressController(...)
2020-07-15T17:21:15.3744385Z 	/home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/framework/providers/gce/ingress.go:81
2020-07-15T17:21:15.3744822Z k8s.io/kubernetes/test/e2e/network.glob..func10.4.2()
2020-07-15T17:21:15.3745340Z 	/home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/network/ingress.go:626 +0x12a
2020-07-15T17:21:15.3745868Z k8s.io/kubernetes/vendor/github.com/onsi/ginkgo/internal/leafnodes.(*runner).runSync(0xc000e17740, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
2020-07-15T17:21:15.3746756Z 	/home/runner/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/onsi/ginkgo/internal/leafnodes/runner.go:113 +0xb8

Fixes: 0f81362fa0
2020-07-16 14:56:08 -05:00
Kubernetes Prow Robot
6a8129f7f6
Merge pull request #92957 from r4f4/override-volume-images
Make nested /volume/ repo images overridable
2020-07-16 06:31:41 -07:00
Kubernetes Prow Robot
bd9be7b544
Merge pull request #93113 from hasheddan/integration-skip
Skip failing scheduler integration tests until they can be run successfully
2020-07-16 00:07:41 -07:00
Kubernetes Prow Robot
1f4da99f69
Merge pull request #92813 from ii/heyste-create-delete-core-v1-collection-namespaced-event-test
Promote deleteCoreV1CollectionNamespacedEvent test - +1 endpoint coverage
2020-07-15 19:16:34 -07:00
Michelle Au
10a8c195a1 Export WaitForCSIDriverRegistrationOnAllNodes to be used by external csi driver repos
Change-Id: Ie61430b1050a778d8ba98177e0c995ff2553f9cd
2020-07-15 16:53:37 -07:00
Kubernetes Prow Robot
8c300565c2
Merge pull request #90941 from ii/ii-promote-configmap-lifecycle
Promote: ConfigMap Lifecycle test - +2 conformance endpoint coverage
2020-07-15 15:28:48 -07:00
hasheddan
a70b78e49a
Skip failing scheduler integration tests until they can be run successfully
The IPAM and scheduler performance tests are currently causing
integration-master job to fail because of timeouts. They were not
previously running as part of integration-master, so we can disable them
without loss of test coverage. They should be re-enabled as part of fix
for #93112.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
2020-07-15 10:28:35 -05:00
Davanum Srinivas
16fb6733a1
Adding dims as reviewer for test/
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-07-15 07:19:53 -04:00
Stephen Augustus
c4b6678757 Update Golang to v1.14.5
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
2020-07-15 00:10:05 -04:00
Kubernetes Prow Robot
c46c1c043e
Merge pull request #91742 from jingxu97/June/wintests
Fix subPath tests for Windows
2020-07-13 23:29:21 -07:00
Kubernetes Prow Robot
e45a598a5c
Merge pull request #93029 from rajansandeep/fixfailtests
Fix failing DNS tests by removing deprecated option
2020-07-13 20:21:35 -07:00
Stephen Heywood
44cd9d3cfe Promote delete collection pods e2e test to conformance 2020-07-14 02:56:54 +00:00
Stephen Heywood
236ad47783 Promote server version e2e test to conformance 2020-07-14 02:22:07 +00:00
Kubernetes Prow Robot
6079cebfae
Merge pull request #90187 from julianvmodesto/last-applied-updater
Implement server-side apply upgrade and downgrade
2020-07-13 16:45:20 -07:00
Kenichi Omichi
c86caa608d Move WatchUntilWithoutRetry() from e2e framework
WatchUntilWithoutRetry() is called from e2e/apps/rc.go only.
So this moves the function to reduce e2e/framework/util.go code.
2020-07-13 22:54:41 +00:00
Stephen Heywood
31962804c0 Update bazel BUILD 2020-07-13 20:40:11 +00:00
Ciprian Hacman
5d87704ed3 Skip arch dependent kubectl test for non AMD64 nodes 2020-07-13 20:25:14 +03:00
Ciprian Hacman
33ac3c36cc Add new flags for node arch 2020-07-13 20:25:14 +03:00
Sandeep Rajan
211448759c Fix failing DNS tests by removing deprecated upstream option 2020-07-13 12:53:19 -04:00
Chelsey Chen
7e04ffbc31 Promote Event CRUD tests to conformance 2020-07-13 09:50:23 -04:00
Stephen Heywood
d055eb5f61 Ingress: Add test for API get /status 2020-07-13 10:33:00 +00:00
Gaurav Singh
22dc4744a0 [test/kubelet]: Fix deadlock in watch manager test
Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>
2020-07-12 10:56:28 -04:00
Kubernetes Prow Robot
53334f063f
Merge pull request #92908 from RobertKielty/error_text_clarification
fixes 92907 improves test error output
2020-07-12 06:59:16 -07:00
Kubernetes Prow Robot
8da9e9b326
Merge pull request #92902 from k-toyoda-pi/unset_alias_metrics_grabber
e2e/metrics_grabber: unset aliases for ginkgo and gomega packages
2020-07-12 06:58:57 -07:00
Stefan Bueringer
06e8780818
conformance-tests: make orpan RS created by deployment test more resilient 2020-07-12 07:51:24 +02:00
Kubernetes Prow Robot
888255bf3a
Merge pull request #92879 from liggitt/short-integration-tests
Skip expensive integration tests in short run mode
2020-07-11 20:57:52 -07:00
Kubernetes Prow Robot
c23a4b08d7
Merge pull request #92874 from chelseychen/event-api
Fix a few places where source field is empty when creating events via events/v1
2020-07-11 20:57:31 -07:00
Kubernetes Prow Robot
d2f4cc032b
Merge pull request #92841 from chethanv28/fix-typo-e2e-tests
Fix typo in vsphere e2e test names
2020-07-11 20:56:33 -07:00
Kubernetes Prow Robot
780f7f0ce9
Merge pull request #92555 from AndiLi99/AndiLi99/snapshot_tests
Refactor tests in snapshottable and fix #73625
2020-07-11 20:55:35 -07:00
Kubernetes Prow Robot
70f68dbf74
Merge pull request #92856 from saschagrunert/psp-seccomp-ga
Implement PodSecurityPolicy enforcement for seccomp GA
2020-07-11 15:35:22 -07:00
hasheddan
a527c10edc
Make sure pod tested for eviction with PDB is not scheduled for deletion
In #91342 attempting to evict a Pod with a DeletionTimestamp caused
checking of PDBs to be ignored due to the fact that a Pod scheduled for
deletion should not be factored into a disruption budget. However, PDB
eviction tests currently will sometimes select a Pod already scheduled
for deletion, expecting that attempting to evict it will conflict with
the PDB. This updates those tests to make sure a Pod with deletion
timestamp is not selected for eviction when it is intended to violate a
PDB.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
2020-07-11 11:25:19 -05:00
Nikhita Raghunath
cb2fb92686 test/images/pets: remove OWNERS to cleanup inactive members
bprashanth hasn't be active since the release of v1.11. Removing them
from test/images/pets/OWNERS would leave mkumatag as the sole approver.

But mkumatag is also an approver for test/images/OWNERS so this commit
removes the test/images/pets/OWNERS completely.

Note: we should try to find more OWNERS for test/images/pets instead,
but this cleanup is a short term solution to avoid the bot suggesting
inactive members for reviews and approval.
2020-07-11 19:35:47 +05:30
Kenichi Omichi
029b2d2197 Remove DeprecatedMightBeMasterNode()
This removes DeprecatedGetMasterAndWorkerNodes() usage from vsphere e2e
test as deprecated function cleanup.
Then all callers of DeprecatedMightBeMasterNode() have been removed.
So this removes DeprecatedMightBeMasterNode() itself also.
2020-07-11 03:18:44 +00:00
Kubernetes Prow Robot
93e76f5081
Merge pull request #92442 from tedyu/grace-period-with-map
Respect grace period when removing mirror pod
2020-07-10 17:49:23 -07:00
Kubernetes Prow Robot
cccb28bb5e
Merge pull request #92812 from ii/heyste-create-delete-core-v1-collection-namespaced-pod-template-test
Promote DeleteCoreV1CollectionNamespacedPodTemplate test+promote - +1 endpoint
2020-07-10 15:43:01 -07:00
Kubernetes Prow Robot
42ae2003dd
Merge pull request #92805 from chethanv28/fix-e2e-test-vsphere_utils
Fix vsphere util method - disksAreAttached
2020-07-10 15:42:51 -07:00
Kubernetes Prow Robot
2613cbc2a7
Merge pull request #92802 from divyenpatel/fix-e2e-test-vsphere_volume_datastore
fixed e2e test vsphere_volume_datastore.go
2020-07-10 15:42:41 -07:00
Kubernetes Prow Robot
0cb7e320a5
Merge pull request #92784 from pohly/generic-ephemeral-inline-volumes
generic ephemeral inline volumes
2020-07-10 15:41:46 -07:00
Kubernetes Prow Robot
49dced762d
Merge pull request #92661 from jpbetz/smd-bump-field-unsetting
Bump to SMD PR#166 to pick up unsetting field changes and add integration tests
2020-07-10 15:41:05 -07:00
Kubernetes Prow Robot
4efed03276
Merge pull request #91637 from robscott/endpointslice-mirroring
Adding new EndpointSlice Mirroring Controller
2020-07-10 10:19:48 -07:00
Sascha Grunert
96fb83c4c1
Implement PodSecurityPolicy enforcement for seccomp GA
This implements the necessary pieced for the PodSecurityPolicy
enforcement like described in the appropriate KEP section:

https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/20190717-seccomp-ga.md#podsecuritypolicy-enforcement

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
2020-07-10 15:55:21 +02:00
Rafael Fonseca
74183e0d88 Make nested /volume/ repo images overridable
The multi-arch container images used in tests live in quay.io which
doesn't support nesting. By making the /volume/ images repo configurable,
we are able to override them despite our current limitation.

Signed-off-by: Rafael Fonseca <r4f4rfs@gmail.com>
2020-07-10 13:37:12 +02:00
Patrick Ohly
2468a24b7a GenericEphemeralVolume: E2E test
This extends the existing "ephemeral volume" tests to also cover
generic ephemeral inline volumes. They get instantiated for all
drivers (CSI and others) which support persistent volume provisioning,
for several different filesystems.

Configuring the number of inline volumes via a flag with a computed
name had been identified as problematic before and now gets removed
because re-using the tests as a stress test with a higher number of
volumes should be added and configured separately.
2020-07-09 23:29:24 +02:00
Stephen Heywood
9520a87488 Fix metadata formatting 2020-07-09 21:16:22 +00:00
Jing Xu
31db94c848 Fix subPath tests for Windows
Windows test for subPath is failing due to an issue related to
removeUnusedContainers calls. After image is changed to Agnhost, it
automatically has a args by default. However, there are places to use
container commands instead of args and causing issues.

This is the first step to fix this issue. Next plan to replace
busybox used in Linux with Agnhost which can work for both linux and
windows.

I also mark two subPath tests as LinuxOnly. I think they are not ready
for windows yet. Before they were passing due to wrong reason. The tests
checks failed container status but the contain fails due to other
reasons than what we expected.
2020-07-09 11:14:17 -07:00
Andi Li
b64f05b70a Change expected content to string constant. Cleanup DeleteAndWaitSnapshot
Use the correct format specifier
2020-07-09 16:30:16 +00:00
Kubernetes Prow Robot
1b4e904183
Merge pull request #92745 from hakman/disruption-image-busybox
Use Pause image for DisruptionController tests
2020-07-09 09:10:00 -07:00
Kubernetes Prow Robot
026cd0e2d7
Merge pull request #92709 from knabben/e2e-kubelet-config
Fetching Kubelet address from Kubelet configuration for e2e test
2020-07-09 09:09:28 -07:00
Kubernetes Prow Robot
883e4eb487
Merge pull request #92627 from oomichi/remove-Deprecated
Add nodeHasControlPlanePods()
2020-07-09 09:07:45 -07:00
Kubernetes Prow Robot
1f89f42602
Merge pull request #92621 from spiffxp/simplify-configmap-lifecycle-test
Simplify ConfigMap lifecycle e2e test
2020-07-09 09:07:31 -07:00
Kubernetes Prow Robot
fe43b104ba
Merge pull request #91745 from Bisnode/gh-87369
Presence of bearer token should cancel exec action
2020-07-09 09:07:00 -07:00
Kubernetes Prow Robot
6dd8d7131f
Merge pull request #91529 from bart0sh/PR0090-remove-benchmark.yaml
Remove unused e2e test image config
2020-07-09 09:06:46 -07:00
Kubernetes Prow Robot
d9b084a9d1
Merge pull request #89629 from fatedier/subpath
Modified subpath configmap mount fails when container restarts
2020-07-09 09:06:32 -07:00
Joe Betz
3c2842fbc6 Add ownership transfer test 2020-07-09 06:18:59 -07:00
Joe Betz
ec136db9ce Add server side apply unsetting field tests 2020-07-09 06:18:58 -07:00
Patrick Ohly
af91e76df8 e2epod: use foreground deletion
This is useful in case that the pod owns some resources, because then
waiting for the pod ensures that those resources also were removed.

This should not matter at the moment because pods typically are not
owners of any other object, but that will change with the introduction
of generic ephemeral inline
volumes (https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/1698-generic-ephemeral-volumes).
2020-07-09 11:03:03 +02:00
Kubernetes Prow Robot
2e6d06c13a
Merge pull request #92479 from ii/heyste-delete-core-v1-collection-namespaced-pod-test
Create deleteCoreV1CollectionNamespacedPod test - +1 endpoint coverage
2020-07-09 00:05:10 -07:00
Kubernetes Prow Robot
94a08e159a
Merge pull request #92387 from pohly/csi-storage-capacity
CSI storage capacity check
2020-07-09 00:04:59 -07:00
Julian V. Modesto
e4368eb67e Implement server-side apply upgrade & downgrade.
- Allow client-side to server-side apply upgrade.

  Ensure that a user can change management of an object from client-side apply to
  server-side apply without conflicts.

- Allow server-side apply to client-side downgrade.

  For an object managed with client-side apply, a user may upgrade to
  managing the object with server-side apply, then decide to downgrade.

  We can support this downgrade by keeping the last-applied-configuration
  annotation for client-side apply updated with server-side apply.
2020-07-08 19:14:03 -04:00
Ted Yu
a76a959294 Respect grace period when removing mirror pod
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2020-07-08 13:38:24 -07:00
Andi Li
913f626adb Add data semantics test for volume snapshots
The test steps are as follows:
1. Write some data
2. Take a snapshot
3. Write more data
4. Create a new volume from snapshot
5. Validate data is the old data
2020-07-08 18:45:54 +00:00
Andi Li
9b0dff7686 Refactor snapshottable and provisioning tests
1. Use ginkgo before each to do common setup
2. Use volume resource to create SC, PV, PVC and handle cleanup
3. Add SnapshotResource to handle creating and cleanup of VS, VSC, VSClass
4. Add test pattern for deletion policy: Delete vs Retain
5. Use test pattern to determine test behaviour
6. Add test pattern for preprovisioned snapshot (not implemented)

These changes are made to consolidate common setup steps and stop resource
leaks by waiting for objects to be deleted.
2020-07-08 18:45:54 +00:00
Wei Huang
d65a97848e
codegen 2020-07-08 09:58:42 -07:00
Wei Huang
4b26ef2217
Remove DisablePreemption field from SchedulerConfig v1beta1
DisablePreemption field can be removed as it can be deduced from PostFilterPlugins.
2020-07-08 09:58:42 -07:00
RobertKielty
8e1548f24b lowercases start of the fmt.Errorf msg as per convention, fixes spelling error 2020-07-08 14:31:41 +01:00
Chelsey Chen
e010436e2a Update conversion between ReportingController and Source.Component 2020-07-08 08:46:38 -04:00
RobertKielty
10bdcb8ef1 fixes 92907 improves test error output 2020-07-08 13:10:50 +01:00