Wojciech Tyczynski
b675b2230c
Avoid unnecessary decoding in etcd3 client
2016-10-11 10:38:46 +02:00
Hongchao Deng
2516ab058d
etcd3 watcher: use prevKV for prevObj
2016-10-10 09:46:40 -07:00
Kubernetes Submit Queue
b5145e1924
Merge pull request #34322 from wojtek-t/cacher_improvements
...
Automatic merge from submit-queue
Improve some logging in cacher
2016-10-08 00:38:48 -07:00
deads2k
518d5500c7
remove testapi.Default.GroupVersion
2016-10-07 10:10:54 -04:00
Wojciech Tyczynski
c02df26ad6
Improve some logging in cacher
2016-10-07 15:04:08 +02:00
Wojciech Tyczynski
d70a9615ec
Minor clearnup in etcd3 code
2016-10-06 15:38:34 +02:00
Wojciech Tyczynski
90bc19959d
Extend logging in cacher to understand its bottleneck
2016-10-06 10:57:46 +02:00
Wojciech Tyczynski
82c360a252
Make gets for previous value in watch serializable
2016-10-05 13:18:31 +02:00
Hongchao Deng
35917e552a
revert #32012 (Unshare cluster in each test suite)
...
Since #33393 is merged, the bug should have been fixed.
2016-09-27 09:38:18 -07:00
Hongchao Deng
6f3ac807fd
pass SelectionPredicate instead of Filter to storage layer
2016-09-26 09:47:19 -07:00
Kubernetes Submit Queue
331eb83585
Merge pull request #33376 from luxas/fix_arm_atomics_2
...
Automatic merge from submit-queue
Move HighWaterMark to the top of the struct in order to fix arm, second time
ref: #33117
Sorry for not fixing everyone at once, but I seriously wasn't prepared for that quick LGTM 😄 , so here's the other half.
@lavalamp
> lgtm, but seriously, this is terrible, we probably have this bug all over. And what if someone embeds the etcdWatcher struct in something else not at the top? We need the compiler to enforce things like this, it just can't be done manually. Can you file or link a golang issue for this?
I totally agree! There isn't currently a way of programmatically detecting this unfortunately.
I guess @davecheney or @minux can explain better to you why it's so hard.
This is noted in https://github.com/kubernetes/kubernetes/blob/master/docs/proposals/multi-platform.md as a corner case indeed.
@pwittrock This should be cherrypicked toghether with #33117
2016-09-23 12:05:09 -07:00
Lucas Käldström
06917531b3
Move HighWaterMark to the top of the struct in order to fix arm, second time
2016-09-23 20:58:28 +03:00
Madhusudan.C.S
c1f0d91c2a
Dereference the UID pointer for a readable error message.
2016-09-22 20:34:06 -07:00
Kubernetes Submit Queue
d323fed024
Merge pull request #33003 from hongchaodeng/etcd_fix2
...
Automatic merge from submit-queue
stop etcd watcher when watch chan is closed
When startWatching() stops due to the watch chan is closed, the watcher could still keeps running in the background. When this case happen, we should stop the watcher entirely and close ResultChan() too.
2016-09-20 20:21:24 -07:00
Hongchao Deng
8e3b40735a
stop etcd watcher when watch chan is closed
2016-09-20 12:45:28 -07:00
Lucas Käldström
519379138d
Move HighWaterMark to the top of the struct in order to fix 32-bit platforms
2016-09-20 22:44:56 +03:00
Hongchao Deng
5a4a095e29
etcd watcher: centralize error handling
2016-09-16 15:31:49 -07:00
Hongchao Deng
3e9af272d5
etcd3/watcher: logging error
2016-09-15 17:23:04 -07:00
Kubernetes Submit Queue
0a62dab566
Merge pull request #32645 from wojtek-t/fix_cacher_logging
...
Automatic merge from submit-queue
Fix logging in cacher
@smarterclayton @liggitt @hongchaodeng
2016-09-15 05:56:39 -07:00
Timothy St. Clair
9f3841b452
Revert "Revert "Enable v3 Client as the default on UTs""
...
This reverts commit 9dcef2e3cd
2016-09-14 07:27:21 -05:00
Wojciech Tyczynski
e5b3f19638
Fix logging in cacher
2016-09-14 09:13:41 +02:00
Wojciech Tyczynski
949dd90593
Extend logging for performance debuggin
2016-09-12 12:46:19 +02:00
Wojciech Tyczynski
03a23aed09
Log water mark for incoming queue in cacher
2016-09-09 11:35:05 +02:00
Kubernetes Submit Queue
504ccc6f37
Merge pull request #32275 from wojtek-t/split_process_event
...
Automatic merge from submit-queue
Split dispatching to watchers in Cacher into separate goroutine.
Should help with #32257
2016-09-08 07:42:12 -07:00
Wojciech Tyczynski
e750454c31
Fix allow for non-ready nodes in e2e framework
2016-09-08 14:22:08 +02:00
Wojciech Tyczynski
378cd81dbe
Split dispatching to watchers in Cacher into separate goroutine.
2016-09-08 13:27:54 +02:00
Wojciech Tyczynski
bd54c389f5
Extend logging for scalability tests debugging
2016-09-08 12:02:59 +02:00
Kubernetes Submit Queue
9f58a867e1
Merge pull request #31522 from krousey/path_validation
...
Automatic merge from submit-queue
Split path validation into a separate library
This PR splits path segment validation into it's own package. This cuts off one of the restclient's dependency paths to some docker packages, and completely eliminates its dependency on go-restful swagger validation.
cc @kubernetes/sig-api-machinery
2016-09-07 10:14:32 -07:00
Hongchao Deng
8723fbaa61
unshare cluster, store in each test suite
2016-09-02 15:04:23 -07:00
Kris
e87edf9bd5
Split path validation into a separate library
2016-08-26 08:05:20 -07:00
Hongchao Deng
9131fbd446
refactor destroy func in unit testing
2016-08-25 22:57:28 -07:00
Hongchao Deng
9fc0e1e98d
return destroy func to clean up internal resources of storage
2016-08-25 08:32:21 -07:00
Kubernetes Submit Queue
c63f43b329
Merge pull request #31387 from hongchaodeng/docs
...
Automatic merge from submit-queue
etcd3 compactor: update docs
Minor fix/improvement on compactor docs.
2016-08-24 21:37:21 -07:00
Hongchao Deng
0b253b519e
etcd3 compactor: update docs
2016-08-24 16:24:24 -07:00
Daniel Smith
9dcef2e3cd
Revert "Enable v3 Client as the default on UTs"
2016-08-24 13:16:40 -07:00
Hongchao Deng
874cc7f2b6
separate test watch from zero and nonzero
2016-08-23 20:34:39 -07:00
Timothy St. Clair
99e017661a
Fix for etcd3 TLS config options
2016-08-22 22:17:55 -05:00
Timothy St. Clair
49b7ebd791
Switch UT default settings to leverage etcd3.v3client
2016-08-22 22:17:55 -05:00
Hongchao Deng
77ffae128e
add boilerplate
2016-08-21 21:45:36 -07:00
Hongchao Deng
41d14d665e
fix
2016-08-21 21:08:16 -07:00
Hongchao Deng
6e4f80909d
unit test for tls of etcd3
2016-08-21 15:59:51 -07:00
Hongchao Deng
014ad63111
etcd3 backend: support TLS
2016-08-21 15:59:51 -07:00
Wojciech Tyczynski
e76c0b7c72
Increase buffer size in etcd_watcher
2016-08-19 13:00:31 +02:00
Kubernetes Submit Queue
18aa761b07
Merge pull request #30664 from hongchaodeng/r3
...
Automatic merge from submit-queue
pkg/storage: remove Codec() from interface
What?
Removes Codec() from storage.Interface.
Why?
- storage interface doesn't need to expose Codec().
- Codec() isn't used anywhere.
2016-08-17 00:56:05 -07:00
Kubernetes Submit Queue
6bbc99937d
Merge pull request #30492 from lixiaobing10051267/masterUID
...
Automatic merge from submit-queue
Modify IsInvalidObj name and description
IsInvalidObj note incorrect, modify it.
2016-08-17 00:55:01 -07:00
Hongchao Deng
a607a69f4a
pkg/storage: cleanup Codec() from interface
2016-08-15 20:46:13 -07:00
Hongchao Deng
ed79925dd6
pkg/storage: remove unused Config
2016-08-15 14:20:38 -07:00
Hongchao Deng
d0938094d9
move new etcd storage into cacher
2016-08-12 18:40:20 -07:00
lixiaobing10051267
65f772d050
Modify IsInvalidObj name and description
2016-08-12 11:17:08 +08:00
Kubernetes Submit Queue
a69054f9c3
Merge pull request #30368 from wojtek-t/log_terminating_all_watchers
...
Automatic merge from submit-queue
Log warning when terminating all watchers
Ref #30275
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.kubernetes.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30368 )
<!-- Reviewable:end -->
2016-08-10 09:26:07 -07:00
