Commit Graph

8 Commits

Author SHA1 Message Date
Ian Chakeres
98e2c8cdee Validate that PV capacity and PVC capacity requests are greater than zero 2017-11-13 08:57:01 -08:00
Kubernetes Submit Queue
28e0c3bef2
Merge pull request #55164 from NickrenREN/validation-not-zero
Automatic merge from submit-queue (batch tested with PRs 49258, 55164). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Make sure that storage request of pvc is not zero

I do not know whether we should add the checking zero logic to `ValidateResourceQuantityValue`.
But at lease we should do this when validate PVC.  If PVC requests 0Gi storage,it does not make sense to provision that volume. 
Volume plugins will not check whether the request of PVC is 0 when they run `CreateVolume` or `CreateImage` called by `Provision()`

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #55163

**Special notes for your reviewer**:

**Release note**:
```release-note
NONE
```
2017-11-12 23:17:37 -08:00
NickrenREN
3a22b5f5e0 Make sure that storage request of pvc is not zero 2017-11-13 11:37:29 +08:00
Kubernetes Submit Queue
381cfee8cd
Merge pull request #55137 from andyzhangx/add-mountpath-tests
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

add windows mount path test

**What this PR does / why we need it**:
add windows mount path test, this PR is for https://github.com/kubernetes/kubernetes/pull/51240, which should include some tests.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #55549

**Special notes for your reviewer**:

**Release note**:

```
none
```
2017-11-12 04:04:18 -08:00
andyzhangx
544a09b30f add windows mount path test 2017-11-10 14:43:09 +00:00
liangxia
890f4b7e2e Add several validation to persistentvolume 2017-11-10 10:31:44 +08:00
Dr. Stefan Schimanski
33b20f22ee pkg/apis/core: fixup package names 2017-11-09 12:14:07 +01:00
Dr. Stefan Schimanski
3848e0a478 Move core api to pkg/apis/core 2017-11-09 12:08:42 +01:00