github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
102,324 Commits 1 Branch 31 Tags
995278c9fbb80cb15136c68970b384cc91030397
Commit Graph

436 Commits

Author SHA1 Message Date
Patrick Ohly
555ff7ef10 CSI: allow drivers that can handle persistent and ephemeral volumes 
The conceptual change is that the mode in which a volume gets handled
is derived from it's spec, not from the ability of the driver. In
practice, that is already how the code worked because it didn't
actually look at CSIDriver.Spec.Mode at all.

Therefore the code change itself is mostly just renaming "driver mode"
to "volume mode". In some places (CanDeviceMount, CanAttach) the
feature check that was used elsewhere seemed to be missing. Now their
code path for ephemeral volumes are also only entered if that feature
is enabled.

The sanity check whether a CSI driver is being used correctly still
needs to be implemented.

Related-to: https://github.com/kubernetes/kubernetes/issues/79624
 2019-07-25 16:45:46 +02:00
Kubernetes Prow Robot
da3daf2e8a Merge pull request #80451 from cwdsuzhou/July/fix_error_override 
Fix error override when saveVolumeData occurs error
 2019-07-24 02:02:15 -07:00
caiweidong
a5bf98a43e Fix error overrided when saveVolumeData occurs error 2019-07-24 10:19:22 +08:00
Ted Yu
f4fbfcb46a Remove recursion in csiAttacher#waitForVolumeAttachmentInternal 2019-07-23 14:29:24 -07:00
caiweidong
45c52d1314 Fix potential panic in nodeGetVolumeStatsV1 2019-07-23 13:47:35 +08:00
caiweidong
8789143062 Fix csi attacher unit tests using t.Run() 2019-07-22 15:42:31 +08:00
David Zhu
831cd29f4e Add passthrough for MountOptions for NodeStageVolume for CSI 2019-07-16 16:17:47 -07:00
Kubernetes Prow Robot
10a1d1f5bd Merge pull request #79920 from cwdsuzhou/July/block_not_support_attach 
Bugfix: csi plugin supporting raw block that does not need attach mounted failed
 2019-07-15 08:39:21 -07:00
caiweidong
0c628e101a Bugfix: csi raw block that does not need attach mounted failed 
Add unit test

fix verify-test-featurefates failed
 2019-07-15 10:34:12 +08:00
Kubernetes Prow Robot
9915047d3d Merge pull request #79113 from tedyu/stop-w-detach 
Close watcher early for volume detachment
 2019-07-12 06:31:18 -07:00
Kubernetes Prow Robot
021ad88ac4 Merge pull request #79894 from odinuge/csi-client-dead-code 
Remove dead code from csi_client
 2019-07-10 06:20:25 -07:00
Kubernetes Prow Robot
d59a603f1b Merge pull request #78267 from mucahitkurt/cleanup/operation-generator-migration-scenarios-unit-tests 
unit tests for operationGenerator.GenerateUnmapVolumeFunc
 2019-07-09 18:20:25 -07:00
Odin Ugedal
542c335fca Remove dead code from csi_client 
When removing a feature flag in
35bc5dc6b6, a few of the lines were
removed, resulting in some dead code.
 2019-07-08 17:53:52 +02:00
Ji-Young Park
528521cfae Return MetricsError with ErrCodeNotSupported code 
GetMetrics function expects MetricsError error
with ErrCodeNotSupported code when driver for the volume
does not support metrics
Updated csi_metrics to return error when underlying csi
driver does not have GET_VOLUME_STATS capability
 2019-07-06 10:49:06 -04:00
Kubernetes Prow Robot
a3be4b6817 Merge pull request #79529 from andyzhangx/change-csi-timeout 
fix: change default timeout value in csi plugin
 2019-07-03 09:12:58 -07:00
Kubernetes Prow Robot
2501a9083d Merge pull request #68513 from codenrhoden/mount-refactor 
Refactor util/mount interface in prep for moving out of k/k
 2019-06-28 13:57:28 -07:00
andyzhangx
d8c92f5c09 fix: change timeout value in csi plugin 2019-06-28 14:27:22 +00:00
Fabio Bertinatto
33c8bacd41 Update nodeinfomanager to store volume limits in CSINode 2019-06-25 16:30:54 +02:00
draveness
35bc5dc6b6 feat: cleanup feature gates for KubeletPluginsWatcher 2019-06-23 16:59:36 +08:00
Ted Yu
005065f8fc Close watcher early for volume detachment 2019-06-17 15:09:43 -07:00
Kubernetes Prow Robot
365283e202 Merge pull request #78532 from cwdsuzhou/simplify_construct_volume_spec 
Simplify func ConstructVolumeSpec
 2019-06-17 11:05:49 -07:00
Kubernetes Prow Robot
e46b9ca656 Merge pull request #78754 from cwdsuzhou/June/csi_attach_close_chan 
Avoid to keep the watcher open for too long
 2019-06-17 04:36:37 -07:00
Kubernetes Prow Robot
bde744eb97 Merge pull request #78839 from tedyu/cleaner-err 
Check correct error for cleanup in csiAttacher#MountDevice
 2019-06-14 20:47:01 -07:00
Travis Rhoden
be7da5052f Refactor pkg/util/mount to be more reusable 
This patch refactors pkg/util/mount to be more usable outside of
Kubernetes. This is done by refactoring mount.Interface to only contain
methods that are not K8s specific. Methods that are not relevant to
basic mount activities but still have OS-specific implementations are
now found in a mount.HostUtils interface.
 2019-06-14 09:35:18 -06:00
Kubernetes Prow Robot
70b46ca5fb Merge pull request #78529 from cwdsuzhou/remove_verbose_err 
Remove dead codes
 2019-06-14 04:09:13 -07:00
Mucahit Kurt
db1c07750a unit tests for the volume plugin name that's used inside GeneratedUnmapVolumeFunc for csi migration on/off scenarios 
Signed-off-by: Mucahit Kurt <mucahitkurt@gmail.com>
 2019-06-11 08:32:25 +03:00
Ted Yu
de92897e26 Check correct error for cleanup 2019-06-09 21:29:28 -07:00
caiweidong
0508bea9b6 Fix keep the watcher open for too long 2019-06-07 21:40:50 +08:00
caiweidong
4ce2f296f5 Simplify func ConstructVolumeSpec 2019-06-05 10:22:13 +08:00
caiweidong
b726db66d2 Remove dead codes 2019-06-03 22:15:53 +08:00
Kubernetes Prow Robot
b7fa33ec15 Merge pull request #77703 from ddebroy/inline-mig-1 
API changes to support migration of inline in-tree volumes to CSI
 2019-05-31 12:23:19 -07:00
Deep Debroy
de7be9d613 Populate InlineVolumeSpec in CSI attacher and translation library 
Signed-off-by: Deep Debroy <ddebroy@docker.com>
 2019-05-30 09:35:22 +00:00
Robert Krawitz
5b97b2860d Change fsGroup to mounterArgs in volume.SetUp() to allow for future extension. 2019-05-29 15:12:28 -04:00
Hemant Kumar
0ab6bdfa36 Wait for waitforattach goroutine before exiting 
This test suite fails in weird ways without waiting for the
goroutine
 2019-05-21 09:57:47 -04:00
Kubernetes Prow Robot
fad34e404e Merge pull request #76188 from humblec/csi-in-m 
csi: Implement NodeServiceCapability_RPC_GET_VOLUME_STATS rpc call
 2019-05-17 20:26:09 -07:00
Humble Chirammal
c511c90b59 csi: Implement NodeServiceCapability_RPC_GET_VOLUME_STATS rpc call 
and implement Metrics Provider for CSI driver

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2019-05-17 17:10:53 +05:30
Andrew Kim
c919139245 update import of generic featuregate code from k8s.io/apiserver/pkg/util/feature -> k8s.io/component-base/featuregate 2019-05-08 10:01:50 -04:00
Kubernetes Prow Robot
e332051416 Merge pull request #77433 from cwdsuzhou/common_func_for_ad 
Add common func for NewAttacher and NewDetacher
 2019-05-07 09:51:56 -07:00
Kubernetes Prow Robot
2e6f58ddf8 Merge pull request #77431 from cwdsuzhou/Add_detacher_assert_check 
Add detacher assertion for csiAttacher
 2019-05-07 09:51:44 -07:00
Kubernetes Prow Robot
a8787dac30 Merge pull request #76927 from mrkm4ntr/unnecessary-goroutine 
Do not generate unnecessary goroutines
 2019-05-06 21:31:53 -07:00
Kubernetes Prow Robot
e0d39be7b5 Merge pull request #76785 from dims/typo-extra-space-in-fatalf-format-string 
typo - extra space - in Fatalf format string
 2019-05-06 14:01:39 -07:00
caiweidong
62fe5fe7b8 add common func for NewAttacher and NewDetacher 2019-05-04 11:08:28 +08:00
caiweidong
5d89ab26e9 Add detacher assert for csiAttacher 2019-05-04 10:43:46 +08:00
Kubernetes Prow Robot
b5c34d0c43 Merge pull request #74734 from codenrhoden/move-mountspath 
Move MountsInGlobalPDPath from mount pkg to volume
 2019-05-01 17:28:18 -07:00
Humble Chirammal
a3c1a6da02 Error message corrections 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2019-05-01 13:36:52 +05:30
Ted Yu
ebe499ec80 Remove variable nodeExpandSet 2019-04-30 06:44:29 -07:00
Ted Yu
565c88de14 Return early when node expansion is determined 2019-04-29 14:05:08 -07:00
Travis Rhoden
78d109e201 Always use filepath.Join instead of path.Join 
This patch cleans up pkg/util/mount/* and pkg/util/volume/* to always
use filepath.Join instead of path.Join. filepath.Join is preferred
because path.Join can have issues on Windows.
 2019-04-29 09:56:05 -06:00
Shintaro Murakami
f8e81337da Do not generate unnecessary goroutine 2019-04-23 16:22:14 +09:00
Kubernetes Prow Robot
29163600fe Merge pull request #76796 from dims/remove-unused-methods 
Remove unused code
 2019-04-19 11:09:55 -07:00