Alvaro Aleman
6d0ac8c561
Use the generic/typed workqueue throughout
...
This change makes us use the generic workqueue throughout the project in
order to improve type safety and readability of the code.
2024-05-04 14:33:12 -04:00
carlory
9ec6ee539a
Remove cloud provider dependency from volume host and volume controllers
2024-04-18 19:00:37 +08:00
Kubernetes Prow Robot
854af6aba6
Merge pull request #122411 from huww98/lift-mountedByNode
...
ad controller: lift nodeAttachedTo.mountedByNode
2024-04-18 00:00:14 -07:00
Kubernetes Prow Robot
ef2c682635
Merge pull request #122082 from carlory/remove-keep-terminated-pod-volumes
...
keep-terminated-pod-volumes flag on kubelet is removed
2024-04-17 23:59:54 -07:00
huweiwen
3a71fe57f7
ad controller: lift nodeAttachedTo.mountedByNode
...
optimize adc.nodeUpdate(). Time complexity reduced from O(n) to O(1), where n is the number of nodes.
Data stored in nodeAttachedTo.mountedByNode is now at actualStateOfWorld.inUseVolumes.
This refactor also ensures that we can record the state update even if the volume is not present in ASW yet.
The added BenchmarkNodeUpdate result is reduced from 28076923 to 16030 ns/op.
The previous BenchmarkPopulateActualStateOfWorld result is also reduced from 13s to 8s.
2024-04-11 15:35:17 +08:00
Kubernetes Prow Robot
611dbaa055
Merge pull request #122790 from carlory/fix-121696
...
Fix flaky test: Test_Run_OneVolumeDetachFailNodeWithReadWriteOnce
2024-03-10 19:23:40 -07:00
carlory
b47c73ee26
keep-terminated-pod-volumes flag on kubelet is removed
2024-03-01 18:42:15 +08:00
Mengjiao Liu
b584b87a94
kube-controller-manager: readjust log verbosity
...
- Increase the global level for broadcaster's logging to 3 so that users can ignore event messages by lowering the logging level. It reduces information noise.
- Making sure the context is properly injected into the broadcaster, this will allow the -v flag value to be used also in that broadcaster, rather than the above global value.
- test: use cancellation from ktesting
- golangci-hints: checked error return value
2024-02-26 14:51:56 +08:00
Kubernetes Prow Robot
31a482a149
Merge pull request #120344 from rohitssingh/disable_force_detach
...
Add a flag to disable force detach behavior in kube-controller-manager
2024-02-22 13:02:38 -08:00
Rohit Singh
13dddca6a2
Add "disable-force-detach-on-timeout" flag to kube-controller-manager
2024-02-22 18:31:52 +00:00
carlory
0cd9d40a65
Test_Run_OneVolumeDetachFailNodeWithReadWriteOnce use
...
waitForAttachStateToNode instead of time.Sleep
2024-02-04 16:57:55 +08:00
Kubernetes Prow Robot
0209c546fd
Merge pull request #121824 from carlory/clean-112
...
adc remove stale comments
2024-01-29 14:13:17 -08:00
Kubernetes Prow Robot
5cf72fbfae
Merge pull request #121713 from carlory/adc
...
adc remove redundant check
2023-12-28 21:47:19 +01:00
huweiwen
a3e27aa1ad
ad controller: optimize populateActualStateOfWorld
...
Reduce overall complexity from O(n^2) to O(n)
Run time of the new benchmark is reduced from hours to 13s
2023-11-17 16:48:30 +08:00
huweiwen
854347ac81
ad controller populator: check for inUse sync in test
2023-11-17 16:48:30 +08:00
carlory
4a4940694f
remove stale comments
2023-11-09 11:58:50 +08:00
carlory
957e9a7f1a
adc remove redundant check
2023-11-03 16:17:39 +08:00
huweiwen
63b3085f2a
fix ad controller populators test
...
The informer is not initialized, so no assertion performed before. Fixed this now.
Then fixed the test failure by using NewAttachDetachController to initialize adc.
2023-10-27 23:35:45 +08:00
Kubernetes Prow Robot
07029999f9
Merge pull request #120666 from b8kings0ga/feature/fix-comment-correction
...
AttachDetachControllerConfiguration.ReconcilerSyncLoopPeriod default value comment fix
2023-10-11 22:51:49 +02:00
Kubernetes Prow Robot
d3559bf77f
Merge pull request #120595 from jsafrane/fix-detach-uncertain
...
Mark a volume as uncertain-attached after detach error
2023-10-08 05:54:01 +02:00
b8kings0ga
9345da51ac
fix comment mistake, run "make update"
2023-09-22 16:37:55 +08:00
Jan Safranek
7fc11f47ff
Mark a volume as uncertain-attached after detach error
...
Volume that failed Detach() should not be marked as attached, CSI
external-attacher is probably still trying to detach it.
Mark it uncertain instead and wait for Detach() to succeed.
2023-09-13 10:03:28 +02:00
kerthcet
6fbb8ec7e4
Move scheduler testing utils to /scheduler/testing
...
Signed-off-by: kerthcet <kerthcet@gmail.com >
2023-09-12 13:42:38 +08:00
Patrick Ohly
2472291790
api: introduce separate VolumeResourceRequirements struct
...
PVC and containers shared the same ResourceRequirements struct to define their
API. When resource claims were added, that struct got extended, which
accidentally also changed the PVC API. To avoid such a mistake from happening
again, PVC now uses its own VolumeResourceRequirements struct.
The `Claims` field gets removed because risk of breaking someone is low:
theoretically, YAML files which have a claims field for volumes now
get rejected when validating against the OpenAPI. Such files
have never made sense and should be fixed.
Code that uses the struct definitions needs to be updated.
2023-08-21 15:31:28 +02:00
carlory
f443c458af
move non-graceful node shutdown to GA
2023-07-11 13:51:51 +08:00
xing-yang
cca6601106
Add reason to force detach metric
2023-07-10 06:30:05 +00:00
Ziqi Zhao
dfc1838379
Migrated pkg/controller/volume|util|replicaset|nodeipam to contextual logging
...
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com >
2023-07-06 07:39:52 +08:00
carlory
5e048041e4
remove helper function for unused storage feature in pkg/proxy/util
2023-06-13 09:22:59 +08:00
guangli.bao
931cc96b8d
remote windows condition when #116693 is merged
...
Signed-off-by: guangli.bao <guangli.bao@daocloud.io >
2023-05-24 14:54:22 +08:00
Kubernetes Prow Robot
484645e817
Merge pull request #116659 from claudiubelu/skip-flaky-tests-2
...
unit tests: Skip flaky tests on Windows (part 2)
2023-05-23 20:04:48 -07:00
SataQiu
3fa55d469c
fix a bug where the AttachedVolume is not printed correctly in the log
2023-05-11 22:04:30 +08:00
Claudiu Belu
0979d55443
unit tests: Skip flaky tests on Windows (part 2)
...
Some of the unit tests are currently flaky on Windows. This commit
skips them until they are resolved.
2023-04-13 12:07:18 +00:00
Kubernetes Prow Robot
8cdc7fa542
Merge pull request #116675 from pacoxu/volume-flake
...
deflake: Add retry with timeout to wait for final conditions
2023-04-11 18:19:09 -07:00
Harshal Patil
1972dd1005
Do not log entire pod struct while attaching the volume
...
Signed-off-by: Harshal Patil <harpatil@redhat.com >
2023-04-05 20:24:12 -04:00
Paco Xu
8e36e948ce
verifyVolumeNoStatusUpdateNeeded may cause flake and so only keep the last ones
2023-03-30 10:44:45 +08:00
Paco Xu
c14068c202
deflake: Add retry with timeout to wait for final conditions
2023-03-22 11:24:09 +08:00
Kubernetes Prow Robot
6a111bebe2
Merge pull request #116377 from kinvolk/rata/userns
...
KEP-127: user namespace support for stateless pods
2023-03-14 10:40:43 -07:00
杨军10092085
361e4ff0fa
volume: use contextual logging
2023-03-14 08:37:30 +08:00
Rodrigo Campos
8af3cce7fe
kubelet: remove GetHostIDsForPod()
...
Now KEP-127 relies on idmap mounts to do the ID translation and we won't
do any chowns in the kubelet.
This patch just removes the usage of GetHostIDsForPod() in
operationexecutor to do the chown, and also removes the
GetHostIDsForPod() method from the kubelet volume interface.
Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com >
2023-03-13 22:28:03 +01:00
Kubernetes Prow Robot
7529178924
Merge pull request #111372 from HeavenTonight/master
...
code cleanup
2023-03-10 11:44:40 -08:00
Sunny Song
98f944f55d
Remove check for CSI driver running on node for CSI migration attach operations
2023-02-09 02:45:02 +00:00
Kubernetes Prow Robot
ad2a9f2f33
Merge pull request #113863 from msau42/owners
...
update sig-storage owners
2023-01-30 10:10:50 -08:00
Jordan Liggitt
78cb3862f1
Fix indentation/spacing in comments to render correctly in godoc
2022-12-17 23:27:38 -05:00
mowangdk
bf244d3046
Lower volume attached touch log level
2022-11-16 16:49:07 +08:00
Michelle Au
524a8b32a6
add sig-storage reviewers, remove inactive sig-storage reviewers, remove redundant owners files
2022-11-15 23:51:57 +00:00
Kubernetes Prow Robot
d7bff1c809
Merge pull request #111577 from brianpursley/troubleshoot-unit-test-flake
...
Add logging for reconciler unit test
2022-11-11 00:44:09 -08:00
Kubernetes Prow Robot
1c230d519e
Merge pull request #113262 from jsafrane/rework-reconstruction
...
Rework volume reconstruction
2022-11-07 12:42:29 -08:00
Jan Safranek
fc245b339b
Refactor ConstructVolumeSpec
...
Return a struct from ConstructVolumeSpec to be able to add more fields to
it later.
2022-11-03 16:55:13 +01:00
Kubernetes Prow Robot
98742f9d77
Merge pull request #110747 from harshanarayana/cleanup/GIT-110737/logging-improvements
...
structured-logging: replace KObjs with KObjSlice for logging
2022-11-03 00:49:34 -07:00
Humble Chirammal
4bafd53a02
Correct typos in pkg/controller/volume
...
Signed-off-by: Humble Chirammal <hchiramm@redhat.com >
2022-09-16 16:50:20 +05:30