Mike Spreitzer
c87cd36d3e
Finish making Gauge and TimingHistogram implement the same interface
2022-05-12 08:00:54 -04:00
Kubernetes Prow Robot
cae22d8b8a
Merge pull request #108797 from deads2k/release-1.25-removed-01-checker
...
update for APIs removed in 1.25
2022-05-11 19:25:13 -07:00
Kubernetes Prow Robot
2d6534cde9
Merge pull request #109969 from sttts/sttts-auth-group-adder-race
...
authn: fix cache mutation by AuthenticatedGroupAdder
2022-05-11 18:17:13 -07:00
Kubernetes Prow Robot
889922476a
Merge pull request #108011 from cici37/benchmark
...
Benchmark cel.UnstructuredToVal
2022-05-11 14:59:00 -07:00
Kubernetes Prow Robot
784cf76469
Merge pull request #109930 from wojtek-t/cleanup_etcd_healthcheck
...
Cleanup etcd healthcheck on shutdown
2022-05-11 13:27:25 -07:00
Kubernetes Prow Robot
efbbc29bfd
Merge pull request #109858 from panslava/skip-deleting-updating-rbs-services
...
GCE: skip updating and deleting external loadbalancer if service is managed by ingress-gce
2022-05-11 13:27:13 -07:00
Dr. Stefan Schimanski
e09e81e4f6
authn: fix cache mutation by AuthenticatedGroupAdder
...
The cached token authenticator returns a cache value. The group adder changes it.
2022-05-11 22:04:50 +02:00
Wojciech Tyczyński
2dd44d6226
Cleanup no-longer used storage cleanup method
2022-05-11 20:11:37 +02:00
Kubernetes Prow Robot
999b1bbe92
Merge pull request #108414 from aojea/cacher_context
...
cacher: don't accept requests if stopped
2022-05-11 10:47:02 -07:00
Steve Kuznetsov
fa2a6d6339
storage: isolate the test resource
...
This test resource only exists to test the versioning logic, but it
cannot live in the general testing package, or import cycles will exist.
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com >
2022-05-11 09:18:15 -07:00
Steve Kuznetsov
eb3aa5be10
storage: move continue token definition to storage
...
The means by which we encode and decode the continue token during a
paginated LIST call is not specific to etcd3. In order to allow for a
generic suite of tests against any storage.Interface implementation, we
need this logic to live outside of the etcd3 package, or import cycles
will exist.
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com >
2022-05-11 08:59:41 -07:00
Steve Kuznetsov
3939f3003e
storage: move the APIObjectVersioner definition to storage
...
The means by which we extract and parse the version of an API object is
not specific to etcd3. In order to allow for a generic suite of tests
against any storage.Interface imlpementation, we need this logic to live
outside of the etcd3 package, or import cycles will exist.
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com >
2022-05-11 08:19:32 -07:00
Kubernetes Prow Robot
efb62b3538
Merge pull request #108080 from astoycos/issue-132
...
Fix Panic Condition
2022-05-11 05:01:02 -07:00
Wojciech Tyczyński
cb80082f66
Cleanup etcd healthcheck on shutdown
2022-05-11 12:15:05 +02:00
Mikhail Mazurskiy
1dda915659
Pass context for TLS dial
2022-05-11 15:14:30 +10:00
kerthcet
5e3df9a155
amend comment of NodeInclusionPolicy
...
Signed-off-by: kerthcet <kerthcet@gmail.com >
2022-05-11 07:48:46 +08:00
Kubernetes Prow Robot
cf64022a0f
Merge pull request #109896 from superbrothers/kubectl-delete-fix-discovery-cache-ttl
...
Fix discovery cache TTL to 6 hours
2022-05-10 14:33:36 -07:00
David Eads
233e0cb8c3
enforce strict alpha handling for API serving
2022-05-10 13:32:07 -04:00
Kubernetes Prow Robot
33b2e16372
Merge pull request #107213 from mk46/portname_validation
...
Fixed port name validation error message.
2022-05-10 10:03:42 -07:00
Kubernetes Prow Robot
cc66198570
Merge pull request #108492 from kerthcet/feature/add-NodeInclustionPolicies
...
Add NodeInclusionPolicy to TopologySpreadConstraint in PodSpec
2022-05-10 08:41:43 -07:00
Andrew Stoycos
6aa779f4ed
Fix Panic Condition
...
Currenlty an event recorder can send an event to a
broadcaster that is already stopped, resulting
in a panic. This ensures the broadcaster holds
a lock while it is shutting down and then forces
any senders to drop queued events following
broadcaster shutdown.
It also updates the Action, ActionOrDrop, Watch,
and WatchWithPrefix functions to return an error
in the case where data is sent on the closed bradcaster
channel rather than panicing.
Lastly it updates unit tests to ensure the fix works correctly
fixes: https://github.com/kubernetes/kubernetes/issues/108518
Signed-off-by: Andrew Stoycos <astoycos@redhat.com >
2022-05-10 09:52:08 -04:00
Kubernetes Prow Robot
e38dba7a15
Merge pull request #109925 from MikeSpreitzer/more-better-bench
...
Simplify and extend the benchmarks of prometheusextension timing histograms
2022-05-10 05:18:08 -07:00
Kubernetes Prow Robot
ccb7118c22
Merge pull request #109914 from stevekuznetsov/skuznets/generic-watch-cancel-test
...
storage/testing: move cancelled watch test to generic package
2022-05-10 05:17:44 -07:00
Kubernetes Prow Robot
0ee7906524
Merge pull request #109909 from stevekuznetsov/skuznets/generic-create-test
...
storage/testing: move creation test to generic package
2022-05-10 04:05:43 -07:00
Kubernetes Prow Robot
d60fb258d9
Merge pull request #109874 from jackfrancis/IPv6DualStack-ga-rm-featuregate
...
azure: remove GA IPv6DualStack feature-gate
2022-05-09 23:33:44 -07:00
Mike Spreitzer
4df968ae1c
Make more ordinary and add benchmarks of wrapped timing histograms
2022-05-10 01:07:00 -04:00
kerthcet
02f0a3ee91
feat: add NodeInclusionPolicy to TopologySpreadConstraint in PodSpec
...
Signed-off-by: kerthcet <kerthcet@gmail.com >
2022-05-10 12:54:49 +08:00
Mike Spreitzer
f3068efcfb
Simplify and extend the benchmarks of timing histograms
...
Replace the use of a clock abstraction with direct provision of the
time-reading function.
Add benchmarks of two ways to fetch and use a vector member.
Following are the results using the revised benchmark suite.
(base) mspreitz@mjs12 prometheusextension % go test -benchmem -run=^$ -bench Histogram .
goos: darwin
goarch: amd64
pkg: k8s.io/component-base/metrics/prometheusextension
cpu: Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
BenchmarkTimingHistogramDirect-16 28562178 39.47 ns/op 0 B/op 0 allocs/op
BenchmarkTimingHistogramVecEltCached-16 29268819 39.41 ns/op 0 B/op 0 allocs/op
BenchmarkTimingHistogramVecEltFetched-16 8345041 142.5 ns/op 32 B/op 1 allocs/op
BenchmarkWeightedHistogram-16 49803134 24.22 ns/op 0 B/op 0 allocs/op
BenchmarkHistogram-16 41756210 29.40 ns/op 0 B/op 0 allocs/op
PASS
ok k8s.io/component-base/metrics/prometheusextension 6.488s
(base) mspreitz@mjs12 prometheusextension % go test -benchmem -run=^$ -bench Histogram .
goos: darwin
goarch: amd64
pkg: k8s.io/component-base/metrics/prometheusextension
cpu: Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
BenchmarkTimingHistogramDirect-16 28246786 39.60 ns/op 0 B/op 0 allocs/op
BenchmarkTimingHistogramVecEltCached-16 29318173 39.44 ns/op 0 B/op 0 allocs/op
BenchmarkTimingHistogramVecEltFetched-16 8441341 142.5 ns/op 32 B/op 1 allocs/op
BenchmarkWeightedHistogram-16 48469184 24.21 ns/op 0 B/op 0 allocs/op
BenchmarkHistogram-16 41001742 29.51 ns/op 0 B/op 0 allocs/op
PASS
ok k8s.io/component-base/metrics/prometheusextension 6.340s
(base) mspreitz@mjs12 prometheusextension % go test -benchmem -run=^$ -bench Histogram .
goos: darwin
goarch: amd64
pkg: k8s.io/component-base/metrics/prometheusextension
cpu: Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
BenchmarkTimingHistogramDirect-16 28983674 40.82 ns/op 0 B/op 0 allocs/op
BenchmarkTimingHistogramVecEltCached-16 29527742 43.83 ns/op 0 B/op 0 allocs/op
BenchmarkTimingHistogramVecEltFetched-16 8238685 143.8 ns/op 32 B/op 1 allocs/op
BenchmarkWeightedHistogram-16 49594070 24.24 ns/op 0 B/op 0 allocs/op
BenchmarkHistogram-16 41100378 29.35 ns/op 0 B/op 0 allocs/op
PASS
ok k8s.io/component-base/metrics/prometheusextension 6.554s
2022-05-09 23:21:49 -04:00
Steve Kuznetsov
2e118f4246
storage/testing: move creation test to generic package
...
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com >
2022-05-09 13:46:24 -07:00
Steve Kuznetsov
6d25e96ced
etcd3/store: make creation test validation generic
...
Different callers to this test may need to do different backend-specific
validation on the stored data, so we allow them a callback for this.
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com >
2022-05-09 13:46:22 -07:00
Steve Kuznetsov
1f24bd91c3
storage/testing: move cancelled watch test to generic package
...
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com >
2022-05-09 09:19:07 -07:00
Steve Kuznetsov
c0fc817255
etcd3/store: call a generic cancelled watch test
...
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com >
2022-05-09 08:23:03 -07:00
Steve Kuznetsov
774870611c
etcd3/store: update cancelled watch test to be generic
...
There's no reason to create the watch using the underlying watcher.
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com >
2022-05-09 08:22:04 -07:00
Steve Kuznetsov
f894f8196d
etcd3/store: update creation test to use storage client
...
There is no functional difference between checking for an empty key
using the database client and doing so with the storage interface. Using
the latter allows this test to be more portable.
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com >
2022-05-09 07:59:38 -07:00
Kazuki Suda
d2b4c017c8
Fix discovery cache TTL to 6 hours
...
Signed-off-by: Kazuki Suda <kazuki.suda@gmail.com >
2022-05-09 13:47:52 +09:00
Kubernetes Prow Robot
bf52c1fd46
Merge pull request #109891 from pohly/log-dependency-update
...
dependencies: logr and zapr v1.2.3
2022-05-08 17:59:18 -07:00
Kubernetes Prow Robot
7af5a7bfc5
Merge pull request #109602 from lavalamp/remove-clustername
...
Finish clustername removal
2022-05-07 08:01:16 -07:00
Mikhail Mazurskiy
6d74474972
Don't clone headers twice
...
CloneRequest() clones headers too
2022-05-07 22:33:50 +10:00
Mike Spreitzer
b2c0c22e8f
A bit more tidying up
2022-05-06 23:45:21 -04:00
Kubernetes Prow Robot
af4dceeac2
Merge pull request #109308 from danwinship/traffic-policy-docs
...
Clarify ExternalTrafficPolicy/InternalTrafficPolicy definitions
2022-05-06 17:23:16 -07:00
Jack Francis
b2e40d8f32
azure: remove GA IPv6DualStack feature-gate
2022-05-06 14:40:51 -07:00
Daniel Smith
a427cd6569
compat
2022-05-06 21:25:20 +00:00
Kubernetes Prow Robot
f7457747f6
Merge pull request #109833 from stevekuznetsov/skuznets/move-simple-tests
...
storage/etcd3: factor tests to accept `storage.Interface`
2022-05-06 09:07:25 -07:00
Kubernetes Prow Robot
e84f62e695
Merge pull request #109836 from tnqn/fix-apiservice-error
...
Fix OpenAPI loading error caused by empty APIService
2022-05-06 07:57:16 -07:00
Patrick Ohly
3e6974e0ba
dependencies: logr and zapr v1.2.3
...
The updated zapr is more resilient against MarshalLog crashing. Not a known
problem in Kubernetes, though.
2022-05-06 15:16:56 +02:00
Slavik Panasovets
e5a1bc2462
GCE: skip updating and deleting external loadbalancers if service is managed outside of service controller
2022-05-06 12:01:48 +00:00
Arda Güçlü
0245e74590
Define NoOptDefVal for validate flag
...
validate flag does not have default value defined when there is no
parameter passed, therefore it tries to use next irrelevant flag.
This PR defines NoOptDefVal for validate flag which is set "strict".
2022-05-06 14:17:50 +03:00
Daniel Smith
1dabd7be5c
generated files
2022-05-05 20:12:51 +00:00
Daniel Smith
331525670b
Remove ClusterName
2022-05-05 20:12:50 +00:00
Steve Kuznetsov
4ff560e4fa
storage/testing: wire things back together with imports
...
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com >
2022-05-05 11:32:20 -07:00