github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
122,180 Commits 1 Branch 31 Tags
a2fb1b51aca61d03a2081bc226ab01a641271ce6
Commit Graph

183 Commits

Author SHA1 Message Date
Maksym Pavlenko
be4b7176dc Fix Abs path validation on Windows (#124084) 
* Windows: Consider slash-prefixed paths as absolute

filepath.IsAbs does not consider "/" or "\" as absolute paths, even
though files can be addressed as such. [1][2]

Currently, there are some unit tests that are failing on Windows due to
this reason.

[1] https://learn.microsoft.com/en-us/dotnet/standard/io/file-path-formats#traditional-dos-paths
[2] https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file#fully-qualified-vs-relative-paths

* Add test to verify IsAbs for windows

Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>

* Fix abs path validation on windows

Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>

* Skipp path clean check for podLogDir on windows

Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>

* Implement IsPathClean to validate path

Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>

* Add warn comment for IsAbs

Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>

---------

Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Co-authored-by: Claudiu Belu <cbelu@cloudbasesolutions.com>
 2024-04-10 10:13:59 -07:00
Kevin Hannon
6a4e19a4ec add no swap as the default option for swap 2024-03-05 16:10:42 -05:00
Kubernetes Prow Robot
dc3f5ec6cc Merge pull request #112957 from mxpv/log-dir 
Allow changing pod log directory
 2024-03-04 21:07:06 -08:00
Peter Hunt
cb39dfc9de Promote ImageMaximumGCAge to beta 
and set to be on by default, adapting e2e tests for it

Signed-off-by: Peter Hunt <pehunt@redhat.com>
 2024-02-27 15:11:45 -05:00
Kubernetes Prow Robot
98bd90fbe2 Merge pull request #114672 from pohly/log-text-split-streams 
log: split streams also for text output
 2024-02-26 01:44:58 -08:00
Maksym Pavlenko
8375163008 Add test to validate non empty pod log dir 
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
 2024-02-21 12:56:13 -08:00
Maksym Pavlenko
ff4f2907c5 Use non-default directory for pod logs and limit path to ASCII characters 
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
 2024-02-16 09:57:17 -08:00
Maksym Pavlenko
19d9405a1c Update comments and error messages 
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
 2024-02-16 09:56:01 -08:00
Maksym Pavlenko
d9e2487d0c Add PodLogsPath to kubelet config 
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
 2024-02-16 09:55:59 -08:00
Harsha Narayana
ab8c784ee9 kubelet: enable configurable rotation duration and parallel rotate 2024-02-09 16:49:11 +05:30
Patrick Ohly
8f4c9c7605 k8s.io/component-base/logs: replace klog text implementation 
This replaces the klog formatting and message routing with a simpler
implementation that uses less code. The main difference is that we skip the
entire unused message routing.

Instead, the same split output streams as for JSON gets implemented in the
io.Writer implementation that gets passed to the textlogger.
 2024-01-17 13:50:03 +01:00
Peter Hunt
76e623098c kubelet config validation: add validation for image max gc age 
Signed-off-by: Peter Hunt <pehunt@redhat.com>
 2023-10-20 12:23:31 -04:00
Peter Hunt
d992ea4b30 kubelet: add and use ImageMaximumGCAge in KubeletConfiguration 
Signed-off-by: Peter Hunt <pehunt@redhat.com>
 2023-10-20 12:23:31 -04:00
Dan Winship
f1e7386fbc Deprecate now-unused kubelet iptables flags 2023-07-17 16:51:47 -04:00
Jordan Liggitt
6c0ea702d4 Conditionally serialize flushFrequency as int 2023-07-16 08:37:37 -04:00
cyclinder
c550c17f7f accept int or string flush frequency 2023-07-13 14:33:33 +08:00
Ian K. Coolidge
cede96336a Depend on k8s.io/utils cpuset 
Steps performed:

$ find . -name '*.go' -exec sed -i
's|k8s.io/kubernetes/pkg/kubelet/cm/cpuset|k8s.io/utils/cpuset|g' {} \
$ ./hack/update-vendor.sh
$ ./hack/update-gofmt.sh
$ git rm -r pkg/kubelet/cm/cpuset/
 2023-05-03 16:26:09 +00:00
Tim Hockin
d55b67b349 Clean up brace whitespace in **/validation_test.go 
This was making my eyes bleed as I read over code.

I used the following in vim.  I made them up on the fly, but they seemed
to pass manual inspection.

:g/},\n\s*{$/s//}, {/
:w
:g/{$\n\s*{$/s//{{/
:w
:g/^\(\s*\)},\n\1},$/s//}},/
:w
:g/^\(\s*\)},$\n\1}$/s//}}/
:w
 2023-05-02 00:48:42 -07:00
Kubernetes Prow Robot
779abe6ebe Merge pull request #115399 from 3u13r/feat/documentTLS13Exception 
Add note about TLS 1.3 cipher suites
 2023-04-11 15:35:27 -07:00
Aravindh Puthiyaparambil
26279a5282 kubelet: Add validation for EnableNodeLogQuery 2023-03-14 08:45:20 -07:00
Aravindh Puthiyaparambil
aadad09410 api: Add EnableNodeLogQuery to KubeletConfiguration 
Added EnableNodeLogQuery field to kubelet/apis/config/types.go and
staging/src/k8s.io/kubelet/config/v1beta1/types.go, then executed.
 `hack/update-codegen.sh`.

This new field will default to off and will need to be explicitly
enabled in addition to the NodeLogQuery gate to use the feature.
 2023-03-14 08:45:19 -07:00
Kubernetes Prow Robot
625b8be09e Merge pull request #115371 from pacoxu/cgroup-v2-memory-tuning 
default memoryThrottlingFactor to 0.9 and optimize the memory.high formulas
 2023-03-08 18:46:00 -08:00
Kubernetes Prow Robot
8d5c96fed2 Merge pull request #116093 from swatisehgal/topologymanager-ga-graduation 
node: topologymgr: Graduate Kubelet Topology Manager to GA
 2023-03-08 16:56:06 -08:00
Paco Xu
f368413d65 sync default qps of kubelet change 2023-03-08 14:04:51 +08:00
Swati Sehgal
ae964a493f node: topologymgr: remove comments with feature gate references 
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
 2023-03-07 09:42:54 +00:00
Swati Sehgal
d536a342b4 node: topologymgr: GA graduation implies Feature Gate is ON by default 
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
 2023-03-06 12:51:05 +00:00
Wojciech Tyczyński
280651abcc Autogenerated 2023-03-06 12:08:34 +01:00
Wojciech Tyczyński
760acbbbe3 Bump QPS limits for Kubelet 2023-03-06 12:07:52 +01:00
Paco Xu
7dab6253e1 default memoryThrottlingFactor to 0.9 and optimize the memory.high calculation formulas 2023-03-03 11:24:40 +08:00
ruiwen-zhao
572e6e0ffb Add MaxParallelImagePulls support 
Signed-off-by: ruiwen-zhao <ruiwen@google.com>
 2023-03-02 03:57:59 +00:00
Kubernetes Prow Robot
53f3583c7f Merge pull request #114785 from TommyStarK/kubelet/replace-deprecated-pointer-function 
kubelet: Replace deprecated pointer function
 2023-03-01 18:04:55 -08:00
Paco Xu
3d536bd14b API docs: point to current docs instead of archived designs 2023-02-16 15:32:08 +08:00
Paco Xu
019d2615af archived design proposals are now moved to Design Proposals Archive Repo. 2023-02-08 11:12:22 +08:00
songxiao-wang87
3e6b954290 Making a run test. 
Signed-off-by: songxiao-wang87 <wang.xiaosong23@zte.com.cn>
 2023-01-31 09:38:48 +00:00
Leonard Cohnen
13354d3da4 Add note about TLS 1.3 cipher suites 2023-01-30 14:42:45 +01:00
TommyStarK
1fcc8fbf59 kubelet: Replace deprecated pointer function 
Signed-off-by: TommyStarK <thomasmilox@gmail.com>
 2023-01-08 13:44:09 +01:00
Paco Xu
f28f40e521 remove a flag check that was introduced in #112542; address several comments 
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
 2022-12-13 14:00:29 +08:00
Aditi Sharma
214a0ee7b8 Migrate container runtime endpoint flag to config 
Signed-off-by: Aditi Sharma <adi.sky17@gmail.com>
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
 2022-12-13 14:00:29 +08:00
PiotrProkop
daee219210 Improved multi-numa alignment in Topology Manager: add topology-manager-policy-options flag in Kubelet 
This patch adds new Kubelet option topologyManagerPolicyOptions.
To introduce new TopologyManager options, first we need to introduce new
flag called `topology-manager-policy-options` to allow users to modify
behaviour of best-effort and restricted policies.

Signed-off-by: PiotrProkop <pprokop@nvidia.com>
 2022-11-03 09:45:33 +01:00
Kubernetes Prow Robot
244c035b87 Merge pull request #110263 from claudiubelu/unittests 
unittests: Fixes unit tests for Windows
 2022-10-25 14:50:34 -07:00
Claudiu Belu
6f2eeed2e8 unittests: Fixes unit tests for Windows 
Currently, there are some unit tests that are failing on Windows due to
various reasons:

- config options not supported on Windows.
- files not closed, which means that they cannot be removed / renamed.
- paths not properly joined (filepath.Join should be used).
- time.Now() is not as precise on Windows, which means that 2
  consecutive calls may return the same timestamp.
- different error messages on Windows.
- files have \r\n line endings on Windows.
- /tmp directory being used, which might not exist on Windows. Instead,
  the OS-specific Temp directory should be used.
- the default value for Kubelet's EvictionHard field was containing
  OS-specific fields. This is now moved, the field is now set during
  Kubelet's initialization, after the config file is read.
 2022-10-25 23:46:56 +03:00
Kubernetes Prow Robot
6f579d3ceb Merge pull request #111616 from ndixita/credential-api-ga 
Move the Kubelet Credential Provider feature to GA and Update the Credential Provider API to GA
 2022-10-15 07:53:09 -07:00
Monis Khan
b738be9b46 Use https links for k8s KEPs, issues, PRs, etc 
Signed-off-by: Monis Khan <mok@microsoft.com>
 2022-09-23 23:36:24 +00:00
Dixita Narang
9c3cb6e66d Fixing boilerplate header 2022-09-16 21:20:30 +00:00
Dixita Narang
4cc741955c Adding default values for v1 credential provider config 2022-09-09 06:11:15 +00:00
Dixita Narang
977a8ebb3a Renaming usage of v1beta1 to v1, and adding API violation exceptions and 
vendor module for v1
 2022-09-09 06:11:06 +00:00
Dmitry Verkhoturov
d0f9e6dc36 clarify CPUCFSQuotaPeriod values, set the minimum to 1ms 
cpu.cfs_period_us is measured in microseconds in the kernel but
provided in time.Duration by the user, that change clarifies the code
to make this evident to the reader.

Also, the minimum value for that feature is 1ms and not 1μs, and this
change alters the validation to reject values smaller than 1ms.
 2022-09-08 23:29:13 +02:00
Antonio Ojea
d434c588d7 Revert "change CPUCFSQuotaPeriod default value to 100us to match Linux default" 
This reverts commit f2d591fae6.
 2022-08-26 23:51:04 +02:00
Kubernetes Prow Robot
2b5475b3fa Merge pull request #111554 from paskal/paskal/clarify_default_cfs_period 
Clarify cpu.cfs_period_us default value
 2022-08-25 07:28:07 -07:00
Kubernetes Prow Robot
70254065ea Merge pull request #109966 from zhangxyjlu/config_validation_test 
Add validation test for features.GracefulNodeShutdownBasedOnPodPriority
 2022-08-24 00:02:24 -07:00