Patrick Ohly
bc6c7fa912
logging: fix names of keys
...
The stricter checking with the upcoming logcheck v0.4.1 pointed out these names
which don't comply with our recommendations in
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md#name-arguments .
2023-01-23 14:24:29 +01:00
Maciej Szulik
be44d67566
Re-use common parts between getNextScheduleTime and nextScheduledTimeDuration
...
The two methods nextScheduledTimeDuration and getNextScheduleTime have a
lot of similarities, so this commit squashes the common parts together
along with getMostRecentScheduleTime to avoid code duplication.
2023-01-18 16:52:45 +01:00
Maciej Szulik
cb491a8d0f
Cleanups in controller utils
...
1. Squash two identical sorters byTime
2. Move helper for searching active jobs into utils to exist next to its
counterpart
2023-01-18 13:40:23 +01:00
Jordan Liggitt
78cb3862f1
Fix indentation/spacing in comments to render correctly in godoc
2022-12-17 23:27:38 -05:00
Kubernetes Prow Robot
ead17f3dc8
Merge pull request #113008 from soltysh/promote_cronjob_metrics
...
Promote cronjob_job_creation_skew metric to stable
2022-11-04 09:36:27 -07:00
Maciej Szulik
4af97e599a
Promote cronjob_job_creation_skew metric to stable
2022-11-04 13:55:32 +01:00
Wojciech Tyczyński
c84c27b6ac
Clean shutdown of event broadcaster in controllers
2022-11-02 21:08:43 +01:00
Han Kang
2bbd445f50
remove rate limiter metric as it is not in use
...
Change-Id: I91157653e3860eeecc3f572aee88da6ffc65faed
2022-10-13 13:07:11 -07:00
Davanum Srinivas
a9593d634c
Generate and format files
...
- Run hack/update-codegen.sh
- Run hack/update-generated-device-plugin.sh
- Run hack/update-generated-protobuf.sh
- Run hack/update-generated-runtime.sh
- Run hack/update-generated-swagger-docs.sh
- Run hack/update-openapi-spec.sh
- Run hack/update-gofmt.sh
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2022-07-26 13:14:05 -04:00
Kubernetes Prow Robot
6269784cd0
Merge pull request #109250 from d-honeybadger/fix-cronjob-scheduling-every-syntax
...
Fix requeueing of cronjobs with every-style schedule
2022-06-28 04:37:57 -07:00
Jordan Liggitt
495b01ef6c
Move cron job feature gate to correct file
2022-04-03 22:56:01 -04:00
d-honeybadger
7ae21b9849
cronjob_controllerv2: fix requeueing of cronjobs with every-style schedule
2022-04-01 20:14:23 -04:00
Ross Peoples
dbb3906a09
Fix for timeZone validation and strategy
2022-03-29 11:40:34 -05:00
Ross Peoples
f3b928a23d
Import tzdata in apiserver, CronJob.timeZone fixes
2022-03-28 16:33:05 -05:00
Ross Peoples
98837de446
TimeZone support for CronJobs
2022-03-28 16:33:00 -05:00
Kubernetes Prow Robot
343125cc6c
Merge pull request #107997 from d-honeybadger/fix-tracking-cronjob-owned-jobs
...
Fix cronjob status reconciliation when job template labels change
2022-02-23 07:14:18 -08:00
d-honeybadger
fb094dc44e
cronjob_controllerv2: do not filter jobs to be reconciled by labels
2022-02-23 09:10:33 -05:00
jlsong01
d281e25426
Optimize cronjob controller status updates
2022-01-27 17:09:47 +08:00
Kubernetes Prow Robot
876d4e0ab0
Merge pull request #107659 from jlsong01/readability_ut_cj_controller
...
readability enhancement for cj controller unit test
2022-01-26 21:12:49 -08:00
jlsong01
79d921e040
readability enhancement for cj controller unit test
2022-01-20 23:10:10 +08:00
Wojciech Tyczyński
551790729f
Remove selflink references in different testing-related files
2022-01-14 12:58:05 +01:00
Davanum Srinivas
9682b7248f
OWNERS cleanup - Jan 2021 Week 1
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2022-01-10 08:14:29 -05:00
Kubernetes Prow Robot
3bebe8f6b5
Merge pull request #105264 from devincd/fix_typo
...
fix the log description
2022-01-06 17:40:29 -08:00
Kubernetes Prow Robot
8ade75465a
Merge pull request #104799 from RyanAoh/cronjob_dev
...
fix the error when cleaning up finished jobs for cronjob
2021-12-17 13:23:53 -08:00
Davanum Srinivas
9405e9b55e
Check in OWNERS modified by update-yamlfmt.sh
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-12-09 21:31:26 -05:00
Aohan Yang
ad4fe13528
fix the error when cleaning up jobs for cronjob
2021-11-22 17:06:22 +08:00
Maciej Szulik
d0518848b5
Add warning about using unsupported CRON_TZ
...
CRON_TZ variable slipped in during upgrading github.com/robfig/cron
library. It allows setting a time zone which is a long requested
feature but one that is not officially supported. This adds warning
event since users should not rely on unsupported features.
2021-11-16 17:41:37 +01:00
Mike Dame
80c01707e0
Wire contexts to Batch controllers ( #105491 )
...
* Wire contexts to Batch controllers
* (hold) feedback + updates that overlap with Apps controllers
* fixup errors
2021-11-10 14:56:46 -08:00
Maciej Szulik
5254493044
Remove old cronjob controller
2021-11-04 13:24:28 +01:00
devincd
e62aef4fc9
fix the log description
...
Signed-off-by: devincd <505259926@qq.com>
2021-09-27 14:20:33 +08:00
Stephen Augustus
481cf6fbe7
generated: Run hack/update-gofmt.sh
...
Signed-off-by: Stephen Augustus <foo@auggie.dev>
2021-08-24 15:47:49 -04:00
Kubernetes Prow Robot
270b66fb94
Merge pull request #102642 from alaypatel07/lastSuccessfulTime
...
populate last successful time to cronjob status
2021-06-15 11:31:35 -07:00
Kubernetes Prow Robot
8eef6438e6
Merge pull request #101055 from SimonCqk/master
...
fix: inaccurate miss schedule times of cronjob v2.
2021-06-15 08:38:01 -07:00
Davanum Srinivas
4b36a5cbe9
Switch to github.com/robfig/cron/v3
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-06-14 19:03:03 -04:00
Kubernetes Prow Robot
52eea971c5
Merge pull request #99279 from yangjunmyfm192085/run-test22
...
Fix typo: Use uniform format of structured klog
2021-06-11 19:22:59 -07:00
Alay Patel
92b52a4fb5
populate last successful time to cronjob status
2021-06-06 16:14:16 -04:00
cndoit18
51717256f9
fix(timezone): the timezone is standardized to UTC
...
Signed-off-by: cndoit18 <cndoit18@outlook.com>
2021-06-03 23:55:39 +08:00
SimonCqk
b9d9cc38b5
fix: inaccurate miss schedule times of cronjob v2.
...
Signed-off-by: SimonCqk <cqk0100@gmail.com>
2021-04-13 13:59:27 +08:00
JunYang
78323910db
Fix typo: Use uniform format of structured klog
...
Signed-off-by: JunYang <yang.jun22@zte.com.cn>
2021-04-10 12:00:00 +08:00
Niekvdplas
fec272a7b2
Fixed several spelling mistakes
2021-03-30 23:02:09 +02:00
Maciej Szulik
0a8417e161
Simplify cronjob v2 controller tests
2021-03-05 19:25:51 +01:00
Maciej Szulik
78f51f8fa5
Switch cronjob controller to batch/v1
2021-03-05 14:03:34 +01:00
mengjiao.liu
f80a799a45
modify the TestController2_updateCronJob test method description
2021-03-04 11:20:33 +08:00
Kubernetes Prow Robot
a89d783b27
Merge pull request #99553 from alaypatel07/fix-flaky-unit-test
...
cronjob: fix flaky unit test TestController2_updateCronJob
2021-03-02 11:11:31 -08:00
Alay Patel
08bc827e66
cronjob_controller: add metrics for job creation skew duration
2021-03-02 10:38:59 -05:00
Alay Patel
602435ccb9
cronjob: fix flaky unit test TestController2_updateCronJob
2021-03-01 15:45:32 -05:00
Benjamin Elder
56e092e382
hack/update-bazel.sh
2021-02-28 15:17:29 -08:00
Kubernetes Prow Robot
c198632a12
Merge pull request #97098 from alaypatel07/cronjob-controller-2-follow-up-2
...
fix the case of time drift and re-implement next schedule calculation
2021-02-25 12:21:40 -08:00
Alay Patel
cebbc6b487
cronjob: use the same schedule Parser for tests as the reconcile loop
2021-02-24 13:50:03 -05:00
Alay Patel
6290a23ceb
cronjob_controllerv2: gracefully handle 0 seconds between schedules
2021-02-24 13:48:56 -05:00