Commit Graph

3067 Commits

Author SHA1 Message Date
Jing Xu
a4aa494cc1 Remove ready directory which created in empty volumeMounter setUp func
Change-Id: I2384b07c7a044149e93e951a45f9f8a7bd9dba15
2020-11-09 23:12:21 -08:00
Kubernetes Prow Robot
d970c18ab8
Merge pull request #95451 from mkumatag/fix_fc
Fix fcpath
2020-10-15 07:10:39 -07:00
Kubernetes Prow Robot
978233775e
Merge pull request #94992 from lala123912/gxf
fix pkg/volume/util static checks
2020-10-15 00:44:24 -07:00
Manjunath A Kumatagi
4a75c7ef1e Fix fcpath 2020-10-14 21:15:22 +05:30
Kubernetes Prow Robot
e799c852fb
Merge pull request #95447 from gnufied/fix-disk-detach-failure
Fix vsphere disk detach failure
2020-10-13 03:36:41 -07:00
tashen
27cb5cf4f0 add systemd mount options interface to support the no-systemd mount 2020-10-13 13:46:57 +08:00
Hemant Kumar
5627771601 Fix vsphere disk detach failing
Make inability to fetch canonicalPath non-fatal error
Throw error if we can't fetch canonicalPath on attach
2020-10-12 21:58:28 -04:00
andyzhangx
9e35244c6c fix azure disk data loss issue on Windows 2020-10-10 02:20:49 +00:00
Sam Fowler
e91ec4fad3 Mask Ceph RBD adminSecrets in logs when logLevel >= 4 2020-10-02 10:48:11 +10:00
lala123912
7594702b22 modify static check
fix format
2020-09-23 19:27:24 +08:00
Kubernetes Prow Robot
796f9d89ba
Merge pull request #94781 from ejweber/fc-attacher-empty-devname
Don't attempt to detach an FC device if we don't know its name
2020-09-22 18:34:22 -07:00
Kubernetes Prow Robot
0b8c2bf1a1
Merge pull request #94735 from mikedanese/flake
test flake: fix data race in csi_test.go
2020-09-22 12:24:01 -07:00
Kubernetes Prow Robot
dd466bccde
Merge pull request #94527 from brahmaroutu/mount-utils-2
Change code to use  staging/k8s.io/mount-utils
2020-09-21 17:46:47 -07:00
Matthew Cary
299a296c7a update-bazel
Change-Id: Iebc99ee13587f0cd4c43ab85c7295d458d679d1e
2020-09-18 00:44:39 +00:00
Matthew Cary
f2e23afcf1 Adds filtering of hosts to DialContexts.
The provided DialContext wraps existing clients' DialContext in an attempt to
preserve any existing timeout configuration. In some cases, we may replace
infinite timeouts with golang defaults.

- scaleio: tcp connect/keepalive values changed from 0/15 to 30/30
- storageos: no change
2020-09-18 00:07:32 +00:00
Matthew Cary
74dbf274d9 update storageos vendor for FilteredDial change 2020-09-18 00:07:32 +00:00
Kubernetes Prow Robot
550b83b293
Merge pull request #92027 from juliantaylor/fix-rbd-expand
fix expanding rbd volumes without ceph.conf
2020-09-17 05:24:45 -07:00
Srini Brahmaroutu
fbe5daed73 Change code to use staging/k8s.io/mount-utils 2020-09-16 21:51:24 -07:00
Kubernetes Prow Robot
09b3f6dbb3
Merge pull request #93214 from trashhalo/prefer-error
test: prefer NoError/Error over Nil/NotNil
2020-09-16 15:10:45 -07:00
knight42
e89e72b637
test: ensure WaitForCacheSync is called after starting sharedInformerFacotry
Signed-off-by: knight42 <anonymousknight96@gmail.com>
2020-09-15 16:02:35 +08:00
Eric Weber
5cd63097ba Don't attempt to detach an FC device if we don't know its name 2020-09-14 14:32:00 -05:00
Mike Danese
94f4f06d13 test flake: fix data race in csi_test.go
The attach goroutine can currently t.Log/t.Error during or after the
subtest completion. This causes races like:

```
==================
WARNING: DATA RACE
Read at 0x00c000e90ac3 by goroutine 1231:
  testing.(*common).logDepth()
      GOROOT/src/testing/testing.go:736 +0xa9
  testing.(*common).log()
      GOROOT/src/testing/testing.go:729 +0x8f
  testing.(*common).Logf()
      GOROOT/src/testing/testing.go:775 +0x21
  k8s.io/kubernetes/pkg/volume/csi.TestCSI_VolumeAll.func21.1()
      pkg/volume/csi/csi_test.go:313 +0x1a4
Previous write at 0x00c000e90ac3 by goroutine 875:
  testing.tRunner.func1()
      GOROOT/src/testing/testing.go:1113 +0x484
  testing.tRunner()
      GOROOT/src/testing/testing.go:1131 +0x22a
  testing.tRunner()
      GOROOT/src/testing/testing.go:1127 +0x202
Goroutine 1231 (running) created at:
  k8s.io/kubernetes/pkg/volume/csi.TestCSI_VolumeAll.func21()
      pkg/volume/csi/csi_test.go:307 +0xf05
  testing.tRunner()
      GOROOT/src/testing/testing.go:1127 +0x202
Goroutine 875 (running) created at:
  testing.(*T).Run()
      GOROOT/src/testing/testing.go:1178 +0x796
  k8s.io/kubernetes/pkg/volume/csi.TestCSI_VolumeAll()
      pkg/volume/csi/csi_test.go:223 +0xb2c
  testing.tRunner()
      GOROOT/src/testing/testing.go:1127 +0x202
==================
```

See also this comment:

07c1788357/src/testing/testing.go (L1141-L1142)

Noticed in:

https://github.com/kubernetes/kubernetes/pull/94449
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/94449/pull-kubernetes-bazel-test/1304519003330318337
2020-09-11 22:19:42 -07:00
Kubernetes Prow Robot
30a9b8b126
Merge pull request #94389 from pacoxu/fix/94378
add lock for csi node update
2020-09-09 06:36:07 -07:00
David Dymko
cda0070f28 fix golint for pkg/volume/azure_dd 2020-09-05 09:44:27 -04:00
Stephen Solka
203679cc61 prefer NoError/Error over Nil/NotNil 2020-09-04 18:35:52 -04:00
Kubernetes Prow Robot
6ee74bf600
Merge pull request #94031 from knight42/fix/TestAttacherWithCSIDriver
test(csi): deflake TestAttacherWithCSIDriver
2020-09-03 11:13:55 -07:00
knight42
469f59a52a
test(csi): deflake TestAttacherWithCSIDriver
Signed-off-by: knight42 <anonymousknight96@gmail.com>
2020-09-03 22:39:40 +08:00
Kubernetes Prow Robot
adac1bfb8b
Merge pull request #93176 from yuzhiquan/fix-hostpath-test
Fix for host path test case
2020-09-02 22:57:40 -07:00
Kubernetes Prow Robot
5f79e91221
Merge pull request #94340 from ialidzhikov/fix/max-data-disk-count
Update max data disk count with new instance types
2020-09-02 02:38:08 -07:00
Kubernetes Prow Robot
d2a0b6f2b8
Merge pull request #90014 from jacobmarble/aws-max-total-iops
AWS: remove volume IOPS limit
2020-09-02 00:41:20 -07:00
Kubernetes Prow Robot
82475c3186
Merge pull request #94126 from andyzhangx/windows-azurefile-mountoptions
fix: use sensitiveOptions on Windows mount
2020-09-01 16:35:20 -07:00
pacoxu
2360f228ab add lock for csi node update
Signed-off-by: pacoxu <paco.xu@daocloud.io>
2020-09-01 15:52:04 +08:00
Kubernetes Prow Robot
e23d83eead
Merge pull request #93710 from Jiawei0227/attachable2non
Detect volume attach-ability in the middle of attaching
2020-08-31 17:39:50 -07:00
ialidzhikov
2327e32839 Update max data disk count with new instance types
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
2020-08-30 21:52:41 +03:00
Kubernetes Prow Robot
7abc47d315
Merge pull request #93136 from donggangcj/fix-static-check-error
fix(staticcheck): fix static error of package `/pkg/volume/gcepd`
2020-08-28 06:35:21 -07:00
Kubernetes Prow Robot
5760cef7a4
Merge pull request #92878 from jvanz/issue90293
cleanup: print warning message only if the function does not finish within 30 seconds
2020-08-27 19:07:55 -07:00
Kubernetes Prow Robot
2e59a17dc1
Merge pull request #92288 from zhijianli88/cleanup-tempfiles
Cleanup tempfiles
2020-08-27 17:56:54 -07:00
Kubernetes Prow Robot
b9c461afe5
Merge pull request #93852 from nikhita/cleanup-vsphere-owners
vsphere: remove inactive members from OWNERS
2020-08-27 06:42:21 -07:00
Jiawei Wang
a6d8e6c5c2 Detect change of volume attachability in the middle of attaching
- Add Unit tests for both volumemanager and attach/detach controller
- Add E2E test
2020-08-24 17:15:11 -07:00
andyzhangx
1b213c9053 fix: use sensitiveOptions on Windows mount 2020-08-20 07:31:07 +00:00
Jing Xu
5aa817ab43 Fix issue in evaluating symlink path for subpath
This PR tries to fix issue https://github.com/kubernetes/kubernetes/issues/93759
2020-08-14 19:39:55 -07:00
Nikhita Raghunath
53e87ddd15 vsphere: remove inactive members from OWNERS
As a part of cleaning up inactive members (who haven't been active since
beginning of 2019) from OWNERS files, this commit moves abrarshivani to
emeritus_approvers section.
2020-08-10 15:23:25 +05:30
Jordan Liggitt
f33dc28094 generated: hack/update-hack-tools.sh && hack/update-vendor.sh 2020-07-25 16:45:02 -04:00
José Guilherme Vanz
5ebb1c3be2
cleanup: print warning message after timeout
If a pod has a configmap/secret volume an annoying message shows up
in the log approximately every 70 seconds. This happens because the
desiredStateOfWorldPopulator sync loop always call the
MarkRemountRequired. The function finds the volume plugin and check
if the plugin requires mount. Configmap and secret plugins always
returns true for that. Thus, the reconciler code of the volume manager
remounts the volume every time. This commit change the SetVolumeOwnership
to print the warning only if the function does not finish within 30
seconds.

Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
2020-07-20 22:46:11 -03:00
José Guilherme Vanz
08ccbe6f0e
Revert "cleanup: decrease log level from warn to v3"
This reverts commit ebece49936e635f151fdd8a64fa2b77fd183e817.
2020-07-20 22:46:11 -03:00
José Guilherme Vanz
9b9dcf3d84
cleanup: decrease log level from warn to v3
If a pod has a configmap/secret volume an annoying message shows up
in the log approximately every 70 seconds. This happens because the
desiredStateOfWorldPopulator sync loop always call the
MarkRemountRequired. The function finds the volume plugin and check
if the plugin requires mount. Configmap and secret plugins always
returns true for that. Thus, the reconciler code of the volume manager
remounts the volume every time. This commit decrease the log level of
that message in the mount function from warning to V4.

Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
2020-07-20 22:46:11 -03:00
Phil Bracikowski
d880a1b78c AWS: increase io1 volume IOPs limit
Max IOPS for SSD (io1) volumes was increased from 20,000 to 32,000:
https://aws.amazon.com/about-aws/whats-new/2017/12/amazon-ebs-provisioned-iops-ssd--io1--volumes-now-support-32-000-iops-and-500-mbs-per-volume/

and later to 64,000:
https://aws.amazon.com/about-aws/whats-new/2018/11/amazon-elastic-block-store-announces-double-the-performance-of-provisioned-iops-volumes/
2020-07-20 17:41:13 -07:00
yuzhiquan
aca107eee5 Fixed potential nil dereference in hostpath unit test 2020-07-20 20:58:36 +08:00
yuzhiquan
a60cbd5535 Fixed error string should not be capitalized 2020-07-20 20:58:06 +08:00
Dong Gang
b30f6f30ed fix(staticcheck): fix static error of package /pkg/volume/gcepd
Signed-off-by: Dong Gang <dong.gang@daocloud.io>
2020-07-18 10:54:10 +08:00