Commit Graph

10412 Commits

Author SHA1 Message Date
Christoph Blecker
710c8563b4 Fix go vet errors 2018-04-02 17:57:44 -07:00
Kubernetes Submit Queue
c46738a3f0 Merge pull request #60073 from justaugustus/int-to-int32ptr
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Use `pkg/util/pointer` functions instead of self-written versions

**What this PR does / why we need it**:
Replaces instances of module-written `int(32|64)? --> *int(32|64)?` functions with functions from k8s.io/kubernetes/pkg/util/pointer

**Special notes for your reviewer**:

Here's the grep used, based on the comments in:
* https://github.com/kubernetes/kubernetes/pull/59924#issuecomment-366119396
* https://github.com/kubernetes/kubernetes/issues/59971#issue-297766556

```bash
$ git grep -E 'func\ [^ (]+\([^ ]+\ int(32|64)?\)\ \*int(32|64)?' !(vendor|staging) | grep -v pkg/util/pointer

pkg/apis/apps/v1/defaults_test.go:func newInt32(val int32) *int32 {
pkg/apis/apps/v1beta1/defaults_test.go:func newInt32(val int32) *int32 {
pkg/apis/apps/v1beta2/defaults_test.go:func newInt32(val int32) *int32 {
pkg/apis/autoscaling/v1/defaults_test.go:func newInt32(val int32) *int32 {
pkg/apis/autoscaling/v2beta1/defaults_test.go:func newInt32(val int32) *int32 {
pkg/apis/autoscaling/validation/validation_test.go:func newInt32(val int32) *int32 {
pkg/apis/batch/v1/defaults_test.go:func newInt32(val int32) *int32 {
pkg/apis/batch/v1beta1/defaults_test.go:func newInt32(val int32) *int32 {
pkg/apis/core/v1/defaults_test.go:func newInt(val int32) *int32 {
pkg/apis/core/validation/validation_test.go:func newInt32(val int) *int32 {
pkg/apis/extensions/v1beta1/defaults_test.go:func newInt32(val int32) *int32 {
pkg/controller/deployment/sync_test.go:func intOrStrP(val int) *intstr.IntOrString {
pkg/kubectl/autoscale_test.go:func newInt32(value int) *int32 {
plugin/pkg/admission/security/podsecuritypolicy/admission_test.go:func userIDPtr(i int) *int64 {
plugin/pkg/admission/security/podsecuritypolicy/admission_test.go:func groupIDPtr(i int) *int64 {
test/e2e/apps/deployment.go:func intOrStrP(num int) *intstr.IntOrString {
test/e2e/auth/pod_security_policy.go:func intPtr(i int64) *int64 {
test/integration/deployment/util.go:func intOrStrP(num int) *intstr.IntOrString {
```

**Release note**:

```release-note
NONE
```
/kind cleanup
/cc @php-coder 
/assign @tallclair
2018-04-02 16:22:28 -07:00
Kubernetes Submit Queue
3b82ea6bcd Merge pull request #60597 from cblecker/go-go-go-one-dot-ten
Automatic merge from submit-queue (batch tested with PRs 61096, 61955, 61542, 60597). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update to use go1.10.1

**What this PR does / why we need it**:
Update to use go1.10.1

**Release note**:
```release-note
Update to use go1.10.1
```
2018-04-02 15:35:12 -07:00
Kubernetes Submit Queue
863d1f5f72 Merge pull request #61987 from nikhiljindal/ingressTest
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Getting error from GetFirewallRule and checking it to fix multicluster ingress test

Fixes https://github.com/kubernetes/kubernetes/pull/61909#issuecomment-377704479

Adding a GetFirewallRuleOrError method that returns the error rather than failing and using that in our multicluster ingress test.

cc @nicksardo @MrHohn @G-Harmon @csbell 

```release-note
NONE
```
2018-04-02 14:06:32 -07:00
nikhiljindal
0f23756d49 Getting error from GetFirewallRule and checking it to fix multicluster ingress test 2018-04-02 10:53:15 -07:00
Satyadeep Musuvathy
86aa5ae9c8 Support custom test configurations 2018-04-02 10:29:36 -07:00
David Eads
ee5bc39c4c remove kube-apiserver option that is always force to true 2018-04-02 12:19:34 -04:00
Ayush Pateria
121bc9c838 Seperate timer durations for expectEvent and expectNoEvent 2018-04-02 19:42:12 +05:30
Ayush Pateria
cbdbcb515b Add e2e test for CRD Watch 2018-04-02 19:40:36 +05:30
Kubernetes Submit Queue
97fdf8ac70 Merge pull request #61895 from atlassian/address-todo
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Use typed events client directly

**What this PR does / why we need it**:
This PR addresses the TODO - the typed events client can be used directly without wrapping.

**Release note**:

```release-note
NONE
```
/kind cleanup
2018-04-02 07:07:50 -07:00
Mikhail Mazurskiy
468655b76a Use typed events client directly 2018-04-01 18:57:29 +10:00
nikhiljindal
cacc9cc87f init annotations if it is nil to fix kubemci e2e test failures 2018-03-31 16:14:38 -07:00
Harry Zhang
2fae40d886 Update bazel 2018-03-31 00:31:32 -07:00
Harry Zhang
187c5bc91e Use initTest for integration to start scheduler
Fix import path

Fix configurator name
2018-03-31 00:28:08 -07:00
Harry Zhang
782a092e2e Use feature gate in integration
Clean up unused import
2018-03-31 00:28:08 -07:00
Kubernetes Submit Queue
7ce753aa73 Merge pull request #61894 from atlassian/misc-cleanups
Automatic merge from submit-queue (batch tested with PRs 61894, 61369). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Use range in loops; misc fixes

**What this PR does / why we need it**:
It is cleaner to use `range` in for loops to iterate over channel until it is closed.

**Release note**:
```release-note
NONE
```
/kind cleanup
2018-03-30 21:16:01 -07:00
Kubernetes Submit Queue
1c008c582c Merge pull request #61909 from nikhiljindal/testMCI
Automatic merge from submit-queue (batch tested with PRs 54997, 61869, 61816, 61909, 60525). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Updating multicluster e2e test to ensure that controller only creates instance groups

Ref https://github.com/kubernetes/ingress-gce/issues/182

Updating the multicluster ingress e2e test to also verify that the controller does not create any other resource than instance group.

I was planning to do that using annotations first, but turns out that we have the right check for annotations: 61d574a2c7/pkg/controller/controller.go (L317) :)

Am using `length(ListResource) == 0` now but have still kept the annotation check.

cc @nicksardo @MrHohn @G-Harmon

**Release note**:
```release-note
NONE
```
2018-03-30 20:13:12 -07:00
Christoph Blecker
9690d44fca Update to use go1.10.1 2018-03-30 15:26:18 -07:00
Kubernetes Submit Queue
718568a94e Merge pull request #61871 from MrHohn/e2e-ingress-gce-shared-test
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

[e2e ingress-gce] Run preshared-cert and backend HTTPS tests with kubemci

**What this PR does / why we need it**:

Make preshared-cert and backside-reencryption tests compatible with kubemci.

Test is currently failing with the symptom described on https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/issues/131#issuecomment-377098544.

@nikhiljindal @g-harmon 
/hold

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #NONE 

**Release note**:

```release-note
NONE
```
2018-03-30 14:21:51 -07:00
nikhiljindal
25eb545a3c Updating multicluster test to ensure that controller only creates instance groups 2018-03-30 12:40:54 -07:00
Kubernetes Submit Queue
8a783b0664 Merge pull request #59768 from barney-s/sts-integration
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Adding integration tests for statefulset

**What this PR does / why we need it**:
Creates a base statefulset integration test framework.
Basic tests added.


**Which issue(s) this PR fixes**:
None

**Special notes for your reviewer**:
Cloned pull/52583 and updated it to work with latest API changes.

**Release note**:
None.
2018-03-30 09:35:01 -07:00
Zihong Zheng
34acfcd027 [e2e ingress-gce] Run preshared-cert and backside-reencryption tests with kubemci 2018-03-30 08:52:28 -07:00
Kubernetes Submit Queue
6360192eab Merge pull request #61847 from mengqiy/patch_conflict
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

fix patch conflict detection in apiserver

Patching conflict for merging list with mergeKey is not determined in the correct way. 

```release-note
None
```
2018-03-30 07:55:12 -07:00
Kubernetes Submit Queue
621610d079 Merge pull request #61935 from kawych/master
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Use old resource model in External Metrics API e2e tests

**What this PR does / why we need it**:
Currently e2e tests for External Metrics are failing, because the tests projects are not whitelisted to use new Stackdriver resource model. They will be in a week, but this particular test doesn't have to depend on it.

**Release note**:
```release-note
NONE
```
2018-03-30 06:49:25 -07:00
Karol Wychowaniec
ac7ae3be7c Use old resource model in External Metrics API e2e tests 2018-03-30 14:00:38 +02:00
Kubernetes Submit Queue
ca5f4b2a09 Merge pull request #61936 from kawych/owner
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add kawych to OWNERS of instrumentation e2e tests

**Release note**:
```release-note
NONE
```
2018-03-30 04:30:36 -07:00
Karol Wychowaniec
c562384ecf Add kawych to OWNERS of instrumentation e2e tests 2018-03-30 12:11:39 +02:00
Kubernetes Submit Queue
e57af2b354 Merge pull request #61760 from bskiba/test-em-sd-clean
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add e2e test for external metrics with Stackdriver

**What this PR does / why we need it**:
Adds e2e tests for external metrics using Stackdriver adapter.
Rename the file to note that these are Stackdriver tests in anticipation of tests running with fake custom metrics apiserver. Refactor the tests to be more structured.

**Release note**:
```
NONE
```
2018-03-30 02:11:20 -07:00
Kubernetes Submit Queue
f8d37cdaf1 Merge pull request #61920 from resouer/fix-61916
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add namespace name into e2e event verify function

**What this PR does / why we need it**:

Scheduler now events assigned msg with `ns/podname`, but the e2e is still expect `podname` only.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #61916

**Special notes for your reviewer**:

cc @Random-Liu @bsalamat 
@kubernetes/sig-scheduling-pr-reviews 

**Release note**:

```release-note
NONE
```
2018-03-30 00:15:37 -07:00
Kubernetes Submit Queue
99fd98a893 Merge pull request #61740 from filbranden/nodetest1
Automatic merge from submit-queue (batch tested with PRs 61482, 61740). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Make systemd service name for kubelet use a timestamp in e2e-node tests.

**What this PR does / why we need it**:

This makes it easier to figure out which execution was last when looking at the output of `systemd list-units kubelet-*.service`.

We try to find the name of the /tmp/node-e2e-* directory and use the same timestamp if we can. Otherwise, we just call Now() again, which isn't as nice (as the unit name and directory name will not match) but will still produce unit names that will be ordered when launching multiple subsequent executions on the same host.


**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
N/A

**Special notes for your reviewer**:

Tested using `make test-e2e-node REMOTE=true` and then checking `systemctl list-units kubelet-*.service` on the target host.

```
$ systemctl list-units kubelet-*.service
kubelet-20180326T142016.service loaded active exited /tmp/node-e2e-20180326T142016/kubelet --kubeconfig /tmp/node-e2e-20180326T142016/kubeconfig --root-dir /var/lib/kubelet ...
kubelet-20180326T143550.service loaded active exited /tmp/node-e2e-20180326T143550/kubelet --kubeconfig /tmp/node-e2e-20180326T143550/kubeconfig --root-dir /var/lib/kubelet ...
```

The units are sorted in the order they were launched.

**Release note**:

```release-note
NONE
```
2018-03-29 21:10:03 -07:00
Mengqi Yu
ff18af452d fix patch conflict detection in apiserver 2018-03-29 20:05:58 -07:00
Filipe Brandenburger
b8c39b7055 In summary_test, make Docker cpu/memory checks optional if unavailable.
The numbers will only be available when docker.service has its own
memory and cpu cgroups, which doesn't necessarily happen unless the unit
has Delegate=yes configured.

Let's work around that by checking the status of Delegate, in the case
where we are:
* running Docker
* running Systemd
* able to check the status through systemctl
* the status is explicitly Delegate=no (the default)

If all of those are true, let's make CPU and Memory expectations
optional.

Tested: make test-e2e-node REMOTE=true HOSTS=centos-e2e-node FOCUS="Summary API"
2018-03-29 18:12:30 -07:00
Filipe Brandenburger
351a70b60e In summary_test, create a file outside the test volume too.
This is necessary to show any RootFs usage on systems where the backing
filesystem of overlay2 is xfs.

The current test only created directories (for mount points) in the
upper layer of the overlay. Outside of the mount namespace, only the
directories are visible. When running `du` on those, usually filesystems
will show some usage, but not xfs, which shows a disk usage of 0 for
directories.

Fix this by creating a file in the root directory, outside the volumes,
in order to trigger some disk usage that can be measured by `du`.

Tested: make test-e2e-node REMOTE=true HOSTS=centos-e2e-node FOCUS="Summary API"
2018-03-29 18:12:29 -07:00
Kubernetes Submit Queue
5ae7bba496 Merge pull request #60100 from mtaufen/node-authz-nodeconfigsource
Automatic merge from submit-queue (batch tested with PRs 61829, 61908, 61307, 61872, 60100). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

node authorizer sets up access rules for dynamic config

This PR makes the node authorizer automatically set up access rules for
dynamic Kubelet config.

I also added some validation to the node strategy, which I discovered we
were missing while writing this.

This PR is based on another WIP from @liggitt.

```release-note
The node authorizer now automatically sets up rules for Node.Spec.ConfigSource when the DynamicKubeletConfig feature gate is enabled.
```
2018-03-29 17:37:18 -07:00
Kubernetes Submit Queue
6c107fccfd Merge pull request #61872 from rmmh/verify-coalesce
Automatic merge from submit-queue (batch tested with PRs 61829, 61908, 61307, 61872, 60100). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Deduplicate identical typecheck errors between platforms.

**What this PR does / why we need it**: Deduplicate identical typecheck errors between platforms.

This will make typecheck output shorter for code that fails compilation everywhere,
like [this](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/61869/pull-kubernetes-typecheck/3274/).

**Release note**:
```release-note
NONE
```
2018-03-29 17:37:15 -07:00
Kubernetes Submit Queue
fe7514cfbc Merge pull request #61307 from filbranden/curl1
Automatic merge from submit-queue (batch tested with PRs 61829, 61908, 61307, 61872, 60100). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Use curl instead of wget to fetch the CNI tarball in e2e-node test

**What this PR does / why we need it**:

Curl is more ubiquitous than wget. For instance, the GCE centos-7 and rhel-7 image families ship curl by default, but not wget.

Looking at the shell scripts under cluster/, they tend to use curl more than wget. (The ones that use wget, such as get-kube.sh, try curl first and only fallback to wget if it's not available.)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:

Fixes running node e2e test on centos-7 or rhel-7 image families provided in GCE.

**Special notes for your reviewer**:

Tested by running node-e2e-test on Ubuntu, COS and CentOS.

**Release note**:

```release-note
NONE
```
2018-03-29 17:37:12 -07:00
Harry Zhang
b646467536 Add namespace name into e2e event verify 2018-03-29 17:37:03 -07:00
Kubernetes Submit Queue
bc2cc5a75d Merge pull request #61560 from apelisse/fix-failing-ui-dashboard-1.10
Automatic merge from submit-queue (batch tested with PRs 57658, 61304, 61560, 61859, 61870). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

test: Disable ui dashboard test for gke

The dashboard is disabled on GKE 1.10, the test is failing because it's
not alive. Let's just skip this use-case, and keep a todo that it'd be
nice to enable the dashboard to test it.

**What this PR does / why we need it**:
Disable dashboard test for GKE.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #61559

**Special notes for your reviewer**:

**Release note**:
```release-note
NONE
```

cc @mml @konryd
2018-03-29 15:03:08 -07:00
Kubernetes Submit Queue
0838c9e990 Merge pull request #61565 from Liujingfang1/issue61484
Automatic merge from submit-queue (batch tested with PRs 61904, 61565, 61401, 61432, 61772). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add retry to AssertCleanup

**What this PR does / why we need it**:
Add retry in AssertCleanup for e2e kubectl test to remove the flakeness

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #61484

**Special notes for your reviewer**:
This function is only used in e2e kubectl test. It doesn't affect other tests' behavior.

**Release note**:

```release-note
NONE
```
2018-03-29 11:46:12 -07:00
Filipe Brandenburger
76ef9c9074 Make systemd service name for kubelet use a timestamp in e2e-node tests.
This makes it easier to figure out which execution was last when looking
at the output of `systemd list-units kubelet-*.service`.

We try to find the name of the /tmp/node-e2e-* directory and use the
same timestamp if we can. Otherwise, we just call Now() again, which
isn't as nice (as the unit name and directory name will not match) but
will still produce unit names that will be ordered when launching
multiple subsequent executions on the same host.
2018-03-29 11:17:42 -07:00
Beata Skiba
896cf2180e Add e2e test for external metrics with Stackdriver
Rename the file to note that these are Stackdriver tests in anticipation of tests with fake custom metrics apiserver. Refactor the tests to be more structured.
2018-03-29 20:05:55 +02:00
Mikhail Mazurskiy
c23a8a85cc Use range in loops; misc fixes 2018-03-29 22:55:25 +11:00
Ryan Hitchman
137268d332 Deduplicate identical typecheck errors between platforms. 2018-03-28 19:42:48 -07:00
Kubernetes Submit Queue
3cb73605aa Merge pull request #61863 from satyasm/ipam-perf-cloud-mock
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Fix 61854, skip for short tests

**What this PR does / why we need it**:
Skip for short tests, so as to avoid running for every PR.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #61854

**Special notes for your reviewer**:

**Release note**:

```release-note
Disable ipamperf integration tests as part of every PR verification.
```
2018-03-28 17:57:59 -07:00
Barni S
42190c350e Adding integration tests for statefulset 2018-03-28 19:24:48 -04:00
Satyadeep Musuvathy
9d9a45893c Fix 61854, skip for short tests 2018-03-28 15:27:21 -07:00
Kubernetes Submit Queue
db8552dfed Merge pull request #56363 from hzxuzhonghu/test-opt
Automatic merge from submit-queue (batch tested with PRs 61848, 61188, 56363, 61357, 61838). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

reduce garbage_collector test cases running time

**What this PR does / why we need it**:
test cases in test\integration\garbagecollector\garbage_collector_test.go wait.Poll interval is too long. So the case running time is too long. 
**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
2018-03-28 13:52:10 -07:00
Kubernetes Submit Queue
f92ddc5dc5 Merge pull request #61188 from grayluck/affinity-test
Automatic merge from submit-queue (batch tested with PRs 61848, 61188, 56363, 61357, 61838). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Affinity test

**What this PR does / why we need it**:
Add e2e test for service session affinity, including all three types of services and externalTravicPolicy=Local.

**Which issue(s) this PR fixes**:
Fixes #55520



**Release note**:

```release-note
NONE
```
2018-03-28 13:52:07 -07:00
Jingfang Liu
eeda67232c Add retry to AssertCleanup 2018-03-28 13:32:21 -07:00
yankaiz
4655f52329 Add e2e test for service session affinity. 2018-03-28 10:54:19 -07:00